Re: [U-Boot] [PATCH v10 07/16] mips: Implement {in, out}_{le, be}_{16, 32, 64} and {in, out}_8

2018-10-09 Thread Stefan Roese
On 04.10.2018 09:00, Mario Six wrote: MIPS is the only architecture currently supported by U-Boot that does not implement any of the in/out register access functions. To have a interface that is useable across architectures, add the functions to the MIPS architecture (implemented using the

Re: [U-Boot] [PATCH v2 03/11] drivers: spi: cf_spi: migrate to DM and DT

2018-10-09 Thread Jagan Teki
On Wed, Oct 10, 2018 at 5:10 AM Angelo Dureghello wrote: > > Adding DM and DT support and removing old non-DM code. Commit head can be: spi: cf_spi: Convert to driver model > > Signed-off-by: Angelo Dureghello > --- > Changes for v2: > - removed non DM code part > - add default setup of CTAR

Re: [U-Boot] [PATCH 01/14] mips: Add in_le32(), out_le32() etc IO accessor functions

2018-10-09 Thread Stefan Roese
Hi Anatolij, On 09.10.2018 19:38, Anatolij Gustschin wrote: Hi Stefan, On Tue, 9 Oct 2018 08:59:03 +0200 Stefan Roese s...@denx.de wrote: in_le32() and out_le32() are needed for the bootcounter support. So lets implement these accessor functions for MIPS as well. Signed-off-by: Stefan

Re: [U-Boot] [PATCH v2 02/11] drivers: spi: cf_spi: add Kconfig option

2018-10-09 Thread Jagan Teki
On Wed, Oct 10, 2018 at 11:14 AM Angelo Dureghello wrote: > Commit message? > Signed-off-by: Angelo Dureghello > --- > Changes for v2: > - new patch > --- > drivers/spi/Kconfig | 18 -- > 1 file changed, 12 insertions(+), 6 deletions(-) > > diff --git a/drivers/spi/Kconfig

Re: [U-Boot] [PATCH v2 01/11] m68k: add basic set of devicetrees

2018-10-09 Thread Jagan Teki
On Wed, Oct 10, 2018 at 5:09 AM Angelo Dureghello wrote: > > This patch adds a basic group of devicetrees, one for each > cpu family, including actually just uart and dspi devices, > since these are the drivers supporting devicetree (support > added in this patch-set). I hope this is Linux DT

[U-Boot] [PATCH v2 09/11] configs: enable use of DT for all m68k boards

2018-10-09 Thread Angelo Dureghello
Enable DT usage for all m68k boards. To provide a working single binary, the dts has been kept as embedded. Signed-off-by: Angelo Dureghello --- Changes for v2: - new patch --- configs/M5208EVBE_defconfig | 2 ++ configs/M52277EVB_defconfig | 2 ++

[U-Boot] [PATCH v2 02/11] drivers: spi: cf_spi: add Kconfig option

2018-10-09 Thread Angelo Dureghello
Signed-off-by: Angelo Dureghello --- Changes for v2: - new patch --- drivers/spi/Kconfig | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig index 196767a3f6..6340453870 100644 --- a/drivers/spi/Kconfig +++

Re: [U-Boot] [PATCH v2 3/4] arm: socfpga: stratix10: Add Stratix10 FPGA into FPGA device table

2018-10-09 Thread Ang, Chee Hong
On Tue, 2018-10-09 at 14:48 +0200, Marek Vasut wrote: > On 10/09/2018 05:03 AM, Ang, Chee Hong wrote: > > > > On Mon, 2018-10-08 at 22:32 +0200, Marek Vasut wrote: > > > > > > On 10/08/2018 05:10 PM, Ang, Chee Hong wrote: > > > > > > > > > > > > On Mon, 2018-10-08 at 11:57 +0200, Marek Vasut

Re: [U-Boot] [PATCH v3 2/6] driver: net: fsl-mc: remove unused strcture elements

2018-10-09 Thread Pankaj Bansal
Hi Joe, > -Original Message- > From: Joe Hershberger [mailto:joe.hershber...@ni.com] > Sent: Wednesday, October 10, 2018 9:29 AM > To: Pankaj Bansal > Cc: Joseph Hershberger ; u-boot b...@lists.denx.de> > Subject: Re: [U-Boot] [PATCH v3 2/6] driver: net: fsl-mc: remove unused > strcture

[U-Boot] [PATCH v4] arm: socfpga: fix SPL booting from fpga OnChip RAM

2018-10-09 Thread Simon Goldschmidt
This patch prevents disabling the FPGA bridges when SPL or U-Boot is executed from FPGA onchip RAM. Signed-off-by: Simon Goldschmidt --- Changes in v4: - use an inline function in misc.h to check for the address range instead of a macro in base_addr_ac5.h Changes in v3: - use

Re: [U-Boot] [PATCH v3 2/6] driver: net: fsl-mc: remove unused strcture elements

2018-10-09 Thread Joe Hershberger
On Tue, Oct 9, 2018 at 9:59 PM Pankaj Bansal wrote: > > The phydev structure is present in both ldpaa_eth_priv and > wriop_dpmac_info. the phydev in wriop_dpmac_info is not being used > > As the phydev is created based on phy_addr and bus members of > wriop_dpmac_info, it is appropriate to keep

[U-Boot] [PATCH v1] armv8: lx2160a: add some minor fixes on esdhc node

2018-10-09 Thread Yinbo Zhu
The esdhc node has some minor fixes according to the RM document. Signed-off-by: Yinbo Zhu --- arch/arm/dts/fsl-lx2160a.dtsi | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/arch/arm/dts/fsl-lx2160a.dtsi b/arch/arm/dts/fsl-lx2160a.dtsi index 73c24f7..8c8172b

[U-Boot] [PATCH v1] configs: lx2160a: enable driver model for eSDHC

2018-10-09 Thread Yinbo Zhu
Enable driver model for eSDHC on lx2160a rdb board. Signed-off-by: Yinbo Zhu --- configs/lx2160ardb_defconfig |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/configs/lx2160ardb_defconfig b/configs/lx2160ardb_defconfig index bc16085..3d577fc 100644 ---

[U-Boot] [PATCH v1] armv8: lx2160a: add eSDHC nodes

2018-10-09 Thread Yinbo Zhu
This patch is to add eSDHC nodes for lx2160a. Signed-off-by: Yinbo Zhu --- arch/arm/dts/fsl-lx2160a-rdb.dts |8 arch/arm/dts/fsl-lx2160a.dtsi| 24 2 files changed, 32 insertions(+), 0 deletions(-) diff --git a/arch/arm/dts/fsl-lx2160a-rdb.dts

[U-Boot] [PATCH v3 5/6] driver: net: fsl-mc: initialize dpmac irrespective of phy

2018-10-09 Thread Pankaj Bansal
The dpmac initalization should not depend on phy. As the phy is not necessary to be present for dpmac to function. Therefore, remove dpmac initialization dependency from phy. Signed-off-by: Pankaj Bansal Acked-by: Joe Hershberger --- Notes: V3: - No change V2: - No Change

[U-Boot] [PATCH v3 6/6] driver: net: fsl-mc: Add support of multiple phys for dpmac

2018-10-09 Thread Pankaj Bansal
Till now we have had cases where we had one phy device per dpmac. Now, with the upcoming products (LX2160AQDS), we have cases, where there are sometimes two phy devices for one dpmac. One phy for TX lanes and one phy for RX lanes. to handle such cases, add the support for multiple phys in ethernet

[U-Boot] [PATCH v3 3/6] driver: net: fsl-mc: fix error handing in init_phy

2018-10-09 Thread Pankaj Bansal
if an error occurs during init_phy, we should free the phydev structure which has been allocated by phy_connect. Signed-off-by: Pankaj Bansal Acked-by: Joe Hershberger --- Notes: V3: - No change V2: - after free phydev just pass NULL into wriop_set_phy_dev()

[U-Boot] [PATCH v3 4/6] driver: net: fsl-mc: Modify the dpmac link detection method

2018-10-09 Thread Pankaj Bansal
when there is no phy present for a dpmac, a dummy phy device is created. when we move to multiple phy method, we need to create as many dummy phy devices. Change this method so that we don't need to create dummy phy devices. We always report linkup if no phy is present. Signed-off-by: Pankaj

[U-Boot] [PATCH v3 2/6] driver: net: fsl-mc: remove unused strcture elements

2018-10-09 Thread Pankaj Bansal
The phydev structure is present in both ldpaa_eth_priv and wriop_dpmac_info. the phydev in wriop_dpmac_info is not being used As the phydev is created based on phy_addr and bus members of wriop_dpmac_info, it is appropriate to keep phydev in wriop_dpmac_info. Also phy_regs is not being used,

[U-Boot] [PATCH v3 1/6] driver: net: fsl-mc: modify the label name

2018-10-09 Thread Pankaj Bansal
The goto label name is misspelled it should be DPMAC not DPAMC Signed-off-by: Pankaj Bansal Acked-by: Joe Hershberger --- Notes: V3: - No change V2: - No change drivers/net/ldpaa_eth/ldpaa_eth.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[U-Boot] [PATCH v3 0/6] driver: net: fsl-mc: Add support of multiple phys for dpmac

2018-10-09 Thread Pankaj Bansal
This patch set adds support of multiple phys for one dpmac Till now we have had cases where we had one phy device per dpmac. Now, with the upcoming products (LX2160AQDS), we have cases, where there are sometimes two phy devices for one dpmac. One phy for TX lanes and one phy for RX lanes. To

Re: [U-Boot] Please pull u-boot-dm

2018-10-09 Thread Simon Glass
Hi Tom, On 9 October 2018 at 18:24, Simon Glass wrote: > > Hi Tom, > > Here is my attempt at a signed pull request. I've brought in most of the > outstanding dm patches. Please let me know if it looks OK. Do you have my > public key? > Build result here:

Re: [U-Boot] [PATCH v2 6/6] driver: net: fsl-mc: Add support of multiple phys for dpmac

2018-10-09 Thread Pankaj Bansal
> -Original Message- > From: Joe Hershberger [mailto:joe.hershber...@ni.com] > Sent: Wednesday, October 10, 2018 3:02 AM > To: Pankaj Bansal > Cc: u-boot ; Joseph Hershberger > ; Priyanka Jain ; > Varun Sethi > Subject: Re: [U-Boot] [PATCH v2 6/6] driver: net: fsl-mc: Add support of >

[U-Boot] [PATCH v3 6/6] driver: net: fsl-mc: Add support of multiple phys for dpmac

2018-10-09 Thread Pankaj Bansal
Till now we have had cases where we had one phy device per dpmac. Now, with the upcoming products (LX2160AQDS), we have cases, where there are sometimes two phy devices for one dpmac. One phy for TX lanes and one phy for RX lanes. to handle such cases, add the support for multiple phys in ethernet

[U-Boot] [PATCH v3 5/6] driver: net: fsl-mc: initialize dpmac irrespective of phy

2018-10-09 Thread Pankaj Bansal
The dpmac initalization should not depend on phy. As the phy is not necessary to be present for dpmac to function. Therefore, remove dpmac initialization dependency from phy. Signed-off-by: Pankaj Bansal Acked-by: Joe Hershberger --- Notes: V3: - No change V2: - No Change

[U-Boot] [PATCH v3 4/6] driver: net: fsl-mc: Modify the dpmac link detection method

2018-10-09 Thread Pankaj Bansal
when there is no phy present for a dpmac, a dummy phy device is created. when we move to multiple phy method, we need to create as many dummy phy devices. Change this method so that we don't need to create dummy phy devices. We always report linkup if no phy is present. Signed-off-by: Pankaj

[U-Boot] [PATCH v3 2/6] driver: net: fsl-mc: remove unused strcture elements

2018-10-09 Thread Pankaj Bansal
The phydev structure is present in both ldpaa_eth_priv and wriop_dpmac_info. the phydev in wriop_dpmac_info is not being used As the phydev is created based on phy_addr and bus members of wriop_dpmac_info, it is appropriate to keep phydev in wriop_dpmac_info. Also phy_regs is not being used,

[U-Boot] [PATCH v3 3/6] driver: net: fsl-mc: fix error handing in init_phy

2018-10-09 Thread Pankaj Bansal
if an error occurs during init_phy, we should free the phydev structure which has been allocated by phy_connect. Signed-off-by: Pankaj Bansal Acked-by: Joe Hershberger --- Notes: V3: - No change V2: - after free phydev just pass NULL into wriop_set_phy_dev()

[U-Boot] [PATCH v3 1/6] driver: net: fsl-mc: modify the label name

2018-10-09 Thread Pankaj Bansal
The goto label name is misspelled it should be DPMAC not DPAMC Signed-off-by: Pankaj Bansal Acked-by: Joe Hershberger --- Notes: V3: - No change V2: - No change drivers/net/ldpaa_eth/ldpaa_eth.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[U-Boot] [PATCH v3 0/6] driver: net: fsl-mc: Add support of multiple phys for dpmac

2018-10-09 Thread Pankaj Bansal
This patch set adds support of multiple phys for one dpmac Till now we have had cases where we had one phy device per dpmac. Now, with the upcoming products (LX2160AQDS), we have cases, where there are sometimes two phy devices for one dpmac. One phy for TX lanes and one phy for RX lanes. To

Re: [U-Boot] [PATCH 1/2] mmc: tmio: Pass full address to tmio_sd_addr_is_dmaable()

2018-10-09 Thread Masahiro Yamada
On Wed, Oct 10, 2018 at 1:17 AM Marek Vasut wrote: > > On 10/09/2018 05:35 PM, Masahiro Yamada wrote: > > On Tue, Oct 9, 2018 at 11:55 PM Marek Vasut wrote: > >> > >> On 10/09/2018 02:24 PM, Masahiro Yamada wrote: > >>> Hi Marek, > >> > >> Hi, > >> > >>> On Tue, Oct 9, 2018 at 8:26 PM Marek

Re: [U-Boot] [PATCH 1/1] efi_loader: set image_base and image_size to correct values

2018-10-09 Thread AKASHI Takahiro
# This discussion should be in ML as more people can join? On Tue, Oct 09, 2018 at 07:25:47PM +0200, Heinrich Schuchardt wrote: > On 10/09/2018 08:55 AM, AKASHI Takahiro wrote: > > On Sat, Oct 06, 2018 at 09:51:01AM +0200, Heinrich Schuchardt wrote: > >> On 09/30/2018 07:26 AM, Heinrich

[U-Boot] [PATCH 4/7] doc: imx: Reorganize i.MX SoC common documentation

2018-10-09 Thread Breno Matheus Lima
The following documents describe device details according to the i.MX family: - README.imx25 - README.imx27 - README.imx5 - README.imx6 - README.mxs Move all device common related document to doc/imx/common for a better directory structure. Signed-off-by: Breno Lima --- doc/imx/{ =>

Re: [U-Boot] [PATCH 02/11] efi_loader: Initial HII protocols

2018-10-09 Thread AKASHI, Takahiro
Heinrich, On Tue, Oct 09, 2018 at 07:19:58PM +0200, Heinrich Schuchardt wrote: > On 10/09/2018 09:24 AM, AKASHI, Takahiro wrote: > > Do you have any specific idea about what is really missing > > in Leif's/Rob's HII patch? > > (My original question.) > > > > -Takahiro Akashi > > Please, see

[U-Boot] [PATCH 1/7] doc: imx: reorganize i.MX documentation

2018-10-09 Thread Breno Matheus Lima
Currently the U-Boot doc/ directory contains the following files that are only relevant for i.MX devices: - doc/README.imx25 - doc/README.imx27 - doc/README.imx5 - doc/README.imx6 - doc/README.imximage - doc/README.mxc_hab - doc/README.mxs - doc/README.mxsimage - doc/README.sdp Move all content

[U-Boot] [PATCH 6/7] doc: imx: misc: Reorganize miscellaneous documentation

2018-10-09 Thread Breno Matheus Lima
The Serial Download Protocol feature is availible in various i.MX SoCs. Move README.sdp document to imx/misc directory. Signed-off-by: Breno Lima --- doc/imx/{ => misc}/README.sdp | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename doc/imx/{ => misc}/README.sdp (100%) diff --git

[U-Boot] [PATCH 2/7] doc: imx: Move SPD related info to the appropriate doc

2018-10-09 Thread Breno Matheus Lima
Currently the Serial Download Protocol tools and procedure are documented in two places: - doc/imx/README.sdp - doc/imx/README.imx6 It is better to consolidate all SDP related information into README.sdp file, so move the content from README.imx6 to README.sdp. Signed-off-by: Breno Lima ---

[U-Boot] [PATCH 5/7] doc: imx: hab: Reorganize High Assurance Boot documentation

2018-10-09 Thread Breno Matheus Lima
The current High Assurance Boot document README.mxc_hab include details for the following features in a single file: - HAB Secure Boot - HAB Encrypted Boot Split HAB documentation in a specific directory for a cleaner documentation structure, subsequent patches will include more content in HAB

[U-Boot] [PATCH v2 05/11] drivers: serial: mcfuart: add Kconfig option

2018-10-09 Thread Angelo Dureghello
This patch adds missing CONFIG_MCFUART to Kconfig. Signed-off-by: Angelo Dureghello --- Changes for v2: - better Kconfig help --- drivers/serial/Kconfig | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig index 5fa27254e3..56dbfd5759

Re: [U-Boot] [PATCH v2 16/17] test: Reduce the number of tests run with sandbox_flattree

2018-10-09 Thread sjg
We only need to run driver-model tests with this config, since this is the only thing that is different when CONFIG_OF_LIVE is not defined. Filter out the other tests to same time. Signed-off-by: Simon Glass --- Changes in v2: - Add new patch to reduce the number of tests run with

Re: [U-Boot] [PATCH v2 15/17] patman: Don't clear progress in tout unless it was used

2018-10-09 Thread sjg
At present calling Uninit() always called ClearProgress() which outputs a \r character as well as spaces to remove any progress information on the line. This can mess up the normal output of binman and other tools. Fix this by outputing this only when progress information has actually been

[U-Boot] [PATCH 7/7] doc: imx: Improve i.MX documentation naming

2018-10-09 Thread Breno Matheus Lima
There is no need to have README in all i.MX documents name. Remove README from i.MX docs name and add .txt file extension. Signed-off-by: Breno Lima Reviewed-by: Ye Li --- doc/imx/common/{README.imx25 => imx25.txt}| 0 doc/imx/common/{README.imx27 => imx27.txt}| 0

[U-Boot] [PATCH 0/7] Restructure the i.MX U-Boot documentation

2018-10-09 Thread Breno Matheus Lima
This patch set is restructuring and cleaning up the current i.MX documentation included in the U-Boot doc directory. The current i.MX documentation is in the root directory so we cannot easily check which one is i.MX related: http://git.denx.de/?p=u-boot/u-boot-imx.git;a=tree;f=doc; This series

[U-Boot] [PATCH v2 04/11] drivers: serial: mcfuart: add DT support

2018-10-09 Thread Angelo Dureghello
This patch adds devicetree support to the mcfuart.c driver and removes non DM code. Signed-off-by: Angelo Dureghello --- Changes for v2: - remove non DM code --- drivers/serial/mcfuart.c | 106 +++ 1 file changed, 28 insertions(+), 78 deletions(-) diff --git

Re: [U-Boot] [PATCH 06/45] spl: input: Allow input in SPL and TPL

2018-10-09 Thread sjg
In some cases it is necessary to read the keyboard in early phases of U-Boot. Update the config to allow this. Signed-off-by: Simon Glass --- drivers/input/Kconfig | 48 ++ drivers/input/Makefile | 11 ++ drivers/input/input.c | 5 - 3

Re: [U-Boot] [PATCH v2 06/17] Makefile: Add a 'check' target for make

2018-10-09 Thread sjg
At present we use 'make tests' to run the tests. For many projects 'make check' is more common, so support that as well. Also add some help to 'make help'. Signed-off-by: Simon Glass --- Changes in v2: None Makefile | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) Applied to

Re: [U-Boot] [PATCH v2 14/17] tools: Set an initial value for indir

2018-10-09 Thread sjg
This variable is not documented or set up in the module. Fix this. Signed-off-by: Simon Glass --- Changes in v2: None tools/patman/tools.py | 3 +++ 1 file changed, 3 insertions(+) Applied to u-boot-dm ___ U-Boot mailing list U-Boot@lists.denx.de

Re: [U-Boot] [PATCH 01/45] dm: core: Alloc uclass-private data to be cache-aligned

2018-10-09 Thread sjg
There is no reason why this feature should not be supported for uclass- private data. Update the code accordingly. Signed-off-by: Simon Glass --- drivers/core/device.c | 3 ++- include/dm/uclass.h | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) Applied to u-boot-dm

Re: [U-Boot] [PATCH v2 13/17] buildman: dtoc: Suppress unwanted output from test

2018-10-09 Thread sjg
There are a few test cases which print output. Suppress this so that tests can run silently in the normal case. Signed-off-by: Simon Glass --- Changes in v2: None tools/buildman/test.py | 4 +++- tools/dtoc/test_dtoc.py | 6 -- 2 files changed, 7 insertions(+), 3 deletions(-) Applied to

[U-Boot] [PATCH 3/7] doc: imx: mkimage: reorganize i.MX mkimage documentation

2018-10-09 Thread Breno Matheus Lima
The following documents describe the image type used by the mkimage tool to generate U-Boot images for i.MX devices. - README.imximage - README.mxsimage Move all mkimage related document to doc/imx/mkimage for a better directory structure. Signed-off-by: Breno Lima --- doc/imx/{ =>

Re: [U-Boot] [PATCH v2 01/17] test/py: ignore console read exceptions after test failure

2018-10-09 Thread sjg
Hi Stephen, On 4 October 2018 at 10:01, Stephen Warren wrote: > On 10/01/2018 09:12 PM, Simon Glass wrote: >> >> From: Stephen Warren >> >> After a test has failed, test/py drains the U-Boot console log to ensure >> that any relevant output is captured. At this point, we don't care about >>

Re: [U-Boot] [PATCH 18/45] cros: Update cros_ec code to use struct udevice

2018-10-09 Thread sjg
At present we pass around a private pointer to specify the cros_ec device. With driver model it makes more sense to pass the device. Update the code to do this. Signed-off-by: Simon Glass --- cmd/cros_ec.c | 24 +++--- drivers/misc/cros_ec.c | 147

[U-Boot] [PATCH v2 07/11] m68k: add initial dts files for all m68k boards

2018-10-09 Thread Angelo Dureghello
This patch adds basic dts files for all the m68k boards. Signed-off-by: Angelo Dureghello --- Changes for v2: - new patch --- arch/m68k/dts/M5208EVBE.dts | 22 +++ arch/m68k/dts/M52277EVB.dts | 25 arch/m68k/dts/M52277EVB_stmicro.dts |

Re: [U-Boot] [PATCH 11/45] rtc: Allow use of RTC in SPL and TPL

2018-10-09 Thread sjg
Add Kconfig options so that the RTC can be used in SPL and TPL. This is helpful for accessing the contents of CMOS RAM, for example. Signed-off-by: Simon Glass --- drivers/rtc/Kconfig | 18 ++ drivers/rtc/Makefile | 2 +- drivers/rtc/rtc-uclass.c | 1 + 3 files

Re: [U-Boot] [PATCH 12/45] fdt: Document the fact that dtc is now built

2018-10-09 Thread sjg
This documentation is out of date now that U-Boot builds dtc automatically. Update it. Signed-off-by: Simon Glass --- doc/README.fdt-control | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) Applied to u-boot-dm ___ U-Boot mailing list

Re: [U-Boot] [PATCH v2 08/17] test: Print the name of each test before running it

2018-10-09 Thread sjg
At present the tests are run without any indication of what is running. For the tests which start with a build this is pretty obvious, but for tools it is not. Add a name for each test we run, and print it before starting the test. Signed-off-by: Simon Glass --- Changes in v2: - Quote @$

Re: [U-Boot] [PATCH 05/45] sf: Avoid allocating memory on every read operation

2018-10-09 Thread sjg
At present spi_flash_cmd_read_ops() allocates and frees a few bytes of memory every time it is called. It is faster to use the stack for this and this is now supported by the minimum GCC version required by U-Boot. Remove the allocation and use a variable-sized array instead. Signed-off-by:

Re: [U-Boot] [PATCH v2 05/17] buildman: Make the toolchain test more forgiving

2018-10-09 Thread sjg
The filenames of the toolchains on kernel.org changes every now and then. Fix it for the current change, and make the test use a regex so that it has a better chance of passing with future changes too. Signed-off-by: Simon Glass --- Changes in v2: None tools/buildman/test.py | 6 -- 1

Re: [U-Boot] [PATCH 20/45] dm: spi: Add logging of some return values

2018-10-09 Thread sjg
When SPI flash operations fail it is helpful to be able to see the error codes and where they are generated. Add logging to capture this information for read operations. Signed-off-by: Simon Glass --- drivers/mtd/spi/sf-uclass.c | 6 +++--- drivers/mtd/spi/sf_probe.c | 2 +-

Re: [U-Boot] [PATCH v2 09/17] test: Tidy up comments and variable name

2018-10-09 Thread sjg
The 'result' variable counts the number of failures in running the tests. Rename it to 'failures' to make this more obvious. Also tidy up a few comments. Signed-off-by: Simon Glass --- Changes in v2: None test/run | 12 1 file changed, 8 insertions(+), 4 deletions(-) Applied to

Re: [U-Boot] [PATCH v2 02/17] sandbox: Unprotect DATA regions in bus tests

2018-10-09 Thread sjg
On my Ubuntu 18.04.1 machine two driver-model bus tests have started failing recently. The problem appears to be that the DATA region of the executable is protected. This does not seem correct, but perhaps there is a reason. To work around it, unprotect the regions in these tests before accessing

Re: [U-Boot] [PATCH 33/45] x86: Update mtrr functions to allow leaving cache alone

2018-10-09 Thread sjg
On Tue, Oct 2, 2018 at 2:24 AM Simon Glass wrote: > > At present the mtrr functions disable the cache before making changes and > enable it again afterwards. This is fine in U-Boot, but does not work if > running in CAR (such as we are in SPL). > > Update the functions so that the caller can

Re: [U-Boot] [PATCH 43/45] video: at91: Adjust vidconsole_position_cursor() to use char pos

2018-10-09 Thread sjg
On 09.10.2018 06:40, Simon Glass wrote: > Hi Eugen, > > On 2 October 2018 at 01:37, Eugen Hristev wrote: >> >> >> >> On 01.10.2018 23:22, Anatolij Gustschin wrote: >>> >>> Hi Simon, >>> >>> On Mon, 1 Oct 2018 12:22:47 -0600 >>> Simon Glass s...@chromium.org wrote: >>> At present this

Re: [U-Boot] bootefi selftest on qemu-x86_64

2018-10-09 Thread Bin Meng
Hi Heinrich, On Wed, Oct 10, 2018 at 12:48 AM Heinrich Schuchardt wrote: > > On 10/09/2018 11:27 AM, Bin Meng wrote: > > Hi Heinrich, > > > > Did you ever get 'bootefi selftest' pass on qemu-x86_64? I got: > > > > => bootefi selftest > > WARNING: booting without device tree > >

Re: [U-Boot] [PATCH v2 03/17] patman: Handle unicode in _ProjectConfigParser tests

2018-10-09 Thread sjg
With Python 2.7.15rc1, ConfigParser.SafeConfigParser has unfortunately started returning unicode, for unknown reasons. Adjust the code to handle this by converting everything to unicode. We cannot convert things to ASCII since email addresses may be encoded with UTF-8. Signed-off-by: Simon Glass

Re: [U-Boot] [PATCH 35/45] cros_ec: Add support for v3 messages on LPC

2018-10-09 Thread sjg
At present version 3 messages are only supported on SPI. Add support for using LPC as well, as used on samus. Signed-off-by: Simon Glass --- drivers/misc/cros_ec_lpc.c | 33 + 1 file changed, 33 insertions(+) Applied to u-boot-dm

Re: [U-Boot] [PATCH 10/45] Kconfig: Convert CONFIG_RTC_MC146818 to Kconfig

2018-10-09 Thread sjg
Move this option to Kconfig and tidy up the two boards which use it. Signed-off-by: Simon Glass --- configs/edison_defconfig | 1 + configs/malta_defconfig | 1 + drivers/rtc/Kconfig | 8 include/configs/edison.h | 1 - include/configs/malta.h | 1 -

Re: [U-Boot] [PATCH v2 10/17] binman: Add a default path to libfdt.py

2018-10-09 Thread sjg
This module is often available in the sandbox_spl build created by 'make check'. Use this as a default path so that just typing 'binman -t' (without setting PYTHONPATH) will generally run the tests. Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/binman.py | 2 ++

Re: [U-Boot] [PATCH 24/45] tpm: Tidy up logging in tpm-common.c

2018-10-09 Thread sjg
At present this file uses logging but it should use the new macros. Update it and add a log message for an error. Signed-off-by: Simon Glass --- lib/tpm-common.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) Applied to u-boot-dm

Re: [U-Boot] [PATCH 26/45] binman: Move to three-digit test-file numbers

2018-10-09 Thread sjg
We now have 99 tests. Before adding any more, rename everything to three digits. This helps to preserve the ordering of tests and makes it easier to find things. Signed-off-by: Simon Glass --- tools/binman/entry_test.py| 2 +- tools/binman/fdt_test.py

Re: [U-Boot] [PATCH 14/45] fdt: Allow indicating a node is for U-Boot proper only

2018-10-09 Thread sjg
At present it is not possible to specify that a node should be used before relocation (in U-Boot proper) without it also ending up in SPL and TPL device trees. Add a new "u-boot,dm-pre-proper" boolean property for this. Signed-off-by: Simon Glass --- doc/driver-model/README.txt | 4 +++-

[U-Boot] Please pull u-boot-dm

2018-10-09 Thread Simon Glass
Hi Tom, Here is my attempt at a signed pull request. I've brought in most of the outstanding dm patches. Please let me know if it looks OK. Do you have my public key? The following changes since commit 0a60a81ba3860946551cb79aa6486aa076e357f3: Kconfig: sandbox: enable cmd_avb and

Re: [U-Boot] bootefi selftest on qemu-x86_64

2018-10-09 Thread Bin Meng
Hi Heinrich, On Wed, Oct 10, 2018 at 7:56 AM Bin Meng wrote: > > Hi Heinrich, > > On Wed, Oct 10, 2018 at 12:48 AM Heinrich Schuchardt > wrote: > > > > On 10/09/2018 11:27 AM, Bin Meng wrote: > > > Hi Heinrich, > > > > > > Did you ever get 'bootefi selftest' pass on qemu-x86_64? I got: > > > >

Re: [U-Boot] [PATCH 15/45] tpm: Add support for SPL and TPL

2018-10-09 Thread sjg
At present the tpm can only be used in U-Boot proper. Updated it to work in SPL and TPL also. Signed-off-by: Simon Glass --- drivers/tpm/Makefile | 2 +- lib/Kconfig | 22 ++ lib/Makefile | 10 +++--- 3 files changed, 30 insertions(+), 4 deletions(-)

Re: [U-Boot] [PATCH v2 12/17] binman: Separate out testSplBssPad()

2018-10-09 Thread sjg
At present this test runs binman twice, which means that the temporary files from the first run do not get cleaned up. Split this into two tests to fix this problem. Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/ftest.py | 4 +++- 1 file changed, 3 insertions(+), 1

Re: [U-Boot] [PATCH 39/45] fdt: Allow C++ comments in link scripts and DT files

2018-10-09 Thread sjg
At present // in a device-tree file or link script causes a warning. But this is used in the standard license header. Update the compiler flags to use C99, which permits this. Signed-off-by: Simon Glass --- Makefile | 2 +- scripts/Makefile.spl | 2 +- 2 files changed, 2

Re: [U-Boot] [PATCH 22/45] video: Adjust video_clear() to return an error

2018-10-09 Thread sjg
On Mon, 1 Oct 2018 12:22:26 -0600 Simon Glass s...@chromium.org wrote: > All driver-model operation should return an error code. Adjust this > function to do so also. > > Signed-off-by: Simon Glass Reviewed-by: Anatolij Gustschin -- Anatolij Applied to u-boot-dm

Re: [U-Boot] [PATCH v2 17/17] binman: Run tests concurrently

2018-10-09 Thread sjg
At present the tests run one after the other using a single CPU. This is not very efficient. Bring in the concurrencytest module and run the tests concurrently, using one process for each CPU by default. A -P option allows this to be overridden, which is necessary for code-coverage to function

Re: [U-Boot] [PATCH 19/45] cros: Adjust board_get_cros_ec_dev() to return a udevice

2018-10-09 Thread sjg
Rather than returning what is effectively an internal data structure, return the cros EC device itself. Signed-off-by: Simon Glass --- common/cros_ec.c | 4 ++-- include/cros_ec.h | 4 +--- 2 files changed, 3 insertions(+), 5 deletions(-) Applied to u-boot-dm

Re: [U-Boot] [PATCH 13/45] doc: Update docs for device tree in SPL, TPL

2018-10-09 Thread sjg
Make a few small updates to indicate that device tree can be used in SPL and TPL. Signed-off-by: Simon Glass --- doc/README.fdt-control | 10 ++ doc/driver-model/README.txt | 3 ++- 2 files changed, 12 insertions(+), 1 deletion(-) Applied to u-boot-dm

Re: [U-Boot] [PATCH 17/45] fdt: Allow libfdt in TPL

2018-10-09 Thread sjg
In some cases (e.g. sandbox with verified boot) it is useful to support libfdt in TPL. Update the Kconfig to handle this. Signed-off-by: Simon Glass --- lib/Kconfig | 10 ++ 1 file changed, 10 insertions(+) Applied to u-boot-dm ___ U-Boot

Re: [U-Boot] [PATCH 29/45] malloc_simple: Add logging of allocations

2018-10-09 Thread sjg
It is sometimes useful to see what memory is being allocated early during boot. Add logging to support this, using a new LOGC_ALLOC category. Signed-off-by: Simon Glass --- common/malloc_simple.c | 58 +++--- include/malloc.h | 1 + 2 files changed,

Re: [U-Boot] [PATCH 03/45] dm: core: Add a function to find the first inactive child

2018-10-09 Thread sjg
Some devices have children and want to press an existing inactive child into service when needed. Add a function to help with this. Signed-off-by: Simon Glass --- drivers/core/device.c | 18 ++ include/dm/device.h | 15 +++ test/dm/core.c| 31

Re: [U-Boot] [PATCH 37/45] panel: Expand the backlight support

2018-10-09 Thread sjg
At present the panel can be turned on but not off, and the brightness cannot be controlled at run-time. Add a new API function to both the panel and backlight uclasses to handle this. Enhance the PWM backlight driver to deal with custom levels properly and allow the backlight to be turned on and

Re: [U-Boot] [PATCH 27/45] binman: Add a test for Intel reference code

2018-10-09 Thread sjg
Unfortunately the test was not included in the original implementation. Add one. Signed-off-by: Simon Glass --- tools/binman/ftest.py | 7 +++ tools/binman/test/100_intel_refcode.dts | 14 ++ 2 files changed, 21 insertions(+) create mode 100644

Re: [U-Boot] [PATCH 16/45] serial: Allow serial to be absent in TPL

2018-10-09 Thread sjg
At present this option applies to SPL, but it should be available in TPL also, and separately. Change to using CONFIG_IS_ENABLED(), add a new Kconfig option and fix up hang(). Signed-off-by: Simon Glass --- drivers/serial/Kconfig | 10 ++ drivers/serial/serial-uclass.c | 4

Re: [U-Boot] [PATCH 30/45] Add a header file for strings

2018-10-09 Thread sjg
Add a string.h header for libraries that expect this to be available, now that U-Boot's version has moved to include/linux. Signed-off-by: Simon Glass --- include/string.h | 1 + 1 file changed, 1 insertion(+) create mode 100644 include/string.h Applied to u-boot-dm

Re: [U-Boot] [PATCH 40/45] pci: Add a little more debugging to pci_rom

2018-10-09 Thread sjg
On Tue, Oct 2, 2018 at 2:48 AM Simon Glass wrote: > > Add some logging on failure. > > Signed-off-by: Simon Glass > --- > > drivers/pci/pci_rom.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Bin Meng Applied to u-boot-dm

Re: [U-Boot] [PATCH 25/45] tpm: Add a few new commands for v1

2018-10-09 Thread sjg
These are needed for the 2018 version of Chromium OS vboot. Add an implementation for TPM v1, with v2 to come later. Signed-off-by: Simon Glass --- cmd/tpm_test.c | 15 --- include/tpm-v1.h | 28 lib/tpm-v1.c | 68

Re: [U-Boot] [PATCH 09/45] blk: Support block drivers in TPL

2018-10-09 Thread sjg
At present it is not possible to enable/disable block drivers in TPL. This is needed to provide sandbox support. Add a Kconfig option and adjust the Makefile. Signed-off-by: Simon Glass --- drivers/block/Kconfig | 12 drivers/block/Makefile | 2 +- 2 files changed, 13

Re: [U-Boot] [PATCH 38/45] ctags: Minor changes to fix ctags output

2018-10-09 Thread sjg
At present ctags emits lines with unmatched quotes which means that the output file is invalid. This is with exuberant-ctags version 5.9~svn201103 but I also see it with plain ctags. I am not sure that it is a bug though. Make a few minor changes in the source code to fix this problem.

Re: [U-Boot] [PATCH v2 07/17] test: Simplify the PATH setup

2018-10-09 Thread sjg
Use 'export' to avoid repeating the path setup for each command. Signed-off-by: Simon Glass --- Changes in v2: None test/run | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) Applied to u-boot-dm ___ U-Boot mailing list

Re: [U-Boot] [PATCH 45/45] dtoc: Fix the value of SetInt()

2018-10-09 Thread sjg
This does not set the correct value at present. Fix it. Signed-off-by: Simon Glass --- tools/dtoc/fdt.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied to u-boot-dm ___ U-Boot mailing list U-Boot@lists.denx.de

Re: [U-Boot] [PATCH v2 11/17] binman: Fix up removal of temporary directories

2018-10-09 Thread sjg
At present 'make check' leaves some temporary directories around. Part of this is because we call tools.PrepareOutputDir() twice in some cases, without calling tools.FinaliseOutputDir() in between. Fix this. Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/elf_test.py | 5

Re: [U-Boot] [PATCH 02/45] dm: core: Update some functions to use const

2018-10-09 Thread sjg
Quite a few functions do not actually modify the device that is passed in. Update the function signatures to reflect that. Signed-off-by: Simon Glass --- drivers/core/device.c | 24 include/dm/device.h | 24 2 files changed, 24 insertions(+),

Re: [U-Boot] [PATCH 02/15] sandbox: Support file truncation with os_open()

2018-10-09 Thread sjg
At present files are not truncated on writing. This is a useful feature. Add support for this. Signed-off-by: Simon Glass --- arch/sandbox/cpu/os.c | 2 ++ include/os.h | 1 + 2 files changed, 3 insertions(+) Applied to u-boot-dm ___ U-Boot

Re: [U-Boot] [PATCH v2 04/17] test/py: Fix unicode handling for log filtering

2018-10-09 Thread sjg
On 2.10.2018 05:12, Simon Glass wrote: > At present the unicode filtering seems to get confused at times with > this error: > > UnicodeDecodeError: 'ascii' codec can't decode byte 0x80 in position > 32: ordinal not in range(128) > > It seems to be due to self._nonprint being interpreted as

Re: [U-Boot] [PATCH 41/45] sysreset: Tidy up a few comments and logging

2018-10-09 Thread sjg
Some comments are incorrect or missing pieces. Fix these and use logging to print the error. Signed-off-by: Simon Glass --- drivers/sysreset/sysreset-uclass.c | 4 +++- include/sysreset.h | 4 +++- test/dm/sysreset.c | 1 - 3 files changed, 6 insertions(+), 3

Re: [U-Boot] [PATCH 11/15] serial: sandbox: Allow serial output without device tree

2018-10-09 Thread sjg
At present sandbox assumes that device-tree control is active, but this may not be the case in SPL or TPL. Add some conditions to handle this. Signed-off-by: Simon Glass --- drivers/serial/sandbox.c | 5 + 1 file changed, 5 insertions(+) Applied to u-boot-dm

Re: [U-Boot] [PATCH 28/45] log: Add comments to the rest of the log categories

2018-10-09 Thread sjg
At present some of the log categories are missing comments. Add them. Signed-off-by: Simon Glass --- include/log.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) Applied to u-boot-dm ___ U-Boot mailing list U-Boot@lists.denx.de

  1   2   3   >