[U-Boot] Moving GRUB building to Gitlab CI

2019-07-17 Thread Heinrich Schuchardt
Hello Tom, as discussed on IRC it would make sense to provide GRUB for testing in U-Boot via gitlab.denx.de. Building could be executed via Gitlab CI. These are the build commands that worked for me to build GRUB for RISC-V 64bit on Debian Buster after installing quite a few dependencies: git

Re: [U-Boot] [PATCH v6 0/4] SiFive SPI MMC Support

2019-07-17 Thread Sagar Kadam
Hi, On Wed, Jul 17, 2019 at 9:54 AM Anup Patel wrote: > > This patchset adds: > 1. SiFive SPI driver > 2. New MMC SPI driver based on DM_MMC and DM_SPI > 3. Enables SiFive SPI driver and MMC SPI driver for SiFive Unleashed board > > With this patch series, we can now load files from SD card on

[U-Boot] [PATCH 1/1] travis.yml: run Python tests on qemu-riscv64_defconfig

2019-07-17 Thread Heinrich Schuchardt
Run the Python tests on the RISC-V architecture too. https://github.com/swarren/uboot-test-hooks has already been updated. Signed-off-by: Heinrich Schuchardt --- Tested on Travis CI: https://travis-ci.org/xypron2/u-boot/builds/560095689 --- .travis.yml | 7 +++ 1 file changed, 7

Re: [U-Boot] SiFive clock driver changes for U-Boot 2019.10

2019-07-17 Thread Anup Patel
Hi Rick, On Thu, Jul 18, 2019 at 8:27 AM Rick Chen wrote: > > Hi Anup > > > > > Hi Tom > > > > > Sent: Thursday, July 18, 2019 1:00 AM > > > To: Simon Glass; Rick Jian-Zhi Chen(陳建志) > > > Cc: Anup Patel; Atish Patra; U-Boot Mailing List > > > Subject: Re: SiFive clock driver changes for U-Boot

Re: [U-Boot] [PATCH 2/2] riscv: Access CSRs using CSR numbers

2019-07-17 Thread Anup Patel
On Thu, Jul 11, 2019 at 12:14 PM Bin Meng wrote: > > We should prefer accessing CSRs using their CSR numbers > because: > 1. It compiles fine with older toolchains. > 2. We can use latest CSR names in #define macro names of CSR >numbers as-per RISC-V spec. > 3. We can access newly added CSRs

Re: [U-Boot] [PATCH 1/2] riscv: Sync csr.h with Linux kernel v5.2

2019-07-17 Thread Anup Patel
On Thu, Jul 11, 2019 at 12:13 PM Bin Meng wrote: > > This syncs csr.h with Linux kernel 5.2, and imports asm.h that > is required by csr.h. > > Signed-off-by: Bin Meng > --- > > arch/riscv/include/asm/asm.h | 68 > > arch/riscv/include/asm/csr.h |

Re: [U-Boot] [PATCH 2/2] riscv: Access CSRs using CSR numbers

2019-07-17 Thread Rick Chen
> > From: Bin Meng [mailto:bmeng...@gmail.com] > > Sent: Thursday, July 11, 2019 2:43 PM > > To: Rick Jian-Zhi Chen(陳建志); Anup Patel; Lukas Auer; U-Boot Mailing List > > Subject: [PATCH 2/2] riscv: Access CSRs using CSR numbers > > > > We should prefer accessing CSRs using their CSR numbers > >

Re: [U-Boot] [PATCH 1/2] riscv: Sync csr.h with Linux kernel v5.2

2019-07-17 Thread Rick Chen
> > From: Bin Meng [mailto:bmeng...@gmail.com] > Sent: Thursday, July 18, 2019 11:13 AM > To: Rick Jian-Zhi Chen(陳建志); Anup Patel; Lukas Auer; U-Boot Mailing List > Subject: Re: [PATCH 1/2] riscv: Sync csr.h with Linux kernel v5.2 > > Hi Rick, > > On Thu, Jul 11, 2019 at 2:43 PM Bin Meng wrote: >

Re: [U-Boot] [PATCH 1/2] riscv: Sync csr.h with Linux kernel v5.2

2019-07-17 Thread Bin Meng
Hi Rick, On Thu, Jul 11, 2019 at 2:43 PM Bin Meng wrote: > > This syncs csr.h with Linux kernel 5.2, and imports asm.h that > is required by csr.h. > > Signed-off-by: Bin Meng > --- > > arch/riscv/include/asm/asm.h | 68 > >

Re: [U-Boot] SiFive clock driver changes for U-Boot 2019.10

2019-07-17 Thread Rick Chen
Hi Anup > > Hi Tom > > > Sent: Thursday, July 18, 2019 1:00 AM > > To: Simon Glass; Rick Jian-Zhi Chen(陳建志) > > Cc: Anup Patel; Atish Patra; U-Boot Mailing List > > Subject: Re: SiFive clock driver changes for U-Boot 2019.10 > > > > On Wed, Jul 17, 2019 at 10:44:23AM -0600, Simon Glass wrote: > >

[U-Boot] [PATCH] gitlab-ci: Add pyelftools when needed

2019-07-17 Thread Tom Rini
In order to mirror current Travis CI support we need to install this package via pip. Signed-off-by: Tom Rini --- .gitlab-ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index cb636b25a61e..da27caeef688 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml

[U-Boot] [PATCH] am335x_boneblack_vboot: Disable asm memcpy/memset in SPL

2019-07-17 Thread Tom Rini
In order to save a little space in SPL, do not use the asm versions of memcpy/memset. Signed-off-by: Tom Rini --- configs/am335x_boneblack_vboot_defconfig | 4 1 file changed, 4 insertions(+) diff --git a/configs/am335x_boneblack_vboot_defconfig b/configs/am335x_boneblack_vboot_defconfig

[U-Boot] [PATCH 3/4] SDP: fix wrong usb request size and add high speed endpoint descriptor

2019-07-17 Thread sherry sun
From: Sherry Sun Because the buffer length of sdp usb request is 65, we have to allocate 65 bytes not 64 bytes. Otherwise there is potential buffer overflow. So the wMaxPacketSize of fullspeed can't meet the needs. Add HS endpoint descriptor for SDP. Then we can use high speed endpoint, and the

Re: [U-Boot] SiFive clock driver changes for U-Boot 2019.10

2019-07-17 Thread Rick Chen
Hi Tom > Sent: Thursday, July 18, 2019 1:00 AM > To: Simon Glass; Rick Jian-Zhi Chen(陳建志) > Cc: Anup Patel; Atish Patra; U-Boot Mailing List > Subject: Re: SiFive clock driver changes for U-Boot 2019.10 > > On Wed, Jul 17, 2019 at 10:44:23AM -0600, Simon Glass wrote: > > Hi, > > > > On Wed, 17

Re: [U-Boot] [PATCH v2 35/37] binman: Add support for Intel IFWI entries

2019-07-17 Thread sjg
An Integrated Firmware Image is used to hold various binaries used for booting with Apollolake and some later devices. Add support for this. Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/etype/intel_descriptor.py| 6 +- tools/binman/etype/intel_ifwi.py

Re: [U-Boot] [PATCH v2 32/37] patman: Add a function to write ifwitool

2019-07-17 Thread sjg
This tool has quite a few arguments and options, so put the functionality in a function so that we call it from one place and hopefully get it right. Signed-off-by: Simon Glass --- Changes in v2: None tools/patman/tools.py | 33 + 1 file changed, 33

Re: [U-Boot] [PATCH v2 01/31] binman: Simplify the entry test

2019-07-17 Thread sjg
The current test for the 'entry' module is a bit convoluted since it has to import the module multiple times. It also relies on ordering, in that test1EntryNoImportLib() must run before test2EntryImportLib() if they are running in the same Python process. This is unreliable since neither the

Re: [U-Boot] [PATCH v2 17/37] binman: Ensure that coverage has access to site packages

2019-07-17 Thread sjg
Code coverage tests fail on binman due to dist-packages being dropped from the python path on Ubuntu 16.04. Add them in so that we can find the elffile module, which is required by binman. Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/binman.py | 8 1 file changed,

[U-Boot] [PATCH 0/4] Make some changes to SDP

2019-07-17 Thread sherry sun
From: Sherry Sun This patchset adds: 1. Add usb_gadget_initialize() and usb_gadget_release() to initialize and release UDC during sdp download. 2. Add high speed endpoint descriptor for sdp. 3. Add a macro definition--CONFIG_SDP_LOADADDR as default sdp load address while SDP_WRITE and SDP_JUMP

Re: [U-Boot] [PATCH v2 18/37] binman: Assume Intel descriptor is at the start of the image

2019-07-17 Thread sjg
At present binman requires that the Intel descriptor has an explicit offset. Generally this is 0 since the descriptor is at the start of the image. Add a default to handle this, so users don't need to specify the offset. Signed-off-by: Simon Glass --- Changes in v2: None

Re: [U-Boot] [PATCH v2 29/37] binman: Allow verbosity control when running tests

2019-07-17 Thread sjg
At present the -v flag is ignored with tests, so that (for example) -v2 does not have any effect. Update binman to pass this flag through to tests so that they work just like running binman normally, except in a few special cases where we are actually testing behaviour with different levels of

Re: [U-Boot] [PATCH v2 26/37] binman: Correct comment in u_boot_spl_elf

2019-07-17 Thread sjg
This comment mentions the wrong default filename. Fix it. Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/README.entries | 2 +- tools/binman/etype/u_boot_spl_elf.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Applied to u-boot-dm, thanks!

Re: [U-Boot] [PATCH v2 12/31] binman: Call ProcessUpdateContents() consistently

2019-07-17 Thread sjg
SetContents() should only be called to set the contents of an entry from within the ObtainContents() call, since it has no guard against increasing the size of the contents, thus triggering incorrect operation. Change all such calls to use ProcessUpdateContents() instead. Signed-off-by: Simon

Re: [U-Boot] [PATCH v2 27/37] binman: Support ELF files for TPL

2019-07-17 Thread sjg
We currenty support using the ELF file in U-Boot proper and SPL, but not TPL. Add this as it is useful both with sandbox and for CBFS to allow adding TPL as a 'stage'. Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/README.entries | 11 +++

Re: [U-Boot] [PATCH v2 02/31] binman: Update future features

2019-07-17 Thread sjg
A few features have been completed and a few items are added. Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/README | 12 1 file changed, 8 insertions(+), 4 deletions(-) Applied to u-boot-dm, thanks! ___ U-Boot mailing

Re: [U-Boot] [PATCH v2 14/37] binman: Detect skipped tests

2019-07-17 Thread sjg
If tests are skipped we should ideally exit with an error, since there may be a missing dependency. However at present this is not desirable since it breaks travis tests. For now, just report the skips. Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/binman.py | 9 +++-- 1

Re: [U-Boot] [PATCH v2 16/37] binman: Add a function to decode an ELF file

2019-07-17 Thread sjg
Add a function which decodes an ELF file, working out where in memory each part of the data should be written. Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/README | 4 +++ tools/binman/elf.py | 76 tools/binman/elf_test.py

Re: [U-Boot] [PATCH v2 15/37] binman: Add a function to create a sample ELF file

2019-07-17 Thread sjg
It is useful to create an ELF file for testing purposes, with just the right attributes used by the test. Add a function to handle this, along with a test that it works correctly. Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/elf.py | 98

Re: [U-Boot] [PATCH v2 13/31] binman: Add a return value to ProcessContentsUpdate()

2019-07-17 Thread sjg
At present if this function tries to update the contents such that the size changes, it raises an error. We plan to add the ability to change the size of entries after packing is completed, since in some cases it is not possible to determine the size in advance. An example of this is with a

Re: [U-Boot] [PATCH v2 11/37] binman: Add missing comments toentry

2019-07-17 Thread sjg
At present GetOffsets() lacks a function comment. Add one. Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/entry.py | 15 +++ 1 file changed, 15 insertions(+) Applied to u-boot-dm, thanks! ___ U-Boot mailing list

Re: [U-Boot] [PATCH v2 07/31] binman: Convert to use ArgumentParser

2019-07-17 Thread sjg
This class is the new way to handle arguments in Python. Convert binman over to use it. At the same time, introduce commands so that we can separate out the different parts of binman functionality. Signed-off-by: Simon Glass --- Changes in v2: - Don't allow global arguments after the command -

Re: [U-Boot] [PATCH v2 20/37] binman: Update entry.SetOffsetSize to be optional

2019-07-17 Thread sjg
At present this function always sets both the offset and the size of entries. But in some cases we want to set only one or the other, for example with the forthcoming ifwi entry, where we only set the offset. Update the function to handle this. Signed-off-by: Simon Glass --- Changes in v2: None

Re: [U-Boot] [PATCH v2 16/31] binman: Allow device-tree entries to be compressed

2019-07-17 Thread sjg
At present the logic skips the blob class' handling of compression, so this is not supported with device tree entries. Fix this. Signed-off-by: Simon Glass --- Changes in v2: - Update test to use _DoReadFileRealDtb() helper tools/binman/etype/blob.py | 25 +

Re: [U-Boot] [PATCH v2 10/31] binman: Allow easy importing of entry modules

2019-07-17 Thread sjg
At present entry modules can only be accessed using Entry.Lookup() or Entry.Create(). Most of the time this is fine, but sometimes a module needs to provide constants or helper functions useful to other modules. It is easier in this case to use 'import'. Add an __init__ file to permit this.

Re: [U-Boot] [PATCH v2 34/37] binman: Add support for CBFS entries

2019-07-17 Thread sjg
Add support for putting CBFSs (Coreboot Filesystems) in an image. This allows binman to produce firmware images used by coreboot to boot. Signed-off-by: Simon Glass --- Changes in v2: - Deal with travis's old lz4 version by skipping tests as necessary - Skip use of cbfstool in tests if it is

Re: [U-Boot] [PATCH v2 25/37] binman: Use tools compression function for blob handling

2019-07-17 Thread sjg
Avoid duplicate code here by using the new compression function in the tools module. Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/etype/blob.py | 16 1 file changed, 4 insertions(+), 12 deletions(-) Applied to u-boot-dm, thanks!

Re: [U-Boot] [PATCH v2 12/37] binman: Tidy up help for --indir

2019-07-17 Thread sjg
The current help is confusing. Adjust it to indicate what the flag actually does. Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/cmdline.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied to u-boot-dm, thanks! ___

Re: [U-Boot] [PATCH v2 28/37] binman: Fix up the _DoTestFile() function -u argument

2019-07-17 Thread sjg
This should be -u, not -up, since we don't need to preserve the output directory in this case. Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/ftest.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied to u-boot-dm, thanks!

Re: [U-Boot] [PATCH v2 21/37] binman: Allow text directly in the node

2019-07-17 Thread sjg
At present text entries use an indirect method to specify the text to use, with a label pointing to the text itself. Allow the text to be directly written into the node. This is more convenient in cases where the text is constant. Signed-off-by: Simon Glass --- Changes in v2: None

Re: [U-Boot] [PATCH v2 37/37] binman: Add support for fixed-offset files in CBFS

2019-07-17 Thread sjg
A feature of CBFS is that it allows files to be positioned at particular offset (as with binman in general). This is useful to support execute-in-place (XIP) code, since this may not be relocatable. Add a new cbfs-offset property to control this. Signed-off-by: Simon Glass --- Changes in v2: -

[U-Boot] [PATCH 2/4] SDP: use CONFIG_SDP_LOADADDR as default load address

2019-07-17 Thread sherry sun
From: Sherry Sun If SDP_WRITE and SDP_JUMP command addr is zero, use CONFIG_SDP_LOADADDR as default address. Signed-off-by: Sherry Sun Signed-off-by: Frank Li --- drivers/usb/gadget/Kconfig | 4 drivers/usb/gadget/f_sdp.c | 6 -- 2 files changed, 8 insertions(+), 2 deletions(-)

Re: [U-Boot] [PATCH v2 18/31] binman: Use the cbfs memlen field only for uncompressed length

2019-07-17 Thread sjg
The purpose of this badly named field is a bit ambiguous. Adjust the code to use it only to store the uncompressed length of a file, leaving it set to None if there is no compression used. This makes it easy to see if the value in this field is relevant / useful. Also set data_len for compressed

Re: [U-Boot] [PATCH v2 14/31] binman: Add a control for post-pack entry expansion

2019-07-17 Thread sjg
We plan to support changing the size of entries after they have been packed. For now it will always be enabled. But to aid testing of both cases (in the event that we want to add a command-line flag, for example), add a setting to control it. Signed-off-by: Simon Glass --- Changes in v2: None

Re: [U-Boot] [PATCH v2 31/37] binman: Pass the toolpath to tests

2019-07-17 Thread sjg
Tools like ifwitool may not be available in the PATH, but are available in the build. These tools may be needed by tests, so allow tests to use the --toolpath flag. Also use this flag with travis. Signed-off-by: Simon Glass --- Changes in v2: None .travis.yml| 2 +- test/run

Re: [U-Boot] [PATCH v2 26/31] binman: Support listing an image

2019-07-17 Thread sjg
Add support for listing the entries in an image. This relies on the image having an FDT map. Signed-off-by: Simon Glass --- Changes in v2: - Adjust the test to not rely on lz4 compression version - Allow listing subsets of the image - Change list command from 'list' to 'ls' - Deal with travis's

Re: [U-Boot] [PATCH v2 05/31] binman: Add an FDT map

2019-07-17 Thread sjg
An FDT map is an entry which holds a full description of the image entries, in FDT format. It can be discovered using the magic string at its start. Tools can locate and read this entry to find out what entries are in the image and where each entry is located. Signed-off-by: Simon Glass ---

Re: [U-Boot] [PATCH v2 36/37] binman: Pad empty areas of the CBFS with files

2019-07-17 Thread sjg
When there is lots of open space in a CBFS it is normally padded with 'empty' files so that sequentially scanning the CBFS can skip from one to the next without a break. Add support for this. Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/cbfs_util.py | 68

Re: [U-Boot] [PATCH v2 04/31] binman: Add a convenience functions for real-DTB tests

2019-07-17 Thread sjg
Quite a few tests will use a real device tree and need it updated with the binman metadata. Add a helper function for this. Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/ftest.py | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) Applied to u-boot-dm,

Re: [U-Boot] [PATCH v2 06/31] binman: Add an image header

2019-07-17 Thread sjg
It is useful to be able to quickly locate the FDT map in the image. An easy way to do this is with a pointer at the start or end of the image. Add an 'image header' entry, which places a magic number followed by a pointer to the FDT map. This can be located at the start or end of the image, or at

Re: [U-Boot] [PATCH v2 13/37] binman: Use a better error for missing Intel descriptor

2019-07-17 Thread sjg
FD is a bit confusing so write this out in full. Also avoid splitting the string so that people can grep for the error message more easily. Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/etype/intel_descriptor.py | 2 +- tools/binman/ftest.py | 4 ++-- 2

[U-Boot] [PATCH 4/4] SDP: Call usb_gadget_initialize and usb_gadget_release to support UDC

2019-07-17 Thread sherry sun
From: Sherry Sun Need initialize UDC before run sdp download and release it at the end of sdp. Signed-off-by: Sherry Sun Signed-off-by: Frank Li --- common/spl/spl_sdp.c | 4 1 file changed, 4 insertions(+) diff --git a/common/spl/spl_sdp.c b/common/spl/spl_sdp.c index

Re: [U-Boot] [PATCH v2 17/31] binman: Provide the actual data address for cbfs files

2019-07-17 Thread sjg
At present a file with no explicit CBFS offset is placed in the next available location but there is no way to find out where it ended up. Update and rename the get_data() function to provide this information. Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/cbfs_util.py | 31

Re: [U-Boot] [PATCH v2 28/31] binman: Allow reading an entry from an image

2019-07-17 Thread sjg
It is useful to be able to extract entry contents from an image to see what is inside. Add a simple function to read the contents of an entry, decompressing it by default. Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/control.py| 20 ++

Re: [U-Boot] [PATCH v2 22/37] patman: Add functions to compress and decompress data

2019-07-17 Thread sjg
Add utility functions to compress and decompress using lz4 and lzma algorithms. In the latter case these use the legacy lzma support favoured by coreboot's CBFS. No tests are provided as these functions will be tested by the CBFS tests in a separate patch. Signed-off-by: Simon Glass ---

Re: [U-Boot] [PATCH v2 15/31] binman: Allow entries to expand after packing

2019-07-17 Thread sjg
Add support for detecting entries that change size after they have already been packed, and re-running packing when it happens. This removes the limitation that entry size cannot change after PackEntries() is called. Signed-off-by: Simon Glass --- Changes in v2: - Avoid dual assignment in

[U-Boot] [PATCH 1/4] imx: spl: Change USB boot device type

2019-07-17 Thread sherry sun
From: Sherry Sun The SPL SDP is configured as BOOT_DEVICE_BOARD, so when booting from USB, change its type to BOOT_DEVICE_BOARD, so we can use SDP. Signed-off-by: Sherry Sun Signed-off-by: Ye Li --- arch/arm/mach-imx/spl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [U-Boot] [PATCH v2 09/31] binman: Drop an unused arg in Entry.Lookup()

2019-07-17 Thread sjg
The first argument is not used. Remove it. Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/entry.py | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) Applied to u-boot-dm, thanks! ___ U-Boot mailing list

Re: [U-Boot] [PATCH v2 30/37] binman: Allow preserving test directories

2019-07-17 Thread sjg
Sometimes when debugging tests it is useful to keep the input and output directories so they can be examined later. Add an option for this and update the binman tests to support it. This affects both the test class and the tearDown() function called after each test. Signed-off-by: Simon Glass

Re: [U-Boot] [PATCH v2 33/37] binman: Add a utility library for coreboot CBFS

2019-07-17 Thread sjg
Coreboot uses a simple flash-based filesystem called Coreboot Filesystem (CBFS) to organise files used during boot. This allows files to be named and their position in the flash to be set. It has special features for dealing with x86 devices which typically memory-map their SPI flash to the top of

Re: [U-Boot] [PATCH v2 11/31] binman: Fix up ProcessUpdateContents error and comments

2019-07-17 Thread sjg
This function raises an exception with its arguments around the wrong way so the message is incorrect. Fix this as well as a few minor comment problems. Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/entry.py | 8 tools/binman/ftest.py | 2 +- 2 files changed, 5

Re: [U-Boot] [PATCH v2 23/37] binman: Use the tools.Decompress method

2019-07-17 Thread sjg
Update the compression test to use the tools module to decompress the output data. Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/ftest.py | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) Applied to u-boot-dm, thanks!

Re: [U-Boot] [PATCH v2 08/31] binman: Move compression into the Entry base class

2019-07-17 Thread sjg
Compression is currently available only with blobs. However we want to report the compression algorithm and uncompressed size for all entries, so that other entry types can support compression. This will help with the forthcoming 'list' feature which lists entries in the image. Move the

Re: [U-Boot] [PATCH v2 24/37] binman: Drop unnecessary debug handling

2019-07-17 Thread sjg
The -D option enables debug mode, but we only need to add -D to the command line once. Drop the duplicate code. Also drop the comment about enabling debugging since this can be done with -D. Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/binman.py | 5 - 1 file changed,

Re: [U-Boot] [PATCH v2 25/31] binman: Convert Image to a subclass of Entry

2019-07-17 Thread sjg
When support for sections (and thus hierarchical images) was added to binman, the decision was made to create a new Section class which could be used by both Image and an Entry_section class. The decision between using inheritance and composition was tricky to make, but in the end it was decided

Re: [U-Boot] [PATCH v2 23/31] binman: Support locating an image header

2019-07-17 Thread sjg
Add support for locating an image header in an image. Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/etype/image_header.py | 23 +++ tools/binman/ftest.py | 27 +++ 2 files changed, 50 insertions(+) Applied to

Re: [U-Boot] [PATCH v2 24/31] binman: Support reading an image into an Image object

2019-07-17 Thread sjg
It is possible to read an Image, locate its FDT map and then read it into the binman data structures. This allows full access to the entries that were written to the image. Add support for this. Signed-off-by: Simon Glass --- Changes in v2: - Deal with travis's old lz4 version by skipping tests

Re: [U-Boot] [PATCH v2 03/31] binman: Update help for new features

2019-07-17 Thread sjg
A few new features have been added. This has rendered part of the README obsolete. Update it. Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/README | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) Applied to u-boot-dm, thanks!

Re: [U-Boot] [PATCH v2 19/37] binman: Don't assume there is an ME region

2019-07-17 Thread sjg
At present having a descriptor means that there is an ME (Intel Management Engine) entry as well. The descriptor provides the ME location and assumes that it is present. For some SoCs this is not true. Before providing the location of a potentially non-existent entry, check if it is present.

Re: [U-Boot] [PATCH v2 21/31] binman: Allow listing the entries in an image

2019-07-17 Thread sjg
It is useful to be able to summarise all the entries in an image, e.g. to display this to this user. Add a new ListEntries() method to Entry, and set up a way to call it through the Image class. Signed-off-by: Simon Glass --- Changes in v2: - Add the Entry object to EntryInfo as well - Change

Re: [U-Boot] [PATCH v2 20/31] binman: Detect bad CBFS file types

2019-07-17 Thread sjg
Detect when an unknown or unsupported file type is specified and report an error. Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/etype/cbfs.py | 3 +++ tools/binman/ftest.py | 6 ++ tools/binman/test/126_cbfs_bad_type.dts | 17

Re: [U-Boot] [PATCH v2 29/31] binman: Support reading from CBFS entries

2019-07-17 Thread sjg
CBFS is a bit like a section but with a custom format. Provide the list of entries and the compression type to binman so that it can extract the data from the CBFS, just like any other part of the image. Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/cbfs_util.py | 14

Re: [U-Boot] [PATCH v2 22/31] binman: Support locating an FDT map

2019-07-17 Thread sjg
Add support for locating an image's Fdt map which is used to determine the contents and structure of the image. Signed-off-by: Simon Glass --- Changes in v2: - Adjust LocateFdtmap() to return the position of the header - Update commit subject to more accurately describe this patch - Update test

Re: [U-Boot] [PATCH v2 19/31] binman: Support FDT update for CBFS

2019-07-17 Thread sjg
It is useful to add the CBFS file information (offset, size, etc.) into the FDT so that the layout is complete. Add support for this. Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/etype/cbfs.py| 49 +-- tools/binman/ftest.py

Re: [U-Boot] [PATCH v2 27/31] binman: Allow for logging information to be displayed

2019-07-17 Thread sjg
Binman generally operates silently but in some cases it is useful to see what Binman is actually doing at each step. Enable some logging output with different logging levels selectable via the -v flag. Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/README | 19

Re: [U-Boot] [PATCH v2 31/31] binman: Add a test for nested and aligned sections

2019-07-17 Thread sjg
Current test coverage is likely sufficient for the logic used to place sections in the image. However it seems useful to add a test specifically for nested sections, since these could have some unusual interactions. Add a new test for this and aligned sections. This test failed before the

Re: [U-Boot] [PATCH v2 30/31] binman: Add an 'extract' command

2019-07-17 Thread sjg
It is useful to be able to extract all binaries from the image, or a subset of them. Add a new 'extract' command to handle this. Signed-off-by: Simon Glass --- Changes in v2: None tools/binman/README | 25 +- tools/binman/cmdline.py | 13 +++ tools/binman/control.py | 60

Re: [U-Boot] Support for i.MX7ULP rev B0

2019-07-17 Thread Fabio Estevam
Hi Peng, On Wed, Jul 17, 2019 at 10:20 PM Peng Fan wrote: > > Hi Fabio, > > I already submitted patches 2 months ago, but still not merged. > https://patchwork.ozlabs.org/cover/1099916/ > https://patchwork.ozlabs.org/patch/1100269/ Thanks, I will test them tomorrow. Cheers

Re: [U-Boot] [PATCH 3/5] traivs: Build aspeed boards

2019-07-17 Thread Joel Stanley
On Thu, 18 Jul 2019 at 01:33, Tom Rini wrote: > > On Thu, Jul 18, 2019 at 01:30:01AM +, Joel Stanley wrote: > > On Wed, 17 Jul 2019 at 19:57, Tom Rini wrote: > > > This isn't needed as the job that builds all matches to arm11 arm7 > > > arm920t arm946es builds it. > > > > I thought this

Re: [U-Boot] [PATCH 3/5] traivs: Build aspeed boards

2019-07-17 Thread Tom Rini
On Thu, Jul 18, 2019 at 01:30:01AM +, Joel Stanley wrote: > On Wed, 17 Jul 2019 at 19:57, Tom Rini wrote: > > > > On Thu, Jul 04, 2019 at 11:05:16AM +0930, Joel Stanley wrote: > > > > > Currently we only have one, but this will expand to cover other boards > > > as they are supported. > > > >

Re: [U-Boot] [PATCH 3/5] traivs: Build aspeed boards

2019-07-17 Thread Joel Stanley
On Wed, 17 Jul 2019 at 19:57, Tom Rini wrote: > > On Thu, Jul 04, 2019 at 11:05:16AM +0930, Joel Stanley wrote: > > > Currently we only have one, but this will expand to cover other boards > > as they are supported. > > > > Signed-off-by: Joel Stanley > > --- > > .travis.yml | 3 +++ > > 1 file

Re: [U-Boot] Support for i.MX7ULP rev B0

2019-07-17 Thread Peng Fan
Hi Fabio, I already submitted patches 2 months ago, but still not merged. https://patchwork.ozlabs.org/cover/1099916/ https://patchwork.ozlabs.org/patch/1100269/ Regards, Peng. > -Original Message- > From: Fabio Estevam [mailto:feste...@gmail.com] > Sent: 2019年7月18日 1:00 > To: Peng Fan

Re: [U-Boot] [RFC, PATCH v4 16/16] efi_loader: variable: rework with new extended env interfaces

2019-07-17 Thread AKASHI Takahiro
Heinrich, On Wed, Jul 17, 2019 at 08:53:53PM +0200, Heinrich Schuchardt wrote: > On 7/17/19 10:25 AM, AKASHI Takahiro wrote: > >In UEFI variable implementation, ENVCTX_UEFI is used for context > >and VARSTORAGE_VOLATILE and VARSTORAGE_NON_VOLATILE_AUTOSAVE are > >allowed for variable storage

Re: [U-Boot] [RFC, PATCH v4 00/16] efi_loader: non-volatile variables support

2019-07-17 Thread AKASHI Takahiro
Heinrich, On Wed, Jul 17, 2019 at 09:05:55PM +0200, Heinrich Schuchardt wrote: > On 7/17/19 10:25 AM, AKASHI Takahiro wrote: > ># In version 4 of this patch set, the implementation is changed to meet > ># Wolfgang's requirements. > ># I believe that this is NOT intrusive, and that my approach

[U-Boot] [PATCH] sunxi: H6: DRAM: Add support for half DQ

2019-07-17 Thread Jernej Skrabec
Half DQ configuration seems to be very rare for H6 based boards/STBs, but exists nevertheless. Currently the only known product which needs this support is Tanix TX6 mini. This commit adds support for half DQ configuration. Code was tested for regressions on other configurations (OrangePi 3 1

[U-Boot] [PATCH] gitlab-ci: Add evb-ast2500 test.py test

2019-07-17 Thread Tom Rini
Bring us back into line with current Travis tests. Signed-off-by: Tom Rini --- .gitlab-ci.yml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 3ddd5ad99a85..cb636b25a61e 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -159,6 +159,16 @@

Re: [U-Boot] [PATCH 3/5] traivs: Build aspeed boards

2019-07-17 Thread Tom Rini
On Thu, Jul 04, 2019 at 11:05:16AM +0930, Joel Stanley wrote: > Currently we only have one, but this will expand to cover other boards > as they are supported. > > Signed-off-by: Joel Stanley > --- > .travis.yml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/.travis.yml

[U-Boot] [PATCH 1/1] video: dw_hdmi: Add support for ddc-i2c-bus property

2019-07-17 Thread Niklas Schulze
Add support for the ddc-i2c-bus device tree property which allows for using an external i2c master for reading the display's EDID. Signed-off-by: Niklas Schulze --- drivers/video/dw_hdmi.c | 10 ++ drivers/video/meson/meson_dw_hdmi.c | 2 ++ drivers/video/rockchip/rk_hdmi.c

Re: [U-Boot] [PATCH 0/4] Marvell MDIO driver and new MDIO name property

2019-07-17 Thread Alex Marginean
+Nevo, I forgot to CC you. Alex On 7/17/2019 6:10 PM, Alex Marginean wrote: This is a respin of the original Marvell MDIO driver submitted by Ken about one year ago, using the new MDIO DM code. Added binding documents for mdio and marvell-mdio and introduced a new optional property for naming

Re: [U-Boot] [RFC, PATCH v4 00/16] efi_loader: non-volatile variables support

2019-07-17 Thread Heinrich Schuchardt
On 7/17/19 10:25 AM, AKASHI Takahiro wrote: # In version 4 of this patch set, the implementation is changed to meet # Wolfgang's requirements. # I believe that this is NOT intrusive, and that my approach here is NOT # selfish at all. If Wolfgang doesn't accept this approach, however, # I would

Re: [U-Boot] [RFC, PATCH v4 16/16] efi_loader: variable: rework with new extended env interfaces

2019-07-17 Thread Heinrich Schuchardt
On 7/17/19 10:25 AM, AKASHI Takahiro wrote: In UEFI variable implementation, ENVCTX_UEFI is used for context and VARSTORAGE_VOLATILE and VARSTORAGE_NON_VOLATILE_AUTOSAVE are allowed for variable storage attribute. Signed-off-by: AKASHI Takahiro --- include/efi_loader.h | 1 +

Re: [U-Boot] [PATCH] spl: implement stack usage check

2019-07-17 Thread Simon Goldschmidt
Am 17.07.2019 um 20:07 schrieb Tom Rini: On Tue, Jul 16, 2019 at 10:30:36PM +0200, Simon Goldschmidt wrote: This implements a stack usage check in SPL. Many boards start up SPL to run code + data from one common, rather small SRAM. To implement a sophisticated SPL binary size limit on such

Re: [U-Boot] [PATCH] spl: implement stack usage check

2019-07-17 Thread Tom Rini
On Tue, Jul 16, 2019 at 10:30:36PM +0200, Simon Goldschmidt wrote: > This implements a stack usage check in SPL. > > Many boards start up SPL to run code + data from one common, rather small > SRAM. To implement a sophisticated SPL binary size limit on such boards, > the stack size (as well as

Re: [U-Boot] [PATCH 1/1] travis-ci: qemu-system-riscv64: Parameter 'id' is missing

2019-07-17 Thread Heinrich Schuchardt
On 7/17/19 6:02 PM, Stephen Warren wrote: On 7/16/19 5:35 PM, Heinrich Schuchardt wrote: When testing qemu-riscv64_defconfig on Travis CI I got a QEMU erorr "Parameter 'id' is missing". A command launching qemu-riscv64_defconfig successfully on Debian is: qemu-system-riscv64 \ -machine virt \

Re: [U-Boot] [PATCH 2/2] watchdog: omap_wdt: Disable DM watchdog support in SPL

2019-07-17 Thread Tom Rini
On Fri, Jul 12, 2019 at 02:53:47PM +0530, suni...@techveda.org wrote: > From: Suniel Mahesh > > This patch disables DM watchdog support for SPL builds and uses > the legacy omap watchdog on TI AM335x chipsets. > > The following build error is reported if DM watchdog support was enabled in >

Re: [U-Boot] [PATCH] travis.yml: change Ubuntu version to xenial

2019-07-17 Thread Ramon Fried
On July 17, 2019 7:42:30 PM GMT+03:00, Tom Rini wrote: >On Wed, Jul 17, 2019 at 07:37:23PM +0300, Ramon Fried wrote: >> >> >> On July 17, 2019 4:29:04 PM GMT+03:00, Tom Rini >wrote: >> >On Mon, Jul 15, 2019 at 03:26:27AM +0300, Ramon Fried wrote: >> > >> >> trusty is getting old, move to

Re: [U-Boot] [RFC] bug.h: Drop filename from BUG/WARNING logs if building for TPL/SPL

2019-07-17 Thread Tom Rini
On Wed, Jul 10, 2019 at 04:30:44PM -0500, Andreas Dannenberg wrote: > On several platforms space is very tight when building for SPL or TPL. > To claw back a few bytes to be used for code remove the __FILE__ name > from the BUG() and WARN() type macros. Since those macros still print > the

Re: [U-Boot] SiFive clock driver changes for U-Boot 2019.10

2019-07-17 Thread Tom Rini
On Wed, Jul 17, 2019 at 10:44:23AM -0600, Simon Glass wrote: > Hi, > > On Wed, 17 Jul 2019 at 00:40, Anup Patel wrote: > > > > Hi Simon, > > > > Can you pick-up SiFive clock driver changes from below series > > for U-Boot 2019.10? > > I don't see them in my patchwork queue. Who is the custodian

[U-Boot] Support for i.MX7ULP rev B0

2019-07-17 Thread Fabio Estevam
Hi Peng and Ye, I notice that mx7ulp evk does not boot with U-Boot mainline. I see that the changes for supporting silicon revision B0 from NXP U-Boot tree are not present in mainline U-Boot. Do you plan to submit these patches upstream? Please let me know. Thanks, Fabio Estevam

Re: [U-Boot] SiFive clock driver changes for U-Boot 2019.10

2019-07-17 Thread Simon Glass
Hi, On Wed, 17 Jul 2019 at 00:40, Anup Patel wrote: > > Hi Simon, > > Can you pick-up SiFive clock driver changes from below series > for U-Boot 2019.10? I don't see them in my patchwork queue. Who is the custodian for this? Regards, Simon > > [PATCH v9 0/9] Update SiFive Unleashed Drivers >

Re: [U-Boot] [PATCH] travis.yml: change Ubuntu version to xenial

2019-07-17 Thread Tom Rini
On Wed, Jul 17, 2019 at 07:37:23PM +0300, Ramon Fried wrote: > > > On July 17, 2019 4:29:04 PM GMT+03:00, Tom Rini wrote: > >On Mon, Jul 15, 2019 at 03:26:27AM +0300, Ramon Fried wrote: > > > >> trusty is getting old, move to xenial (16.04) > >> to get updated gcc and other tools. > >> > >>

  1   2   >