Re: PINE64 Rock64 - How to get SPI driver working

2020-05-19 Thread Kamal R. Prasad
Hello, I want to add a helper function to uboot i.e uboot# help will show a list of commands. I want to add 1 for my own private command. which file contains the list of cmd that will be displayed and the indirection? thanks -kamal On Wed, May 20, 2020 at 8:58 AM Johannes Krottmayer wrote: >

pull request of u-boot-fsl-qoriq for v2020.07

2020-05-19 Thread Priyanka Jain
Dear Tom, Please find my pull-request for u-boot-fsl-qoriq/master https://travis-ci.org/github/p-priyanka-jain/u-boot/builds Summary Add DM_ETH support for lx2160aqds, ls2080aqds, ls1088aqds QSI related fixes on ls1012a, ls2080a, ls1046a, ls1088a, ls1043a based platforms Bug-fixes/updtaes

Re: [PATCH v1 00/15] add basic driver support for broadcom NS3 soc

2020-05-19 Thread Rayagonda Kokatanur
Hi Thomas, On Wed, May 20, 2020 at 7:34 AM Thomas Fitzsimmons wrote: > > Rayagonda Kokatanur writes: > > > On Tue, May 19, 2020 at 11:01 PM Tom Rini wrote: > >> > >> On Tue, May 19, 2020 at 10:39:49PM +0530, Rayagonda Kokatanur wrote: > >> > Hi Tom, > >> > > >> > > >> > On Tue, May 19, 2020 at

Re: [PATCH v10 17/18] configs: fu540: Add config options for U-Boot SPL

2020-05-19 Thread Bin Meng
Hi Jagan, On Wed, May 20, 2020 at 12:11 AM Jagan Teki wrote: > > On Sat, May 16, 2020 at 11:42 AM Pragnesh Patel > wrote: > > > > Hi Jagan, > > > > >-Original Message- > > >From: Jagan Teki > > >Sent: 15 May 2020 23:05 > > >To: Pragnesh Patel > > >Cc: U-Boot-Denx ; Atish Patra > > >;

Re: rockpro64: Enable HDMI output

2020-05-19 Thread Anand Moon
On Friday, May 15, 2020, 5:28:36 PM GMT+5:30, Marcin Juszkiewicz wrote: Enable config options and console setting like on other rk3399 boards. --- configs/rockpro64-rk3399_defconfig | 4 include/configs/rockpro64_rk3399.h | 5 + 2 files changed, 9 insertions(+) diff --git

Re: [PATCH] ARM: add psci_arch_init() declaration for CONFIG_ARMV7_PSCI

2020-05-19 Thread Masahiro Yamada
On Wed, May 20, 2020 at 12:09 PM Simon Glass wrote: > > HI Masahiro, > > On Tue, 19 May 2020 at 20:44, Masahiro Yamada > wrote: > > > > arch/arm/include/asm/system.h declares psci_arch_init(), but it is > > surrounded by #ifdef CONFIG_ARMV8_PSCI. > > > > psci_arch_init() is called for

[PATCH 5/6] ARM: uniphier: delete or replace includes

2020-05-19 Thread Masahiro Yamada
pulls in a lot of bloat. is unneeded in most of places. Signed-off-by: Masahiro Yamada --- arch/arm/mach-uniphier/arm32/cache-uniphier.c | 1 - arch/arm/mach-uniphier/arm32/psci.c | 1 - arch/arm/mach-uniphier/arm32/timer.c | 2 +-

[PATCH 3/6] ARM: uniphier: drop #include again from umc-pxs2.c

2020-05-19 Thread Masahiro Yamada
I do not understand the change made to this file by commit 691d719db718 ("common: Drop init.h from common header"). git show 691d719db718 -- arch/arm/mach-uniphier/dram/umc-pxs2.c This file does not call or define any functions declared in Simply revert the change made to this file.

[PATCH 1/6] ARM: uniphier: include instead of from psci.c

2020-05-19 Thread Masahiro Yamada
I do not understand the change made to this file by commit 90526e9fbac4 ("common: Drop net.h from common header"). git show 90526e9fbac4 -- arch/arm/mach-uniphier/arm32/psci.c It added while this file does not call the standard cache functions at all. All the uniphier-specific cache

[PATCH 6/6] ARM: uniphier: remove board_eth_init()

2020-05-19 Thread Masahiro Yamada
This platform completely migrated to CONFIG_DM_ETH. board_eth_init() is only called from net/eth_legacy.c Remove the legacy hook. Signed-off-by: Masahiro Yamada --- arch/arm/mach-uniphier/micro-support-card.c | 12 1 file changed, 12 deletions(-) diff --git

[PATCH 4/6] ARM: uniphier: drop #include again

2020-05-19 Thread Masahiro Yamada
I do not understand the changes made to these files by commit f7ae49fc4f36 ("common: Drop log.h from common header"). git show f7ae49fc4f36 -- arch/arm/mach-uniphier/ None of them uses the log function feature. Simply revert the changes made to these files. Signed-off-by: Masahiro Yamada

[PATCH 2/6] ARM: uniphier: remove #include again from micro-support-card.c

2020-05-19 Thread Masahiro Yamada
I do not understand the changes made to this file by commit 90526e9fbac4 ("common: Drop net.h from common header"). git show 90526e9fbac4 -- arch/arm/mach-uniphier/micro-support-card.c The necessary declaration is already included by at line 112. It also moved the inclusion, but I do not

Re: [PING][PATCH] Optionally: Set the serial# environment variable on the i.MX7.

2020-05-19 Thread Mark G
On Mon, 11 May 2020, Stefano Babic wrote: patch was hidden in the flood of other patches and I am unsure if this belongs to i.MX: No worries. To clarify the patch applies to all i.MX7 boards. On 19.02.20 22:01, Mark G wrote: +  Linux kernel will use this as the serial number of the

PINE64 Rock64 - How to get SPI driver working

2020-05-19 Thread Johannes Krottmayer
Hello, I just compiled U-Boot v2020.04 for a PINE64 Rock media board. It compiles fine without errors, but when I try to probe the on board flash I get an error: => sf probe Invalid bus 0 (err=-19) Failed to initialize SPI flash at 0:0 (error -19) => SPI is activated in the Device-Tree blob. I

Re: [RFC 5/6] dtoc: update dtb_platdata to support cd-gpios

2020-05-19 Thread Simon Glass
On Wed, 13 May 2020 at 14:14, Walter Lozano wrote: > > Currently dtoc does not support the property cd-gpios used to declare > the gpios for card detect in mmc. > > This patch adds support to cd-gpios property. > > Signed-off-by: Walter Lozano > --- > tools/dtoc/dtb_platdata.py | 13

Re: [PATCH v11 00/18] RISC-V SiFive FU540 support SPL

2020-05-19 Thread Rick Chen
Hi Bin > -Original Message- > From: Bin Meng [mailto:bmeng...@gmail.com] > Sent: Tuesday, May 19, 2020 4:44 PM > To: Pragnesh Patel; Rick Jian-Zhi Chen(陳建志) > Subject: Re: [PATCH v11 00/18] RISC-V SiFive FU540 support SPL > > Hi Rick, > > On Tue, May 19, 2020 at 3:04 PM Pragnesh Patel >

Re: [RFC 6/6] dtoc add test for cd-gpios

2020-05-19 Thread Simon Glass
On Wed, 13 May 2020 at 14:14, Walter Lozano wrote: > > Add a test for dtoc taking into account the cd-gpios property. > > Signed-off-by: Walter Lozano > --- > tools/dtoc/dtoc_test_phandle_cd_gpios.dts | 42 + > tools/dtoc/test_dtoc.py | 72 +++ >

Re: [PATCH] ARM: add psci_arch_init() declaration for CONFIG_ARMV7_PSCI

2020-05-19 Thread Simon Glass
HI Masahiro, On Tue, 19 May 2020 at 20:44, Masahiro Yamada wrote: > > arch/arm/include/asm/system.h declares psci_arch_init(), but it is > surrounded by #ifdef CONFIG_ARMV8_PSCI. > > psci_arch_init() is called for CONFIG_ARMV7_PSCI too. Add the missing > function declaration. > > Signed-off-by:

Re: [RFC 4/6] dtoc: update tests to match new platdata

2020-05-19 Thread Simon Glass
On Wed, 13 May 2020 at 14:14, Walter Lozano wrote: > > After using a new approach to link nodes when OF_PLATDATA is enabled > the test cases need to be update. > > This patch updates the tests based on this new implementation. > > Signed-off-by: Walter Lozano > --- > tools/dtoc/test_dtoc.py |

Re: [RFC 3/6] dtoc: extend dtoc to use struct driver_info when linking nodes

2020-05-19 Thread Simon Glass
Hi Walter, On Wed, 13 May 2020 at 14:14, Walter Lozano wrote: > > In the current implementation, when dtoc parses a dtb to generate a struct > platdata it converts the information related to linked nodes as pointers > to struct platdata of destination nodes. By doing this, it makes > difficult

Re: [RFC 2/6] core: extend struct driver_info to point to device

2020-05-19 Thread Simon Glass
Hi Walter, On Wed, 13 May 2020 at 14:14, Walter Lozano wrote: > > Currently when creating an U_BOOT_DEVICE entry a struct driver_info > is declared, which contains the data needed to instantiate the device. > However, the actual device is created at runtime and there is no proper > way to get

Re: [PATCH 05/10] x86: Convert from ACCESS_ONCE to READ/WRITE_ONCE

2020-05-19 Thread Simon Glass
On Thu, 14 May 2020 at 06:30, Tom Rini wrote: > > In order to update our to a newer version that no > longer provides ACCESS_ONCE() but only READ_ONCE()/WRITE_ONCE() we need > to convert arch/x86/include/asm/atomic.h to the other macros. > > Cc: Simon Glass > Cc: Bin Meng > Signed-off-by: Tom

Re: [RFC 1/6] dtoc: add support to scan drivers

2020-05-19 Thread Simon Glass
Hi Walter, On Wed, 13 May 2020 at 14:13, Walter Lozano wrote: > > Currently dtoc scans dtbs to convert them to struct platdata and > to generate U_BOOT_DEVICE entries. These entries need to be filled > with the driver name, but at this moment the information used is the > compatible name present

Re: [RFC 0/6] improve OF_PLATDATA support

2020-05-19 Thread Simon Glass
Hi Walter, On Wed, 13 May 2020 at 14:13, Walter Lozano wrote: > > When using OF_PLATDATA dtbs are converted to C structs in order to save > space as we can remove both dtbs and libraries from TPL/SPL binaries. > > This patchset tries to improve its support by overcoming some limitations > in the

Re: [PATCH v5 3/3] gpio: search for gpio label if gpio is not found through bank name

2020-05-19 Thread Simon Glass
Hi Heiko, On Fri, 15 May 2020 at 08:02, Heiko Schocher wrote: > > dm_gpio_lookup_name() searches for a gpio through > the bank name. But we have also gpio labels, and it > makes sense to search for a gpio also in the labels > we have defined, if no gpio is found through the > bank name

Re: [PATCH v5 1/3] gpio-uclass.c: save the GPIOD flags also in the gpio descriptor

2020-05-19 Thread Simon Glass
On Fri, 15 May 2020 at 08:01, Heiko Schocher wrote: > > save the GPIOD_ flags also in the gpio descriptor. > > Signed-off-by: Heiko Schocher > > > --- > > Changes in v5: > - add comment from patrick, update the descriptor flags > in _dm_gpio_set_dir_flags() if setting direction was OK. > >

Re: [PATCH v3 2/7] uart: pl011: Add proper DM clock support

2020-05-19 Thread Simon Glass
Hi André, On Tue, 12 May 2020 at 08:27, André Przywara wrote: > > On 28/04/2020 18:57, Simon Glass wrote: > > Hi, > > sorry for the delay, found this, slightly mouldy already, in my draft > folder. > > First, thanks for the review! I saw the Tom merged this already, but > wanted to come back to

Re: U-CLASS SPI Bus and Devices

2020-05-19 Thread Simon Glass
Hi Rudolf, On Tue, 12 May 2020 at 18:02, Rudolf J Streif wrote: > > Hi Simon, > > Thanks for your response. > > On 5/7/20 6:36 PM, Simon Glass wrote: > > Hi Rudolf, > > > > On Wed, 18 Mar 2020 at 05:25, Rudolf J Streif > > wrote: > >> I ran into an issue today with a U-CLASS SPI NOR flash

Re: [PATCH v5 2/3] sandbox, test: add test for GPIO_HOG function

2020-05-19 Thread Simon Glass
Hi Heiko, On Fri, 15 May 2020 at 08:02, Heiko Schocher wrote: > > currently gpio hog function is not tested with "ut dm gpio" > so add some basic tests for gpio hog functionality. > > For this enable GPIO_HOG in sandbox_defconfig, add > in DTS some gpio hog entries, and add testcase in > "ut dm

[PATCH] ARM: add psci_arch_init() declaration for CONFIG_ARMV7_PSCI

2020-05-19 Thread Masahiro Yamada
arch/arm/include/asm/system.h declares psci_arch_init(), but it is surrounded by #ifdef CONFIG_ARMV8_PSCI. psci_arch_init() is called for CONFIG_ARMV7_PSCI too. Add the missing function declaration. Signed-off-by: Masahiro Yamada --- arch/arm/include/asm/system.h | 1 + 1 file changed, 1

RE: [PATCH] cpu: imx8: use intended cpu-thermal device when getting temp value

2020-05-19 Thread Peng Fan
> Subject: [PATCH] cpu: imx8: use intended cpu-thermal device when getting > temp value > > This fixes getting DT alert and critical pdata values in imx_scu_thermal > driver. > On i.MX8QXP using not initialized alert pdata value resulted in boot hang and > endless loop outputting: > CPU

Re: [PATCH v1 1/3] board: ns3: add optee based bnxt fw load driver

2020-05-19 Thread Thomas Fitzsimmons
Hi Rayagonda and Vikas, Rayagonda Kokatanur writes: > From: Vikas Gupta > > Add optee based bnxt fw load driver. What is "bnxt"? Maybe you could add a comment explaining what it is, or at least expanding it if it's an acronym? Thanks, Thomas

Re: [PATCH v1 00/15] add basic driver support for broadcom NS3 soc

2020-05-19 Thread Thomas Fitzsimmons
Rayagonda Kokatanur writes: > On Tue, May 19, 2020 at 11:01 PM Tom Rini wrote: >> >> On Tue, May 19, 2020 at 10:39:49PM +0530, Rayagonda Kokatanur wrote: >> > Hi Tom, >> > >> > >> > On Tue, May 19, 2020 at 12:46 AM Tom Rini wrote: >> > > >> > > On Sun, May 17, 2020 at 01:49:30PM +0530,

Re: [PATCH v1 2/3] board: ns3: add FIT image its file

2020-05-19 Thread Thomas Fitzsimmons
Hi Rayagonda and Pramod, Rayagonda Kokatanur writes: > From: Pramod Kumar > > Add FIT image its file. The .its file and dev keys seem generic. Are you intending to add to the .its file subsequently, e.g., to demonstrate FIT usage unique to the NS3? Thomas

Re: patman: ImportError

2020-05-19 Thread Simon Glass
Hi Stefan, On Sun, 17 May 2020 at 07:54, Stefan Bosch wrote: > > Hi Simon, > > Am 17.05.20 um 01:03 schrieb Simon Glass: > > Hi Stefan, > > > > On Sat, 16 May 2020 at 05:27, Stefan Bosch wrote: > >> > >> Hello, > >> > >> recently, I updated my local repository (U-Boot master). Last commit is >

[PATCH v2] patman: Avoid circular dependency between command and tools

2020-05-19 Thread Simon Glass
This seems to cause problems in some cases. Split the dependency by copying the code to command. Reported-by: Stefan Bosch Signed-off-by: Simon Glass --- Changes in v2: - Update gitutil as well tools/patman/command.py | 7 +++ tools/patman/gitutil.py | 1 - 2 files changed, 3

[PATCH] psci: add 'static inline' to invoke_psci_fn() stub

2020-05-19 Thread Masahiro Yamada
Avoid potential multiple definitions when CONFIG_ARM_PSCI_FW is disabled. Signed-off-by: Masahiro Yamada --- include/linux/psci.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/psci.h b/include/linux/psci.h index 9433df836b..841dbc8da7 100644 ---

Re: [PATCH 2/2] thermal: imx_scu_thermal: fix getting DT alert property value

2020-05-19 Thread Anatolij Gustschin
On Wed, 20 May 2020 00:05:01 +0200 Anatolij Gustschin ag...@denx.de wrote: ... > When uclass_get_device_by_name() is used, then > imx_sc_thermal_ofdata_to_platdata() > is called for "cpu-thermal0" device, here getting the list works > and alert/critical pdata values are initialized properly.

[PATCH] cpu: imx8: use intended cpu-thermal device when getting temp value

2020-05-19 Thread Anatolij Gustschin
This fixes getting DT alert and critical pdata values in imx_scu_thermal driver. On i.MX8QXP using not initialized alert pdata value resulted in boot hang and endless loop outputting: CPU Temperature (47200C) has beyond alert (0C), close to critical (0C) waiting... While at it, preset CPU type

[PATCH 25/26] x86: minnowmax: Enable the copy framebuffer

2020-05-19 Thread Simon Glass
Update the video driver to support this feature and enable it on minnowmax to speed up the display. With this change, the time taken to print the environment to the display without CONFIG_CONSOLE_SCROLL_LINES is reduced from over 13 seconds to 300ms, at 1280x1024. Signed-off-by: Simon Glass ---

[PATCH 26/26] x86: minnowmax: Drop screen resolution to 1024x768

2020-05-19 Thread Simon Glass
This seems like a more reasonable resolution for this board, since it is quite slow. It also allows it to work with a 5" LCD display in my lab. Signed-off-by: Simon Glass --- configs/minnowmax_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 22/26] x86: video: Support copy framebuffer with probed devices

2020-05-19 Thread Simon Glass
For PCI video devices that are not mentioned in the devicetree, U-Boot does not bind a driver before relocation, since PCI is not fully probed at that point. Furthermore it is possible for the video device to be on a secondary bus which is not even scanned. This is fine if the framebuffer is

[PATCH 23/26] x86: chromebook_samus: Enable the copy framebuffer

2020-05-19 Thread Simon Glass
Update the video driver to support this feature and enable it on samus. Also remove the multi-line scrolling since normal scrolling is fast enough now. With this change, the time taken to print the environment to the display without CONFIG_CONSOLE_SCROLL_LINES is reduced from about 430ms to 12ms.

[PATCH 24/26] x86: chromebook_link: Enable the copy framebuffer

2020-05-19 Thread Simon Glass
Update the video driver to support this feature and enable it on link. Also remove the multi-line scrolling since normal scrolling is fast enough now. With this change, the time taken to print the environment to the display without CONFIG_CONSOLE_SCROLL_LINES is reduced from about 930ms to 29ms.

[PATCH 20/26] x86: fsp: video: Allocate a frame buffer when needed

2020-05-19 Thread Simon Glass
When the copy framebuffer is in use, we must also have the standard U-Boot framebuffer available. Update the FSP driver to support this. Signed-off-by: Simon Glass --- arch/x86/lib/fsp/fsp_graphics.c | 12 1 file changed, 12 insertions(+) diff --git

[PATCH 21/26] video: Correctly handle multiple framebuffers

2020-05-19 Thread Simon Glass
At present video_bottom is set to the bottom of each framebuffer when it is allocated. This is not correct, since it should hold the bottom of the entire area available for framebuffers. Fix this by adding a private address in the uclass which keeps track of the next available spot for a

[PATCH 17/26] video: Add comments to struct sandbox_sdl_plat

2020-05-19 Thread Simon Glass
This struct is not commented but needs it. Also fix the comment in check_vidconsole_output() about the encoding for the rotation value. Signed-off-by: Simon Glass --- include/dm/test.h | 14 +- test/dm/video.c | 3 ++- 2 files changed, 15 insertions(+), 2 deletions(-) diff

[PATCH 18/26] video: sandbox: Add support for the copy framebuffer

2020-05-19 Thread Simon Glass
Enable this feature on sandbox by updating the SDL driver to have two framebuffers. Update the video tests to check that the copy framebuffer is kept in sync. Signed-off-by: Simon Glass --- configs/sandbox_defconfig | 1 + drivers/video/sandbox_sdl.c | 9 +- test/dm/video.c

[PATCH 19/26] video: pci: Set up the copy framebuffer

2020-05-19 Thread Simon Glass
When using a copy framebuffer we need to tell the video subsystem its address. U-Boot's normally allocated framebuffer is used as the working buffer, but nothing is displayed until it is copied to the copy framebuffer. For this to work the video driver must request that a framebuffer be allocated

[PATCH 15/26] video: Update rotated console to support copy buffer

2020-05-19 Thread Simon Glass
Update the implementation to keep a track of what it changes in the frame buffer and then tell the copy buffer about it. Use the special vidconsole_memmove() helper so that memmove() operations are also reflected in the copy buffer. Signed-off-by: Simon Glass --- drivers/video/console_rotate.c

[PATCH 16/26] video: Update the copy framebuffer when writing bitmaps

2020-05-19 Thread Simon Glass
Adjust the bitmap code to sync to the copy framebuffer when done. Signed-off-by: Simon Glass --- drivers/video/video_bmp.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/video/video_bmp.c b/drivers/video/video_bmp.c index eb9636541d..732ce3bcc1

[PATCH 14/26] video: Update truetype console to support copy buffer

2020-05-19 Thread Simon Glass
Update the implementation to keep a track of what it changes in the frame buffer and then tell the copy buffer about it. Use the special vidconsole_memmove() helper so that memmove() operations are also reflected in the copy buffer. Signed-off-by: Simon Glass ---

[PATCH 13/26] video: Update normal console to support copy buffer

2020-05-19 Thread Simon Glass
Update the implementation to keep a track of what it changes in the frame buffer and then tell the copy buffer about it. Use the special vidconsole_memmove() helper so that memmove() operations are also reflected in the copy buffer. Signed-off-by: Simon Glass --- drivers/video/console_normal.c

[PATCH 11/26] video: Clear the copy framebuffer when clearing the screen

2020-05-19 Thread Simon Glass
Update video_clear() to also sync to the copy framebuffer. Signed-off-by: Simon Glass --- drivers/video/video-uclass.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/video/video-uclass.c b/drivers/video/video-uclass.c index 0c97377ea9..4d6f950eab 100644 ---

[PATCH 12/26] video: Add helpers for vidconsole for the copy framebuffer

2020-05-19 Thread Simon Glass
Add a convenience function to call video_sync_copy() for a vidconsole. Also add a memmove() helper, which does the memmove() as well as the sync. Signed-off-by: Simon Glass --- drivers/video/vidconsole-uclass.c | 22 ++ include/video_console.h | 49

[PATCH 10/26] video: Set up the copy framebuffer when enabled

2020-05-19 Thread Simon Glass
This framebuffer is separately mapped. Update the video post-probe function to set this up. Signed-off-by: Simon Glass --- drivers/video/video-uclass.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/video/video-uclass.c b/drivers/video/video-uclass.c index

[PATCH 09/26] video: Add support for copying to a hardware framebuffer

2020-05-19 Thread Simon Glass
Some architectures use a cached framebuffer and flush the cache as needed so that changes are visible. This is supported by U-Boot. However x86 uses an uncached framebuffer with a 'write-combining' feature to speed up writes. Reads are permitted but they are extremely expensive. Unfortunately,

[PATCH 07/26] video: Drop unnecessary #ifdef around vid_console_color()

2020-05-19 Thread Simon Glass
All of the functions in this file only apply if DM_VIDEO is enabled. Drop the #ifdef as it just clutters things up. Add the needed forward declaration. Signed-off-by: Simon Glass --- include/video_console.h | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

[PATCH 02/26] console: Add a way to output to serial only

2020-05-19 Thread Simon Glass
In the video drivers it is useful to print errors while debugging but doing so risks an infinite loop as the debugging info itself may go through the video drivers. Add a new console function that prints information only to the serial device, thus making it safe for use in debugging.

[PATCH 08/26] video: Add a comment for struct video_uc_platdata

2020-05-19 Thread Simon Glass
Add a few notes to explain the purpose of each member of this struct. Signed-off-by: Simon Glass --- include/video.h | 12 1 file changed, 12 insertions(+) diff --git a/include/video.h b/include/video.h index e7c58e86cb..813b5653b0 100644 --- a/include/video.h +++

[PATCH 06/26] video: Adjust rotated console to start at right edge

2020-05-19 Thread Simon Glass
At present when the console is rotated 180 degrees it starts almost a whole character to the left of the right edge (typically 7 pixels with an 8-pixel-wide font). On a display which aligns with the font width, this just wastes space. On a display that does not this can result in x_frac going

[PATCH 04/26] sandbox: video: Allow selection of rotated console

2020-05-19 Thread Simon Glass
Add a devicetree property to select a rotated console. This uses the same encoding as vidconsole itself: 0=normal; 1=90 degrees clockwise, 2=upside down, 3=90 degrees anticlockwise. Signed-off-by: Simon Glass --- drivers/video/sandbox_sdl.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 03/26] video: Show an error when a vidconsole function fails

2020-05-19 Thread Simon Glass
At present these functions fail silently even when debugging, which is not very helpful. Add a way to print a message to the serial output when an error is detected. Signed-off-by: Simon Glass --- drivers/video/vidconsole-uclass.c | 22 +++--- 1 file changed, 19 insertions(+),

[PATCH 05/26] video: Split out expression parts into variables

2020-05-19 Thread Simon Glass
The functions in this file do similar things but not always in the same way. To make the code easier to read and compare, use a separate 'linenum' variable in every function. This is then multiplied by the line length to get the offset within the frame buffer to modify. Also use an 'x' variable to

Re: U-Boot DM device tree and Linux device tree - what are the differences and why?

2020-05-19 Thread Rudolf J Streif
Hi Fabio On 5/19/20 5:23 AM, Fabio Estevam wrote: > Hi Rudolf, > > On Tue, May 19, 2020 at 1:28 AM Rudolf J Streif > wrote: >> I solved the problem with u-boot not recognizing the eMMC. The device >> tree is working now for u-boot. >> >> However, i.MX6 is using SPL which is loaded into OCRAM. If

[PATCH 01/26] x86: fsp: Reinit the FPU after FSP meminit

2020-05-19 Thread Simon Glass
The APL FSP appears to leave the FPU in a bad state in that it has registers in use. This causes an error when the next FPU operation is performed. Work around this by re-resetting the FPU after calling FSP-M. This allows the freetype console to work correctly. Signed-off-by: Simon Glass ---

[PATCH 00/26] x86: video: Speed up the framebuffer

2020-05-19 Thread Simon Glass
Some architectures use a cached framebuffer and flush the cache as needed so that changes are visible. This is supported by U-Boot. However x86 uses an uncached framebuffer with a 'write-combining' feature to speed up writes. Reads are permitted but they are extremely expensive. Unfortunately,

Re: [PATCH v2 1/2] spi: call WATCHDOG_RESET() in spi_nor_wait_till_ready_with_timeout()

2020-05-19 Thread Rasmus Villemoes
On 20/03/2020 11.14, Rasmus Villemoes wrote: > I have a board for which doing "sf erase 0x10 0x8" > consistently causes the external watchdog circuit to reset the > board. Make sure to pet the watchdog during slow operations such as > erasing or writing large areas of a spi nor flash.

Re: [PATCH 2/2] thermal: imx_scu_thermal: fix getting DT alert property value

2020-05-19 Thread Anatolij Gustschin
On Tue, 19 May 2020 11:45:55 + Peng Fan peng@nxp.com wrote: ... > Do you have more insights about uclass_get_device and > uclass_get_device_byname? > uclass_get_device not work, but uclass_get_device_byname work. well, we have three thermal uclass devices on i.MX8QXP: thermal 0 [

[PATCH v2 10/10] test: dm: rtc: add tests of rtc shell command

2020-05-19 Thread Rasmus Villemoes
Signed-off-by: Rasmus Villemoes --- test/dm/rtc.c | 61 +++ 1 file changed, 61 insertions(+) diff --git a/test/dm/rtc.c b/test/dm/rtc.c index 5301805d19..d1d8ff0375 100644 --- a/test/dm/rtc.c +++ b/test/dm/rtc.c @@ -5,6 +5,7 @@ */ #include

[PATCH v2 07/10] rtc: sandbox-rtc: fix set method

2020-05-19 Thread Rasmus Villemoes
The current set method is broken; a simple test case is to first set the date to something in April, then change the date to 31st May: => date 040412122020.34 Date: 2020-04-04 (Saturday)Time: 12:12:34 => date 053112122020.34 Date: 2020-05-01 (Friday)Time: 12:12:34 or via the amending of

[PATCH v2 09/10] test: dm: rtc: add test of rtc_read, rtc_write

2020-05-19 Thread Rasmus Villemoes
Define a few aux registers and check that they can be read/written individually. Also check that one can access the time-keeping registers directly and get the expected results. Signed-off-by: Rasmus Villemoes --- arch/sandbox/include/asm/rtc.h | 5 test/dm/rtc.c | 45

[PATCH v2 08/10] rtc: i2c_rtc_emul: catch any write to the "reset" register

2020-05-19 Thread Rasmus Villemoes
It's more natural that any write that happens to touch the reset register should cause a reset, rather than just a write that starts at that offset. Signed-off-by: Rasmus Villemoes --- drivers/rtc/i2c_rtc_emul.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH v2 01/10] rtc: add rtc_read helper and ->read method

2020-05-19 Thread Rasmus Villemoes
Some users may want to read multiple consecutive 8-bit registers. Instead of each caller having to implement the loop, provide a rtc_read() helper. Also, allow a driver to provide a ->read method, which can be more efficient than reading one register at a time. Reviewed-by: Simon Glass

[PATCH v2 05/10] rtc: pcf2127: provide ->write method

2020-05-19 Thread Rasmus Villemoes
Reviewed-by: Simon Glass Signed-off-by: Rasmus Villemoes --- drivers/rtc/pcf2127.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/rtc/pcf2127.c b/drivers/rtc/pcf2127.c index f48cd8cb18..a3faf62ee0 100644 --- a/drivers/rtc/pcf2127.c +++ b/drivers/rtc/pcf2127.c @@ -42,6 +42,12

[PATCH v2 06/10] rtc: add rtc command

2020-05-19 Thread Rasmus Villemoes
Mostly as an aid for debugging RTC drivers, provide a command that can be used to read/write arbitrary registers (assuming the driver provides the read/write methods or their single-register-at-a-time variants). Signed-off-by: Rasmus Villemoes --- cmd/Kconfig | 6 ++ cmd/Makefile | 1 +

[PATCH v2 03/10] rtc: fall back to ->{read, write} if ->{read, write}8 are not provided

2020-05-19 Thread Rasmus Villemoes
Similar to how the rtc_{read,write} functions fall back to using the {read,write}8 methods, do the opposite in the rtc_{read,write}8 functions. This way, each driver only needs to provide either ->read8 or ->read to make both rtc_read8() and rtc_read() work - without this, a driver that provides

[PATCH v2 02/10] rtc: add rtc_write() helper

2020-05-19 Thread Rasmus Villemoes
Similar to rtc_read(), introduce a helper that allows the caller to write multiple consecutive 8-bit registers with one call. If the driver provides the ->write method, use that, otherwise loop using ->write8. Reviewed-by: Simon Glass Signed-off-by: Rasmus Villemoes ---

[PATCH v2 00/10] new rtc methods, rtc command, and tests

2020-05-19 Thread Rasmus Villemoes
I need access to registers other than just the timekeeping ones of the pcf2127, so I wanted to implement ->read8 and ->write8. But for testing these it appeared there was no convenient way to invoke those from the shell, so I also ended up adding such a command. Also, it seemed more natural to

[PATCH v2 04/10] rtc: pcf2127: provide ->read method

2020-05-19 Thread Rasmus Villemoes
This simply consists of renaming the existing pcf2127_read_reg() helper to follow the naming of the other methods (i.e. pcf2127_rtc_) and changing the type of its "len" parameter. Reviewed-by: Simon Glass Signed-off-by: Rasmus Villemoes --- drivers/rtc/pcf2127.c | 6 +++--- 1 file changed, 3

Re: [PATCH] doc: rockchip: Update documentation with Rock Pi 4

2020-05-19 Thread Walter Lozano
Hi Tom, On 19/5/20 18:02, Tom Rini wrote: On Tue, May 19, 2020 at 05:29:31PM -0300, Walter Lozano wrote: Hi Jagan On 19/5/20 15:57, Jagan Teki wrote: On Wed, May 20, 2020 at 12:15 AM Walter Lozano wrote: Update README.rockchip to reflect the support of Radxa Rock Pi 4 Signed-off-by:

Re: [PATCH] doc: rockchip: Update documentation with Rock Pi 4

2020-05-19 Thread Tom Rini
On Tue, May 19, 2020 at 05:29:31PM -0300, Walter Lozano wrote: > Hi Jagan > > On 19/5/20 15:57, Jagan Teki wrote: > > On Wed, May 20, 2020 at 12:15 AM Walter Lozano > > wrote: > > > Update README.rockchip to reflect the support of Radxa Rock Pi 4 > > > > > > Signed-off-by: Walter Lozano > > >

Re: [PATCH] doc: rockchip: Update documentation with Rock Pi 4

2020-05-19 Thread Walter Lozano
Hi Jagan On 19/5/20 15:57, Jagan Teki wrote: On Wed, May 20, 2020 at 12:15 AM Walter Lozano wrote: Update README.rockchip to reflect the support of Radxa Rock Pi 4 Signed-off-by: Walter Lozano --- doc/README.rockchip | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) We have

Re: [PATCH v2 5/5] mtd: spi: Use CONFIG_IS_ENABLED to prevent ifdef

2020-05-19 Thread Jagan Teki
On Thu, May 14, 2020 at 11:41 PM Jagan Teki wrote: > > Use CONFIG_IS_ENABLED to prevent ifdef in sf_probe.c > > Cc: Simon Glass > Cc: Vignesh R > Cc: Daniel Schwierzeck > Signed-off-by: Jagan Teki > --- Applied to u-boot-spi/master

Re: [PATCH 4/5] mtd: sf: Drop plat from sf_probe

2020-05-19 Thread Jagan Teki
On Fri, May 15, 2020 at 12:47 PM Pratyush Yadav wrote: > > On 14/05/20 05:41PM, Jagan Teki wrote: > > dm_spi_slave_platdata used in sf_probe for printing > > plat->cs value and there is no relevant usage apart > > from this. > > > > We have enouch debug messages available in SPI and SF > >

Re: [PATCH 2/5] cmd: sf Drop reassignment of new into flash

2020-05-19 Thread Jagan Teki
On Thu, May 14, 2020 at 5:42 PM Jagan Teki wrote: > > The new pointer points to flash found and that would > assign it to global 'flash' pointer for further flash > operations and also keep track of old flash pointer. > > This would happen if the probe is successful or even > failed, but current

[PATCH v2 7/9] sifive: fu540: Mark the default env as SPI flash

2020-05-19 Thread Jagan Teki
Mark the default U-Boot environment as SPI flash since this is an on board flash device. Reviewed-by: Bin Meng Signed-off-by: Jagan Teki --- Changes for v2: - none board/sifive/fu540/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/board/sifive/fu540/Kconfig

[PATCH v2 9/9] sifive: fu540: Enable SF distro bootcmd

2020-05-19 Thread Jagan Teki
Enable SPI flash(SF) distro boot command in Sifive FU540. This distro boot will read the boot script at specific location at the flash and start sourcing the same. Included the SF device at the last of the target devices list since all the rest of the devices on the list have more possibility to

[PATCH v4] net: tftp: Add client support for RFC 7440

2020-05-19 Thread Ramon Fried
Add support for RFC 7440: "TFTP Windowsize Option". This optional feature allows the client and server to negotiate a window size of consecutive blocks to send as an alternative for replacing the single-block lockstep schema. windowsize can be defined statically during compilation by setting

[PATCH v2 8/9] sifive: fu540: Add boot flash script offset, size

2020-05-19 Thread Jagan Teki
HiFive-Unleashed-A00 has SPI flash with 32MiB size. So, let's use the script offset at the end of 4K. This way it cannot overlap any offsets being used by software components in flash layout. So, SF distrocmd will pick the script at desired script address and run. Signed-off-by: Jagan Teki ---

[PATCH v2 6/9] env: Enable SPI flash env for SiFive FU540

2020-05-19 Thread Jagan Teki
SPI flash device on HiFive Unleashed has 32MiB Size. This patch add SPI flash environment after U-Boot proper partition with a size of 128KiB. SPI flash partition layout(32MiB): 0 - 34 : reserved for GPT header 35 - 39 : unused 40 - 2087: loader1 (SPL, FSBL) 2088 - 10279

[PATCH v2 5/9] sifive: fu540: Add Booting from SPI

2020-05-19 Thread Jagan Teki
U-Boot SPL 2020.07-rc2-00156-gb9abb0716a-dirty (May 19 2020 - 21:56:17 +0530) Trying to boot from SPI U-Boot 2020.07-rc2-00156-gb9abb0716a-dirty (May 19 2020 - 21:56:17 +0530) CPU: rv64imafdc Model: SiFive HiFive Unleashed A00 DRAM: 8 GiB No reserved memory region found in source FDT MMC:

[PATCH v2 3/9] riscv: dts: fu540-c000-u-boot: Add sifive, fu540-modeselect

2020-05-19 Thread Jagan Teki
Add sifive,fu540-modeselect node, which usually get runtime boot mode of fu540 boards. Signed-off-by: Jagan Teki --- Changes for v2: - new patch arch/riscv/dts/fu540-c000-u-boot.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/riscv/dts/fu540-c000-u-boot.dtsi

[PATCH v2 4/9] drivers: Add fu540 board driver

2020-05-19 Thread Jagan Teki
Add fu540 board driver, which is used to get runtime boot mode of fu540 boards. Cc: Mario Six Cc: Tom Rini Cc: Simon Glass Cc: Jean-Jacques Hiblot Signed-off-by: Jagan Teki --- Changes for v2: - new patch drivers/board/Kconfig | 8 drivers/board/Makefile | 1 +

[PATCH v2 0/9] riscv: sifive/fu540: Booting from SPI

2020-05-19 Thread Jagan Teki
This series support Boot from SPI on SiFive FU540 HiFive Unleashed board, with improved version of detecting bootmode at runtime. Previous version changes are at [1]. Changes for v2: - fu540 board driver - runtime bootmode detection - rebase on Pragnesh v11 series [1]

[PATCH v2 2/9] dt-bindings: board: Document sifive,fu540-modeselect

2020-05-19 Thread Jagan Teki
Add dt-bindings documentation for sifive,fu540-modeselect board driver, which usually get runtime boot mode of fu540 boards. Cc: Simon Glass Signed-off-by: Jagan Teki --- Changes for v2: - new patch .../board/sifive,fu540-modeselect.txt | 15 +++ 1 file changed, 15

[PATCH v2 1/9] spl: Try to get SPL boot device via board_get_int

2020-05-19 Thread Jagan Teki
Usually, the associated board would supply spl boot device using spl_boot_device() but some boards have board driver that are possible to supply boot device via board_get_int with BOARD_SPL_BOOT_DEVICE id. This patch add support for those. Cc: Mario Six Cc: Tom Rini Cc: Simon Glass Cc:

Re: [PATCH 1/5] mtd: spi: Call sst_write in _write ops

2020-05-19 Thread Jagan Teki
On Thu, May 14, 2020 at 5:41 PM Jagan Teki wrote: > > Currently spi-nor code is assigning _write ops for SST > and other flashes separately. > > Just call the sst_write from generic write ops and return > if SST flash found, this way it avoids the confusion of > multiple write ops assignment

Re: [PATCH] doc: rockchip: Update documentation with Rock Pi 4

2020-05-19 Thread Jagan Teki
On Wed, May 20, 2020 at 12:15 AM Walter Lozano wrote: > > Update README.rockchip to reflect the support of Radxa Rock Pi 4 > > Signed-off-by: Walter Lozano > --- > doc/README.rockchip | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) We have doc/board/rockchip please update there.

Re: [PATCH v11 18/18] doc: sifive: fu540: Add description for OpenSBI generic platform

2020-05-19 Thread Jagan Teki
On Tue, May 19, 2020 at 12:35 PM Pragnesh Patel wrote: > > OpenSBI generic platform support provides platform specific > functionality based on the FDT passed by previous booting stage. > > Depends on OpenSBI commit: > platform: Add generic FDT based platform support > (sha1:

  1   2   3   >