Re: [PATCH] mmc: omap_hsmmc: Add guards around omap_hsmmc_get_cfg()

2020-06-04 Thread Lokesh Vutla
On 05/06/20 1:33 am, Tom Rini wrote: > We only call the function omap_hsmmc_get_cfg in the case of OMAP34XX or > when we have to iodelay recalibration. Add guards for these checks as > clang will otherwise warn. > > Cc: Peng Fan > Cc: Lokesh Vutla > Signed-off-by: Tom Rini Reviewed-by:

Re: [PATCH] gpio: omap_gpio: Fix unused function warning in non-DM case

2020-06-04 Thread Lokesh Vutla
On 05/06/20 1:31 am, Tom Rini wrote: > In the case of non-DM_GPIO the function get_gpio_index() will never be > called, and clang will warn about this. Move this to be with the other > non-DM code for easier removal later. > > Cc: Lokesh Vutla > Signed-off-by: Tom Rini Reviewed-by: Lokesh

Re: [PATCH] board: ti: common: Fix pointer-bool-conversion warnings

2020-06-04 Thread Lokesh Vutla
On 05/06/20 1:15 am, Tom Rini wrote: > When building this code with clang-10 a number of warnings will be > generated along the lines of: > warning: address of array 'ep->version' will always evaluate to 'true' > > Convert these checks to checking the strlen of the part of the array we > care

Re: [PATCH v2 17/23] ti: Drop omap5 uevm

2020-06-04 Thread Lokesh Vutla
Hi Jagan, On 27/05/20 6:26 pm, Jagan Teki wrote: > DM, DM_SPI and other driver model migration deadlines > are expired for this board. > > Drop it. > > Cc: Lokesh Vutla > Signed-off-by: Jagan Teki Please hold this patch. I see patches in ML for converting to DM

Re: [PATCH v2 15/23] ti: Drop panda board

2020-06-04 Thread Lokesh Vutla
Hi Jagan, On 27/05/20 6:26 pm, Jagan Teki wrote: > DM, DM_SPI and other driver model migration deadlines > are expired for this board. > > Drop it. > > Cc: Lokesh Vutla > Signed-off-by: Jagan Teki Please hold this patch. I see patches in ML for converting to DM

Re: [PATCH v7 2/3] dm: core: fix dev_read_alias_highest_id() without libfdt

2020-06-04 Thread Simon Glass
On Mon, 1 Jun 2020 at 17:47, Michael Walle wrote: > > If CONFIG_DM_DEV_READ_INLINE is set, dev_read_alias_highest_id() calls > libfdt_get_highest_id(). But this function is only available if we have > libfdt compiled in. If its not available return -1, which matches the > return code for no alias

Re: [PATCH 1/1] smbios: empty strings in smbios_add_string()

2020-06-04 Thread Simon Glass
On Mon, 1 Jun 2020 at 07:44, Heinrich Schuchardt wrote: > > smbios_add_string() cannot deal with empty strings. This leads to incorrect > property values and invalid tables. E.g. for the pine64-lts_defconfig > CONFIG_SMBIOS_MANUFACTURER="". Linux command dmidecode shows: > > Table 1: >

Re: [PATCH] RFC: tiny-dm: Proposal for using driver model in SPL

2020-06-04 Thread Simon Glass
Hi, On Thu, 4 Jun 2020 at 21:11, Simon Glass wrote: > > Hi Walter, > > On Mon, 1 Jun 2020 at 14:55, Walter Lozano > wrote: > > > > Hi Simon, > > > > On 26/5/20 15:39, Walter Lozano wrote: > > > Hi Simon, > > > > > > On 25/5/20 18:40, Simon Glass wrote: > > >> Hi Tom, > > >> > > >> On Mon, 25

[PATCH 1/1] doc: Coccinelle: move to HTML doc

2020-06-04 Thread Heinrich Schuchardt
Move doc/README.coccinelle to doc/develop/coccinelle.rst using the current linux-next version of the text. Signed-off-by: Heinrich Schuchardt --- doc/README.coccinelle | 491 doc/develop/coccinelle.rst | 505 +

Re: [PATCH] RFC: tiny-dm: Proposal for using driver model in SPL

2020-06-04 Thread Simon Glass
Hi Tom, On Tue, 2 Jun 2020 at 07:53, Tom Rini wrote: > > On Mon, Jun 01, 2020 at 05:55:31PM -0300, Walter Lozano wrote: > > Hi Simon, > > > > On 26/5/20 15:39, Walter Lozano wrote: > > > Hi Simon, > > > > > > On 25/5/20 18:40, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Mon, 25 May

Re: [PATCH] RFC: tiny-dm: Proposal for using driver model in SPL

2020-06-04 Thread Simon Glass
Hi Walter, On Mon, 1 Jun 2020 at 14:55, Walter Lozano wrote: > > Hi Simon, > > On 26/5/20 15:39, Walter Lozano wrote: > > Hi Simon, > > > > On 25/5/20 18:40, Simon Glass wrote: > >> Hi Tom, > >> > >> On Mon, 25 May 2020 at 14:57, Tom Rini wrote: > >>> On Mon, May 25, 2020 at 02:34:20PM -0600,

[PATCH 1/1] doc: move Clang documentation to HTML

2020-06-04 Thread Heinrich Schuchardt
* Move README.clang to doc/build/clang.rst and reformat as reStructeredText. * Indicate that -ffixed-r9 and -ffixed-x18 are used to reserve registers for gd. * Minor editing. Signed-off-by: Heinrich Schuchardt --- doc/README.clang| 55

Re: [PATCH v2 8/8] rockchip: puma: enable new usb config options

2020-06-04 Thread Kever Yang
On 2020/6/4 下午6:09, Heiko Stuebner wrote: From: Heiko Stuebner With recently added changes we get support for usb3 including handling of the phys (type-c and inno-usb2), so enable the necessary config options on puma. Signed-off-by: Heiko Stuebner Reviewed-by: Kever Yang Thanks, -

Re: [PATCH v2 7/8] rockchip: puma: drop special handling of usb host regulator

2020-06-04 Thread Kever Yang
On 2020/6/4 下午6:09, Heiko Stuebner wrote: From: Heiko Stuebner With the current usb stack in u-boot, all host ports on puma work flawlessly without any additional special handling, so drop that usb hub hacking from the puma board. Tested with mass-storage and usb-ethernet on both usb3 and

Re: [PATCH v2 6/8] rockchip: puma: remove separate fit generator

2020-06-04 Thread Kever Yang
On 2020/6/4 下午6:09, Heiko Stuebner wrote: From: Heiko Stuebner The introduction of the puma-specific generator was mainly a way to split the pmu firmware from the ATF binary and not having to distribute that 4GB (sparse) image that was created before moving to the bl31.elf as base. Looking

Re: [PATCH v2 5/8] rockchip: puma: reorganize devicetrees to actually work and match upstream

2020-06-04 Thread Kever Yang
Hi Heiko, On 2020/6/4 下午6:09, Heiko Stuebner wrote: index 00..f23ec02783 --- /dev/null +++ b/arch/arm/dts/rk3399-puma-haikou.dts @@ -0,0 +1,272 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Copyright (c) 2017 Theobroma Systems Design und Consulting GmbH + */ + +/dts-v1/;

Re: [PATCH v2 4/8] rockchip: puma: fix indentation of misc_init_r

2020-06-04 Thread Kever Yang
On 2020/6/4 下午6:09, Heiko Stuebner wrote: From: Heiko Stuebner The commit moving puma to the generic cpuid/macaddr helpers used 7 spaces as indentation, so correct that by moving to the required tabs. Fixes: fa177ff0208b ("board: puma: Use rockchip_* helpers to setup cpuid and macaddr")

Re: [PATCH v2 3/8] rockchip: puma: fix indentation for -u-boot.dtsi

2020-06-04 Thread Kever Yang
On 2020/6/4 下午6:09, Heiko Stuebner wrote: From: Heiko Stuebner Tabs not spaces, so transform it to the common styling. Signed-off-by: Heiko Stuebner Reviewed-by: Philipp Tomsich Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3399-puma-u-boot.dtsi | 30

Re: [PATCH v2 2/8] arm64: dts: rk3399-puma: fix gpio levels for vcc5v0-host regulator

2020-06-04 Thread Kever Yang
On 2020/6/4 下午6:09, Heiko Stuebner wrote: From: Heiko Stuebner The regulator enable-gpio uses opposite values for the declaration vs. the enable_active_low property, breaking the regulator enablement. Make the usbhost-supply work again by bringing them in sync again. This mimics the

Re: [PATCH v2 1/8] arm64: dts: rk3399-puma: fix gpio levels for gmac reset pin

2020-06-04 Thread Kever Yang
On 2020/6/4 下午6:09, Heiko Stuebner wrote: From: Heiko Stuebner The gmac reset has opposite values for the gpio declaration and the separate reset-active, bring this in line to make u-boot also find the ethernet-phy. This mimics the upstream Linux commit found on

RE: [PATCH] mmc: omap_hsmmc: Add guards around omap_hsmmc_get_cfg()

2020-06-04 Thread Peng Fan
> Subject: [PATCH] mmc: omap_hsmmc: Add guards around > omap_hsmmc_get_cfg() > > We only call the function omap_hsmmc_get_cfg in the case of OMAP34XX or > when we have to iodelay recalibration. Add guards for these checks as clang > will otherwise warn. > > Cc: Peng Fan > Cc: Lokesh Vutla >

[PATCH] tpm: add TPM2_GetRandom command support

2020-06-04 Thread Dhananjay Phadke
Add support for TPM2 GetRandom command Signed-off-by: Dhananjay Phadke --- include/tpm-v2.h | 13 + lib/tpm-v2.c | 44 2 files changed, 57 insertions(+) diff --git a/include/tpm-v2.h b/include/tpm-v2.h index ae00803f6d..513697e9a1

Re: [PATCH] serial: Convert ARM_DCC to Kconfig

2020-06-04 Thread Tom Rini
On Tue, Jun 02, 2020 at 05:26:33PM -0400, Tom Rini wrote: > The symbol "CONFIG_ARM_DCC" is used to control building > drivers/serial/arm_dcc.c. Provide a simple Kconfig entry for this. > > Cc: Luca Ceresoli > Cc: Michal Simek > Cc: Tom McLeod > Cc: Mike Looijmans > Signed-off-by: Tom Rini

Re: [PATCH] serial: Add missing Kconfig dependencies for debug consoles

2020-06-04 Thread Tom Rini
On Thu, May 28, 2020 at 12:05:12PM +0200, Michal Simek wrote: > Debug console is the part of serial driver in the same file. It means to be > able to enable debug console you also need to enable driver itself. > That's why add all dependecies and list only debug consoles which are > enabled based

Re: [PATCH 6/8] Convert CONFIG_BZIP2 et al to Kconfig

2020-06-04 Thread Tom Rini
On Tue, May 26, 2020 at 03:06:17PM -0400, Tom Rini wrote: > This converts the following to Kconfig: >CONFIG_BZIP2 >CONFIG_GZIP >CONFIG_LZO >CONFIG_ZLIB >CONFIG_LZMA >CONFIG_LZO > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc

Re: [PATCH 5/8] topic_miami: Disable GPIO

2020-06-04 Thread Tom Rini
On Tue, May 26, 2020 at 03:06:16PM -0400, Tom Rini wrote: > Per the boards config header file, there is no useful GPIO on these > boards. Remove CONFIG_CMD_GPIO from the defconfigs. > > Cc: Mike Looijmans > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc

Re: [PATCH 8/8] Convert CONFIG_BOARD_LATE_INIT to Kconfig

2020-06-04 Thread Tom Rini
On Tue, May 26, 2020 at 03:06:19PM -0400, Tom Rini wrote: > This converts the following to Kconfig: >CONFIG_BOARD_LATE_INIT > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 7/8] Convert CONFIG_CMD_ASKENV et al to Kconfig

2020-06-04 Thread Tom Rini
On Tue, May 26, 2020 at 03:06:18PM -0400, Tom Rini wrote: > This converts the following to Kconfig: >CONFIG_CMD_ASKENV >CONFIG_CMD_BMP >CONFIG_CMD_BOOTD >CONFIG_CMD_CACHE >CONFIG_CMD_CRC32 >CONFIG_CMD_DHCP >CONFIG_CMD_ENV >CONFIG_CMD_EXPORTENV >CONFIG_CMD_EXT2

Re: [PATCH 3/8] bcmstb: Migrate CONFIG_CMD_EXT[24]

2020-06-04 Thread Tom Rini
On Tue, May 26, 2020 at 03:06:14PM -0400, Tom Rini wrote: > The common config header for bcm7260 and bcm7445 enable > CONFIG_CMD_EXT2/EXT4 but the defconfigs do not. This results in the > commands being disabled. Enable them via the defconfig. > > Cc: Thomas Fitzsimmons > Signed-off-by: Tom

Re: [PATCH 6/6] checkpatch.pl: Request if() instead #ifdef

2020-06-04 Thread Tom Rini
On Fri, May 22, 2020 at 04:32:40PM -0600, Simon Glass wrote: > There is a lot of use of #ifdefs in U-Boot. In an effort reduce this, > suggest using the compile-time construct. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 4/8] ARM: rmobile: blanche: Disable CONFIG_CMD_SF / CONFIG_CMD_SPI

2020-06-04 Thread Tom Rini
On Tue, May 26, 2020 at 03:06:15PM -0400, Tom Rini wrote: > The config header for this platform disables both CMD_SF and CMD_SPI and > the defconfig leaves them enabled. Disable them from the defconfig and > enable them in the header. > > Cc: Marek Vasut > Cc: Masakazu Mochizuki >

Re: [PATCH 2/8] mx6memcal: Finish migration to defconfig options

2020-06-04 Thread Tom Rini
On Tue, May 26, 2020 at 03:06:13PM -0400, Tom Rini wrote: > The config header for this platform uses '#undef' in a number of cases. > All of the MMC related ones were already handled correctly in the > defconfig file. In the case of CONFIG_CMD_FUSE, the command was being > built and enabled via

Re: [PATCH 1/8] pfla02: Rework excluding NAND from SPL

2020-06-04 Thread Tom Rini
On Tue, May 26, 2020 at 03:06:12PM -0400, Tom Rini wrote: > Rather than only enable CONFIG_CMD_NAND for non-SPL builds, move the CMD > options to defconfig and rework the guards to not try and call the > function in SPL builds. > > Cc: Stefano Babic > Signed-off-by: Tom Rini > Acked-by:

Re: [PATCHv2] checkpatch.pl: Add check for defining CONFIG_CMD_xxx via config files

2020-06-04 Thread Tom Rini
On Tue, May 26, 2020 at 02:29:02PM -0400, Tom Rini wrote: > All of our cmds have a Kconfig entry. Making enabling a CMD via the > config file an error to checkpatch.pl. > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 1/6] checkpatch.pl: Update to v5.7-rc6

2020-06-04 Thread Tom Rini
On Fri, May 22, 2020 at 04:32:35PM -0600, Simon Glass wrote: > Bring in the newest script. This is close enough to v5.8 that it will > likely be final. Keep the U-Boot changes to $logFunctions > > Signed-off-by: Simon Glass I've moved this to v5.7 itself and reworded to match. Applied to

Re: [PATCH 5/6] checkpatch.pl: Request a test when a new command is added

2020-06-04 Thread Tom Rini
On Fri, May 22, 2020 at 04:32:39PM -0600, Simon Glass wrote: > This request is made with nearly every new command. Point to some docs > on how to do it. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 3/6] checkpatch.pl: Add a check for tests needed for uclasses

2020-06-04 Thread Tom Rini
On Fri, May 22, 2020 at 04:32:37PM -0600, Simon Glass wrote: > A common problem when submitting a new uclass is to forget to add sandbox > tests. Add a warning for this. > > Of course tests should always be added for new code, but this one seems to > be missed by nearly every new contributor. >

Re: [PATCH 2/6] checkpatch.pl: Add a U-Boot option

2020-06-04 Thread Tom Rini
On Fri, May 22, 2020 at 04:32:36PM -0600, Simon Glass wrote: > Add an option to indicate that U-Boot-specific checks should be enabled. > Add a function to house the code that will be added. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description:

Re: [PATCH 4/6] checkpatch.pl: Warn if the flattree API is used

2020-06-04 Thread Tom Rini
On Fri, May 22, 2020 at 04:32:38PM -0600, Simon Glass wrote: > We want people to use the livetree API, so request it. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] usb: eth: lan78xx: Fix logic in lan78xx_read_otp() to avoid a warning

2020-06-04 Thread Marek Vasut
On 6/4/20 10:35 PM, Tom Rini wrote: > In lan78xx_read_otp() we want to know if sig is LAN78XX_OTP_INDICATOR_1 > or LAN78XX_OTP_INDICATOR_2. In the case of matching the first one we > set offset to itself, and clang warns about this. Rework the logic so > that if sig is the second indicator we

Re: [PATCH v5 05/21] arm: mvebu: x530: Disable smart hwcaps selection

2020-06-04 Thread Chris Packham
On 5/06/20 12:44 am, Pratyush Yadav wrote: > The option SPI_FLASH_SMART_HWCAPS will be introduced in a future commit. > It is enabled by default. It updates the hwcaps selection of SPI NOR to > use the SPI MEM's supports_op() hook. But this leads to a code size > increase and so the SPL binary

[PATCH v3 2/6] sifive: fu540: Add Booting from SPI

2020-06-04 Thread Jagan Teki
Add booting from SPI for SiFive Unleashed board. Signed-off-by: Jagan Teki --- Changes for v3: - updated based on master arch/riscv/cpu/fu540/Kconfig | 2 + .../dts/hifive-unleashed-a00-u-boot.dtsi | 12 ++ configs/sifive_fu540_defconfig| 4 ++

[PATCH v3 6/6] sifive: fu540: Enable SF distro bootcmd

2020-06-04 Thread Jagan Teki
Enable SPI flash(SF) distro boot command in Sifive FU540. This distro boot will read the boot script at specific location at the flash and start sourcing the same. Included the SF device at the last of the target devices list since all the rest of the devices on the list have more possibility to

[PATCH v3 4/6] sifive: fu540: Mark the default env as SPI flash

2020-06-04 Thread Jagan Teki
Mark the default U-Boot environment as SPI flash since this is an on board flash device. Reviewed-by: Bin Meng Signed-off-by: Jagan Teki --- Changes for v3: - none board/sifive/fu540/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/board/sifive/fu540/Kconfig

[PATCH v3 5/6] sifive: fu540: Add boot flash script offset, size

2020-06-04 Thread Jagan Teki
HiFive-Unleashed-A00 has SPI flash with 32MiB size. So, let's use the script offset at the end of 4K. This way it cannot overlap any offsets being used by software components in flash layout. So, SF distrocmd will pick the script at desired script address and run. Signed-off-by: Jagan Teki ---

[PATCH v3 3/6] env: Enable SPI flash env for SiFive FU540

2020-06-04 Thread Jagan Teki
SPI flash device on HiFive Unleashed has 32MiB Size. This patch add SPI flash environment after U-Boot proper partition with a size of 128KiB. SPI flash partition layout(32MiB): 0 - 34 : reserved for GPT header 35 - 39 : unused 40 - 2087: loader1 (SPL, FSBL) 2088 - 10279

[PATCH v3 1/6] sifive: fu540: Add runtime boot mode detection

2020-06-04 Thread Jagan Teki
Add support to detect boot mode at runtime for SiFive FU540 boards. Signed-off-by: Jagan Teki --- Changes for v3: - new patch board/sifive/fu540/fu540.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/board/sifive/fu540/fu540.c

[PATCH v3 0/6] riscv: sifive/fu540: SPI boot

2020-06-04 Thread Jagan Teki
Updated series with boot device detection directly on spl_boot_device function instead of having separate board driver. Previous version changes are at [1]. Changes for v3: - fixed env definitions build - added boot device detection in board Changes for v2: - fu540 board driver - runtime

[PATCH] usb: eth: lan78xx: Fix logic in lan78xx_read_otp() to avoid a warning

2020-06-04 Thread Tom Rini
In lan78xx_read_otp() we want to know if sig is LAN78XX_OTP_INDICATOR_1 or LAN78XX_OTP_INDICATOR_2. In the case of matching the first one we set offset to itself, and clang warns about this. Rework the logic so that if sig is the second indicator we adjust the offset as today and if it does not

Re: [PATCH u-boot] eth/r8152: update the firmware

2020-06-04 Thread Marek Vasut
On 6/4/20 5:45 AM, Hayes Wang wrote: > Marek Vasut [mailto:ma...@denx.de] >> Sent: Tuesday, June 02, 2020 7:59 PM > [...] >> Can you be more specific about the problem you are fixing here ? >> What is the problem ? > > There is low probability that the device may be lost when

Re: [PATCH] usb: musb-new: Fix unused function warnings from clang

2020-06-04 Thread Marek Vasut
On 6/4/20 10:09 PM, Tom Rini wrote: > The functions dsps_readb and dsps_writeb are only used by code that is > under a !__UBOOT__ guard today. Add that guard around these functions > as well to avoid the warning. > > Cc: Marek Vasut > Signed-off-by: Tom Rini Reviewed-by: Marek Vasut

[PATCH] usb: musb-new: Fix unused function warnings from clang

2020-06-04 Thread Tom Rini
The functions dsps_readb and dsps_writeb are only used by code that is under a !__UBOOT__ guard today. Add that guard around these functions as well to avoid the warning. Cc: Marek Vasut Signed-off-by: Tom Rini --- drivers/usb/musb-new/musb_dsps.c | 4 1 file changed, 4 insertions(+)

[PATCH] usb: gadget: ether: Fix warnings about unused code

2020-06-04 Thread Tom Rini
When building this with clang we see a few new warnings. There are a handful of structs that we declare and use only in the case of !defined(CONFIG_USB_ETH_CDC) && defined(CONFIG_USB_ETH_SUBSET) so update the guards used to match this as well as cover all members rather than just a few. Finally,

[PATCH] net: cpsw: Add __maybe_unused to generated inlines

2020-06-04 Thread Tom Rini
We generate a number of helper inline functions to make accesses easier. However not all permutations of each function will be used and clang will warn about unused ones. Decorate all of them with __maybe_unused because of this. Cc: Lokesh Vutla Signed-off-by: Tom Rini ---

[PATCH] mmc: omap_hsmmc: Add guards around omap_hsmmc_get_cfg()

2020-06-04 Thread Tom Rini
We only call the function omap_hsmmc_get_cfg in the case of OMAP34XX or when we have to iodelay recalibration. Add guards for these checks as clang will otherwise warn. Cc: Peng Fan Cc: Lokesh Vutla Signed-off-by: Tom Rini --- Aside, Lokesh, can you please add drivers/mmc/omap_hsmmc.c to the

[PATCH] gpio: omap_gpio: Fix unused function warning in non-DM case

2020-06-04 Thread Tom Rini
In the case of non-DM_GPIO the function get_gpio_index() will never be called, and clang will warn about this. Move this to be with the other non-DM code for easier removal later. Cc: Lokesh Vutla Signed-off-by: Tom Rini --- drivers/gpio/omap_gpio.c | 9 - 1 file changed, 4

[PATCH] board: ti: am335x_evm: Remove duplicate setting of bd_ram_ofs member

2020-06-04 Thread Tom Rini
With clang we get a report that we are setting this member twice. Fortunately it is to the same value, so drop the hard-coded value line. Signed-off-by: Tom Rini --- board/ti/am335x/board.c | 1 - 1 file changed, 1 deletion(-) diff --git a/board/ti/am335x/board.c b/board/ti/am335x/board.c

[PATCH] board: ti: common: Fix pointer-bool-conversion warnings

2020-06-04 Thread Tom Rini
When building this code with clang-10 a number of warnings will be generated along the lines of: warning: address of array 'ep->version' will always evaluate to 'true' Convert these checks to checking the strlen of the part of the array we care about. As this array will be null terminated

[PATCH] crypto/fsl: fix unaligned access

2020-06-04 Thread Michael Walle
On aarch64 running with dcache off, will result in an unaligned access exception: => dcache off => hash sha1 $kernel_addr_r 100 "Synchronous Abort" handler, esr 0x9661 elr: 960317d8 lr : 960316a4 (reloc) elr: fbd787d8 lr : fbd786a4 [..] The

Re: [U-Boot] Pull request: u-boot-riscv/master

2020-06-04 Thread Tom Rini
On Thu, Jun 04, 2020 at 10:18:07AM +0800, ub...@andestech.com wrote: > Hi Tom, > > Please pull some riscv updates: > > - Fixes 7e249bc13aaf: ("riscv: Move all SMP related SBI calls to SBI_v01") >Move sbi_probe_extension() out of CONFIG_SBI_V01. > - SiFive FU540 support SPL. > > Thanks >

Re: [PATCH v4] net: tftp: Add client support for RFC 7440

2020-06-04 Thread Ravik Hasija
On Wed, Jun 3, 2020 at 5:55 AM Ravik Hasija rahasij@.microsoft wrote: > > Ramon Fried-4 wrote > > + if (strcmp((char *)pkt + i, "windowsize") == 0) { > > For servers that doesnt support windowsize option the above check could > > result in accessing memory outside of valid

[PATCH 1/2] cmd: booti: Fix spelling of "environment".

2020-06-04 Thread Vagrant Cascadian
Signed-off-by: Vagrant Cascadian --- cmd/booti.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/booti.c b/cmd/booti.c index ae37975494..af0603b96e 100644 --- a/cmd/booti.c +++ b/cmd/booti.c @@ -141,7 +141,7 @@ static char booti_help_text[] = "\tspecifying the

[PATCH 2/2] doc: sifive: Fix spelling of "environment".

2020-06-04 Thread Vagrant Cascadian
Signed-off-by: Vagrant Cascadian --- doc/board/sifive/fu540.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/board/sifive/fu540.rst b/doc/board/sifive/fu540.rst index 43402cb2e5..39fb8d8990 100644 --- a/doc/board/sifive/fu540.rst +++ b/doc/board/sifive/fu540.rst

[PATCH 1/1] sandbox: handling out of memory

2020-06-04 Thread Heinrich Schuchardt
assert() only works in debug mode. So checking a successful memory allocation should not use assert(). Signed-off-by: Heinrich Schuchardt --- arch/sandbox/cpu/state.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/sandbox/cpu/state.c b/arch/sandbox/cpu/state.c

Re: [PULL] u-boot-atmel-fixes-2020.07-a

2020-06-04 Thread Tom Rini
On Thu, Jun 04, 2020 at 03:26:24PM +, eugen.hris...@microchip.com wrote: > On 04.06.2020 18:05, Tom Rini wrote: > > > > Applied to u-boot/master, thanks! > > > But please note that building for all of "sama5" gives a ton of device > > tree warnings, can you please look in to them?

[PATCH 1/1] efi_loader: comments EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL

2020-06-04 Thread Heinrich Schuchardt
Provide missing comments for the functions implementing the EFI_SIMPLE_TEXT_OUTPUT_PROTOCOL. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_console.c | 124 --- 1 file changed, 115 insertions(+), 9 deletions(-) diff --git

Re: [PATCH v4 1/2] net: cortina_ni: Add eth support for Cortina Access CAxxxx SoCs

2020-06-04 Thread Ramon Fried
On Wed, Jun 3, 2020 at 11:05 AM Alex Nemirovsky wrote: > > From: Aaron Tseng > > Add Cortina Access Ethernet device driver for CA SoCs. > This driver supports only the DM_ETH network model. > > Signed-off-by: Aaron Tseng > Signed-off-by: Alex Nemirovsky > > CC: Joe Hershberger > CC: Abbie

Re: [PATCH v4] net: tftp: Add client support for RFC 7440

2020-06-04 Thread Ramon Fried
On Wed, Jun 3, 2020 at 5:55 AM Ravik Hasija wrote: > > Ramon Fried-4 wrote > > + if (strcmp((char *)pkt + i, "windowsize") == 0) { > > For servers that doesnt support windowsize option the above check could > > result in accessing memory outside of valid range. Please check

Re: [PATCH v2 5/6] crypto/fsl: instantiate the RNG with prediciton resistance

2020-06-04 Thread Michael Walle
Am 2020-06-04 17:46, schrieb Michael Walle: If it is already instantiated tear it down first and then reinstanciate it again with prediction resistance. Signed-off-by: Michael Walle --- drivers/crypto/fsl/desc.h| 2 ++ drivers/crypto/fsl/jobdesc.c | 12 ++-

Re: [PATCH 06/10] dtoc: extend dtoc to use struct driver_info when linking nodes

2020-06-04 Thread Simon Glass
On Fri, 29 May 2020 at 12:15, Walter Lozano wrote: > > In the current implementation, when dtoc parses a dtb to generate a struct > platdata it converts the information related to linked nodes as pointers > to struct platdata of destination nodes. By doing this, it makes > difficult to get

Re: [PATCH 02/10] dtoc: add option to disable warnings

2020-06-04 Thread Simon Glass
Hi Walter, On Fri, 29 May 2020 at 12:15, Walter Lozano wrote: > > As dtoc now performs checks for valid driver names, when running dtoc > tests several warnings arise as these tests don't use valid driver > names. > > This patch adds an option to disable those warning, which is only > intended

Re: [PATCH 09/10] dtoc: update dtb_platdata to support cd-gpios

2020-06-04 Thread Simon Glass
On Fri, 29 May 2020 at 12:15, Walter Lozano wrote: > > Currently dtoc does not support the property cd-gpios used to declare > the gpios for card detect in mmc. > > This patch adds support to cd-gpios property. > > Signed-off-by: Walter Lozano > --- > tools/dtoc/dtb_platdata.py | 13

Re: [PATCH 08/10] dtoc: update tests to match new platdata

2020-06-04 Thread Simon Glass
On Fri, 29 May 2020 at 12:15, Walter Lozano wrote: > > After using a new approach to link nodes when OF_PLATDATA is enabled > the test cases need to be update. > > This patch updates the tests based on this new implementation. > > Signed-off-by: Walter Lozano > --- > tools/dtoc/test_dtoc.py |

Re: [PATCH 04/10] core: drop const for struct driver_info

2020-06-04 Thread Simon Glass
On Fri, 29 May 2020 at 12:15, Walter Lozano wrote: > > In order to prepare for a new support of phandle when OF_PLATDATA is used > drop the const for struct driver_info as this struct will need to be > updated on runtime. > > Signed-off-by: Walter Lozano > --- > drivers/core/device.c| 2

Re: [PATCH 05/10] core: extend struct driver_info to point to device

2020-06-04 Thread Simon Glass
Hi Walter, On Fri, 29 May 2020 at 12:15, Walter Lozano wrote: > > Currently when creating an U_BOOT_DEVICE entry a struct driver_info > is declared, which contains the data needed to instantiate the device. > However, the actual device is created at runtime and there is no proper > way to get

Re: [PATCH 10/10] dtoc add test for cd-gpios

2020-06-04 Thread Simon Glass
On Fri, 29 May 2020 at 12:15, Walter Lozano wrote: > > Add a test for dtoc taking into account the cd-gpios property. > > Signed-off-by: Walter Lozano > --- > tools/dtoc/dtoc_test_phandle_cd_gpios.dts | 42 ++ > tools/dtoc/test_dtoc.py | 67 +++

Re: [PATCH 07/10] dm: doc: update of-plat with new phandle support

2020-06-04 Thread Simon Glass
On Fri, 29 May 2020 at 12:15, Walter Lozano wrote: > > Update documentation to reflect the new phandle support when OF_PLATDATA > is used. Now phandles are implemented as pointers to U_BOOT_DEVICE, > which makes it possible to get a pointer to the actual device. > > Signed-off-by: Walter Lozano

Re: [PATCH 01/10] dtoc: add support to scan drivers

2020-06-04 Thread Simon Glass
Hi Walter, On Fri, 29 May 2020 at 12:15, Walter Lozano wrote: > > Currently dtoc scans dtbs to convert them to struct platdata and > to generate U_BOOT_DEVICE entries. These entries need to be filled > with the driver name, but at this moment the information used is the > compatible name present

Re: [PATCH 03/10] dm: doc: update of-plat with the suppor for driver aliases

2020-06-04 Thread Simon Glass
On Fri, 29 May 2020 at 12:15, Walter Lozano wrote: > > Update the documentation with the support for driver aliases using > U_BOOT_DRIVER_ALIAS. > > Signed-off-by: Walter Lozano > --- > doc/driver-model/of-plat.rst | 14 +- > 1 file changed, 13 insertions(+), 1 deletion(-) >

Re: Re: [PATCH v2 00/35] dm: Add programmatic generation of ACPI tables (part B)

2020-06-04 Thread Simon Glass
Hi Wolfgang, On Thu, 4 Jun 2020 at 07:27, Wolfgang Wallner wrote: > > Hi Simon, > > -"U-Boot" schrieb: - > > Betreff: Antwort: Re: [PATCH v2 00/35] dm: Add programmatic generation of > > ACPI tables (part B) > > > > Hi Bin, > > > > -"Bin Meng" schrieb: - > > > Betreff: Re:

[PATCH v2 4/6] crypto/fsl: don't regenerate secure keys

2020-06-04 Thread Michael Walle
The secure keys (TDKEK, JDKEK, TDSK) can only be generated once after a POR. Otherwise the RNG4 will throw an error. Signed-off-by: Michael Walle --- drivers/crypto/fsl/jobdesc.c | 4 ++-- drivers/crypto/fsl/jobdesc.h | 2 +- drivers/crypto/fsl/jr.c | 9 + include/fsl_sec.h

[PATCH v2 2/6] crypto/fsl: export caam_get_era()

2020-06-04 Thread Michael Walle
We need the era in other modules, too. For example, to get the RNG version. Signed-off-by: Michael Walle Reviewed-by: Horia Geantă --- drivers/crypto/fsl/sec.c | 10 +- include/fsl_sec.h| 2 ++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git

[PATCH v2 6/6] crypto/fsl: add RNG support

2020-06-04 Thread Michael Walle
Register the random number generator with the rng subsystem in u-boot. This way it can be used by EFI as well as for the 'rng' command. Signed-off-by: Michael Walle --- drivers/crypto/fsl/Kconfig | 14 ++ drivers/crypto/fsl/Makefile | 1 + drivers/crypto/fsl/jobdesc.c | 10 +

[PATCH v2 5/6] crypto/fsl: instantiate the RNG with prediciton resistance

2020-06-04 Thread Michael Walle
If it is already instantiated tear it down first and then reinstanciate it again with prediction resistance. Signed-off-by: Michael Walle --- drivers/crypto/fsl/desc.h| 2 ++ drivers/crypto/fsl/jobdesc.c | 12 ++- drivers/crypto/fsl/jobdesc.h | 2 ++ drivers/crypto/fsl/jr.c | 66

[PATCH v2 3/6] crypto/fsl: support newer SEC modules

2020-06-04 Thread Michael Walle
Since Era 10, the version registers changed. Add the version registers and use them on newer modules. Signed-off-by: Michael Walle Reviewed-by: Horia Geantă --- drivers/crypto/fsl/jr.c | 12 -- include/fsl_sec.h | 51 +++-- 2 files changed, 54

[PATCH v2 0/6] crypto/fsl: add RNG support

2020-06-04 Thread Michael Walle
First, improve the compatibility on newer Era CAAMs. These introduced new version registers. Secondly, add RNG support for the CAAM. This way we get random number generator support for EFI for free and KASLR will work with ARM64 kernels booted with bootefi. Changes since v1: - instantiate RNG

[PATCH v2 1/6] crypto/fsl: make SEC%u status line consistent

2020-06-04 Thread Michael Walle
Align the status line with all the other output in U-Boot. Before the change: DDR3.9 GiB (DDR3, 32-bit, CL=11, ECC on) SEC0: RNG instantiated WDT: Started with servicing (60s timeout) After the change: DDR3.9 GiB (DDR3, 32-bit, CL=11, ECC on) SEC0: RNG instantiated WDT: Started with

Re: [PATCH 4/4] crypto/fsl: add RNG support

2020-06-04 Thread Heinrich Schuchardt
On 04.06.20 15:20, Michael Walle wrote: > Am 2020-06-04 14:58, schrieb Heinrich Schuchardt: >> On 04.06.20 14:52, Michael Walle wrote: >>> Am 2020-06-04 14:26, schrieb Heinrich Schuchardt: On 04.06.20 10:05, Horia Geantă wrote: > On 6/4/2020 5:31 AM, Heinrich Schuchardt wrote: >>> >

[PATCH] sata_sil: make it buildable with DM_PCI

2020-06-04 Thread Marcin Juszkiewicz
Linker complained about lack of `pci_virt_to_mem` function. Looks like driver was not ready for device model - I took solution from e1000.c driver. Signed-off-by: Marcin Juszkiewicz --- drivers/ata/sata_sil.c | 4 1 file changed, 4 insertions(+) diff --git drivers/ata/sata_sil.c

Re: [PULL] u-boot-atmel-fixes-2020.07-a

2020-06-04 Thread Eugen.Hristev
On 04.06.2020 18:05, Tom Rini wrote: > Applied to u-boot/master, thanks! > But please note that building for all of "sama5" gives a ton of device > tree warnings, can you please look in to them? Thanks! Hi Tom, Any changes in the DTC version or something? there are no changes in the

[PATCH] test_sleep.py: make sleep time and margin configurable

2020-06-04 Thread Heiko Schocher
make the sleep time and the margin configurable. Signed-off-by: Heiko Schocher --- travis build: https://travis-ci.org/github/hsdenx/u-boot-test/builds/694545225 This patch is needed as I start test/py now within tbot [1]. On some configurations U-Boot is compiled on a build machine for

[PATCHv3 33/36] configs: T4240RDB: Enable ESPI driver

2020-06-04 Thread Zhiqiang Hou
From: Xiaowei Bao Enable the DM ESPI driver in T4240RDB defconfig. Signed-off-by: Xiaowei Bao Signed-off-by: Hou Zhiqiang --- V3: - No change. configs/T4240RDB_SDCARD_defconfig | 2 ++ configs/T4240RDB_defconfig| 2 ++ 2 files changed, 4 insertions(+) diff --git

[PATCHv3 35/36] dts: P1010RDB: Add eSPI slave DT nodes

2020-06-04 Thread Zhiqiang Hou
From: Hou Zhiqiang Add DT nodes for eSPI slave device SPI flash. Signed-off-by: Hou Zhiqiang --- V3: - No change. arch/powerpc/dts/p1010rdb-pa.dts | 1 + arch/powerpc/dts/p1010rdb-pa_36b.dts | 1 + arch/powerpc/dts/p1010rdb.dtsi | 17 + 3 files changed, 19

[PATCHv3 36/36] configs: P1010RDB: Enable eSPI controller and SPI flash DM driver

2020-06-04 Thread Zhiqiang Hou
From: Hou Zhiqiang Enable the DM_SPI and DM_SPI_FLASH in P1010RDB defconfigs except SECBOOT defconfigs. Signed-off-by: Hou Zhiqiang --- V3: - No change. configs/P1010RDB-PA_36BIT_NAND_defconfig | 2 ++ configs/P1010RDB-PA_36BIT_NOR_defconfig | 2 ++

[PATCHv3 34/36] dts: P1010: Add eSPI controller DT node

2020-06-04 Thread Zhiqiang Hou
From: Hou Zhiqiang Add eSPI controller DT node for P1010. Signed-off-by: Hou Zhiqiang --- V3: - No change. arch/powerpc/dts/p1010si-post.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/powerpc/dts/p1010si-post.dtsi b/arch/powerpc/dts/p1010si-post.dtsi index

[PATCHv3 31/36] dts: T4240: Add ESPI DT nodes

2020-06-04 Thread Zhiqiang Hou
From: Xiaowei Bao Add ESPI controller DT node for T4240. Signed-off-by: Xiaowei Bao Signed-off-by: Hou Zhiqiang --- V3: - Move the eSPI DT node back to path /soc, in v2 the patch command put the eSPI node to the path /cpus by mistake. arch/powerpc/dts/t4240.dtsi | 9 + 1 file

[PATCHv3 32/36] dts: T4240RDB: Add ESPI slave device node

2020-06-04 Thread Zhiqiang Hou
From: Xiaowei Bao Add ESPI slave node for T4240RDB. Signed-off-by: Xiaowei Bao Signed-off-by: Hou Zhiqiang --- V3: - No change. arch/powerpc/dts/t4240rdb.dts | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/powerpc/dts/t4240rdb.dts b/arch/powerpc/dts/t4240rdb.dts

[PATCHv3 30/36] configs: T2080RDB: Enable ESPI driver

2020-06-04 Thread Zhiqiang Hou
From: Xiaowei Bao Enable the DM ESPI driver in T2080RDB defconfig. Signed-off-by: Xiaowei Bao Signed-off-by: Hou Zhiqiang --- V3: - No change. configs/T2080RDB_NAND_defconfig | 2 ++ configs/T2080RDB_SDCARD_defconfig | 2 ++ configs/T2080RDB_SPIFLASH_defconfig | 2 ++

[PATCHv3 29/36] dts: T2080RDB: Add ESPI slave device node

2020-06-04 Thread Zhiqiang Hou
From: Xiaowei Bao Add ESPI slave node for T2080RDB. Signed-off-by: Xiaowei Bao Signed-off-by: Hou Zhiqiang --- V3: - No change. arch/powerpc/dts/t2080rdb.dts | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/powerpc/dts/t2080rdb.dts b/arch/powerpc/dts/t2080rdb.dts

[PATCHv3 26/36] dts: T104x: Add ESPI DT nodes

2020-06-04 Thread Zhiqiang Hou
From: Xiaowei Bao Add ESPI controller DT node for T104x. Signed-off-by: Xiaowei Bao Signed-off-by: Hou Zhiqiang --- V3: - Move the eSPI DT node back to path /soc, in v2 the patch command put the eSPI node to the path /cpus by mistake. arch/powerpc/dts/t104x.dtsi | 9 + 1 file

  1   2   3   >