Re: [PATCH] test: add dependency for UT_LOG

2020-06-06 Thread Heinrich Schuchardt
Am June 7, 2020 3:52:37 AM UTC schrieb Kever Yang : >The callback of do_ut_log() is defined in test/log/test-main.c >which is depend on CONFIG_LOG. Where do you see such a dependency? With which configuration did you have a build problem? > >Signed-off-by: Kever Yang >--- > > test/Kconfig | 1

[PATCH] Revert "lib: Improve _parse_integer_fixup_radix base 16 detection"

2020-06-06 Thread Sean Anderson
This reverts commit 0486497e2b5f4d36fa968a1a60fea358cbf70b65. The strtoul has well-defined semantics. It is defined by the C standard and POSIX. To quote the relevant section of the man pages, > If base is zero or 16, the string may then include a "0x" prefix, and the > number will be read in

Re: [PATCH v3 5/8] rockchip: puma: reorganize devicetrees to actually work and match upstream

2020-06-06 Thread Kever Yang
On 2020/6/5 下午6:06, Heiko Stuebner wrote: From: Heiko Stuebner So far the puma dts files only just included the main puma dtsi without handling the actual baseboard and rk3399-puma.dtsi was very much detached from the variant in the mainline Linux kernel. Recent changes resulted in a

[PATCH] rockchip: rk3399-evb: add stdout-path for the board

2020-06-06 Thread Kever Yang
The 'stdout-path' is missing after dts sync. Fixes: 167efc2c7a ("arm64: dts: rk3399: Sync v5.7-rc1 from Linux") Signed-off-by: Kever Yang --- arch/arm/dts/rk3399-evb-u-boot.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/dts/rk3399-evb-u-boot.dtsi

[PATCH] test: add dependency for UT_LOG

2020-06-06 Thread Kever Yang
The callback of do_ut_log() is defined in test/log/test-main.c which is depend on CONFIG_LOG. Signed-off-by: Kever Yang --- test/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/test/Kconfig b/test/Kconfig index 9b2f84b551..8c32fa5cbd 100644 --- a/test/Kconfig +++ b/test/Kconfig @@

Re: [PATCH] patman: use new --u-boot option with checkpath.pl

2020-06-06 Thread Simon Glass
Hi Daniel, On Sat, 6 Jun 2020 at 20:02, Simon Glass wrote: > > Hi Daniel, > > On Sat, 6 Jun 2020 at 15:31, Daniel Schwierzeck > wrote: > > > > checkpatch.pl now supports a --u-boot option for U-Boot specific > > checks. Use that in patman to check the patch series. > > > > Signed-off-by: Daniel

Re: [PATCH] patman: use new --u-boot option with checkpath.pl

2020-06-06 Thread Simon Glass
Hi Daniel, On Sat, 6 Jun 2020 at 15:31, Daniel Schwierzeck wrote: > > checkpatch.pl now supports a --u-boot option for U-Boot specific > checks. Use that in patman to check the patch series. > > Signed-off-by: Daniel Schwierzeck > > --- > > tools/patman/checkpatch.py | 2 +- > 1 file changed,

Re: [PATCH 1/5] arm: enable allocate-on-read for LPAE's DCACHE_WRITEBACK

2020-06-06 Thread Heinrich Schuchardt
On 6/7/20 1:17 AM, Ard Biesheuvel wrote: > On Sat, 6 Jun 2020 at 22:14, Heinrich Schuchardt wrote: >> >> On 6/6/20 7:15 PM, Ard Biesheuvel wrote: >>> The LPAE version of DCACHE_WRITEBACK is currently defined as no-allocate >>> for both reads and writes, which deviates from the non-LPAE

Re: [PATCH 1/5] arm: enable allocate-on-read for LPAE's DCACHE_WRITEBACK

2020-06-06 Thread Ard Biesheuvel
On Sat, 6 Jun 2020 at 22:14, Heinrich Schuchardt wrote: > > On 6/6/20 7:15 PM, Ard Biesheuvel wrote: > > The LPAE version of DCACHE_WRITEBACK is currently defined as no-allocate > > for both reads and writes, which deviates from the non-LPAE definition, > > and mostly defeats the purpose of

Re: [U-Boot] [PATCH v2 04/16] arm: socfpga: stratix10: Add pinmux support for Stratix10 SoC

2020-06-06 Thread Heinrich Schuchardt
On 5/18/18 4:05 PM, Ley Foon Tan wrote: > Add pinmux driver support for Stratix SoC > > Signed-off-by: Chin Liang See > Signed-off-by: Ley Foon Tan > --- > arch/arm/mach-socfpga/Makefile |2 + > .../arm/mach-socfpga/include/mach/system_manager.h |5 +- >

Re: [PATCH 5/5] arm: qemu: override flash accessors to use virtualizable instructions

2020-06-06 Thread Ard Biesheuvel
On Sat, 6 Jun 2020 at 23:08, Heinrich Schuchardt wrote: > > On 6/6/20 7:15 PM, Ard Biesheuvel wrote: > > Some instructions in the ARM ISA have multiple output registers, such > > as ldrd/ldp (load pair), where two registers are loaded from memory, > > but also ldr with indexing, where the memory

Out of bounds access in arch/arm/cpu/armv7/iproc-common/armpll.c

2020-06-06 Thread Heinrich Schuchardt
Hello Scott, CppCheck gives an error: [arch/arm/cpu/armv7/iproc-common/armpll.c:137]: (error) Array 'armpll_clk_tab[13]' accessed at index 17, which is out of bounds. In the loop at the start of armpll_config() i is determined. The maximum value of i after checking status in line 53 is 12. In

[PATCH] patman: use new --u-boot option with checkpath.pl

2020-06-06 Thread Daniel Schwierzeck
checkpatch.pl now supports a --u-boot option for U-Boot specific checks. Use that in patman to check the patch series. Signed-off-by: Daniel Schwierzeck --- tools/patman/checkpatch.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/patman/checkpatch.py

[PATCH 1/1] mtd: cfi_flash: use __raw_writeq(), __raw_readq()

2020-06-06 Thread Heinrich Schuchardt
Functions __raw_writeq(), __raw_readq() are available for all architectures. So let's use them. Signed-off-by: Heinrich Schuchardt --- drivers/mtd/cfi_flash.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/cfi_flash.c b/drivers/mtd/cfi_flash.c index

Re: [PATCH 5/5] arm: qemu: override flash accessors to use virtualizable instructions

2020-06-06 Thread Heinrich Schuchardt
On 6/6/20 7:15 PM, Ard Biesheuvel wrote: > Some instructions in the ARM ISA have multiple output registers, such > as ldrd/ldp (load pair), where two registers are loaded from memory, > but also ldr with indexing, where the memory base register is incremented > as well when the value is loaded to

[PATCH 5/6] .travis.yml: add Qemu tests for MIPS Malta board

2020-06-06 Thread Daniel Schwierzeck
Add Qemu tests for the MIPS Malta machine as a replacement for the deprecated generic MIPS machine. Signed-off-by: Daniel Schwierzeck --- .travis.yml | 28 1 file changed, 28 insertions(+) diff --git a/.travis.yml b/.travis.yml index bb02b6d816..a042aa2c7d 100644

[PATCH 6/6] .azure-pipelines.yml: add Qemu tests for MIPS Malta board

2020-06-06 Thread Daniel Schwierzeck
Add Qemu tests for the MIPS Malta machine as a replacement for the deprecated generic MIPS machine. Signed-off-by: Daniel Schwierzeck --- .azure-pipelines.yml | 16 1 file changed, 16 insertions(+) diff --git a/.azure-pipelines.yml b/.azure-pipelines.yml index

[PATCH 4/6] .gitlab-ci.yml: add Qemu tests for MIPS Malta board

2020-06-06 Thread Daniel Schwierzeck
Add Qemu tests for the MIPS Malta machine as a replacement for the deprecated generic MIPS machine. Signed-off-by: Daniel Schwierzeck --- .gitlab-ci.yml | 32 1 file changed, 32 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index

[PATCH 3/6] mips: malta: build u-boot-swap.bin

2020-06-06 Thread Daniel Schwierzeck
The Qemu Malta machine expects the firmware in Big-Endian byte order. Therefore the Little-Endian variants of the Malta board needs to be byte swapped. Signed-off-by: Daniel Schwierzeck --- configs/malta64el_defconfig | 1 + configs/maltael_defconfig | 1 + 2 files changed, 2 insertions(+)

[PATCH 2/6] Makefile: add rule to generate u-boot-swap.bin

2020-06-06 Thread Daniel Schwierzeck
This rule generates an u-boot binary file where the byte endianness is swapped. This will be used by the MIPS Malta Little-Endian variants to be able to boot with Qemu. The Qemu Malta Machine expects the firmware in Big-Endian order. Signed-off-by: Daniel Schwierzeck --- Makefile | 6 ++ 1

[PATCH 0/6] Add Qemu tests for MIPS Malta machine

2020-06-06 Thread Daniel Schwierzeck
The currently used qemu_mips target respectively the Qemu generic MIPS machine is marked as deprecated by Qemu. One should use the MIPS Malta machine. Also the qemu_mips target only exists in U-Boot, the Linux support was removed centuries ago. Thus we should deprecated and remove the qemu_mips

[PATCH 1/6] tools: add script for byte endianness swapping

2020-06-06 Thread Daniel Schwierzeck
This can be used to swap the byte endianness of a binary file from Little-Endian to Big-Endian or vice-versa. Signed-off-by: Daniel Schwierzeck --- tools/endian-swap.py | 55 1 file changed, 55 insertions(+) create mode 100755 tools/endian-swap.py

Re: [PATCH 4/5] arm: qemu: disable the EFI workaround for older GRUB

2020-06-06 Thread Heinrich Schuchardt
On 6/6/20 7:15 PM, Ard Biesheuvel wrote: > The QEMU/mach-virt targeted port of u-boot currently only runs on > QEMU under TCG emulation, which does not model the caches at all, > and so no users can exist that are relying on the GRUB hack for > EFI boot. > > We will shortly enable support for

Re: [PATCH 3/5] arm: qemu: implement enable_caches()

2020-06-06 Thread Heinrich Schuchardt
On 6/6/20 7:15 PM, Ard Biesheuvel wrote: > Add an override for enable_caches to enable the I and D caches, along > with the cached 1:1 mapping of all of DRAM. This is needed for running > U-Boot under virtualization with QEMU/kvm. > > Signed-off-by: Ard Biesheuvel > --- >

Re: [PATCH 2/5] arm: qemu: enable LPAE on 32-bit

2020-06-06 Thread Heinrich Schuchardt
On 6/6/20 10:32 PM, Heinrich Schuchardt wrote: > On 6/6/20 7:15 PM, Ard Biesheuvel wrote: >> QEMU's mach-virt machine only supports selecting CPU models that >> implement the virtualization extensions, and are therefore guaranteed >> to support LPAE as well. > > I wonder why > qemu-system-arm

Re: [PATCH 2/5] arm: qemu: enable LPAE on 32-bit

2020-06-06 Thread Heinrich Schuchardt
On 6/6/20 7:15 PM, Ard Biesheuvel wrote: > QEMU's mach-virt machine only supports selecting CPU models that > implement the virtualization extensions, and are therefore guaranteed > to support LPAE as well. I wonder why qemu-system-arm -machine virt -cpu help lists cortex-a9 (which is not LPAE

Re: [PATCH 1/5] arm: enable allocate-on-read for LPAE's DCACHE_WRITEBACK

2020-06-06 Thread Heinrich Schuchardt
On 6/6/20 7:15 PM, Ard Biesheuvel wrote: > The LPAE version of DCACHE_WRITEBACK is currently defined as no-allocate > for both reads and writes, which deviates from the non-LPAE definition, > and mostly defeats the purpose of enabling the caches in the first place. > > So align LPAE with !LPAE,

[PATCH] riscv: sbi: Add newline to error message

2020-06-06 Thread Sean Anderson
Signed-off-by: Sean Anderson --- common/spl/spl_opensbi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/spl/spl_opensbi.c b/common/spl/spl_opensbi.c index e88136e6f3..14f335f75f 100644 --- a/common/spl/spl_opensbi.c +++ b/common/spl/spl_opensbi.c @@ -56,7 +56,7 @@

Re: [PATCH v3 3/4] spl: fit: nand: fix fit loading in case of bad blocks

2020-06-06 Thread Michael Nazzareno Trimarchi
Hi Dario I know that is an important bug to be addressed and I would like to add even Tom on this On Wed, May 27, 2020 at 1:56 PM Dario Binacchi wrote: > > The offset at which the image to be loaded from NAND is located is > retrieved from the itb header. The presence of bad blocks in the area

Re: [PATCH 7/8] regmap: Add support for regmap fields

2020-06-06 Thread Simon Glass
Hi Pratyush, On Fri, 5 Jun 2020 at 13:03, Pratyush Yadav wrote: > > Hi Simon, > > On 31/05/20 08:08AM, Simon Glass wrote: > > Hi Pratyush, > > > > On Wed, 27 May 2020 at 06:52, Pratyush Yadav wrote: > > > > > > From: Jean-Jacques Hiblot > > > > > > A regmap field is an abstraction available in

Re: UCLASS_BLK driver binding without devtree and U_BOOT_DEVICE

2020-06-06 Thread Simon Glass
Hi Anastasiia, On Fri, 5 Jun 2020 at 08:21, Anastasiia Lukianenko wrote: > > Hi Simon, > > Thank you for detailed reply. > We will bind UCLASS_BLK driver according to your advice. Block device > will have it's own parent which handles the actual device access. > Most likely I'll have more

[PATCH 4/5] arm: qemu: disable the EFI workaround for older GRUB

2020-06-06 Thread Ard Biesheuvel
The QEMU/mach-virt targeted port of u-boot currently only runs on QEMU under TCG emulation, which does not model the caches at all, and so no users can exist that are relying on the GRUB hack for EFI boot. We will shortly enable support for running under KVM, but the GRUB hack (which disables all

[PATCH 5/5] arm: qemu: override flash accessors to use virtualizable instructions

2020-06-06 Thread Ard Biesheuvel
Some instructions in the ARM ISA have multiple output registers, such as ldrd/ldp (load pair), where two registers are loaded from memory, but also ldr with indexing, where the memory base register is incremented as well when the value is loaded to the destination register. MMIO emulation under

[PATCH 3/5] arm: qemu: implement enable_caches()

2020-06-06 Thread Ard Biesheuvel
Add an override for enable_caches to enable the I and D caches, along with the cached 1:1 mapping of all of DRAM. This is needed for running U-Boot under virtualization with QEMU/kvm. Signed-off-by: Ard Biesheuvel --- board/emulation/qemu-arm/qemu-arm.c | 7 +++ 1 file changed, 7

[PATCH 1/5] arm: enable allocate-on-read for LPAE's DCACHE_WRITEBACK

2020-06-06 Thread Ard Biesheuvel
The LPAE version of DCACHE_WRITEBACK is currently defined as no-allocate for both reads and writes, which deviates from the non-LPAE definition, and mostly defeats the purpose of enabling the caches in the first place. So align LPAE with !LPAE, and enable allocate-on-read. Signed-off-by: Ard

[PATCH 2/5] arm: qemu: enable LPAE on 32-bit

2020-06-06 Thread Ard Biesheuvel
QEMU's mach-virt machine only supports selecting CPU models that implement the virtualization extensions, and are therefore guaranteed to support LPAE as well. Initially, QEMU would not allow emulating these CPUs running in HYP mode (or EL2, for AArch64), but today, it also contains a complete

[PATCH 0/5] Fixes for running U-boot under QEMU/KVM

2020-06-06 Thread Ard Biesheuvel
This series fixes a number of issues that exist in the QEMU/mach-virt port of u-boot, and that prevent it from executing correctly under virtualization (as opposed to TCG emulation) As the Linux EFI subsystem maintainer, I am looking to increase test coverage for the EFI related changes that are

Re: [PATCH 3/6] env: Fix invalid env handling in env_init()

2020-06-06 Thread Tom Rini
On Sat, Jun 06, 2020 at 04:54:52PM +0200, Marek Vasut wrote: > On 6/5/20 11:11 PM, Tom Rini wrote: > > On Fri, Jun 05, 2020 at 10:47:24PM +0200, Marek Vasut wrote: > >> On 6/5/20 9:07 PM, Tom Rini wrote: > >>> On Wed, Jun 03, 2020 at 02:01:08AM +0200, Marek Vasut wrote: > >>> > In case the

Re: [PATCH 3/6] env: Fix invalid env handling in env_init()

2020-06-06 Thread Marek Vasut
On 6/5/20 11:11 PM, Tom Rini wrote: > On Fri, Jun 05, 2020 at 10:47:24PM +0200, Marek Vasut wrote: >> On 6/5/20 9:07 PM, Tom Rini wrote: >>> On Wed, Jun 03, 2020 at 02:01:08AM +0200, Marek Vasut wrote: >>> In case the env storage driver marks environment as ENV_INVALID, we must reset the

[PATCH] clk: renesas: Synchronize Gen2 MSTP teardown tables

2020-06-06 Thread Marek Vasut
Synchronize Gen2 MSTP teardown tables with datasheet Rev.2.00 Feb 01, 2016. This corrects the following bits: - added H2 MSTP3[10] SCIF2 - added H2/M2/E2 MSTP7[29] TCON - removed E2 MSTP5[22] Thermal Sensor - removed E2 MSTP10[31,24:22] SRC0, SRC7:9 Signed-off-by: Marek Vasut Cc:

Re: [PATCH 01/15] net: pcnet: Drop typedef struct pcnet_priv_t

2020-06-06 Thread Marek Vasut
On 6/6/20 1:56 AM, Daniel Schwierzeck wrote: > > > Am 05.06.20 um 19:50 schrieb Marek Vasut: >> On 6/5/20 6:38 PM, Daniel Schwierzeck wrote: >>> >>> >>> Am 05.06.20 um 18:22 schrieb Marek Vasut: On 6/5/20 5:28 PM, Daniel Schwierzeck wrote: > > > Am 17.05.20 um 18:24 schrieb

[PATCH 1/1] efi_loader: printf code in efi_image_parse()

2020-06-06 Thread Heinrich Schuchardt
For size_t we have to use %zu for printing not %lu. Fixes: 4540dabdcaca ("efi_loader: image_loader: support image authentication") Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_image_loader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 1/1] arm: sunxi: increase SYS_MALLOC_F_LEN

2020-06-06 Thread Heinrich Schuchardt
The current default of 0x400 for SYS_MALLOC_F_LEN is too small if any additional drivers marked as DM_FLAG_PRE_RELOC are loaded before relocation. CONFIG_RSA=y which is needed for UEFI secure boot or for FIT image verification loads the driver mod_exp_sw which has DM_FLAG_PRE_RELOC. CONFIG_LOG=Y

Re: [PATCH 1/1] sunxi: CONFIG_INIT_SP_RELATIVE=y for Pine64 LTS

2020-06-06 Thread Heinrich Schuchardt
On 6/3/20 7:07 PM, Heinrich Schuchardt wrote: > On 6/3/20 6:31 PM, André Przywara wrote: >> On 03/06/2020 16:47, Heinrich Schuchardt wrote: >> >> Hi Heinrich, >> >>> On 03.06.20 01:46, André Przywara wrote: On 02/06/2020 20:55, Tom Rini wrote: Hi, > On Tue, Jun 02, 2020 at

Re: [PATCH 0/2] omap4: panda: convert to device model

2020-06-06 Thread Jonathan Gray
On Tue, Jun 02, 2020 at 02:19:07PM +0300, Tero Kristo wrote: > Hi, > > As there is looming death to OMAP4 Panda board u-boot support, I decided > to take a shot and convert it to device model myself. With these patches > it boots up fine, and there are no DM_SPL conversion complaints during >

Pull request for UEFI sub-system for efi-2020-07-rc4 (2)

2020-06-06 Thread Heinrich Schuchardt
The following changes since commit 88bd5b1793600b0f5f25c3d236b4d049fb986140: configs: Resync with savedefconfig (2020-06-04 19:29:09 -0400) are available in the Git repository at: https://gitlab.denx.de/u-boot/custodians/u-boot-efi.git tags/efi-2020-07-rc4-2 for you to fetch changes up to