Re: using sudo?, Re: [PATCH v2 8/8] test/py: efi_secboot: add test for intermediate certificates

2020-07-08 Thread AKASHI Takahiro
Tom, On Wed, Jul 08, 2020 at 11:15:26PM -0400, Tom Rini wrote: > On Thu, Jul 09, 2020 at 09:58:03AM +0900, AKASHI Takahiro wrote: > > > Hi Tom, > > > > I'd like to make sure of your policy about usage of "sudo" on CI. > > Do you think that we should always avoid using "sudo" in testing? > > >

Re: [PATCH v2 2/5] arm: kirkwood: convert LaCie boards to DM_SPI_FLASH

2020-07-08 Thread Stefan Roese
On 08.07.20 20:46, Jagan Teki wrote: On Wed, Jul 8, 2020 at 12:19 PM Jagan Teki wrote: On Sun, Jun 28, 2020 at 10:31 PM Simon Guinot wrote: This patch converts the following Kirkwood-based LaCie boards to DM, DM_SPI and DM_SPI_FLASH: - d2 Network v2 - Internet Space v2 - 2Big Network v2 -

Re: [PATCH] arm: cmd_stm32prog: Fix the CONFIG_IS_ENABLED() usage

2020-07-08 Thread Bin Meng
On Thu, Jul 9, 2020 at 1:32 AM Patrick DELAUNAY wrote: > > Hi Bin, > > > From: Bin Meng > > Sent: mercredi 8 juillet 2020 09:19 > > > > Add parentheses around CONFIG_IS_ENABLED() in the if statement, to fix > > potential build failures. > > > > Signed-off-by: Bin Meng > > > > --- > > Fixes the

Re: [PATCH 1/8] dm: soc: Introduce UCLASS_SOC for SOC ID and attribute matching

2020-07-08 Thread Dave Gerlach
Simon, On 7/2/20 10:50 PM, Simon Glass wrote: On Mon, 29 Jun 2020 at 22:38, Dave Gerlach wrote: Introduce UCLASS_SOC to be used for SOC identification and attribute matching based on the SoC ID info. This allows drivers to be provided for SoCs to retrieve SoC identifying information and also

Re: [PATCH 1/8] dm: soc: Introduce UCLASS_SOC for SOC ID and attribute matching

2020-07-08 Thread Dave Gerlach
Tom, On 6/30/20 7:43 AM, Tom Rini wrote: On Mon, Jun 29, 2020 at 11:38:46PM -0500, Dave Gerlach wrote: Introduce UCLASS_SOC to be used for SOC identification and attribute matching based on the SoC ID info. This allows drivers to be provided for SoCs to retrieve SoC identifying information and

Re: using sudo?, Re: [PATCH v2 8/8] test/py: efi_secboot: add test for intermediate certificates

2020-07-08 Thread Tom Rini
On Thu, Jul 09, 2020 at 09:58:03AM +0900, AKASHI Takahiro wrote: > Hi Tom, > > I'd like to make sure of your policy about usage of "sudo" on CI. > Do you think that we should always avoid using "sudo" in testing? > > I remember that you had allowed us to run sudo in (python) > test scripts on

using sudo?, Re: [PATCH v2 8/8] test/py: efi_secboot: add test for intermediate certificates

2020-07-08 Thread AKASHI Takahiro
Hi Tom, I'd like to make sure of your policy about usage of "sudo" on CI. Do you think that we should always avoid using "sudo" in testing? I remember that you had allowed us to run sudo in (python) test scripts on Travis CI when I requested this (for FAT filesystem?). -Takahiro Akashi On Tue,

Re: [PATCH v3 01/13] lib/crypto, efi_loader: avoid multiple inclusions of header files

2020-07-08 Thread AKASHI Takahiro
Heinrich, On Wed, Jul 08, 2020 at 12:29:54PM +0200, Heinrich Schuchardt wrote: > On 08.07.20 07:01, AKASHI Takahiro wrote: > > By adding extra symbols, we can now avoid including x509_parser and > > pkcs7_parser.h files multiple times. > > > > Signed-off-by: AKASHI Takahiro > > Suggested-by:

Re: [PATCH v2] cmd: add a panic command

2020-07-08 Thread Tom Rini
On Tue, Jun 30, 2020 at 01:05:45AM +0200, Heiko Stuebner wrote: > From: Heiko Stuebner > > Even in boot scripts it may be needed to "panic" when all options > are exhausted and the device specification specifies hanging > instead of resetting the board. > > So add a new panic command that just

Re: [PATCH v6 8/8] spl: fit: select SPL_CRYPTO_SUPPORT for SPL_FIT_SIGNATURE

2020-07-08 Thread Tom Rini
On Thu, Jun 18, 2020 at 04:23:28PM +0200, Heiko Stuebner wrote: > From: Heiko Stuebner > > Verifying FIT images obviously needs the rsa parts of crypto > support and while main uboot always compiles crypto support, > it's optional for SPL and we should thus select the necessary > option to not

Re: [PATCH v7 1/1] lib: rsa: fix allocated size for rr and rrtmp in rsa_gen_key_prop()

2020-07-08 Thread Tom Rini
On Tue, Jul 07, 2020 at 10:57:26PM +0200, Heinrich Schuchardt wrote: > From: Heiko Stuebner > > When calculating rrtmp/rr rsa_gen_key_prop() tries to make > (((rlen + 31) >> 5) + 1) steps in the rr uint32_t array and > (((rlen + 7) >> 3) + 1) / 4 steps in uint32_t rrtmp[] > with rlen being

Re: [PATCH v6 7/8] spl: fit: select SPL_HASH_SUPPORT for SPL_FIT_SIGNATURE

2020-07-08 Thread Tom Rini
On Thu, Jun 18, 2020 at 04:23:27PM +0200, Heiko Stuebner wrote: > From: Heiko Stuebner > > rsa-checsum needs support for hash functions or else will run into > compile errors like: > u-boot/lib/rsa/rsa-checksum.c:28: undefined reference to > `hash_progressive_lookup_algo' > > So similar to

Re: [PATCH v6 1/8] lib: rsa: distinguish between tpl and spl for CONFIG_RSA_VERIFY

2020-07-08 Thread Tom Rini
On Thu, Jun 18, 2020 at 04:23:21PM +0200, Heiko Stuebner wrote: > From: Heiko Stuebner > > While the SPL may want to do signature checking this won't be > the case for TPL in all cases, as TPL is mostly used when the > amount of initial memory is not enough for a full SPL. > > So on a system

Re: [PATCH v6 6/8] lib: rsa: add documentation to padding_pss_verify to document limitations

2020-07-08 Thread Tom Rini
On Thu, Jun 18, 2020 at 04:23:26PM +0200, Heiko Stuebner wrote: > From: Heiko Stuebner > > padding_pss_verify only works with the default pss salt setting of -2 > (length to be automatically determined based on the PSS block structure) > not -1 (salt length set to the maximum permissible

Re: [PATCH v6 2/8] lib: rsa: take spl/non-spl into account when building rsa_verify_with_pkey()

2020-07-08 Thread Tom Rini
On Thu, Jun 18, 2020 at 04:23:22PM +0200, Heiko Stuebner wrote: > From: Heiko Stuebner > > Right now in multiple places there are only checks for the full > CONFIG_RSA_VERIFY_WITH_PKEY option, not split into main,spl,tpl variants. > > This breaks when the rsa functions get enabled for SPL, for

Re: [PATCH v2] tpm2: tis_spi: add linux compatible fallback string

2020-07-08 Thread Tom Rini
On Fri, Jun 12, 2020 at 05:17:33PM +0200, Bruno Thomsen wrote: > This solves a compatibility issue with Linux device trees > that contain TPMv2.x hardware. So it's easier to import DTS > from upstream kernel when migrating board init from C code > to DTS. > > The issue is that fallback binding

Re: [PATCH v6 5/8] lib: rsa: free local arrays after use in rsa_gen_key_prop()

2020-07-08 Thread Tom Rini
On Thu, Jun 18, 2020 at 04:23:25PM +0200, Heiko Stuebner wrote: > From: Heiko Stuebner > > n, rr and rrtmp are used for internal calculations, but in the end > the results are copied into separately allocated elements of the > actual key_prop, so the n, rr and rrtmp elements are not used

Re: [PATCH] tpm: add TPM2_GetRandom command support

2020-07-08 Thread Tom Rini
On Thu, Jun 04, 2020 at 04:43:59PM -0700, Dhananjay Phadke wrote: > Add support for TPM2 GetRandom command > > Signed-off-by: Dhananjay Phadke > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v6 3/8] lib: rsa: bring exp_len in line when generating a key_prop

2020-07-08 Thread Tom Rini
On Thu, Jun 18, 2020 at 04:23:23PM +0200, Heiko Stuebner wrote: > From: Heiko Stuebner > > The exponent field of struct key_prop gets allocated an uint64_t, > and the contents are positioned from the back, so an exponent of > "0x01 0x00 0x01" becomes 0x0 0x0 0x0 0x0 0x0 0x1 0x0 0x1" > > Right

Re: [PATCH 5/6] command: Drop #ifdef for MEM_SUPPORT_64BIT_DATA

2020-07-08 Thread Tom Rini
On Tue, Jun 02, 2020 at 07:26:48PM -0600, Simon Glass wrote: > This is defined only when __lp64__ is defined. That means that ulong is > 64 bits long. Therefore we don't need to use a separate u64 type on those > architectures. > > Fix up the code to take advantage of that, removing the

Re: [PATCH 6/6] cmd: Add a memory-search command

2020-07-08 Thread Tom Rini
On Tue, Jun 02, 2020 at 07:26:49PM -0600, Simon Glass wrote: > It is useful to be able to find hex values and strings in a memory range. > Add a command to support this. > > cmd: Fix 'md' and add a memory-search command > At present 'md.q' is broken. This series provides a fix for this. It also

Re: [PATCH 4/6] display_options: Drop #ifdef for MEM_SUPPORT_64BIT_DATA

2020-07-08 Thread Tom Rini
On Tue, Jun 02, 2020 at 07:26:47PM -0600, Simon Glass wrote: > This is defined only when __lp64__ is defined. That means that ulong is > 64 bits long. Therefore we don't need to use a separate u64 type on those > architectures. > > Fix up the code to take advantage of that, removing the

Re: [PATCH] sata_sil: make it buildable with DM_PCI

2020-07-08 Thread Tom Rini
On Thu, Jun 04, 2020 at 01:29:22PM +0200, Marcin Juszkiewicz wrote: > Linker complained about lack of `pci_virt_to_mem` function. > Looks like driver was not ready for device model - I took solution from > e1000.c driver. > > Signed-off-by: Marcin Juszkiewicz Applied to u-boot/master, thanks!

Re: [PATCH 3/6] cmd: mem: Drop #ifdef for MEM_SUPPORT_64BIT_DATA

2020-07-08 Thread Tom Rini
On Tue, Jun 02, 2020 at 07:26:46PM -0600, Simon Glass wrote: > This is defined only when __lp64__ is defined. That means that ulong is > 64 bits long. Therefore we don't need to use a separate u64 type on those > architectures. > > Fix up the code to take advantage of that, removing the

Re: [PATCH v3 4/4] spl: fit: improve spl_nand_fit_read(...) readability

2020-07-08 Thread Tom Rini
On Wed, May 27, 2020 at 01:56:21PM +0200, Dario Binacchi wrote: > Replacing the ret variable with err and handling first the error > condition about the value returned by the spl_nand_fit_read routine, > improves the code readability. > Furthermore, the 'else' int the 'else return ret'

Re: [PATCH v3 3/4] spl: fit: nand: fix fit loading in case of bad blocks

2020-07-08 Thread Tom Rini
On Wed, May 27, 2020 at 01:56:20PM +0200, Dario Binacchi wrote: > The offset at which the image to be loaded from NAND is located is > retrieved from the itb header. The presence of bad blocks in the area > of the NAND where the itb image is located could invalidate the offset > which must

Re: [PATCH v3 2/4] spl: fit: fail fit loading in case of FDT appending error

2020-07-08 Thread Tom Rini
On Wed, May 27, 2020 at 01:56:19PM +0200, Dario Binacchi wrote: > If uboot does not embed its device tree and the FIT loading function > returns error in case of failure in the FDT append, the redundant itb > image could be loaded. > > cc: Michael Trimarchi > Signed-off-by: Dario Binacchi >

Re: [PATCH 2/6] cmd: mem: Use a macro to avoid #ifdef in help

2020-07-08 Thread Tom Rini
On Tue, Jun 02, 2020 at 07:26:45PM -0600, Simon Glass wrote: > It is a bit painful to have #ifdefs in the middle of the help for each > command. Add a macro to avoid this. > > Signed-off-by: Simon Glass > Reviewed-by: Stefan Roese Applied to u-boot/master, thanks! -- Tom signature.asc

Re: [PATCH 1/6] Update MEM_SUPPORT_64BIT_DATA to be always defined

2020-07-08 Thread Tom Rini
On Tue, Jun 02, 2020 at 07:26:44PM -0600, Simon Glass wrote: > Define this macro always so we don't need the preprocessor to check it. > Convert the users to #if instead of #ifdef. > > Note that '#if MEM_SUPPORT_64BIT_DATA' does not give an error if the > macro is not define. It just assumes

Re: [PATCH] debug_uart: Add CR before and after announce string

2020-07-08 Thread Tom Rini
On Fri, May 15, 2020 at 07:09:03AM +0200, Stefan Roese wrote: > Add linefeeds before and after the announce string. This makes the > output easier to read, especially if some text follows the announce > message without a specific additional CR. > > Signed-off-by: Stefan Roese > Reviewed-by: Bin

Re: [PATCH v3 1/4] spl: fix format of function documentation

2020-07-08 Thread Tom Rini
On Wed, May 27, 2020 at 01:56:18PM +0200, Dario Binacchi wrote: > U-Boot adopted the kernel-doc annotation style. > > cc: Michael Trimarchi > Signed-off-by: Dario Binacchi > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] lib: rsa: function to verify a signature against a hash

2020-07-08 Thread Tom Rini
On Fri, May 22, 2020 at 04:20:33PM +0200, Heiko Stuebner wrote: > From: Heiko Stuebner > > rsa_verify() expects a memory region and wants to do the hashing itself, > but there may be cases where the hashing is done via other means, > like hashing a squashfs rootfs. > > So add rsa_verify_hash()

Re: [PATCH] bugfix: tpm2_tis_spi: redeclaration compile error

2020-07-08 Thread Tom Rini
On Mon, Jul 06, 2020 at 05:32:27PM +0200, Bruno Thomsen wrote: > tpm2_tis_spi driver fails to compile with errors like this: > > drivers/tpm/tpm_tis.h:117:2: error: redeclaration of enumerator > 'TPM_ACCESS_VALID' > drivers/tpm/tpm_tis.h:118:2: error: redeclaration of enumerator >

Re: [PATCH 1/2] tpm: add #ifndef to fix redeclaration build errors

2020-07-08 Thread Tom Rini
On Mon, May 11, 2020 at 03:22:25PM +0200, Johannes Holland wrote: > tpm_tis_spi.c directly includes tpm_tis.h and tpm-v2.h which both > define the same enums (see e.g. TPM_ACCESS_VALID). Add an #ifndef to > prevent redeclaration errors. > > Signed-off-by: Johannes Holland Applied to

[PATCH 2/2] configs: rock64-rk3328_defconfig: Add SPI Flash support

2020-07-08 Thread Johannes Krottmayer
Add U-Boot SPI Flash support for the PINE64 Rock64 board Signed-off-by: Johannes Krottmayer Cc: Matwey V. Kornilov --- configs/rock64-rk3328_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configs/rock64-rk3328_defconfig b/configs/rock64-rk3328_defconfig index

[PATCH 1/2] ARM: dts: rk3328-rock64: Add SPI Flash support

2020-07-08 Thread Johannes Krottmayer
Add U-Boot SPI Flash support for the PINE64 Rock64 board Signed-off-by: Johannes Krottmayer Cc: Matwey V. Kornilov --- arch/arm/dts/rk3328-rock64-u-boot.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/dts/rk3328-rock64-u-boot.dtsi

[PATCH 0/2] PINE64 Rock64 board: Add SPI Flash support

2020-07-08 Thread Johannes Krottmayer
This patch series adds SPI Flash support for the PINE64 Rock64 board. Tested with the version 2.0 of the board. Johannes Krottmayer (2): ARM: dts: rk3328-rock64: Add SPI Flash support configs: rock64-rk3328_defconfig: Add SPI Flash support arch/arm/dts/rk3328-rock64-u-boot.dtsi | 6 ++

Re: [PATCH 1/2] vboot: add support for multiple required keys

2020-07-08 Thread Thirupathaiah Annapureddy
Hi Simon, Thanks a lot for reviewing the patch. I would appreciate if you could clarify the following in-line questions: On 6/29/2020 10:31 AM, Simon Glass wrote: > Hi Thirupathaiah, > > > On Mon, 29 Jun 2020 at 11:26, Simon Glass wrote: >> >> Hi Thirupathaiah, >> >> On Thu, 25 Jun 2020 at

Re: [PATCH] fixdep: fix CONFIG_IS_ENABLED etc. handling

2020-07-08 Thread Simon Glass
On Wed, 8 Jul 2020 at 15:46, Stephen Warren wrote: > > From: Stephen Warren > > When fixdep detects CONFIG_IS_ENABLED and other similar macros, it must > parse the macro parameter to determine which actual CONFIG_ option is > being referenced. This involves moving a pointer forward through the >

Re: [PATCH 08/12] poweroff: Add poweroff-gpio driver

2020-07-08 Thread Simon Glass
Hi Sebastian, On Wed, 1 Jul 2020 at 11:27, Sebastian Reichel wrote: > > Add GPIO poweroff driver, which is based on the Linux > driver and uses the same DT binding. > > Signed-off-by: Sebastian Reichel > --- > drivers/power/Kconfig | 8 > drivers/power/Makefile| 1 + >

Re: [PATCH 08/12] poweroff: Add poweroff-gpio driver

2020-07-08 Thread Jaehoon Chung
On 7/2/20 2:26 AM, Sebastian Reichel wrote: > Add GPIO poweroff driver, which is based on the Linux > driver and uses the same DT binding. > > Signed-off-by: Sebastian Reichel > --- > drivers/power/Kconfig | 8 > drivers/power/Makefile| 1 + >

[PATCH 1/3] drivers: clk: rockchip: clk_rk3328: Add SPI support

2020-07-08 Thread Johannes Krottmayer
Add SPI support for the RK3328 clock driver Signed-off-by: Johannes Krottmayer Cc: Kever Yang Cc: Jagan Teki --- drivers/clk/rockchip/clk_rk3328.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/clk/rockchip/clk_rk3328.c

[PATCH 3/3] ARM: dts: rk3328: Add SPI support

2020-07-08 Thread Johannes Krottmayer
Add U-Boot SPI support for the RK3328 Signed-off-by: Johannes Krottmayer Cc: Kever Yang Cc: Jagan Teki --- arch/arm/dts/rk3328-u-boot.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/dts/rk3328-u-boot.dtsi b/arch/arm/dts/rk3328-u-boot.dtsi index c69e13e11e..c980daae99

[PATCH 0/3] rockchip: rk3328: Add SPI support

2020-07-08 Thread Johannes Krottmayer
This patch series adds support for the RK3328 SPI controller. Johannes Krottmayer (3): drivers: clk: rockchip: clk_rk3328: Add SPI support drivers: spi: rk_spi: Add support for RK3328 ARM: dts: rk3328: Add SPI support arch/arm/dts/rk3328-u-boot.dtsi | 5 +

[PATCH 2/3] drivers: spi: rk_spi: Add support for RK3328

2020-07-08 Thread Johannes Krottmayer
Add support for the RK3328 SPI controller Signed-off-by: Johannes Krottmayer Cc: Kever Yang Cc: Jagan Teki --- I don't know if "rk3399_spi_params" is also required for the RK3328 SPI controller. Probing, Reading, Writing and Erasing of a flash device works with the SF command. Tested it with

[PATCH] fixdep: fix CONFIG_IS_ENABLED etc. handling

2020-07-08 Thread Stephen Warren
From: Stephen Warren When fixdep detects CONFIG_IS_ENABLED and other similar macros, it must parse the macro parameter to determine which actual CONFIG_ option is being referenced. This involves moving a pointer forward through the entire CONFIG_ option "word". Currently, the code uses variable

Re: test/py GPIO failure in u-boot/master

2020-07-08 Thread Stephen Warren
On 7/8/20 2:24 PM, Stephen Warren wrote: > On 7/8/20 10:06 AM, Tom Rini wrote: >> On Wed, Jul 08, 2020 at 09:50:06AM -0600, Stephen Warren wrote: >>> Latest u-boot/master is failing a couple test/py test_ut tests for GPIO: >>> => ut dm gpio Test: dm_test_gpio: gpio.c extra-gpios:

Re: test/py GPIO failure in u-boot/master

2020-07-08 Thread Simon Glass
Hi, On Wed, 8 Jul 2020 at 14:24, Stephen Warren wrote: > > On 7/8/20 10:06 AM, Tom Rini wrote: > > On Wed, Jul 08, 2020 at 09:50:06AM -0600, Stephen Warren wrote: > >> Latest u-boot/master is failing a couple test/py test_ut tests for GPIO: > >> > >>> => ut dm gpio > >>> Test: dm_test_gpio:

Re: test/py GPIO failure in u-boot/master

2020-07-08 Thread Stephen Warren
On 7/8/20 10:06 AM, Tom Rini wrote: > On Wed, Jul 08, 2020 at 09:50:06AM -0600, Stephen Warren wrote: >> Latest u-boot/master is failing a couple test/py test_ut tests for GPIO: >> >>> => ut dm gpio >>> Test: dm_test_gpio: gpio.c >>> extra-gpios: get_value: error: gpio b5 not reserved >>>

[PATCH v5] ARM: dts: stm32: add seeed studio odyssey-stm32mp157c board

2020-07-08 Thread Marcin Sloniewski
This commit adds device tree files supporting SBC from Seeed Studio based on STM32MP157C. This works with generic stm32mp1 config. Right now only booting from SD card is supported. Signed-off-by: Marcin Sloniewski --- Changes in v5: - removed description of PLL1 which is now handled by OPP

Re: [RFC PATCH 01/16] patman: Use test_util to show test results

2020-07-08 Thread Stephen Finucane
On Tue, 2020-07-07 at 11:09 +1000, Daniel Axtens wrote: > Simon Glass writes: > > > Hi Daniel, > > > > On Sun, 5 Jul 2020 at 22:50, Daniel Axtens wrote: > > > Daniel Axtens writes: > > > > > > > Hi Simon, > > > > > > > > I can't see a cover letter so apologies if I've misunderstood

[PATCH v6] ARM: dts: stm32: add seeed studio odyssey-stm32mp157c board

2020-07-08 Thread Marcin Sloniewski
This commit adds device tree files supporting SBC from Seeed Studio based on STM32MP157C. This works with generic stm32mp1 config. Right now only booting from SD card is supported. Signed-off-by: Marcin Sloniewski --- Changes in v6: - forgot to add changes in v5 ;( Changes in v5: - removed

Re: [PATCH 16/16] arm: Remove mx31pdk_defconfig board

2020-07-08 Thread Magnus Lilja
On Wed, 8 Jul 2020 at 15:04, Jagan Teki wrote: > > On Sat, Jun 13, 2020 at 7:26 PM Jagan Teki wrote: > > > > DM, OF_CONTROL, DM_SPI and other driver model migration > > deadlines are expired for this board. > > > > Remove it. > > > > Patch-cc: Magnus Lilja > > Signed-off-by: Jagan Teki > > ---

Re: [PATCH 00/16] spi: dm-conversion (part3)

2020-07-08 Thread Magnus Lilja
On Wed, 8 Jul 2020 at 14:55, Stefano Babic wrote: > > On 08.07.20 13:40, Jagan Teki wrote: > > On Sat, Jun 13, 2020 at 9:11 PM Tom Rini wrote: > >> > >> On Sat, Jun 13, 2020 at 07:24:39PM +0530, Jagan Teki wrote: > >> > >>> This series updated boards which are using mxc_spi > >>> driver. > >>> >

Re: [PATCH v2 2/5] arm: kirkwood: convert LaCie boards to DM_SPI_FLASH

2020-07-08 Thread Jagan Teki
On Wed, Jul 8, 2020 at 12:19 PM Jagan Teki wrote: > > On Sun, Jun 28, 2020 at 10:31 PM Simon Guinot > wrote: > > > > This patch converts the following Kirkwood-based LaCie boards to DM, > > DM_SPI and DM_SPI_FLASH: > > > > - d2 Network v2 > > - Internet Space v2 > > - 2Big Network v2 > > -

Re: [PATCH v2 16/23] ti: Drop sdp4430 board

2020-07-08 Thread Tom Rini
On Wed, Jul 08, 2020 at 12:12:57PM +0530, Jagan Teki wrote: > On Tue, Jul 7, 2020 at 9:30 PM Tom Rini wrote: > > > > On Tue, Jul 07, 2020 at 09:18:52PM +0530, Jagan Teki wrote: > > > On Sat, Jun 13, 2020 at 11:51 PM Jagan Teki > > > wrote: > > > > > > > > On Wed, May 27, 2020 at 6:27 PM Jagan

RE: [PATCH] i2c: stm32f7: SYSCFG Fast Mode Plus support for I2C STM32F7

2020-07-08 Thread Patrick DELAUNAY
Hi Heiko > From: Heiko Schocher > Sent: mardi 7 juillet 2020 07:21 > > Hello Patrick, > > Am 06.07.2020 um 13:31 schrieb Patrick Delaunay: > > Read SYSCFG bindings to set Fast Mode Plus bits if Fast Mode Plus > > speed is selected. > > > > Handle the stm32mp15 specific compatible to handle

Re: [PULL u-boot] Please pull u-boot-amlogic-20200708

2020-07-08 Thread Tom Rini
tps://gitlab.denx.de/u-boot/custodians/u-boot-amlogic.git > tags/u-boot-amlogic-20200708 > > for you to fetch changes up to d9c967792b7830d51a1fe596f9a27ea6dfd4bcfe: > > ARM: dts: meson-sm1-odroid-c4: add ethernet PHY reset (2020-07-08 10:52:45 > +0200) > Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

RE: [PATCH] arm: cmd_stm32prog: Fix the CONFIG_IS_ENABLED() usage

2020-07-08 Thread Patrick DELAUNAY
Hi Bin, > From: Bin Meng > Sent: mercredi 8 juillet 2020 09:19 > > Add parentheses around CONFIG_IS_ENABLED() in the if statement, to fix > potential build failures. > > Signed-off-by: Bin Meng > > --- > Fixes the issue as seen with Azure: >

RE: [PATCH 3/3] cmd: adtimg: Refactor usage style

2020-07-08 Thread Patrick DELAUNAY
Thanks, > From: Eugeniu Rosca > Sent: lundi 6 juillet 2020 08:47 > > Hi Patrick, > > On Fri, Jul 03, 2020 at 04:40:28PM +, Patrick DELAUNAY wrote: > > > From: U-Boot On Behalf Of Eugeniu > > > Rosca > > > Sent: samedi 11 janvier 2020 00:30 > > > > > > Hi Tom, > > > > > > On Fri, Jan 10,

Re: [PATCH v3 00/13] efi_loader: rework/improve UEFI secure boot code

2020-07-08 Thread Heinrich Schuchardt
On 08.07.20 07:01, AKASHI Takahiro wrote: > Summary > === > I'm currently working on reworking UEFI secure boot, aiming to add > "intermediate certificates" support. In this effort, I found a couple > of issues that should immediately be fixed or useful improvements even > without intermediate

[PATCH v3 14/17] efi_loader: memory buffer for variables

2020-07-08 Thread Heinrich Schuchardt
Saving UEFI variable as encoded U-Boot environment variables does not allow support at runtime. Provide functions to manage a memory buffer with UEFI variables. Signed-off-by: Heinrich Schuchardt --- include/efi_variable.h | 54 +++ lib/efi_loader/Makefile | 1 +

[PATCH v3 17/17] efi_selftest: adjust runtime test for variables

2020-07-08 Thread Heinrich Schuchardt
As variable services are available at runtime we have to expect EFI_SUCCESS when calling the services. Signed-off-by: Heinrich Schuchardt --- lib/efi_selftest/efi_selftest_variables_runtime.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git

[PATCH v3 15/17] efi_loader: use memory based variable storage

2020-07-08 Thread Heinrich Schuchardt
Saving UEFI variable as encoded U-Boot environment variables does not allow implement run-time support. Use a memory buffer for storing UEFI variables. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_variable.c | 556 ++ 1 file changed, 93

[PATCH v3 16/17] efi_loader: enable UEFI variables at runtime

2020-07-08 Thread Heinrich Schuchardt
Enable UEFI variables at runtime. Signed-off-by: Heinrich Schuchardt --- v3: Use efi_var_mem_ins() when restoring variables from file. Remove EFI_VARIABLE_READ_ONLY attribute in runtime GetVariable(). --- lib/efi_loader/efi_runtime.c | 2 ++ lib/efi_loader/efi_var_file.c | 6

[PATCH v3 12/17] efi_loader: optional pointer for ConvertPointer

2020-07-08 Thread Heinrich Schuchardt
If the EFI_OPTIONAL_PTR is set in DebugDisposition, a NULL pointer does not constitute an invalid parameter. Signed-off-by: Heinrich Schuchardt --- include/efi_api.h| 2 ++ lib/efi_loader/efi_runtime.c | 6 ++ 2 files changed, 8 insertions(+) diff --git a/include/efi_api.h

[PATCH v3 13/17] efi_loader: new function efi_memcpy_runtime()

2020-07-08 Thread Heinrich Schuchardt
Provide a memcpy() function that we can use at UEFI runtime. Signed-off-by: Heinrich Schuchardt --- include/efi_loader.h | 3 +++ lib/efi_loader/efi_runtime.c | 19 +++ 2 files changed, 22 insertions(+) diff --git a/include/efi_loader.h b/include/efi_loader.h index

[PATCH v3 09/17] efi_loader: secure boot flag

2020-07-08 Thread Heinrich Schuchardt
In audit mode the UEFI variable SecureBoot is set to zero but the efi_secure_boot flag is set to true. The efi_secure_boot flag should match the UEFIvariable SecureBoot. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_variable.c | 8 ++-- 1 file changed, 2 insertions(+), 6

[PATCH v3 10/17] efi_loader: UEFI variable persistence

2020-07-08 Thread Heinrich Schuchardt
Persist non-volatile UEFI variables in a file on the EFI system partition. The file is written whenever a non-volatile UEFI variable is changed after initialization of the UEFI sub-system. The file is read during the UEFI sub-system initialization to restore non-volatile UEFI variables.

[PATCH v3 11/17] efi_loader: export efi_convert_pointer()

2020-07-08 Thread Heinrich Schuchardt
We need ConvertPointer() to adjust pointers when implementing runtime services within U-Boot. After ExitBootServices() gd is not available anymore. So we should not use EFI_ENTRY() and EFI_EXIT(). Signed-off-by: Heinrich Schuchardt --- include/efi_loader.h | 3 +++

[PATCH v3 08/17] efi_loader: read-only AuditMode and DeployedMode

2020-07-08 Thread Heinrich Schuchardt
Set the read only property of the UEFI variables AuditMode and DeployedMode conforming to the UEFI specification. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_variable.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git

[PATCH v3 01/17] efi_loader: prepare for read only OP-TEE variables

2020-07-08 Thread Heinrich Schuchardt
We currently have two implementations of UEFI variables: * variables provided via an OP-TEE module * variables stored in the U-Boot environment Read only variables are up to now only implemented in the U-Boot environment implementation. Provide a common interface for both implementations that

[PATCH v3 07/17] efi_loader: value of VendorKeys

2020-07-08 Thread Heinrich Schuchardt
According to the UEFI specification the variable VendorKeys is 1 if the "system is configured to use only vendor-provided keys". As we do not supply any vendor keys yet the variable VendorKeys must be zero. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_variable.c | 75

[PATCH v3 03/17] efi_loader: separate UEFI variable API from implemementation

2020-07-08 Thread Heinrich Schuchardt
Separate the remaining UEFI variable API functions GetNextVariableName and QueryVariableInfo() from internal functions implementing them. Signed-off-by: Heinrich Schuchardt --- v3: avoid setting efi_runtime_services.set_variable twice --- include/efi_variable.h| 39

[PATCH v3 05/17] efi_loader: simplify boot manager

2020-07-08 Thread Heinrich Schuchardt
Simplify the implementation of the UEFI boot manager: * avoid EFI_CALL for SetVariable() and GetVariable() * remove unnecessary type conversions Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_bootmgr.c | 28 1 file changed, 12 insertions(+), 16

[PATCH v3 04/17] efi_loader: OsIndicationsSupported, PlatformLangCodes

2020-07-08 Thread Heinrich Schuchardt
UEFI variables OsIndicationsSupported, PlatformLangCodes should be read only. Avoid EFI_CALL() for SetVariable(). Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_setup.c | 59 -- 1 file changed, 31 insertions(+), 28 deletions(-) diff --git

[PATCH v3 02/17] efi_loader: display RO attribute in printenv -e

2020-07-08 Thread Heinrich Schuchardt
Let the 'printenv -e' command display the read only flag. If the variable is time authenticated write the time stamp. Avoid EFI_CALL() when calling SetVariable() and GetVariable(). Signed-off-by: Heinrich Schuchardt --- cmd/nvedit_efi.c | 24 1 file changed, 16

[PATCH v3 06/17] efi_loader: keep attributes in efi_set_variable_int

2020-07-08 Thread Heinrich Schuchardt
Do not change the value of parameter attributes in function efi_set_variable_int(). This allows to use it later. Do not use variable attr for different purposes but declare separate variables (attr and old_attr). Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_variable.c | 24

[PATCH v3 00/17] efi_loader: non-volatile and runtime variables

2020-07-08 Thread Heinrich Schuchardt
Up to now UEFI variables where stored in U-Boot environment variables. Saving UEFI variables was not possible without saving the U-Boot environment variables. With this patch series file ubootefi.var in the EFI system partition is used for saving UEFI variables. Furthermore the UEFI variables

Re: test/py GPIO failure in u-boot/master

2020-07-08 Thread Tom Rini
On Wed, Jul 08, 2020 at 09:50:06AM -0600, Stephen Warren wrote: > Latest u-boot/master is failing a couple test/py test_ut tests for GPIO: > > > => ut dm gpio > > Test: dm_test_gpio: gpio.c > > extra-gpios: get_value: error: gpio b5 not reserved > >

test/py GPIO failure in u-boot/master

2020-07-08 Thread Stephen Warren
Latest u-boot/master is failing a couple test/py test_ut tests for GPIO: > => ut dm gpio > Test: dm_test_gpio: gpio.c > extra-gpios: get_value: error: gpio b5 not reserved > /var/lib/jenkins/workspace/u-boot-denx_uboot-master-build/src/u-boot/test/dm/gpio.c:137, > dm_test_gpio (): 0 ==

Re: [PATCH] config: Enable USB Keyboard support on RPi4

2020-07-08 Thread Matthias Brugger
On 05/05/2020 16:51, Nicolas Saenz Julienne wrote: Supporting USB keyboards out of the box is both handy for development and production. Notably if u-boot is used to boot into GRUB. Signed-off-by: Nicolas Saenz Julienne Applied to rpi-next now. I dropped the hunk for 32 bit for now,

Re: CONFIG_NR_DRAM_BANKS in configs/rpi_4* deleted

2020-07-08 Thread Tom Rini
On Wed, Jul 08, 2020 at 05:21:59PM +0200, Matthias Brugger wrote: > Hi Tom, > > I just realized that > 88bd5b1793 ("configs: Resync with savedefconfig") > > Delete the CONFIG_NR_DRAM_BANKS entries as added in this patch, which leads > to a regression in RPi4 (only one GB of memory visible to

CONFIG_NR_DRAM_BANKS in configs/rpi_4* deleted

2020-07-08 Thread Matthias Brugger
Hi Tom, I just realized that 88bd5b1793 ("configs: Resync with savedefconfig") Delete the CONFIG_NR_DRAM_BANKS entries as added in this patch, which leads to a regression in RPi4 (only one GB of memory visible to the kernel if you use Grub for booting). Is it generally wrong to add

Re: [PATCH v3 07/15] dt-bindings: memory: ns3: update GIC LPI address

2020-07-08 Thread Rayagonda Kokatanur
Hi Simon, On Mon, Jul 6, 2020 at 11:53 AM Rayagonda Kokatanur wrote: > > On Mon, Jul 6, 2020 at 10:56 AM Simon Glass wrote: > > > > Hi Rayagonda, > > > > On Sun, 5 Jul 2020 at 12:21, Rayagonda Kokatanur > > wrote: > > > > > > Hi Simon, > > > > > > On Sun, Jul 5, 2020 at 12:20 AM Rayagonda

Re: [PATCH v3 06/15] board: ns3: default reset type to L3

2020-07-08 Thread Rayagonda Kokatanur
Hi Simon, On Wed, Jul 8, 2020 at 8:31 PM Simon Glass wrote: > > Hi Rayagonda, > > On Wed, 8 Jul 2020 at 01:01, Rayagonda Kokatanur > wrote: > > > > Hi Simon, > > > > On Fri, Jul 3, 2020 at 6:16 AM Simon Glass wrote: > > > > > > Hi Rayagonda, > > > > > > On Mon, 29 Jun 2020 at 22:43, Rayagonda

Re: [PATCH v6 0/4] usb: xhci: Load Raspberry Pi 4 VL805's firmware

2020-07-08 Thread Matthias Brugger
On 29/06/2020 18:37, Nicolas Saenz Julienne wrote: Newer revisions of the RPi4 need their xHCI chip, VL805, firmware to be loaded explicitly. Earlier versions didn't need that as they where using an EEPROM for that purpose. This series takes care of setting up the relevant infrastructure and

Re: [PATCH v4 0/9] USB host support for Raspberry Pi 4 board (64-bit)

2020-07-08 Thread Matthias Brugger
On 25/05/2020 13:39, Sylwester Nawrocki wrote: Hi all, This patch series adds USB host support for Raspberry Pi 4 board. It includes the Broadcom STB PCIe controller driver ported from Linux kernel, a memory mapping update for the xHCI controller on PCIe bus for 64-bit builds and some

[PATCH v2 1/2] spi: Remove unnecessary #ifdefs in header file

2020-07-08 Thread Simon Glass
These prevent use of compile-time checks such as: if (CONFIG_IS_ENABLED(DM_SPI)) since, for example, if CONFIG_SPL_DM_SPI is not enabled then the definitions are not included by spi.h and the C code will not build. The #ifdefs are unnecessary since there are no conflicts with the pre-DM

Re: [PATCH v3 06/15] board: ns3: default reset type to L3

2020-07-08 Thread Simon Glass
Hi Rayagonda, On Wed, 8 Jul 2020 at 01:01, Rayagonda Kokatanur wrote: > > Hi Simon, > > On Fri, Jul 3, 2020 at 6:16 AM Simon Glass wrote: > > > > Hi Rayagonda, > > > > On Mon, 29 Jun 2020 at 22:43, Rayagonda Kokatanur > > wrote: > > > > > > Hi Simon, > > > > > > On Fri, Jun 26, 2020 at 6:42 AM

[PATCH v2 2/2] x86: apl: Re-enable loading of SPL

2020-07-08 Thread Simon Glass
At present the SPL loader is not included in the TPL image so SPL cannot be loaded. Fix it by including this file for both SPL and TPL. Signed-off-by: Simon Glass Fixes: c87f9ce2273 ("x86: Don't build some unused objects in TPL") --- (no changes since v1) arch/x86/cpu/apollolake/Makefile | 2

Re: [PATCH 1/2] spi: Remove unnecessary #ifdefs in header file

2020-07-08 Thread Simon Glass
Hi Bin, On Tue, 7 Jul 2020 at 19:05, Bin Meng wrote: > > Hi Simon, > > On Tue, Jul 7, 2020 at 3:58 PM Bin Meng wrote: > > > > On Tue, Jul 7, 2020 at 3:56 PM Bin Meng wrote: > > > > > > On Mon, Jul 6, 2020 at 10:16 AM Simon Glass wrote: > > > > > > > > These prevent use of compile-time checks

Re: [PATCH v1 02/43] binman: Refactor binman_entry_find() to allow other nodes

2020-07-08 Thread Tom Rini
On Wed, Jul 08, 2020 at 12:07:24PM +0800, Bin Meng wrote: > +Tom, > > On Wed, Jul 8, 2020 at 10:23 AM Simon Glass wrote: > > > > Hi Bin, > > > > On Mon, 29 Jun 2020 at 20:33, Bin Meng wrote: > > > > > > Hi Simon, > > > > > > On Mon, Jun 15, 2020 at 11:57 AM Simon Glass wrote: > > > > > > > >

Re: [PATCH v2 2/2] pwm: Add PWM driver for SiFive SoC

2020-07-08 Thread Tom Rini
On Wed, Jul 08, 2020 at 06:30:28AM +0200, Heiko Schocher wrote: > Hello Yash, > > Am 23.04.2020 um 13:27 schrieb Yash Shah: > > Adds a PWM driver for PWM chip present in SiFive's HiFive Unleashed SoC > > This driver is simple port of Linux pwm sifive driver from Linux v5.6 > > > > commit:

Re: [PATCH] gpio: fix test.py for gpio label lookup

2020-07-08 Thread Tom Rini
On Wed, Jul 08, 2020 at 10:24:00AM +0200, Heiko Schocher wrote: > commit 2bd261dd1712 ("gpio: search for gpio label if gpio is not found > through bank name") > > disabled DM_GPIO_LOOKUP_LABEL which is needed > in sandbox defconfigs, as we have tests for this > functionality. > >

Re: Pull request: u-boot-rockchip-20200708

2020-07-08 Thread Tom Rini
tlab.denx.de/u-boot/custodians/u-boot-rockchip.git > tags/u-boot-rockchip-20200708 > > for you to fetch changes up to ad277eb4587ab1ac710ce8fd2b733874032d951f: > > ARM: dts: rockchip: Add Radxa Rock Pi N8 initial support (2020-07-07 > 19:45:57 +0800) > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: 'next' now merged to 'master'

2020-07-08 Thread Tom Rini
On Wed, Jul 08, 2020 at 08:30:51AM +0200, Heiko Schocher wrote: > Hi Tom, > > Am 07.07.2020 um 15:38 schrieb Tom Rini: > > Hey all, > > > > I have now merged the next branch back in to master and pushed that out. > > Unfortunately you changed patch: > > "gpio: search for gpio label if gpio is

[PULL u-boot] Please pull u-boot-amlogic-20200708

2020-07-08 Thread Neil Armstrong
2f5fbb5b39f7b67044dda5c35e4a4b31685a3109: Prepare v2020.07 (2020-07-06 15:22:53 -0400) are available in the Git repository at: https://gitlab.denx.de/u-boot/custodians/u-boot-amlogic.git tags/u-boot-amlogic-20200708 for you to fetch changes up to d9c967792b7830d51a1fe596f9a27ea6dfd4bcfe

Re: [PATCH 03/16] dh_imx6: Switch to full DM-aware

2020-07-08 Thread Jagan Teki
On Mon, Jun 22, 2020 at 3:09 PM 'Ludwig Zenz' via Amarula Linux wrote: > > On 6/13/20 3:55 PM, Jagan Teki wrote: > > Enable DM_SPI/DM_SPI_FLASH with a related config option. > > > > Build fine, but not tested. > > Hello, > > due to memory limitations in the SRAM of the i.MX6S in SPL we have not

Re: [PATCH 16/16] arm: Remove mx31pdk_defconfig board

2020-07-08 Thread Jagan Teki
On Sat, Jun 13, 2020 at 7:26 PM Jagan Teki wrote: > > DM, OF_CONTROL, DM_SPI and other driver model migration > deadlines are expired for this board. > > Remove it. > > Patch-cc: Magnus Lilja > Signed-off-by: Jagan Teki > --- Added board maintainer.

  1   2   >