Re: [PATCH 5/9] xhci-ring.c: Add the poll_pend state to properly abort transactions

2020-08-23 Thread Jason Wessel
On 8/20/20 3:26 AM, Bin Meng wrote: > Hi Jason, > > On Sat, Jul 25, 2020 at 5:51 AM Jason Wessel > wrote: >> >> xhci_trl_tx and xhchi_bulk_tx can be called synchronously by other >> drivers such as the usb storage or network, while the keyboard driver >> exclusively uses the polling mode. >>

u-boot@lists.denx.de

2020-08-23 Thread Tom Rini
On Tue, Aug 11, 2020 at 11:23:40AM -0600, Simon Glass wrote: > These brackets are not needed. Drop them. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 8/8] stdio: Tidy up the coding style

2020-08-23 Thread Tom Rini
On Tue, Aug 11, 2020 at 11:23:41AM -0600, Simon Glass wrote: > Bring the coding style in this file up to the current level. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 6/8] stdio: Update to use compiler for Kconfig checks

2020-08-23 Thread Tom Rini
On Tue, Aug 11, 2020 at 11:23:39AM -0600, Simon Glass wrote: > Drop use of the preprocessor where possible. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 2/8] Convert CONFIG_SPLASH_SCREEN et al to Kconfig

2020-08-23 Thread Tom Rini
On Tue, Aug 11, 2020 at 11:23:35AM -0600, Simon Glass wrote: > This converts the following to Kconfig: >CONFIG_SPLASH_SCREEN >CONFIG_SPLASH_SCREEN_ALIGN >CONFIG_SPLASHIMAGE_GUARD >CONFIG_SPLASH_SOURCE > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom si

Re: [PATCH v2 5/8] stdio: Drop #ifdefs in the header file

2020-08-23 Thread Tom Rini
On Tue, Aug 11, 2020 at 11:23:38AM -0600, Simon Glass wrote: > These prevent the use of IS_ENABLED() and are unnecessary. Drop them and > fix a few code-style nits nearby. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 1/8] moveconfig: Skip binary and ELF files

2020-08-23 Thread Tom Rini
On Tue, Aug 11, 2020 at 11:23:34AM -0600, Simon Glass wrote: > Add a few more file extensions to the list of files that should not be > processed. This avoids unicode errors, for example. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP

Re: [PATCH v2 4/8] stdio: Tidy up use of CONFIG_SYS_DEVICE_NULLDEV

2020-08-23 Thread Tom Rini
On Tue, Aug 11, 2020 at 11:23:37AM -0600, Simon Glass wrote: > Now that this is in Kconfig we can move the logic at the top of the file > to Kconfig, and use if() instead of #if. Update the file with these > changes. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom si

Re: [PATCH v2 3/8] Convert CONFIG_SYS_DEVICE_NULLDEV to Kconfig

2020-08-23 Thread Tom Rini
On Tue, Aug 11, 2020 at 11:23:36AM -0600, Simon Glass wrote: > This converts the following to Kconfig: >CONFIG_SYS_DEVICE_NULLDEV > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] arm: dts: fix ast2500-evb inclusion for correct target

2020-08-23 Thread Tom Rini
On Sat, Aug 22, 2020 at 10:24:58PM -0700, Thirupathaiah Annapureddy wrote: > > > On 8/20/2020 5:03 PM, Tom Rini wrote: > > On Thu, Aug 20, 2020 at 02:09:55PM -0700, Thirupathaiah Annapureddy wrote: > >> Hi Ryan, > >> > >> Thanks for reviewing the patch. Please see my comment(s): > >> > >> On 8/19

Re: [PATCH] Convert CONFIG_NETCONSOLE to Kconfig

2020-08-23 Thread Tom Rini
On Sun, Aug 23, 2020 at 01:42:47PM -0400, Tom Rini wrote: > This converts the following to Kconfig: >CONFIG_NETCONSOLE > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

[PATCH] Convert CONFIG_NETCONSOLE to Kconfig

2020-08-23 Thread Tom Rini
This converts the following to Kconfig: CONFIG_NETCONSOLE Signed-off-by: Tom Rini --- arch/arm/mach-kirkwood/include/mach/config.h | 1 - configs/SBx81LIFKW_defconfig | 1 + configs/SBx81LIFXCAT_defconfig | 1 + configs/brppt1_mmc_defconfig | 1 +

RPi4 U-Boot freeze

2020-08-23 Thread Stefan Agner
Hi, I noticed a quite common freeze when running 32-bit U-Boot 2020.01 (rpi_4_32b_defconfig) on a 2GB RPi4 model: U-Boot 2020.01 (Aug 07 2020 - 13:00:23 +) DRAM: 1.9 GiB This happens fairly often, I would say 4 out of 5 boot tries. However, if it boots, everything seems to run fine. The

Re: [PATCH v2 1/4] firmware: add new driver for SCMI firmwares

2020-08-23 Thread Etienne Carriere
Hello Simon, > > This change introduces SCMI agent driver in U-Boot in the firmware > > U-class. > > (...) > > Changes in v2: > > (...) > > > > Note: review comments on defining a uclass and sandbox for SCMI > > transport drivers are NOT addressed in this v2. Main issue is that > > there is no dri

Re: [PATCHv3 02/10] gpio: mxc_gpio: add support to read status of output gpios

2020-08-23 Thread Fabio Estevam
Hi Sebastian, On Fri, Aug 21, 2020 at 1:16 PM Sebastian Reichel wrote: > > This is supported by the hardware when the pinmux is configured I assume you are referring to the SION bit. > correctly. Usually it is not, so this adds explicit code for this. > This fixes all GPIO regulators being show

Re: [PATCH v1 06/24] pci: pci-uclass: Add multi entry support for memory regions

2020-08-23 Thread Tom Rini
On Sun, Aug 23, 2020 at 11:41:41AM +0200, Stefan Roese wrote: > Hi Simon, > Hi Tom, > > On 22.08.20 17:09, Simon Glass wrote: > > Hi Stefan, > > > > On Fri, 14 Aug 2020 at 05:40, Stefan Roese wrote: > > > > > > Hi Simon, > > > > > > On 04.08.20 17:05, Simon Glass wrote: > > > > > > > > > >

Re: [PATCH v1 06/24] pci: pci-uclass: Add multi entry support for memory regions

2020-08-23 Thread Stefan Roese
Hi Simon, Hi Tom, On 22.08.20 17:09, Simon Glass wrote: Hi Stefan, On Fri, 14 Aug 2020 at 05:40, Stefan Roese wrote: Hi Simon, On 04.08.20 17:05, Simon Glass wrote: Changes in v1: - Change patch subject - Enhance Kconfig help descrition - Use if() instead of #if drivers/pci/Kconfi

[PATCH 3/4] test: unit test for efi_dp_check_length()

2020-08-23 Thread Heinrich Schuchardt
Provide a unit test for function efi_dp_check_length(). Signed-off-by: Heinrich Schuchardt --- test/lib/Makefile | 1 + test/lib/efi_device_path.c | 50 ++ 2 files changed, 51 insertions(+) create mode 100644 test/lib/efi_device_path.c diff --git a

[PATCH 4/4] efi_loader: validate device path length in boot manager

2020-08-23 Thread Heinrich Schuchardt
Boot variables are provided by the user and therefore cannot be trusted. We have to validate them before usage. A device path provided by a Boot variable must have an end node within the indicated device path length. Signed-off-by: Heinrich Schuchardt --- lib/efi_loader/efi_bootmgr.c |

[PATCH 1/4] include: kernel.h: define SSIZE_MAX

2020-08-23 Thread Heinrich Schuchardt
Define SSIZE_MAX, the largest value fitting into a variable of type ssize_t. Signed-off-by: Heinrich Schuchardt --- include/linux/kernel.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/linux/kernel.h b/include/linux/kernel.h index b88c210065..3e71d61074 100644 --- a/include/linu

[PATCH 0/4] efi_loader: validate device path length in boot manager

2020-08-23 Thread Heinrich Schuchardt
Boot variables are provided by the user and therefore cannot be trusted. We have to validate them before usage. A device path provided by a Boot variable must have an end node within the indicated device path length. * Provide function efi_dp_check_length() to check the length of device

[PATCH 2/4] efi_loader: efi_dp_check_length()

2020-08-23 Thread Heinrich Schuchardt
We need to check that device paths provided via UEFI variables are not malformed. Provide function efi_dp_check_length() to check if a device path has an end node within a given number of bytes. Signed-off-by: Heinrich Schuchardt --- include/efi_loader.h | 2 ++ lib/efi_loader/efi_