[PATCH 1/1] env: typo enougth

2020-10-29 Thread Heinrich Schuchardt
%s/enougth/enough/ Signed-off-by: Heinrich Schuchardt --- env/nowhere.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/env/nowhere.c b/env/nowhere.c index d33fdf27d0..d43a2d6b51 100644 --- a/env/nowhere.c +++ b/env/nowhere.c @@ -30,7 +30,7 @@ static int

Re: [PATCH v7 01/17] dfu: rename dfu_tftp_write() to dfu_write_by_name()

2020-10-29 Thread AKASHI Takahiro
Tom, On Thu, Oct 29, 2020 at 10:43:16AM -0400, Tom Rini wrote: > On Thu, Oct 29, 2020 at 01:47:41PM +0900, AKASHI Takahiro wrote: > > > This function is essentially independent from tftp, and will also be > > utilised in implementing UEFI capsule update in a later commit. > > So just give it a

[PATCH v3 25/29] patman: Detect missing upstream in CountCommitsToBranch

2020-10-29 Thread Simon Glass
At present if we fail to find the upstream then the error output is piped to wc, resulting in bogus results. Avoid the pipe and check the output directly. Signed-off-by: Simon Glass --- (no changes since v1) tools/patman/func_test.py | 19 +++ tools/patman/gitutil.py | 10

[PATCH v3 29/29] patman: Support listing comments from patchwork

2020-10-29 Thread Simon Glass
While reviewing feedback it is helpful to see the review comments on the command line to check that each has been addressed. Add an option to support that. Update the workflow documentation to describe the new features. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: -

[PATCH v3 27/29] patman: Support updating a branch with review tags

2020-10-29 Thread Simon Glass
It is tedious to add review tags into the local branch and errors can sometimes be made. Add an option to create a new branch with the review tags obtained from patchwork. Signed-off-by: Simon Glass --- Changes in v3: - Allow tags to be inserted in the middle of the commit message

[PATCH v3 26/29] patman: Support checking for review tags in patchwork

2020-10-29 Thread Simon Glass
Before sending out a new version of a series for review, it is important to add any review tags (e.g. Reviewed-by, Acked-by) collected by patchwork. Otherwise people waste time reviewing the same patch repeatedly, become frustrated and stop reviewing your patches. To help with this, add a new

[PATCH v3 23/29] patman: Allow showing a Commit as a string

2020-10-29 Thread Simon Glass
Use the subject of the Commit object when printing it out. Signed-off-by: Simon Glass --- (no changes since v1) tools/patman/commit.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/patman/commit.py b/tools/patman/commit.py index e49bf87dfc8..5bf2b940299 100644 ---

[PATCH v3 28/29] patman: Support parsing of review snippets

2020-10-29 Thread Simon Glass
Add support for parsing the contents of a patchwork 'patch' web page containing comments received from reviewers. This allows patman to show these comments in a simple 'snippets' format. A snippet is some quoted code plus some unquoted comments below it. Each review is from a unique person/email

[PATCH v3 24/29] patman: Improve handling of files

2020-10-29 Thread Simon Glass
Sometimes warnings are associated with a file and sometimes with the patch as a whole. Update the regular expression to handle both cases, even in emacs mode. Also add support for detecting new files. Signed-off-by: Simon Glass --- (no changes since v1) tools/patman/checkpatch.py | 11

[PATCH v3 21/29] patman: Fix spelling of plural for warning

2020-10-29 Thread Simon Glass
Tidy up the extra 's' when there is only a single warning. Fix the empty print statement also. Signed-off-by: Simon Glass --- (no changes since v1) tools/patman/patchstream.py | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tools/patman/patchstream.py

[PATCH v3 22/29] patman: Don't ignore lines starting with hash

2020-10-29 Thread Simon Glass
These lines can indicate a continuation of an error and should not be ignored. Fix this. Fixes: 666eb15e923 ("patman: Handle checkpatch output with notes and code") Signed-off-by: Simon Glass --- (no changes since v1) tools/patman/checkpatch.py | 7 +-- 1 file changed, 5 insertions(+), 2

[PATCH v3 19/29] patman: Add some tests for warnings

2020-10-29 Thread Simon Glass
Add tests that check that warnings are generated when expected. Signed-off-by: Simon Glass --- (no changes since v1) tools/patman/func_test.py | 111 +--- tools/patman/main.py| 16 +- tools/patman/patchstream.py | 2 +- 3 files changed, 116

[PATCH v3 09/29] patman: Fix constant style in patchstream

2020-10-29 Thread Simon Glass
These constants should use upper case. Update them to keep pylint3 happy. Signed-off-by: Simon Glass --- (no changes since v1) tools/patman/patchstream.py | 44 ++--- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/tools/patman/patchstream.py

[PATCH v3 20/29] patman: Convert testBasic() to use an interator

2020-10-29 Thread Simon Glass
On balance it is easier to use an iterator here, particularly if we need to insert lines due to new functionality. The only niggle is the need to keep the previous iterator value around in one case. Convert this test to use iter(). Signed-off-by: Simon Glass --- (no changes since v1)

[PATCH v3 15/29] patman: Attach warnings to individual patches

2020-10-29 Thread Simon Glass
At present warnings are produced across the whole set of patches when parsing them. It is more useful to associate each warning with the patch (or commit) that generated it. Attach warnings to the Commit object and move them out of PatchStream. Also avoid generating duplicate warnings for the

[PATCH v3 14/29] patman: Move warning collection to a function

2020-10-29 Thread Simon Glass
Add a new function in PatchStream to collect the warnings generated while parsing the stream. This will allow us to adjust the logic, such as dealing with per-commit warnings. Two of the warnings are in fact internal errors, so change them to raise and exception. Signed-off-by: Simon Glass ---

[PATCH v3 17/29] patman: Drop unused signoff member

2020-10-29 Thread Simon Glass
This is not used. Drop it. Signed-off-by: Simon Glass --- (no changes since v1) tools/patman/func_test.py | 1 + tools/patman/patchstream.py | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/patman/func_test.py b/tools/patman/func_test.py index

[PATCH v3 16/29] patman: Convert 'Series-xxx' tag errors into warnings

2020-10-29 Thread Simon Glass
If the Series-xxx tag is not recognised patman currently reports a fatal error. This is inconvenient if a new feature is later added to patman that an earlier version does not support. Report a warning instead, to allow the user to take action if needed, but still allow operation to proceed.

[PATCH v3 18/29] patman: Add a test for PatchStream tags

2020-10-29 Thread Simon Glass
The current functional tests run most of patman. Add a smaller test that just checks tag handling with the PatchStream class. Signed-off-by: Simon Glass --- (no changes since v1) tools/patman/func_test.py | 26 +- tools/patman/patchstream.py | 23

[PATCH v3 13/29] patman: Fix up argument/return docs in patchstream

2020-10-29 Thread Simon Glass
Add missing documentation and type information. Fix up some missing docs on exceptions also. Signed-off-by: Simon Glass --- (no changes since v1) tools/patman/patchstream.py | 82 ++--- 1 file changed, 50 insertions(+), 32 deletions(-) diff --git

[PATCH v3 11/29] patman: Rename variables in patchstream

2020-10-29 Thread Simon Glass
Some variables are too short or shadow other variables or types. Fix these to keep pylint3 happy. Signed-off-by: Simon Glass --- (no changes since v1) tools/patman/patchstream.py | 52 ++--- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git

[PATCH v3 12/29] patman: Drop unused args in patchstream

2020-10-29 Thread Simon Glass
Drop a few arguments that are not used in functions. Signed-off-by: Simon Glass --- (no changes since v1) tools/patman/patchstream.py | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tools/patman/patchstream.py b/tools/patman/patchstream.py index

[PATCH v3 10/29] patman: Rename functions in patchstream

2020-10-29 Thread Simon Glass
Rename these functions to lower case as per PEP8. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 6 +-- tools/patman/control.py | 6 +-- tools/patman/func_test.py | 6 +-- tools/patman/patchstream.py | 88

[PATCH v3 08/29] patman: Fix indenting in patchstream

2020-10-29 Thread Simon Glass
Update the indenting to keep pylint3 happy. Signed-off-by: Simon Glass --- (no changes since v1) tools/patman/patchstream.py | 29 - 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/tools/patman/patchstream.py b/tools/patman/patchstream.py index

[PATCH v3 05/29] patman: Use capture_sys_output() consistently

2020-10-29 Thread Simon Glass
One test still uses its own function for capturing output. Modify it to use the standard one in test_util Signed-off-by: Simon Glass --- (no changes since v1) tools/patman/func_test.py | 20 ++-- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git

[PATCH v3 07/29] patman: Allow linking a series with patchwork

2020-10-29 Thread Simon Glass
Add a new Series-links tag to tell patman how to find the series in patchwork. Each item is the series ID optionally preceded by the series version that the link refers to. An empty version indicates this is the latest series. For example: Series-links: 209816 1:203302 Documentation is added

[PATCH v3 06/29] patman: Fix remaining pylint3 warnings in func_test

2020-10-29 Thread Simon Glass
This fixes all but the ones about too many variables/statements. Signed-off-by: Simon Glass --- (no changes since v1) tools/patman/func_test.py | 76 +-- 1 file changed, 58 insertions(+), 18 deletions(-) diff --git a/tools/patman/func_test.py

[PATCH v3 04/29] patman: Fix whitespace errors in func_test

2020-10-29 Thread Simon Glass
Fix up various indentation and other minor things to make pylint3 happier. Signed-off-by: Simon Glass --- (no changes since v1) tools/patman/func_test.py | 37 +++-- 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/tools/patman/func_test.py

[PATCH v3 02/29] azure/gitLab/travis: Add pygit2 as a dependency for tests

2020-10-29 Thread Simon Glass
This lets patman run all of its tests, rather than skipping quite a few. Signed-off-by: Simon Glass --- (no changes since v1) .azure-pipelines.yml | 2 +- .gitlab-ci.yml | 2 +- .travis.yml | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH v3 01/29] patman: Correct operation of -n

2020-10-29 Thread Simon Glass
This operation was unfortunately broken by a recent change. It is now necessary to use -i in addition to -n, if there are errors or warnings in the patches. Correct this by always showing the summary information. Fixes: f3653759758 ("patman: Move main code out to a control module")

[PATCH v3 00/29] patman: Collect review tags and comments from Patchwork

2020-10-29 Thread Simon Glass
Patman is a useful tool for creating, checking sending out patches. It automates the creation of patches, simplifies checking them and handles cover letters and change logs. However once patches are sent and reviewers add Reviewed-by tags, etc., these must be manually added into the commits using

[PATCH v3 03/29] patman: Update how tests are run

2020-10-29 Thread Simon Glass
The current instructions are out-of-date. Fix them. Signed-off-by: Simon Glass --- (no changes since v1) tools/patman/README | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tools/patman/README b/tools/patman/README index 52b2cf70bd0..7ede1068ee1 100644 ---

Re: [PATCH v2 11/11] Azure/GitLab/Travis: Add SPL unit tests

2020-10-29 Thread Simon Glass
Run SPL unit tests in all test environments. Signed-off-by: Simon Glass --- (no changes since v1) .azure-pipelines.yml | 2 +- .gitlab-ci.yml | 2 +- .travis.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v2 15/28] binman: Move section padding to the parent

2020-10-29 Thread Simon Glass
Each section is padded up to its size, if the contents are not large enough. Move this logic from _BuildSectionData() to GetPaddedDataForEntry() so that all the padding is in one place. With this, the testDual test is working again, so enable it. Signed-off-by: Simon Glass --- Changes in v2: -

Re: [PATCH 15/20] dm: core: Convert #ifdef to if() in root.c

2020-10-29 Thread Simon Glass
Convert a few conditions to use compile-time checks to reduce the number of build paths. Signed-off-by: Simon Glass --- drivers/core/root.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v2 16/28] binman: Make section padding consistent with other entries

2020-10-29 Thread Simon Glass
At present padding of sections is inconsistent with other entry types, in that different pad bytes are used. When a normal entry is padded by its parent, the parent's pad byte is used. But for sections, the section's pad byte is used. Adjust logic to always do this the same way. Note there is

Re: [PATCH v2 07/28] binman: Expand the error message for breaching a section

2020-10-29 Thread Simon Glass
Add in a few more details to this error message to make it easier to see what is going on. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/etype/section.py | 10 ++ tools/binman/ftest.py | 5 +++-- 2 files changed, 9 insertions(+), 6 deletions(-) Applied to

Re: [PATCH 07/20] sandbox: Allow selection of SPL unit tests

2020-10-29 Thread Simon Glass
Now that we have more than one test, add a way to select the test to run. Signed-off-by: Simon Glass --- arch/sandbox/cpu/spl.c | 2 +- arch/sandbox/cpu/start.c | 9 + arch/sandbox/include/asm/state.h | 1 + 3 files changed, 11 insertions(+), 1 deletion(-) Applied to

Re: [PATCH 09/20] dm: test: Add a check that all devices have a dev value

2020-10-29 Thread Simon Glass
With of-platdata, the driver_info struct is updated with the device pointer when it is bound. This makes it easy for a device to be found by its driver info with the device_get_by_driver_info() function. Add a test that all devices (except the root device) have such an entry. Fix a bug that the

Re: [PATCH v2 03/28] binman: Add tests for skip-at-start sections

2020-10-29 Thread Simon Glass
At present this feature is tested view the end-at-4gb feature. Add some tests of its own, including the operation of padding. The third test here shows binman's current, inconsistent approach to padding in the top-level section. Future patches in this series will address this. Signed-off-by:

Re: [PATCH 06/20] dm: Add a C test for of-platdata properties

2020-10-29 Thread Simon Glass
At present properties are tested in a roundabout way. The driver's probe() method writes out the values of the properties and the Python test checks the output from U-Boot SPL. Add a C test which checks these values more directly. Signed-off-by: Simon Glass --- test/dm/of_platdata.c | 69

Re: [PATCH 10/20] dm: test: Add a test for of-platdata phandles

2020-10-29 Thread Simon Glass
We have a test in dtoc for this feature, but not one in U-Boot itself. Add a simple test that checks that the information comes through correctly. Signed-off-by: Simon Glass --- arch/sandbox/dts/sandbox.dtsi | 26 configs/sandbox_spl_defconfig | 1 +

Re: [PATCH v2 18/28] binman: Set section contents in GetData()

2020-10-29 Thread Simon Glass
Section contents is not set up when ObtainContents() is called, since packing often changes the layout of the contents. Ensure that the contents are correctly recorded by making this function regenerate the section. It is normally only called by the parent section (when packing) or by the

Re: [PATCH 11/20] dm: Use an allocated array for run-time device info

2020-10-29 Thread Simon Glass
At present we update the driver_info struct with a pointer to the device that it created (i.e. caused to be bound). This works fine when U-Boot SPL is stored in read-write memory. But on some platforms, such as Intel Apollo Lake, it is not possible to update the data memory. In any case, it is

Re: [PATCH v2 27/28] binman: Support compression of sections

2020-10-29 Thread Simon Glass
With the previous changes, it is now possible to compress entire sections. Add some tests to check that compression works correctly, including updating the metadata. Also update the documentation. Signed-off-by: Simon Glass --- Changes in v2: - Renumber the test .dts files to make space for

Re: [PATCH 13/20] dm: Support parent devices with of-platdata

2020-10-29 Thread Simon Glass
At present of-platdata does not provide parent information. But this is useful for I2C devices, for example, since it allows them to determine which bus they are on. Add support for setting the parent correctly, by storing the parent driver_info index in dtoc and reading this in

Re: [PATCH 14/20] dm: Add a test for of-platdata parent information

2020-10-29 Thread Simon Glass
Add a simple test that we can obtain the correct parent for an I2C device. This requires updating the driver names to match the compatible strings, adding them to the devicetree and enabling a few options. Signed-off-by: Simon Glass --- arch/sandbox/dts/sandbox.dts | 1 +

Re: [PATCH 12/20] sandbox: Fix up building for of-platdata

2020-10-29 Thread Simon Glass
There is no devicetree with of-platdata. Update a few uclasses to allow them to be built for sandbox_spl. Also drop the i2c-gpio from SPL to avoid build errors, since it does not support of-platdata. Signed-off-by: Simon Glass --- drivers/i2c/Makefile | 2 +-

Re: [PATCH 18/20] dm: Use driver_info index instead of pointer

2020-10-29 Thread Simon Glass
At present we use a 'node' pointer in the of-platadata phandle_n_arg structs. This is a pointer to the struct driver_info for a particular device, and we can use it to obtain the struct udevice pointer itself. Since we don't know the struct udevice pointer until it is allocated in memory, we have

Re: [PATCH 16/20] x86: apl: Enable SPI flash in TPL with APL_SPI_FLASH_BOOT

2020-10-29 Thread Simon Glass
At present, enabling CONFIG_APL_SPI_FLASH_BOOT does not build since SPI and SPI flash are not enabled for TPL. Add a condition to fix this and tidy up a build warning in the SPI-flash driver. Signed-off-by: Simon Glass --- arch/x86/cpu/apollolake/Kconfig | 2 ++ drivers/spi/ich.c

Re: [PATCH 17/20] x86: apl: Take advantage of the of-platdata parent support

2020-10-29 Thread Simon Glass
Now that parent devices are supported with of-platadata, we don't need the messy code to fix up the parent pointers and allocations on Apollo Lake. Put the code behind a condition. Signed-off-by: Simon Glass --- arch/x86/cpu/apollolake/spl.c | 3 ++- drivers/misc/p2sb-uclass.c| 27

Re: [PATCH v2 04/11] dm: test: Add a very simple of-platadata test

2020-10-29 Thread Simon Glass
At present we have a pytest that covers of-platadata. Add a very simple unit test that just checks that a device can be found. This shows the ability to write these tests in C. Signed-off-by: Simon Glass --- (no changes since v1) test/dm/Makefile | 4 +++- test/dm/of_platdata.c | 19

Re: [PATCH v2 13/28] binman: Move section-building code into a function

2020-10-29 Thread Simon Glass
Create a new _BuildSectionData() to hold the code that is now in GetData(), so that it is clearly separated from entry.GetData() base function. Separate out the 'pad-before' processing to make this easier to understand. Unfortunately this breaks the testDual test. Rather than squash several

Re: [PATCH 19/20] dm: Don't allow U_BOOT_DEVICE() when of-platdata is used

2020-10-29 Thread Simon Glass
With of-platdata, the devicetree is supposed to specify all the devices in the system. So far this hasn't really mattered since of-platdata still works correctly. However, new of-platdata features rely on numbering the devices in a particular order so that they can be referenced by a single

Re: [PATCH v2 06/11] pytest: Collect SPL unit tests

2020-10-29 Thread Simon Glass
Add a new test_spl fixture to handle running SPL unit tests. Signed-off-by: Simon Glass --- Changes in v2: - Drop debug print() - Restart U-Boot after each SPL test test/py/conftest.py | 13 - test/py/tests/test_spl.py | 34 ++ 2 files

Re: [PATCH v2 08/11] sandbox: Allow selection of SPL unit tests

2020-10-29 Thread Simon Glass
Now that we have more than one test, add a way to select the test to run. Signed-off-by: Simon Glass --- (no changes since v1) arch/sandbox/cpu/spl.c | 2 +- arch/sandbox/cpu/start.c | 9 + arch/sandbox/include/asm/state.h | 1 + 3 files changed, 11 insertions(+), 1

Re: [PATCH 20/20] dm: doc: Update the of-platadata documentation

2020-10-29 Thread Simon Glass
Update this to incorporate the parent feature as well as other recent developments. Signed-off-by: Simon Glass --- doc/driver-model/of-plat.rst | 42 1 file changed, 19 insertions(+), 23 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH v2 07/11] test: Run SPL unit tests

2020-10-29 Thread Simon Glass
Update the 'run' script to include SPL unit tests. Signed-off-by: Simon Glass --- (no changes since v1) test/run | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Applied to u-boot-dm, thanks!

Re: [PATCH v2 05/11] Makefile: Generate a symbol file for u-boot-spl

2020-10-29 Thread Simon Glass
Add a rule to generate u-boot-spl.sym so that pytest can discover the available unit tests. Signed-off-by: Simon Glass --- (no changes since v1) scripts/Makefile.spl | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) Applied to u-boot-dm, thanks!

Re: [PATCH v2 03/11] dm: test: Add a way to run SPL tests

2020-10-29 Thread Simon Glass
Add a -u flag for U-Boot SPL which requests that unit tests be run. To make this work, export dm_test_main() and update it to skip test features that are not used with of-platdata. To run the tests: $ spl/u-boot-spl -u U-Boot SPL 2020.10-rc5 (Oct 01 2020 - 07:35:39 -0600) Running 0

Re: [PATCH v2 02/11] dm: test: Update the test runner to support of-platdata

2020-10-29 Thread Simon Glass
At present DM tests assume that a devicetree is available. This is not the case with of-platadata. Update the code to add this condition. Signed-off-by: Simon Glass --- (no changes since v1) test/dm/test-main.c | 27 --- 1 file changed, 16 insertions(+), 11

Re: [PATCH v2 02/28] binman: Drop unused return variable for _DoTestFile()

2020-10-29 Thread Simon Glass
This function returns the exit code from binman, not any data. Fix up a few callers in the tests. Signed-off-by: Simon Glass --- Changes in v2: - Add new patch to drop unused return variable for _DoTestFile() tools/binman/ftest.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH v2 10/11] dm: test: Drop of-platdata pytest

2020-10-29 Thread Simon Glass
Now that we have a C version of this test, drop the Python implementation. Signed-off-by: Simon Glass --- (no changes since v1) arch/sandbox/cpu/spl.c | 12 arch/sandbox/cpu/start.c | 9 -- arch/sandbox/include/asm/state.h | 1 - drivers/misc/spltest_sandbox.c

Re: [PATCH v2 04/28] binman: Give a sensible error if no command is given

2020-10-29 Thread Simon Glass
At present if 'binman' is typed on the command line, a strange error about a missing argument is displayed. Fix this. These does not seem to be standard way to add the 'required' argument in all recent Python versions, so set it manually. Signed-off-by: Simon Glass --- (no changes since v1)

Re: [PATCH v2 01/28] binman: Update the entry docs

2020-10-29 Thread Simon Glass
This has got out of sync with the entries. Regenerate it. Signed-off-by: Simon Glass --- Changes in v2: - Add a patch to update the entry docs tools/binman/README.entries | 23 +++ 1 file changed, 23 insertions(+) Applied to u-boot-dm, thanks!

Re: [PATCH v2 06/28] binman: Remove references to 'image' in entry_Section

2020-10-29 Thread Simon Glass
While a section is the base class of Image, it is more correct to refer to sections in most places in this file. Fix these comments. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/etype/section.py | 8 1 file changed, 4 insertions(+), 4 deletions(-) Applied to

Re: [PATCH v2 11/28] binman: Expand docs and test for padding

2020-10-29 Thread Simon Glass
Padding becomes part of the entry once the image is written out, but within binman the entry contents does not include the padding. Add documentation to make this clear, as well as a test. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/README | 12 +---

Re: [PATCH v2 08/28] binman: Move CompressData() into Entry base class

2020-10-29 Thread Simon Glass
At present this is only used by blobs. To allow it to be used by other entry types (such as sections), move it into the base class. Also read the compression type in the base class. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/entry.py | 17 +

Re: [PATCH v2 10/28] binman: Update testPackExtra with more checks

2020-10-29 Thread Simon Glass
Check the contents of each section to make sure it is actually in the right place. Also fix a whitespace error in the .dts file. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/ftest.py| 27 ++- tools/binman/test/009_pack_extra.dts |

Re: [PATCH v2 12/28] binman: Expand docs and test for alignment

2020-10-29 Thread Simon Glass
Alignment does form part of the entry once the image is written out, but within binman the entry contents does not include the padding. Add documentation to make this clear, as well as a test. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/README | 29

Re: [PATCH v2 05/28] binman: Fix return from u-boot-ucode if there is no DT

2020-10-29 Thread Simon Glass
This should return empty contents, not leave it unset. Fix it. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/etype/u_boot_ucode.py | 1 + 1 file changed, 1 insertion(+) Applied to u-boot-dm, thanks!

Re: [PATCH v2 19/28] binman: Avoid reporting image-pos with compression

2020-10-29 Thread Simon Glass
When a section is compressed, all entries within it are grouped together into a compressed block of data. This obscures the start of each individual child entry. Avoid reporting bogus 'image-pos' properties in this case, since it is not possible to access the entry at the location provided. The

Re: [PATCH v2 17/28] binman: Store the original data before compression

2020-10-29 Thread Simon Glass
When compressing an entry, the original uncompressed data is overwritten. Store it so it is available if needed. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/entry.py | 7 ++- tools/binman/ftest.py | 12 2 files changed, 18 insertions(+), 1 deletion(-)

Re: [PATCH v2 09/28] binman: Use 'files-compress' to set compression for files

2020-10-29 Thread Simon Glass
At present we use 'compress' as the property to set the compression of a 'files' entry. But this conflicts with the same property for entries, of which Entry_section is a subclass. Strictly speaking, since Entry_files is in fact a subclass of Entry_section, the files can be compressed

Re: [PATCH v2 14/28] binman: Refactor _BuildSectionData()

2020-10-29 Thread Simon Glass
At present this function does the padding needed around an entry. It is easier to understand what is going on if we have a function that returns the contents of an entry, with padding included. Refactor the code accordingly, adding a new GetPaddedData() method. Signed-off-by: Simon Glass ---

Re: [PATCH v2 20/28] binman: Drop Entry.CheckOffset()

2020-10-29 Thread Simon Glass
This function just calls CheckEntries() in the only non-trivial implementation. Drop it and use CheckEntries() directly. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/entry.py | 2 +- tools/binman/etype/section.py | 5 + 2 files changed, 2 insertions(+), 5

Re: [PATCH v2 21/28] binman: Move sort and expand to the main Pack() function

2020-10-29 Thread Simon Glass
At present sorting and expanding entries are side-effects of the CheckEntries() function. This is a bit confusing, as 'checking' would not normally involve making changes. Move these steps into the Pack() function instead. Signed-off-by: Simon Glass --- (no changes since v1)

Re: [PATCH v2 24/28] binman: Drop CheckEntries()

2020-10-29 Thread Simon Glass
This method introduces a separation between packing and checking that is different for sections. In order to handle compression properly, we need to be able to deal with a section's size being smaller than the uncompressed size of its contents. It is easier to make this work if everything happens

Re: [PATCH v2 23/28] binman: Call CheckSize() from the section's Pack() method

2020-10-29 Thread Simon Glass
At present CheckSize() is called from the function that packs the entries. Move it up to the main Pack() function so that _PackEntries() can just do the packing. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/etype/section.py | 5 - 1 file changed, 4 insertions(+), 1

Re: [PATCH v2 22/28] binman: Drop the Entry.CheckSize() method

2020-10-29 Thread Simon Glass
This is only used by entry_Section and that class already calls it. Avoid calling it twice. Also drop it from the documentation. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/README | 21 ++--- tools/binman/control.py | 1 - 2 files changed, 10

Re: [PATCH v2 25/28] binman: Update CheckEntries() for compressed sections

2020-10-29 Thread Simon Glass
At present this function assumes that the size of a section is at least as large as its contents. With compression this is often not the case. Relax this constraint by using the uncompressed size, if available. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/etype/section.py

Re: [PATCH v2] imx: mx6cuboxi: Disable thermal driver in SPL

2020-10-29 Thread Simon Glass
On Thu, Oct 29, 2020 at 2:08 PM Simon Glass wrote: > > This feature is incompatble with of-platdata since it uses the > U_BOOT_DEVICE() macro. With of-platdata the only devices permitted are > those created by dtoc. > > The driver is not used in SPL anyway, so exclude it from that build. > >

Re: [PATCH v2 26/28] binman: Use the actual contents in CheckSize()

2020-10-29 Thread Simon Glass
At present this function adds up the total size of entries to work out the size of a section's contents. With compression this is no-longer enough. We may as well bite the bullet and build the section contents instead. Call _BuildSectionData() to get the (possibly compressed) contents and

Re: [PATCH v2 28/28] binman: Avoid calculated section data repeatedly

2020-10-29 Thread Simon Glass
Refactor the implementation slightly so that section data is not rebuilt when it is already available. We still have GetData() set up to rebuild the section, since we don't currently track when things change that might affect a section. For example, if a blob is updated within a section, we must

Re: [PATCH 08/18] serial: add uart driver for MediaTek MT7620 SoC

2020-10-29 Thread Weijie Gao
On Thu, 2020-10-29 at 08:30 -0600, Simon Glass wrote: > Hi Weijie, > > On Thu, 29 Oct 2020 at 03:47, Weijie Gao wrote: > > > > On Mon, 2020-10-26 at 22:51 -0600, Simon Glass wrote: > > > Hi Weijie, > > > > > > On Fri, 16 Oct 2020 at 01:36, Weijie Gao wrote: > > > > > > > > This patch adds uart

[PATCH 2/2] rtc: initialize emulated RTC from environment variable

2020-10-29 Thread Heinrich Schuchardt
Up to now the emulated RTC is initialized using the U-Boot build time. With this patch the environment variable 'rtc_emul_epoch' can be used to provide a better initial time. The variable is a decimal string with the number of seconds since 1970-01-01. Here is an example where the RTC had not

[PATCH 0/2] rtc: initialize emulated RTC from environment variable

2020-10-29 Thread Heinrich Schuchardt
Up to now the emulated RTC is initialized using the U-Boot build time. With this patch the environment variable 'rtc_emul_epoch' can be used to provide a better initial time. The variable is a decimal string with the number of seconds since 1970-01-01. Heinrich Schuchardt (2): rtc: use probe()

[PATCH 1/2] rtc: use probe() to initialize emulated RTC

2020-10-29 Thread Heinrich Schuchardt
Currently the emulated RTC is initialized in the emul_rtc_get() get function. This does not match the design of the driver model. Move the initialization of the emulated RTC to the probe() function. Signed-off-by: Heinrich Schuchardt --- drivers/rtc/emul_rtc.c | 18 -- 1 file

RE: [PATCH] mmc: Parse new binding for eMMC fixed driver type

2020-10-29 Thread Peng Fan
> Subject: RE: [PATCH] mmc: Parse new binding for eMMC fixed driver type > > > > > From: Peng Fan > > Sent: Tuesday, July 14, 2020 4:52 PM > > To: Tokumoto, Shunsuke/�员� 俊介 > > Cc: u-boot@lists.denx.de; Iida, Yasushi/��田 康志 > > > > Subject: RE: [PATCH] mmc: Parse new binding for eMMC fixed

RE: [PATCH] mmc: Parse new binding for eMMC fixed driver type

2020-10-29 Thread s-tokum...@fujitsu.com
> From: Peng Fan > Sent: Tuesday, July 14, 2020 4:52 PM > To: Tokumoto, Shunsuke/徳本 俊介 > Cc: u-boot@lists.denx.de; Iida, Yasushi/飯田 康志 > > Subject: RE: [PATCH] mmc: Parse new binding for eMMC fixed driver type > > > Subject: [PATCH] mmc: Parse new binding for eMMC fixed driver type > > > >

[v2] board: freescale: sys_eeprom: update address length argument

2020-10-29 Thread Biwen Li
From: Biwen Li Update address length argument Signed-off-by: Biwen Li --- Change in v2: - update subject description board/freescale/common/sys_eeprom.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/board/freescale/common/sys_eeprom.c

Re: [PATCH v2 0/2] rtc: provide an emulated RTC

2020-10-29 Thread Pablo Sebastián Greco
On 29/10/20 08:36, Heinrich Schuchardt wrote: On 10/29/20 11:27 AM, Pablo Sebastián Greco wrote: Can I suggest as a future enhancement adding an option to also be able to read U_BOOT_EPOCH from env? Userspace tools could write the time on shutdown (like fakehwclock). Thank you for your

[PATCH] configs: migrate CONFIG_IMX_THERMAL to defconfigs

2020-10-29 Thread Tom Rini
Done via moveconfig.py Signed-off-by: Tom Rini --- configs/cgtqmx6eval_defconfig | 1 + configs/colibri-imx6ull_defconfig | 1 + configs/colibri_imx7_defconfig| 1 + configs/colibri_imx7_emmc_defconfig | 1 + configs/gwventana_emmc_defconfig |

Re: Using USB Mass Storage on AM335X

2020-10-29 Thread Otavio Salvador
Em qui., 29 de out. de 2020 às 19:46, Tom Rini escreveu: > On Thu, Oct 29, 2020 at 07:19:47PM -0300, Otavio Salvador wrote: > > Does anyone know why selecting CONFIG_CMD_USB_MASS_STORAGE=y causes > > the board to not boot anymore? > > Have you otherwise confirmed that you have gadget support

Re: Using USB Mass Storage on AM335X

2020-10-29 Thread Tom Rini
On Thu, Oct 29, 2020 at 07:19:47PM -0300, Otavio Salvador wrote: > Hi, > > I am working on porting mainline U-Boot to a custom AM335X board that > only has eMMC as the boot medium. > > I can load U-Boot via serial boot and flash MLO and u-boot.img into > the eMMC using DFU. Then the board boots

Using USB Mass Storage on AM335X

2020-10-29 Thread Otavio Salvador
Hi, I am working on porting mainline U-Boot to a custom AM335X board that only has eMMC as the boot medium. I can load U-Boot via serial boot and flash MLO and u-boot.img into the eMMC using DFU. Then the board boots successfully via eMMC. Now I want to run the "ums" command to be able to mount

[PATCH] arm: mvebu: puzzle-m801: Add a maintainer

2020-10-29 Thread Luka Kovacic
Add Luka Perkov to Puzzle-M801 BOARD MAINTAINERS. Signed-off-by: Luka Kovacic Cc: Luka Perkov --- board/Marvell/mvebu_armada-8k/MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/board/Marvell/mvebu_armada-8k/MAINTAINERS b/board/Marvell/mvebu_armada-8k/MAINTAINERS index

[PATCH] spl: spl_fit.c: enable check of signature for config node in spl/tpl

2020-10-29 Thread Philippe Reynes
This commit add the support of signature check for config node in spl/tpl when the function spl_load_simple_fit is used. Signed-off-by: Philippe Reynes --- common/spl/spl_fit.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/common/spl/spl_fit.c b/common/spl/spl_fit.c index

[PATCH] drivers: led: bcm6858: set the correct led polarity register

2020-10-29 Thread Steven Lawrance
This change sets the output (hardware) polarity register instead of the input (software) polarity register for the bcm6858 LED controller. The logic was inverted (a LED configued active high behaved as active low). Signed-off-by: Steven Lawrance --- drivers/led/led_bcm6858.c | 8 1

Re: [Uboot-stm32] [PATCH 0/7] arm: cache: cp15: don't map reserved region with no-map property

2020-10-29 Thread Jerome Forissier
On 10/29/20 5:06 PM, Etienne Carriere wrote: > On Thu, 29 Oct 2020 at 12:26, Ard Biesheuvel wrote: >> The point I made before was that secure and non-secure are two >> disjoint address spaces. The fact that TZ firewalls exist where you >> can move things from one side to the other does not

  1   2   >