[PATCH 0/4] common: Drop remaining includes in common.h (part A)

2020-10-30 Thread Simon Glass
This series continues the removal of include files in the common.h header. Simon Glass (4): common: Drop asm/global_data.h from common header common: Drop display_options.h from common header common: Drop linux/printk.h from common header Fix code style for time functions

[PATCH 2/4] common: Drop display_options.h from common header

2020-10-30 Thread Simon Glass
Move this out of the common header and include it only where needed. Signed-off-by: Simon Glass --- arch/arm/cpu/armv7/s5p-common/cpu_info.c | 1 + arch/arm/mach-at91/arm926ejs/eflash.c | 1 + arch/arm/mach-imx/hab.c | 1 + arch/powerpc/cpu/mpc85xx/cpu.c

[PATCH 4/4] Fix code style for time functions

2020-10-30 Thread Simon Glass
Fix the code style used for some time functions. Signed-off-by: Simon Glass --- arch/arm/cpu/arm920t/imx/timer.c | 2 +- arch/arm/cpu/sa1100/timer.c | 2 +- arch/microblaze/cpu/timer.c | 2 +- arch/powerpc/lib/interrupts.c| 2 +- arch/powerpc/lib/time.c | 5 +++--

Re: Please pull u-boot-dm

2020-10-30 Thread Tom Rini
On Fri, Oct 30, 2020 at 01:13:04PM -0600, Simon Glass wrote: > Hi Tom, > > https://gitlab.denx.de/u-boot/custodians/u-boot-dm/-/commits/master > https://travis-ci.com/github/sjg20/u-boot/builds/196409920 > https://dev.azure.com/simon0972/u-boot/_build?definitionId=1 > > > The following changes

Pull request: u-boot-rockchip-20201031

2020-10-30 Thread Kever Yang
Hi Tom, Please pull the rockchip updates/fixes: - New PX30 board: Engicam PX30.Core; - Fix USB HID support for rock960; - Remove host endianness dependency for rockchip mkimage; - dts update for rk3288-tinker; - Enable console MUX for some ROCKPi boards; - Add config-based ddr selection for px30;

[PATCH 3/4] fs: btrfs: initialize @ret to 0 to prevent uninitialized return value

2020-10-30 Thread Qu Wenruo
In show_dir() if we hit a ROOT_ITEM, we can exit with uninitialized @ret. Fix it by initializing it to 0. Reported-by: Coverity CID 312955 Signed-off-by: Qu Wenruo --- fs/btrfs/btrfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/btrfs.c b/fs/btrfs/btrfs.c index

[PATCH 4/4] fs: btrfs: initialize @ii in show_dir() to make coverity happy

2020-10-30 Thread Qu Wenruo
In show_dir() if we hit file type FT_CHRDEV or FT_BLKDEV, we expect an BTRFS_INODE_ITEM_KEY, and for that case, we should have @ii filled with data read from disk. We even have ASSERT() for this purpose, but unfortunately coverity can't understand the ASSERT() nor if we get key type

[PATCH 2/4] fs: btrfs: volumes: prevent overflow for multiplying

2020-10-30 Thread Qu Wenruo
In __btrfs_map_block() we do a int * int and assign it to u64. This is not safe as the result (int * int) is still evaluated as (int) thus it can overflow. Convert one of the multiplier to u64 to prevent such problem. In real world, this should not cause problem as we have device number limit

[PATCH 0/4] fs: btrfs: coverity fixes

2020-10-30 Thread Qu Wenruo
Most of the coverity reports are at least a good hint to us to improve the code style. Although there are some false alerts, but it's really hard to teach coverity to be a real human (yet), thus fix the warning even it's just false alerts. Qu Wenruo (4): fs: btrfs: inode: handle uninitialized

[PATCH 1/4] fs: btrfs: inode: handle uninitialized type before returning it

2020-10-30 Thread Qu Wenruo
In btrfs_lookup_path() the local variable @type should always be updated after we hit any file/dir. But if @filename is NULL from the very beginning, then we don't initialize it and return it directly. To prevent such problem from happening, we initialize @type to BTRFS_FT_UNKNOWN. For normal

Re: [PATCH v4 2/3] env: Access Environment in SPI flashes before relocation

2020-10-30 Thread Michael Walle
Hi, Am 2020-10-31 01:07, schrieb Tom Rini: [..] > +static int env_sf_init(void) > +{ > +#if defined(INITENV) && (CONFIG_ENV_ADDR != 0x0) > + return env_sf_init_addr(); > +#elif defined(CONFIG_ENV_SPI_EARLY) > + return env_sf_init_early(); > +#endif > + /* > + * we must return with 0 if

Re: [PATCH v4 2/3] env: Access Environment in SPI flashes before relocation

2020-10-30 Thread Tom Rini
On Sat, Oct 31, 2020 at 12:51:27AM +0100, Michael Walle wrote: > Hi Heiko, Hi Tom, > > Am 2020-10-10 10:28, schrieb Heiko Schocher: > > Enable the new Kconfig option ENV_SPI_EARLY if you want > > to use Environment in SPI flash before relocation. > > Call env_init() and than you can use

Re: [PATCH v4 2/3] env: Access Environment in SPI flashes before relocation

2020-10-30 Thread Michael Walle
Hi Heiko, Hi Tom, Am 2020-10-10 10:28, schrieb Heiko Schocher: Enable the new Kconfig option ENV_SPI_EARLY if you want to use Environment in SPI flash before relocation. Call env_init() and than you can use env_get_f() for accessing Environment variables. Signed-off-by: Heiko Schocher ---

[scan-ad...@coverity.com: New Defects reported by Coverity Scan for Das U-Boot]

2020-10-30 Thread Tom Rini
Here's the latest report from Coverity scan. I think it's more helpful to send these to the list so that anyone can help advise on solutions than to send it only to people that may have introduced the problem, as I have previously been forwarding to. I don't recall why I got in the habit to

Please pull u-boot-dm

2020-10-30 Thread Simon Glass
Hi Tom, https://gitlab.denx.de/u-boot/custodians/u-boot-dm/-/commits/master https://travis-ci.com/github/sjg20/u-boot/builds/196409920 https://dev.azure.com/simon0972/u-boot/_build?definitionId=1 The following changes since commit cdeb7b8f984e6d9bcdc5a6fdda6107af156d47bf: configs: Resync

Re: [maemo-leste] [PATCH] nokia_rx51: disable obsolete VIDEO config

2020-10-30 Thread Pali Rohár
On Thursday 29 October 2020 14:06:30 Lokesh Vutla wrote: > On 24/10/20 5:49 pm, Tom Rini wrote: > > On Sat, Oct 24, 2020 at 12:46:45PM +0200, Merlijn Wajer wrote: > >> Hi, > >> > >> On 24/10/2020 12:06, Pali Rohár wrote: > >>> On Wednesday 21 October 2020 08:47:02 Tom Rini wrote: > On Wed,

Re: [PATCH] log: typo logl_pref in documentation

2020-10-30 Thread Tom Rini
On Fri, Oct 30, 2020 at 06:50:31PM +0100, Heinrich Schuchardt wrote: > The name of structure element logl_prev is not matched by the > documentation. > > %s/logl_pref/logl_prev/ > > Signed-off-by: Heinrich Schuchardt Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP

Re: [PATCH v4 21/22] doc: Add log kerneldocs to documentation

2020-10-30 Thread Tom Rini
On Tue, Oct 27, 2020 at 07:55:40PM -0400, Sean Anderson wrote: > The functions in log.h are already mostly documented, so add them to the > generated documentation. > > Signed-off-by: Sean Anderson > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc

Re: [PATCH v4 20/22] test: Add a test for log filter-*

2020-10-30 Thread Tom Rini
On Tue, Oct 27, 2020 at 07:55:39PM -0400, Sean Anderson wrote: > This exercises a few success and failure modes of the log filter-* > commands. log filter-list is not tested because it's purely informational. > I don't think there's a good way to test it except by testing if the output > of the

Re: [PATCH v4 17/22] lib: Add getopt

2020-10-30 Thread Tom Rini
On Tue, Oct 27, 2020 at 07:55:36PM -0400, Sean Anderson wrote: > Some commands can get very unweildy if they have too many positional > arguments. Adding options makes them easier to read, remember, and > understand. > > This implementation of getopt has been taken from barebox, which has had >

Re: [PATCH v4 22/22] doc: Update logging documentation

2020-10-30 Thread Tom Rini
On Tue, Oct 27, 2020 at 07:55:41PM -0400, Sean Anderson wrote: > This updates logging documentation with some examples of the new commands > added in the previous commits. It also removes some items from the to-do > list which have been implemented. > > Signed-off-by: Sean Anderson >

Re: [PATCH v4 19/22] cmd: log: Add commands to manipulate filters

2020-10-30 Thread Tom Rini
On Tue, Oct 27, 2020 at 07:55:38PM -0400, Sean Anderson wrote: > This adds several commands to add, list, and remove log filters. Due to the > complexity of adding a filter, `log filter-list` uses options instead of > positional arguments. > > These commands have been added as subcommands to log

Re: [PATCH v4 14/22] cmd: log: Split off log level parsing

2020-10-30 Thread Tom Rini
On Tue, Oct 27, 2020 at 07:55:33PM -0400, Sean Anderson wrote: > Move parsing of log level into its own function so it can be re-used. This > also adds support for using log level names instead of just the integer > equivalent. > > Signed-off-by: Sean Anderson > Reviewed-by: Simon Glass

Re: [PATCH v4 16/22] cmd: log: Make "log level" print all log levels

2020-10-30 Thread Tom Rini
On Tue, Oct 27, 2020 at 07:55:35PM -0400, Sean Anderson wrote: > This makes the log level command print all valid log levels. The default > log level is annotated. This provides an easy way to see which log levels > are compiled-in. > > Signed-off-by: Sean Anderson > Reviewed-by: Simon Glass

Re: [PATCH v4 18/22] test: Add a test for getopt

2020-10-30 Thread Tom Rini
On Tue, Oct 27, 2020 at 07:55:37PM -0400, Sean Anderson wrote: > A few of these tests were inspired by those in glibc. The syntax for > invoking test_getopt is a bit funky, but it's necessary so that the CPP can > parse the arguments correctly. > > Signed-off-by: Sean Anderson Applied to

Re: [PATCH v4 15/22] cmd: log: Add commands to list categories and drivers

2020-10-30 Thread Tom Rini
On Tue, Oct 27, 2020 at 07:55:34PM -0400, Sean Anderson wrote: > This allows users to query which categories and drivers are available on > their system. This allows them to construct filter-add commands without > (e.g.) adjusting the log format to show categories and drivers. > > Signed-off-by:

Re: [PATCH v4 10/22] test: Add tests for LOGFF_DENY

2020-10-30 Thread Tom Rini
On Tue, Oct 27, 2020 at 07:55:29PM -0400, Sean Anderson wrote: > This adds some tests for log filters which deny if they match. > > Signed-off-by: Sean Anderson > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v4 13/22] cmd: log: Use sub-commands for log

2020-10-30 Thread Tom Rini
On Tue, Oct 27, 2020 at 07:55:32PM -0400, Sean Anderson wrote: > This reduces duplicate code, and makes adding new sub-commands easier. > > Signed-off-by: Sean Anderson > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v4 12/22] test: Add test for LOGFF_MIN

2020-10-30 Thread Tom Rini
On Tue, Oct 27, 2020 at 07:55:31PM -0400, Sean Anderson wrote: > This tests log filters matching on a minimum level. > > Signed-off-by: Sean Anderson > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v4 09/22] test: log: Give tests names instead of numbers

2020-10-30 Thread Tom Rini
On Tue, Oct 27, 2020 at 07:55:28PM -0400, Sean Anderson wrote: > Now that the log test command is no more, we can give the log tests proper > names. > > Signed-off-by: Sean Anderson Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v4 11/22] log: Add filter flag to match greater than a log level

2020-10-30 Thread Tom Rini
On Tue, Oct 27, 2020 at 07:55:30PM -0400, Sean Anderson wrote: > This is the complement of the existing behavior to match only messages with > a log level less than a threshold. This is primarily useful in conjunction > with LOGFF_DENY. > > Signed-off-by: Sean Anderson > Reviewed-by: Simon

Re: [PATCH v4 07/22] log: Add filter flag to deny on match

2020-10-30 Thread Tom Rini
On Tue, Oct 27, 2020 at 07:55:26PM -0400, Sean Anderson wrote: > Without this flag, log filters can only explicitly accept messages. > Allowing denial makes it easier to filter certain subsystems. Unlike > allow-ing filters, deny-ing filters are added to the beginning of the > filter list. This

Re: [PATCH v4 08/22] test: log: Convert log_test from python to C

2020-10-30 Thread Tom Rini
On Tue, Oct 27, 2020 at 07:55:27PM -0400, Sean Anderson wrote: > When rebasing this series I had to renumber all my log tests because > someone made another log test in the meantime. This involved updaing a > number in several places (C and python), and it wasn't checked by the > compiler. So I

Re: [PATCH v4 02/22] log: Fix incorrect documentation of log_filter.cat_list

2020-10-30 Thread Tom Rini
On Tue, Oct 27, 2020 at 07:55:21PM -0400, Sean Anderson wrote: > Logging category lists are terminated by LOGC_END, not LOGC_NONE. > > Fixes: e9c8d49d54 ("log: Add an implementation of logging") > > Signed-off-by: Sean Anderson > Reviewed-by: Heinrich Schuchardt Applied to u-boot/master,

Re: [PATCH v4 06/22] log: Add function to create a filter with flags

2020-10-30 Thread Tom Rini
On Tue, Oct 27, 2020 at 07:55:25PM -0400, Sean Anderson wrote: > This function exposes a way to specify flags when creating a filter. > > Signed-off-by: Sean Anderson > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v4 05/22] log: Expose some helper functions

2020-10-30 Thread Tom Rini
On Tue, Oct 27, 2020 at 07:55:24PM -0400, Sean Anderson wrote: > These functions are required by "cmd: log: Add commands to manipulate > filters" and "test: Add a test for log filter-*". > > Signed-off-by: Sean Anderson > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom

Re: [PATCH v4 04/22] log: Use CONFIG_IS_ENABLED() for LOG_TEST

2020-10-30 Thread Tom Rini
On Tue, Oct 27, 2020 at 07:55:23PM -0400, Sean Anderson wrote: > Checkpatch complains about using #ifdef for CONFIG variables. > > Signed-off-by: Sean Anderson > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v4 01/22] log: Fix missing negation of ENOMEM

2020-10-30 Thread Tom Rini
On Tue, Oct 27, 2020 at 07:55:20PM -0400, Sean Anderson wrote: > Errors returned should be negative. > > Fixes: 45fac9fc18 ("log: Correct missing free() on error in log_add_filter()") > > Signed-off-by: Sean Anderson > Reviewed-by: Heinrich Schuchardt Applied to u-boot/master, thanks! --

Re: [PATCH v4 03/22] log: Add additional const qualifier to arrays

2020-10-30 Thread Tom Rini
On Tue, Oct 27, 2020 at 07:55:22PM -0400, Sean Anderson wrote: > Both these arrays and their members are const. Fixes checkpatch complaint. > > Signed-off-by: Sean Anderson > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v4 3/3] imx6: enable early spi environment access on aristainetos boards

2020-10-30 Thread Tom Rini
On Sat, Oct 10, 2020 at 10:28:06AM +0200, Heiko Schocher wrote: > On aristianetos boards the display type is detected > through "panel" environment variable. Dependend on the > display type we detect the board type and this decides which > DTB we have to use for the board. > > So we need early

Re: [PATCH v4 2/3] env: Access Environment in SPI flashes before relocation

2020-10-30 Thread Tom Rini
On Sat, Oct 10, 2020 at 10:28:05AM +0200, Heiko Schocher wrote: > Enable the new Kconfig option ENV_SPI_EARLY if you want > to use Environment in SPI flash before relocation. > Call env_init() and than you can use env_get_f() for > accessing Environment variables. > > Signed-off-by: Heiko

Re: [GIT PULL] xilinx patches for v2021.01-v2

2020-10-30 Thread Tom Rini
On Thu, Oct 29, 2020 at 03:23:03PM +0100, Michal Simek wrote: > Hi Tom, > > please pull these patches to your tree. > Gitlab CI looks good > https://gitlab.denx.de/u-boot/custodians/u-boot-microblaze/-/pipelines/5170 > Travis is still running and it is quite slow but I have been running > full

Re: Please pull u-boot-marvell/master

2020-10-30 Thread Tom Rini
On Thu, Oct 29, 2020 at 03:31:27PM +0100, Stefan Roese wrote: > Hi Tom, > > please pull an update of Marvell Armada & Octeon TX/TX2 related > patches. Here the summary log: > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v4 1/3] env: split env_import_redund() into 2 functions

2020-10-30 Thread Tom Rini
On Sat, Oct 10, 2020 at 10:28:04AM +0200, Heiko Schocher wrote: > split from env_import_redund() the part which checks > which Environment is valid into a separate function > called env_check_redund() and call it from env_import_redund(). > > So env_check_redund() can be used from places which

[PATCH] configs: meson64_android: don't show logo on ROM USB boot

2020-10-30 Thread Mattijs Korpershoek
From: Guillaume La Roque When booting from rom usb, skip the boot logo logic as it's possible that the partition containing the logo does not exist yet. Signed-off-by: Neil Armstrong Signed-off-by: Guillaume La Roque Signed-off-by: Mattijs Korpershoek --- include/configs/meson64_android.h |

Re: [patch v2 01/10] drivers/video/rockchip/rk_vop.c: Use endpoint compatible string to find VOP mode

2020-10-30 Thread Rtp
Kever Yang writes: > Hi Arnaud, > >     Thanks for your patch. > >     Please use module name as subject prefix instead of a file name, > eg. "rockchip: video: vop". > ok. will fix. > On 2020/10/27 下午9:21, Arnaud Patard (Rtp) wrote: >> The current code is using an hard coded enum and the of

Re: [PATCH 00/33] stm32: enable logging features

2020-10-30 Thread Simon Glass
Hi Patrick, On Wed, 28 Oct 2020 at 05:52, Patrick DELAUNAY wrote: > > Hi Simon, > > > From: Simon Glass > > Sent: lundi 26 octobre 2020 20:23 > > > > Hi Patrick, > > > > On Thu, 15 Oct 2020 at 09:59, Patrick DELAUNAY > > wrote: > > > > > > Hi Simon, > > > > > > > From: Simon Glass > > > >

Re: [PATCH] Makefile: Correctly propagate failure when removing target

2020-10-30 Thread Simon Glass
Hi Paul, On Tue, 27 Oct 2020 at 20:25, Pali Rohár wrote: > > On Tuesday 27 October 2020 20:10:37 Simon Glass wrote: > > Hi Paul, > > > > On Mon, 26 Oct 2020 at 07:11, Pali Rohár wrote: > > > > > > On more places is used pattern 'command > $@ || rm -f $@'. But it does not > > > propagate failure

Re: [PATCH 16/25] binman: Avoid reporting image-pos with compression

2020-10-30 Thread Simon Glass
Hi Alper, On Mon, 26 Oct 2020 at 17:20, Alper Nebi Yasak wrote: > > On 26/10/2020 22:22, Simon Glass wrote: > > Hi Alper, > > > > On Mon, 19 Oct 2020 at 15:29, Alper Nebi Yasak > > wrote: > >> > >> On 19/10/2020 05:41, Simon Glass wrote: > >>> When a section is compressed, all entries within

Re: [PATCH 08/18] serial: add uart driver for MediaTek MT7620 SoC

2020-10-30 Thread Simon Glass
Hi Weijie, On Thu, 29 Oct 2020 at 21:21, Weijie Gao wrote: > > On Thu, 2020-10-29 at 08:30 -0600, Simon Glass wrote: > > Hi Weijie, > > > > On Thu, 29 Oct 2020 at 03:47, Weijie Gao wrote: > > > > > > On Mon, 2020-10-26 at 22:51 -0600, Simon Glass wrote: > > > > Hi Weijie, > > > > > > > > On

[PATCH] log: typo logl_pref in documentation

2020-10-30 Thread Heinrich Schuchardt
The name of structure element logl_prev is not matched by the documentation. %s/logl_pref/logl_prev/ Signed-off-by: Heinrich Schuchardt --- include/asm-generic/global_data.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/asm-generic/global_data.h

Re: [PATCH] fs/squashfs: Fix index off by 1 for inode SQFS_LDIR_TYPE

2020-10-30 Thread João Marcos Costa
Tested-by Joao Marcos Costa Em sex., 30 de out. de 2020 às 10:42, Gerard Koskamp < gerard.kosk...@nedap.com> escreveu: > I've created a squashfs file system with Yocto (it use squashfs-tools) > and u-boot command sqfsls give the error:'Error while searching inode: > unknown type.' > After some

[PATCH] test: unit test for efi_create_indexed_name()

2020-10-30 Thread Heinrich Schuchardt
Provide a unit test for function efi_create_indexed_name(). Signed-off-by: Heinrich Schuchardt --- test/unicode_ut.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/test/unicode_ut.c b/test/unicode_ut.c index 26d96336f3..33fc8b0ee1 100644 --- a/test/unicode_ut.c +++

[PATCH] test: unit test for efi_create_indexed_name()

2020-10-30 Thread Heinrich Schuchardt
Provide a unit test for function efi_create_indexed_name(). Signed-off-by: Heinrich Schuchardt --- test/unicode_ut.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/test/unicode_ut.c b/test/unicode_ut.c index 26d96336f3..33fc8b0ee1 100644 --- a/test/unicode_ut.c +++

[PATCH] cros_ec: Support keyboard scanning with EC_CMD_GET_NEXT_EVENT

2020-10-30 Thread Alper Nebi Yasak
The cros_ec_keyb driver currently uses EC_CMD_MKBP_STATE to scan the keyboard, but this host command was superseded by EC_CMD_GET_NEXT_EVENT and unavailable on more recent devices (including gru-kevin), as it was removed in cros-ec commit 87a071941b89 ("mkbp: Add support for buttons and

Re: [PATCH 1/1] env: typo enougth

2020-10-30 Thread Joe Hershberger
On Fri, Oct 30, 2020 at 12:11 AM Heinrich Schuchardt wrote: > > %s/enougth/enough/ > > Signed-off-by: Heinrich Schuchardt Acked-by: Joe Hershberger

Re: [PATCH v4 8/8] doc: rockchip: Document Rockchip miniloader flashing

2020-10-30 Thread Kever Yang
On 2020/10/28 下午9:33, Jagan Teki wrote: This would be useful and recommended boot flow for new boards which has doesn't have the DDR support yet in mainline. Sometimes it is very useful for debugging mainline DDR support. Documen it for px30 boot flow. Signed-off-by: Jagan Teki

Re: [PATCH v4 7/8] rockchip: Add Engicam PX30.Core C.TOUCH 2.0

2020-10-30 Thread Kever Yang
On 2020/10/28 下午9:33, Jagan Teki wrote: PX30.Core is an EDIMM SOM based on Rockchip PX30 from Engicam. C.TOUCH 2.0 is a general purpose carrier board with capacitive touch interface support. PX30.Core needs to mount on top of this Carrier board for creating complete PX30.Core C.TOUCH 2.0

Re: [PATCH v4 6/8] arm64: dts: rockchip: px30: Add Engicam C.TOUCH 2.0

2020-10-30 Thread Kever Yang
On 2020/10/28 下午9:33, Jagan Teki wrote: Engicam C.TOUCH 2.0 is an EDIMM compliant general purpose carrier board with capacitive touch interface. Genaral features: - TFT 10.1" industrial, 1280x800 LVDS display - Ethernet 10/100 - Wifi/BT - USB Type A/OTG - Audio Out - CAN - LVDS panel

Re: [PATCH v4 4/8] board: engicam: Attach i.MX6 common code

2020-10-30 Thread Kever Yang
On 2020/10/28 下午9:33, Jagan Teki wrote: The existing common code for Engicam boards uses i.MX6, so attach that into i.MX6 Engicam boards so-that adding new SoC variants of Engicam boards become meaningful. Add support for it. Cc: Stefano Babic Signed-off-by: Jagan Teki Reviewed-by: Kever

Re: [PATCH v4 5/8] rockchip: Add Engicam PX30.Core EDIMM2.2 Starter Kit

2020-10-30 Thread Kever Yang
On 2020/10/28 下午9:33, Jagan Teki wrote: PX30.Core is an EDIMM SOM based on Rockchip PX30 from Engicam. EDIMM2.2 Starter Kit is an EDIMM 2.2 Form Factor Capacitive Evaluation Board from Engicam. PX30.Core needs to mount on top of this Evaluation board for creating complete PX30.Core EDIMM2.2

Re: [PATCH] configs: meson64_android: don't show logo on ROM USB boot

2020-10-30 Thread Neil Armstrong
On 30/10/2020 16:03, Mattijs Korpershoek wrote: > From: Guillaume La Roque > > When booting from rom usb, skip the boot logo logic as it's possible > that the partition containing the logo does not exist yet. > > Signed-off-by: Neil Armstrong > Signed-off-by: Guillaume La Roque >

Re: [PATCH v1 5/7] apalis-imx8: add implementation for board_mem_get_layout

2020-10-30 Thread Oleksandr Suvorov
On Thu, Oct 22, 2020 at 11:22 AM Igor Opaniuk wrote: > > From: Igor Opaniuk > > Add implementation of board_mem_get_layout for overriding the memory > layout. > > Signed-off-by: Igor Opaniuk Acked-by: Oleksandr Suvorov > --- > > board/toradex/apalis-imx8/apalis-imx8.c | 23

Re: [PATCH v1] verdinx-imx8mm: enable fdt overlays and env importing

2020-10-30 Thread Oleksandr Suvorov
On Fri, Oct 30, 2020 at 5:15 PM Oleksandr Suvorov wrote: > > On Fri, Oct 30, 2020 at 4:53 PM Igor Opaniuk wrote: > > > > From: Igor Opaniuk > > > > Enable CONFIG_CMD_IMPORTENV and CONFIG_OF_LIBFDT_OVERLAY needed > > for booting regular Toradex BSP images. > > > > Signed-off-by: Igor Opaniuk >

Re: [RESEND PATCH v1] verdin-imx8mm: enable fdt overlays and env importing

2020-10-30 Thread Oleksandr Suvorov
On Fri, Oct 30, 2020 at 4:55 PM Igor Opaniuk wrote: > > From: Igor Opaniuk > > Enable CONFIG_CMD_IMPORTENV and CONFIG_OF_LIBFDT_OVERLAY needed > for booting regular Toradex BSP images. > > Signed-off-by: Igor Opaniuk Reviewed-by: Oleksandr Suvorov > --- > > configs/verdin-imx8mm_defconfig |

Re: [patch v2 01/10] drivers/video/rockchip/rk_vop.c: Use endpoint compatible string to find VOP mode

2020-10-30 Thread Kever Yang
Hi Arnaud,     Thanks for your patch.     Please use module name as subject prefix instead of a file name, eg. "rockchip: video: vop". On 2020/10/27 下午9:21, Arnaud Patard (Rtp) wrote: The current code is using an hard coded enum and the of node reg value of endpoint to find out if the

Re: [PATCH v1] verdinx-imx8mm: enable fdt overlays and env importing

2020-10-30 Thread Oleksandr Suvorov
On Fri, Oct 30, 2020 at 4:53 PM Igor Opaniuk wrote: > > From: Igor Opaniuk > > Enable CONFIG_CMD_IMPORTENV and CONFIG_OF_LIBFDT_OVERLAY needed > for booting regular Toradex BSP images. > > Signed-off-by: Igor Opaniuk Reviewed-by: Oleksandr Suvorov > --- > > configs/verdin-imx8mm_defconfig |

Re: [PATCH] km/arm: coding style clean up

2020-10-30 Thread Stefan Roese
On 30.10.20 12:45, Holger Brunck wrote: Address most of the checkpatch issues we found in km_arm and common km code. CC: Stefan Roese CC: Valentin Longchamp Signed-off-by: Holger Brunck Reviewed-by: Stefan Roese Thanks, Stefan --- board/keymile/common/common.c | 44

Re: [PATCH] rockchip: mkimage: Remove host endianness dependency

2020-10-30 Thread Kever Yang
On 2020/10/25 上午12:43, Samuel Holland wrote: The Rockchip boot ROM expects little-endian values in the image header. When running mkimage on a big-endian machine, these values need to be byteswapped before writing or verifying the header. This change fixes cross-compiling U-Boot SPL for the

Re: [PATCH 3/4] video: rockchip: Support 4K resolution for rk3288, HDMI

2020-10-30 Thread Kever Yang
On 2020/10/24 上午3:57, Jagan Teki wrote: Like, rk3399 the rk3288 also supports 4K resolution. So, enable it for rk3288 with HDMI platforms. Right now, rockchip video drivers are supporting for rk3288, rk3399 SoC families, so mark the 4K resolution by default if it's an HDMI video out.

Re: [PATCH 4/4] rockchip: Enable Console MUX in ROCKPi N8

2020-10-30 Thread Kever Yang
On 2020/10/24 上午3:57, Jagan Teki wrote: Enable Console multiplexing in ROCKPi N8 which would is required to video out the console buffer. Enable it. Signed-off-by: Jagan Teki Reviewed-by: Kever Yang Thanks, - Kever --- configs/rock-pi-n8-rk3288_defconfig | 1 - 1 file changed, 1

Re: [PATCH 2/4] arm64: dts: rockchip: Add chosen node for ROCK-Pi N8

2020-10-30 Thread Kever Yang
On 2020/10/24 上午3:57, Jagan Teki wrote: Add chosen node in -u-boot.dtsi for ROCK-Pi N8 board. This will help to get serial out messages. Signed-off-by: Jagan Teki Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/dts/rk3288-rock-pi-n8-u-boot.dtsi | 6 ++ 1 file changed, 6

Re: [PATCH 1/4] rockchip: Enable Console MUX in ROCKPi N10

2020-10-30 Thread Kever Yang
On 2020/10/24 上午3:57, Jagan Teki wrote: Enable Console multiplexing in ROCKPi N10 which would is required to video out the console buffer. Enable it. Signed-off-by: Jagan Teki Reviewed-by: Kever Yang Thanks, - Kever --- configs/rock-pi-n10-rk3399pro_defconfig | 1 - 1 file changed, 1

[RESEND PATCH v1] verdin-imx8mm: enable fdt overlays and env importing

2020-10-30 Thread Igor Opaniuk
From: Igor Opaniuk Enable CONFIG_CMD_IMPORTENV and CONFIG_OF_LIBFDT_OVERLAY needed for booting regular Toradex BSP images. Signed-off-by: Igor Opaniuk --- configs/verdin-imx8mm_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configs/verdin-imx8mm_defconfig

RE: [PATCH] dm: soc: Add SoC id for attribute matching

2020-10-30 Thread Biju Das
Hi Dave, Thanks for the feedback. > Subject: Re: [PATCH] dm: soc: Add SoC id for attribute matching > > Hi, > > On 10/30/20 9:07 AM, Biju Das wrote: > > Add SoC identification string for attribute matching. > > Also changed the comments from "an SOC" to "a SoC". > > This is not a correct

Re: [PATCH 0/3] mmc support for QEMU

2020-10-30 Thread Harm Berntsen
Hi, I didn't include changes in the defconfig because you need to manually add the device to the QEMU virt machine via the command line. On the other hand the u-boot binary size does not really matter for QEMU environments. For CI it will also be nice to ensure this set-up will build. I'll send

[PATCH v1] verdinx-imx8mm: enable fdt overlays and env importing

2020-10-30 Thread Igor Opaniuk
From: Igor Opaniuk Enable CONFIG_CMD_IMPORTENV and CONFIG_OF_LIBFDT_OVERLAY needed for booting regular Toradex BSP images. Signed-off-by: Igor Opaniuk --- configs/verdin-imx8mm_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configs/verdin-imx8mm_defconfig

Re: [PATCH 0/3] mmc support for QEMU

2020-10-30 Thread Bin Meng
On Fri, Oct 30, 2020 at 6:56 PM Harm Berntsen wrote: > > Hi, > > This patch series allows you to use a mmc drive from within QEMU: > > 1. make qemu_arm_defconfig > 2. Enable the CONFIG_DM_MMC, CONFIG_MMC_PCI, CONFIG_MMC_SDHCI options > 3. Run quemu as follows: > >qemu-system-arm >-machine

Re: [PATCH] dm: soc: Add SoC id for attribute matching

2020-10-30 Thread Dave Gerlach
Hi, On 10/30/20 9:07 AM, Biju Das wrote: Add SoC identification string for attribute matching. Also changed the comments from "an SOC" to "a SoC". This is not a correct change, "an" should be used if the word that follows starts with a vowel sound, which "SoC" does. "SOC" could be changed

[PATCH] dm: soc: Add SoC id for attribute matching

2020-10-30 Thread Biju Das
Add SoC identification string for attribute matching. Also changed the comments from "an SOC" to "a SoC". Signed-off-by: Biju Das Reviewed-by: Lad Prabhakar --- drivers/soc/soc-uclass.c | 19 ++- drivers/soc/soc_sandbox.c | 8 include/soc.h | 39

[PATCH] fs/squashfs: Fix index off by 1 for inode SQFS_LDIR_TYPE

2020-10-30 Thread Gerard Koskamp
I've created a squashfs file system with Yocto (it use squashfs-tools) and u-boot command sqfsls give the error:'Error while searching inode: unknown type.' After some digging in the code I found that the index is off by 1. This patch fix this issue and I can successful use the sqfsls command.

[PATCH] dm: core: Add of_match_node helper function

2020-10-30 Thread Biju Das
Add of_match_node() helper function to iterate over the device tree and tell if a device_node has a matching of_match structure. Signed-off-by: Biju Das Reviewed-by: Lad Prabhakar --- drivers/core/device.c | 21 + include/dm/device.h | 13 + 2 files changed,

[u-boot PATCH] configs: am65/j72x: Set CONFIG_LOGLEVEL to 7

2020-10-30 Thread Roger Quadros
By default CONFIG_LOGLEVEL seems to be set to 4 which is too low and doesn't show dev_info/dev_notice/dev_warn messages on console. This has been deliberately set low globally to be conservative setting across the board due to primary bootloader size limitations. It is best to tune per board

[PATCH] km/arm: coding style clean up

2020-10-30 Thread Holger Brunck
Address most of the checkpatch issues we found in km_arm and common km code. CC: Stefan Roese CC: Valentin Longchamp Signed-off-by: Holger Brunck --- board/keymile/common/common.c | 44 --- board/keymile/common/ivm.c | 84 ++---

Re: [PATCH] ram: rockchip: px30: add a config-based ddr selection

2020-10-30 Thread Philipp Tomsich
> On 01.10.2020, at 20:40, Heiko Stuebner wrote: > > From: Heiko Stuebner > > The SRAM on the PX30 is not big enough to hold multiple DDR configs > so it needs to be selected during build. > > So far simply the DDR3 config was always selected and getting DDR4 > or LPDDR2/3 initialized

[PATCH 3/3] mmc: Only retrieve cd pin when GPIO is enabled

2020-10-30 Thread Harm Berntsen
The driver only needs to retrieve the pin for the ACPI info. The driver itself works without depending on GPIO. Signed-off-by: Harm Berntsen CC: Simon Glass ---  drivers/mmc/pci_mmc.c | 2 ++  1 file changed, 2 insertions(+) diff --git a/drivers/mmc/pci_mmc.c b/drivers/mmc/pci_mmc.c index

[PATCH 1/3] gpio: do not include on ARCH_QEMU

2020-10-30 Thread Harm Berntsen
As no gpio.h is defined for this architecture, to avoid compilation failure, do not include for QEMU. Signed-off-by: Harm Berntsen ---  arch/arm/include/asm/gpio.h | 3 ++-  1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/include/asm/gpio.h b/arch/arm/include/asm/gpio.h

[PATCH 2/3] acpi: Only include asm header when available

2020-10-30 Thread Harm Berntsen
The only platforms with an asm/acpi_table.h file are X86 and Sandbox. Some drivers, i.e. pci_mmc.c, can generate ACPI info and therefore include asm/acpi_table.h by proxy. This commit ensures that the platforms wishing to use such driver and do not have ACPI support do not fail on this include.

Re: U-Boot i2c bus num 1 is broken on Nokia N900

2020-10-30 Thread Ivaylo Dimitrov
Hi, On 29.10.20 г. 11:32 ч., Heiko Schocher wrote: Hello Ivaylo, Am 29.10.2020 um 08:51 schrieb Ivaylo Dimitrov: Hi, On 28.10.20 г. 7:42 ч., Heiko Schocher wrote: Hello Pali, sorry for late response ... Am 26.10.2020 um 22:48 schrieb Pali Rohár: On Monday 27 April 2020 09:03:13 Heiko

[PATCH 0/3] mmc support for QEMU

2020-10-30 Thread Harm Berntsen
Hi, This patch series allows you to use a mmc drive from within QEMU: 1. make qemu_arm_defconfig 2. Enable the CONFIG_DM_MMC, CONFIG_MMC_PCI, CONFIG_MMC_SDHCI options 3. Run quemu as follows:    qemu-system-arm    -machine virt,highmem=off \    -device sdhci-pci \    -device

Re: [PATCH] video: rockchip: Add missing dpcd_write() call to link_train_ce()

2020-10-30 Thread Kever Yang
Hi, On 2020/10/16 上午2:29, Tom Rini wrote: On Wed, Oct 14, 2020 at 11:39:40PM +0300, Alper Nebi Yasak wrote: On 14/10/2020 22:31, Tom Rini wrote: On Wed, Oct 14, 2020 at 09:58:28PM +0300, Alper Nebi Yasak wrote: On 14/10/2020 18:24, Tom Rini wrote: Ugh. In so far as anything can be

Re: [PATCH 1/3] rockchip: efuse: add support for RK3288 non-secure efuse

2020-10-30 Thread Kever Yang
Hi Jonas,     Could you help to format the coding style as required so that we can merge this patch to the mainline? Thanks, - Kever On 2020/10/14 上午4:21, Jonas Karlman wrote: From: Francis Fan Extend rockchip efuse driver with support for RK3288 non-secure efuse. Signed-off-by: Francis

RE: [PATCH v4 2/3] armv8: lx2162a: Add Soc changes to support LX2162A

2020-10-30 Thread Meenakshi Aggarwal
> -Original Message- > From: Tom Rini > Sent: Thursday, October 29, 2020 8:14 PM > To: Meenakshi Aggarwal > Cc: u-boot@lists.denx.de; Priyanka Jain ; Varun Sethi > > Subject: Re: [PATCH v4 2/3] armv8: lx2162a: Add Soc changes to support > LX2162A > > On Thu, Oct 29, 2020 at

Re: [PATCH] video: rockchip: Add missing dpcd_write() call to link_train_ce()

2020-10-30 Thread Kever Yang
On 2020/10/7 上午4:39, Alper Nebi Yasak wrote: Found this by comparing it to the coreboot driver, a form of this call was introduced there in their commit b9a7877568cf ("rockchip/*: refactor edp driver"). This is copy-pasted from U-Boot's link_train_cr() slightly above it. Without this on a

Re: [PATCH] ram: rockchip: px30: add a config-based ddr selection

2020-10-30 Thread Kever Yang
On 2020/10/2 上午2:40, Heiko Stuebner wrote: From: Heiko Stuebner The SRAM on the PX30 is not big enough to hold multiple DDR configs so it needs to be selected during build. So far simply the DDR3 config was always selected and getting DDR4 or LPDDR2/3 initialized would require a code

Re: [PATCH] rockchip: Rock960: fix up USB support

2020-10-30 Thread Kever Yang
Hi Peter,     Could you add you signature for this patch? Thanks, - Kever On 2020/9/29 下午9:06, Peter Robinson wrote: Fix up USB config options so keyboards and other USB devices work. --- configs/rock960-rk3399_defconfig | 9 ++--- include/configs/rock960_rk3399.h | 2 ++ 2 files

[PATCH v2 20/21] reset: reset-mtmips: add DM_FLAG_PRE_RELOC flag

2020-10-30 Thread Weijie Gao
Add DM_FLAG_PRE_RELOC flag for reset-mtmips to make sure this driver can be probed before relocation even if u-boot,dm-pre-reloc is not present in the dts. Signed-off-by: Weijie Gao --- v2 changes: new --- drivers/reset/reset-mtmips.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v2 19/21] mmc: mtk-sd: add pad control settings for MediaTek MT7620/MT76x8 SoCs

2020-10-30 Thread Weijie Gao
The driver is missing pad control settings (pad delay and pad conf) for the mt7620 and mt76x8. Although mt76x8 still works well, mt7620 will encounter CRC error on data transfers. This patch adds default pad control settings for mt7620_compat. Also a missing field .sclk_cycle_shift = 20 for

[PATCH v2 16/21] spi: add spi controller support for MediaTek MT7620 SoC

2020-10-30 Thread Weijie Gao
This patch adds spi controller support for MediaTek MT7620 SoC. The SPI controller supports two chip selects. These two chip selects are implemented as two separate register groups, but they share the same bus (DI/DO/CLK), only CS pins are dedicated for each register group. Appearently these two

[PATCH v2 18/21] net: add ethernet driver for MediaTek MT7620 SoC

2020-10-30 Thread Weijie Gao
This patch adds ethernet driver for MediaTek MT7620 SoC. The MT7620 SoC has a built-in ethernet (Frame Engine) and a built-in 7-port switch and two xMII interfaces (can be MII/RMII/RGMII). The port 0-3 of the switch connects to intergrited FE PHYs. Port 4 can be configured to connect to either

  1   2   >