Re: [PATCH 4/4] fs: btrfs: initialize @ii in show_dir() to make coverity happy

2020-11-01 Thread Qu Wenruo
On 2020/11/2 下午3:24, Marek Behun wrote: > On Mon, 2 Nov 2020 08:27:16 +0800 > Qu Wenruo wrote: > >> Thus I really tend to believe it's just a bug in coverity. >> All locations accessing @ii all have its key.type checked to ensure it get >> filled in the first place. > > If this is a bug in

Re: [PATCH 4/4] fs: btrfs: initialize @ii in show_dir() to make coverity happy

2020-11-01 Thread Marek Behun
On Mon, 2 Nov 2020 08:27:16 +0800 Qu Wenruo wrote: > Thus I really tend to believe it's just a bug in coverity. > All locations accessing @ii all have its key.type checked to ensure it get > filled in the first place. If this is a bug in coverity, we should fix coverity, not add extra code to

Re: U-Boot i2c bus num 1 is broken on Nokia N900

2020-11-01 Thread Heiko Schocher
Hello Ivaylo, Am 31.10.2020 um 12:47 schrieb Ivaylo Dimitrov: On 30.10.20 г. 9:24 ч., Heiko Schocher wrote: Hello Ivaylo, Am 30.10.2020 um 08:00 schrieb Ivaylo Dimitrov: Hi, On 29.10.20 г. 11:32 ч., Heiko Schocher wrote: Hello Ivaylo, Am 29.10.2020 um 08:51 schrieb Ivaylo Dimitrov: Hi,

Re: Using USB Mass Storage on AM335X

2020-11-01 Thread Heiko Schocher
Hello Otavio, Am 01.11.2020 um 02:12 schrieb Otavio Salvador: Hello all, Em qui., 29 de out. de 2020 às 19:19, Otavio Salvador escreveu: ... Does anyone know why selecting CONFIG_CMD_USB_MASS_STORAGE=y causes the board to not boot anymore? We found it; setting

Re: [PATCH] env: env_sf: don't set .init op if not needed

2020-11-01 Thread Heiko Schocher
Hello Michael, Am 01.11.2020 um 14:38 schrieb Michael Walle: Commit 92765f45bb95 ("env: Access Environment in SPI flashes before relocation") at least breaks the Kontron sl28 board. I guess it also breaks others which use a (late) SPI environment. Unfortunately, we cannot set the .init op and

[RFC PATCH] dfu: add DFU_SKIP layout concept

2020-11-01 Thread Jaehoon Chung
Add DFU_SKIP layout cencept. If layout is "skip", it will be skipped after nothing to do. It's useful to support multiple board with one tar file. Signed-off-by: Jaehoon Chung --- drivers/dfu/dfu.c | 2 +- drivers/dfu/dfu_mmc.c | 9 + include/dfu.h | 1 + 3 files changed, 11

Re: [PATCH v2 17/21] phy: add USB PHY driver for MediaTek MT7620 SoC

2020-11-01 Thread Jagan Teki
On Fri, Oct 30, 2020 at 3:05 PM Weijie Gao wrote: > > This patch adds USB PHY driver for MediaTek MT7620 SoC > > Signed-off-by: Weijie Gao > --- > v2 changes: none > --- > drivers/phy/Kconfig | 7 +++ > drivers/phy/Makefile | 1 + > drivers/phy/mt7620-usb-phy.c | 113

[PATCH 1/1] layerscape: fdt.c: Check for NULL return value from fdt_getprop()

2020-11-01 Thread Priyanka Singh
Check for NULL return value from fdt_getprop() in fdt_fixup_remove_jr() Signed-off-by: Priyanka Singh --- arch/arm/cpu/armv8/fsl-layerscape/fdt.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/arch/arm/cpu/armv8/fsl-layerscape/fdt.c

Re: [PATCH v2 14/21] watchdog: add watchdog driver for MediaTek MT7620 SoC

2020-11-01 Thread Jagan Teki
On Fri, Oct 30, 2020 at 3:04 PM Weijie Gao wrote: > > This patch adds watchdog support for the Mediatek MT7620 SoC > > Signed-off-by: Weijie Gao > --- > v2 changes: add expire_now > --- > drivers/watchdog/Kconfig | 7 ++ > drivers/watchdog/Makefile | 1 + >

[PATCH 1/1] board: freescale: vid.c: Add check for return value of adjust_vdd()

2020-11-01 Thread Priyanka Singh
Add check for return value of adjust_vdd() Signed-off-by: Priyanka Singh --- board/freescale/common/vid.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/board/freescale/common/vid.c b/board/freescale/common/vid.c index bfd24c43b4..95d7df1e26 100644 ---

Re: [PATCH v2 16/21] spi: add spi controller support for MediaTek MT7620 SoC

2020-11-01 Thread Jagan Teki
On Fri, Oct 30, 2020 at 3:05 PM Weijie Gao wrote: > > This patch adds spi controller support for MediaTek MT7620 SoC. > > The SPI controller supports two chip selects. These two chip selects are > implemented as two separate register groups, but they share the same bus > (DI/DO/CLK), only CS pins

Re: [PATCH v4 2/3] env: Access Environment in SPI flashes before relocation

2020-11-01 Thread Heiko Schocher
Hello Tom, Michael, Am 31.10.2020 um 01:07 schrieb Tom Rini: On Sat, Oct 31, 2020 at 12:51:27AM +0100, Michael Walle wrote: Hi Heiko, Hi Tom, Am 2020-10-10 10:28, schrieb Heiko Schocher: Enable the new Kconfig option ENV_SPI_EARLY if you want to use Environment in SPI flash before

[PATCH] configs: meson64: relocate config_distro_bootcmmd header

2020-11-01 Thread Jaehoon Chung
Relocate a config_distro_bootcmd header before defined CONFIG_EXTRA_ENV_SETTINGS. Otherwise it can't change to specific environment. Signed-off-by: Jaehoon Chung --- include/configs/meson64.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/configs/meson64.h

Re: [PATCH 2/4] fs: btrfs: volumes: prevent overflow for multiplying

2020-11-01 Thread Qu Wenruo
On 2020/11/2 上午8:20, Qu Wenruo wrote: > > > On 2020/11/2 上午7:02, Marek Behun wrote: >> On Sat, 31 Oct 2020 09:07:50 +0800 >> Qu Wenruo wrote: >> >>> In real world, this should not cause problem as we have device number >>> limit thus it won't go beyond 4G for a single stripe. >> >> So we

Re: [PATCH 4/4] fs: btrfs: initialize @ii in show_dir() to make coverity happy

2020-11-01 Thread Qu Wenruo
On 2020/11/2 上午7:06, Marek Behun wrote: > On Sat, 31 Oct 2020 09:07:52 +0800 > Qu Wenruo wrote: > >> In show_dir() if we hit file type FT_CHRDEV or FT_BLKDEV, we expect an >> BTRFS_INODE_ITEM_KEY, and for that case, we should have @ii filled with >> data read from disk. >> >> We even have

Re: [PATCH 2/4] fs: btrfs: volumes: prevent overflow for multiplying

2020-11-01 Thread Qu Wenruo
On 2020/11/2 上午7:02, Marek Behun wrote: > On Sat, 31 Oct 2020 09:07:50 +0800 > Qu Wenruo wrote: > >> In real world, this should not cause problem as we have device number >> limit thus it won't go beyond 4G for a single stripe. > > So we can't run into this overflow in U-Boot because only

[PATCH v2 2/3] x86: zimage: Sanity-check the kernel version before printing it

2020-11-01 Thread Simon Glass
With Chrome OS the kernel setup block is stored in a separate place from the kernel, so it is not possible to access the kernel version string. At present, garbage is printed. Add a sanity check to avoid this. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/lib/zimage.c | 9

[PATCH v2 3/3] x86: zimage: Quieten down the zimage boot process

2020-11-01 Thread Simon Glass
Much of the output is not very useful. The bootm command is quite a bit quieter. Convert some output to use log_debug(). Signed-off-by: Simon Glass --- Changes in v2: - Drop patches already applied - Rebase ot master arch/x86/lib/zimage.c | 11 ++- 1 file changed, 6 insertions(+), 5

[PATCH v2 0/3] Various minor patches

2020-11-01 Thread Simon Glass
This series contains a number of minor patches collected while completing the ACPI updates for U-Boot. Changes in v2: - Drop patches already applied - Rebase ot master Simon Glass (3): x86: zimage: Add a little more logging x86: zimage: Sanity-check the kernel version before printing it

[PATCH v2 1/3] x86: zimage: Add a little more logging

2020-11-01 Thread Simon Glass
Add logging for each part of the boot process, using a new Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/lib/zimage.c | 6 ++ common/log.c | 1 + include/log.h | 1 + 3 files changed, 8 insertions(+) diff --git a/arch/x86/lib/zimage.c

Re: [PATCH 10/10] setexpr: Add support for strings

2020-11-01 Thread Marek Behun
What is the purpose of + operator on strings? Can't we use setenv "${a}${b}" ?

Re: [PATCH 4/4] fs: btrfs: initialize @ii in show_dir() to make coverity happy

2020-11-01 Thread Marek Behun
On Sat, 31 Oct 2020 09:07:52 +0800 Qu Wenruo wrote: > In show_dir() if we hit file type FT_CHRDEV or FT_BLKDEV, we expect an > BTRFS_INODE_ITEM_KEY, and for that case, we should have @ii filled with > data read from disk. > > We even have ASSERT() for this purpose, but unfortunately coverity

Re: [PATCH 3/4] fs: btrfs: initialize @ret to 0 to prevent uninitialized return value

2020-11-01 Thread Marek Behun
Reviewed-by: Marek Behún

Re: [PATCH 2/4] fs: btrfs: volumes: prevent overflow for multiplying

2020-11-01 Thread Marek Behun
On Sat, 31 Oct 2020 09:07:50 +0800 Qu Wenruo wrote: > In real world, this should not cause problem as we have device number > limit thus it won't go beyond 4G for a single stripe. So we can't run into this overflow in U-Boot because only one device is supported? But in Linux we can run into

Re: [PATCH 1/4] fs: btrfs: inode: handle uninitialized type before returning it

2020-11-01 Thread Marek Behun
Reviewed-by: Marek Behún

Re: Pull request for UEFI sub-system for efi-2021-01-rc2 (2)

2020-11-01 Thread Tom Rini
On Sun, Nov 01, 2020 at 04:39:26PM +0100, Heinrich Schuchardt wrote: > The following changes since commit cdeb7b8f984e6d9bcdc5a6fdda6107af156d47bf: > > configs: Resync with savedefconfig (2020-10-29 10:48:01 -0400) > > are available in the Git repository at: > >

[PATCH 07/10] setexpr: Correct dropping of final unmatched string

2020-11-01 Thread Simon Glass
At present the 'nlen' variable increases with each loop. If the previous loop had back references, then subsequent loops without back references use the wrong value of nlen. The value is larger, meaning that the string terminator from nbuf is copied along to the main buffer, thus terminating the

[PATCH 08/10] setexpr: Correct buffer overflow bug and enable tests

2020-11-01 Thread Simon Glass
At present when more than one substitution is made this function overwrites its buffers. Fix this bug and update the tests now that they can pass. Also update the debug code to show all substrings, since at present it omits the final one. Fixes: 855f18ea0e6 ("setexpr: add regex substring

[PATCH 10/10] setexpr: Add support for strings

2020-11-01 Thread Simon Glass
Add support for dealing with string operands, including reading a string from memory into an environment variable and concatenating two strings. Signed-off-by: Simon Glass --- cmd/setexpr.c | 82 +++ test/cmd/setexpr.c | 86

[PATCH 09/10] setexpr: Convert to use a struct for values

2020-11-01 Thread Simon Glass
At present a ulong is used to hold operand values. This means that strings cannot be used. While most operations are not useful for strings, concatenation is. As a starting point to supporting strings, convert the code to use a struct instead of a ulong for operands. Signed-off-by: Simon Glass

[PATCH 03/10] setexpr: Add explicit support for 32- and 64-bit ints

2020-11-01 Thread Simon Glass
At present this function assumes that a size of 4 refers to a ulong. This is true on 32-bit machines but not commonly on 64-bit machines. This means that the 'l' specify does not work correctly with setexpr. Add an explicit case for 32-bit values so that 64-bit machines can still use the 'l'

[PATCH 05/10] setexpr: Split the core logic into its own function

2020-11-01 Thread Simon Glass
At present this function always allocates a large amount of stack, and selects its own size for buffers. This makes it hard to test the code for buffer overflow. Separate out the inner logic of the substitution so that tests can call this directly. This will allow checking that the algorithm does

[PATCH 04/10] test: Add some setexpr regex tests

2020-11-01 Thread Simon Glass
Add tests for the setexpr regex commands. Note that these tests currently crash on sandbox due to an existing bug in the setexpr implementation, so two of the tests are commented out. Signed-off-by: Simon Glass --- test/cmd/setexpr.c | 58 ++ 1 file

[PATCH 06/10] setexpr: Add some tests for buffer overflow and backref

2020-11-01 Thread Simon Glass
Add tests to check for buffer overflow using simple replacement as well as back references. At present these don't fully pass. Signed-off-by: Simon Glass --- cmd/setexpr.c | 21 +++ include/command.h | 17 + test/cmd/setexpr.c | 89

[PATCH 01/10] test: Add some tests for setexpr

2020-11-01 Thread Simon Glass
This command currently has no tests. Add some for basic assignment and the integer operations. Note that the default size for setexpr is ulong, which varies depending on the build machine. So for sandbox on a 64-bit host, this means that the default size is 64 bits. Signed-off-by: Simon Glass

[PATCH 02/10] command: Add constants for cmd_get_data_size string / error

2020-11-01 Thread Simon Glass
At present these values are open-coded in a few places. Add constants so the meaning is clear. Also add a comment to cmd_get_data_size() Signed-off-by: Simon Glass --- cmd/itest.c | 4 ++-- cmd/mem.c | 2 +- common/command.c | 4 ++-- include/command.h | 26

[PATCH 00/10] setexpr: Correct various bugs and add tests plus string support

2020-11-01 Thread Simon Glass
This command has several bugs that were discovered in trying to get zboot to make use of regular expression substitution: - reads the wrong values with 'setexpr.l' or 'setexpr' on 64-bit machines - buffer overflow of main string buffer - buffer overflow of 'new' string buffer - produces the wrong

RE: [PATCH v5 2/2] mmc: renesas-sdhi: Add R8A774A1 SDHI quirks

2020-11-01 Thread Biju Das
Hi Marek, > Subject: Re: [PATCH v5 2/2] mmc: renesas-sdhi: Add R8A774A1 SDHI quirks > > On 10/8/20 10:59 AM, Biju Das wrote: > > Add various SDHI quirks for R8A774A1 SoC. > > > > Signed-off-by: Biju Das > > Reviewed-by: Lad Prabhakar lad...@bp.renesas.com> > > --- > > v5 : New Patch > > --- >

RE: [PATCH v5 1/2] arm: rmobile: Add RZ/G2[HMNE] SoC support

2020-11-01 Thread Biju Das
Hi Marek, > Subject: Re: [PATCH v5 1/2] arm: rmobile: Add RZ/G2[HMNE] SoC support > > On 10/8/20 10:59 AM, Biju Das wrote: > > [...] > > > +static const struct udevice_id tfa_cpu_info[] = { > > + { .compatible = "renesas,r8a774a1", .data = > RMOBILE_CPU_TYPE_R8A774A1 }, > > + { .compatible

RE: [PATCH 3/8] pinctrl: renesas: r8a7796: Optimize pinctrl image size for R8A774A1

2020-11-01 Thread Biju Das
Hi Marek, > Subject: Re: [PATCH 3/8] pinctrl: renesas: r8a7796: Optimize pinctrl image > size > for R8A774A1 > > On 10/28/20 11:34 AM, Biju Das wrote: > > This driver supports both RZ/G2M and R-Car M3-W/W+ SoCs. > > Optimize pinctrl image size for RZ/G2M, when support for R-Car M3-W/W+ > >

Pull request for UEFI sub-system for efi-2021-01-rc2 (2)

2020-11-01 Thread Heinrich Schuchardt
The following changes since commit cdeb7b8f984e6d9bcdc5a6fdda6107af156d47bf: configs: Resync with savedefconfig (2020-10-29 10:48:01 -0400) are available in the Git repository at: https://gitlab.denx.de/u-boot/custodians/u-boot-efi.git tags/efi-2020-01-rc2-2 for you to fetch changes up to

[PATCH V2 10/12] doc: board: Convert i.MX6 Sabresd README to reST

2020-11-01 Thread sbabic
> Convert plain text documentation to reStructuredText format and add > it to Sphinx TOC tree. No essential content change. > Signed-off-by: Peng Fan Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- =

[PATCH V2 06/12] doc: board: Convert i.MX8QXP MEK README to reST

2020-11-01 Thread sbabic
> Convert plain text documentation to reStructuredText format and add > it to Sphinx TOC tree. No essential content change. > Signed-off-by: Peng Fan Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- =

[PATCH V2 09/12] doc: board: Convert i.MX6 Sabreauto README to reST

2020-11-01 Thread sbabic
> Convert plain text documentation to reStructuredText format and add > it to Sphinx TOC tree. No essential content change. > Signed-off-by: Peng Fan Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- =

[PATCH V2 05/12] doc: board: Convert i.MX8MQ EVK README to reST

2020-11-01 Thread sbabic
> Convert plain text documentation to reStructuredText format and add > it to Sphinx TOC tree. No essential content change. > Signed-off-by: Peng Fan Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- =

[PATCH V2 03/12] doc: board: Convert i.MX8MN EVK README to reST

2020-11-01 Thread sbabic
> Convert plain text documentation to reStructuredText format and add > it to Sphinx TOC tree. No essential content change. > Signed-off-by: Peng Fan Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- =

[PATCH V2 07/12] doc: board: Convert i.MXRT1020 EVK README to reST

2020-11-01 Thread sbabic
> Convert plain text documentation to reStructuredText format and add > it to Sphinx TOC tree. No essential content change. > Signed-off-by: Peng Fan Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- =

[PATCH V2 08/12] doc: board: Convert i.MXRT1050 EVK README to reST

2020-11-01 Thread sbabic
> Convert plain text documentation to reStructuredText format and add > it to Sphinx TOC tree. No essential content change. > Signed-off-by: Peng Fan Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- =

[PATCH V2 11/12] doc: board: Convert i.MX6UL 14x14 EVK README to reST

2020-11-01 Thread sbabic
> Convert plain text documentation to reStructuredText format and add > it to Sphinx TOC tree. No essential content change. > Signed-off-by: Peng Fan Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- =

[PATCH V2 12/12] doc: board: Convert i.MX6ULL EVK README to reST

2020-11-01 Thread sbabic
> Convert plain text documentation to reStructuredText format and add > it to Sphinx TOC tree. No essential content change. > Signed-off-by: Peng Fan Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- =

[PATCH V2 04/12] doc: board: Convert i.MX8MM EVK README to reST

2020-11-01 Thread sbabic
> Convert plain text documentation to reStructuredText format and add > it to Sphinx TOC tree. No essential content change. > Signed-off-by: Peng Fan Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- =

[PATCH V2 02/12] doc: board: Convert i.MX8MP EVK README to reST

2020-11-01 Thread sbabic
> Convert plain text documentation to reStructuredText format and add > it to Sphinx TOC tree. No essential content change. > Signed-off-by: Peng Fan Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- =

[PATCH V2 01/12] board: imx: address dd usage in README

2020-11-01 Thread sbabic
> When using cygwin64 "dd (coreutils) 8.26 Packaged by Cygwin (8.26-2)", > the last not 512bytes aligned data wat cut off and not burned into SD > card. > Saying the flash.bin size is 1085608 bytes, not 512bytes aligned. It only > burned 1085440 bytes, the leaving 168 bytes were not burnned and

[PATCH] env: env_sf: don't set .init op if not needed

2020-11-01 Thread Michael Walle
Commit 92765f45bb95 ("env: Access Environment in SPI flashes before relocation") at least breaks the Kontron sl28 board. I guess it also breaks others which use a (late) SPI environment. Unfortunately, we cannot set the .init op and fall back to the same behavior as it would be unset. Thus guard

[PATCH] gpio: mt7621: remove dependce SOC_MT7628 of MT7621_GPIO

2020-11-01 Thread Du Huanpeng
the help says it is for "MT7621 compatible" GPIOs, but in this Kconfig it depends on MT7628 SoC. this will prevent other SoC to use this driver. Signed-off-by: Du Huanpeng --- drivers/gpio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/Kconfig

Re: [PATCH 3/8] pinctrl: renesas: r8a7796: Optimize pinctrl image size for R8A774A1

2020-11-01 Thread Marek Vasut
On 10/28/20 11:34 AM, Biju Das wrote: This driver supports both RZ/G2M and R-Car M3-W/W+ SoCs. Optimize pinctrl image size for RZ/G2M, when support for R-Car M3-W/W+ (R8A7796[01]) is not enabled. Based on the similar patch on Linux. Is this patch now part of mainline Linux or is there a

Re: [PATCH 5/8] pinctrl: renesas: r8a7795: Optimize pinctrl image size for R8A774E1

2020-11-01 Thread Marek Vasut
On 10/28/20 11:34 AM, Biju Das wrote: This driver supports both RZ/G2H and R-Car H3 SoCs. Optimize pinctrl image size for RZ/G2H, when support for R-Car H3 (R8A7795) is not enabled Based on the similar patch on Linux. Applied, thanks

Re: [PATCH 4/8] pinctrl: renesas: r8a77965: Optimize pinctrl image size for R8A774B1

2020-11-01 Thread Marek Vasut
On 10/28/20 11:34 AM, Biju Das wrote: This driver supports both RZ/G2N and R-Car M3-N SoCs. Optimize pinctrl image size for RZ/G2N, when support for R-Car M3-N (R8A77965) is not enabled. Based on the simialr patch on Linux. Applied, thanks

Re: [PATCH 2/8] pinctrl: renesas: r8a77951: Add R8A774E1 PFC support

2020-11-01 Thread Marek Vasut
On 10/28/20 11:34 AM, Biju Das wrote: Renesas RZ/G2H (r8a774e1) is pin compatible with R-Car H3 (r8a77951), however it doesn't have several automotive specific peripherals. Add a r8a77951 specific pin groups/functions along with common pin groups/functions for supporting both r8a77951 and

Re: [PATCH 1/8] pinctrl: renesas: r8a77965: Add R8A774B1 PFC support

2020-11-01 Thread Marek Vasut
On 10/28/20 11:34 AM, Biju Das wrote: Renesas RZ/G2N (r8a774b1) is pin compatible with R-Car M3-N (r8a77965), however it doesn't have several automotive specific peripherals. Add a r8a77965 specific pin groups/functions along with common pin groups/functions for supporting both r8a77965 and

Re: [PATCH v5 18/27] misc: am33xx: add control module driver

2020-11-01 Thread Dario Binacchi
Hi Simon, > Il 28/10/2020 03:10 Simon Glass ha scritto: > > > On Sun, 25 Oct 2020 at 06:40, Dario Binacchi wrote: > > > > The implementation of this driver was needed to bind the device tree > > sub-nodes of the 'clocks' node. In fact, the lack of the compatible > > property in the 'clocks'