Re: [PATCH] env: Fix warning when forcing environment without ENV_ACCESS_IGNORE_FORCE

2021-01-28 Thread Fuzzey, Martin
On Fri, 29 Jan 2021 at 00:05, Marek Vasut wrote: > > On 1/28/21 8:37 PM, Fuzzey, Martin wrote: > > Hi Marek, > > Hi, > > > On Thu, 28 Jan 2021 at 20:07, Marek Vasut wrote: > >> > >> Based on env/Kconfig description of this option: > >> > >> config ENV_ACCESS_IGNORE_FORCE > >> bool

Re: [PATCH] env: sf: single function env_sf_save()

2021-01-28 Thread Stefan Roese
On 28.01.21 12:21, Harry Waschkeit wrote: Even though an "if (CONFIG_IS_ENABLED(...))" would statically evaluate to '0' without active redundancy in environments, the parser sees the syntax error of the non-existing structure element. So, I don't see a chance for avoiding the #if construct

RE: [PATCHv2] pci: layerscape: Remove the shadow SVR definitions

2021-01-28 Thread Wasim Khan
> -Original Message- > From: Z.q. Hou > Sent: Friday, January 29, 2021 10:17 AM > To: u-boot@lists.denx.de; Priyanka Jain > Cc: Wasim Khan ; Z.q. Hou > Subject: [PATCHv2] pci: layerscape: Remove the shadow SVR definitions > > From: Hou Zhiqiang > > This patch moves the SVR

RE: [PATCH] pci: kconfig: layerscape: Change LX2162A PCIe node compatible string

2021-01-28 Thread Wasim Khan
> -Original Message- > From: Z.q. Hou > Sent: Friday, January 29, 2021 10:52 AM > To: u-boot@lists.denx.de; Priyanka Jain ; Wasim Khan > > Cc: Z.q. Hou > Subject: [PATCH] pci: kconfig: layerscape: Change LX2162A PCIe node > compatible string > > From: Hou Zhiqiang > > LX2162A is

Re: [RFC RESEND 1/2] efi: Add ESRT to the EFI system table

2021-01-28 Thread AKASHI Takahiro
First of all, one comment: It would be nice to have a list of what features are supported and what are not in this patch series. For example, with this patch, I suspect - FwVersion in ESRT entry will never be updated at capsule update - LastAttemptVersion/LastAttemptStatus will not be sustained

[PATCH] pci: kconfig: layerscape: Change LX2162A PCIe node compatible string

2021-01-28 Thread Zhiqiang Hou
From: Hou Zhiqiang LX2162A is not like LX2160A which has different PCIe controller in rev1 and rev2 silicon. It supports only one configuration of PCIe controller, which is same as LS2088A. So update PCIe compatible string same as LS2088A. Signed-off-by: Hou Zhiqiang --- drivers/pci/Kconfig |

[PATCHv2] pci: layerscape: Remove the shadow SVR definitions

2021-01-28 Thread Zhiqiang Hou
From: Hou Zhiqiang This patch moves the SVR definitions to a new svr.h for Layerscape armv7 and armv8 platforms respectively, so that the PCIe driver can reuse them. Signed-off-by: Hou Zhiqiang --- V2: - rebase the patch and correct the typos in the subject

Re: [PATCH V2] cmd: mem: fix to display wrong memory information

2021-01-28 Thread Jaehoon Chung
On 1/28/21 6:33 PM, Stefan Roese wrote: > On 28.01.21 03:35, Jaehoon Chung wrote: >> When run meminfo command, it's displayed wrong memory information. >> Because some boards are that gd->ram_size is reassigned to other value >> in board file. >> Additionally, display a memory bank information. >>

Re: [BUG] Hang shortly after loading FDT when booting on RK3399

2021-01-28 Thread Jan Palus
On 28.01.2021 23:28, Jan Palus wrote: > FWIW I figured it hangs in ohci-hcd.c at: > > static int hc_reset(ohci_t *ohci) > ... > if (ohci_readl(>regs->control) & OHCI_CTRL_IR) { This appears to be caused by following events: - usb_stop() (usb-class.c) iterates to remove every bus -

Re: [PATCH] ata: sunxi: fix debug messages

2021-01-28 Thread Andre Przywara
On Sun, 24 Jan 2021 19:13:10 +0100 Dario Binacchi wrote: > It is useless and misleading to print the ret variable that is not set > by the dev_read_addr routine. Also, move the '\n' character after the > round bracket that contains the error code. > > Signed-off-by: Dario Binacchi Good catch!

Re: [PATCH v2 2/2] doc: device-tree-bindings: rtc: Abracon AB x80x i2c rtc

2021-01-28 Thread Tom Rini
On Fri, Jan 15, 2021 at 01:53:03PM +0800, Ying-Chun Liu wrote: > From: "Ying-Chun Liu (PaulLiu)" > > Document the bindings for abracon,abx80x and related compatibles. > > Signed-off-by: Ying-Chun Liu (PaulLiu) Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP

Re: [PATCH 17/17] binman: Allow reading entries from a subnode

2021-01-28 Thread Tom Rini
On Wed, Jan 13, 2021 at 08:29:57PM -0700, Simon Glass wrote: > Some images may have multiple copies of the same thing, e.g. two versions > of the read/write U-Boots. It is necessary to read data from one or other > of these under selection of the verified-boot logic. Add a function to > select

Re: [PATCH 16/17] binman: Move selection of the binman node into a function

2021-01-28 Thread Tom Rini
On Wed, Jan 13, 2021 at 08:29:56PM -0700, Simon Glass wrote: > Move this logic out of the main init function so it is available for > other purpose. > > Use a different error when multiple-images is in use but no subnode is > available. This makes it easier to determine what is wrong. > >

Re: [PATCH 15/17] crc32: Exclude crc32 from TPL

2021-01-28 Thread Tom Rini
On Wed, Jan 13, 2021 at 08:29:55PM -0700, Simon Glass wrote: > Unfortunately the toolchain often brings in the crc32 table even if the > function is not actually used. For now, exclude it from the TPL build, > which is very sensitive to size. > > Signed-off-by: Simon Glass Applied to

Re: [PATCH] cmd: misc: Fix return value for the sleep command

2021-01-28 Thread Tom Rini
On Fri, Jan 22, 2021 at 12:27:31PM +0100, Marek Szyprowski wrote: > If sleeping has been interrupted, return CMD_RET_FAILURE instead of -1 > (CMD_RET_USAGE). > > Signed-off-by: Marek Szyprowski > Reviewed-by: Simon Glass > Reviewed-by: Jaehoon Chung Applied to u-boot/master, thanks! -- Tom

Re: [PATCH] autoboot: fix illegal memory access when stop key and delay key are empty

2021-01-28 Thread Tom Rini
On Fri, Jan 15, 2021 at 03:11:49AM +, yuezhang...@sony.com wrote: > If both stop key and delay key are empty, the length of these > keys is 0. The subtraction operation will cause the u_int type > variable to overflow, will cause illegal memory access in key > input loop. > > This commit

Re: [PATCH v2 1/2] rtc: add rtc-abx80x, a driver for the Abracon AB x80x i2c rtc

2021-01-28 Thread Tom Rini
On Fri, Jan 15, 2021 at 01:53:02PM +0800, Ying-Chun Liu wrote: > From: "Ying-Chun Liu (PaulLiu)" > > This is a basic driver for the ultra-low-power Abracon AB x80x series > of RTC chips. It supports in particular, the supersets AB0805 and AB1805. > It allows reading and writing the time, and

Re: [PATCH 14/17] mmc: pci_mmc: Set the removable flag

2021-01-28 Thread Tom Rini
On Wed, Jan 13, 2021 at 08:29:54PM -0700, Simon Glass wrote: > Set this flag so that it is available to those looking at the device. For > non-removable devices there is no need to check for insertion/removable > since the media can never change. > > Signed-off-by: Simon Glass > Reviewed-by:

Re: [PATCH 12/17] mmc: pci_mmc: Only generate ACPI code for the SD card

2021-01-28 Thread Tom Rini
On Wed, Jan 13, 2021 at 08:29:52PM -0700, Simon Glass wrote: > At present if an eMMC part is in the system, the ACPI table generated > will include information about that, as well as the SD card. We only need > to include the SD card, since it has a card-detect GPIO. Use a different > compatible

Re: [PATCH 04/17] bloblist: Add missing tag names

2021-01-28 Thread Tom Rini
On Wed, Jan 13, 2021 at 08:29:44PM -0700, Simon Glass wrote: > Add tag names for recently added types. > > Fixes: d2cb7a22da0 (x86: Allow putting some tables in the bloblist) > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 11/17] uuid: Add a comment for UUID_STR_LEN

2021-01-28 Thread Tom Rini
On Wed, Jan 13, 2021 at 08:29:51PM -0700, Simon Glass wrote: > This macro is the length of the string but excludes the terminator. Users > must add 1 when declaring a large-enough string. Add a comment to make > this clear. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! --

Re: [PATCH 10/17] display_options: Use USE_TINY_PRINTF for SPL check

2021-01-28 Thread Tom Rini
On Wed, Jan 13, 2021 at 08:29:50PM -0700, Simon Glass wrote: > At present this code uses a simple printf() format if running in SPL. But > SPL can use the full printf. Use USE_TINY_PRINTF instead. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc

Re: [PATCH 09/17] fdtdec: Use CONFIG_IS_ENABLED in board_fdt_blob_setup()

2021-01-28 Thread Tom Rini
On Wed, Jan 13, 2021 at 08:29:49PM -0700, Simon Glass wrote: > This setting may be different in SPL and TPL. Update the code to check > the correct setting. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 08/17] fdtdec: Update the missing-devicetree message

2021-01-28 Thread Tom Rini
On Wed, Jan 13, 2021 at 08:29:48PM -0700, Simon Glass wrote: > This includes information about sandbox which is not relevant for most > boards. Drop it. > > Also add the address to help figure out the problem. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom

Re: [PATCH 07/17] net: Use CONFIG_IS_ENABLED() in eth_dev_get_mac_address()

2021-01-28 Thread Tom Rini
On Wed, Jan 13, 2021 at 08:29:47PM -0700, Simon Glass wrote: > This function may be used in SPL where devicetree is not available. > Use the correct macro so that the function does not try to read it. > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc

Re: [PATCH 06/17] video: Allow syncing the entire framebuffer to the copy

2021-01-28 Thread Tom Rini
On Wed, Jan 13, 2021 at 08:29:46PM -0700, Simon Glass wrote: > In some cases so much of the framebuffer is updated that it is not worth > copying the changes piece by piece to the copy framebuffer. Add a function > to copy the whole thing. > > Signed-off-by: Simon Glass Applied to

Re: [PATCH 03/17] bloblist: Support relocating to a larger space

2021-01-28 Thread Tom Rini
On Wed, Jan 13, 2021 at 08:29:43PM -0700, Simon Glass wrote: > Typically in TPL/SPL the bloblist is quite small. But U-Boot proper may > want to add a lot more to it, such as ACPI tables. > > Add a way to expand the bloblist by relocating it in U-Boot proper, along > with the other relocation

Re: [PATCH 02/17] spl: Add functions for next and previous phase

2021-01-28 Thread Tom Rini
On Wed, Jan 13, 2021 at 08:29:42PM -0700, Simon Glass wrote: > It is useful to be able to figure out which phase we are loading next and > which phase we came from. Add some functions to handle this as well as > returning the name of a phase. This allows messages like "Booting to x" > where x is

Re: [PATCH] lib: rsa: rsa-verify: don't look for keys in the FIT image

2021-01-28 Thread Tom Rini
On Tue, Jan 12, 2021 at 07:18:54PM +0100, Philippe Reynes wrote: > In the function rsa_verify_hash, if the "main" key doesn't > work, u-boot try others keys. But it searches those keys > in the FIT image instead of the u-boot device tree. > > Signed-off-by: Philippe Reynes > Reviewed-by: Simon

Re: [PATCH] pci: Remove CONFIG_PCI_ENUM_ONLY as it's not used (any more)

2021-01-28 Thread Tom Rini
On Tue, Jan 12, 2021 at 12:03:43PM +0100, Stefan Roese wrote: > This patch completely removes CONFIG_PCI_ENUM_ONLY from the PCI code as > it is not configured for any board (any more). With this removal, some > PCI related files get cleaned up a bit. > > Additional, dm_pciauto_setup_device() is

Re: [PATCH] common: fit-sig: Fix error message in fit_config_verify_sig()

2021-01-28 Thread Tom Rini
On Mon, Jan 11, 2021 at 08:46:58AM -0600, Alexandru Gagniuc wrote: > In fit_config_verify_sig(), when no 'signature*' subnode exists in > the configuration node, the fdt_for_each_subnode() loop is a no-op. > Therefore, no error flags are set, and 'err_,sg' is not populated > with an error string.

Re: [PATCH] bootcount: allow to use this feature on TPL

2021-01-28 Thread Tom Rini
On Fri, Dec 11, 2020 at 07:56:47PM +0100, Philippe Reynes wrote: > This commit add an option TPL_BOOTCOUNT_LIMIT to > use bootcount on TPL. > > Signed-off-by: Philippe Reynes > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] smccc: fix sign bit expansion

2021-01-28 Thread Tom Rini
On Tue, Jan 05, 2021 at 08:03:11PM +, Volodymyr Babchuk wrote: > Signed ARM_SMCCC_FAST_CALL value is shifted to 31'st bit. Then, it is expanded > to 64 bit value, which results in 1s in higher 32 bits. > > This causes corrupted values in 64-bit SMC IDs and issues in buggy handlers of >

Re: [PATCH] test: correct entry point to pytest

2021-01-28 Thread Tom Rini
On Thu, Jan 28, 2021 at 07:36:53PM +0100, Heinrich Schuchardt wrote: > On 1/28/21 5:17 PM, Tom Rini wrote: > > On Thu, Jan 28, 2021 at 02:28:03PM +0100, Heinrich Schuchardt wrote: > > > On 28.01.21 13:58, Tom Rini wrote: > > > > On Thu, Jan 28, 2021 at 12:46:11PM +0100, Heinrich Schuchardt wrote:

Re: [PATCH] Makefile: Do not call useless command 'true'

2021-01-28 Thread Tom Rini
On Wed, Nov 04, 2020 at 03:33:44PM +0100, Pali Rohár wrote: > Macro 'cmd_objcopy_uboot' currently does not work with passed empty command > expanded from 'cmd_static_rela' and therefore dummy command 'true' is set > in 'cmd_static_rela' to workaround this issue. > > Eliminate it now by fixing

Re: [PATCH] env: Fix warning when forcing environment without ENV_ACCESS_IGNORE_FORCE

2021-01-28 Thread Marek Vasut
On 1/28/21 8:37 PM, Fuzzey, Martin wrote: Hi Marek, Hi, On Thu, 28 Jan 2021 at 20:07, Marek Vasut wrote: Based on env/Kconfig description of this option: config ENV_ACCESS_IGNORE_FORCE bool "Block forced environment operations" default n help If

Re: [PATCH] env: Fix warning when forcing environment without ENV_ACCESS_IGNORE_FORCE

2021-01-28 Thread Marek Vasut
On 1/28/21 8:26 PM, Tom Rini wrote: On Thu, Jan 28, 2021 at 08:07:54PM +0100, Marek Vasut wrote: On 1/11/21 11:27 AM, Martin Fuzzey wrote: Since commit 0f036bf4b87e ("env: Warn on force access if ENV_ACCESS_IGNORE_FORCE set") a warning message is displayed when setenv -f is used WITHOUT

Re: [BUG] Hang shortly after loading FDT when booting on RK3399

2021-01-28 Thread Jan Palus
FWIW I figured it hangs in ohci-hcd.c at: static int hc_reset(ohci_t *ohci) ... if (ohci_readl(>regs->control) & OHCI_CTRL_IR) {

[PATCH v2 09/12] pinctrl: single: add get_pins_count operation

2021-01-28 Thread Dario Binacchi
It returns the number of selectable pins. Signed-off-by: Dario Binacchi Reviewed-by: Simon Glass --- Changes in v2: - Added Simon Glass review tag. drivers/pinctrl/pinctrl-single.c | 37 1 file changed, 37 insertions(+) diff --git

[PATCH v2 11/12] pinctrl: single: add get_pin_muxing operation

2021-01-28 Thread Dario Binacchi
It allows to display the muxing of a given pin. Inspired by more recent versions of the Linux driver, in addition to the address and the value of the configuration register I added the pin function retrieved from the DT. In doing so, the information displayed does not depend on the platform, being

[PATCH v2 10/12] pinctrl: single: add get_pin_name operation

2021-01-28 Thread Dario Binacchi
It returns the name of the requested pin. Signed-off-by: Dario Binacchi Reviewed-by: Simon Glass --- Changes in v2: - Added Simon Glass review tag. drivers/pinctrl/pinctrl-single.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/pinctrl/pinctrl-single.c

[PATCH v2 12/12] test: pinmux: add test for 'pinctrl-single' driver

2021-01-28 Thread Dario Binacchi
The test adds two pinmux nodes to the device tree, one to test when a register changes only one pin's mux (pinctrl-single,pins), and the other to test when more than one pin's mux is changed (pinctrl-single,bits). This required replacing the controller's register access functions when the driver

[PATCH v2 07/12] pinctrl: single: change function mask default value

2021-01-28 Thread Dario Binacchi
The patch is inspired by more recent versions of the Linux driver. Replacing the default value 0x of the function mask with 0 is certainly more conservative in case the "pinctrl-single,function-mask" DT property is missing. Signed-off-by: Dario Binacchi --- (no changes since v1)

[PATCH v2 08/12] pinctrl: single: add register access functions

2021-01-28 Thread Dario Binacchi
The configuration of pinmux registers was implemented with duplicate code which can be removed by adding two functions for read/write access. Access to 8-bit registers has also been added. Signed-off-by: Dario Binacchi --- Changes in v2: - Updated commit message. - Remove pointer to access

[PATCH v2 03/12] pinctrl: single: fix offset management

2021-01-28 Thread Dario Binacchi
The pinmux configuration DT node of a peripheral does not define a physical address but an offset. Only by adding it to the base address of the controller it is possible to calculate the physical address of the register to be configured. Printing an offset also requires a different formatting

[PATCH v2 02/12] pinctrl: single: fix the loop counter variable type

2021-01-28 Thread Dario Binacchi
The 'n' variable is used as a loop counter, not as a physical address, and is used in a comparison with an int. So it makes sense to change its type from phys_addr_t to int. Signed-off-by: Dario Binacchi Reviewed-by: Simon Glass Reviewed-by: Pratyush Yadav --- Changes in v2: - Updated commit

[PATCH v2 06/12] pinctrl: single: check "register-width" DT property

2021-01-28 Thread Dario Binacchi
In more recent versions of the Linux kernel the driver's probe function returns an error if the "pinctrl-single,register-width" DT property is missing. The lack of this information, in fact, does not allow to know whether to access the registers of the controller at 8, 16, ... bits.

[PATCH v2 04/12] pinctrl: single: fix debug messages formatting

2021-01-28 Thread Dario Binacchi
The dev_dbg(dev, " reg/val 0x%pa/0x%08x\n", , val); prints the 'reg' address preceded by the prefix 0x0x instead of 0x. This because the printf '%pa' format specifier already appends the prefix '0x' to the address displayed. Signed-off-by: Dario Binacchi --- Changes in v2: - Updated commit

[PATCH v2 05/12] pinctrl: single: get register area size by device API

2021-01-28 Thread Dario Binacchi
Use dev_read_addr_size to get size of the controller's register area. Signed-off-by: Dario Binacchi --- Changes in v2: - Check dev_read_addr_size return value drivers/pinctrl/pinctrl-single.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git

[PATCH v2 00/12] Add support for pinmux status command on beaglebone

2021-01-28 Thread Dario Binacchi
The series was born from the need to check the pinmux setting of a peripheral on a beaglebone board. I then ran the 'pinmux status -a' command but it failed because some operations (get_pin_muxing, get_pin_name and get_pins_count) were missing in the 'pinctrl-single' driver. The patch series

[PATCH v2 01/12] pinctrl: single: fix format of structure documentation

2021-01-28 Thread Dario Binacchi
U-Boot adopted the kernel-doc annotation style. Signed-off-by: Dario Binacchi Reviewed-by: Simon Glass --- Changes in v2: - Added Simon Glass review tag. drivers/pinctrl/pinctrl-single.c | 45 +--- 1 file changed, 36 insertions(+), 9 deletions(-) diff --git

[PATCH 2/2] power: pmic: remove pmic_max8997/8 files

2021-01-28 Thread Jaehoon Chung
Remove pmic_max8997/8 files about no-DM. There are already existed max8997/8 as driver-model. Signed-off-by: Jaehoon Chung --- drivers/power/pmic/Makefile | 2 - drivers/power/pmic/pmic_max8997.c | 107 -- drivers/power/pmic/pmic_max8998.c | 32 - 3

[PATCH 1/2] board: samsung: covert to driver model about power_key_pressed

2021-01-28 Thread Jaehoon Chung
Convert to driver model about power_key_pressed. Signed-off-by: Jaehoon Chung --- board/samsung/common/misc.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/board/samsung/common/misc.c b/board/samsung/common/misc.c index

[PATCH 0/2] power: remove non-DM max8997/8 files

2021-01-28 Thread Jaehoon Chung
Remove non-DM files about max8997 and max8998. There are already max8997/8 pmic driver to support driver-model. But i didn't remove them because there was one place to use them. Now, it's time to remove non-DM max8997/8 files after converting to DM in samsung/common/misc.c Jaehoon Chung (2):

Re: [RESEND PATCH v1 1/1] mmc: fix response timeout after switch command

2021-01-28 Thread Jaehoon Chung
Hi Stefan, On 1/29/21 4:23 AM, Stefan Bosch wrote: > Hi, > > On 27.01.21 00:38, Jaehoon Chung wrote: >> Hi, >> >> On 1/23/21 9:37 PM, Stefan Bosch wrote: >>> After issuing the switch command: Wait until 'current state' of the card >>> status becomes 'tran'. This prevents from response timeout at

Re: [PATCH v1] usb: kbd: destroy device after console is stopped

2021-01-28 Thread Andy Shevchenko
On Thu, Jan 28, 2021 at 10:47 PM Tom Rini wrote: > On Thu, Jan 28, 2021 at 10:35:37PM +0200, Andy Shevchenko wrote: > Running this here on sandbox I get: > FAILED test/py/tests/test_ut.py::test_ut[ut_dm_bootcount] - OSError: [Errno > 5] Input/output ... Btw this is the wrong test case name

Re: [PATCH v1] usb: kbd: destroy device after console is stopped

2021-01-28 Thread Andy Shevchenko
On Thu, Jan 28, 2021 at 10:47 PM Tom Rini wrote: > On Thu, Jan 28, 2021 at 10:35:37PM +0200, Andy Shevchenko wrote: > > On Thu, Jan 28, 2021 at 06:19:56PM +0100, Nicolas Saenz Julienne wrote: > > > On Thu, 2021-01-28 at 18:55 +0200, Andy Shevchenko wrote: ... > > > Sadly this doesn't seem to

[PATCH 1/1] tools: add mkeficapsule to .gitignore

2021-01-28 Thread Heinrich Schuchardt
mkeficapsule is a build product. Add it to .gitignore Signed-off-by: Heinrich Schuchardt --- tools/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/.gitignore b/tools/.gitignore index a021ea95cd..a88453f64d 100644 --- a/tools/.gitignore +++ b/tools/.gitignore @@ -20,6 +20,7

Re: [PATCH v1] usb: kbd: destroy device after console is stopped

2021-01-28 Thread Tom Rini
On Thu, Jan 28, 2021 at 10:35:37PM +0200, Andy Shevchenko wrote: > On Thu, Jan 28, 2021 at 06:19:56PM +0100, Nicolas Saenz Julienne wrote: > > Hi Andy, > > > > On Thu, 2021-01-28 at 18:55 +0200, Andy Shevchenko wrote: > > > In case of IOMUX enabled it assumes that console devices in the list > >

Re: [PATCH v1] usb: kbd: destroy device after console is stopped

2021-01-28 Thread Andy Shevchenko
On Thu, Jan 28, 2021 at 06:19:56PM +0100, Nicolas Saenz Julienne wrote: > Hi Andy, > > On Thu, 2021-01-28 at 18:55 +0200, Andy Shevchenko wrote: > > In case of IOMUX enabled it assumes that console devices in the list > > are available to get them stopped properly via ->stop() callback. > >

[PATCH v3] arm: fsl: common: Improve NXP VID driver PMBus support

2021-01-28 Thread Stephen Carlson
This patch adds support for more PMBus compatible devices to the NXP drivers for its QorIQ family devices. At runtime, the voltage regulator is queried over I2C, and the required voltage multiplier determined. This change supports the DIRECT and LINEAR PMBus voltage reporting modes. Previously,

[PATCH] test: Update test_fs to not use deprecated pytest.yield_fixture()

2021-01-28 Thread Tom Rini
As noted in comments, yield_fixture has been deprecated for longer than our minimum required version of pytest. Newer versions of pytest cause this to be a louder warning, and as the migration is trivial, perform it now. Signed-off-by: Tom Rini --- test/py/tests/test_fs/conftest.py | 15

Re: [PATCH] env: Fix warning when forcing environment without ENV_ACCESS_IGNORE_FORCE

2021-01-28 Thread Fuzzey, Martin
Hi Marek, On Thu, 28 Jan 2021 at 20:07, Marek Vasut wrote: > > Based on env/Kconfig description of this option: > > config ENV_ACCESS_IGNORE_FORCE > bool "Block forced environment operations" > default n > help >If defined, don't allow the -f switch to env

Re: [PATCH] test: correct entry point to pytest

2021-01-28 Thread Andy Shevchenko
On Thu, Jan 28, 2021 at 1:46 PM Heinrich Schuchardt wrote: > > With Pytest 6.0.2 'make tests' fails: > > sandbox: Traceback (most recent call last): > File "./test/py/test.py", line 20, in > sys.exit(load_entry_point('pytest', 'console_scripts', 'pytest')(args)) > TypeError: console_main()

Re: [PATCH] env: Fix warning when forcing environment without ENV_ACCESS_IGNORE_FORCE

2021-01-28 Thread Tom Rini
On Thu, Jan 28, 2021 at 08:07:54PM +0100, Marek Vasut wrote: > On 1/11/21 11:27 AM, Martin Fuzzey wrote: > > Since commit 0f036bf4b87e ("env: Warn on force access if > > ENV_ACCESS_IGNORE_FORCE set") > > a warning message is displayed when setenv -f is used WITHOUT > >

Re: [RESEND PATCH v1 1/1] mmc: fix response timeout after switch command

2021-01-28 Thread Stefan Bosch
Hi, On 27.01.21 00:38, Jaehoon Chung wrote: Hi, On 1/23/21 9:37 PM, Stefan Bosch wrote: After issuing the switch command: Wait until 'current state' of the card status becomes 'tran'. This prevents from response timeout at the next command because of 'current state' = 'data'.> Signed-off-by:

Re: [PATCH] env: Fix warning when forcing environment without ENV_ACCESS_IGNORE_FORCE

2021-01-28 Thread Marek Vasut
On 1/11/21 11:27 AM, Martin Fuzzey wrote: Since commit 0f036bf4b87e ("env: Warn on force access if ENV_ACCESS_IGNORE_FORCE set") a warning message is displayed when setenv -f is used WITHOUT CONFIG_ENV_ACCESS_IGNORE_FORCE, but the variable is set anyway, resulting in lots of log pollution.

Re: [PATCH] env: Fix warning when forcing environment without ENV_ACCESS_IGNORE_FORCE

2021-01-28 Thread Marek Vasut
On 1/28/21 10:11 AM, Heinrich Schuchardt wrote: [...] diff --git a/env/flags.c b/env/flags.c index df4aed2..e3e833c 100644 --- a/env/flags.c +++ b/env/flags.c @@ -563,12 +563,13 @@ int env_flags_validate(const struct env_entry *item, const char *newval, Please, add a Sphinx style function

Re: [PATCH v1] usb: kbd: destroy device after console is stopped

2021-01-28 Thread Andy Shevchenko
On Thu, Jan 28, 2021 at 01:24:04PM -0500, Tom Rini wrote: > On Thu, Jan 28, 2021 at 08:18:47PM +0200, Andy Shevchenko wrote: > > On Thu, Jan 28, 2021 at 12:58:30PM -0500, Tom Rini wrote: > > > On Thu, Jan 28, 2021 at 07:52:36PM +0200, Andy Shevchenko wrote: > > > > On Thu, Jan 28, 2021 at

Re: [PATCH] test: correct entry point to pytest

2021-01-28 Thread Heinrich Schuchardt
On 1/28/21 5:17 PM, Tom Rini wrote: On Thu, Jan 28, 2021 at 02:28:03PM +0100, Heinrich Schuchardt wrote: On 28.01.21 13:58, Tom Rini wrote: On Thu, Jan 28, 2021 at 12:46:11PM +0100, Heinrich Schuchardt wrote: With Pytest 6.0.2 'make tests' fails: sandbox: Traceback (most recent call last):

Re: [PATCH v1] usb: kbd: destroy device after console is stopped

2021-01-28 Thread Tom Rini
On Thu, Jan 28, 2021 at 08:18:47PM +0200, Andy Shevchenko wrote: > On Thu, Jan 28, 2021 at 12:58:30PM -0500, Tom Rini wrote: > > On Thu, Jan 28, 2021 at 07:52:36PM +0200, Andy Shevchenko wrote: > > > On Thu, Jan 28, 2021 at 07:46:49PM +0200, Andy Shevchenko wrote: > > > > On Thu, Jan 28, 2021 at

Re: [PATCH] test: correct entry point to pytest

2021-01-28 Thread Andy Shevchenko
On Thu, Jan 28, 2021 at 1:46 PM Heinrich Schuchardt wrote: > > With Pytest 6.0.2 'make tests' fails: > > sandbox: Traceback (most recent call last): > File "./test/py/test.py", line 20, in > sys.exit(load_entry_point('pytest', 'console_scripts', 'pytest')(args)) > TypeError: console_main()

Re: [PATCH v1] usb: kbd: destroy device after console is stopped

2021-01-28 Thread Andy Shevchenko
On Thu, Jan 28, 2021 at 12:58:30PM -0500, Tom Rini wrote: > On Thu, Jan 28, 2021 at 07:52:36PM +0200, Andy Shevchenko wrote: > > On Thu, Jan 28, 2021 at 07:46:49PM +0200, Andy Shevchenko wrote: > > > On Thu, Jan 28, 2021 at 06:19:56PM +0100, Nicolas Saenz Julienne wrote: > > > > Hi Andy, > > > >

Re: [PATCH v1] usb: kbd: destroy device after console is stopped

2021-01-28 Thread Andy Shevchenko
On Thu, Jan 28, 2021 at 07:52:36PM +0200, Andy Shevchenko wrote: > On Thu, Jan 28, 2021 at 07:46:49PM +0200, Andy Shevchenko wrote: > > On Thu, Jan 28, 2021 at 06:19:56PM +0100, Nicolas Saenz Julienne wrote: > > > Hi Andy, > > > > > > On Thu, 2021-01-28 at 18:55 +0200, Andy Shevchenko wrote: > >

Re: [PATCH v1] usb: kbd: destroy device after console is stopped

2021-01-28 Thread Tom Rini
On Thu, Jan 28, 2021 at 07:52:36PM +0200, Andy Shevchenko wrote: > On Thu, Jan 28, 2021 at 07:46:49PM +0200, Andy Shevchenko wrote: > > On Thu, Jan 28, 2021 at 06:19:56PM +0100, Nicolas Saenz Julienne wrote: > > > Hi Andy, > > > > > > On Thu, 2021-01-28 at 18:55 +0200, Andy Shevchenko wrote: > >

Re: [PATCH v4 0/6] Add support for ECDSA image signing (with test)

2021-01-28 Thread Alex G.
On 1/28/21 10:40 AM, Patrick DELAUNAY wrote: Hi Alexandru, Hi Patrick I found in doc/uImage.FIT/signature.txt the description     - key-name-hint: Name of key to use for signing. The keys will normally be in a single directory (parameter -k to mkimage). [snip] You are correct that the

Re: [PATCH v1] usb: kbd: destroy device after console is stopped

2021-01-28 Thread Andy Shevchenko
On Thu, Jan 28, 2021 at 07:46:49PM +0200, Andy Shevchenko wrote: > On Thu, Jan 28, 2021 at 06:19:56PM +0100, Nicolas Saenz Julienne wrote: > > Hi Andy, > > > > On Thu, 2021-01-28 at 18:55 +0200, Andy Shevchenko wrote: > > > In case of IOMUX enabled it assumes that console devices in the list > >

[PATCH v1 5/7] sf protect (un)lock for SST26*: test BPR values

2021-01-28 Thread Bernhard Kirchen
after writing new block protection bits, read back the block protection bit register and test whether the desired settings were accepted. fail with error message otherwise. this adjusts the behavior of "sf protect (un)lock" for SST26* chips to be similar to the (un)locking behavior of

[PATCH v1 4/7] write WPEN bit for SST26* devices when locking

2021-01-28 Thread Bernhard Kirchen
"sf protect lock" did only protect against accidental writes by software. it did not lock down the config or block-protection registers if the WP# pin was deasserted. hardware write protection was never enabled for these devices. this change implements setting the WPEN bit and clearing the IOC

[PATCH v1 3/7] SST26* locking: need to enable write

2021-01-28 Thread Bernhard Kirchen
prior to using the WBPR (write block protection register) command to write new block protection register values, the WREN command must be sent. otherwise the new values are not applied. Signed-off-by: Bernhard Kirchen --- drivers/mtd/spi/spi-nor-core.c | 8 1 file changed, 8

[PATCH v1 1/7] command sf: help text format

2021-01-28 Thread Bernhard Kirchen
properly indent the help text and use single quotes consistently to mark variable parameters. Signed-off-by: Bernhard Kirchen --- cmd/sf.c | 48 ++-- 1 file changed, 22 insertions(+), 26 deletions(-) diff --git a/cmd/sf.c b/cmd/sf.c index

[PATCH v1 7/7] provide "sf protect check" command

2021-01-28 Thread Bernhard Kirchen
this change exposes checking the protection mechanism of SPI NOR flash chips to the CLI. it expands what was already there to communicate not only the protection state of a particular region, but also whether or not the hardware write protection mechanism of the chip is enabled. the new command

[PATCH v1 6/7] fix sst26_process_bpr check

2021-01-28 Thread Bernhard Kirchen
the sst26_process_bpr function is supposed to check whether a particular protection bit is set (write-lock active). the caller always returns with EACCES when sst26_process_bpr returns true. the previous implementation (double negation) causes the caller to abort checking protection bits when the

Re: [PATCH v1] usb: kbd: destroy device after console is stopped

2021-01-28 Thread Andy Shevchenko
On Thu, Jan 28, 2021 at 06:19:56PM +0100, Nicolas Saenz Julienne wrote: > Hi Andy, > > On Thu, 2021-01-28 at 18:55 +0200, Andy Shevchenko wrote: > > In case of IOMUX enabled it assumes that console devices in the list > > are available to get them stopped properly via ->stop() callback. > >

Re: [PATCH v1] usb: kbd: destroy device after console is stopped

2021-01-28 Thread Nicolas Saenz Julienne
Hi Andy, On Thu, 2021-01-28 at 18:55 +0200, Andy Shevchenko wrote: > In case of IOMUX enabled it assumes that console devices in the list > are available to get them stopped properly via ->stop() callback. > However, the USB keyboard driver violates this assumption and tries > to play tricks so

Re: [PATCH v2 0/2] Console/stdio use after free

2021-01-28 Thread Andy Shevchenko
On Thu, Jan 28, 2021 at 02:12:38PM +0100, Nicolas Saenz Julienne wrote: > With today's master, 70c2525c0d3c ('IOMUX: Stop dropped consoles') > introduces a use after free in usb_kbd_remove(): > > - usbkbd's stdio device is de-registered with stdio_deregister_dev(), > the struct stdio_dev is

[PATCH v1] usb: kbd: destroy device after console is stopped

2021-01-28 Thread Andy Shevchenko
In case of IOMUX enabled it assumes that console devices in the list are available to get them stopped properly via ->stop() callback. However, the USB keyboard driver violates this assumption and tries to play tricks so the device get destroyed while being listed as an active console. Swap the

Re: [PATCH v4 0/6] Add support for ECDSA image signing (with test)

2021-01-28 Thread Patrick DELAUNAY
Hi Alexandru, On 1/8/21 8:17 PM, Alexandru Gagniuc wrote: ## Purpose and intent > > The purpose of this series is to enable ECDSA as an alternative to > RSA for FIT signing. As new chips have built-in support for ECDSA > verified boot, it makes sense to stick to one signing algorithm, >

Re: [PATCH 05/30] doc: Document how sandbox_spl_tests are run

2021-01-28 Thread Heinrich Schuchardt
On 28.01.21 16:11, Simon Glass wrote: > Add a few notes about the sandbox_spl tests, since they are special. > > Signed-off-by: Simon Glass > --- > > doc/develop/testing.rst | 5 > doc/develop/tests_under.rst | 59 + > 2 files changed, 64

Re: [PATCH] env: Fix warning when forcing environment without ENV_ACCESS_IGNORE_FORCE

2021-01-28 Thread Tom Rini
On Fri, Jan 15, 2021 at 01:43:44PM -0500, Tom Rini wrote: > On Mon, Jan 11, 2021 at 11:27:20AM +0100, Martin Fuzzey wrote: > > > Since commit 0f036bf4b87e ("env: Warn on force access if > > ENV_ACCESS_IGNORE_FORCE set") > > a warning message is displayed when setenv -f is used WITHOUT > >

[PATCH v1 7/7] provide "sf protect check" command

2021-01-28 Thread Bernhard Kirchen
this change exposes checking the protection mechanism of SPI NOR flash chips to the CLI. it expands what was already there to communicate not only the protection state of a particular region, but also whether or not the hardware write protection mechanism of the chip is enabled. the new command

[PATCH v1 6/7] fix sst26_process_bpr check

2021-01-28 Thread Bernhard Kirchen
the sst26_process_bpr function is supposed to check whether a particular protection bit is set (write-lock active). the caller always returns with EACCES when sst26_process_bpr returns true. the previous implementation (double negation) causes the caller to abort checking protection bits when the

[PATCH v1 2/7] sf protect: warn about failed (un)lock operation

2021-01-28 Thread Bernhard Kirchen
it is not guaranteed that there is a human readable message when the lock or unlock operation failed. make sure there is a message emitted by the "sf protect" implementation if the subcommand failed. Signed-off-by: Bernhard Kirchen --- cmd/sf.c | 7 ++- 1 file changed, 6 insertions(+), 1

[PATCH v1 1/7] command sf: help text format

2021-01-28 Thread Bernhard Kirchen
properly indent the help text and use single quotes consistently to mark variable parameters. Signed-off-by: Bernhard Kirchen --- cmd/sf.c | 48 ++-- 1 file changed, 22 insertions(+), 26 deletions(-) diff --git a/cmd/sf.c b/cmd/sf.c index

[PATCH v1 0/7] fix and improve Micron/SST26* SPI NOR protection handling

2021-01-28 Thread Bernhard Kirchen
these patches improve the existing SPI NOR flash protection features by enabling hardware write protection where applicable, by fixing bugs, and by providing more information on the status of protection. this shall make using the protection feature more user-friendly and help meeting user

[PATCH v1 5/7] sf protect (un)lock for SST26*: test BPR values

2021-01-28 Thread Bernhard Kirchen
after writing new block protection bits, read back the block protection bit register and test whether the desired settings were accepted. fail with error message otherwise. this adjusts the behavior of "sf protect (un)lock" for SST26* chips to be similar to the (un)locking behavior of

[PATCH v1 4/7] write WPEN bit for SST26* devices when locking

2021-01-28 Thread Bernhard Kirchen
"sf protect lock" did only protect against accidental writes by software. it did not lock down the config or block-protection registers if the WP# pin was deasserted. hardware write protection was never enabled for these devices. this change implements setting the WPEN bit and clearing the IOC

[PATCH v1 3/7] SST26* locking: need to enable write

2021-01-28 Thread Bernhard Kirchen
prior to using the WBPR (write block protection register) command to write new block protection register values, the WREN command must be sent. otherwise the new values are not applied. Signed-off-by: Bernhard Kirchen --- drivers/mtd/spi/spi-nor-core.c | 8 1 file changed, 8

Re: [PATCH 02/30] doc: Document make tcheck

2021-01-28 Thread Heinrich Schuchardt
On 28.01.21 16:11, Simon Glass wrote: > Add a comment about this option in the documentation. Also mention the > script that runs these combinations. > > Signed-off-by: Simon Glass > --- > > doc/develop/testing.rst | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git

Re: [PATCH 01/30] doc: Tidy up testing section

2021-01-28 Thread Heinrich Schuchardt
On 28.01.21 16:11, Simon Glass wrote: > Tweak this so the output looks a little better. > > Signed-off-by: Simon Glass > --- > > doc/develop/testing.rst | 17 + > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/doc/develop/testing.rst b/doc/develop/testing.rst >

  1   2   3   >