[PATCH 2/2] buildman: Support single-threaded operation

2021-01-30 Thread Simon Glass
At present even if only a single thread is in use, buildman still uses threading. For some debugging it is helpful to do everything in the main process. Allow -T0 to support this. Signed-off-by: Simon Glass --- tools/buildman/README | 5 +++ tools/buildman/builder.py | 60

[PATCH 1/2] gitlab: Move the n900 test into its own section

2021-01-30 Thread Simon Glass
This test is not reliable. Quite often (20%?) it makes the build fail and a retry succeeds. Move it to the end so it does not cause the whole build to above. Signed-off-by: Simon Glass --- .gitlab-ci.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.gitlab-ci.yml

Re: Intermittent failure with test_efi_selftest_text_input

2021-01-30 Thread Simon Glass
Hi Heinrich and Bin, On Sat, 12 Sept 2020 at 14:15, Simon Glass wrote: > > Hi Heinrich, > > On Sat, 12 Sep 2020 at 14:11, Heinrich Schuchardt wrote: > > > > Am 12. September 2020 18:40:17 MESZ schrieb Simon Glass : > >> > >> Hi Heinrich, > >> > >> I am seeing a failure in gitlab every now and

Re: [PATCH 2/8] spl: fit: Factor out FIT parsing and use a context struct

2021-01-30 Thread Simon Glass
HI Alex, On Wed, 30 Dec 2020 at 19:57, Simon Glass wrote: > > Hi Alex, > > On Tue, 29 Dec 2020 at 17:07, Alex G. wrote: > > > > > > > > On 12/28/20 9:33 PM, Simon Glass wrote: > > > Hi Alex, > > > > > > On Mon, 21 Dec 2020 at 15:24, Alex G. wrote: > > >> > > >> > > >> > > >> On 12/21/20 2:23

Re: [PATCH 2/7] global_data.h: Change ram_top type to phys_addr_t

2021-01-30 Thread Simon Glass
Hi Bin, On Sat, 30 Jan 2021 at 20:40, Bin Meng wrote: > > Hi Simon, > > On Sun, Jan 31, 2021 at 12:24 AM Simon Glass wrote: > > > > Hi Bin, > > > > On Sat, 30 Jan 2021 at 03:14, Bin Meng wrote: > > > > > > Hi Simon, > > > > > > On Sat, Jan 30, 2021 at 1:48 AM Simon Glass wrote: > > > > > > >

Re: [PATCH 2/7] global_data.h: Change ram_top type to phys_addr_t

2021-01-30 Thread Bin Meng
Hi Simon, On Sun, Jan 31, 2021 at 12:24 AM Simon Glass wrote: > > Hi Bin, > > On Sat, 30 Jan 2021 at 03:14, Bin Meng wrote: > > > > Hi Simon, > > > > On Sat, Jan 30, 2021 at 1:48 AM Simon Glass wrote: > > > > > > Hi Bin, > > > > > > On Sat, 23 Jan 2021 at 19:03, Simon Glass wrote: > > > > > >

[PATCH v2 39/40] test: sandbox: Move sandbox test docs into doc/develop

2021-01-30 Thread Simon Glass
At present some of the documentation about running sandbox tests is in the sandbox docs. It makes more sense to put it in with the other testing docs, with a link there from sandbox. Update the documentation accordingly. Also add a paragraph explaining why sandbox exists and the test philosophy

[PATCH v2 40/40] doc: Explain briefly how to write new tests

2021-01-30 Thread Simon Glass
Add a second on writing tests, covering when to use Python and C, where to put the tests, etc. Add a link to the existing Python test documentation. Signed-off-by: Simon Glass --- Changes in v2: - Add new patches to cover running an SPL test doc/develop/index.rst | 1 +

[PATCH v2 37/40] doc: Move coccinelle into its own section

2021-01-30 Thread Simon Glass
This tool has nothing to do with testing. Create a new section for 'refactoring' and move it into there. It is likely that other topics may fall under the same heading, such as using moveconfig and search/replace tools. Signed-off-by: Simon Glass --- (no changes since v1)

[PATCH v2 38/40] spl: test: Add a test for spl_load_simple_fit()

2021-01-30 Thread Simon Glass
As an example of an SPL test, add a new test for loading a FIT within SPL. This runs on sandbox_spl. For this to work, the text base is adjusted so that there is plenty of space available. While we are here, document struct spl_load_info properly, since this is currently ambiguous. This test

[PATCH v2 34/40] test: Allow SPL to run any available test

2021-01-30 Thread Simon Glass
At present SPL only runs driver model tests. Update it to run all available tests, i.e. in any test suite. Signed-off-by: Simon Glass --- (no changes since v1) arch/sandbox/cpu/spl.c | 7 +-- include/test/test.h| 16 +--- test/dm/test-dm.c | 11 ++- 3 files

[PATCH v2 36/40] spl: Convert spl_fit to work with sandbox

2021-01-30 Thread Simon Glass
At present this casts addresses to pointers so cannot work with sandbox. Update the code to use map_sysmem() instead. As part of this change, the existing load_ptr is renamed to src_ptr since it is not a pointer to load_addr. It is confusing to use a similar name for something that is not

[PATCH v2 35/40] sandbox: Update os_find_u_boot() to find the .img file

2021-01-30 Thread Simon Glass
At present this function can only locate the u-boot ELF file. For SPL it is handy to be able to locate u-boot.img since this is what would normally be loaded by SPL. Add another argument to allow this to be selected. While we are here, update the function to load SPL when running in TPL, since

[PATCH v2 33/40] test: Rename all linker lists to have a ut_ prefix

2021-01-30 Thread Simon Glass
At present each test suite has its own portion of the linker_list section of the image, but other lists are interspersed. This makes it hard to enumerate all the available tests without knowing the suites that each one is in. Place all tests together in a single contiguous list by giving them

[PATCH v2 31/40] test: log: Rename log main test file to log_ut.c

2021-01-30 Thread Simon Glass
The current name is the same as the main test runner file. Rename it to avoid confusion. Signed-off-by: Simon Glass --- (no changes since v1) test/log/Makefile | 2 +- test/log/{test-main.c => log_ut.c} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename

[PATCH v2 32/40] test: Add a macros for finding tests in linker_lists

2021-01-30 Thread Simon Glass
At present we use the linker list directly. This is not very friendly, so add a helpful macro instead. This will also allow us to change the naming later without updating this code. Signed-off-by: Simon Glass --- (no changes since v1) include/test/test.h | 6 ++ test/bloblist.c

[PATCH v2 30/40] test: Move restoring of driver model state to ut_run_list()

2021-01-30 Thread Simon Glass
Add this functionality to ut_run_list() so it can be removed from dm_test_run(). At this point all tests are run through ut_run_list(). Signed-off-by: Simon Glass --- (no changes since v1) test/dm/test-dm.c | 11 --- test/test-main.c | 30 +- 2 files

[PATCH v2 27/40] test: Run driver-model tests using ut_run_list()

2021-01-30 Thread Simon Glass
Use this function instead of implementing it separately for driver model. Make ut_run_tests() private since it is only used in test-main.c Signed-off-by: Simon Glass --- Changes in v2: - Allow for prefix to be NULL, to match function comment include/test/ut.h | 42 ---

[PATCH v2 29/40] test: Move the devicetree check into ut_run_list()

2021-01-30 Thread Simon Glass
Add a check to ut_run_list() as to whether a list has driver model tests. Move the logic for the test devicetree into that function, in an effort to eventually remove all logic from dm_test_run(). Signed-off-by: Simon Glass --- (no changes since v1) test/dm/test-dm.c | 13 -

[PATCH v2 28/40] test: Use return values in dm_test_run()

2021-01-30 Thread Simon Glass
Update this function to use the return value of ut_run_list() to check for success/failure, so that they are in sync. Also return a command success code so that the caller gets what it expects. Signed-off-by: Simon Glass --- (no changes since v1) test/dm/test-dm.c | 14 ++ 1 file

[PATCH v2 26/40] test: Use a local variable for test state

2021-01-30 Thread Simon Glass
At present we use a global test state for all driver-model tests. Make use of a local struct like we do with the other tests. To make this work, add functions to get and set this state. When a test starts, the state is set (so it can be used in the test). When a test finishes, the state is unset,

[PATCH v2 25/40] test: Add ut_run_test_live_flat() to run tests twice

2021-01-30 Thread Simon Glass
Driver model tests are generally run twice, once with livetree enable and again with it disabled. Add a function to handle this and call it from the driver model test runner. Make ut_run_test() private since it is not used outside test-main.c now. Signed-off-by: Simon Glass --- Changes in v2:

[PATCH v2 24/40] test: Drop dm_do_test()

2021-01-30 Thread Simon Glass
In an effort to make use of a common test runner, use ut_run_test() directly to run driver model tests. Signed-off-by: Simon Glass --- (no changes since v1) test/dm/test-dm.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/test/dm/test-dm.c

[PATCH v2 21/40] test: Move dm_test_destroy() into test-main.c

2021-01-30 Thread Simon Glass
Move this function into the common test runner and rename it to dm_test_post_run() so that its purpose is clear. Signed-off-by: Simon Glass --- (no changes since v1) test/dm/test-dm.c | 22 -- test/test-main.c | 23 +++ 2 files changed, 23

[PATCH v2 23/40] test: Use ut_run_test() to run driver model tests

2021-01-30 Thread Simon Glass
Instead of having a separate function for running driver model tests, use the common one. Make the pre/post-run functions private since we don't need these outside of test-main.c Signed-off-by: Simon Glass --- (no changes since v1) include/test/ut.h | 20

[PATCH v2 22/40] test: Move test running into a separate function

2021-01-30 Thread Simon Glass
Add a function to handle the preparation for running a test and the post-test clean-up. Signed-off-by: Simon Glass --- (no changes since v1) include/test/ut.h | 16 test/test-main.c | 32 +++- 2 files changed, 39 insertions(+), 9 deletions(-)

[PATCH v2 20/40] test: Move dm_test_init() into test-main.c

2021-01-30 Thread Simon Glass
Move this function into test-main so that all the init is in one place. Rename it so that its purpose is clearer. Signed-off-by: Simon Glass --- (no changes since v1) include/test/ut.h | 9 - test/dm/test-dm.c | 22 -- test/test-main.c | 33

[PATCH v2 19/40] test: Drop struct dm_test_state

2021-01-30 Thread Simon Glass
Driver model is a core part of U-Boot. We don't really need to have a separate test structure for the driver model tests and it makes it harder to write a test if you have to think about which type of test it is. Subsume the fields from struct dm_test_state into struct unit_test_state and delete

[PATCH v2 18/40] test: Handle driver model reinit in test_pre_run()

2021-01-30 Thread Simon Glass
For driver model tests we want to reinit the data structures so that everything is in a known state before the test runs. This avoids one test changing something that breaks a subsequent tests. Move the call for this into test_pre_run(). Signed-off-by: Simon Glass --- (no changes since v1)

[PATCH v2 17/40] test: Move delay skipping to test_pre_run()

2021-01-30 Thread Simon Glass
This allows delays to be skipped in sandbox tests. Move it to the common pre-init function. Signed-off-by: Simon Glass --- (no changes since v1) include/test/ut.h | 11 +++ test/dm/test-dm.c | 2 -- test/test-main.c | 2 ++ test/ut.c | 7 +++ 4 files changed, 20

[PATCH v2 15/40] test: Drop mallinfo() work-around

2021-01-30 Thread Simon Glass
This is not needed now. Drop it. Signed-off-by: Simon Glass --- (no changes since v1) test/dm/test-dm.c | 2 -- test/test-main.c | 4 +--- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/test/dm/test-dm.c b/test/dm/test-dm.c index 65b89dbb936..57785e503ff 100644 ---

[PATCH v2 12/40] test: Move dm_extended_scan() to test_pre_run()

2021-01-30 Thread Simon Glass
Move this step over to the pre-run function. Signed-off-by: Simon Glass --- (no changes since v1) test/dm/test-dm.c | 3 --- test/test-main.c | 7 +++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/test/dm/test-dm.c b/test/dm/test-dm.c index 3b1460327ad..3f9ce3d6fa8

[PATCH v2 16/40] test: Move console silencing to test_pre_run()

2021-01-30 Thread Simon Glass
We already have a function for silencing the console during tests. Use this from test_pre_run() and drop this code from the driver model tests. Signed-off-by: Simon Glass --- (no changes since v1) test/dm/test-dm.c | 4 test/test-main.c | 3 ++- 2 files changed, 2 insertions(+), 5

[PATCH v2 14/40] test: Move dm_scan_plat() to test_pre_run()

2021-01-30 Thread Simon Glass
Move this step over to the pre-run function. Signed-off-by: Simon Glass --- (no changes since v1) test/dm/test-dm.c | 2 -- test/test-main.c | 3 +++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/test/dm/test-dm.c b/test/dm/test-dm.c index 3f76a1dc2c2..65b89dbb936 100644 ---

[PATCH v2 13/40] test: Move do_autoprobe() to test_pre_run()

2021-01-30 Thread Simon Glass
Move this step over to the pre-run function. Signed-off-by: Simon Glass --- (no changes since v1) test/dm/test-dm.c | 17 - test/test-main.c | 18 ++ 2 files changed, 18 insertions(+), 17 deletions(-) diff --git a/test/dm/test-dm.c b/test/dm/test-dm.c index

[PATCH v2 11/40] test: Call test_pre/post_run() from driver model tests

2021-01-30 Thread Simon Glass
Ultimately we want to get rid of the special driver model test init and use test_pre_run() and test_post_run() for all tests. As a first step, use those function to handle console recording. For now we need a special case for setting uts->start, but that wil go away once all init is in one place.

[PATCH v2 10/40] test: Create pre/post-run functions

2021-01-30 Thread Simon Glass
Split out the test preparation into a separation function before expanding it. Add a post-run function as well, currently empty. Signed-off-by: Simon Glass --- (no changes since v1) include/test/ut.h | 20 test/test-main.c | 41 +++--

[PATCH v2 09/40] test: Add an overall test runner

2021-01-30 Thread Simon Glass
Add a new test runner that will eventually be able to run any test. For now, have it run the 'command' unit tests, so that the functionality in cmd_ut_category() moves into it. Signed-off-by: Simon Glass --- (no changes since v1) include/test/ut.h | 42 ++

[PATCH v2 08/40] test: Rename test-main.c to test-dm.c

2021-01-30 Thread Simon Glass
This is the main test function for driver model but not for other tests. Rename the file and the function so this is clear. Signed-off-by: Simon Glass --- (no changes since v1) arch/sandbox/cpu/spl.c | 2 +- include/test/test.h| 4 ++-- test/dm/Makefile

[PATCH v2 07/40] test: Mark all driver model tests with a flag

2021-01-30 Thread Simon Glass
Add a flag for driver model tests, so we can do special processing for them. Signed-off-by: Simon Glass --- (no changes since v1) include/dm/test.h | 3 ++- include/test/test.h | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/include/dm/test.h b/include/dm/test.h index

[PATCH v2 06/40] test: Correct setexpr test prefix

2021-01-30 Thread Simon Glass
This prefix should be for setexpr, not mem. This means that trying to select just these tests to run does not work. Fix it. For some reason this provokes an assertion failure due to memory not being freed. Move the env_set() in setexpr_test_str() to before the malloc() heap size size is recorded

[PATCH v2 05/40] doc: Document how sandbox_spl_tests are run

2021-01-30 Thread Simon Glass
Add a few notes about the sandbox_spl tests, since they are special. Signed-off-by: Simon Glass --- Changes in v2: - Add a note that SPL tests can in fact be run individualy - Document how to run all C tests with 'ut all' - Fix 'get list' typo doc/develop/testing.rst | 5 +++

[PATCH v2 04/40] doc: Explain how to run tests without pytest

2021-01-30 Thread Simon Glass
Add details about how to run a sandbox test directly, without using pytest. This is more convenient for rapid development, since it is faster and allows easier use of a debugger. Also mention sandbox_flattree as an example of the different sandbox builds available. Signed-off-by: Simon Glass ---

[PATCH v2 03/40] sandbox: Drop the 'starting...' message unless testing

2021-01-30 Thread Simon Glass
This message is annoying since it is only useful for testing. Add a flag to control whether it is emitted or not, so it can be supressed by default. Signed-off-by: Simon Glass --- (no changes since v1) arch/sandbox/cpu/start.c | 15 +-- arch/sandbox/include/asm/state.h |

[PATCH v2 02/40] doc: Document make tcheck

2021-01-30 Thread Simon Glass
Add a comment about this option in the documentation. Also mention the script that runs these combinations. Signed-off-by: Simon Glass --- Changes in v2: - Expand docs on how each type of test is marked doc/develop/testing.rst | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-)

[PATCH v2 01/40] doc: Tidy up testing section

2021-01-30 Thread Simon Glass
Tweak this so the output looks a little better. Signed-off-by: Simon Glass --- Changes in v2: - Use correct rst format for 'Ad-hoc tests' section doc/develop/testing.rst | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/doc/develop/testing.rst

[PATCH v2 00/40] test: Refactor tests to have a single test runner

2021-01-30 Thread Simon Glass
At present U-Boot has two broad sets of tests in the C code: driver model tests which do a lot of pre-/post-init and command tests which do not. This separation makes it slightly harder to write a test, since there are two different test-state structures and different rules for running the two

Please pull u-boot-dm

2021-01-30 Thread Simon Glass
Hi Tom, https://gitlab.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/6139 The following changes since commit 472a716b8fdfd88a27cb675e4ea8e12cb4f79fc3: configs: Resync with savedefconfig (2021-01-29 13:56:04 -0500) are available in the Git repository at: git://git.denx.de/u-boot-dm.git

[PATCH] test/py: support pytest 6

2021-01-30 Thread Stephen Warren
Two changes are needed to support pytest 6: 1) The main entry point no longer allows command-line arguments to be supplied. Instead, we must modify sys.argv before calling the entry point. pytest 5.1.2 (from the current requirements.txt) supports either modifying sys.argv, or passing arguments,

[PATCH 4/4] fs: fat: remove trailing periods from long name

2021-01-30 Thread Heinrich Schuchardt
The FAT32 File System Specification [1] requires leading and trailing spaces as well as trailing periods of long names to be ignored. This renders a test for '.' and '..' as file name superfluous. But we must check that the resulting name has at least one character. [1] Microsoft Extensible

[PATCH 3/4] fs: fat: carve out fat_create_dir_entry()

2021-01-30 Thread Heinrich Schuchardt
fat_mkdir() and file_fat_write_at() use identical code to create a new directory entry. Carve out a new function fat_create_dir_entry() to avoid this code duplication. Signed-off-by: Heinrich Schuchardt --- fs/fat/fat_write.c | 93 -- 1 file changed,

[PATCH 2/4] fs: fat: must not write directory '.' and '..'

2021-01-30 Thread Heinrich Schuchardt
Directories or files called '.' or '..' cannot be created or written to in any directory. Move the test to normalize_longname() to check this early. Signed-off-by: Heinrich Schuchardt --- fs/fat/fat_write.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git

[PATCH 1/4] fs: fat: usage basename in file_fat_write_at, fat_mkdir

2021-01-30 Thread Heinrich Schuchardt
This patch involves no functional change. It is just about code readability. Both in file_fat_write_at() and fat_mkdir() the incoming file or directory path are split into two parts: the parent directory and the base name. In file_fat_write_at() the value of the variable basename is assigned to

[PATCH 0/4] fs: fat: code clean up

2021-01-30 Thread Heinrich Schuchardt
With the series paths with trailing periods like '/foo/a...' do no lead to creating files and directories with invalid names. Duplicate code is carved out into a new function. Patch 1/4 is resent to indicate import sequence. Heinrich Schuchardt (4): fs: fat: usage basename in

Re: [PATCH] test/py: support pytest 6

2021-01-30 Thread Heinrich Schuchardt
On 1/30/21 11:19 PM, Heinrich Schuchardt wrote: Am 30. Januar 2021 22:05:44 MEZ schrieb Stephen Warren : Two changes are needed to support pytest 6: 1) The main entry point no longer allows command-line arguments to be supplied. Instead, we must modify sys.argv before calling the entry point.

Re: [PATCH] test/py: support pytest 6

2021-01-30 Thread Heinrich Schuchardt
Am 30. Januar 2021 22:05:44 MEZ schrieb Stephen Warren : >Two changes are needed to support pytest 6: > >1) The main entry point no longer allows command-line arguments to be >supplied. Instead, we must modify sys.argv before calling the entry >point. pytest 5.1.2 (from the current

[PATCH v2] armv8: Handle EL2 Host mode

2021-01-30 Thread Mark Kettenis
On implementations that support VHE, the layout of the CPTR_EL2 register depends on whether HCR_EL2.E2H is set. Check this bit and and set the aprropriate bits to enable access to the FP/SIMD registers. This allows U-Boot to run on systems that pass control to U-Boot in EL2 with EL2 Host mode

Re: [PATCH 05/11] dm: core: Don't inline dev_read...() calls with of-platdata

2021-01-30 Thread Simon Glass
At present if these calls are used with of-platdata, a confusing error is produced, referring to a function not actually called by the code causing the problem. Fix this by not inlining, so that the error mentions the dev_read_...() function and it is more obvious what is going on.

Re: [PATCH 07/11] clk: x86: Correct the driver name

2021-01-30 Thread Simon Glass
The current driver name does not match its compatible string, so of-platdata does not work correctly. Fix it. Signed-off-by: Simon Glass --- drivers/clk/intel/clk_intel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH 08/11] dm: core: Add a comment about pinctrl_select_state()

2021-01-30 Thread Simon Glass
The use of pinctrl in the core of driver model is useful but can provoke some strange behaviour. Add a comment to aid debugging. Signed-off-by: Simon Glass --- drivers/core/device.c | 9 + 1 file changed, 9 insertions(+) Applied to u-boot-dm, thanks!

Re: [PATCH 04/11] sandbox: Disable I2C emulators in SPL

2021-01-30 Thread Simon Glass
Hello Simon, Am 21.01.21 um 21:57 schrieb Simon Glass: > These cannot work with of-platdata since they currently need the > devicetree at runtime. Disable the emulators and the sandbox I2C driver > that needs them. We can enable these later, if needed for testing. > > Switch the of_plat_parent

Re: [PATCH] do not pass NULL pointer to libfdt

2021-01-30 Thread Simon Glass
Re-send because of line-wraps. Without this patch, u-boot just hangs if the fdt pointer is not initialized. The diagnostic subsystems are not yet initialized, so all you get is a blind hang. Signed-off-by: stanislav.pinc...@kaspersky.com --- include/dm/read.h | 2 +- 1 file changed, 1

Re: [PATCH 1/1] sandbox: keep time offset when resetting

2021-01-30 Thread Simon Glass
Hi Heinrich, On Thu, 21 Jan 2021 at 02:19, Heinrich Schuchardt wrote: > > On 07.01.21 13:35, Simon Glass wrote: > > Hi Heinrich, > > > > On Wed, 30 Dec 2020 at 10:07, Heinrich Schuchardt > > wrote: > >> > >> The UEFI Self Certification Test (SCT) checks the SetTime() service with > >> the

Re: [PATCH 01/11] spl: Tidy up SPL/TPL malloc sizes

2021-01-30 Thread Simon Glass
The current help talks about relocation which doesn't apply to SPL and TPL. Update it to avoid confusion. Also make the TPL size default to the same as the SPL size, since this is more likely to be a useful value than the one used by U-Boot proper, which may be quite a bit larger. Signed-off-by:

Re: [PATCH v5] net: tftp: Add client support for RFC 7440

2021-01-30 Thread Ramon Fried
On Sat, Jan 30, 2021 at 10:39 PM Suneel Garapati wrote: > > Hello Ramon, > > With TFTP window size as default 1 and enabling TFTPPUT config option > results in tftpboot command failure. > > Attached the pcap files for with and without TFTPPUT enabled. > Both captures are the same except that the

Re: [PATCH 02/11] x86: coral: Support TPM and RTC in SPL

2021-01-30 Thread Simon Glass
Update the devicetree so that the TPM and RTC can be used in SPL. Also enable the pins used for getting the memory configuration settings while we are here. Signed-off-by: Simon Glass --- arch/x86/dts/chromebook_coral.dts| 20 +++-

Re: [PATCH 03/11] i2c: desigware: Add an alias for Intel Apollo Lake

2021-01-30 Thread Simon Glass
Hello Simon, Am 21.01.21 um 21:57 schrieb Simon Glass: > Add an alias so that this driver can be used in TPL on coral. > > Signed-off-by: Simon Glass > --- > > drivers/i2c/designware_i2c_pci.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Heiko Schocher bye, Heiko -- DENX Software

Re: [PATCH 06/11] clk: Add debugging for return values

2021-01-30 Thread Simon Glass
Use the log_msg_ret() mechanism to get error-return information when clocks fail to probe, etc. Signed-off-by: Simon Glass --- drivers/clk/clk-uclass.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH 10/11] Add a symlink for ctype.h

2021-01-30 Thread Simon Glass
Libraries that link with U-Boot typically may expect to be able to include ctype.h but this file is in a different place in U-Boot. Add a symlink to make this work. Signed-off-by: Simon Glass --- include/ctype.h | 1 + 1 file changed, 1 insertion(+) create mode 12 include/ctype.h Applied

Re: [PATCH 11/11] binman: Print a debug message when binman selects a node

2021-01-30 Thread Simon Glass
Add some debugging to indicate which node the binman library is looking at. Signed-off-by: Simon Glass --- lib/binman.c | 2 ++ 1 file changed, 2 insertions(+) Applied to u-boot-dm, thanks!

Re: [PATCH] dm: replace auto_alloc_size with auto

2021-01-30 Thread Simon Glass
On Sat, 23 Jan 2021 at 11:49, Dario Binacchi wrote: > > The auto_alloc_size members of struct driver has been renamed auto. > > Signed-off-by: Dario Binacchi > --- > > include/dm/device.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Simon Glass Applied to u-boot-dm,

Re: [PATCH 1/2] sandbox: fill block device meta information

2021-01-30 Thread Simon Glass
Provide information about host backed block device. Mark the device created by 'host bind' as removable. Signed-off-by: Heinrich Schuchardt --- drivers/block/sandbox.c | 11 +++ 1 file changed, 11 insertions(+) Applied to u-boot-dm, thanks!

Re: [PATCH 2/2] disk: part: sandbox support in dev_print()

2021-01-30 Thread Simon Glass
Commands like 'fatinfo' call dev_print() to print device information. If the block device is created via 'host bind', we should print accurate information. Signed-off-by: Heinrich Schuchardt --- disk/part.c | 1 + 1 file changed, 1 insertion(+) Applied to u-boot-dm, thanks!

Re: [PATCH 1/4] Respect that some compression algos can be enabled separately for SPL

2021-01-30 Thread Stefano Babic
Hi everybody, On 27.01.21 14:19, Stefano Babic wrote: On 27.01.21 08:57, Frieder Schrempf wrote: On 26.01.21 18:53, Tim Harvey wrote: On Sat, Jan 23, 2021 at 4:39 AM Stefano Babic wrote: Hi Tim, there is a weird side effect with this patch, breaking m68k architecture. For some reason,

Re: [PATCH v5] net: tftp: Add client support for RFC 7440

2021-01-30 Thread Suneel Garapati
Hello Ramon, With TFTP window size as default 1 and enabling TFTPPUT config option results in tftpboot command failure. Attached the pcap files for with and without TFTPPUT enabled. Both captures are the same except that the TFTPPUT option enables ICMP handler and for the response from the

Pull request for UEFI sub-system for efi-2021-04-rc1-4

2021-01-30 Thread Heinrich Schuchardt
The following changes since commit 472a716b8fdfd88a27cb675e4ea8e12cb4f79fc3: configs: Resync with savedefconfig (2021-01-29 13:56:04 -0500) are available in the Git repository at: https://gitlab.denx.de/u-boot/custodians/u-boot-efi.git tags/efi-2021-04-rc1-4 for you to fetch changes up to

Re: [PATCH] test: Update test_fs to not use deprecated pytest.yield_fixture()

2021-01-30 Thread Tom Rini
On Thu, Jan 28, 2021 at 02:39:56PM -0500, Tom Rini wrote: > As noted in comments, yield_fixture has been deprecated for longer than > our minimum required version of pytest. Newer versions of pytest cause > this to be a louder warning, and as the migration is trivial, perform it > now. > >

Re: [PATCH] test: correct entry point to pytest

2021-01-30 Thread Tom Rini
On Thu, Jan 28, 2021 at 12:46:11PM +0100, Heinrich Schuchardt wrote: > With Pytest 6.0.2 'make tests' fails: > > sandbox: Traceback (most recent call last): > File "./test/py/test.py", line 20, in > sys.exit(load_entry_point('pytest', 'console_scripts', 'pytest')(args)) > TypeError:

Re: [PATCH 1/1] test: pr_cont_test.o depends on CONFIG_LOG=y

2021-01-30 Thread Tom Rini
On Wed, Jan 27, 2021 at 12:09:46PM +0100, Heinrich Schuchardt wrote: > Compiling wandboard_defconfig with CONFIG_UT_LOG=y leads to a build error: > > test/log/pr_cont_test.c: In function ‘log_test_pr_cont’: > test/log/pr_cont_test.c:28:14: error: > ‘gd_t’ {aka ‘volatile struct global_data’} has

Re: [PATCH] fs: btrfs: Select SHA256 in Kconfig

2021-01-30 Thread Tom Rini
On Wed, Jan 27, 2021 at 10:42:30AM +0100, matthias@kernel.org wrote: > From: Matthias Brugger > > Since commit 565a4147d17a ("fs: btrfs: Add more checksum algorithms") > btrfs uses the sha256 checksum algorithm. But Kconfig lacks to select > it. This leads to compilation errors: >

Re: [PATCH 1/1] fs: fat: remove superfluous assignments

2021-01-30 Thread Tom Rini
On Tue, Jan 26, 2021 at 12:14:14AM +0100, Heinrich Schuchardt wrote: > Do not assign a value to a variable if it is not used. > > Signed-off-by: Heinrich Schuchardt Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 1/1] fs: fat: avoid out of bounds access warning

2021-01-30 Thread Tom Rini
On Tue, Jan 26, 2021 at 12:04:19AM +0100, Heinrich Schuchardt wrote: > When copying short name plus extension refer to the encapsulating structure > and not to the short name element. > > Signed-off-by: Heinrich Schuchardt Applied to u-boot/master, thanks! -- Tom signature.asc Description:

Re: [PATCH 1/1] avb: AVB_VERIFY depends on MMC

2021-01-30 Thread Tom Rini
On Mon, Jan 25, 2021 at 12:17:57PM +0100, Heinrich Schuchardt wrote: > AVB Verified Boot uses functions related to MMC. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Igor Opaniuk Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH] vexpress_aemv8a: allow overriding BOOTCOMMAND

2021-01-30 Thread Tom Rini
On Wed, Jan 20, 2021 at 09:54:53PM +0300, Stanislav Pinchuk wrote: > Re-send because of line-wraps. > > This patch fixes the behaviour of the menuconfig's BOOTCOMMAND > setting. Which is just ignored without that patch on > vexpress_aemv8a platform. > > Signed-off-by:

Re: [PATCH,v2,2/2] arm: dts: enable MTK SPI NOR controller driver

2021-01-30 Thread Tom Rini
On Wed, Jan 20, 2021 at 03:31:34PM +0800, SkyLake Huang wrote: > From: "SkyLake.Huang" > > 1. Enable MTK SPI NOR controller driver on mt7622 & mt7629. > 2. Enable quad mode for read and single mode for write. > > Signed-off-by: SkyLake.Huang Applied to u-boot/master, thanks! -- Tom

Re: [PATCH,v2,1/2] spi: mtk_snor: add support for MTK SPI NOR controller

2021-01-30 Thread Tom Rini
On Wed, Jan 20, 2021 at 03:31:33PM +0800, SkyLake Huang wrote: > From: "SkyLake.Huang" > > This patch adds support for MTK SPI NOR controller, which you > can see on mt7622 & mt7629. > > 1. This controller is designed only for SPI NOR. We can't adjust > its bus clock dynamically. Set clock in

Re: [PATCH 1/1] cmd: add more implementation IDs to sbi command

2021-01-30 Thread Tom Rini
On Tue, Jan 19, 2021 at 07:44:45PM +, Heinrich Schuchardt wrote: > Additional SBI implementation IDs have been added to the upcoming > next version of the SBI specification. > > https://github.com/riscv/riscv-sbi-doc/blob/master/riscv-sbi.adoc > > Signed-off-by: Heinrich Schuchardt

Re: [PATCH] test: test_ofplatdata: Mark as sandbox specific

2021-01-30 Thread Tom Rini
On Tue, Jan 19, 2021 at 02:40:10PM -0500, Tom Rini wrote: > This test checks for output specific to the sandbox device tree, mark it > as sandbox specific. > > Signed-off-by: Tom Rini Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH 2/3] test: inconsistent string tests

2021-01-30 Thread Tom Rini
On Mon, Jan 18, 2021 at 12:17:34AM +0100, Heinrich Schuchardt wrote: > Excluding ut str in test/cmd_ut.c but compiling test/str_ut.c results in > failure of the Python test invoking the C unit tests as observed on > sipeed_riscv_smode_defconfig: > > FAILED

Re: [PATCH 1/3] test: inconsistent bootm tests

2021-01-30 Thread Tom Rini
On Mon, Jan 18, 2021 at 12:17:33AM +0100, Heinrich Schuchardt wrote: > Excluding ut bootm in test/cmd_ut.c but compiling test/bootm.c results in > failure of the Python test invoking the C unit tests as observed on > sipeed_riscv_smode_defconfig: > > FAILED

Re: [PATCH] env: sf: cosmetic: remove unnecessary space

2021-01-30 Thread Tom Rini
On Mon, Jan 04, 2021 at 02:41:31PM +0100, Patrick Delaunay wrote: > Remove the unnecessary space before the 2 "done:" labels > in env_sf_save(). > > Signed-off-by: Patrick Delaunay Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

[PATCH 2/2] callback: mmc: tmio: Add card detect polling callback

2021-01-30 Thread Marek Vasut
Implement callback for polling the card detect line. This way the driver automatically detects when a card was removed and sets the mmc system state for that particular slot to re-init the card on next use. Signed-off-by: Marek Vasut --- drivers/mmc/tmio-common.c | 15 +++

[PATCH 1/2] callback: Implement support for registering main loop callbacks

2021-01-30 Thread Marek Vasut
Add initial code for registering callbacks into the main loop. These callbacks should be quick asynchronous functions executed in the background, useful e.g. for polling SD card detect line or for running USB state machine. Signed-off-by: Marek Vasut --- common/cli_readline.c | 6 ++

[PATCH 5/5] ARM: rmobile: Enable NVMe support on RCar3

2021-01-30 Thread Marek Vasut
Enable support for PCIe NVMe devices. Signed-off-by: Marek Vasut --- configs/rcar3_salvator-x_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/rcar3_salvator-x_defconfig b/configs/rcar3_salvator-x_defconfig index 6109a23a31..f97276b98e 100644 ---

[PATCH 4/5] ARM: rmobile: Enable CONFIG_PCI_REGION_MULTI_ENTRY on RCar3

2021-01-30 Thread Marek Vasut
R-Car3 can have multiple regions of type memory in DT, enable CONFIG_PCI_REGION_MULTI_ENTRY to handle those instead of using just one of the memory regions. Signed-off-by: Marek Vasut --- configs/rcar3_salvator-x_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 3/5] pci: renesas: Fix BAR mapping on Gen3

2021-01-30 Thread Marek Vasut
Because the first PCIExAR(n) register is configured with the mapping, It is the second PCIExAR(n) register that must be written with 0, not the last one. Update the n from 4 to 1 to select the correct register. Signed-off-by: Marek Vasut Cc: Bin Meng Cc: Nobuhiro Iwamatsu ---

[PATCH 2/5] pci: renesas: Make map address and mask power of two on Gen3

2021-01-30 Thread Marek Vasut
Both the map address and mask must be power of two per documentation, adjust the code accordingly. Signed-off-by: Marek Vasut Cc: Bin Meng Cc: Nobuhiro Iwamatsu --- drivers/pci/pci-rcar-gen3.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git

[PATCH 1/5] pci: renesas: Add root bus handling on Gen3

2021-01-30 Thread Marek Vasut
Add code to access the PCIe root bus space and configure it. Signed-off-by: Marek Vasut Cc: Bin Meng Cc: Nobuhiro Iwamatsu --- drivers/pci/pci-rcar-gen3.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/pci/pci-rcar-gen3.c

[PATCH] nvme: Fix cache alignment

2021-01-30 Thread Marek Vasut
The various structures in the driver are already correcty padded and cache aligned in memory, however the cache operations are called on the structure sizes, which themselves might not be cache aligned. Add the necessary rounding to fix this, which permits the nvme to work on arm64.

Re: [PATCH 2/7] global_data.h: Change ram_top type to phys_addr_t

2021-01-30 Thread Simon Glass
Hi Bin, On Sat, 30 Jan 2021 at 03:14, Bin Meng wrote: > > Hi Simon, > > On Sat, Jan 30, 2021 at 1:48 AM Simon Glass wrote: > > > > Hi Bin, > > > > On Sat, 23 Jan 2021 at 19:03, Simon Glass wrote: > > > > > > On Thu, 21 Jan 2021 at 08:00, Bin Meng wrote: > > > > > > > > From: Bin Meng > > > >

  1   2   >