Re: [PATCH v2 18/19] video: sunxi: Add DW HDMI PHY driver

2021-03-07 Thread Jagan Teki
On Sun, Mar 7, 2021 at 1:25 AM Jernej Skrabec wrote: > > This commit adds standalone driver for DW HDMI PHY. It deprecates code > which is included in sunxi dw-hdmi platform driver. > > Signed-off-by: Jernej Skrabec > --- > arch/arm/mach-sunxi/Kconfig | 1 + >

Re: [PATCH u-boot 13/39] efi_loader: fix warning when linking with LTO

2021-03-07 Thread Bin Meng
On Sun, Mar 7, 2021 at 12:26 PM Marek Behún wrote: > > When linking with LTO, the compiler complains about type mismatch of > variables `__efi_runtime_start`, `__efi_runtime_stop`, > `__efi_runtime_rel_start` and `__efi_runtime_rel_stop`: > > include/efi_loader.h:218:21: warning: type of

Re: [PATCH u-boot 12/39] string: make memcpy() and memset() visible to fix LTO linking errors

2021-03-07 Thread Bin Meng
Hi Marek, On Sun, Mar 7, 2021 at 12:26 PM Marek Behún wrote: > > It seems that sometimes (happening on ARM64, for example with > turris_mox_defconfig) GCC, when linking with LTO, changes the symbol > names of some functions, for example lib/string.c's memcpy() function to > memcpy.isra.0. > >

Re: [PATCH u-boot 11/39] binman: declare symbols externally visible

2021-03-07 Thread Bin Meng
Hi Marek, On Sun, Mar 7, 2021 at 12:59 PM Marek Behun wrote: > > I forgot to drop this patch. It is not needed, please ignore it. > Why is this not needed anymore? Regards, Bin

Re: [PATCH u-boot 10/39] linker_lists: declare lists and entries as __ADDRESSABLE for LTO

2021-03-07 Thread Bin Meng
On Sun, Mar 7, 2021 at 12:26 PM Marek Behún wrote: > > Use the __ADDRESSABLE() macro to make entries and lists declared by > ll_entry_declare() and ll_entry_declare_list() addressable so that when > building with LTO the compiler does not optimize this data away. > > Signed-off-by: Marek Behún >

Re: [PATCH u-boot 08/39] linker_lists: prepare macros to avoid code repetition

2021-03-07 Thread Bin Meng
On Sun, Mar 7, 2021 at 12:26 PM Marek Behún wrote: > > Prepare private macros expanding to linker list entry symbol name and > declaration to avoid nasty code repetition in the next patch. > > We also avoid some code repetition in current code with these macros. > > Signed-off-by: Marek Behún >

Re: [PATCH u-boot v1.1 14.1/39] efi_loader: add macro for const EFI runtime data

2021-03-07 Thread Heinrich Schuchardt
On 3/8/21 8:01 AM, Marek Behún wrote: Add macro __efi_runtime_rodata, for const variables with similar purpose as those using __efi_runtime_data. Signed-off-by: Marek Behún --- include/efi_loader.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/efi_loader.h

Re: [PATCH u-boot 06/39] treewide: Convert macro and uses of __section(foo) to __section("foo")

2021-03-07 Thread Bin Meng
On Sun, Mar 7, 2021 at 12:26 PM Marek Behún wrote: > > This commit does the same thing as Linux commit 33def8498fdd. > > Use a more generic form for __section that requires quotes to avoid > complications with clang and gcc differences. > > Remove the quote operator # from compiler_attributes.h

Re: [PATCH u-boot 07/39] compiler.h: align the __ADDRESSABLE macro with Linux' version

2021-03-07 Thread Bin Meng
On Sun, Mar 7, 2021 at 12:26 PM Marek Behún wrote: > > Use UNIQUE_ID in the __ADDRESSABLE macro. > > Signed-off-by: Marek Behún > --- > include/linux/compiler.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/compiler.h b/include/linux/compiler.h > index

Re: [PATCH v5 08/10] mtd: spi-nor-core: Add Cypress manufacturer ID in set_4byte

2021-03-07 Thread Takahiro Kuwano
On 2/24/2021 9:11 PM, Pratyush Yadav wrote: > On 19/02/21 10:56AM, tkuw584...@gmail.com wrote: >> From: Takahiro Kuwano >> >> Cypress chips support SPINOR_OP_EN4B(B7h)/SPINOR_OP_EX4B(E9h) to > > The datasheet says the EN4B command is indeed B7h but EX4B is listed as > B8h. The command E9h is

Re: [PATCH u-boot 04/39] api: fix a potential serious bug caused by undef CONFIG_SYS_64BIT_LBA

2021-03-07 Thread Marek Behun
On Mon, 8 Mar 2021 15:09:51 +0800 Bin Meng wrote: > Hi Marek, > > On Sun, Mar 7, 2021 at 12:26 PM Marek Behún wrote: > > > > The api_public.h header file undefined macro CONFIG_SYS_64BIT_LBA. > > > > But api/api_storage.c includes this header before including part.h, > > causing the type of

Re: [PATCH v5 07/10] mtd: spi-nor-core: Add non-uniform erase for Spansion/Cypress

2021-03-07 Thread Takahiro Kuwano
Hi Pratyush, On 2/24/2021 9:05 PM, Pratyush Yadav wrote: > On 19/02/21 10:56AM, tkuw584...@gmail.com wrote: >> From: Takahiro Kuwano >> >> Some of Spansion/Cypress chips have overlaid 4KB sectors at top and/or >> bottom, depending on the device configuration, while U-Boot supports >> uniform

Re: [PATCH u-boot-dm 03/39] regmap: fix a serious pointer casting bug

2021-03-07 Thread Bin Meng
On Sun, Mar 7, 2021 at 12:26 PM Marek Behún wrote: > > There is a serious bug in regmap_read() and regmap_write() functions > where an uint pointer is cast to (void *) which is then cast to (u8 *), > (u16 *), (u32 *) or (u64 *), depending on register width of the map. > > For example given a

Re: [PATCH u-boot 04/39] api: fix a potential serious bug caused by undef CONFIG_SYS_64BIT_LBA

2021-03-07 Thread Bin Meng
Hi Marek, On Sun, Mar 7, 2021 at 12:26 PM Marek Behún wrote: > > The api_public.h header file undefined macro CONFIG_SYS_64BIT_LBA. > > But api/api_storage.c includes this header before including part.h, > causing the type of lbaint_t and subsequently the type signature of > blk_dread() and

Re: [PATCH u-boot-marvell 02/39] ddr: marvell: axp: fix array types have different bounds warning

2021-03-07 Thread Marek Behun
On Mon, 8 Mar 2021 07:58:30 +0100 Stefan Roese wrote: > Hi Marek, > > On 08.03.21 07:46, Marek Behun wrote: > > And BTW do you have time to test this series on some ARM boards? > > I can test this on the theadorable Armada XP board, which also uses > SPL. Do you have a git repo I should use?

[PATCH u-boot v1.1 14.2/39] lib: crc32: put the crc_table variable into efi_runtime_rodata section

2021-03-07 Thread Marek Behún
When compiling with LTO, the compiler fails with an error saying that `crc_table` causes a section type conflict with `efi_var_buf`. This is because both are declared to be in the same section (via macro `__efi_runtime_data`), but one is const while the other is not. Put this variable into the

[PATCH u-boot v1.1 14.1/39] efi_loader: add macro for const EFI runtime data

2021-03-07 Thread Marek Behún
Add macro __efi_runtime_rodata, for const variables with similar purpose as those using __efi_runtime_data. Signed-off-by: Marek Behún --- include/efi_loader.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/efi_loader.h b/include/efi_loader.h index a8281b3c95..b1e5d2e13e 100644

Re: [PATCH u-boot-marvell 02/39] ddr: marvell: axp: fix array types have different bounds warning

2021-03-07 Thread Stefan Roese
Hi Marek, On 08.03.21 07:46, Marek Behun wrote: And BTW do you have time to test this series on some ARM boards? I can test this on the theadorable Armada XP board, which also uses SPL. Do you have a git repo I should use? Or is the patch series from yesterday the "latest and greatest"?

Re: [PATCH v5 05/10] mtd: spi-nor-core: Add the ->ready() hook

2021-03-07 Thread Takahiro Kuwano
On 2/19/2021 6:57 PM, Pratyush Yadav wrote: > On 19/02/21 10:55AM, tkuw584...@gmail.com wrote: >> From: Takahiro Kuwano >> >> For dual/quad die package devices from Spansion/Cypress, the device's >> status needs to be checked by reading status registers in all dies, by >> using Read Any Register

Re: [PATCH u-boot-marvell 02/39] ddr: marvell: axp: fix array types have different bounds warning

2021-03-07 Thread Stefan Roese
On 08.03.21 07:45, Marek Behun wrote: Reviewed-by: Stefan Roese Thanks, Stefan. Do you want to merge this into your repo u-boot-marvell, or shall Tom merge this once this series is mature? AFAIU, your patch series touches many architectures / platforms. It' currently assigned to Tom in

Re: [PATCH u-boot-marvell 02/39] ddr: marvell: axp: fix array types have different bounds warning

2021-03-07 Thread Bin Meng
On Sun, Mar 7, 2021 at 12:26 PM Marek Behún wrote: > > The arrays `pbs_dq_mapping`, `div_ratio1to1` and `div_ratio2to1` have > different bounds declared in header files where these variables are also > defined from the ones declared in source files. > > This causes the compiler to complain (when

Re: [PATCH u-boot-marvell 01/39] ddr: marvell: axp: align signature of mv_xor_mem_init() with a38x

2021-03-07 Thread Bin Meng
On Sun, Mar 7, 2021 at 12:26 PM Marek Behún wrote: > > In arch/arm/mach-mvebu/dram.c we always include axp's xor.h for common > XOR definitions, regardless whether we compile for axp or a38x. > > But the declaration of this function has a different signature in axp's > xor.h from the one used in

Re: [PATCH u-boot-marvell 02/39] ddr: marvell: axp: fix array types have different bounds warning

2021-03-07 Thread Marek Behun
And BTW do you have time to test this series on some ARM boards?

Re: [PATCH u-boot-marvell 02/39] ddr: marvell: axp: fix array types have different bounds warning

2021-03-07 Thread Marek Behun
> Reviewed-by: Stefan Roese Thanks, Stefan. Do you want to merge this into your repo u-boot-marvell, or shall Tom merge this once this series is mature? Marek

Re: [PATCH u-boot-marvell 02/39] ddr: marvell: axp: fix array types have different bounds warning

2021-03-07 Thread Stefan Roese
On 07.03.21 05:25, Marek Behún wrote: The arrays `pbs_dq_mapping`, `div_ratio1to1` and `div_ratio2to1` have different bounds declared in header files where these variables are also defined from the ones declared in source files. This causes the compiler to complain (when building with LTO):

Re: [PATCH v3 3/5] board/Synology: Unify legacy kernel support

2021-03-07 Thread Stefan Roese
On 07.03.21 22:22, Phil Sutter wrote: Move the relevant bits from ds109.{c,h} into common/ and adjust the code to fit both DS109 and DS414. Moreover: * Introduce syno_board_id() which translates CONFIG_MACH_TYPE into the expected board ID tag value. * Properly initialize isusbhost, mac and

Re: [PATCH v3 2/5] configs: ds414: Enable XHCI_PCI by default

2021-03-07 Thread Stefan Roese
On 07.03.21 22:21, Phil Sutter wrote: With the recent fixes in pci_mvebu and xhci-pci drivers, the two rear USB3 ports are finally usable and accessing them no longer hangs the system. Signed-off-by: Phil Sutter Reviewed-by: Stefan Roese Thanks, Stefan

Re: [PATCH v2 2/5] configs: ds414: Enable XHCI_PCI by default

2021-03-07 Thread Stefan Roese
On 07.03.21 21:58, Phil Sutter wrote: On Sat, Mar 06, 2021 at 09:15:27AM +0100, Stefan Roese wrote: On 05.03.21 21:03, Phil Sutter wrote: With the recent fixes in pci_mvebu and xhci-pci drivers, the two rear USB3 ports are finally usable and accessing them no longer hangs the system. Moreover,

Re: [PATCH 4/5] pinctrl: K210_PINCTRL depends on REGMAP and on SYSCON

2021-03-07 Thread Leo Liang
On Thu, Mar 04, 2021 at 05:00:50PM +, Heinrich Schuchardt wrote: > Select missing Kconfig dependencies. > > Signed-off-by: Heinrich Schuchardt > --- > drivers/pinctrl/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig >

Re: [PATCH 2/5] cmd/sbi: use constants instead of numerical values

2021-03-07 Thread Leo Liang
On Thu, Mar 04, 2021 at 05:00:48PM +, Heinrich Schuchardt wrote: > Use constants for extension IDs. > > Signed-off-by: Heinrich Schuchardt > --- > cmd/riscv/sbi.c | 30 +++--- > 1 file changed, 15 insertions(+), 15 deletions(-) > > diff --git a/cmd/riscv/sbi.c

Re: [PATCH v5 1/2] gpio: i2c-gpio: Drop use of dm_gpio_set_dir()

2021-03-07 Thread Heiko Schocher
Hello Simon, On 08.03.21 04:45, Simon Glass wrote: > This is the only driver that uses this function. Update it to use the > alternative which is dm_gpio_set_dir_flags(). > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > drivers/i2c/i2c-gpio.c | 19 +-- > 1

Re: [PATCH v5 03/41] doc: Document make tcheck

2021-03-07 Thread Heinrich Schuchardt
Am 8. März 2021 01:34:39 MEZ schrieb Simon Glass : >Add a comment about this option in the documentation. Also mention the >script that runs these combinations. > >Signed-off-by: Simon Glass >--- > >(no changes since v2) > >Changes in v2: >- Expand docs on how each type of test is marked > >

[PATCH v5 2/2] gpio: Drop dm_gpio_set_dir()

2021-03-07 Thread Simon Glass
This function is not used. Drop it. Signed-off-by: Simon Glass Reviewed-by: Patrick Delaunay --- Changes in v5: - Drop patches previously applied drivers/gpio/gpio-uclass.c | 11 --- include/asm-generic/gpio.h | 11 --- 2 files changed, 22 deletions(-) diff --git

[PATCH v5 1/2] gpio: i2c-gpio: Drop use of dm_gpio_set_dir()

2021-03-07 Thread Simon Glass
This is the only driver that uses this function. Update it to use the alternative which is dm_gpio_set_dir_flags(). Signed-off-by: Simon Glass --- (no changes since v1) drivers/i2c/i2c-gpio.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git

[PATCH v5 0/2] gpio: Update and simplify the uclass API

2021-03-07 Thread Simon Glass
At present the GPIO uclass mirrors what was in U-Boot before driver model. It works well in most cases but is becoming cumbersome with things like pull-up/down and drive strength. In those cases it is easier for the driver to deal with all the flags at one, rather than piece by piece. In fact the

[PATCH] usb: ehci-hcd: Add IAA handshake for removing async QH

2021-03-07 Thread Ye Li
According to EHCI spec, software needs to do handshake with HC for safely removing QH from async list. This handshake is implemented by setting IAAD (Interrupt on Async Advance Doorbell) bit in USB_USBCMD register and poll the IAA (Interrupt on Async Advance bit) in the USB_USBSTS to ensure the HC

[PATCH v5 41/41] doc: Explain briefly how to write new tests

2021-03-07 Thread Simon Glass
Add a second on writing tests, covering when to use Python and C, where to put the tests, etc. Add a link to the existing Python test documentation. Signed-off-by: Simon Glass --- Changes in v5: - Mention UEFI tests - Update language to make it clear when sandbox is discussed - Update table

[PATCH v5 40/41] test: sandbox: Move sandbox test docs into doc/develop

2021-03-07 Thread Simon Glass
At present some of the documentation about running sandbox tests is in the sandbox docs. It makes more sense to put it in with the other testing docs, with a link there from sandbox. Update the documentation accordingly. Also add a paragraph explaining why sandbox exists and the test philosophy

[PATCH v5 39/41] spl: test: Add a test for spl_load_simple_fit()

2021-03-07 Thread Simon Glass
As an example of an SPL test, add a new test for loading a FIT within SPL. This runs on sandbox_spl. For this to work, the text base is adjusted so that there is plenty of space available. While we are here, document struct spl_load_info properly, since this is currently ambiguous. This test

[PATCH v5 38/41] spl: Convert spl_fit to work with sandbox

2021-03-07 Thread Simon Glass
At present this casts addresses to pointers so cannot work with sandbox. Update the code to use map_sysmem() instead. As part of this change, the existing load_ptr is renamed to src_ptr since it is not a pointer to load_addr. It is confusing to use a similar name for something that is not

[PATCH v5 37/41] sandbox: Update os_find_u_boot() to find the .img file

2021-03-07 Thread Simon Glass
At present this function can only locate the u-boot ELF file. For SPL it is handy to be able to locate u-boot.img since this is what would normally be loaded by SPL. Add another argument to allow this to be selected. While we are here, update the function to load SPL when running in TPL, since

[PATCH v5 35/41] test: Rename all linker lists to have a ut_ prefix

2021-03-07 Thread Simon Glass
At present each test suite has its own portion of the linker_list section of the image, but other lists are interspersed. This makes it hard to enumerate all the available tests without knowing the suites that each one is in. Place all tests together in a single contiguous list by giving them

[PATCH v5 34/41] test: Add a macros for finding tests in linker_lists

2021-03-07 Thread Simon Glass
At present we use the linker list directly. This is not very friendly, so add a helpful macro instead. This will also allow us to change the naming later without updating this code. Signed-off-by: Simon Glass --- (no changes since v1) include/test/test.h | 6 ++ test/bloblist.c

[PATCH v5 19/41] test: Move delay skipping to test_pre_run()

2021-03-07 Thread Simon Glass
This allows delays to be skipped in sandbox tests. Move it to the common pre-init function. Signed-off-by: Simon Glass --- (no changes since v1) include/test/ut.h | 11 +++ test/dm/test-dm.c | 2 -- test/test-main.c | 2 ++ test/ut.c | 7 +++ 4 files changed, 20

[PATCH v5 36/41] test: Allow SPL to run any available test

2021-03-07 Thread Simon Glass
At present SPL only runs driver model tests. Update it to run all available tests, i.e. in any test suite. Signed-off-by: Simon Glass --- (no changes since v1) arch/sandbox/cpu/spl.c | 7 +-- include/test/test.h| 16 +--- test/dm/test-dm.c | 11 ++-

[PATCH v5 33/41] test: log: Rename log main test file to log_ut.c

2021-03-07 Thread Simon Glass
The current name is the same as the main test runner file. Rename it to avoid confusion. Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt --- (no changes since v1) test/log/Makefile | 2 +- test/log/{test-main.c => log_ut.c} | 0 2 files changed, 1 insertion(+), 1

[PATCH v5 31/41] test: Move the devicetree check into ut_run_list()

2021-03-07 Thread Simon Glass
Add a check to ut_run_list() as to whether a list has driver model tests. Move the logic for the test devicetree into that function, in an effort to eventually remove all logic from dm_test_run(). Signed-off-by: Simon Glass --- (no changes since v1) test/dm/test-dm.c | 13 -

[PATCH v5 32/41] test: Move restoring of driver model state to ut_run_list()

2021-03-07 Thread Simon Glass
Add this functionality to ut_run_list() so it can be removed from dm_test_run(). At this point all tests are run through ut_run_list(). Signed-off-by: Simon Glass --- (no changes since v1) test/dm/test-dm.c | 11 --- test/test-main.c | 30 +- 2 files

[PATCH v5 29/41] test: Run driver-model tests using ut_run_list()

2021-03-07 Thread Simon Glass
Use this function instead of implementing it separately for driver model. Make ut_run_tests() private since it is only used in test-main.c Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Allow for prefix to be NULL, to match function comment include/test/ut.h | 42

[PATCH v5 28/41] test: Use a local variable for test state

2021-03-07 Thread Simon Glass
At present we use a global test state for all driver-model tests. Make use of a local struct like we do with the other tests. To make this work, add functions to get and set this state. When a test starts, the state is set (so it can be used in the test). When a test finishes, the state is unset,

[PATCH v5 30/41] test: Use return values in dm_test_run()

2021-03-07 Thread Simon Glass
Update this function to use the return value of ut_run_list() to check for success/failure, so that they are in sync. Also return a command success code so that the caller gets what it expects. Signed-off-by: Simon Glass --- (no changes since v1) test/dm/test-dm.c | 14 ++ 1 file

[PATCH v5 27/41] test: Add ut_run_test_live_flat() to run tests twice

2021-03-07 Thread Simon Glass
Driver model tests are generally run twice, once with livetree enable and again with it disabled. Add a function to handle this and call it from the driver model test runner. Make ut_run_test() private since it is not used outside test-main.c now. Signed-off-by: Simon Glass --- (no changes

[PATCH v5 26/41] test: Drop dm_do_test()

2021-03-07 Thread Simon Glass
In an effort to make use of a common test runner, use ut_run_test() directly to run driver model tests. Signed-off-by: Simon Glass --- (no changes since v1) test/dm/test-dm.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/test/dm/test-dm.c

[PATCH v5 22/41] test: Move dm_test_init() into test-main.c

2021-03-07 Thread Simon Glass
Move this function into test-main so that all the init is in one place. Rename it so that its purpose is clearer. Signed-off-by: Simon Glass --- (no changes since v1) include/test/ut.h | 9 - test/dm/test-dm.c | 22 -- test/test-main.c | 33

[PATCH v5 23/41] test: Move dm_test_destroy() into test-main.c

2021-03-07 Thread Simon Glass
Move this function into the common test runner and rename it to dm_test_post_run() so that its purpose is clear. Signed-off-by: Simon Glass --- (no changes since v1) test/dm/test-dm.c | 22 -- test/test-main.c | 23 +++ 2 files changed, 23

[PATCH v5 18/41] test: Move console silencing to test_pre_run()

2021-03-07 Thread Simon Glass
We already have a function for silencing the console during tests. Use this from test_pre_run() and drop this code from the driver model tests. Signed-off-by: Simon Glass --- (no changes since v1) test/dm/test-dm.c | 4 test/test-main.c | 3 ++- 2 files changed, 2 insertions(+), 5

[PATCH v5 25/41] test: Use ut_run_test() to run driver model tests

2021-03-07 Thread Simon Glass
Instead of having a separate function for running driver model tests, use the common one. Make the pre/post-run functions private since we don't need these outside of test-main.c Signed-off-by: Simon Glass --- (no changes since v1) include/test/ut.h | 20

[PATCH v5 24/41] test: Move test running into a separate function

2021-03-07 Thread Simon Glass
Add a function to handle the preparation for running a test and the post-test clean-up. Signed-off-by: Simon Glass --- (no changes since v1) include/test/ut.h | 16 test/test-main.c | 32 +++- 2 files changed, 39 insertions(+), 9 deletions(-)

[PATCH v5 21/41] test: Drop struct dm_test_state

2021-03-07 Thread Simon Glass
Driver model is a core part of U-Boot. We don't really need to have a separate test structure for the driver model tests and it makes it harder to write a test if you have to think about which type of test it is. Subsume the fields from struct dm_test_state into struct unit_test_state and delete

[PATCH v5 20/41] test: Handle driver model reinit in test_pre_run()

2021-03-07 Thread Simon Glass
For driver model tests we want to reinit the data structures so that everything is in a known state before the test runs. This avoids one test changing something that breaks a subsequent tests. Move the call for this into test_pre_run(). Signed-off-by: Simon Glass --- (no changes since v1)

[PATCH v5 13/41] test: Call test_pre/post_run() from driver model tests

2021-03-07 Thread Simon Glass
Ultimately we want to get rid of the special driver model test init and use test_pre_run() and test_post_run() for all tests. As a first step, use those function to handle console recording. For now we need a special case for setting uts->start, but that wil go away once all init is in one place.

[PATCH v5 14/41] test: Move dm_extended_scan() to test_pre_run()

2021-03-07 Thread Simon Glass
Move this step over to the pre-run function. Signed-off-by: Simon Glass --- (no changes since v1) test/dm/test-dm.c | 3 --- test/test-main.c | 7 +++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/test/dm/test-dm.c b/test/dm/test-dm.c index 69a0349d04c..4cb0da13b7c

[PATCH v5 11/41] test: Add an overall test runner

2021-03-07 Thread Simon Glass
Add a new test runner that will eventually be able to run any test. For now, have it run the 'command' unit tests, so that the functionality in cmd_ut_category() moves into it. Signed-off-by: Simon Glass --- (no changes since v1) include/test/ut.h | 42 ++

[PATCH v5 17/41] test: Drop mallinfo() work-around

2021-03-07 Thread Simon Glass
This is not needed now. Drop it. Signed-off-by: Simon Glass --- (no changes since v1) test/dm/test-dm.c | 2 -- test/test-main.c | 4 +--- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/test/dm/test-dm.c b/test/dm/test-dm.c index 18877c7ae56..d1d83e34782 100644 ---

[PATCH v5 15/41] test: Move do_autoprobe() to test_pre_run()

2021-03-07 Thread Simon Glass
Move this step over to the pre-run function. Signed-off-by: Simon Glass --- (no changes since v1) test/dm/test-dm.c | 17 - test/test-main.c | 18 ++ 2 files changed, 18 insertions(+), 17 deletions(-) diff --git a/test/dm/test-dm.c b/test/dm/test-dm.c index

[PATCH v5 16/41] test: Move dm_scan_plat() to test_pre_run()

2021-03-07 Thread Simon Glass
Move this step over to the pre-run function. Signed-off-by: Simon Glass --- (no changes since v1) test/dm/test-dm.c | 2 -- test/test-main.c | 3 +++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/test/dm/test-dm.c b/test/dm/test-dm.c index c2e1a1b9207..18877c7ae56 100644 ---

[PATCH v5 12/41] test: Create pre/post-run functions

2021-03-07 Thread Simon Glass
Split out the test preparation into a separation function before expanding it. Add a post-run function as well, currently empty. Signed-off-by: Simon Glass --- (no changes since v1) include/test/ut.h | 20 test/test-main.c | 41 +++--

[PATCH v5 08/41] test: Correct setexpr test prefix

2021-03-07 Thread Simon Glass
This prefix should be for setexpr, not mem. This means that trying to select just these tests to run does not work. Fix it. For some reason this provokes an assertion failure due to memory not being freed. Move the env_set() in setexpr_test_str() to before the malloc() heap size size is recorded

[PATCH v5 10/41] test: Rename test-main.c to test-dm.c

2021-03-07 Thread Simon Glass
This is the main test function for driver model but not for other tests. Rename the file and the function so this is clear. Signed-off-by: Simon Glass --- (no changes since v1) arch/sandbox/cpu/spl.c | 2 +- include/test/test.h| 4 ++-- test/dm/Makefile

[PATCH v5 07/41] doc: Document how sandbox_spl_tests are run

2021-03-07 Thread Simon Glass
Add a few notes about the sandbox_spl tests, since they are special. Signed-off-by: Simon Glass Acked-by: Pratyush Yadav --- (no changes since v4) Changes in v4: - Fix 'of-pldata' typo Changes in v3: - Reword the SPL tests section for clarity Changes in v2: - Add a note that SPL tests can

[PATCH v5 04/41] sandbox: Drop the 'starting...' message

2021-03-07 Thread Simon Glass
This message is annoying since it is only useful for testing. Drop it and update the test to cope. Signed-off-by: Simon Glass --- Changes in v5: - Update the test so we don't need a flag arch/sandbox/cpu/start.c | 1 - test/py/tests/test_log.py | 1 - 2 files changed, 2 deletions(-) diff

[PATCH v5 06/41] doc: Explain how to run tests without pytest

2021-03-07 Thread Simon Glass
Add details about how to run a sandbox test directly, without using pytest. This is more convenient for rapid development, since it is faster and allows easier use of a debugger. Also mention sandbox_flattree as an example of the different sandbox builds available. Signed-off-by: Simon Glass ---

[PATCH v5 09/41] test: Mark all driver model tests with a flag

2021-03-07 Thread Simon Glass
Add a flag for driver model tests, so we can do special processing for them. Signed-off-by: Simon Glass --- (no changes since v1) include/dm/test.h | 3 ++- include/test/test.h | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/include/dm/test.h b/include/dm/test.h index

[PATCH v5 03/41] doc: Document make tcheck

2021-03-07 Thread Simon Glass
Add a comment about this option in the documentation. Also mention the script that runs these combinations. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Expand docs on how each type of test is marked doc/develop/testing.rst | 12 +++- 1 file changed, 11

[PATCH v5 05/41] test: Re-enable test_ofplatdata

2021-03-07 Thread Simon Glass
This was inadvertently disabled after a recent change. Re-enable it. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch to re-enable test_ofplatdata test/py/tests/test_ofplatdata.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v5 02/41] doc: Tidy up testing section

2021-03-07 Thread Simon Glass
Tweak this so the output looks a little better. Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt --- (no changes since v2) Changes in v2: - Use correct rst format for 'Ad-hoc tests' section doc/develop/testing.rst | 20 1 file changed, 12 insertions(+), 8

[PATCH v5 01/41] dm: core: Fix allocation of empty of-platdata

2021-03-07 Thread Simon Glass
With of-platdata we always have a dtv struct that holds the platform data provided by the driver_info record. However, this struct can be empty if there are no actual devicetree properties provided. The upshot of empty platform data is that it will end up as a zero-size member in the BSS section,

[PATCH v5 00/41] test: Refactor tests to have a single test runner

2021-03-07 Thread Simon Glass
At present U-Boot has two broad sets of tests in the C code: driver model tests which do a lot of pre-/post-init and command tests which do not. This separation makes it slightly harder to write a test, since there are two different test-state structures and different rules for running the two

Re: [PATCH] configs: add PineTab defconfig

2021-03-07 Thread Icenowy Zheng
于 2021年3月8日 GMT+08:00 上午8:12:24, Andre Przywara 写到: >On Sun, 7 Mar 2021 13:53:56 +0100 >Nicolas Boulenguez wrote: > >Hi, > >> From: Arnaud Ferraris >> >> The PineTab device-tree is already in u-boot, this commit adds the >corresponding >> defconfig, based on pinephone_defconfig. >> >>

Re: [PATCH] configs: add PineTab defconfig

2021-03-07 Thread Andre Przywara
On Sun, 7 Mar 2021 13:53:56 +0100 Nicolas Boulenguez wrote: Hi, > From: Arnaud Ferraris > > The PineTab device-tree is already in u-boot, this commit adds the > corresponding > defconfig, based on pinephone_defconfig. > > Signed-off-by: Arnaud Ferraris > > --- a/board/sunxi/MAINTAINERS >

Re: [RFC] tests in test/dm/video.c are not independent

2021-03-07 Thread Simon Glass
Hi Heinrich, On Sun, 7 Mar 2021 at 11:49, Heinrich Schuchardt wrote: > > Hello Simon, > > looking at the tests in test/dm/video.c it seems that none of them > clears the screen before adding text and testing the hash of the frame > buffer. So it is hard to tell which output led to changes in

Re: [PATCH v4 42/42] doc: Explain briefly how to write new tests

2021-03-07 Thread Simon Glass
Hi Heinrich, On Thu, 4 Mar 2021 at 13:14, Heinrich Schuchardt wrote: > > On 04.03.21 14:51, Simon Glass wrote: > > Add a second on writing tests, covering when to use Python and C, where > > to put the tests, etc. Add a link to the existing Python test > > documentation. > > > > Signed-off-by:

Re: [PATCH] pico-imx6ul: Pass the PMIC I2C address in pmic_get()

2021-03-07 Thread Jaehoon Chung
On 3/6/21 7:11 AM, Fabio Estevam wrote: > Pass "pfuze3000@8" in pmic_get() so that the PMIC node can > be found in the devicetree. > > Signed-off-by: Fabio Estevam Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > board/technexion/pico-imx6ul/pico-imx6ul.c | 2 +- > 1 file

Re: [PATCH 1/2] power: regulator: add driver for ANATOP regulator

2021-03-07 Thread Jaehoon Chung
Dear Ying-Chun On 3/8/21 3:18 AM, Ying-Chun Liu wrote: > From: "Ying-Chun Liu (PaulLiu)" > > Anatop is an integrated regulator inside i.MX6 SoC. > There are 3 digital regulators which controls PU, CORE (ARM), and SOC. > And 3 analog regulators which controls 1P1, 2P5, 3P0 (USB). > This patch

Re: [PATCH v4 06/42] doc: Explain how to run tests without pytest

2021-03-07 Thread Simon Glass
Hi Heinrich, On Thu, 4 Mar 2021 at 11:13, Heinrich Schuchardt wrote: > > On 3/4/21 2:50 PM, Simon Glass wrote: > > Add details about how to run a sandbox test directly, without using > > pytest. This is more convenient for rapid development, since it is faster > > and allows easier use of a

Re: [PATCH 16/20] binman: doc: Add documentation to htmldocs

2021-03-07 Thread Simon Glass
Hi Heinrich, On Sun, 7 Mar 2021 at 17:31, Heinrich Schuchardt wrote: > > On 3/7/21 11:17 PM, Simon Glass wrote: > > Hi Heinrich, > > > > On Sun, 7 Mar 2021 at 17:13, Heinrich Schuchardt wrote: > >> > >> On 3/7/21 10:22 PM, Simon Glass wrote: > >>> Hi Heinrich, > >>> > >>> On Sun, 7 Mar 2021 at

Re: [PATCH 16/20] binman: doc: Add documentation to htmldocs

2021-03-07 Thread Heinrich Schuchardt
On 3/7/21 11:17 PM, Simon Glass wrote: Hi Heinrich, On Sun, 7 Mar 2021 at 17:13, Heinrich Schuchardt wrote: On 3/7/21 10:22 PM, Simon Glass wrote: Hi Heinrich, On Sun, 7 Mar 2021 at 15:02, Heinrich Schuchardt wrote: On 3/7/21 8:31 PM, Simon Glass wrote: Add a link to binman's

Re: [PATCH v4 39/42] doc: Move coccinelle into its own section

2021-03-07 Thread Simon Glass
Hi Heinrich, On Thu, 4 Mar 2021 at 12:23, Heinrich Schuchardt wrote: > > On 04.03.21 14:51, Simon Glass wrote: > > This tool has nothing to do with testing. Create a new section for > > 'refactoring' and move it into there. It is likely that other topics may > > fall under the same heading, such

Re: [PATCH 16/20] binman: doc: Add documentation to htmldocs

2021-03-07 Thread Simon Glass
Hi Heinrich, On Sun, 7 Mar 2021 at 17:13, Heinrich Schuchardt wrote: > > On 3/7/21 10:22 PM, Simon Glass wrote: > > Hi Heinrich, > > > > On Sun, 7 Mar 2021 at 15:02, Heinrich Schuchardt wrote: > >> > >> On 3/7/21 8:31 PM, Simon Glass wrote: > >>> Add a link to binman's documentation and adjust

Re: [PATCH] configs: add PineTab defconfig

2021-03-07 Thread Andre Przywara
On Sun, 07 Mar 2021 12:34:14 -0800 Vagrant Cascadian wrote: > On 2021-03-07, Nicolas Boulenguez wrote: > > From: Arnaud Ferraris > > > > The PineTab device-tree is already in u-boot, this commit adds the > > corresponding > > defconfig, based on pinephone_defconfig. > > > > Signed-off-by:

Re: [PATCH 16/20] binman: doc: Add documentation to htmldocs

2021-03-07 Thread Heinrich Schuchardt
On 3/7/21 10:22 PM, Simon Glass wrote: Hi Heinrich, On Sun, 7 Mar 2021 at 15:02, Heinrich Schuchardt wrote: On 3/7/21 8:31 PM, Simon Glass wrote: Add a link to binman's documentation and adjust the files so that it is accessible. Use the name README.rst so it is easy to discover when binman

Re: [PATCH 16/20] binman: doc: Add documentation to htmldocs

2021-03-07 Thread Simon Glass
Hi Heinrich, On Sun, 7 Mar 2021 at 15:02, Heinrich Schuchardt wrote: > > On 3/7/21 8:31 PM, Simon Glass wrote: > > Add a link to binman's documentation and adjust the files so that it is > > accessible. Use the name README.rst so it is easy to discover when binman > > is installed without

[PATCH v3 3/5] board/Synology: Unify legacy kernel support

2021-03-07 Thread Phil Sutter
Move the relevant bits from ds109.{c,h} into common/ and adjust the code to fit both DS109 and DS414. Moreover: * Introduce syno_board_id() which translates CONFIG_MACH_TYPE into the expected board ID tag value. * Properly initialize isusbhost, mac and mtu fields from env variables. * Set the

[PATCH v3 2/5] configs: ds414: Enable XHCI_PCI by default

2021-03-07 Thread Phil Sutter
With the recent fixes in pci_mvebu and xhci-pci drivers, the two rear USB3 ports are finally usable and accessing them no longer hangs the system. Signed-off-by: Phil Sutter --- Changes since v2: - Leave PREBOOT alone, with recent kernels XHCI HCD works fine even if not initialized. - Adjust

Re: [PATCH v2 2/5] configs: ds414: Enable XHCI_PCI by default

2021-03-07 Thread Phil Sutter
On Sat, Mar 06, 2021 at 09:15:27AM +0100, Stefan Roese wrote: > On 05.03.21 21:03, Phil Sutter wrote: > > With the recent fixes in pci_mvebu and xhci-pci drivers, the two rear > > USB3 ports are finally usable and accessing them no longer hangs the > > system. Moreover, if Linux is booted without

Re: [PATCH u-boot 14/39] lib: crc32: put the crc_table variable into efi_runtime_rodata section

2021-03-07 Thread Marek Behun
On Sun, 7 Mar 2021 14:04:35 +0100 Marek Behun wrote: > Hmm, maybe this should be split into 2 commits. I have divided this into 2 commits and pushed into my github branch

Re: [PATCH u-boot 38/39] ARM: enable LTO for some boards

2021-03-07 Thread Marek Behun
On Sun, 7 Mar 2021 10:14:07 -0600 Adam Ford wrote: > On Sat, Mar 6, 2021 at 10:26 PM Marek Behún wrote: > > > > Enable LTO for some boards that were tested by people on U-Boot Mailing > > List. > > > > I have also confirmed this works on the r8a774a1_beacon board as well > and boots without

Re: [PATCH] configs: add PineTab defconfig

2021-03-07 Thread Vagrant Cascadian
On 2021-03-07, Nicolas Boulenguez wrote: > From: Arnaud Ferraris > > The PineTab device-tree is already in u-boot, this commit adds the > corresponding > defconfig, based on pinephone_defconfig. > > Signed-off-by: Arnaud Ferraris ... > --- /dev/null > +++ b/configs/pinetab_defconfig ... >

Re: [PATCH 16/20] binman: doc: Add documentation to htmldocs

2021-03-07 Thread Heinrich Schuchardt
On 3/7/21 8:31 PM, Simon Glass wrote: Add a link to binman's documentation and adjust the files so that it is accessible. Use the name README.rst so it is easy to discover when binman is installed without U-Boot. Signed-off-by: Simon Glass --- doc/index.rst | 1 +

Re: [PATCH 15/20] doc: Move UEFI down a bit

2021-03-07 Thread Heinrich Schuchardt
On 3/7/21 8:31 PM, Simon Glass wrote: This features a little too prominently in the contents at present. It seems more important to talk about driver model and the API (which includes some UEFI notes). The driver model is only relevant for developers. So it should be moved to "Develop U-Boot".

  1   2   >