[PATCH] dm: usb: add hook for low level usb init

2021-07-16 Thread Simon-Pierre Allaire
Signed-off-by: Simon-Pierre Allaire --- drivers/usb/host/usb-uclass.c | 7 ++- drivers/usb/musb-new/musb_uboot.c | 13 + 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/usb-uclass.c b/drivers/usb/host/usb-uclass.c index 611ea97a72..e1ea21970c

Re: using binman fails boot

2021-07-16 Thread Tim Harvey
On Fri, Jul 16, 2021 at 3:11 PM Simon Glass wrote: > > () which has > Hi Tim, > > On Fri, 16 Jul 2021 at 15:43, Tim Harvey wrote: > > > > On Thu, Jul 15, 2021 at 9:30 PM Simon Glass wrote: > > > > > > Hi Tim, > > > > > > On Thu, 15 Jul 2021 at 16:58, Tim Harvey wrote: > > > > > > > >

[PATCH] common: board_r: print error if binman_init fails

2021-07-16 Thread Tim Harvey
Display an error if binman_init fails. Signed-off-by: Tim Harvey --- common/board_r.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/common/board_r.c b/common/board_r.c index 3f82404772..e3e6248a1f 100644 --- a/common/board_r.c +++ b/common/board_r.c @@ -323,10

Re: [PATCH] dm: usb: add hook for low level usb init

2021-07-16 Thread Simon Glass
Hi Simon-Pierre, On Fri, 16 Jul 2021 at 10:35, Simon-Pierre Allaire wrote: > > Signed-off-by: Simon-Pierre Allaire > --- > commit message? Needs motivation and what it does. But I think we're going to have to figure out a driver model way of doing this. > drivers/usb/host/usb-uclass.c |

Re: using binman fails boot

2021-07-16 Thread Simon Glass
() which has Hi Tim, On Fri, 16 Jul 2021 at 15:43, Tim Harvey wrote: > > On Thu, Jul 15, 2021 at 9:30 PM Simon Glass wrote: > > > > Hi Tim, > > > > On Thu, 15 Jul 2021 at 16:58, Tim Harvey wrote: > > > > > > Greetings, > > > > > > I'm taking a look at moving imx8mm-venice to use binman for

Re: using binman fails boot

2021-07-16 Thread Tim Harvey
On Thu, Jul 15, 2021 at 9:30 PM Simon Glass wrote: > > Hi Tim, > > On Thu, 15 Jul 2021 at 16:58, Tim Harvey wrote: > > > > Greetings, > > > > I'm taking a look at moving imx8mm-venice to use binman for packaging. > > After doing so U-Boot proper fails to boot: > > > > U-Boot SPL

Re: Please pull u-boot-marvell/master (watchdog related)

2021-07-16 Thread Tom Rini
On Fri, Jul 16, 2021 at 12:18:10PM +0200, Stefan Roese wrote: > Hi Tom, > > please pull the following watchdog related patches: > Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

[PATCH] zynqmp: restore the jtag interface

2021-07-16 Thread Jorge Ramirez-Ortiz
As a security feature, if boot.bin was configured for secure boot the CSU will disable the JTAG interface on all cases. Some boards might rely on this interface for flashing to QSPI in which case those systems might end up bricked during development. This commit attempts to restore the interface

Re: [PATCH] image: android: Automatically detect more compression types

2021-07-16 Thread Tom Rini
On Thu, Jul 01, 2021 at 08:33:16PM +0200, Stephan Gerhold wrote: > At the moment android_image_get_kcomp() can automatically detect > LZ4 compressed kernels and the compression specified in uImages. > However, especially on ARM64 Linux is often compressed with GZIP. > Attempting to boot an

Re: [PATCH] fit: Load DTO into temporary buffer and ignore load address

2021-07-16 Thread Tom Rini
On Fri, Jun 11, 2021 at 04:09:56AM +0200, Marek Vasut wrote: > The current fitImage DTO implementation expects each fitImage image > subnode containing DTO to have 'load' property, pointing somewhere > into memory where the DTO will be loaded. The address in the 'load' > property must be

Re: [PATCH v2 3/3] lib/vsprintf.c: remove unused ip6_addr_string()

2021-07-16 Thread Tom Rini
On Fri, May 28, 2021 at 12:20:46AM +0200, Rasmus Villemoes wrote: > There's currently no user of %p[iI]6, so including ip6_addr_string() > in the image is a waste of bytes. It's easy enough to have the > compiler elide it without removing the code completely. > > The closest I can find to

Re: [PATCH v2 1/3] lib/vsprintf.c: implement printf() in terms of vprintf()

2021-07-16 Thread Tom Rini
On Fri, May 28, 2021 at 12:20:44AM +0200, Rasmus Villemoes wrote: > This saves some code, both in terms of #LOC and .text size, and it is > also the normal convention that foo(...) is implemented in terms of > vfoo(). > > Reviewed-by: Simon Glass > Signed-off-by: Rasmus Villemoes Applied to

Re: [PATCH v2 15/16] clk: Detect failure to set defaults

2021-07-16 Thread Tom Rini
On Thu, May 13, 2021 at 07:39:31PM -0600, Simon Glass wrote: > When the default clocks cannot be set, the clock is silently probed and > the error is ignored. This is incorrect, since having the clocks at the > correct speed may be important for operation of the system. > > Fix it by checking

Re: [PATCH v2 2/3] lib/vsprintf.c: remove stale comment

2021-07-16 Thread Tom Rini
On Fri, May 28, 2021 at 12:20:45AM +0200, Rasmus Villemoes wrote: > U-Boot doesn't support %pS/%pF or any other kind of kallsyms-like > lookups. Remove the comment. > > Reviewed-by: Simon Glass > Signed-off-by: Rasmus Villemoes Applied to u-boot/master, thanks! -- Tom signature.asc

Re: [PATCH v2 14/16] sandbox: Silence coverity warning in state_read_file()

2021-07-16 Thread Tom Rini
On Thu, May 13, 2021 at 07:39:30PM -0600, Simon Glass wrote: > In this case the value seems save to pass to os_free(). Add a comment. > > Signed-off-by: Simon Glass > Reported-by: Coverity (CID: 165109) Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 13/16] tpm: Check outgoing command size

2021-07-16 Thread Tom Rini
On Thu, May 13, 2021 at 07:39:29PM -0600, Simon Glass wrote: > In tpm_sendrecv_command() the command buffer is passed in. If a mistake is > somehow made in setting this up, the size could be out of range. Add a > sanity check for this. > > Signed-off-by: Simon Glass > Reported-by: Coverity

Re: [PATCH v2 12/16] pinctrl: Avoid coverity warning when checking width

2021-07-16 Thread Tom Rini
On Thu, May 13, 2021 at 07:39:28PM -0600, Simon Glass wrote: > The width is set up in single_of_to_plat() and can only have three values, > all of which result in a non-zero divisor. Add a comment. > > Signed-off-by: Simon Glass > Reported-by: Coverity (CID: 331154) Applied to u-boot/master,

Re: [PATCH v2 11/16] cbfs: Check offset range when reading a file

2021-07-16 Thread Tom Rini
On Thu, May 13, 2021 at 07:39:27PM -0600, Simon Glass wrote: > Add a check that the offset is within the allowed range. > > Signed-off-by: Simon Glass > Reported-by: Coverity (CID: 331155) Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 10/16] sandbox: cros_ec: Update error handling when reading matrix

2021-07-16 Thread Tom Rini
On Thu, May 13, 2021 at 07:39:26PM -0600, Simon Glass wrote: > At present the return value of ofnode_get_property() is not checked, which > causes a coverity warning. While we are here, use logging for the errors. > > Signed-off-by: Simon Glass > Reported-by: Coverity (CID: 331157) Applied to

Re: [PATCH v2 08/16] dm: core: Check uclass_get() return value when dumping

2021-07-16 Thread Tom Rini
On Thu, May 13, 2021 at 07:39:24PM -0600, Simon Glass wrote: > Update dm_dump_drivers() to use the return value from uclass_get() to > check the validity of uc. This is equivalent and should be more attractive > to Coverity. > > Signed-off-by: Simon Glass > Reported-by: Coverity (CID: 316601)

Re: [PATCH v2 05/16] reset: Avoid a warning in devm_reset_bulk_get_by_node()

2021-07-16 Thread Tom Rini
On Thu, May 13, 2021 at 07:39:21PM -0600, Simon Glass wrote: > The devres_alloc() function is intended to avoid the need for freeing > memory, although in practice it may not be enabled, thus leading to a true > leak. > > Nevertheless this is intended. Add a comment to explain this. > >

Re: [PATCH v2 06/16] reset: Avoid a warning in devm_regmap_init()

2021-07-16 Thread Tom Rini
On Thu, May 13, 2021 at 07:39:22PM -0600, Simon Glass wrote: > The devres_alloc() function is intended to avoid the need for freeing > memory, although in practice it may not be enabled, thus leading to a true > leak. > > Nevertheless this is intended. Add a comment. > > Signed-off-by: Simon

Re: [PATCH v2 04/16] tools: Avoid showing return value of clock_gettime()

2021-07-16 Thread Tom Rini
On Thu, May 13, 2021 at 07:39:20PM -0600, Simon Glass wrote: > This value is either 0 for success or -1 for error. Coverity reports that > "ret" is passed to a parameter that cannot be negative, pointing to the > condition 'if (ret < 0)'. > > Adjust it to just check for non-zero and avoid

Re: [PATCH v2 03/16] test: Rename final check in setexpr_test_backref()

2021-07-16 Thread Tom Rini
On Thu, May 13, 2021 at 07:39:19PM -0600, Simon Glass wrote: > The bug in setexpr is fixed now, so this test can be enabled. > > Reported-by: Coverity (CID: 316346) > > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 02/16] video: Check return value in pwm_backlight_of_to_plat()

2021-07-16 Thread Tom Rini
On Thu, May 13, 2021 at 07:39:18PM -0600, Simon Glass wrote: > This cannot actually fail, but check the value anyway to keep coverity > happy. > > Signed-off-by: Simon Glass > Reported-by: Coverity (CID: 316351) Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP

Re: [PATCH v2 01/16] sandbox: net: Ensure host name is always a valid string

2021-07-16 Thread Tom Rini
On Thu, May 13, 2021 at 07:39:17PM -0600, Simon Glass wrote: > At present if ifname is exactly IFNAMSIZ characters then it will result > in an unterminated string. Fix this by using strlcpy() instead. > > Signed-off-by: Simon Glass > Reported-by: Coverity (CID: 316358) > Acked-by: Ramon Fried

Re: [PATCH] rtc: m41t62: fix wrong register use for set/reset ST bit

2021-07-16 Thread Tom Rini
On Mon, May 10, 2021 at 05:23:37AM +, Max Yang wrote: > Fix wrong register use when set/reset ST bit. > ST bit is in register M41T62_REG_SEC not in M41T62_REG_ALARM_HOUR. > > I have not actually tested this. But this seemed buggy from inspection. > > Fixes: 9bbe210512c4539 ("rtc: m41t62:

Re: [PULL] Pull request for u-boot master / v2021.10 = u-boot-stm32-20210715

2021-07-16 Thread Tom Rini
On Fri, Jul 16, 2021 at 10:40:35AM +0200, Patrick DELAUNAY wrote: > Hi Tom, > > Please pull the STM32 related patches for u-boot/master, v2021.10: > u-boot-stm32-20210715 > > - DTS: alignment with Linux kernel v5.13 for stm32mp15 boards > - STM32MP1: update the stm32key command > - STM32MP1:

Re: [PATCH 2/3] mkeficapsule: Remove dtb related options

2021-07-16 Thread Simon Glass
Hi Ilias, On Thu, 15 Jul 2021 at 11:00, Ilias Apalodimas wrote: > > commit 322c813f4bec ("mkeficapsule: Add support for embedding public key in a > dtb") > added a bunch of options enabling the addition of the capsule public key > in a dtb. Since now we embeded the key in U-Boot's .rodata we

Re: [PATCH 2/3] mkeficapsule: Remove dtb related options

2021-07-16 Thread Takahiro Akashi
On Fri, Jul 16, 2021 at 02:57:54PM +0900, Masami Hiramatsu wrote: > 2021年7月16日(金) 2:00 Ilias Apalodimas : > > > > commit 322c813f4bec ("mkeficapsule: Add support for embedding public key in > > a dtb") > > added a bunch of options enabling the addition of the capsule public key > > in a dtb.

Re: [PATCH 1/3] efi_capsule: Move signature from DTB to .rodata

2021-07-16 Thread Simon Glass
Hi Ilias, On Thu, 15 Jul 2021 at 11:00, Ilias Apalodimas wrote: > > The capsule signature is now part of our DTB. This is problematic when a > user is allowed to change/fixup that DTB from U-Boots command line since he > can overwrite the signature as well. Do you mean with the 'fdt' command?

Re: [PATCH 1/3] efi_capsule: Move signature from DTB to .rodata

2021-07-16 Thread Takahiro Akashi
Just a few minor comments: On Fri, Jul 16, 2021 at 02:57:00PM +0900, Masami Hiramatsu wrote: > 2021年7月16日(金) 2:00 Ilias Apalodimas : > > > > The capsule signature is now part of our DTB. This is problematic when a > > user is allowed to change/fixup that DTB from U-Boots command line since he >

Re: [PATCH 3/3] doc: Update CapsuleUpdate READMEs

2021-07-16 Thread AKASHI Takahiro
On Fri, Jul 16, 2021 at 10:09:40AM +0300, Ilias Apalodimas wrote: > > > + > > > +The directory \EFI\UpdateCapsule is checked for capsules only within the > > > +EFI system partition on the device specified in the active boot option > > > +determine by reference to BootNext variable or BootOrder

u-boot saveenv to redundant fat does not persist env

2021-07-16 Thread Pierre-Alexis Ciavaldini
Hi, I'm trying to integrate u-boot in our project that is a custom scripted build without yocto, for use with mender. The complete discussion can be found here : https://hub.mender.io/t/pi3-usb-boot-support/595/54?u=peac The issue is that when issuing saveenv in u-boot, it responds with "Saving

Adding UBI support to U-Boot 2014.04 without nand driver

2021-07-16 Thread Bartlomiej Grzeskowiak
Hi, I am developing an OpenWRT based system. I got an SDK from a chip provider that includes U-Boot 2014.0. I want to extend its functionality with UBI. I've added CONFIG_CMD_UBI, without any problems. I get ubi commands in uboot now. But: setenv mtdids nand0=my_nand setenv mtdparts

[PATCH] arm: mvebu: Espressobin: Enable 'mtd' command and define SPI NOR partitions

2021-07-16 Thread Pali Rohár
U-Boot now supports parsing SPI NOR partitions from Device Tree. So enable 'mtd' command support for Espressobin board and define partition layout in U-Boot Espressobin DTS file. Access to SPI NOR via 'sf' command is old method and 'mtd' command is now preferred variant. >From include file remove

Please pull u-boot-marvell/master (watchdog related)

2021-07-16 Thread Stefan Roese
Hi Tom, please pull the following watchdog related patches: - designware_wdt: reset watchdog in designware_wdt_stop() function (Meng) - socfpga_stratix10: enable wdt command (Meng) - wdt-uclass: Use IS_ENABLED for

Re: [PATCH v2] drivers: watchdog: wdt-uclass: Use IS_ENABLED for WATCHDOG_AUTOSTART

2021-07-16 Thread Stefan Roese
On 15.07.21 13:26, Teresa Remmet wrote: There is no separate SPL/TPL config for WATCHDOG_AUTOSTART. So use IS_ENABLED instead of CONFIG_IS_ENABLED to make watchdog working in SPL again. Fixes: 830d29ac3721 ("watchdog: Allow to use CONFIG_WDT without starting watchdog") Signed-off-by: Teresa

Re: [PATCH v5,2/2] arm: socfpga: socfpga_stratix10: enable wdt command by default

2021-07-16 Thread Stefan Roese
On 24.05.21 04:22, meng...@windriver.com wrote: From: MengLi In latest u-boot code, watchdog feature is implemented, so enable wdt command by default. Signed-off-by: Meng Li Applied to u-boot-marvell/master Thanks, Stefan --- v2: Change the title of this patch ---

Re: [PATCH v5,1/2] driver: watchdog: reset watchdog in designware_wdt_stop() function

2021-07-16 Thread Stefan Roese
On 24.05.21 04:22, meng...@windriver.com wrote: From: MengLi In uboot command line environment, watchdog is not able to be stopped with below commands: SOCFPGA_STRATIX10 # wdt dev watchdog@ffd00200 SOCFPGA_STRATIX10 # wdt stop Refer to watchdog driver in linux kernel, it is also need to reset

Re: [PATCH] smbios: Fix calculating BIOS Release Date

2021-07-16 Thread Pali Rohár
On Friday 16 July 2021 08:39:05 Heinrich Schuchardt wrote: > On 4/22/21 6:09 PM, Pali Rohár wrote: > > BIOS Release Date must be in format mm/dd/ and must be release date. > > %s/BIOS/The SMBIOS/ No. In SMBIOS specification and also in U-Boot structures it is called "BIOS Release Date". Not

[PATCH 1/4] clk: at91: clk-master: split master clock in pres and divider

2021-07-16 Thread Claudiu Beznea
Split master clock in 2 controlling block: one for prescaler one for divider. This will allow referencing correctly the CPU clock and master clock in device trees. Reported-by: Eugen Hristev Fixes: a64862284f65 ("clk: at91: sam9x60: add support compatible with CCF") Signed-off-by: Claudiu Beznea

[PATCH 3/4] ARM: dts: at91: sam9x60: add bindings for CPU

2021-07-16 Thread Claudiu Beznea
Add bindings for CPU. This will allow displaying correctly the crystal, CPU and master clock. Reported-by: Eugen Hristev Fixes: a64862284f65 ("clk: at91: sam9x60: add support compatible with CCF") Signed-off-by: Claudiu Beznea --- arch/arm/dts/sam9x60.dtsi | 12 1 file changed, 12

[PATCH 2/4] cpu: at91: add compatible for ARM9260EJ-S

2021-07-16 Thread Claudiu Beznea
The crystal, CPU and master clock were not displayed correctly on SAM9X60 after adding CCF clock support. Add compatible for ARM926EJ-S to fix this. Reported-by: Eugen Hristev Fixes: a64862284f65 ("clk: at91: sam9x60: add support compatible with CCF") Signed-off-by: Claudiu Beznea ---

[PATCH 4/4] configs: sam9x60ek: enable CONFIG_CPU

2021-07-16 Thread Claudiu Beznea
Enable CONFIG_CPU for SAM9X60EK configs. Reported-by: Eugen Hristev Fixes: a64862284f65 ("clk: at91: sam9x60: add support compatible with CCF") Signed-off-by: Claudiu Beznea --- configs/sam9x60ek_mmc_defconfig | 1 + configs/sam9x60ek_nandflash_defconfig | 1 +

[PATCH 0/4] clk: at91: fix system clocks display for sam9x60

2021-07-16 Thread Claudiu Beznea
Hi, After added CCF support for SAM9X60 the CPU, crystal and master clocks were not displayed correctly. These clocks are now displayed by at91_cpu driver. Adapt master clock driver by adding control logic for its prescaler and divider such that these to be correctly retrived by at91_cpu driver

[RESEND PATCH 2/3] Marvell Sheevaplug: Use Ethernet PHY name and address from device tree

2021-07-16 Thread Tony Dinh
- In DM Ethernet, the old "egiga0" name is no longer valid, so replace it with Ethernet PHY name from device tree. Also, Ethernet PHY address is available so read it from device tree. Signed-off-by: Tony Dinh --- board/Marvell/sheevaplug/sheevaplug.c | 54 +-- 1 file

[PULL] Pull request for u-boot master / v2021.10 = u-boot-stm32-20210715

2021-07-16 Thread Patrick DELAUNAY
Hi Tom, Please pull the STM32 related patches for u-boot/master, v2021.10: u-boot-stm32-20210715 - DTS: alignment with Linux kernel v5.13 for stm32mp15 boards - STM32MP1: update the stm32key command - STM32MP1: activate the rng command - STM32MP1: fix the stm32prog command (help, parttition

Re: [PATCH 1/2] stm32mp: use device sequence number in boot_instance variable

2021-07-16 Thread Patrick DELAUNAY
Hi, On 7/6/21 5:19 PM, Patrick Delaunay wrote: Use the device sequence number in boot_instance variable and no more the SDMMC instance provided by ROM code/TF-A. After this patch we don't need to define the mmc alias in device tree, for example: mmc0 = mmc1 = mmc2 = to have a

Re: [PATCH 2/2] ARM: dts: stm32mp15: remove mmc alias

2021-07-16 Thread Patrick DELAUNAY
Hi, On 7/6/21 5:19 PM, Patrick Delaunay wrote: Remove the mmc alias no more required as the sequence number of mmc device is used for boot_instance. Signed-off-by: Patrick Delaunay --- arch/arm/dts/stm32mp157a-dk1-u-boot.dtsi | 1 - arch/arm/dts/stm32mp157c-ed1-u-boot.dtsi | 2 -- 2

Re: [PATCH] stm32mp: stm32prog: use defines for virtual partition size

2021-07-16 Thread Patrick DELAUNAY
Hi, On 7/5/21 9:39 AM, Patrick Delaunay wrote: Use the existing defines PMIC_SIZE and OTP_SIZE and a new define CMD_SIZE for virtual partition size. This patch corrects the size for OTP partition in alternate name (1024 instead of 512) and avoids other alignment issues. Signed-off-by: Patrick

Re: [PATCH] configs: stm32mp1: activate command rng

2021-07-16 Thread Patrick DELAUNAY
Hi, On 6/29/21 12:08 PM, Patrick Delaunay wrote: Activate the command rng with CONFIG_CMD_RNG, used to test the rng driver Signed-off-by: Patrick Delaunay --- configs/stm32mp15_basic_defconfig | 2 +- configs/stm32mp15_trusted_defconfig | 2 +- 2 files changed, 2 insertions(+), 2

Re: [PATCH 2/2] stm32mp: syscon: manage clock when present in device tree

2021-07-16 Thread Patrick DELAUNAY
Hi, On 6/29/21 12:04 PM, Patrick Delaunay wrote: Enable the clocks during syscon probe when they are present in device tree. This patch avoids a freeze when the SYSCFG clock is not enabled by TF-A / OP-TEE. Signed-off-by: Patrick Delaunay --- arch/arm/mach-stm32mp/syscon.c | 14

Re: [PATCH 1/2] clk: stm32mp1: add support of SYSCFG clock

2021-07-16 Thread Patrick DELAUNAY
Hi, On 6/29/21 12:04 PM, Patrick Delaunay wrote: Add the support of SYSCFG clock used by syscon driver to prepare the clock management of STM32MP_SYSCON_SYSCFG. This clock is already defined in kernel device tree, stm32mp151.dtsi but not yet supported in the syscon driver: syscfg:

Re: [PATCH 7/7] stm32mp: cmd_stm32key: add subcommand close

2021-07-16 Thread Patrick DELAUNAY
Hi, On 6/28/21 2:56 PM, Patrick Delaunay wrote: The expected sequence to close the device 1/ Load key in DDR with any supported load command 2/ Update OTP with key: STM32MP> stm32key read At this point the device is able to perform image authentication but non-authenticated images can still

Re: [PATCH 6/7] stm32mp: cmd_stm32key: add read OTP subcommand

2021-07-16 Thread Patrick DELAUNAY
Hi, On 6/28/21 2:56 PM, Patrick Delaunay wrote: Allow to read the OTP value and lock status with the command $> stm32key read. This patch also protects the stm32key fuse command. Signed-off-by: Patrick Delaunay --- arch/arm/mach-stm32mp/cmd_stm32key.c | 93 ++-- 1

Re: [PATCH 5/7] stm32mp: cmd_stm32key: add get_misc_dev function

2021-07-16 Thread Patrick DELAUNAY
Hi, On 6/28/21 2:56 PM, Patrick Delaunay wrote: Add a helper function to access to BSEC misc driver. Signed-off-by: Patrick Delaunay --- arch/arm/mach-stm32mp/cmd_stm32key.c | 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) Applied to u-boot-stm/master, thanks!

Re: [PATCH 4/7] stm32mp: cmd_stm32key: lock of PKH OTP after fuse

2021-07-16 Thread Patrick DELAUNAY
Hi, On 6/28/21 2:56 PM, Patrick Delaunay wrote: Lock the OTP value of key's hash after the command $> stm32key fuse This operation forbids a second update of these OTP as they are ECC protected in BSEC: any update of these OTP with a different value causes a BSEC disturb error and the closed

Re: [PATCH 3/7] stm32mp: cmd_stm32key: handle error in fuse_hash_value

2021-07-16 Thread Patrick DELAUNAY
Hi, On 6/28/21 2:55 PM, Patrick Delaunay wrote: Handle errors in fuse_hash_value function. Signed-off-by: Patrick Delaunay --- arch/arm/mach-stm32mp/cmd_stm32key.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) Applied to u-boot-stm/master, thanks!

Re: [PATCH 2/7] stm32mp: cmd_stm32key: use sub command

2021-07-16 Thread Patrick DELAUNAY
Hi, On 6/28/21 2:55 PM, Patrick Delaunay wrote: Simplify parsing the command argument by using the macro U_BOOT_CMD_WITH_SUBCMDS. Signed-off-by: Patrick Delaunay --- arch/arm/mach-stm32mp/cmd_stm32key.c | 55 ++-- 1 file changed, 36 insertions(+), 19 deletions(-)

Re: [PATCH 1/7] stm32mp: configs: activate the command stm32key only for ST boards

2021-07-16 Thread Patrick DELAUNAY
Hi, On 6/28/21 2:55 PM, Patrick Delaunay wrote: This command is used to evaluate the secure boot on stm32mp SOC, it is deactivated by default in real products. We activate this command only in STMicroelectronics defconfig used with the evaluation boards. Signed-off-by: Patrick Delaunay ---

Re: [PATCH] stm32mp: stm32prog: fix the content of short help message

2021-07-16 Thread Patrick DELAUNAY
Hi, On 6/28/21 2:44 PM, Patrick Delaunay wrote: Reduce the content of short help message for stm32prog command and removed the carriage return to fix the display of 'help' command when this command is activated. Fixes: 954bd1a923a6 ("stm32mp: add the command stm32prog") Signed-off-by: Patrick

Re: [PATCH] configs: stm32mp1: remove splashimage and add fdtoverlay_addr_r

2021-07-16 Thread Patrick DELAUNAY
Hi, On 6/28/21 2:42 PM, Patrick Delaunay wrote: Add the variable used by PXE command for fdtoverlays support since the commit 69076dff2284 ("cmd: pxe: add support for FDT overlays"). Reused the unused "splashimage" address as CONFIG_SPLASH_SOURCE and CONFIG_VIDEO_LOGO are not activated and

[PATCH] clk: stm32mp1: add support of BSEC clock

2021-07-16 Thread Patrick Delaunay
Add the support of the BSEC clock used by the STM32MP misc driver since the commit 622c956cada0 ("stm32mp: bsec: manage clock when present in device tree") even if this clock is not yet defined in kernel device tree stm32mp151.dtsi. This patch avoids issue for basic boot when this secure clock

Re: [PATCH 3/3] doc: Update CapsuleUpdate READMEs

2021-07-16 Thread Ilias Apalodimas
> > + > > +The directory \EFI\UpdateCapsule is checked for capsules only within the > > +EFI system partition on the device specified in the active boot option > > +determine by reference to BootNext variable or BootOrder variable > > processing. > > %s/determine/determined/ > sure > > +The

Re: [PATCH 3/3] doc: Update CapsuleUpdate READMEs

2021-07-16 Thread Heinrich Schuchardt
On 7/15/21 7:00 PM, Ilias Apalodimas wrote: Since we removed embeddingg the capsule key into a .dtb and fixed authenticated capsule updates for all boards, move the relevant documentation in the efi file and update it accordingly Signed-off-by: Ilias Apalodimas ---

Re: [PATCH 1/3] efi_capsule: Move signature from DTB to .rodata

2021-07-16 Thread Sughosh Ganu
On Thu, 15 Jul 2021 at 22:30, Ilias Apalodimas wrote: > The capsule signature is now part of our DTB. This is problematic when a > user is allowed to change/fixup that DTB from U-Boots command line since he > can overwrite the signature as well. > So Instead of adding the key on the DTB, embed

Re: [PATCH] efi_loader: Use %pD to log device-path instead of local efi_dp_str()

2021-07-16 Thread Heinrich Schuchardt
On 7/14/21 7:19 AM, Masami Hiramatsu wrote: Use %pD to log device-path instead of using efi_dp_str() and efi_free_pool() locally in find_boot_device(). This is a cleanup patch, no feature update nor fix. Suggested-by: Heinrich Schuchardt Signed-off-by: Masami Hiramatsu Reviewed-by: Heinrich

Re: [PATCH] smbios: Fix calculating BIOS Release Date

2021-07-16 Thread Heinrich Schuchardt
On 4/22/21 6:09 PM, Pali Rohár wrote: BIOS Release Date must be in format mm/dd/ and must be release date. %s/BIOS/The SMBIOS/ Please add a reference to the System Management BIOS (SMBIOS) Reference Specification here an as comment in the code. U-Boot currently sets BIOS Release Date