Re: [PATCH] dt-bindings: u-boot: Add a few more options bindings

2021-11-26 Thread Simon Glass
+ others Are there no comments on this? - Simon On Fri, 19 Nov 2021 at 17:13, Simon Glass wrote: > > +Rob Herring oops > > > On Fri, 19 Nov 2021 at 17:04, Simon Glass wrote: > > > > This adds three new options with varying degree of interest / precedent. > > > > This being sent to the mailing

Re: Pull request for efi-2022-01-rc3-2

2021-11-26 Thread Tom Rini
On Fri, Nov 26, 2021 at 10:42:56PM +0100, Heinrich Schuchardt wrote: > Dear Tom, > > The following changes since commit 2ad8d0cb950da2233a2ec030533f4e54c6d04126: > > Merge branch 'efi-2022-01' of > https://source.denx.de/u-boot/custodians/u-boot-efi (2021-11-20 09:36:37 > -0500) > > are

Re: [U-BOOT-TEST-HOOKS PATCH 1/1] Enable TPMv2 emulation

2021-11-26 Thread Tom Rini
On Wed, Nov 24, 2021 at 08:33:42AM +0100, Heinrich Schuchardt wrote: > On 11/24/21 08:23, Ilias Apalodimas wrote: > > Hi Heinrich, > > > > On Mon, 15 Nov 2021 at 12:11, Heinrich Schuchardt > > wrote: > > > > > > Provide a QEMU helper script to launch swtpm and add extra parameters to > > >

[PATCH v8] driver: spi: add bcm iproc qspi support

2021-11-26 Thread Roman Bacik
From: Rayagonda Kokatanur IPROC qspi driver supports both BSPI and MSPI modes. Signed-off-by: Rayagonda Kokatanur Signed-off-by: Bharat Gooty Acked-by: Rayagonda Kokatanur Signed-off-by: Roman Bacik --- Changes in v8: - add 4-byte address support Changes in v7: - remove hardcorded

Re: [PATCH] tpm: avoid NULL pointer dereference in tpm_tis_send()

2021-11-26 Thread Ilias Apalodimas
Hi Heinrich, On Fri, Nov 26, 2021 at 11:54:52PM +0100, Heinrich Schuchardt wrote: > You should not dereference a pointer before checking if it is NULL. > > Signed-off-by: Heinrich Schuchardt > --- > drivers/tpm/tpm2_tis_core.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >

[PATCH] tpm: avoid NULL pointer dereference in tpm_tis_send()

2021-11-26 Thread Heinrich Schuchardt
You should not dereference a pointer before checking if it is NULL. Signed-off-by: Heinrich Schuchardt --- drivers/tpm/tpm2_tis_core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/tpm/tpm2_tis_core.c b/drivers/tpm/tpm2_tis_core.c index ec8c730fe9..0ff21a1ef7

Re: a question about falcon mode

2021-11-26 Thread Abder
Hi Alex, Just a quick remarque that intrigued me: Le jeu. 25 nov. 2021 à 15:57, Alex G. a écrit : > > On 11/25/21 1:07 AM, Chan Kim wrote: > > Hello all, > > > > I'm trying to implement falcon mode for our board. Then should I first > > implement the normal mode(spl + proper)? > > > > It looks

[PATCH 1/1] test: fix pylint warnings in test_env.py

2021-11-26 Thread Heinrich Schuchardt
* assert does not need parentheses * add module docstring * fix misspelled constant True * limit lines to 100 characters Signed-off-by: Heinrich Schuchardt --- test/py/tests/test_env.py | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git

Pull request for efi-2022-01-rc3-2

2021-11-26 Thread Heinrich Schuchardt
Dear Tom, The following changes since commit 2ad8d0cb950da2233a2ec030533f4e54c6d04126: Merge branch 'efi-2022-01' of https://source.denx.de/u-boot/custodians/u-boot-efi (2021-11-20 09:36:37 -0500) are available in the Git repository at:

Re: [PATCH v7 3/3] efi_loader: Extend PCR's for firmware measurements

2021-11-26 Thread Ilias Apalodimas
Hi Ruchika, On Fri, 26 Nov 2021 at 13:53, Ruchika Gupta wrote: > > Firmwares before U-Boot may be capable of doing tpm measurements > and passing them to U-Boot in the form of eventlog. However there > may be scenarios where the firmwares don't have TPM driver and > are not capable of extending

Re: [PATCH v7 1/3] efi_loader: Add check for event log passed from firmware

2021-11-26 Thread Ilias Apalodimas
Hi Heinrich, > > +} > > > + > > > +/** > > > + * parse_specid_event() - Parse and verify the specID Event in the > > > eventlog > > > + * > > > + * @dev: udevice > > > + * @buffer: Pointer to the start of the eventlog > > > + * @log_size:Size of the eventlog >

Re: [PATCH v7 1/3] efi_loader: Add check for event log passed from firmware

2021-11-26 Thread Heinrich Schuchardt
On 11/26/21 14:52, Ilias Apalodimas wrote: On Fri, Nov 26, 2021 at 05:22:59PM +0530, Ruchika Gupta wrote: Platforms may have support to measure their initial firmware components and pass the event log to u-boot. The event log address can be passed in property tpm_event_log_addr and

[BUG] cppcheck results for efi_tcg2.c

2021-11-26 Thread Heinrich Schuchardt
Hello Masahisa, Ilias, Ruchika, please, have a look at the cppcheck results for efi_tcg2.c. [unusedFunction] may be due to checking a single file. [arithOperationsOnVoidPointer] you might ignore. But the rest should be addressed. Best regards Heinrich $ cppcheck lib/efi_loader/efi_tcg2.c

Re: [PATCH] include/linux/byteorder: fix cpu_to_be32_array()

2021-11-26 Thread Heinrich Schuchardt
On 5/23/21 21:54, Heinrich Schuchardt wrote: On 5/23/21 9:40 PM, Tom Rini wrote: This was fixed in what commit from Linux?  Thanks! include/linux/byteorder/generic.h in Linux is equally broken. This should not stop you from merging this patch. I will create a patch for Linux. Best

Re: [PATCH V2] clk: introduce u-boot,ignore-clk-defaults

2021-11-26 Thread Tom Rini
On Fri, Nov 26, 2021 at 01:17:10PM -0500, Sean Anderson wrote: > On 11/24/21 9:10 AM, Tom Rini wrote: > > On Tue, Nov 23, 2021 at 09:16:14PM -0500, Sean Anderson wrote: > > > On 11/22/21 10:02 PM, Peng Fan (OSS) wrote: > > > > > Subject: Re: [PATCH V2] clk: introduce u-boot,ignore-clk-defaults > >

Re: [PATCH V2] clk: introduce u-boot,ignore-clk-defaults

2021-11-26 Thread Sean Anderson
On 11/24/21 9:10 AM, Tom Rini wrote: On Tue, Nov 23, 2021 at 09:16:14PM -0500, Sean Anderson wrote: On 11/22/21 10:02 PM, Peng Fan (OSS) wrote: Subject: Re: [PATCH V2] clk: introduce u-boot,ignore-clk-defaults On Mon, Nov 22, 2021 at 11:33:27AM +0800, Peng Fan (OSS) wrote: + Rob On

Re: [RFC PATCH 3/3] imx: imx8mp_evk: override env_get_location

2021-11-26 Thread Marek Behún
On Fri, 26 Nov 2021 18:43:31 +0100 Tommaso Merciai wrote: > Override env_get_location function at board level, previously dropped > down from soc.c > > References: > - commit f1575f23df1ef704051f218d5bc4aeeb20c2c542 > > Signed-off-by: Tommaso Merciai > --- > Changes since v1: > - Remove

[RFC PATCH 3/3] imx: imx8mp_evk: override env_get_location

2021-11-26 Thread Tommaso Merciai
Override env_get_location function at board level, previously dropped down from soc.c References: - commit f1575f23df1ef704051f218d5bc4aeeb20c2c542 Signed-off-by: Tommaso Merciai --- Changes since v1: - Remove wrong env_get_offset function from commit board/freescale/imx8mp_evk/imx8mp_evk.c

[RFC PATCH 2/3] imx: imx8mn_evk: override env_get_location

2021-11-26 Thread Tommaso Merciai
Override env_get_location function at board level, previously dropped down from soc.c References: - commit f1575f23df1ef704051f218d5bc4aeeb20c2c542 Signed-off-by: Tommaso Merciai --- Changes since v1: - Remove wrong env_get_offset function from commit board/freescale/imx8mn_evk/imx8mn_evk.c

[RFC PATCH 1/3] imx8m: drop env_get_location for imx8mn and imx8mp

2021-11-26 Thread Tommaso Merciai
This function defined for two architecture is not really generic and can generate problem when people add a new board. Signed-off-by: Tommaso Merciai --- Changes since v1: - Fix commit: drop down only env_get_location arch/arm/mach-imx/imx8m/soc.c | 39 --- 1

[RFC PATCH 0/3] imx8m: move env_get_location for imx8mn and imx8mp at board level

2021-11-26 Thread Tommaso Merciai
This series move env_get_location from soc to board level. As suggested by Michael make no sense to define an unique way for multiple board. One board can boot from emmc and having env on spi flash etc.. Anyways, this function is kept in both imx8mn and imx8mp evk boards instead of being

Re: [PATCH v2 03/14] clk: mtmips: add clock driver for MediaTek MT7621 SoC

2021-11-26 Thread Sean Anderson
On 11/18/21 8:35 PM, Weijie Gao wrote: This patch adds a clock driver for MediaTek MT7621 SoC. This driver provides clock gate control as well as getting clock frequency for CPU/SYS/XTAL and some peripherals. Signed-off-by: Weijie Gao --- v2 changes: none --- drivers/clk/mtmips/Makefile

Re: [PATCH] board: ti: am43xx: pass boot device information from SPL to U-Boot proper

2021-11-26 Thread Michael Nazzareno Trimarchi
Hi Josef On Fri, Nov 26, 2021 at 10:56 AM Josef Lusticky wrote: > > TI AM43xx SoC supports various boot devices (peripherals). > There is already handoff mechanism prepared to allow passing > the information which boot device was used to load the SPL. > > Use the handoff mechanism to pass this

[PATCH] pinctrl: single: add support for pinctrl-single, pins when #pinctrl-cells = 2

2021-11-26 Thread AJ Bagwell
Changes to the am33xx device (33e9021a) trees have been merged in from the upstream linux kernel which now means the device tree uses the new pins format (as of 5.10) where the confinguration can be stores as a separate configuration value and pin mux mode which are then OR'd together. This patch

[PATCH 1/1] video: mxsfb: fix pixel clock polarity

2021-11-26 Thread Sébastien Szymanski
DISPLAY_FLAGS_PIXDATA_NEGEDGE means the controller drives the data on pixel clocks falling edge. That is DOTCLK_POL=0 (default) not 1. The same change has been made on the Linux's driver:

[PATCH 1/1] configs: opos6uldev: update to have screen working at power on

2021-11-26 Thread Sébastien Szymanski
Signed-off-by: Sébastien Szymanski --- configs/opos6uldev_defconfig | 3 --- 1 file changed, 3 deletions(-) diff --git a/configs/opos6uldev_defconfig b/configs/opos6uldev_defconfig index c52d2a5d39..409c48451e 100644 --- a/configs/opos6uldev_defconfig +++ b/configs/opos6uldev_defconfig @@

Re: [PATCH 00/16] tools: Add support for signing devicetree blobs

2021-11-26 Thread Rasmus Villemoes
On 12/11/2021 20.28, Simon Glass wrote: > At present mkimage supports signing FITs, the standard U-Boot image type. > > Various people are opposed to using FIT since: > > a) it requires adding support for FIT into other bootloaders, notably >UEFI > b) it requires packaging a kernel in this

[PATCH 5/5] board: sl28: add basic PSCI implementation

2021-11-26 Thread Michael Walle
For now, this only provides reset and poweroff functions. Signed-off-by: Michael Walle --- board/kontron/sl28/Makefile| 2 ++ board/kontron/sl28/psci.c | 42 ++ configs/kontron_sl28_defconfig | 2 ++ 3 files changed, 46 insertions(+) create mode

[PATCH 4/5] armv8: psci: add ARMV8_PSCI_RELOCATE Kconfig option

2021-11-26 Thread Michael Walle
There is an user-selectable SYS_HAS_ARMV8_SECURE_BASE, which has the same meaning but is just for the ls1043ardb board. As no in-tree config uses this, drop it and replace it with something more sophiticated: ARMV8_PSCI_RELOCATE. This option will then enable the ARMV8_SECURE_BASE option which is

[PATCH 3/5] armv8: psci: skip setup code if we are not EL3

2021-11-26 Thread Michael Walle
If we are running in EL2 skip PSCI implementation setup. This avoids an exception if CONFIG_ARMV8_PSCI is set, but u-boot is started by TF-A. Signed-off-by: Michael Walle --- arch/arm/cpu/armv8/cpu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/cpu/armv8/cpu.c

[PATCH 2/5] armv8: layerscape: get rid of smc_call()

2021-11-26 Thread Michael Walle
There are two different implementations to do a secure monitor call: smc_call() and arm_smccc_smc(). The former is defined in fwcall.c and seems to be an ad-hoc implementation. The latter is imported from linux. smc_call() is also only available if CONFIG_ARMV8_PSCI is not defined. This makes it

[PATCH 1/5] armv8: include psci_update_dt() unconditionally

2021-11-26 Thread Michael Walle
psci_update_dt() is also required if CONFIG_ARMV8_PSCI is set, that is, if u-boot is the PSCI provider. Guard the check which is intended to call into the PSCI implementation in the secure firmware, by the proper macro SEC_FIRMWARE_ARMV8_PSCI. Signed-off-by: Michael Walle ---

[PATCH 0/5] board: sl28: add basic PSCI implementation

2021-11-26 Thread Michael Walle
Add PSCI support to reset and power-off the board. Because this board can be used without TF-A, supply a (mandatory) PSCI implementation. The armv8 u-boot part already contains most bits for the implementation, it is just, that it isn't compatible with the layerscape parts. Thus, we first need to

[PATCH] armv8: sec_firmware: drop unneeded ARMV8_SEC_FIRMWARE_SUPPORT check

2021-11-26 Thread Michael Walle
This module will only be compiled if this symbol is set. Remove the useless check. While at it, invert the return code, to return 0 if the function succeeds. The only user of this function in arch/arm/cpu/armv8/fsl-layerscape/fdt.c doesn't check the return code anyway, so its safe change it.

Re: [PATCH v2 04/11] Convert CONFIG_PHYSMEM to Kconfig

2021-11-26 Thread Andy Shevchenko
On Thu, Nov 25, 2021 at 2:12 AM Simon Glass wrote: > On Wed, 24 Nov 2021 at 09:33, Andy Shevchenko > wrote: > > > > On Wed, Nov 24, 2021 at 6:28 PM Simon Glass wrote: > > > > > > This converts the following to Kconfig: > > >CONFIG_PHYSMEM > > > > Why? > > Because we want to avoid ad-hoc

Re: [PATCH v1 1/1] tools/netconsole: Add support for socat

2021-11-26 Thread Andy Shevchenko
On Fri, Nov 19, 2021 at 1:29 AM Ferry Toth wrote: > > Hi, > > Op 17-11-2021 om 18:15 schreef Andy Shevchenko: > > socat is a very powerful tool to work with socets (and not only) > > in UNIX systems. Let's add support for it in netconsole. > > > > Signed-off-by: Andy Shevchenko > Tested-by:

Re: [PATCH v3] efi_loader: check tcg2 protocol installation outside the TCG protocol

2021-11-26 Thread Ilias Apalodimas
Hi Kojima-san, On Fri, Nov 26, 2021 at 10:31:16AM +0900, Masahisa Kojima wrote: > There are functions that calls tcg2_agile_log_append() outside > of the TCG protocol invocation (e.g tcg2_measure_pe_image). > These functions must to check that tcg2 protocol is installed. > If not, measurement

[PATCH u-boot-marvell v2 9/9] arm: mvebu: spl: Fix 100 column exceeds

2021-11-26 Thread Marek Behún
From: Marek Behún Fix 100 column exceeds in arch/arm/mach-mvebu/spl.c. Signed-off-by: Marek Behún --- arch/arm/mach-mvebu/spl.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-mvebu/spl.c b/arch/arm/mach-mvebu/spl.c index 7dbe8eeba3..7450e1e3da 100644

[PATCH u-boot-marvell v2 8/9] arm: mvebu: spl: Use IS_ENABLED() instead of #ifdef where possible

2021-11-26 Thread Marek Behún
From: Marek Behún Use the preferred if (IS_ENABLED(X)) instead of #ifdef X where possible. There are still places where this is not possible or is more complicated to convert in this file. Leave those be for now. Signed-off-by: Marek Behún --- arch/arm/mach-mvebu/spl.c | 43

[PATCH u-boot-marvell v2 6/9] arm: mvebu: spl: Print srcaddr in error message

2021-11-26 Thread Marek Behún
From: Marek Behún Print the wrong srcaddr (spl_image->offset) in error message also for SATA case. Signed-off-by: Marek Behún --- arch/arm/mach-mvebu/spl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-mvebu/spl.c b/arch/arm/mach-mvebu/spl.c index

[PATCH u-boot-marvell v2 7/9] arm: mvebu: spl: Use preferred types u8/u16/u32 instead of uintN_t

2021-11-26 Thread Marek Behún
From: Marek Behún Checkpatch warns about using uint32/16/8_t instead of u32/16/8. Use the preferred types. Signed-off-by: Marek Behún --- arch/arm/mach-mvebu/spl.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git

[PATCH u-boot-marvell v2 5/9] arm: mvebu: Check for kwbimage data checksum

2021-11-26 Thread Marek Behún
From: Pali Rohár Last 4 bytes of kwbimage boot image is checksum. Verify it via the new spl_check_board_image() function which is called by U-Boot SPL after loading kwbimage. Signed-off-by: Pali Rohár Signed-off-by: Marek Behún Reviewed-by: Stefan Roese --- Changes since v1: - changed

[PATCH u-boot-marvell v2 2/9] SPL: Add struct spl_boot_device parameter into spl_parse_board_header()

2021-11-26 Thread Marek Behún
From: Pali Rohár Add parameter spl_boot_device to spl_parse_board_header(), which allows the implementations to see from which device we are booting and do boot-device-specific checks of the image header. Signed-off-by: Pali Rohár Signed-off-by: Marek Behún Reviewed-by: Stefan Roese ---

[PATCH u-boot-marvell v2 4/9] SPL: Add support for checking board / BootROM specific image types

2021-11-26 Thread Marek Behún
From: Pali Rohár Commit 9baab60b8054 ("SPL: Add support for parsing board / BootROM specific image types") added support for loading board specific image types. This commit adds support for a new weak function spl_parse_board_header() which is called after loading boot image. Board may

[PATCH u-boot-marvell v2 3/9] arm: mvebu: Check that kwbimage blockid matches boot mode

2021-11-26 Thread Marek Behún
From: Pali Rohár Each boot mode has its own kwbimage specified by blockid. So check that kwbimage is valid by blockid. Signed-off-by: Pali Rohár Signed-off-by: Marek Behún Reviewed-by: Stefan Roese --- Changes since v1: - updated error messages as requested by Stefan ---

[PATCH u-boot-marvell v2 1/9] arm: mvebu: Check that kwbimage offset and blocksize are valid

2021-11-26 Thread Marek Behún
From: Pali Rohár There are certain restrictions for kwbimage offset and blocksize. Validate them. Signed-off-by: Pali Rohár Signed-off-by: Marek Behún Reviewed-by: Stefan Roese --- Changes since v1: - updated error messages as requested by Stefan --- arch/arm/mach-mvebu/spl.c | 12

[PATCH u-boot-marvell v2 0/9] More verifications for kwbimage in SPL

2021-11-26 Thread Marek Behún
From: Marek Behún Hello Stefan, this is v2 of series that adds more checks for kwbimage validity and consistency to SPL, mainly checking image data checksum. Changes since v1: - updated error messages as requested by Stefan - fixed checkpatch warnings for uintN_t types (converted to preferred

Re: a question about falcon mode

2021-11-26 Thread Alex G.
On 11/26/21 1:53 AM, Chan Kim wrote: Hi Alex, Thanks for the reply. So I gather that to be able to use 'spl export fdt' to store the 'snapshot' to the storage I should make the spl program runnable at least to that stage. (being able to load kernel image, dtb, initrd and give the spl export

[PATCH u-boot-marvell RESEND 09/11] phy: marvell: a3700: Convert to official DT bindings in COMPHY driver

2021-11-26 Thread Marek Behún
From: Pali Rohár Convert A3720 common PHY driver to official DT bindings. This puts us closer to be able to synchronize A3720 device-trees with those from Linux. Signed-off-by: Pali Rohár Signed-off-by: Marek Behún Cc: Konstantin Porotchkin Cc: Robert Marko Cc: Luka Perkov Cc: Marcin

[PATCH u-boot-marvell RESEND 10/11] arm: mvebu: turris_mox: Fix unstable board topology reading

2021-11-26 Thread Marek Behún
From: Marek Behún The pre-relocation board topology reading in board_fix_fdt() is unstable: sometimes wrong data are read from the SPI bus. This is due to wrong order of SPI bus configuration instructions: we first need to set the pins to SPI mode, and only after that configure the bus. Also

[PATCH u-boot-marvell RESEND 11/11] fdt_support: Add fdt_delete_disabled_nodes() and use in Turris MOX

2021-11-26 Thread Marek Behún
From: Marek Behún Move Turris MOX specific remove_disabled_nodes() to fdt_support with name fdt_delete_disabled_nodes(), so that others can potentially use it. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese --- board/CZ.NIC/turris_mox/turris_mox.c | 20 +---

[PATCH u-boot-marvell RESEND 08/11] arm: mvebu: turris_mox: Enable eth1 in U-Boot if a network module is present

2021-11-26 Thread Marek Behún
From: Pali Rohár Enable eth1 node in U-Boot's device-tree if a network module (SFP, Topaz or Peridot) is detected. This is required for proper detection of eth1 comphy in a3700 comphy driver by the following patches. Signed-off-by: Pali Rohár Signed-off-by: Marek Behún Reviewed-by: Stefan

[PATCH u-boot-marvell RESEND 06/11] fdt_support: Add some useful functions

2021-11-26 Thread Marek Behún
From: Marek Behún Add functions fdt_node_offset_by_pathf(), fdt_create_phandle_by_pathf(), fdt_set_status_by_pathf() to get node offset, get/create node phandle and set status for node given by path/alias formatted with sprintf. Add functions fdt_create_phandle_by_compatible(),

[PATCH u-boot-marvell RESEND 04/11] fdt_support: Remove FDT_STATUS_FAIL_ERROR_CODE

2021-11-26 Thread Marek Behún
From: Marek Behún Since no one uses this feature and I am not aware of any parsers of this in Linux, remove it. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Cc: Simon Glass Cc: Andy Shevchenko Cc: Pratyush Yadav Cc: Tim Harvey Cc: Michael Walle Cc: Priyanka Jain ---

[PATCH u-boot-marvell RESEND 07/11] arm: mvebu: turris_mox: Find DT nodes by compatible or alias instead of path

2021-11-26 Thread Marek Behún
From: Marek Behún It is better to find DT nodes by compatible strings or aliases instead of path. There were issues with Linux some DTBs having different names of some nodes, e.g. internal-regs instead of internal-regs@d000 This should be a generic fix for such issues. Also since

[PATCH u-boot-marvell RESEND 05/11] fdt_support: Fix comment for fdt_create_phandle()

2021-11-26 Thread Marek Behún
From: Marek Behún This function does not necessarily create a new phandle. If a phandle exists, no new phandle is created. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese --- common/fdt_support.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/fdt_support.c

[PATCH u-boot-marvell RESEND 03/11] fdt_support: Remove fdt_alloc_phandle() in favor of fdt_generate_phandle()

2021-11-26 Thread Marek Behún
From: Marek Behún Commit f0921f5098d ("fdt: Sync up to the latest libfdt") introduced fdt_generate_phandle() in libfdt, making fdt_alloc_phandle() obsolete in fdt_support. Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Cc: Simon Glass Cc: "hui.song" Cc: Meenakshi Aggarwal Cc:

[PATCH u-boot-marvell RESEND 02/11] treewide: Use fdt_create_phandle() where appropriate

2021-11-26 Thread Marek Behún
From: Marek Behún Replace fdt_alloc_phandle() with subsequent fdt_set_phandle() by fdt_create_phandle(). Signed-off-by: Marek Behún Reviewed-by: Stefan Roese Cc: Aaron Williams Cc: Ramon Fried Cc: Vladimir Oltean --- board/Marvell/octeon_ebb7304/board.c | 5 ++---

[PATCH u-boot-marvell RESEND 00/11] Some mvebu comphy + mox + fdt_support changes

2021-11-26 Thread Marek Behún
From: Marek Behún Hello Stefan, as requested I am resending this series with board maintainers added in Ccs. Original message: Pali prepared patches that convert A3720 comphy driver to use Linux' DT bindings. (Yes, I have patches that convert the whole driver into using SMC calls into ATF,

[PATCH u-boot-marvell RESEND 01/11] include/linux/byteorder: Fix compilation of __constant_cpu_to_be32()

2021-11-26 Thread Marek Behún
From: Pali Rohár The macro __constant_cpu_to_be32() uses ___constant_swab32(), which for some reason is not defined and causes the following error during compilation: include/linux/byteorder/little_endian.h:28:52: warning: implicit declaration of function ‘___constant_swab32’; did you

Re: [PATCH v7 1/3] efi_loader: Add check for event log passed from firmware

2021-11-26 Thread Ilias Apalodimas
On Fri, Nov 26, 2021 at 05:22:59PM +0530, Ruchika Gupta wrote: > Platforms may have support to measure their initial firmware components > and pass the event log to u-boot. The event log address can be passed > in property tpm_event_log_addr and tpm_event_log_size of the tpm node. > Platforms may

Re: [RESEND RFC PATCH 09/10] FWU: Add support for FWU Multi Bank Update feature

2021-11-26 Thread Heinrich Schuchardt
On 11/25/21 08:13, Sughosh Ganu wrote: The FWU Multi Bank Update feature supports updation of firmware images to one of multiple sets(also called banks) of images. The firmware images are clubbed together in banks, with the system booting images from the active bank. Information on the images

Re: [RESEND RFC PATCH 00/10] FWU: Add support for FWU Multi Bank Update feature

2021-11-26 Thread Ilias Apalodimas
Hi Heincrich, On Fri, Nov 26, 2021 at 01:29:02PM +0100, Heinrich Schuchardt wrote: > On 11/25/21 08:12, Sughosh Ganu wrote: > > (resending to including the first paragraph which got deleted for some > > reason). > > > > The patchset adds support for the FWU Multi Bank Update[1] > > The patch

Re: [RESEND RFC PATCH 07/10] EFI: FMP: Add provision to update image's ImageTypeId in image descriptor

2021-11-26 Thread Heinrich Schuchardt
On 11/25/21 08:12, Sughosh Ganu wrote: The FWU Multi Banks Update feature allows updating different types of updatable firmware images on the platform. These image types are identified using the ImageTypeId GUID value. Add support in the GetImageInfo function of the FMP protocol to get the GUID

Re: [RESEND RFC PATCH 00/10] FWU: Add support for FWU Multi Bank Update feature

2021-11-26 Thread Heinrich Schuchardt
On 11/25/21 08:12, Sughosh Ganu wrote: (resending to including the first paragraph which got deleted for some reason). The patchset adds support for the FWU Multi Bank Update[1] The patch set is lacking a documentation update The patch set is lacking an integration test. Please, add both to

[PATCH v7 3/3] efi_loader: Extend PCR's for firmware measurements

2021-11-26 Thread Ruchika Gupta
Firmwares before U-Boot may be capable of doing tpm measurements and passing them to U-Boot in the form of eventlog. However there may be scenarios where the firmwares don't have TPM driver and are not capable of extending the measurements in the PCRs. Based on TCG spec, if previous firnware has

[v7 PATCH 2/3] tpm: use more algorithms than sha256 on pcr_read

2021-11-26 Thread Ruchika Gupta
The current tpm2_pcr_read is hardcoded using SHA256. Make the actual command to TPM configurable to use wider range of algorithms. The current command line is kept as is i.e limited to SHA-256 only. Signed-off-by: Ruchika Gupta Reviewed-by: Ilias Apalodimas --- v7: No change v6: No change v5:

[PATCH v7 1/3] efi_loader: Add check for event log passed from firmware

2021-11-26 Thread Ruchika Gupta
Platforms may have support to measure their initial firmware components and pass the event log to u-boot. The event log address can be passed in property tpm_event_log_addr and tpm_event_log_size of the tpm node. Platforms may choose their own specific mechanism to do so. A weak function is added

Re: [RESEND RFC PATCH 03/10] FWU: Add metadata structure and functions for accessing metadata

2021-11-26 Thread Ilias Apalodimas
Hi Sughosh, On Thu, Nov 25, 2021 at 12:42:55PM +0530, Sughosh Ganu wrote: > In the FWU Multi Bank Update feature, the information about the > updatable images is stored as part of the metadata, which is stored on > a dedicated partition. Add the metadata structure, and functions to > access the

Re: [RESEND PATCH] rpi: Copy properties from firmware dtb to the loaded dtb

2021-11-26 Thread Matthias Brugger
On 25/11/2021 20:42, Sjoerd Simons wrote: The RPI firmware adjusts several property values in the dtb it passes to u-boot depending on the board/SoC revision. Inherit some of these when u-boot loads a dtb itself. Specificaly copy: * /model: The firmware provides a more specific string *

[PATCH u-boot-next 12/12] pci: sh7751: Fix access to config space via PCI_CONF1_ADDRESS() macro

2021-11-26 Thread Pali Rohár
sh7751 platform uses standard format of Config Address for PCI Configuration Mechanism #1. Commit 72c2f4acd76f ("pci: sh7751: Convert to DM and DT probing") which did conversion of PCI sh7751 driver to DM, broke access to config space as that commit somehow swapped device and function bits in

[PATCH u-boot-next 11/12] m68k: mcf5445x: pci: Use PCI_CONF1_ADDRESS() macro

2021-11-26 Thread Pali Rohár
mcf5445x platform uses standard format of Config Address for PCI Configuration Mechanism #1. So use new U-Boot macro PCI_CONF1_ADDRESS(). Signed-off-by: Pali Rohár --- arch/m68k/cpu/mcf5445x/pci.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

[PATCH u-boot-next 10/12] x86: pci: Use PCI_CONF1_ADDRESS() macro

2021-11-26 Thread Pali Rohár
x86 platform uses standard format of Config Address for PCI Configuration Mechanism #1. So use new U-Boot macro PCI_CONF1_ADDRESS(). Signed-off-by: Pali Rohár --- arch/x86/cpu/pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/cpu/pci.c b/arch/x86/cpu/pci.c

[PATCH u-boot-next 08/12] pci: mediatek: Use PCI_CONF1_EXT_ADDRESS() macro

2021-11-26 Thread Pali Rohár
PCI mediatek driver uses extended format of Config Address for PCI Configuration Mechanism #1 but with cleared Enable bit. So use new U-Boot macro PCI_CONF1_EXT_ADDRESS() with clearing PCI_CONF1_ENABLE bit and remove old custom driver address macros. Signed-off-by: Pali Rohár ---

[PATCH u-boot-next 09/12] pci: sh7780: Use PCI_CONF1_ADDRESS() macro

2021-11-26 Thread Pali Rohár
PCI sh7780 driver uses standard format of Config Address for PCI Configuration Mechanism #1. So use new U-Boot macro PCI_CONF1_ADDRESS(). Signed-off-by: Pali Rohár --- drivers/pci/pci_sh7780.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pci/pci_sh7780.c

[PATCH u-boot-next 06/12] pci: tegra: Use PCI_CONF1_EXT_ADDRESS() macro

2021-11-26 Thread Pali Rohár
PCI tegra driver uses extended format of Config Address for PCI Configuration Mechanism #1 but with cleared Enable bit. So use new U-Boot macro PCI_CONF1_EXT_ADDRESS() with clearing PCI_CONF1_ENABLE bit and remove old custom driver address function. Signed-off-by: Pali Rohár ---

[PATCH u-boot-next 07/12] pci: fsl: Use PCI_CONF1_EXT_ADDRESS() macro

2021-11-26 Thread Pali Rohár
PCI fsl driver uses extended format of Config Address for PCI Configuration Mechanism #1. So use new U-Boot macro PCI_CONF1_EXT_ADDRESS(). Signed-off-by: Pali Rohár --- drivers/pci/pcie_fsl.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/pci/pcie_fsl.c

[PATCH u-boot-next 05/12] pci: mvebu: Use PCI_CONF1_EXT_ADDRESS() macro

2021-11-26 Thread Pali Rohár
PCI mvebu driver uses extended format of Config Address for PCI Configuration Mechanism #1. So use new U-Boot macro PCI_CONF1_EXT_ADDRESS() and remove old custom driver address macros. Signed-off-by: Pali Rohár --- drivers/pci/pci_mvebu.c | 17 - 1 file changed, 4

[PATCH u-boot-next 02/12] pci: gt64120: Use PCI_CONF1_ADDRESS() macro

2021-11-26 Thread Pali Rohár
PCI gt64120 driver uses standard format of Config Address for PCI Configuration Mechanism #1. So use new U-Boot macro PCI_CONF1_ADDRESS() and remove old custom driver address macros. Signed-off-by: Pali Rohár --- drivers/pci/pci_gt64120.c | 7 ++- include/gt64120.h | 12

[PATCH u-boot-next 04/12] pci: msc01: Use PCI_CONF1_ADDRESS() macro

2021-11-26 Thread Pali Rohár
PCI msc01 driver uses standard format of Config Address for PCI Configuration Mechanism #1 but with cleared Enable bit. So use new U-Boot macro PCI_CONF1_ADDRESS() with clearing PCI_CONF1_ENABLE bit and remove old custom driver address macros. Signed-off-by: Pali Rohár ---

[PATCH u-boot-next 03/12] pci: mpc85xx: Use PCI_CONF1_EXT_ADDRESS() macro

2021-11-26 Thread Pali Rohár
PCI mpc85xx driver uses extended format of Config Address for PCI Configuration Mechanism #1. So use new U-Boot macro PCI_CONF1_EXT_ADDRESS(). Signed-off-by: Pali Rohár --- drivers/pci/pci_mpc85xx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH u-boot-next 01/12] pci: Add standard PCI Config Address macros

2021-11-26 Thread Pali Rohár
Lot of PCI and PCIe controllers are using standard Config Address for PCI Configuration Mechanism #1 or its extended version. So add PCI_CONF1_ADDRESS() and PCI_CONF1_EXT_ADDRESS() macros into U-Boot's pci.h header file which can be suitable for most PCI and PCIe controller drivers. Drivers do

[PATCH u-boot-next 00/12] Common U-Boot macros for PCI Configuration Mechanism #1

2021-11-26 Thread Pali Rohár
This patch series add new U-Boot macros for composing Config Address for PCI Configuration Mechanism #1 as defined in PCI Local Bus Specification, including extended variant (which do not have any formal specification) and then use these new macros (PCI_CONF1_ADDRESS and PCI_CONF1_EXT_ADDRESS) in

Re: [PATCH v6 1/3] efi_loader: Add check for event log passed from firmware

2021-11-26 Thread Ruchika Gupta
Hi Heinrich, On Fri, 26 Nov 2021 at 13:01, Heinrich Schuchardt wrote: > On 11/26/21 06:00, Ruchika Gupta wrote: > > Platforms may have support to measure their initial firmware components > > and pass the event log to u-boot. The event log address can be passed > > in property

Re: [PATCH v3 2/2] usb: gadget: Add CDC ACM function

2021-11-26 Thread Pali Rohár
On Friday 26 November 2021 09:39:18 Loic Poulain wrote: > Hi Pali, > > On Thu, 25 Nov 2021 at 19:10, Pali Rohár wrote: > > > > On Thursday 25 November 2021 18:16:15 Loic Poulain wrote: > > > Add support for CDC ACM using the new UDC and gadget API. This protocol > > > can be used for serial over

[PATCH] board: ti: am43xx: pass boot device information from SPL to U-Boot proper

2021-11-26 Thread Josef Lusticky
TI AM43xx SoC supports various boot devices (peripherals). There is already handoff mechanism prepared to allow passing the information which boot device was used to load the SPL. Use the handoff mechanism to pass this information to U-Boot proper and set the "boot_device" environment variable in

Re: [PATCH v5 3/3] mtd: spi-nor-core: Add support for Macronix Octal flash

2021-11-26 Thread liao jaime
Hi Tudor > > On 11/18/21 12:13 PM, JaimeLiao wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > Adding Macronix Octal flash for Octal DTR support. > > > > The octaflash series can be divided into the following types: > > > > MX25

Re: [PATCH v3 2/2] usb: gadget: Add CDC ACM function

2021-11-26 Thread Loic Poulain
Hi Pali, On Thu, 25 Nov 2021 at 19:10, Pali Rohár wrote: > > On Thursday 25 November 2021 18:16:15 Loic Poulain wrote: > > Add support for CDC ACM using the new UDC and gadget API. This protocol > > can be used for serial over USB data transfer and is widely supported > > by various OS

Re: [PATCH v6 1/3] efi_loader: Add check for event log passed from firmware

2021-11-26 Thread Ilias Apalodimas
Hi Heinrich, > > > + > > + /* > > +* initialize log area as 0xff so the OS can easily figure out the > > +* last log entry > > Where is this standardized? > > EFI_TCG2_PROTOCOL.GetEventLog() returns EventLogLastEntry to indicate > the last log entry. > Indeed. However while I was