Re: [PATCH v2] phy: Track power-on and init counts in uclass

2021-12-30 Thread Peter Robinson
On Tue, Dec 28, 2021 at 12:55 PM Tom Rini wrote: > > On Tue, Dec 28, 2021 at 01:34:18AM -0700, Simon Glass wrote: > > Hi Alper, > > > > On Fri, 24 Dec 2021 at 06:06, Alper Nebi Yasak > > wrote: > > > > > > On boards using the RK3399 SoC, the USB OHCI and EHCI controllers share > > > the same

Re: [PATCH v8 20/25] x86: efi: Don't set up global_data again with EFI

2021-12-30 Thread Heinrich Schuchardt
On 12/29/21 19:57, Simon Glass wrote: Since EFI does not relocate and uses the same global_data pointer throughout the board-init process, drop this unnecessary setup, to avoid a hang. Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt

Re: [PATCH v8 19/25] x86: efi: Show the system-table revision

2021-12-30 Thread Heinrich Schuchardt
On 12/29/21 19:57, Simon Glass wrote: Show the revision of this table as it can be important. Also update the 'efi table' entry to show the actual address of the EFI table rather than our table that points to it. This saves a step and the intermediate table has nothing else in it.

Re: [PATCH v8 16/25] efi: Allow easy selection of serial-only operation

2021-12-30 Thread Heinrich Schuchardt
On 12/29/21 19:57, Simon Glass wrote: Add info about how to select vidconsole or serial. Also set up a demo boot command. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Add a better boot command too include/configs/efi-x86_app.h | 25 + 1

Re: [PATCH v8 15/25] efi: Show when allocated pages are used

2021-12-30 Thread Heinrich Schuchardt
On 12/29/21 19:57, Simon Glass wrote: Add a message here so that both paths of memory allocation are reported. Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt

Re: [PATCH v8 14/25] efi: Mention that efi_info_get() is only used in the stub

2021-12-30 Thread Heinrich Schuchardt
On 12/29/21 19:57, Simon Glass wrote: This provides access to EFI tables after U-Boot has exited boot services. It is not needed in the app since boot services remain alive and we can just call them whenever needed. Add a comment to explain this. Signed-off-by: Simon Glass --- (no changes

Re: [PATCH v8 13/25] efi: Check for failure when initing the app

2021-12-30 Thread Heinrich Schuchardt
On 12/29/21 19:57, Simon Glass wrote: The stub checks for failure with efi_init(). Add this for the app as well. It is unlikely that anything can be done, but we may as well stop. Signed-off-by: Simon Glass --- (no changes since v6) Changes in v6: - Use 'U-Boot' instead of 'ARP' typo

Re: [PATCH v8 12/25] efi: Move exit_boot_services into a function

2021-12-30 Thread Heinrich Schuchardt
On 12/29/21 19:57, Simon Glass wrote: At present this code is inline in the app and stub. But they do the same thing. The difference is that the stub does it immediately and the app doesn't want to do it until the end (when it boots a kernel) or not at all, if returning to UEFI. Move it into a

Re: [PATCH v8 11/25] efi: Share struct efi_priv between the app and stub code

2021-12-30 Thread Heinrich Schuchardt
On 12/29/21 19:57, Simon Glass wrote: At present each of these has its own static variable and helper functions. Move them into a shared file. Signed-off-by: Simon Glass --- (no changes since v1) include/efi.h | 21 + lib/efi/efi.c | 29

Re: [PATCH v8 10/25] efi: Add a few comments to the stub

2021-12-30 Thread Heinrich Schuchardt
On 12/29/21 19:57, Simon Glass wrote: Comment some functions that need more information. Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt

Re: [PATCH v8 09/25] efi: Fix ll_boot_init() operation with the app

2021-12-30 Thread Heinrich Schuchardt
On 12/29/21 19:57, Simon Glass wrote: This should return false when the EFI app is running, since UEFI has done the required low-level init. Fix it. Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt

Re: [PATCH v2 03/14] clk: mtmips: add clock driver for MediaTek MT7621 SoC

2021-12-30 Thread Sean Anderson
On 12/27/21 3:06 AM, Weijie Gao wrote: On Wed, 2021-12-15 at 11:11 -0500, Sean Anderson wrote: It is fine to implement only the necessary functionality, but it should be done in a way which is easy to extend in the future, and which won't cause us compatibility problems. Generally, I would

[PATCH 2/2] ARM: dts: imx: Synchronize iMX6QDL DHCOM PDK2 DTs with Linux 5.15.12

2021-12-30 Thread Marek Vasut
Synchronize DH DHCOM DTs with Linux commit 25960cafa06e ("Linux 5.15.12"). There is no functional change to the resulting DTs. The imx6qdl-dhcom-pdk2.dtsi had to be adjusted with additional headers, gpio.h, pwm.h, input.h, else the DT cannot be compiled, the same change is likely necessary in

[PATCH 1/2] ARM: dts: imx: Add labels to remaining anatop regulators

2021-12-30 Thread Marek Vasut
Add labels to remaining anatop regulators, so their supplies can be assigned in board DTs. This is similar to Linux kernel commit 93385546ba369 ("ARM: dts: imx6qdl-sabresd: Assign corresponding power supply for LDOs") except it does not contain the unrelated sabresd changes. Signed-off-by: Marek

[PATCH 2/2] ARM: dts: stm32: Synchronize DHCOM DTs with Linux 5.15.12

2021-12-30 Thread Marek Vasut
Synchronize DH DHCOM DTs with Linux commit 25960cafa06e ("Linux 5.15.12"). There is no functional change to the resulting DTs. The eeprom0 alias and PHY reset GPIO are now reinstated in SoM u-boot dtsi. Signed-off-by: Marek Vasut Cc: Patrice Chotard Cc: Patrick Delaunay ---

[PATCH 1/2] ARM: dts: stm32: Synchronize DHCOR DTs with Linux 5.15.12

2021-12-30 Thread Marek Vasut
Synchronize DH DHCOR DTs with Linux commit 25960cafa06e ("Linux 5.15.12"). There is no functional change to the resulting DTs. The eeprom0 alias is now reinstated in SoM u-boot dtsi, the PHY reset GPIO is reinstated in AV96 u-boot dtsi. Signed-off-by: Marek Vasut Cc: Patrice Chotard Cc: Patrick

Re: Boot Linux FIT image from SPL

2021-12-30 Thread Fabio Estevam
Hi Sven, On Thu, Dec 30, 2021 at 6:22 PM Sven Schwermer wrote: > > Hi Fabio, > > Thank you for the hint. That's a _very_ useful document. In the > meantime, I have been able to boot my Linux FIT image straight from SPL > on my i.MX6ULL platform. Glad you got it to work. It would be nice if you

Re: Boot Linux FIT image from SPL

2021-12-30 Thread Sven Schwermer
Hi Fabio, Thank you for the hint. That's a _very_ useful document. In the meantime, I have been able to boot my Linux FIT image straight from SPL on my i.MX6ULL platform. I have, however, noticed that Linux boots much faster when launched from u-boot proper compared to SPL. Time to

[PATCH v3] phy: Track power-on and init counts in uclass

2021-12-30 Thread Alper Nebi Yasak
On boards using the RK3399 SoC, the USB OHCI and EHCI controllers share the same PHY device instance. While these controllers are being stopped they both attempt to power-off and deinitialize it, but trying to power-off the deinitialized PHY device results in a hang. This usually happens just

[PATCH v3 5/6] rockchip: spl: replace ifdef by IS_ENABLED for timer_init() call condition

2021-12-30 Thread Johan Jonker
Not all Rockchip SoC models use the ARM arch timer. Call the function timer_init() only when CONFIG_SYS_ARCH_TIMER is available. Replace the ifdef call condition by IS_ENABLED to increase build coverage and make the code easier to read. Signed-off-by: Johan Jonker ---

[PATCH v3 6/6] rockchip: tpl: use IS_ENABLED for timer_init() call condition

2021-12-30 Thread Johan Jonker
Not all Rockchip SoC models use the ARM arch timer. Call the function timer_init() only when CONFIG_SYS_ARCH_TIMER is available. Use the call condition IS_ENABLED to increase build coverage and make the code easier to read. Signed-off-by: Johan Jonker --- arch/arm/mach-rockchip/tpl.c | 5 +++--

[PATCH v3 4/6] rockchip: tpl: change call condition rockchip_stimer_init()

2021-12-30 Thread Johan Jonker
The Rockchip SoCs rk3066/rk3188 have no CONFIG_ROCKCHIP_STIMER_BASE defined. Currently only rk3188 has an exception. Make this more generic and call the function rockchip_stimer_init() only when CONFIG_ROCKCHIP_STIMER_BASE is available. Signed-off-by: Johan Jonker --- Changed V3: use

[PATCH v3 3/6] rockchip: spl: change call condition rockchip_stimer_init()

2021-12-30 Thread Johan Jonker
The Rockchip SoCs rk3066/rk3188 have no CONFIG_ROCKCHIP_STIMER_BASE defined. Currently only rk3188 has an exception. Make this more generic and call the function rockchip_stimer_init() only when CONFIG_ROCKCHIP_STIMER_BASE is available. Signed-off-by: Johan Jonker --- Changed V3: use

[PATCH v3 2/6] rockchip: move CONFIG_SYS_ARCH_TIMER to Kconfig

2021-12-30 Thread Johan Jonker
The config item SYS_ARCH_TIMER is default y if ARM64. Move CONFIG_SYS_ARCH_TIMER to Kconfig for the Rockchip CPU_V7A SoCs that have ARM Generic Timer support. Signed-off-by: Johan Jonker --- arch/arm/mach-rockchip/rk3036/Kconfig | 3 +++ arch/arm/mach-rockchip/rk3128/Kconfig | 3 +++

[PATCH v3 1/6] rockchip: move ROCKCHIP_STIMER_BASE to Kconfig

2021-12-30 Thread Johan Jonker
Move ROCKCHIP_STIMER_BASE to Kconfig. Signed-off-by: Johan Jonker --- Changed V3: add ROCKCHIP_STIMER --- arch/arm/mach-rockchip/Kconfig| 22 ++ arch/arm/mach-rockchip/px30/Kconfig | 3 +++ arch/arm/mach-rockchip/rk3036/Kconfig | 3 +++

[PATCH] spl: Convert SYS_MMCSD_RAW_MODE_KERNEL_SECTOR to Kconfig

2021-12-30 Thread Alexandru Gagniuc
Falcon mode is very useful in improving boot speed. A question that Falcon mode asks is "Where do I look for the kernel". With MMC boot media, the correct answer is CONFIG_SYS_MMCSD_RAW_MODE_KERNEL_SECTOR. The scope of this patch is to move this to Kconfig. It is possible for a system to support

Re: [PATCH v2 1/1] fastboot: fb_getvar: Add getvar_logical_blocksize for NXP mfgtool

2021-12-30 Thread Sean Anderson
On 12/29/21 8:35 AM, Angus Ainslie wrote: Hi Sean, On 2021-12-28 08:59, Sean Anderson wrote: Hi Angus, NXP's mfgtool queies the mmc blocksize and splits a sparse image into blocksize size pieces for the upload. It's still not clear to me why this is necessary. fastboot (for example)

[PATCH v1 1/1] env: fat: Allow overriding interface, device and partition

2021-12-30 Thread hyyxohk
For platform which can boot on different device, this allows to override interface, device and partition from board code. Signed-off-by: hyyxohk --- env/fat.c | 30 +- include/env_internal.h | 20 2 files changed, 37 insertions(+),

Re: help on udoo_neo power up on mainline uboot

2021-12-30 Thread Peter Robinson
On Thu, Dec 30, 2021 at 2:12 PM Fabio Estevam wrote: > > Hi Peter, > > On Thu, Dec 30, 2021 at 11:08 AM Peter Robinson wrote: > > > That works for my Full board. Interestingly in my playing I had got to > > similar and had wondered about whether the checkboard function was > > needed. > > > >

Re: help on udoo_neo power up on mainline uboot

2021-12-30 Thread Fabio Estevam
Hi Peter, On Thu, Dec 30, 2021 at 11:08 AM Peter Robinson wrote: > That works for my Full board. Interestingly in my playing I had got to > similar and had wondered about whether the checkboard function was > needed. > > One minor query on the above is it worth assigning the board_string >

Re: help on udoo_neo power up on mainline uboot

2021-12-30 Thread Peter Robinson
On Wed, Dec 29, 2021 at 11:07 PM Fabio Estevam wrote: > > Hi Peter and Tommaso, > > On Wed, Dec 29, 2021 at 7:38 PM Fabio Estevam wrote: > > > Yes, according to Peter, the failure comes only during the second call > > to get_board_value() > > I managed to get my Udoo Neo board working again. > >

Re: [PATCH v8 08/25] efi: Add comments to struct efi_priv

2021-12-30 Thread Heinrich Schuchardt
On 12/29/21 19:57, Simon Glass wrote: This structure is uncommented. Fix it. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Drop comments that confuse sphinx - Move device_path path change to its own patch include/efi.h | 23 +++ 1 file changed,

Re: [PATCH v8 05/25] x86: Don't process the kernel command line unless enabled

2021-12-30 Thread Simon Glass
Hi Heinrich, On Thu, 30 Dec 2021 at 06:16, Heinrich Schuchardt wrote: > > On 12/29/21 19:57, Simon Glass wrote: > > If the 'bootm' command is not enabled then this code is not available and > > this causes a link error. Fix it. > > > > Note that for the EFI app, there is no indication of missing

Re: [PATCH v8 07/25] efi: Drop device_path from struct efi_priv

2021-12-30 Thread Heinrich Schuchardt
On 12/29/21 19:57, Simon Glass wrote: This is not used anywhere drop it. Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt --- (no changes since v3) Changes in v3: - Move device_path path change to its own patch include/efi.h | 1 - 1 file changed, 1 deletion(-) diff

Re: [PATCH v8 06/25] x86: efi: Add room for the binman definition in the dtb

2021-12-30 Thread Heinrich Schuchardt
On 12/29/21 19:57, Simon Glass wrote: At present only 4KB of spare space is left in the DTB when building the EFI app. Increase this to 32KB so there is plenty of space to insert the binman definition. This cannot be expanded later (as with OF_SEPARATE) because the ELF image has already been

Re: [PATCH v8 05/25] x86: Don't process the kernel command line unless enabled

2021-12-30 Thread Heinrich Schuchardt
On 12/29/21 19:57, Simon Glass wrote: If the 'bootm' command is not enabled then this code is not available and this causes a link error. Fix it. Note that for the EFI app, there is no indication of missing code. It just hangs! Signed-off-by: Simon Glass --- (no changes since v1)

Re: [PATCH v8 02/25] efi: Locate all block devices in the app

2021-12-30 Thread Heinrich Schuchardt
On 12/29/21 19:57, Simon Glass wrote: When starting the app, locate all block devices and make them available to U-Boot. This allows listing partitions and accessing files in filesystems. EFI also has the concept of 'disks', meaning boot media. For now, this is not obviously useful in U-Boot,

Re: [PATCH v8 01/25] efi: Make unicode printf available to the app

2021-12-30 Thread Heinrich Schuchardt
On 12/29/21 19:57, Simon Glass wrote: This is needed to show unicode strings. Enable this code in the app. Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt