Re: [RFC PATCH v3 2/9] FWU: Add FWU metadata access functions for GPT partitioned block devices

2022-01-23 Thread AKASHI Takahiro
On Mon, Jan 24, 2022 at 12:28:24PM +0530, Sughosh Ganu wrote: > hi Masami, > > On Thu, 20 Jan 2022 at 14:13, Masami Hiramatsu > wrote: > > > > Hi Sughosh, > > > > 2022年1月20日(木) 3:56 Sughosh Ganu : > > > > > +static int fwu_gpt_update_mdata(struct fwu_mdata *mdata) > > > +{ > > > + int ret;

Re: [PATCH 6/8] cmd: efidebug: simplify printing GUIDs

2022-01-23 Thread AKASHI Takahiro
On Fri, Jan 21, 2022 at 05:03:03PM +0100, Heinrich Schuchardt wrote: > On 1/21/22 16:20, Simon Glass wrote: > > Hi Heinrich, > > > > On Sun, 16 Jan 2022 at 08:14, Heinrich Schuchardt > > wrote: > > > > > > Use "%pS" to print text representations of GUIDs. > > > > > > Signed-off-by: Heinrich

Re: [RFC PATCH v3 3/9] FWU: stm32mp1: Add helper functions for accessing FWU metadata

2022-01-23 Thread Sughosh Ganu
hi Masami, On Mon, 24 Jan 2022 at 08:16, Masami Hiramatsu wrote: > > Hi Sughosh, > > BTW, I can't find the definition of CONFIG_FWU_NUM_IMAGES_PER_BANK and > CONFIG_FWU_NUM_BANKS for this platform. > Is it really possible to build this platform with FWU_MULTI_BANK_UPDATE? Yes, I have actually

Re: [RFC PATCH v3 2/9] FWU: Add FWU metadata access functions for GPT partitioned block devices

2022-01-23 Thread Masami Hiramatsu
Hi Sughosh, 2022年1月24日(月) 15:58 Sughosh Ganu : > > hi Masami, > > On Thu, 20 Jan 2022 at 14:13, Masami Hiramatsu > wrote: > > > > Hi Sughosh, > > > > 2022年1月20日(木) 3:56 Sughosh Ganu : > > > > > +static int fwu_gpt_update_mdata(struct fwu_mdata *mdata) > > > +{ > > > + int ret; > > > +

[PATCH] binman: doc: fix typo for u-boot-tpl

2022-01-23 Thread Heiko Thiery
Cc: Simon Glass Signed-off-by: Heiko Thiery --- tools/binman/binman.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/binman/binman.rst b/tools/binman/binman.rst index 3e063d1f86..3eedfdfe78 100644 --- a/tools/binman/binman.rst +++ b/tools/binman/binman.rst @@ -707,7

Re: [RFC PATCH v3 1/9] FWU: Add FWU metadata structure and functions for accessing metadata

2022-01-23 Thread Sughosh Ganu
hi Masami, On Thu, 20 Jan 2022 at 11:35, Masami Hiramatsu wrote: > > Hi Sughosh, > > I have another comment on this patch. > > 2022年1月20日(木) 3:56 Sughosh Ganu : > > > +/** > > + * fwu_update_active_index() - Update active_index from the FWU metadata > > + * @active_idx: active_index value to be

Re: [RFC PATCH v3 1/9] FWU: Add FWU metadata structure and functions for accessing metadata

2022-01-23 Thread Sughosh Ganu
hi Masami, On Thu, 20 Jan 2022 at 11:23, Masami Hiramatsu wrote: > > Hello Sughosh, > > 2022年1月20日(木) 3:56 Sughosh Ganu : > > > > In the FWU Multi Bank Update feature, the information about the > > updatable images is stored as part of the metadata, which is stored on > > a dedicated partition.

Re: [RFC PATCH v3 2/9] FWU: Add FWU metadata access functions for GPT partitioned block devices

2022-01-23 Thread Sughosh Ganu
hi Masami, On Thu, 20 Jan 2022 at 14:13, Masami Hiramatsu wrote: > > Hi Sughosh, > > 2022年1月20日(木) 3:56 Sughosh Ganu : > > > +static int fwu_gpt_update_mdata(struct fwu_mdata *mdata) > > +{ > > + int ret; > > + struct blk_desc *desc; > > + u16 primary_mpart = 0, secondary_mpart

Re: [RFC PATCH v3 5/9] EFI: FMP: Add provision to update image's ImageTypeId in image descriptor

2022-01-23 Thread Sughosh Ganu
On Mon, 24 Jan 2022 at 08:03, AKASHI Takahiro wrote: > > On Fri, Jan 21, 2022 at 12:32:04PM +0530, Sughosh Ganu wrote: > > hi Takahiro, > > > > On Thu, 20 Jan 2022 at 10:54, AKASHI Takahiro > > wrote: > > > > > > On Thu, Jan 20, 2022 at 12:25:44AM +0530, Sughosh Ganu wrote: > > > > The FWU Multi

[PATCH v5 3/3] arm: kirkwood: Pogoplug-V4 : Add board implementation files

2022-01-23 Thread Tony Dinh
Add board header, defconfig, and implementation files for Pogoplug V4. Signed-off-by: Tony Dinh --- Changes in v5: - Currently, CONFIG_RESET_PHY_R symbol is used in arch/arm/mach-kirkwood/include/mach/config.h for all Kirkwood boards with mv8831116 PHY, with each board defines the function

[PATCH v5 2/3] arm: kirkwood: Pogoplug-V4 : Add Kconfig files

2022-01-23 Thread Tony Dinh
Add Kconfig files for Pogoplug V4 board Signed-off-by: Tony Dinh --- (no changes since v3) Changes in v3: - Migrate symbols from board include header to Kconfig arch/arm/mach-kirkwood/Kconfig | 6 ++ board/cloudengines/pogo_v4/Kconfig | 16 2 files changed, 22

[PATCH v5 1/3] arm: kirkwood: Pogoplug-V4 : Add DTS files

2022-01-23 Thread Tony Dinh
Add DTS files for Pogoplug V4 board Reviewed-by: Stefan Roese Signed-off-by: Tony Dinh --- (no changes since v2) Changes in v2: - Use mainline Linux DTS version arch/arm/dts/Makefile | 1 + arch/arm/dts/kirkwood-pogoplug-series-4.dts | 180 2

[PATCH v5 0/3] arm: kirkwood: Add support for Pogoplug V4

2022-01-23 Thread Tony Dinh
Pogoplug V4 specifications: Kirkwood 88F6192 SoC 800 MHz CPU 1Gbs Ethernet 128 MB RAM 128 MB NAND 1x USB 2.0 2x USB 3.0 (on PCIe bus) 1 SDHC slot 1x External SATA port (USM enclosure form factor slot) Changes in v5: - Currently, CONFIG_RESET_PHY_R symbol is used in

[PATCH v2 1/1] serial: npcm: Add support for Nuvoton NPCM SoCs

2022-01-23 Thread Stanley Chu
Add Nuvoton BMC NPCM7xx/NPCM8xx uart driver Signed-off-by: Stanley Chu --- Changes in v2: Drop unnecessary outer brackets. Return -EAGAIN if not ready for tx/rx. Add comments. --- drivers/serial/Kconfig | 9 +++ drivers/serial/Makefile | 1 + drivers/serial/serial_npcm.c |

Re: [RFC PATCH v3 9/9] mkeficapsule: Add support for generating empty capsules

2022-01-23 Thread Masami Hiramatsu
Hi, 2022年1月24日(月) 11:08 AKASHI Takahiro : > > > > + memcpy(_guid, _guid, sizeof(efi_guid_t)); > > > > + header.header_size = sizeof(header); > > > > + header.flags = 0; > > > > + > > > > + if (fw_accept) { > > > > + header.capsule_image_size = sizeof(header) + > > >

Re: [RFC PATCH v3 3/9] FWU: stm32mp1: Add helper functions for accessing FWU metadata

2022-01-23 Thread Masami Hiramatsu
Hi Sughosh, BTW, I can't find the definition of CONFIG_FWU_NUM_IMAGES_PER_BANK and CONFIG_FWU_NUM_BANKS for this platform. Is it really possible to build this platform with FWU_MULTI_BANK_UPDATE? Thank you, 2022年1月20日(木) 3:56 Sughosh Ganu : > > Add helper functions needed for accessing the FWU

Re: [RFC PATCH v3 5/9] EFI: FMP: Add provision to update image's ImageTypeId in image descriptor

2022-01-23 Thread AKASHI Takahiro
On Fri, Jan 21, 2022 at 12:32:04PM +0530, Sughosh Ganu wrote: > hi Takahiro, > > On Thu, 20 Jan 2022 at 10:54, AKASHI Takahiro > wrote: > > > > On Thu, Jan 20, 2022 at 12:25:44AM +0530, Sughosh Ganu wrote: > > > The FWU Multi Banks Update feature allows updating different types of > > >

Re: [RFC PATCH v3 9/9] mkeficapsule: Add support for generating empty capsules

2022-01-23 Thread AKASHI Takahiro
On Fri, Jan 21, 2022 at 12:18:38PM +0530, Sughosh Ganu wrote: > hi Takahiro, > > On Thu, 20 Jan 2022 at 07:43, AKASHI Takahiro > wrote: > > > > Hi Sughosh, > > > > From user's point of view, > > > > On Thu, Jan 20, 2022 at 12:25:48AM +0530, Sughosh Ganu wrote: > > > The Dependable Boot

Re: [PATCH 02/11] arm: arm926ej-s: add sunxi code

2022-01-23 Thread Andre Przywara
On Thu, 20 Jan 2022 22:16:41 -0500 Jesse Taube wrote: Hi Jesse, > On 1/20/22 21:25, Andre Przywara wrote: > > On Tue, 4 Jan 2022 19:34:59 -0500 > > Jesse Taube wrote: > > > > Hi, > > > >> From: Icenowy Zheng > >> > >> Some Allwinner SoCs use ARM926EJ-S core. > >> > >> Add Allwinner/sunXi

Re: [PATCH 10/40] acpi: Allow include files within the board directory

2022-01-23 Thread Simon Glass
Some .asl files include others using the iasl 'include' directive. This needs to be able to find the files referenced. For an out-of-tree build the source directory is not the current directory. Moreover, U-Boot preprocesses the input file and puts the result in the output directory. So iasl does

Re: [PATCH 02/40] x86: Allow any arch to generate ACPI tables

2022-01-23 Thread Simon Glass
These have sadly found their way to ARM now. Allow any arch to support generating ACPI tables. Disable this for the tools build. Signed-off-by: Simon Glass --- arch/Kconfig | 2 ++ arch/x86/Kconfig | 9 - configs/tools-only_defconfig | 1 + lib/Kconfig

Re: [PATCH 03/40] x86: Move the acpi table to generic global_data

2022-01-23 Thread Simon Glass
Allow this to be used on any arch. Also convert to using macros so that we can check the CONFIG option in C code. Signed-off-by: Simon Glass --- arch/sandbox/include/asm/global_data.h | 1 - arch/x86/include/asm/global_data.h | 1 - cmd/acpi.c | 6 +++---

Re: [PATCH 04/40] arm: Allow supporting ACPI-table generation

2022-01-23 Thread Simon Glass
Hi François, On Wed, 1 Dec 2021 at 10:45, François Ozog wrote: > > Hi > > Le mer. 1 déc. 2021 à 18:11, Tom Rini a écrit : >> >> On Wed, Dec 01, 2021 at 05:49:54PM +0100, Mark Kettenis wrote: >> > > From: Simon Glass >> > > Date: Wed, 1 Dec 2021 09:02:38 -0700 >> > > >> > > Some ARM boards are

Re: [PATCH 05/40] x86: Tidy up use of CONFIG_ACPIGEN

2022-01-23 Thread Simon Glass
This is enabled for quite a few boards which don't create ACPI tables. Tidy this up by dropping the option for some boards. Signed-off-by: Simon Glass --- arch/Kconfig | 2 +- configs/cherryhill_defconfig | 1 + configs/chromebook_link64_defconfig| 1 +

Re: [PATCH 11/40] acpi: Move acpi_fill_header() to the generic header

2022-01-23 Thread Simon Glass
This function is not x86-specific so move it into the common header file. Signed-off-by: Simon Glass --- arch/x86/include/asm/acpi_table.h | 1 - include/acpi/acpi_table.h | 8 2 files changed, 8 insertions(+), 1 deletion(-) Applied to u-boot-dm, thanks!

Re: [PATCH 06/40] sandbox: Allow building with GENERATE_ACPI_TABLE

2022-01-23 Thread Simon Glass
Hi Heinrich, On Wed, 1 Dec 2021 at 11:14, Heinrich Schuchardt wrote: > > On 12/1/21 17:02, Simon Glass wrote: > > At present this option is missing a header file, a function prototype and > > the qfw driver needs a header included. > > > > Fix these problems so we can enable this option on

Re: [PATCH 07/40] efi: Correct call to write_acpi_tables()

2022-01-23 Thread Simon Glass
Hi Heinrich, On Wed, 1 Dec 2021 at 22:00, Heinrich Schuchardt wrote: > > Am 1. Dezember 2021 22:12:09 MEZ schrieb Simon Glass : > >Hi Heinrich, > > > >On Wed, 1 Dec 2021 at 12:57, Heinrich Schuchardt wrote: > >> > >> > >> > >> On 12/1/21 20:32, Simon Glass wrote: > >> > Hi Heinrich, > >> > > >>

Re: [PATCH 08/40] efi: Correct address handling with ACPI tables

2022-01-23 Thread Simon Glass
Hi Heinrich, On Wed, 1 Dec 2021 at 11:13, Heinrich Schuchardt wrote: > > On 12/1/21 17:02, Simon Glass wrote: > > The current EFI implementation confuses pointers and addresses. Normally > > we can get away with this but in the case of sandbox it causes failures. > > > > Despite the fact that

Re: [PATCH 12/40] acpi: Add a table start

2022-01-23 Thread Simon Glass
It is useful to record the start of an ACPI table so that offsets from that point can be easily calculated. Add this to the context and set it before calling the writer method. Signed-off-by: Simon Glass --- drivers/core/acpi.c | 5 ++--- include/dm/acpi.h | 4 2 files changed, 6

Re: [PATCH 13/40] acpi: Add a linker list for ACPI tables

2022-01-23 Thread Simon Glass
At present we call lots of functions to generate the required ACPI tables. It would be better to standardise these functions and allow them to be automatically collected and used when needed. Add a linker list to handle this. Signed-off-by: Simon Glass --- include/dm/acpi.h | 57

Re: [PATCH 14/40] x86: acpi: Split out context creation from base tables

2022-01-23 Thread Simon Glass
At present acpi_setup_base_tables() both sets up the ACPI context and writes out the base tables. We want to use an ACPI writer to write the base tables, so split this function into two, with acpi_setup_ctx() doing the context set, and acpi_setup_base_tables() just doing the base tables. Disable

Re: [PATCH 15/40] x86: Use the ACPI table writer

2022-01-23 Thread Simon Glass
Use the new ACPI writer to write the ACPI tables. At present this is all done in one monolithic function. Future work will split this out. Unfortunately the QFW write_acpi_tables() function conflicts with the 'writer' version, so disable that for sandbox. Signed-off-by: Simon Glass ---

Re: [PATCH 17/40] x86: Move FACS table to a writer function

2022-01-23 Thread Simon Glass
Move this table over to use a writer function, moving the code from the x86 implementation. Add a pointer to the DSDT in struct acpi_ctx so we can reference it later. Signed-off-by: Simon Glass --- arch/x86/lib/acpi_table.c | 26 ++ include/dm/acpi.h | 2 ++

Re: [PATCH 18/40] x86: Move DSDT table to a writer function

2022-01-23 Thread Simon Glass
Move this table over to use a writer function, moving the code from the x86 implementation. Add a pointer to the DSDT in struct acpi_ctx so we can reference it later. Disable this table for sandbox since we don't actually compile real ASL code. Signed-off-by: Simon Glass ---

Re: [PATCH 16/40] x86: Move base tables to a writer function

2022-01-23 Thread Simon Glass
Use the new ACPI writer to write the base tables at the start of the area, moving this code from the x86 implementation. Signed-off-by: Simon Glass --- arch/x86/lib/acpi_table.c | 2 - include/acpi/acpi_table.h | 10 - include/dm/acpi.h | 23 +- lib/acpi/Makefile |

Re: [PATCH 19/40] x86: Move GNVS table to a writer function

2022-01-23 Thread Simon Glass
Move this table over to use a writer function, for x86 only. Handle the two cases Signed-off-by: Simon Glass --- arch/x86/lib/acpi_table.c | 73 +++ 1 file changed, 36 insertions(+), 37 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH 20/40] x86: Move FADT table to a writer function

2022-01-23 Thread Simon Glass
Move this table over to use a writer function, for x86 only. Signed-off-by: Simon Glass --- arch/x86/lib/acpi_table.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH 21/40] x86: Move FACP table into separate functions

2022-01-23 Thread Simon Glass
Each board has its own way of creating this table. Rather than calling the acpi_create_fadt() function for each one from a common acpi_write_fadt() function, just move the writer into the board-specific code. Signed-off-by: Simon Glass --- arch/x86/cpu/apollolake/acpi.c| 17

Re: [PATCH 22/40] x86: Move SSDT table to a writer function

2022-01-23 Thread Simon Glass
Move this table over to use a writer function, moving the code from the x86 implementation. Signed-off-by: Simon Glass --- arch/x86/lib/acpi_table.c | 93 +-- lib/acpi/Makefile | 1 + lib/acpi/ssdt.c | 49 + 3 files

Re: [PATCH 23/40] x86: Move TPM2 table to a writer function

2022-01-23 Thread Simon Glass
Move this table over to use a writer function, for x86 only. Signed-off-by: Simon Glass --- arch/x86/lib/acpi_table.c | 39 ++- 1 file changed, 18 insertions(+), 21 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH 24/40] x86: Move MADT table to a writer function

2022-01-23 Thread Simon Glass
Move this table over to use a writer function, for x86 only. Signed-off-by: Simon Glass --- arch/x86/lib/acpi_table.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH 25/40] x86: Move TCPA table to a writer function

2022-01-23 Thread Simon Glass
Move this table over to use a writer function, for x86 only. Signed-off-by: Simon Glass --- arch/x86/lib/acpi_table.c | 38 -- 1 file changed, 16 insertions(+), 22 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH 26/40] x86: Move CSRT table to a writer function

2022-01-23 Thread Simon Glass
Move this table over to use a writer function, moving the code from the x86 implementation. Signed-off-by: Simon Glass --- arch/x86/lib/acpi_table.c | 62 --- lib/acpi/Makefile | 1 + lib/acpi/csrt.c | 50 +++ 3

Re: [PATCH 27/40] x86: acpi: Update acpi_fill_csrt() to use acpi_ctx

2022-01-23 Thread Simon Glass
Update this function to the newer style, so we can avoid passing and returning an address through this function. Also move this function out of the x86 code so it can be used by other archs. Signed-off-by: Simon Glass --- arch/x86/cpu/tangier/acpi.c | 9 ++---

Re: [PATCH 29/40] x86: Move acpi_get_rsdp_addr() ACPI tables to the writer

2022-01-23 Thread Simon Glass
Move this over to use a writer file, moving the code from the x86 implementation. There is no need to store a separate variable since we can simply access the ACPI context. With this, the original monolithic x86 function for writing ACPI tables is gone. Note that QEMU has its own

Re: [PATCH 28/40] x86: Move device-specific ACPI tables to a writer function

2022-01-23 Thread Simon Glass
Move this over to use a writer function, moving the code from the x86 implementation. Signed-off-by: Simon Glass --- arch/x86/lib/acpi_table.c | 2 -- lib/acpi/acpi_writer.c| 12 2 files changed, 12 insertions(+), 2 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH 30/40] acpi: Collect tables in the acpi_item list

2022-01-23 Thread Simon Glass
At present this list is used to collect items within the DSDT and SSDT tables. It is useful for it to collect the whole tables as well, so there is a list of what was created and which write created each one. Refactor the code accordingly. Signed-off-by: Simon Glass --- drivers/core/acpi.c

Re: [PATCH 31/40] acpi: Tidy up the item list

2022-01-23 Thread Simon Glass
At present this is really just a debugging aid, but it is a bit untidy. Add proper columns and display the type name instead of a number. Sample output for coral: => acpi items Seq Type Addr Size Device/Writer --- - - 0 other 79925000

Re: [PATCH 32/40] acpi: Tidy up the table list

2022-01-23 Thread Simon Glass
At present this is really just a debugging aid, but it is a bit untidy. Add proper columns so it is easier to read. Sample output for coral: => acpi list Name Base Size Detail - -- RSDP 79925000 24 v02 U-BOOT RSDT 79925030 48 v01

Re: [PATCH 33/40] doc: Add usage information for the acpi command

2022-01-23 Thread Simon Glass
Add some documentation for this command. Signed-off-by: Simon Glass --- doc/usage/acpi.rst | 235 doc/usage/index.rst | 1 + 2 files changed, 236 insertions(+) create mode 100644 doc/usage/acpi.rst Applied to u-boot-dm, thanks!

Re: [PATCH 34/40] acpi: Add some tables needed by ARM devices

2022-01-23 Thread Simon Glass
Add some tables needed for ARM devices, including more MADT subtables, a CSRT descriptor, GTDT and PPTT. WIP: This needs comments added. Signed-off-by: Simon Glass --- include/acpi/acpi_table.h | 205 ++ 1 file changed, 205 insertions(+) Applied to

Re: [PATCH 35/40] acpi: Add myself as maintainer

2022-01-23 Thread Simon Glass
Add myself as maintainer of the generic ACPI code, until someone else steps up to take it on. Signed-off-by: Simon Glass --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) Applied to u-boot-dm, thanks!

Re: [PATCH 02/14] video: nokia_rx51: Drop obsolete video code

2022-01-23 Thread Simon Glass
Hi Pali, On Sun, 23 Jan 2022 at 09:01, Pali Rohár wrote: > > Hello! > > On Sunday 23 January 2022 08:54:24 Simon Glass wrote: > > Hi Pali, > > > > On Sun, 23 Jan 2022 at 07:57, Pali Rohár wrote: > > > > > > On Sunday 23 January 2022 07:36:22 Simon Glass wrote: > > > > Hi Pali, > > > > > > > >

Re: [PATCH v4 1/4] checkpatch: Support wide strings

2022-01-23 Thread Simon Glass
Hi Joe, On Sun, 23 Jan 2022 at 09:27, Joe Perches wrote: > > On Sun, 2022-01-23 at 11:19 -0500, Tom Rini wrote: > > On Sun, Jan 23, 2022 at 08:10:37AM -0800, Joe Perches wrote: > > > On Sun, 2022-01-23 at 09:03 -0700, Simon Glass wrote: > > > > > > > Do you think we > > > > should try to send

[PATCH] binman: Document the __bss_size symbol error

2022-01-23 Thread Simon Glass
Add a note about the message so it is clear why it occurs. Signed-off-by: Simon Glass --- tools/binman/binman.rst | 29 + 1 file changed, 29 insertions(+) diff --git a/tools/binman/binman.rst b/tools/binman/binman.rst index db2234bd8ff..eb2c9d4bdcc 100644 ---

[PATCH v5 2/4] efi: Use 16-bit unicode strings

2022-01-23 Thread Simon Glass
At present we use wide characters for unicode but this is not necessary. Change the code to use the 'u' literal instead. This helps to fix build warnings for sandbox on rpi. Signed-off-by: Simon Glass Suggested-by: Heinrich Schuchardt Reviewed-by: Heinrich Schuchardt --- (no changes since v4)

[PATCH v5 4/4] treewide: Use 16-bit unicode strings

2022-01-23 Thread Simon Glass
At present we use wide characters for unicode but this is not necessary. Change the code to use the 'u' literal instead. This helps to fix build warnings for sandbox on rpi. Note: This applies tree-wide Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add a new patch to

[PATCH v5 1/4] scripts/checkpatch.pl: Resync with v5.16

2022-01-23 Thread Simon Glass
This resyncs us with the version found in v5.16 of the Linux kernel with the following exceptions: - Keep our u-boot specific tests / code area. - Change the location of checkpatch.rst - Drop the "use strscpy" test as we don't have that, but do have strlcpy and want that used now. - Keep

[PATCH v5 3/4] sandbox: Detect the host bit size automatically

2022-01-23 Thread Simon Glass
At present if you build sandbox on a 32-bit host a lot of errors are produced. This is because CONFIG_HOST_64BIT is enabled by default. It is quite annoying to have to change that manually before building sandbox. It is also quite confusing for new users. Add a way to detect the setting and add

[PATCH v5 0/4] Fix compiler warnings for 32-bit ARM

2022-01-23 Thread Simon Glass
These were noticed when building sandbox on a Raspberry Pi 400, which uses 32-bit linux. To make this work, I enabled CONFIG_HOST_32BIT in 'make menuconfig'. It would be nice if that were automatic, since we have the logic already in arch/sandbox/config.mk So this series adds that. It also

Re: [PATCH v4 1/4] checkpatch: Support wide strings

2022-01-23 Thread Joe Perches
On Sun, 2022-01-23 at 11:19 -0500, Tom Rini wrote: > On Sun, Jan 23, 2022 at 08:10:37AM -0800, Joe Perches wrote: > > On Sun, 2022-01-23 at 09:03 -0700, Simon Glass wrote: > > > > > Do you think we > > > should try to send the U-Boot things upstream? > > > > No idea. What are the U-Boot things

Re: [PATCH v4 1/4] checkpatch: Support wide strings

2022-01-23 Thread Tom Rini
On Sun, Jan 23, 2022 at 08:10:37AM -0800, Joe Perches wrote: > On Sun, 2022-01-23 at 09:03 -0700, Simon Glass wrote: > > > Do you think we > > should try to send the U-Boot things upstream? > > No idea. What are the U-Boot things that could or should be generic ? > >

Re: [PATCH 17/23] video: Convert CONFIG_VIDEO_LOGO to Kconfig

2022-01-23 Thread Tom Rini
On Sun, Jan 23, 2022 at 04:11:00PM +0100, Pali Rohár wrote: > On Sunday 23 January 2022 09:54:02 Tom Rini wrote: > > On Sun, Jan 23, 2022 at 03:48:17PM +0100, Pali Rohár wrote: > > > On Saturday 22 January 2022 13:41:01 Tom Rini wrote: > > > > On Sat, Jan 22, 2022 at 04:41:42PM +0100, Pali Rohár

Re: [PATCH v4 1/4] checkpatch: Support wide strings

2022-01-23 Thread Joe Perches
On Sun, 2022-01-23 at 09:03 -0700, Simon Glass wrote: > Do you think we > should try to send the U-Boot things upstream? No idea. What are the U-Boot things that could or should be generic ? https://source.denx.de/u-boot/u-boot/-/commits/master/scripts/checkpatch.pl

Re: [PATCH v4 1/4] checkpatch: Support wide strings

2022-01-23 Thread Tom Rini
On Sun, Jan 23, 2022 at 09:03:16AM -0700, Simon Glass wrote: > Hi Tom, > > On Sun, 23 Jan 2022 at 07:54, Tom Rini wrote: > > > > On Fri, Jan 21, 2022 at 06:27:33PM -0700, Simon Glass wrote: > > > > > From: Joe Perches > > > > > > Allow prefixing typical strings with L for wide strings and u for

Re: [PATCH v4 1/4] checkpatch: Support wide strings

2022-01-23 Thread Simon Glass
Hi Tom, On Sun, 23 Jan 2022 at 07:54, Tom Rini wrote: > > On Fri, Jan 21, 2022 at 06:27:33PM -0700, Simon Glass wrote: > > > From: Joe Perches > > > > Allow prefixing typical strings with L for wide strings and u for > > unicode strings. > > > > Signed-off-by: Joe Perches > > Signed-off-by:

Re: [PATCH 02/14] video: nokia_rx51: Drop obsolete video code

2022-01-23 Thread Pali Rohár
Hello! On Sunday 23 January 2022 08:54:24 Simon Glass wrote: > Hi Pali, > > On Sun, 23 Jan 2022 at 07:57, Pali Rohár wrote: > > > > On Sunday 23 January 2022 07:36:22 Simon Glass wrote: > > > Hi Pali, > > > > > > On Sun, 23 Jan 2022 at 07:08, Pali Rohár wrote: > > > > > > > > + Maemo > > > > >

Re: [PATCH 02/14] video: nokia_rx51: Drop obsolete video code

2022-01-23 Thread Simon Glass
Hi Pali, On Sun, 23 Jan 2022 at 07:57, Pali Rohár wrote: > > On Sunday 23 January 2022 07:36:22 Simon Glass wrote: > > Hi Pali, > > > > On Sun, 23 Jan 2022 at 07:08, Pali Rohár wrote: > > > > > > + Maemo > > > > > > On Sunday 23 January 2022 07:04:03 Simon Glass wrote: > > > > Drop this code

[PATCH v2 2/2] input: apple: Add support for Apple SPI keyboard

2022-01-23 Thread Mark Kettenis
This driver adds support for the keyboard on Apple Silicon laptops. The controller for this keyboard sits on an SPI bus and uses an Apple-specific HID over SPI protocol. The packets sent by this controller for key presses and key releases are fairly simple and are decoded directly by the code in

[PATCH v2 1/2] spi: apple: Add driver for Apple SPI controller

2022-01-23 Thread Mark Kettenis
Add a driver for the SPI controller integrated on Apple SoCs. This is necessary to support the keyboard on Apple Silicon laopts since their keyboard uses an Apple-specific HID over SPI protocol. Signed-off-by: Mark Kettenis Reviewed-by: Simon Glass Tested on: Macbook Air M1 Tested-by: Simon

[PATCH v2 0/2] Apple M1 laptop keyboard support

2022-01-23 Thread Mark Kettenis
This short series implements support for the laptop keyboards on the Apple Silicon Mac laptops. These keyboards are connected to an SPI bus, so this adds a driver for the SPI controller integrated on the SoC, as well as the driver for the keyboard itself. This makes it possible to interact with

Re: [PATCH 17/23] video: Convert CONFIG_VIDEO_LOGO to Kconfig

2022-01-23 Thread Pali Rohár
On Sunday 23 January 2022 09:54:02 Tom Rini wrote: > On Sun, Jan 23, 2022 at 03:48:17PM +0100, Pali Rohár wrote: > > On Saturday 22 January 2022 13:41:01 Tom Rini wrote: > > > On Sat, Jan 22, 2022 at 04:41:42PM +0100, Pali Rohár wrote: > > > > Adding other Maemo developers... > > > > > > > > On

Re: [PATCH 02/14] video: nokia_rx51: Drop obsolete video code

2022-01-23 Thread Pali Rohár
On Sunday 23 January 2022 07:36:22 Simon Glass wrote: > Hi Pali, > > On Sun, 23 Jan 2022 at 07:08, Pali Rohár wrote: > > > > + Maemo > > > > On Sunday 23 January 2022 07:04:03 Simon Glass wrote: > > > Drop this code which uses a header that is about to be deleted. > > > > And what / where is the

Re: [PULL] u-boot-sh/master

2022-01-23 Thread Tom Rini
On Sun, Jan 23, 2022 at 03:01:00AM +0100, Marek Vasut wrote: > The following changes since commit e6786b0354372c8a68d01e4d633a19cdce373b70: > > Merge branch '2022-01-21-Kconfig-migrations' (2022-01-21 14:01:41 -0500) > > are available in the Git repository at: > >

Re: Pull request for efi-2022-04-rc1-2

2022-01-23 Thread Tom Rini
On Sat, Jan 22, 2022 at 09:12:48PM +0100, Heinrich Schuchardt wrote: > Dear Tom, > > The following changes since commit 6a685753ce8b6b02b67d64b239143bf19eda63c9: > > Merge branch '2022-01-18-platform-updates' (2022-01-18 16:07:33 -0500) > > are available in the Git repository at: > >

Re: [PATCH v4 1/4] checkpatch: Support wide strings

2022-01-23 Thread Tom Rini
On Fri, Jan 21, 2022 at 06:27:33PM -0700, Simon Glass wrote: > From: Joe Perches > > Allow prefixing typical strings with L for wide strings and u for > unicode strings. > > Signed-off-by: Joe Perches > Signed-off-by: Simon Glass > --- > This was found on LKML: > >

Re: [PATCH 17/23] video: Convert CONFIG_VIDEO_LOGO to Kconfig

2022-01-23 Thread Tom Rini
On Sun, Jan 23, 2022 at 03:48:17PM +0100, Pali Rohár wrote: > On Saturday 22 January 2022 13:41:01 Tom Rini wrote: > > On Sat, Jan 22, 2022 at 04:41:42PM +0100, Pali Rohár wrote: > > > Adding other Maemo developers... > > > > > > On Saturday 22 January 2022 10:29:34 Tom Rini wrote: > > > > This

Re: [PATCH 17/23] video: Convert CONFIG_VIDEO_LOGO to Kconfig

2022-01-23 Thread Pali Rohár
On Saturday 22 January 2022 13:41:01 Tom Rini wrote: > On Sat, Jan 22, 2022 at 04:41:42PM +0100, Pali Rohár wrote: > > Adding other Maemo developers... > > > > On Saturday 22 January 2022 10:29:34 Tom Rini wrote: > > > This is perhaps as good/bad time as any to ask about the conversion > > >

Re: [PATCH 02/14] video: nokia_rx51: Drop obsolete video code

2022-01-23 Thread Simon Glass
Hi Pali, On Sun, 23 Jan 2022 at 07:08, Pali Rohár wrote: > > + Maemo > > On Sunday 23 January 2022 07:04:03 Simon Glass wrote: > > Drop this code which uses a header that is about to be deleted. > > And what / where is the replacement? This is DM_VIDEO. There are quite a few example drivers in

Re: [PATCH 02/14] video: nokia_rx51: Drop obsolete video code

2022-01-23 Thread Pali Rohár
+ Maemo On Sunday 23 January 2022 07:04:03 Simon Glass wrote: > Drop this code which uses a header that is about to be deleted. And what / where is the replacement? > Signed-off-by: Simon Glass > --- > > board/nokia/rx51/rx51.c | 19 --- > configs/nokia_rx51_defconfig |

[PATCH 14/14] video: Drop formike driver

2022-01-23 Thread Simon Glass
This is not used. Drop it. Signed-off-by: Simon Glass --- drivers/video/Makefile | 1 - drivers/video/formike.c | 513 --- scripts/config_whitelist.txt | 1 - 3 files changed, 515 deletions(-) delete mode 100644 drivers/video/formike.c diff

[PATCH 10/14] video: fsl: colibri_vf: Drop FSL DCU driver

2022-01-23 Thread Simon Glass
This does not use driver model and is more than two years past the migration date. Drop it. It can be added back later if needed. Signed-off-by: Simon Glass --- arch/arm/cpu/armv7/ls102xa/soc.c | 4 - arch/arm/include/asm/arch-ls102xa/config.h | 1 -

[PATCH 11/14] video: Drop FSL DIU driver

2022-01-23 Thread Simon Glass
This does not use driver model and is more than two years past the migration date. Drop it. It can be added back later if needed. Signed-off-by: Simon Glass --- README | 13 - board/freescale/common/Makefile | 2 - board/freescale/common/diu_ch7301.c | 217

[PATCH 12/14] video: mxs: Drop old video code

2022-01-23 Thread Simon Glass
This is no-longer used and is the last reference to video_hw_init(). Drop it. Signed-off-by: Simon Glass --- drivers/video/mxsfb.c | 89 --- 1 file changed, 89 deletions(-) diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c index

[PATCH 13/14] video: Convert CONFIG_VIDEO_BCM2835 to Kconfig

2022-01-23 Thread Simon Glass
This converts the following to Kconfig: CONFIG_VIDEO_BCM2835 This is the final ad-hoc CONFIG_VIDEO_... to convert. Signed-off-by: Simon Glass --- configs/rpi_0_w_defconfig | 1 + configs/rpi_2_defconfig| 1 + configs/rpi_3_32b_defconfig| 1 + configs/rpi_3_b_plus_defconfig

[PATCH 09/14] video: Drop da8xx-fb

2022-01-23 Thread Simon Glass
This is not used in U-Boot anymore. Drop it. Signed-off-by: Simon Glass --- drivers/video/Makefile |1 - drivers/video/da8xx-fb.c | 1047 -- drivers/video/da8xx-fb.h | 115 scripts/config_whitelist.txt |1 - 4 files changed, 1164

[PATCH 08/14] video: Clean up the uclass header

2022-01-23 Thread Simon Glass
Drop the unnecessary cruft from this header and update the title. Signed-off-by: Simon Glass --- include/video.h | 84 + 1 file changed, 1 insertion(+), 83 deletions(-) diff --git a/include/video.h b/include/video.h index

[PATCH 07/14] video: Drop references to CONFIG_VIDEO et al

2022-01-23 Thread Simon Glass
Drop the Kconfigs which are not used and all references to them. In particular, this drops CONFIG_VIDEO to avoid confusion and allow us to eventually rename CONFIG_DM_VIDEO to CONFIG_VIDEO. Also drop the prototype for video_get_info_str() which is no-longer used. Signed-off-by: Simon Glass ---

[PATCH 05/14] video: Drop video_fb header

2022-01-23 Thread Simon Glass
This is not used now. Drop it. Signed-off-by: Simon Glass --- .../mach-nexell/include/mach/display_dev.h| 1 - board/aristainetos/aristainetos.c | 1 - board/freescale/t104xrdb/diu.c| 1 - board/socrates/socrates.c | 1 -

[PATCH 01/14] video: Drop cfg_console

2022-01-23 Thread Simon Glass
The non-driver model video support was removed two years ago. Drop this driver, which is only used by nokia_rx51. Signed-off-by: Simon Glass --- README |1 - cmd/cls.c|2 - common/stdio.c |1 - configs/nokia_rx51_defconfig |

[PATCH 04/14] video: nexell: Drop unused and invalid code

2022-01-23 Thread Simon Glass
Unfortunately this driver uses the old video structure to store things. This is not supported with driver model. Drop the old code and comment out the other pieces, so the maintainer can take a look. Signed-off-by: Simon Glass --- arch/arm/mach-nexell/include/mach/display_dev.h | 4 ++--

[PATCH 03/14] video: siemens: Drop unused video code

2022-01-23 Thread Simon Glass
Drop this old code which is not built anymore, as it depends on CONFIG_VIDEO which has been removed. Signed-off-by: Simon Glass --- board/siemens/common/board.c | 3 - board/siemens/common/factoryset.c | 7 - board/siemens/common/factoryset.h | 3 - board/siemens/pxm2/board.c

[PATCH 02/14] video: nokia_rx51: Drop obsolete video code

2022-01-23 Thread Simon Glass
Drop this code which uses a header that is about to be deleted. Signed-off-by: Simon Glass --- board/nokia/rx51/rx51.c | 19 --- configs/nokia_rx51_defconfig | 1 - include/configs/nokia_rx51.h | 11 --- 3 files changed, 31 deletions(-) diff --git