Re: FIT image: load secure FPGA

2022-02-08 Thread Jorge Ramirez-Ortiz, Foundries
On 07/02/22, Adrian Fiergolski wrote: > Hi Jorge and Oleksandr, > > Thank you for sharing all the links. I found there a lot of inspiration to > meet my target of using encrypted bitfiles. thanks Adrian. Glad to hear that > > I have also shared with the community a patch, on top of your

RE: Compile error with SPL_FIT_FULL_CHECK and SPL_LOAD_FIT_FULL enabled

2022-02-08 Thread Johann Neuhauser
> -Original Message- > From: Simon Glass [mailto:s...@chromium.org] > Sent: Tuesday, February 8, 2022 6:13 PM > > Hi Johann, > Hi Simon, thanks for your fast answer. > On Tue, 8 Feb 2022 at 08:44, Johann Neuhauser > wrote: > > > > Dear developers and Simon, > > > > we wanna run secure

Re: [PATCH v4 01/11] FWU: Add FWU metadata structure and driver for accessing metadata

2022-02-08 Thread Michal Simek
Hi, On 2/9/22 00:39, Masami Hiramatsu wrote: Hi Michal, 2022年2月8日(火) 23:27 Michal Simek : On 2/8/22 15:14, Masami Hiramatsu wrote: 2022年2月8日(火) 22:45 Michal Simek : On 2/8/22 14:36, Masami Hiramatsu wrote: 2022年2月8日(火) 20:35 Sughosh Ganu : On Tue, 8 Feb 2022 at 16:26, Michal Simek

Re: [PATCH v4 02/11] FWU: Add FWU metadata access driver for GPT partitioned block devices

2022-02-08 Thread Masami Hiramatsu
Hi Sughosh, While porting mdata-sf driver, I'm confusing on the devicetree usage. 2022年2月8日(火) 3:21 Sughosh Ganu : > +int fwu_get_mdata_device(struct udevice **mdata_dev) > +{ > + u32 phandle; > + int ret, size; > + struct udevice *dev, *child; > + ofnode fwu_mdata_node;

Re: [PATCH v4 2/2] efi_loader: Reset system after CapsuleUpdate on disk

2022-02-08 Thread Masami Hiramatsu
Hi Takahiro, 2022年2月9日(水) 12:13 AKASHI Takahiro : > > On Thu, Feb 03, 2022 at 06:23:27PM +0900, Masami Hiramatsu wrote: > > Add a cold reset soon after processing capsule update on disk. > > This is required in UEFI specification 2.9 Section 8.5.5 > > "Delivery of Capsules via file on Mass

Re: [PATCH v4 2/2] efi_loader: Reset system after CapsuleUpdate on disk

2022-02-08 Thread AKASHI Takahiro
On Thu, Feb 03, 2022 at 06:23:27PM +0900, Masami Hiramatsu wrote: > Add a cold reset soon after processing capsule update on disk. > This is required in UEFI specification 2.9 Section 8.5.5 > "Delivery of Capsules via file on Mass Storage device" as; > > In all cases that a capsule is

Re: [PATCH v4 10/11] mkeficapsule: Add support for generating empty capsules

2022-02-08 Thread AKASHI Takahiro
Hi Sughosh, On Mon, Feb 07, 2022 at 11:50:00PM +0530, Sughosh Ganu wrote: > The Dependable Boot specification describes the structure of the What is this specification? Please specify the link to the doc. > firmware accept and revert capsules. These are empty capsules which > are used for

[PATCH] arm: kirkwood: Pogoplug E02 : Convert Ethernet to Driver Model

2022-02-08 Thread Tony Dinh
The Pogoplug E02 board has the network chip Marvell 88E1116R. Convert to Driver Model and use uclass mvgbe and the compatible driver M88E1118R to bring up Ethernet. - Add board_eth_init(), CONFIG_DM_ETH, and CONFIG_PHY_MARVELL to bring up Ethernet. - Currently, CONFIG_RESET_PHY_R symbol is used

Re: Running qemu tests on RISC-V

2022-02-08 Thread Simon Glass
Hi Heinrich, On Tue, 8 Feb 2022 at 17:58, Heinrich Schuchardt wrote: > > > > Am 8. Februar 2022 22:55:38 MEZ schrieb Simon Glass : > >Hi Alper, > > > >On Tue, 8 Feb 2022 at 14:36, Alper Nebi Yasak > >wrote: > >> > >> On 08/02/2022 23:43, Simon Glass wrote: > >> > Thanks for testing it. I don't

Re: [PATCH] binman: Skip processing "hash" subnodes of FIT subsections

2022-02-08 Thread Simon Glass
Hi Alper, On Tue, 8 Feb 2022 at 16:07, Alper Nebi Yasak wrote: > > Binman's FIT entry type can have image subentries with "hash" subnodes > intended to be processed by mkimage, but not binman. However, the Entry > class and any subclass that reuses its implementation tries to process > these

[GIT PULL] Please pull u-boot-mmc master

2022-02-08 Thread Jaehoon Chung
Dear Tom, Please pull u-boot-mmc master into u-boot master branch. There is the fixing fsl_esdhc_imx issue. If there is any problem, let me know, plz Best Regards, Jaehoon Chung CI: https://source.denx.de/u-boot/custodians/u-boot-mmc/-/pipelines/10913 The following changes since commit

Re: Running qemu tests on RISC-V

2022-02-08 Thread Heinrich Schuchardt
Am 8. Februar 2022 22:55:38 MEZ schrieb Simon Glass : >Hi Alper, > >On Tue, 8 Feb 2022 at 14:36, Alper Nebi Yasak wrote: >> >> On 08/02/2022 23:43, Simon Glass wrote: >> > Thanks for testing it. I don't see this on >> > >> > 8b139f4e1c0 (HEAD, us/master) Merge tag 'u-boot-imx-20220207' of >> >

Re: ARM A53 and initial MMU mapping for EL0/1/2/3 ?

2022-02-08 Thread Andre Przywara
On Tue, 8 Feb 2022 22:05:00 + Joakim Tjernlund wrote: Hi Joakim, > Trying to figure out how I should map the MMU for normal RAM so it acessible > from all ELx security states. ^^^ This does not make much sense. U-Boot is typically running in one exception level only, and sets

Re: [PATCH] Nokia RX-51: Convert to CONFIG_DM_KEYBOARD

2022-02-08 Thread Pali Rohár
On Tuesday 08 February 2022 12:36:24 Tom Rini wrote: > On Thu, Feb 03, 2022 at 07:38:50PM +0100, Pali Rohár wrote: > > > Signed-off-by: Pali Rohár > > Applied to u-boot/master, thanks! > > -- > Tom Thank you Tom!

Re: [PATCH 03/19] mmc: call device_probe() after scanning

2022-02-08 Thread Jaehoon Chung
On 2/2/22 10:08, AKASHI Takahiro wrote: > Every time a mmc bus/port is scanned and a new device is detected, > we want to call device_probe() as it will give us a chance to run > additional post-processings for some purposes. > > In particular, support for creating partitions on a device will be

Re: [PATCH v4 4/4] rockchip: sdhci: Add HS400 Enhanced Strobe support for RK3568

2022-02-08 Thread Jaehoon Chung
On 1/29/22 07:42, Alper Nebi Yasak wrote: > On RK3568, a register bit must be set to enable Enhanced Strobe. > However, it appears that the address of this register may differ from > vendor to vendor and should be read from the underlying MMC IP. Let the > Rockchip SDHCI driver read this address

Re: [PATCH v4 01/11] FWU: Add FWU metadata structure and driver for accessing metadata

2022-02-08 Thread Masami Hiramatsu
Hi Michal, 2022年2月8日(火) 23:27 Michal Simek : > > > > On 2/8/22 15:14, Masami Hiramatsu wrote: > > 2022年2月8日(火) 22:45 Michal Simek : > >> > >> > >> > >> On 2/8/22 14:36, Masami Hiramatsu wrote: > >>> 2022年2月8日(火) 20:35 Sughosh Ganu : > > On Tue, 8 Feb 2022 at 16:26, Michal Simek wrote:

Re: [PATCH v4 3/4] rockchip: sdhci: Add HS400 Enhanced Strobe support for RK3399

2022-02-08 Thread Jaehoon Chung
On 1/29/22 07:42, Alper Nebi Yasak wrote: > On RK3399, a register bit must be set to enable Enhanced Strobe. > Let the Rockchip SDHCI driver set it when Enhanced Strobe configuration > is requested. However, having it set makes the lower-speed modes stop > working and makes reinitialization fail,

Re: [PATCH] cmd: mmc: Consider GP partitions in mmc hwpartition user enh start -

2022-02-08 Thread Jaehoon Chung
On 1/27/22 08:16, Jaehoon Chung wrote: > On 1/18/22 06:54, Marek Vasut wrote: >> In case the eMMC contains any GP partitions or user sets up new GP >> partitions, the size of these GP partitions reduce the size of the >> USER partition. Subtract the size of those GP partitions from the >>

Re: [PATCH v1] mmc: fsl_esdhc_imx: fix watermark level in dma

2022-02-08 Thread Jaehoon Chung
On 2/1/22 07:08, Marcel Ziswiler wrote: > From: Marcel Ziswiler > > Seems that we need the waterlevel setting not only for PIO mode as > without this at least the i.MX 8M Mini won't boot anymore when being > written by such a U-Boot. Corruption has also been observed both on > the i.MX 6 as well

Please pull u-boot-dm

2022-02-08 Thread Simon Glass
Hi Tom, https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/10909 The following changes since commit 531c00894577a0a852431adf61ade76925f8b162: Merge branch '2022-02-08-TI-platform-updates' (2022-02-08 12:28:04 -0500) are available in the Git repository at:

[PATCH 2/2] Add SCSI scan for ENV in EXT4 or FAT

2022-02-08 Thread Rogier Stam
When having environment stored in EXT4 or FAT and using an AHCI or SCSI device / partition the scan would not be performed early enough and hence the device would not be recognized. This change adds the scan when the interface is "scsi" in a similar way to mmc_initialize. Signed-off-by: Rogier

[PATCH 1/2] Fix Espressobin build for configs where ENV is not in SPI

2022-02-08 Thread Rogier Stam
When storing the UBoot Environment in for example EXT4, the U-Boot build is broken for several reasons: 1. armada-385-turris-omnia-u-boot.dtsi will not allow CONFIG_ENV_OFFSET and CONFIG_ENV_SIZE to be undefined 2. armada-37xx/board.c ft_board_setup function does not exist if

[PATCH 0/2] U-Boot ENV in EXT4 support for Expressobin (revised)

2022-02-08 Thread Rogier Stam
Hi Per comments of Stefan I have split the patch in two: - one for env file changes - one for espressobin related changes Let me know if any other changes are needed. Regards Rogier Rogier Stam (2): Fix Espressobin build for configs where ENV is not in SPI Add SCSI scan for ENV in EXT4 or

[PATCH] spi: dw: Fix broken dw_spi_mem_ops()

2022-02-08 Thread Niklas Cassel
From: Niklas Cassel The driver is currently using sizeof(op->cmd.opcode) in the op_len calculation. Commit d15de623013c ("spi: spi-mem: allow specifying a command's extension") changed op->cmd.opcode from one byte to two. Instead, a new struct member op->cmd.nbytes is supposed to be used. For

[PATCH] binman: Skip processing "hash" subnodes of FIT subsections

2022-02-08 Thread Alper Nebi Yasak
Binman's FIT entry type can have image subentries with "hash" subnodes intended to be processed by mkimage, but not binman. However, the Entry class and any subclass that reuses its implementation tries to process these unconditionally. This can lead to an error when boards specify hash algorithms

Re: Compile error with SPL_FIT_FULL_CHECK and SPL_LOAD_FIT_FULL enabled

2022-02-08 Thread Simon Glass
Hi Philippe, On Tue, 8 Feb 2022 at 10:12, Philippe REYNES wrote: > > Hi Johann, > > Le 08/02/2022 à 16:43, Johann Neuhauser a écrit : > > Dear developers and Simon, > > > > we wanna run secure boot with U-Boot's SPL_FIT_SIGNATURE and FIT_SIGNATURE > > on our STM32MP1 boards and discovered the

ARM A53 and initial MMU mapping for EL0/1/2/3 ?

2022-02-08 Thread Joakim Tjernlund
Trying to figure out how I should map the MMU for normal RAM so it acessible from all ELx security states. So far I have this mem_map: /* memory mapped RAM. 32MB */ .virt = 0x6000UL, .phys = 0x6000UL, .size = 0x0200UL,

Re: Running qemu tests on RISC-V

2022-02-08 Thread Simon Glass
Hi Alper, On Tue, 8 Feb 2022 at 14:36, Alper Nebi Yasak wrote: > > On 08/02/2022 23:43, Simon Glass wrote: > > Thanks for testing it. I don't see this on > > > > 8b139f4e1c0 (HEAD, us/master) Merge tag 'u-boot-imx-20220207' of > > https://gitlab.denx.de/u-boot/custodians/u-boot-imx > > > > : > >

Re: [PATCH] image: Control FIT signature verification at runtime

2022-02-08 Thread Andrew Jeffery
On Mon, 7 Feb 2022, at 11:37, ChiaWei Wang wrote: > Hi Andrew, > > I am curious about the usage scenario. > Is the runtime control required for production release? Yes. > As this control acts like a backdoor to bypass the chain-of-trust. Right, just as strap pin controlling the SB ROM in the

Re: Running qemu tests on RISC-V

2022-02-08 Thread Alper Nebi Yasak
On 08/02/2022 23:43, Simon Glass wrote: > Thanks for testing it. I don't see this on > > 8b139f4e1c0 (HEAD, us/master) Merge tag 'u-boot-imx-20220207' of > https://gitlab.denx.de/u-boot/custodians/u-boot-imx > > : > > tools/binman/binman --toolpath ./tools build -u -d u-boot.dtb -O . > -m

[PATCH 1/1] iommu: Add M1 Pro/Max support to Apple DART driver

2022-02-08 Thread Janne Grunau
For the purpose of this driver (activating bypass mode) t6000-dart and t8103-dart are fully compatible. Signed-off-by: Janne Grunau Reviewed-by: Mark Kettenis --- drivers/iommu/apple_dart.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iommu/apple_dart.c

[PATCH v2 1/1] arm: apple: Switch to fully dynamic mem layout

2022-02-08 Thread Janne Grunau
Support for Apple M1 Pro and Max will allow using a single binary for all M1 SoCs. The M1 Pro/Max have a different memory layout. The RAM start address is 0x100__ instead of 0x8__. Replace the hardcoded memory layout with dynamic initialized environment variables in

[PATCH] arm: apple: Add M1 Pro/Max support

2022-02-08 Thread Mark Kettenis
Choose the memory map based on the compatible property from the device tree passed to us by m1n1. Since DRAM on the M1 Pro/Max starts at a different address avoid hardcoding the top of usable memory. Also make sure that the addresses entered into the memory map are page aligned such that we don't

Re: Running qemu tests on RISC-V

2022-02-08 Thread Simon Glass
Hi Alper, On Tue, 8 Feb 2022 at 11:20, Alper Nebi Yasak wrote: > > On 08/02/2022 20:13, Simon Glass wrote: > > Hi Heinrich, > > > > On Tue, 8 Feb 2022 at 08:34, Heinrich Schuchardt wrote: > >> > >> On 2/8/22 15:52, Simon Glass wrote: > >>> Hi Heinrich, > >>> > >>> On Tue, 8 Feb 2022 at 01:21,

Re: [PATCH v2 5/5] binman: Update image positions of FIT subentries

2022-02-08 Thread Simon Glass
Hi Alper, On Mon, 7 Feb 2022 at 15:08, Alper Nebi Yasak wrote: > > Binman keeps track of positions of each entry in the final image, but > currently this data is wrong for things included in FIT entries, > especially since a previous patch makes FIT a subclass of Section and > inherit its

Re: [PATCH 11/17] patman: Convert camel case in test_util.py

2022-02-08 Thread Simon Glass
Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- tools/binman/main.py | 6 +++--- tools/dtoc/main.py| 6 +++--- tools/dtoc/test_fdt.py| 2 +- tools/patman/main.py | 2 +- tools/patman/test_util.py | 6 +++--- 5 files

Re: [PATCH 16/17] patman: Update with new pylint scores

2022-02-08 Thread Simon Glass
Update the new baseline since various scores have improved. Signed-off-by: Simon Glass --- scripts/pylint.base | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) Applied to u-boot-dm, thanks!

Re: [RFC PATCH] dts: automatically build necessary .dtb files

2022-02-08 Thread Simon Glass
On Tue, 8 Feb 2022 at 08:15, Simon Glass wrote: > > On Mon, 24 Jan 2022 at 14:15, Rasmus Villemoes > wrote: > > > > On 24/01/2022 18.57, Simon Glass wrote: > > > Hi, > > > > > > On Mon, 24 Jan 2022 at 09:02, Tom Rini wrote: > > >> > > >> On Mon, Jan 10, 2022 at 02:34:41PM +0100, Rasmus

Re: [PATCH] dm: Use parenthesis for the device_get_ops macro argument

2022-02-08 Thread Simon Glass
On Sat, 29 Jan 2022 at 12:21, Sughosh Ganu wrote: > > Use parenthesis for the device_get_ops macro argument. This prevents > errors when using an expression for the parameter. > > Signed-off-by: Sughosh Ganu > --- > include/dm/device.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH v2 1/1] sandbox: fix build failure with musl and SDL

2022-02-08 Thread Simon Glass
On 2/8/22 16:16, Simon Glass wrote: > On Sat, 29 Jan 2022 at 07:17, Heinrich Schuchardt > wrote: >> >> >> >> On 1/28/22 10:08, Heinrich Schuchardt wrote: >>> sdl.c is compiled against the SDL library. >>> >>> Trying to redefine wchar_t with -fshort-wchar is not necessary >>> and leads to build

Re: [PATCH 01/17] patman: Convert camel case in tools.py

2022-02-08 Thread Simon Glass
Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- tools/binman/bintool.py | 10 +- tools/binman/bintool_test.py| 34 +-- tools/binman/btool/lz4.py | 8 +- tools/binman/btool/lzma_alone.py

Re: [PATCH 03/17] patman: Convert camel case in checkpatch.py

2022-02-08 Thread Simon Glass
Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- tools/patman/checkpatch.py | 22 +++--- tools/patman/control.py | 2 +- tools/patman/test_checkpatch.py | 12 ++-- 3 files changed, 18 insertions(+), 18

Re: [PATCH 04/17] patman: Convert camel case in commit.py

2022-02-08 Thread Simon Glass
Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- tools/patman/commit.py | 10 +- tools/patman/patchstream.py | 8 tools/patman/series.py | 2 +- 3 files changed, 10 insertions(+), 10 deletions(-) Applied to

Re: [PATCH 02/17] patman: Convert camel case in command.py

2022-02-08 Thread Simon Glass
Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- tools/binman/bintool.py | 2 +- tools/binman/elf.py | 2 +- tools/binman/elf_test.py| 2 +- tools/binman/ftest.py | 2 +- tools/buildman/builder.py

Re: [PATCH 05/17] patman: Convert camel case in cros_subprocess.py

2022-02-08 Thread Simon Glass
Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- tools/patman/command.py | 2 +- tools/patman/cros_subprocess.py | 59 + 2 files changed, 31 insertions(+), 30 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH 06/17] patman: Convert camel case in func_test.py

2022-02-08 Thread Simon Glass
Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- tools/patman/func_test.py | 50 +++ 1 file changed, 25 insertions(+), 25 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH 07/17] patman: Convert camel case in get_maintainer.py

2022-02-08 Thread Simon Glass
Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- tools/patman/get_maintainer.py | 6 +++--- tools/patman/series.py | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH 08/17] patman: Convert camel case in gitutil.py

2022-02-08 Thread Simon Glass
Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- tools/buildman/builder.py | 12 ++-- tools/buildman/builderthread.py | 2 +- tools/buildman/control.py | 10 +-- tools/buildman/func_test.py | 4 +-

Re: [PATCH 09/17] patman: Convert camel case in project.py

2022-02-08 Thread Simon Glass
Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- tools/patman/main.py| 2 +- tools/patman/project.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH 10/17] patman: Convert camel case in test_checkpatch.py

2022-02-08 Thread Simon Glass
Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- tools/patman/test_checkpatch.py | 68 - 1 file changed, 34 insertions(+), 34 deletions(-) Applied to u-boot-dm, thanks!

Re: [PATCH 12/17] patman: Convert camel case in tout.py

2022-02-08 Thread Simon Glass
Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- tools/binman/bintool.py | 10 ++--- tools/binman/control.py | 44 +- tools/binman/elf.py | 6 +--

Re: [PATCH 14/17] patman: Rename Color() method to build()

2022-02-08 Thread Simon Glass
This method has the same name as its class which is confusing. It is also annoying when searching the code. It builds a string with a colour, so rename it to build(). Signed-off-by: Simon Glass --- tools/binman/bintool.py | 8 tools/buildman/builder.py | 24

Re: [PATCH 13/17] patman: Rename Print() to Tprint()

2022-02-08 Thread Simon Glass
Rename this function so that when we convert it to snake case it will not conflict with the built-in print() function. Signed-off-by: Simon Glass --- tools/buildman/builder.py | 56 +++ tools/buildman/control.py | 4 +-- tools/patman/main.py | 2 +-

Re: [PATCH 15/17] patman: Convert camel case in terminal.py

2022-02-08 Thread Simon Glass
Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- tools/buildman/builder.py | 68 ++--- tools/buildman/control.py | 4 +-- tools/buildman/func_test.py | 10 +++--- tools/buildman/test.py | 8 ++---

Re: [PATCH] serial: remove nulldev_serial_input

2022-02-08 Thread Simon Glass
On Wed, 2 Feb 2022 at 05:53, Heiko Schocher wrote: > > nulldev_serial_input is static and not used in this file, > so remove it. > > Signed-off-by: Heiko Schocher > --- > azure build is clean > https://dev.azure.com/hs0298/hs/_build/results?buildId=78=results > > drivers/serial/serial_nulldev.c

Re: [PATCH] serial-uclass: fix build warning

2022-02-08 Thread Simon Glass
On Wed, 2 Feb 2022 at 05:55, Heiko Schocher wrote: > > if CONFIG_DM_STDIO is defined but SERIAL_PRESENT not, > gcc drops warnings for serial_stub_* functions > that they are defined but not used. > > Fix it. > > Signed-off-by: Heiko Schocher > --- > azure build is clean >

Re: [PATCH 2/2] acpi: Move MCFG implementation to common lib

2022-02-08 Thread Simon Glass
Hi Moritz, On Mon, 7 Feb 2022 at 13:49, Moritz Fischer wrote: > > Hi Simon, > > On Mon, Feb 7, 2022 at 12:22 PM Simon Glass wrote: > > > > Hi Moritz, > > > > On Sat, 5 Feb 2022 at 13:17, Moritz Fischer wrote: > > > > > > MCFG tables are used on multiple arches. Move to common ACPI lib. > > > >

Re: [PATCH 1/2] arch: x86: lib: acpi_table: Fix MCFG entries

2022-02-08 Thread Simon Glass
Hi Moritz, On Sat, 5 Feb 2022 at 13:17, Moritz Fischer wrote: > > Commit d953137526cc ("x86: Move SSDT table to a writer function") > introduced a bug where the actual MCFG entries are no longer generated. > > Cc: Simon Glass > Fixes: d953137526cc ("x86: Move SSDT table to a writer function") >

Re: [PATCH v2 2/5] binman: Register and check bintools from FIT subentries

2022-02-08 Thread Simon Glass
Binman keeps track of binary tools each entry wants to use. The implementation of this for the FIT entry only adds "mkimage", but not the tools that would be used by its subentries. Register the binary tools that FIT subentries will use in addition to the one FIT itself uses, and check their

Re: [PATCH v2 1/5] binman: Fix subentry expansion for FIT entry type

2022-02-08 Thread Simon Glass
On Mon, 7 Feb 2022 at 15:08, Alper Nebi Yasak wrote: > > Binman tries to expand some entries into parts that make it up, e.g. > 'u-boot' into a 'u-boot-expanded' section that contains 'u-boot-nodtb' > and 'u-boot-dtb'. Entries with child entries must call ExpandEntries() > on them to build a

Re: [PATCH v2 3/5] binman: Check missing bintools of Section subclasses

2022-02-08 Thread Simon Glass
Binman can check for missing binary tools and prints warnings if anything required for an image is missing. The implementation of this for the Section entry only checks the subentries, presumably because Section does not use any binary tools itself. However, this means the check is also skipped

Re: [PATCH v2 4/5] binman: Convert FIT entry type to a subclass of Section entry type

2022-02-08 Thread Simon Glass
The binman FIT entry type shares some code with the Section entry type. This shared code is bound to grow, since FIT entries are conceptually a variation of Section entries. Make FIT entry type a subclass of Section entry type, simplifying it a bit and providing us the features that Section

[PATCH 00/24] binman: rockchip: Migrate from rockchip SPL_FIT_GENERATOR script

2022-02-08 Thread Simon Glass
At present rockchip 64-bit boards make use of a FIT-generator script written in Python. The script supports splitting an ELF file into several 'loadable' nodes in the FIT. Binman does not current support this feature. This series adds binman support for ELF splitting. This works by adding a new

Re: k210 spi flash regression

2022-02-08 Thread Pratyush Yadav
On 07/02/22 12:23PM, Niklas Cassel wrote: > Hello Pratyush, > > I upgraded u-boot on my k210 maix bit board, and the SPI flash is no longer > detected. > > > I bisected the problem to commit: > d15de623013c ("spi: spi-mem: allow specifying a command's extension") Hm, this commit is not

Re: [PATCH] boot: Update default on USE_SPL_FIT_GENERATOR

2022-02-08 Thread Simon Glass
Hi Tom, On Tue, 8 Feb 2022 at 10:53, Tom Rini wrote: > > On Tue, Feb 08, 2022 at 10:22:34AM -0500, Tom Rini wrote: > > On Tue, Feb 08, 2022 at 08:13:33AM -0700, Simon Glass wrote: > > > Hi Tom, > > > > > > On Mon, 31 Jan 2022 at 17:03, Tom Rini wrote: > > > > > > > > The use of

Re: [PATCH] binman: Correct the error message for a bad hash algorithm

2022-02-08 Thread Simon Glass
Hi Alper, On Tue, 8 Feb 2022 at 11:54, Alper Nebi Yasak wrote: > > On 08/02/2022 20:59, Simon Glass wrote: > > This shows an internal type at present, rather than the algorithm name. > > Fix it and update the test to catch this. > > > > Signed-off-by: Simon Glass > > --- > > > >

Re: [PATCH] binman: Correct the error message for a bad hash algorithm

2022-02-08 Thread Alper Nebi Yasak
On 08/02/2022 20:59, Simon Glass wrote: > This shows an internal type at present, rather than the algorithm name. > Fix it and update the test to catch this. > > Signed-off-by: Simon Glass > --- > > tools/binman/ftest.py | 2 +- > tools/binman/state.py | 2 +- > 2 files changed, 2

[PATCH 24/24] rockchip: Drop the FIT generator script

2022-02-08 Thread Simon Glass
This is not used anymore. Drop it. Signed-off-by: Simon Glass --- Makefile | 3 - arch/arm/mach-rockchip/make_fit_atf.py | 240 - boot/Kconfig | 1 - 3 files changed, 244 deletions(-) delete mode 100755

[PATCH 23/24] rockchip: Convert all boards to use binman

2022-02-08 Thread Simon Glass
Instead of the bash script, use binman to generate the FIT for arm64. For 32-bit boards, use binman for all images, dropping the intermediate files. With this change, only Zynq is now using SPL_FIT_GENERATOR so update the Kconfig rule accordingly. Clean up the Makefile to the extent possible.

[PATCH 22/24] rockchip: Support building the all output files in binman

2022-02-08 Thread Simon Glass
Add the required binman images to replace the Makefile rules which are currently used. This includes subsuming: - tpl/u-boot-tpl-rockchip.bin if TPL is enabled - idbloader.img if either or both of SPL and TPL are enabled - u-boot.itb2 if SPL_FIT is enabled - u-boot-rockchip.bin if SPL

[PATCH 20/24] binman: Support splitting an ELF file into multiple nodes

2022-02-08 Thread Simon Glass
Some boards need to load an ELF file using the 'loadables' property, but the file has segments at different memory addresses. This means that it cannot be supplied as a flat binary. Allow generating a separate node in the FIT for each segment in the ELF, with a different load address for each.

[PATCH 21/24] rockchip: Include binman script in 64-bit boards

2022-02-08 Thread Simon Glass
Include the rockchip-u-boot.dtsi file with 64-bit boards and enable binman so that these boards can also use it, rather than using special Makefile rules and scripts. This does not change the Makefile nor remove any scripts, but sets it up so that this is possible. Signed-off-by: Simon Glass

[PATCH 19/24] binman: Allow different operations in FIT generator nodes

2022-02-08 Thread Simon Glass
At present we only support expanding out FDT nodes. Make the operation into an @operation property, so that others can be supported. Re-arrange and tidy up the documentation so that it has separate headings for each topic. Signed-off-by: Simon Glass --- tools/binman/entries.rst

[PATCH 18/24] binman: Tidy up the docs a little with fit

2022-02-08 Thread Simon Glass
Add a few quotes and clarify the data property. Signed-off-by: Simon Glass --- tools/binman/entries.rst | 15 --- tools/binman/etype/fit.py | 15 --- 2 files changed, 16 insertions(+), 14 deletions(-) diff --git a/tools/binman/entries.rst b/tools/binman/entries.rst

[PATCH 16/24] binman: Move entry-data collection into a Entry method

2022-02-08 Thread Simon Glass
Collecting the data from a list of entries and putting it in a file is a useful operation that will be needed by other entry types. Put this into a method in the Entry class. Add some documentation about how to collect data for an entry type. Signed-off-by: Simon Glass ---

[PATCH 17/24] binman: fit: Refactor to reduce function size

2022-02-08 Thread Simon Glass
Split subnode and property processing into separate functions to make the _AddNode() function a little smaller. Tweak a few comments. This does not change any functionality. Signed-off-by: Simon Glass --- tools/binman/etype/fit.py | 116 -- 1 file changed,

[PATCH 15/24] binman: Add a ELF test file with disjoint text sections

2022-02-08 Thread Simon Glass
Add a file that has two text sections at different addresses, so we can test this behaviour in binman, once added. Signed-off-by: Simon Glass --- tools/binman/test/Makefile | 6 +- tools/binman/test/elf_sections.c | 20 +++ tools/binman/test/elf_sections.lds | 31

[PATCH 12/24] WIP: binman: Add support for OP-TEE

2022-02-08 Thread Simon Glass
Add support for an Open Portable Trusted Execution Environment (OP-TEE) blob which is used with ARM Trusted Firmware. Note: This is a placeholder patch as Roger Quadros has already posted one: https://patchwork.ozlabs.org/project/uboot/patch/20220204130031.24610-1-rog...@kernel.org/

[PATCH 14/24] binman: Support a list of strings with the mkimage etype

2022-02-08 Thread Simon Glass
At present the 'args' property of the mkimage entry type is a string. This makes it difficult to include CONFIG options in that property. In particular, this does not work: args = "-n CONFIG_SYS_SOC -E" since the preprocessor does not operate within strings, nor does this: args = "-n"

[PATCH 13/24] binman: Add to the TODO

2022-02-08 Thread Simon Glass
Add some ideas that have come to mind recently. Signed-off-by: Simon Glass --- tools/binman/binman.rst | 8 1 file changed, 8 insertions(+) diff --git a/tools/binman/binman.rst b/tools/binman/binman.rst index 9e39e678a3..d6b95de1f5 100644 --- a/tools/binman/binman.rst +++

[PATCH 11/24] elf: Add a way to read segment information from an ELF file

2022-02-08 Thread Simon Glass
Add a function which reads the segments and the entry address. Also fix a comment nit in the tests while we are here. Signed-off-by: Simon Glass --- tools/binman/elf.py | 37 + tools/binman/elf_test.py | 31 +-- 2 files

[PATCH 10/24] binman: Update docs to indicate mkimage is supported

2022-02-08 Thread Simon Glass
Now that there is a mkimage entry-type, update the docs to remove the future reference. Signed-off-by: Simon Glass --- tools/binman/binman.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/binman/binman.rst b/tools/binman/binman.rst index ab5a5e06b1..9e39e678a3

[PATCH 06/24] dtoc: Support adding a string list to a device tree

2022-02-08 Thread Simon Glass
Add a new function to add a string list. Signed-off-by: Simon Glass --- tools/dtoc/fdt.py | 18 ++ tools/dtoc/test_fdt.py | 8 2 files changed, 26 insertions(+) diff --git a/tools/dtoc/fdt.py b/tools/dtoc/fdt.py index 32a7aa9829..e7197f8f12 100644 ---

[PATCH 09/24] dtoc: Support reading a list of arguments

2022-02-08 Thread Simon Glass
It is helpful to support a string or stringlist containing a list of space-separated arguments, for example: args = "-n fred", "-a", "123"; This resolves to the list: -n fred -a 123 which can be passed to a program as arguments. Add a helper to do the required processing.

[PATCH 08/24] dtoc: Allow deleting nodes and adding them in the same sync

2022-02-08 Thread Simon Glass
This does not work at present, since the current algorithm assumes that either there are no nodes or all nodes have an offset. If a node is new, but an old node is still in the tree, then syncing fails due to this assumption. Fix it and add a test. Signed-off-by: Simon Glass ---

[PATCH 07/24] dtoc: Support deleting a node

2022-02-08 Thread Simon Glass
Add a function to delete a node. This is synced to the tree when requested. Signed-off-by: Simon Glass --- tools/dtoc/fdt.py | 17 + tools/dtoc/test_fdt.py | 9 + 2 files changed, 26 insertions(+) diff --git a/tools/dtoc/fdt.py b/tools/dtoc/fdt.py index

[PATCH 05/24] rockchip: evb-rk3288: Drop raw-image support

2022-02-08 Thread Simon Glass
This boards uses SPL_FIT so does not need to support loading a raw image. Drop it to avoid binman trying to insert a symbol which has no value. Signed-off-by: Simon Glass --- configs/evb-rk3288_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/evb-rk3288_defconfig

[PATCH 04/24] spl: Allow disabling binman symbols in SPL

2022-02-08 Thread Simon Glass
When CONFIG_SPL_FIT is enabled we do not access U-Boot directly in the image, since it is embedded in a FIT which is parsed at runtime. Provide a CONFIG option to drop the symbols in this case. Signed-off-by: Simon Glass --- common/spl/Kconfig | 24 common/spl/spl.c

[PATCH 03/24] spl: x86: Correct the binman symbols for SPL

2022-02-08 Thread Simon Glass
These symbols are incorrect, meaning that binman cannot find the associated entry. This leads to errors like: binman: Section '/binman/simple-bin': Symbol '_binman_spl_prop_size' in entry '/binman/simple-bin/u-boot-spl/u-boot-spl-nodtb': Entry 'spl' not found in list

[PATCH 02/24] moveconfig: Allow regex matches when finding combinations

2022-02-08 Thread Simon Glass
It is useful to be able to search for CONFIG options that match a regex, such as this, which lists boards which define SPL_FIT_GENERATOR and anything not starting with ROCKCHIP: ./tools/moveconfig.py -f SPL_FIT_GENERATOR ~ROCKCHIP.* Add support for this. Signed-off-by: Simon Glass ---

[PATCH 01/24] moveconfig: Show the config name rather than the defconfig

2022-02-08 Thread Simon Glass
The _defconfig suffix is unnecessary when showing matching boards. Drop it. Signed-off-by: Simon Glass --- tools/moveconfig.py | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/tools/moveconfig.py b/tools/moveconfig.py index 1bcf58caf1..5ef5a95eb6 100755 ---

[PATCH] common: spl: spl_mmc: Add full FIT image support for kernel/OS loading during Falcon boot mode while booting via MMC

2022-02-08 Thread Nathan Barrett-Morrison
Hi Tom, This patch adds support for Falcon mode boot via MMC flash boot devices with full FIT images. While attempting to use Falcon boot mode with FIT images on MMC flash boot devices, I've found the following additional code to be required. Patch attached and also added inline below:

Re: Running qemu tests on RISC-V

2022-02-08 Thread Alper Nebi Yasak
On 08/02/2022 20:13, Simon Glass wrote: > Hi Heinrich, > > On Tue, 8 Feb 2022 at 08:34, Heinrich Schuchardt wrote: >> >> On 2/8/22 15:52, Simon Glass wrote: >>> Hi Heinrich, >>> >>> On Tue, 8 Feb 2022 at 01:21, Heinrich Schuchardt wrote: Hello Simon, The

[PATCH] common: spl: spl_spi: Add in FIT image support for kernel/OS loading during Falcon boot mode while booting via SPI

2022-02-08 Thread Nathan Barrett-Morrison
Hi Tom, This patch adds support for Falcon mode boot via SPI flash boot devices with FIT images. While attempting to use Falcon boot mode with FIT images on SPI flash boot devices, I've found the following additional code to be required. Patch attached and also added inline below: Sincerely,

[PATCH] binman: Correct the error message for a bad hash algorithm

2022-02-08 Thread Simon Glass
This shows an internal type at present, rather than the algorithm name. Fix it and update the test to catch this. Signed-off-by: Simon Glass --- tools/binman/ftest.py | 2 +- tools/binman/state.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/binman/ftest.py

Re: [PATCH] boot: Update default on USE_SPL_FIT_GENERATOR

2022-02-08 Thread Tom Rini
On Tue, Feb 08, 2022 at 10:22:34AM -0500, Tom Rini wrote: > On Tue, Feb 08, 2022 at 08:13:33AM -0700, Simon Glass wrote: > > Hi Tom, > > > > On Mon, 31 Jan 2022 at 17:03, Tom Rini wrote: > > > > > > The use of CONFIG_SPL_FIT_GENERATOR is deprecated and should not be > > > used. Start by

Re: [PATCH v2 06/25] phy: cadence: Sierra: Add array of input clocks in "struct cdns_sierra_phy"

2022-02-08 Thread Tom Rini
On Fri, Jan 28, 2022 at 01:41:33PM +0530, Aswath Govindraju wrote: > From: Kishon Vijay Abraham I > > Instead of having separate structure members for each input clock, add > an array for the input clocks within "struct cdns_sierra_phy". This is > in preparation for adding more input clocks

Re: [PATCH] Nokia RX-51: Convert to CONFIG_DM_KEYBOARD

2022-02-08 Thread Tom Rini
On Thu, Feb 03, 2022 at 07:38:50PM +0100, Pali Rohár wrote: > Signed-off-by: Pali Rohár Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 25/25] include: configs: j721e_evm: Add support to boot ethfw core in j721e

2022-02-08 Thread Tom Rini
On Fri, Jan 28, 2022 at 01:41:52PM +0530, Aswath Govindraju wrote: > Add configs to enable booting ethfw core in j721e > > Signed-off-by: Aswath Govindraju Applied to u-boot/master, thanks! -- Tom signature.asc Description: PGP signature

  1   2   3   >