Re: [PATCH] mtd: nand: denali: Add SPL image loader

2022-10-20 Thread Michael Nazzareno Trimarchi
Hi On Fri, Oct 21, 2022 at 5:26 AM Jagan Teki wrote: > > On Mon, Sep 5, 2022 at 7:44 PM Jit Loon Lim wrote: > > > > From: Tien Fong Chee > > > > Add image loader used by the NAND SPL into the full Denali NAND > > driver. This allows usage of the full Denali NAND driver in SPL instead > > of

Re: [PATCH] mtd: nand: denali: Add SPL image loader

2022-10-20 Thread Jagan Teki
On Mon, Sep 5, 2022 at 7:44 PM Jit Loon Lim wrote: > > From: Tien Fong Chee > > Add image loader used by the NAND SPL into the full Denali NAND > driver. This allows usage of the full Denali NAND driver in SPL instead > of the reduced SPL-only version. > > Signed-off-by: Tien Fong Chee >

Re: [PATCH] mtd: nand: Allow full NAND framework in SPL

2022-10-20 Thread Jagan Teki
On Mon, Sep 5, 2022 at 7:41 PM Jit Loon Lim wrote: > > From: Tien Fong Chee > > Add configuration option to compile the entire NAND framework into > U-Boot SPL. This is required by some drivers, like the Denali NAND, > which use a lot of functionality from the NAND core. > > Signed-off-by: Marek

[PATCH] efi_loader: remove CONFIG_EFI_SETUP_EARLY

2022-10-20 Thread AKASHI Takahiro
Since the commit a9bf024b2933 ("efi_loader: disk: a helper function to create efi_disk objects from udevice"), CONFIG_EFI_SETUP_EARLY option is by default on and will never be turned off. So just remove this option. Signed-off-by: AKASHI Takahiro --- common/board_r.c | 2 +-

Re: [PATCH v2 00/28] ARM: Add Rockchip RV1126 support

2022-10-20 Thread Jagan Teki
Hi Kever, On Mon, 17 Oct 2022 at 19:03, Jagan Teki wrote: > > Hi Kever, > > On Mon, 17 Oct 2022 at 18:59, Kever Yang wrote: > > > > Hi Jagan, > > > > Could you resend this patch set? There are some merge conflict when > > I try to apply. > > > > For dts related patch, please add the

Pull request: u-boot-rockchip-20221020

2022-10-20 Thread Kever Yang
) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-rockchip.git tags/u-boot-rockchip-20221020 for you to fetch changes up to 85a8ef1264fca77827f7702594272d17c7c39ce1: arm: dts: rockchip: rk356x: sync with Linux 6.0 (2022-10-19 19:30:49 +0800

Re: [PATCH v2 11/12] rockchip: lion-rk3368: migrate to u-boot-rockchip.bin

2022-10-20 Thread Kever Yang
On 2022/10/19 22:10, quentin.sch...@theobroma-systems.com wrote: Hi Kever, On 10/19/22 2:47 PM, Kever Yang wrote: Hi Quentin, This is report by the  denx ci system:

[PATCH v3 16/43] disk: Rename block_dev to desc

2022-10-20 Thread Simon Glass
The use of 'block_dev' in this context is confusing, since it is not a pointer to a device, just to some information about it. Rename this to 'desc', as is more commonly used, since it is a block descriptor. Signed-off-by: Simon Glass Acked-by: Heinrich Schuchardt --- (no changes since v2)

[PATCH v3 15/43] disk: Rename block functions

2022-10-20 Thread Simon Glass
Use the uclass type as the first part of the function name, to be consistent with the methods in other block drivers. Signed-off-by: Simon Glass --- Changes in v3: - Add comments to the renamed functions Changes in v2: - Add new patch to rename block functions disk/disk-uclass.c| 24

[PATCH v3 25/43] sandbox: Add a way to specify the sandbox executable

2022-10-20 Thread Simon Glass
At present the sandbox executable is assumed to be arg[0] but this only works for a single jump (e.g. from SPL to U-Boot). Add a new arg to solve this issue, along with a detailed comment. Signed-off-by: Simon Glass --- (no changes since v1) arch/sandbox/cpu/start.c | 30

[PATCH v3 43/43] vbe: Add a test for the VBE flow into U-Boot proper

2022-10-20 Thread Simon Glass
Add a test which checks that VBE boots correctly from TPL through to U-Boot proper. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Drop patch 'rsa: Avoid warning in padding_pss_verify()' arch/sandbox/dts/test.dts | 37 ++

[PATCH v3 37/43] vbe: Add info about the VBE device to the fwupd node

2022-10-20 Thread Simon Glass
At present we put the driver in the /chosen node in U-Boot. This is a bit strange, since U-Boot doesn't normally use that node itself. It is better to put it under the bootstd node. To make this work we need to copy create the node under /chosen when fixing up the device tree. Copy over all the

[PATCH v3 26/43] image: Add the concept of a phase to FIT

2022-10-20 Thread Simon Glass
We want to be able to mark an image as related to a phase, so we can easily load all the images for SPL or for U-Boot proper. Add this to the FIT specification, along with some access functions. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Attach the phase to the

[PATCH v3 32/43] vbe: Support selecting operations by SPL phase

2022-10-20 Thread Simon Glass
VBE supports booting firmware during the SPL phases, i.e. so that VPL can start SPL and SPL can start U-Boot. It also supports booting an OS, when in U-Boot. As a first step towards these features, add functions to indicate the current VBE phase. The firmware selection is done in VPL and the OS

[PATCH v3 42/43] vbe: Add a command to show the VBE state

2022-10-20 Thread Simon Glass
Add a VBE comment which shows the current state. Currently this is just the phases which booted via VBE. Signed-off-by: Simon Glass --- (no changes since v1) cmd/vbe.c | 31 ++- include/spl.h | 2 ++ 2 files changed, 32 insertions(+), 1 deletion(-) diff --git

[PATCH v3 34/43] vbe: Move OS implementation into a separate file

2022-10-20 Thread Simon Glass
Move this into its own file so it can be built only by U-Boot proper. Signed-off-by: Simon Glass --- (no changes since v1) boot/Makefile| 1 + boot/vbe_simple.c| 102 +-- boot/vbe_simple.h| 34 +++

[PATCH v3 41/43] vbe: Record which phases loaded using VBE

2022-10-20 Thread Simon Glass
We expect VPL and SPL to load using VBE. Add a record of this so we can check it in U-Boot proper. Signed-off-by: Simon Glass --- (no changes since v1) boot/vbe_simple_fw.c | 10 ++ include/bloblist.h | 1 + include/vbe.h| 9 + 3 files changed, 20 insertions(+)

[PATCH v3 36/43] vbe: Add Kconfig options for VPL

2022-10-20 Thread Simon Glass
Enable the various features needed in VPL, by adding Kconfig options. Update the defconfig for sandbox_vpl so that the build for each phase includes what is needed. Drop LZMA for now and make sure partition support is omitted in SPL, since it is not needed. Signed-off-by: Simon Glass --- (no

[PATCH v3 38/43] sandbox: Add an image for VPL

2022-10-20 Thread Simon Glass
Use binman to build an image which includes all the U-Boot phases so that a full VBE boot can take place with just that image.bin file. Attach the image file to mmc2 so it can be loaded. VBE is used to load images in two phases: - In VPL, VBE decides which SPL image to load - In SPL, VBE

[PATCH v3 39/43] vpl: Allow signature verification

2022-10-20 Thread Simon Glass
Add the required Kconfig option so that signatures can be verified when loading a configuration. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Add new patch to allow signature verification boot/Kconfig | 1 - common/Kconfig | 7 +++ 2 files changed, 7

[PATCH v3 31/43] sandbox: Support obtaining the next phase from an image

2022-10-20 Thread Simon Glass
At present sandbox runs the next phase from discrete executables, so for example u-boot-tpl runs u-boot-vpl to get to the next phase. In some cases the phases are all built into a single firmware image, as is done for real boards. Add support for this to sandbox. Make it higher priority so that

[PATCH v3 35/43] vbe: Drop the U-Boot prefix from the version

2022-10-20 Thread Simon Glass
We don't need the U-Boot prefix on the version and in fact it is harmful since pytest gets confused seeing the U-Boot banner bring displayed when the version is printed. Drop the prefix from the string. We could produce an entirely new string from the component parts, but this adds to the rodata

[PATCH v3 27/43] image: Allow loading a FIT image for a particular phase

2022-10-20 Thread Simon Glass
Add support for filtering out FIT images by phase. Rather than adding yet another argument to this already overloaded function, use a composite value, where the phase is only added in if needed. The FIT config is still selected (and verified) as normal, but the images are selected based on the

[PATCH v3 30/43] spl: Allow multiple loaders of the same time

2022-10-20 Thread Simon Glass
At present we only support a single loader of each time. Extra ones are ignored. This means that only one BOOT_DEVICE_BOARD can be used in the SPL image. This is inconvenient since we sometimes want to provide several board-specific drivers, albeit at different priorties. Add support for this.

[PATCH v3 22/43] sandbox: Drop message about writing sandbox state

2022-10-20 Thread Simon Glass
This happens every time sandbox moves to the next phase so is not very interesting. Display the message only when debugging. Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt --- (no changes since v1) arch/sandbox/cpu/state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v3 33/43] vbe: Support reading the next SPL phase via VBE

2022-10-20 Thread Simon Glass
Add an SPL loader to obtain the next-phase binary from a FIT provided by the VBE driver. Signed-off-by: Simon Glass --- (no changes since v1) arch/sandbox/cpu/spl.c | 3 +- arch/sandbox/include/asm/spl.h | 1 + boot/Makefile | 1 + boot/vbe_request.c

[PATCH v3 24/43] sandbox: Generalise SPL booting

2022-10-20 Thread Simon Glass
At present sandbox only supports jumping to a file, to get to the next U-Boot phase. We want to support other methods, so update the code to use an enum for the method. Also use the Use board_boot_order() to set the order, so we can add more options. Also add the MMC methods into the BOOT_DEVICE

[PATCH v3 40/43] vbe: Use a manual test

2022-10-20 Thread Simon Glass
Use a manual test for the VBE test, so we can make the pytest and the C unit test work together properly. Signed-off-by: Simon Glass --- (no changes since v1) test/boot/vbe_fixup.c | 19 --- test/py/tests/test_vbe.py | 7 ++- 2 files changed, 10 insertions(+), 16

[PATCH v3 29/43] vbe: Use a warning for a failed requests

2022-10-20 Thread Simon Glass
Optional requests should present a warning rather than an error. Update the log call. Signed-off-by: Simon Glass --- (no changes since v1) boot/vbe_request.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/boot/vbe_request.c b/boot/vbe_request.c index

[PATCH v3 18/43] usb: Update the test to cover reading and writing

2022-10-20 Thread Simon Glass
Add test coverage for blk_write() as well. The blk_erase() is not tested for now as the USB stor interface does not support erase. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Rebase to master drivers/scsi/scsi_emul.c | 9

[PATCH v3 14/43] bootstd: Add a way to set up a bootflow

2022-10-20 Thread Simon Glass
Add a function to init a bootflow, to reduce code duplication. Signed-off-by: Simon Glass --- (no changes since v1) boot/bootdev-uclass.c | 5 + boot/bootflow.c| 9 + boot/bootmeth-uclass.c | 5 + include/bootflow.h | 12 4 files changed, 23

[PATCH v3 23/43] image: Move comment for fit_conf_find_compat()

2022-10-20 Thread Simon Glass
Move this comment to the header file, where the APIs should be defined. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Update the comment style boot/image-fit.c | 43 --- include/image.h | 41

[PATCH v3 28/43] vbe: Rename vbe_fixup to vbe_request

2022-10-20 Thread Simon Glass
The vbe_fixup file handles device tree fixups, but these are called OS requests in VBE. Rename the file to reflect its wider purpose. Signed-off-by: Simon Glass --- (no changes since v1) boot/Makefile | 2 +- boot/{vbe_fixup.c => vbe_request.c} | 2 +-

[PATCH v3 17/43] dm: blk: Add udevice functions

2022-10-20 Thread Simon Glass
At present we have functions called blk_dread(), etc., which take a struct blk_desc * to refer to the block device. Add some functions which use udevice instead, since this is more in keeping with how driver model is supposed to work. Update one of the tests to use this. Note that it would be

[PATCH v3 19/43] bloblist: Drop debugging

2022-10-20 Thread Simon Glass
Disable debugging by default since this implementation is stable now. Signed-off-by: Simon Glass --- (no changes since v1) common/bloblist.c | 1 - 1 file changed, 1 deletion(-) diff --git a/common/bloblist.c b/common/bloblist.c index 8488663354b..0d63b6e8817 100644 --- a/common/bloblist.c

[PATCH v3 21/43] dm: mmc: Allow sandbox emulator to build without writes

2022-10-20 Thread Simon Glass
When MMC_WRITE is disabled this driver produced a build error. Fix this. Also update a comment while we are here. Signed-off-by: Simon Glass Reviewed-by: Jaehoon Chung --- (no changes since v1) drivers/mmc/sandbox_mmc.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff

[PATCH v3 20/43] dm: blk: mmc: Tidy up some Makefile rules for SPL

2022-10-20 Thread Simon Glass
Use the correct SPL_TPL_ variable so that these features can be enabled in TPL and VPL as needed. Disable it by default in TPL to avoid any code-size increase. No boards are actually using it since the Makefile rules don't allow including drivers/block/ with TPL_DM enabled. It can be manually

[PATCH v3 12/43] test: Update tests to use the skip feature

2022-10-20 Thread Simon Glass
Some tests currently return 0 when they want to be skipped. Update them to return -EAGAIN instead, so they are counted as skipped. A few tests are in two parts, with the latter part being skipped in certain situations. Split these into two and use the correct condition for the second part.

[PATCH v3 13/43] test: Support tests which can only be run manually

2022-10-20 Thread Simon Glass
At present we normally write tests either in Python or in C. But most Python tests end up doing a lot of checks which would be better done in C. Checks done in C are orders of magnitude faster and it is possible to get full access to U-Boot's internal workings, rather than just relying on the

[PATCH v3 09/43] binman: Handle writing ELF symbols in the Entry class

2022-10-20 Thread Simon Glass
This feature is used by several etypes and we plan to add more that use it. Make symbol writing a feature of the base class to reduce the code duplication. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/entry.py | 13 +++--

[PATCH v3 11/43] test: Report skippped tests

2022-10-20 Thread Simon Glass
At present it is possible for a test to skip itself by returning -EAGAIN but this is not recorded. An existing example is in test_pre_run() with the "Console recording disabled" check. Keep a track of skipped tests and report the total at the end. Signed-off-by: Simon Glass Acked-by: Heinrich

[PATCH v3 10/43] binman: Support writing symbols into ELF files

2022-10-20 Thread Simon Glass
In some cases the ELF version of SPL builds may be packaged, rather than a binary .bin file. Add support for this. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/elf.py | 41 +++ tools/binman/entry.py | 5 ++-

[PATCH v3 07/43] binman: Allow obtaining a symbol value

2022-10-20 Thread Simon Glass
Provide a function to obtain the integer value of an ELF symbol. This will be used Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/elf.py | 53 ++--- 1 file changed, 45 insertions(+), 8 deletions(-) diff --git a/tools/binman/elf.py

[PATCH v3 08/43] binman: Split out looking up a symbol into a function

2022-10-20 Thread Simon Glass
Move this code into its own function so it can be used from tests. Signed-off-by: Simon Glass --- (no changes since v1) tools/binman/etype/section.py | 60 ++- 1 file changed, 45 insertions(+), 15 deletions(-) diff --git a/tools/binman/etype/section.py

[PATCH v3 05/43] spl: Refactor controls for console output

2022-10-20 Thread Simon Glass
The expression in boot_from_devices() is fairly long and appears to be an artefact from before we could easily call printf(...) and have the call be nop'd out. So update it to just check CONFIG_SILENT_CONSOLE. Signed-off-by: Simon Glass Suggested-by: Tom Rini --- (no changes since v1)

[PATCH v3 06/43] spl: Add a separate silence option for SPL

2022-10-20 Thread Simon Glass
Add an option to allow silent console to be controlled separately in SPL, so that boot progress can be shown. Disable it by default for sandbox since it is useful to see what is going on there. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Refactor based on a change to

[PATCH v3 04/43] spl: Use binman suffix allow symbols of any SPL etype

2022-10-20 Thread Simon Glass
At present we use symbols for the u-boot-spl entry, but this is not always what we want. For example, sandbox actually jumps to a u-boot-spl-elf entry, since sandbox executables are ELF files. We already handle this with U-Boot by using the '-any' suffix. Add it for SPL as well. Signed-off-by:

[PATCH v3 03/43] disk: Drop debug messages in part_efi

2022-10-20 Thread Simon Glass
This is monstrously verbose when something goes wrong. It should work by recording the problem and reporting it (once) at the command level. At present it sometimes outputs hundreds of lines of CRC mismatches. For now, just silence it all. GUID Partition Table Entry Array CRC is wrong:

[PATCH v3 01/43] WIP: gitlab: Install pyelftools

2022-10-20 Thread Simon Glass
This should not need to be applied if the Dockerfile update is taken. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Move the gitlab change into an RFC patch .gitlab-ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index

[PATCH v3 00/43] vbe: Implement the full firmware flow

2022-10-20 Thread Simon Glass
This series provides an implementation of VBE from TPL through to U-Boot proper, using VBE to load the relevant firmware stages. It buils a single image.bin file containing all the phases: TPL - initial phase, loads VPL using binman symbols VPL - main firmware phase, loads SPL using VBE

[PATCH 3/3] highbank: switch to use the Arm SP804 DM_TIMER driver

2022-10-20 Thread Andre Przywara
So far the Calxeda machines were using the CONFIG_SYS_TIMER_* macros to simply hardcode the address of the counter register of the SP804 timer. This method is deprecated and scheduled for removal. Use the newly introduced SP804 DM_TIMER driver to provide timer functionality on Highbank and Midway

[PATCH 2/3] highbank: scan into hb_sregs DT subnodes

2022-10-20 Thread Andre Przywara
The DT used for Calxeda Highbank and Midway systems exposes a "system registers" block, modeled as a DT subnode. This includes several clocks, including the two fixed clocks for the main oscillator and timer. So far U-Boot was ignorant of this special construct (a "clocks" node within the

[PATCH 1/3] timer: add SP804 UCLASS timer driver

2022-10-20 Thread Andre Przywara
The "Arm Ltd. Dual-Timer Module (SP804)" is a simple 32-bit count-down timer IP with interrupt functionality, and is used in some SoCs from various vendors. Add a simple DM compliant timer driver, to allow users of the SP804 to switch to DM_TIMER. This relies on the input clock to be accessible

[PATCH 0/3] timer: add SP804 DM_TIMER driver (and use it)

2022-10-20 Thread Andre Przywara
Some boards were using an ARM SP804 timer IP, but were driving that using hardcoded addresses and input frequencies, using the CONFIG_SYS_TIMER_* macros. This is deprecated and scheduled for removal. This series adds a DM_TIMER compliant SP804 driver in patch 1, and lets the Highbank board use

[PATCH] arm: armada: dts: Add clock to armada-ap80x uart1

2022-10-20 Thread Hamish Martin
The uart1 node was missing the 'clock-frequency' property. This meant the driver for this device would fail at probe. The clock for uart1 is fed from the same source as uart0 and is a fixed 200MHz clock. This is confirmed via documentation for the CN9130 SoC and from the equivalent code in Linux

Re: [maemo-leste] Broken u-boot on n900 hw (possibly CONFIG_POSITION_INDEPENDENT)

2022-10-20 Thread Pali Rohár
On Monday 10 October 2022 23:30:21 Sicelo wrote: > On Sun, Oct 09, 2022 at 09:33:17PM +0200, Pali Rohár wrote: > > Hello! > > > > Current u-boot from master branch does not work on n900 hw. It does not > > show anything on display, there just nokia logo. > > > > In qemu it is working fine and

Re: [PATCH v2 2/5] Makefile: Correct a missing FORCE on the binman rule

2022-10-20 Thread Pali Rohár
On Wednesday 19 October 2022 19:55:43 Simon Glass wrote: > Hi Pali, > > On Sun, 16 Oct 2022 at 04:16, Pali Rohár wrote: > > > > On Tuesday 11 October 2022 23:35:22 Masahiro Yamada wrote: > > > On Tue, Oct 11, 2022 at 11:16 PM Simon Glass wrote: > > > > > > > > This is required for if_changed to

[PATCH v2] mkimage: fit: Fix signing of configs with external data

2022-10-20 Thread Sean Anderson
Just like we exclude data-size, data-position, and data-offset from fit_config_check_sig, we must exclude them while signing as well. While we're at it, use the FIT_DATA_* defines for fit_config_check_sig as welll. Fixes: 8edecd3110e ("fit: Fix verification of images with external data") Fixes:

[PATCH v2 4/4] cmd: source: Support specifying config name

2022-10-20 Thread Sean Anderson
As discussed previously [1,2], the source command is not safe to use with verified boot unless there is a key with required = "images" (which has its own problems). This is because if such a key is absent, signatures are verified but not required. It is assumed that configuration nodes will

[PATCH v2 2/4] treewide: Use NULL for script image name

2022-10-20 Thread Sean Anderson
Two callers of image_source_script specify an image name. However, both use the deprecated @ syntax, indicating that they have not been updated in a while. If CONFIG_FIT_SIGNATURE is enabled, we will reject such names outright. Back in commit 152576a598c ("stm32mp: stm32prog: handle U-Boot script

[PATCH v2 3/4] cmd: source: Clean up a few lines

2022-10-20 Thread Sean Anderson
This simplifies a few lines and corrects an error message. Signed-off-by: Sean Anderson Reviewed-by: Simon Glass --- (no changes since v1) cmd/source.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/cmd/source.c b/cmd/source.c index bb98255fe86..f08e6d34172

[PATCH v2 0/4] cmd: source: Support specifying config name

2022-10-20 Thread Sean Anderson
This series adds support for using configs with the source command. See the third patch for details. Changes in v2: - Add test for source command Sean Anderson (4): test: Add test for source command treewide: Use NULL for script image name cmd: source: Clean up a few lines cmd: source:

[PATCH v2 1/4] test: Add test for source command

2022-10-20 Thread Sean Anderson
This adds a basic test for FIT image handling by the source command. It's a python test becase we need to run mkimage. Signed-off-by: Sean Anderson --- Changes in v2: - New test/py/tests/source.its | 43 test/py/tests/test_source.py | 28

Re: [PULL] u-boot-riscv/master

2022-10-20 Thread Tom Rini
On Thu, Oct 20, 2022 at 12:36:23PM +, Leo Liang wrote: > Hi Tom, > > The following changes since commit 3724ddf157aab3bd009c1da234b9a1af1621b544: > > Merge branch '2022-10-18-TI-platform-updates' (2022-10-18 18:13:39 -0400) > > are available in the Git repository at: > >

Re: [GIT PULL] clk changes for v2023.01

2022-10-20 Thread Tom Rini
On Wed, Oct 19, 2022 at 07:56:17PM -0400, Sean Anderson wrote: > The following changes since commit d3ccdc0fce206c1d54fbdc607333de6184e19e75: > > Merge tag 'efi-2022-10-rc6' of > https://source.denx.de/u-boot/custodians/u-boot-efi (2022-09-30 08:30:38 > -0400) > > are available in the Git

Re: Pull request: u-boot-sunxi/master for 2023.01

2022-10-20 Thread Tom Rini
On Thu, Oct 20, 2022 at 12:54:27AM +0100, Andre Przywara wrote: > Hi Tom, > > please pull the first bunch of the sunxi pull request for this cycle. > Beside some rather unexciting sync of the DTs from the kernel tree, and > some Kconfig cleanup, there are some improvements for the ARMv5

[PATCH] arm: mach-omap2: Move common image process functions out of board files

2022-10-20 Thread Andrew Davis
The functions board_fit_image_post_process() and board_tee_image_process() are not actually board specific (despite their names). Any board using the OMAP2 family can use these functions. Move them to boot-common.c. Signed-off-by: Andrew Davis --- arch/arm/mach-omap2/boot-common.c | 16

Re: [uboot] mtd NAND recognition regression

2022-10-20 Thread Michael Nazzareno Trimarchi
Hi Marcin On Thu, Oct 20, 2022 at 6:13 PM Michael Nazzareno Trimarchi wrote: > > Hi > > On Thu, Oct 20, 2022 at 5:58 PM Marcin Gołaś wrote: > > > > Hi, > > > > after uboot update from 2022.07 to 2022.10 SAMSUNG NAND is not recognized > > correctly. > > I use device with SAMSUNG K9K8G08U0F flash

Re: [uboot] mtd NAND recognition regression

2022-10-20 Thread Michael Nazzareno Trimarchi
Hi On Thu, Oct 20, 2022 at 5:58 PM Marcin Gołaś wrote: > > Hi, > > after uboot update from 2022.07 to 2022.10 SAMSUNG NAND is not recognized > correctly. > I use device with SAMSUNG K9K8G08U0F flash which does not support ONFI and > JEDEC. > Both uboot versions read 8-byte id_data in the same

Re: [PATCH] drivers: pci: pcie_dw_common: add upper-limit to iATU

2022-10-20 Thread Bin Meng
Hi Ben, On Thu, Oct 20, 2022 at 11:51 PM Ben Dooks wrote: > > The 4.6 spec added an upper 32bits to the ATU limit, and since this > driver is already assuming the unrolled feature added in the 4.8 > specification this really should be set. > > This is causing a bug with testing against the QEMU

[PATCH] drivers: pci: pcie_dw_common: add upper-limit to iATU

2022-10-20 Thread Ben Dooks
The 4.6 spec added an upper 32bits to the ATU limit, and since this driver is already assuming the unrolled feature added in the 4.8 specification this really should be set. This is causing a bug with testing against the QEMU model as it defaults the viewports to fully open and not setting this

Re: [PATCH 3/6] net: (actually/better) deal with CVE-2022-{30790, 30552}

2022-10-20 Thread Artur Łącki
I tested these patches with my exploit. At the moment it looks like the vulnerability has been fixed.

[uboot] mtd NAND recognition regression

2022-10-20 Thread Marcin Gołaś
Hi, after uboot update from 2022.07 to 2022.10 SAMSUNG NAND is not recognized correctly. I use device with SAMSUNG K9K8G08U0F flash which does not support ONFI and JEDEC. Both uboot versions read 8-byte id_data in the same way: 0xD3ECC65A9551D3EC. However 2022.07 recognized flash correctly as:

Re: [PATCH 6/6] sunxi: add CherryPi-F1C200s support

2022-10-20 Thread Giulio Benetti
Hi Andre, On 18/10/22 16:01, Andre Przywara wrote: On Fri, 14 Oct 2022 01:04:18 -0400 Jesse Taube wrote: Hi Jesse, Giulio, thanks for having a look and for the testing! You're welcome: Tested-by: Giulio Benetti Best regards -- Giulio Benetti CEO/CTO@Benetti Engineering sas On 10/13/22

Re: [PATCH v4 1/2] mx7ulp: add base SPL support for mx7ulp

2022-10-20 Thread Stefano Babic
Hi Oleksandr, Ricardo, On 05.08.22 20:19, Oleksandr Suvorov wrote: From: Ricardo Salveti Add a base implementation of mx7ulp SPL config header and soc, and changes in makefiles in order to allow building SPL on mx7ulp based devices. Signed-off-by: Ricardo Salveti Co-developed-by: Oleksandr

Re: [PATCH v4 5/5] arm: imx8mp: Initial MSC SM2S iMX8MP support

2022-10-20 Thread Stefano Babic
On 04.10.22 13:07, Martyn Welch wrote: Add support for the MSC SM2S-IMX8PLUS SMARC Module. Tested in conjunction with the MSC SM2-MB-EP1 Mini-ITX Carrier Board. I see at least some issues: - MAINTAINERS file is missing - a lot of symbols are set in include/configs/msc_sm2s_imx8mp.h instead

i2c-gpio: condition is always false

2022-10-20 Thread Sergei Antonov
Hello! Please look at this code from drivers/i2c/i2c-gpio.c: static int i2c_gpio_of_to_plat(struct udevice *dev) { struct i2c_gpio_bus *bus = dev_get_priv(dev); int ret; /* "gpios" is deprecated and replaced by "sda-gpios" + "scl-gpios". */ ret =

Re: [PATCH v14 15/15] FWU: doc: Add documentation for the FWU feature

2022-10-20 Thread Etienne Carriere
Hi Sughosh, For info I successfully tested your v14 series on my boards. (note i did not test case with a power failure in between mdata partition updates, discussed in patch v14 02/15). I'll run another tests round on next v15 to post my Tested-by tag. Br, Etienne On Tue, 18 Oct 2022 at 13:45,

[PATCH] i2c: i2c-gpio: add newline

2022-10-20 Thread Sergei Antonov
Add newline at the end of the printed string. Signed-off-by: Sergei Antonov --- drivers/i2c/i2c-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/i2c-gpio.c b/drivers/i2c/i2c-gpio.c index 1aedad5c8ede..4ed9e9e7cddd 100644 --- a/drivers/i2c/i2c-gpio.c +++

Re: [PATCH v14 14/15] mkeficapsule: Add support for setting OEM flags in capsule header

2022-10-20 Thread Etienne Carriere
On Thu, 20 Oct 2022 at 16:11, Sughosh Ganu wrote: > > On Thu, 20 Oct 2022 at 19:25, Etienne Carriere > wrote: > > > > On Tue, 18 Oct 2022 at 13:44, Sughosh Ganu wrote: > > > > > > Add support for setting OEM flags in the capsule header. As per the > > > UEFI specification, bits 0-15 of the

Re: [PATCH v14 08/15] event: Add an event for main_loop

2022-10-20 Thread Etienne Carriere
On Tue, 18 Oct 2022 at 13:44, Sughosh Ganu wrote: > > Add an event type EVT_MAIN_LOOP that can be used for registering > events that need to be run after the platform has been initialised and > before the main_loop function is called. > > Signed-off-by: Sughosh Ganu > Reviewed-by: Simon Glass >

Re: [PATCH v14 07/15] FWU: STM32MP1: Add support to read boot index from backup register

2022-10-20 Thread Etienne Carriere
On Tue, 18 Oct 2022 at 13:44, Sughosh Ganu wrote: > > The FWU Multi Bank Update feature allows the platform to boot the > firmware images from one of the partitions(banks). The first stage > bootloader(fsbl) passes the value of the boot index, i.e. the bank > from which the firmware images were

Re: [PATCH v14 13/15] mkeficapsule: Add support for generating empty capsules

2022-10-20 Thread Etienne Carriere
On Tue, 18 Oct 2022 at 13:44, Sughosh Ganu wrote: > > The Dependable Boot specification[1] describes the structure of the > firmware accept and revert capsules. These are empty capsules which > are used for signalling the acceptance or rejection of the updated > firmware by the OS. Add support

Re: [PATCH v14 14/15] mkeficapsule: Add support for setting OEM flags in capsule header

2022-10-20 Thread Sughosh Ganu
On Thu, 20 Oct 2022 at 19:25, Etienne Carriere wrote: > > On Tue, 18 Oct 2022 at 13:44, Sughosh Ganu wrote: > > > > Add support for setting OEM flags in the capsule header. As per the > > UEFI specification, bits 0-15 of the flags member of the capsule > > header can be defined per capsule GUID.

Re: [PATCH v14 15/15] FWU: doc: Add documentation for the FWU feature

2022-10-20 Thread Etienne Carriere
On Tue, 18 Oct 2022 at 16:26, Ilias Apalodimas wrote: > > On Tue, Oct 18, 2022 at 05:13:37PM +0530, Sughosh Ganu wrote: > > Add documentation for the FWU Multi Bank Update feature. The document > > describes the steps needed for setting up the platform for the > > feature, as well as steps for

Re: [PATCH v14 14/15] mkeficapsule: Add support for setting OEM flags in capsule header

2022-10-20 Thread Etienne Carriere
On Tue, 18 Oct 2022 at 13:44, Sughosh Ganu wrote: > > Add support for setting OEM flags in the capsule header. As per the > UEFI specification, bits 0-15 of the flags member of the capsule > header can be defined per capsule GUID. > > The oemflags will be used for the FWU Multi Bank update

Re: [PATCH v2] spl: fit: Report fdt error for loading u-boot

2022-10-20 Thread Mark Kettenis
> From: Simon Glass > Date: Wed, 19 Oct 2022 08:15:35 -0600 > > Hi Mark, > > On Wed, 19 Oct 2022 at 08:08, Mark Kettenis wrote: > > > > > From: Simon Glass > > > Date: Wed, 19 Oct 2022 07:18:10 -0600 > > > > > > Hi, > > > > > > On Mon, 17 Oct 2022 at 05:53, Su, Bao Cheng > > > wrote: > > >

[u-boot][PATCH v3 4/4] memory: Add TI GPMC driver

2022-10-20 Thread Roger Quadros
The GPMC is a unified memory controller dedicated for interfacing with external memory devices like - Asynchronous SRAM-like memories and ASICs - Asynchronous, synchronous, and page mode burst NOR flash - NAND flash - Pseudo-SRAM devices This driver will take care of setting up the GPMC based

[u-boot][PATCH v3 3/4] dt/bindings: memory: Add bindings for TI GPMC driver

2022-10-20 Thread Roger Quadros
GPMC stands for General Purpose Memory Controller and it is present on many Texas Instruments SoCs. It supports a number of Asynchronous and Synchronous interfaces and has various settings to configure the bus interface. The DT bindings define all the various GPMC settings. As the GPMC supports

[u-boot][PATCH v3 2/4] scripts: Makefile.spl: Enable memory drivers to be built for SPL

2022-10-20 Thread Roger Quadros
Introduce CONFIG_SPL_MEMORY to allow Memory drivers to be built for SPL. Signed-off-by: Roger Quadros --- common/spl/Kconfig | 7 +++ scripts/Makefile.spl | 1 + 2 files changed, 8 insertions(+) diff --git a/common/spl/Kconfig b/common/spl/Kconfig index 70d97815f0..186131a699 100644 ---

[u-boot][PATCH v3 1/4] dm: memory: Introduce new uclass

2022-10-20 Thread Roger Quadros
Introduce UCLASS_MEMORY for future Memory Controller device drivers. Signed-off-by: Roger Quadros Reviewed-by: Simon Glass --- arch/sandbox/dts/test.dts | 4 drivers/memory/Kconfig | 17 + drivers/memory/Makefile | 2 ++

[u-boot][PATCH v3 0/4] Introduce MEMORY uclass and TI GPMC driver

2022-10-20 Thread Roger Quadros
Hi, This series introduces the MEMORY controller uclass for the drivers that exist in drivers/memory directory. With that, we add the TI GPMC Memory controller driver as the first user of this uclass. The GPMC is a unified memory controller dedicated for interfacing with external memory devices

[PULL] u-boot-riscv/master

2022-10-20 Thread Leo Liang
Hi Tom, The following changes since commit 3724ddf157aab3bd009c1da234b9a1af1621b544: Merge branch '2022-10-18-TI-platform-updates' (2022-10-18 18:13:39 -0400) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-riscv.git for you to fetch changes up to

Re: [u-boot][PATCH v2 2/4] scripts: Makefile.spl: Enable memory drivers to be built for SPL

2022-10-20 Thread Tom Rini
On Thu, Oct 20, 2022 at 03:23:42PM +0300, Roger Quadros wrote: > Hi Tom, > > On 19/10/2022 15:54, Tom Rini wrote: > > On Wed, Oct 19, 2022 at 11:17:35AM +0300, Roger Quadros wrote: > >> > >> > >> On 18/10/2022 20:40, Tom Rini wrote: > >>> On Thu, Oct 06, 2022 at 04:23:58PM +0300, Roger Quadros

Re: [PATCH v14 09/15] FWU: Add boot time checks as highlighted by the FWU specification

2022-10-20 Thread Ilias Apalodimas
Hi Sughosh, > > > + } > > > + > > > + return 0; > > > +} > > > + > > > +static int fwu_trial_state_check(void) > > > +{ > > > + int ret; > > > + struct udevice *dev; > > > + efi_status_t status; > > > + efi_uintn_t var_size; > > > + u16 trial_state_ctr; > > > +

Re: [u-boot][PATCH v2 2/4] scripts: Makefile.spl: Enable memory drivers to be built for SPL

2022-10-20 Thread Roger Quadros
Hi Tom, On 19/10/2022 15:54, Tom Rini wrote: > On Wed, Oct 19, 2022 at 11:17:35AM +0300, Roger Quadros wrote: >> >> >> On 18/10/2022 20:40, Tom Rini wrote: >>> On Thu, Oct 06, 2022 at 04:23:58PM +0300, Roger Quadros wrote: We will need ti-gpmc driver for SPL. Allow memory drivers do be

Re: [PATCH v17 1/2] net: Add TCP protocol

2022-10-20 Thread Duncan Hare
I used a server on Linux for testing. Sent from Yahoo Mail on Android On Tue, Oct 18, 2022 at 9:59, Simon Glass wrote: Hi PaulLiu, On Mon, 17 Oct 2022 at 01:03, PaulLiu wrote: > > Hi Simon, > > I think it is a bit hard for me to test it right now. It seems that we need > to setup a fake

Re: [PATCH] spi: spi-mem: ease checks in dtr_supports_op()

2022-10-20 Thread Dhruva Gole
Forgot to add in CC, + Jagan Teki (maintainer:SPI) On 20/10/22 14:04, Dhruva Gole wrote: Remove the extra conditions that cause some cases to fail prematurely like if the data number of bytes is odd. The controller can handle odd number of bytes data read in DTR Mode. Don't fail supports op

[PATCH] spi: spi-mem: ease checks in dtr_supports_op()

2022-10-20 Thread Dhruva Gole
Remove the extra conditions that cause some cases to fail prematurely like if the data number of bytes is odd. The controller can handle odd number of bytes data read in DTR Mode. Don't fail supports op for this condition. Signed-off-by: Dhruva Gole --- For a deeper context, refer to a cover

Re: [PATCH v14 02/15] FWU: Add FWU metadata structure and driver for accessing metadata

2022-10-20 Thread Ilias Apalodimas
Hi Sughosh, Etienne [...] > > > + * Check if the platform has defined its own > > > + * function to check the metadata partitions' > > > + * validity. If so, that takes precedence. > > > + */ > > > + ret = fwu_mdata_check(dev); > > > > Isn't this a bit dangerous? Let's

  1   2   >