Re: [PULL next] u-boot-at91-2023.04-a

2023-01-06 Thread Tom Rini
On Thu, Jan 05, 2023 at 09:54:12AM +, eugen.hris...@microchip.com wrote: > Hello Tom, > > Please pull tag u-boot-at91-2023.04-a , the first set of at91 features > for the next cycle 2023.04. > > This feature set includes the new DM-based NAND flash driver (old non-DM > driver is still

Re: [regression] 2023.01 breaks u-boot-initial-env for aarch64

2023-01-06 Thread Sean Anderson
On 1/6/23 19:44, Otavio Salvador wrote: Hello, When using v2023.01-rc4-49-g582e3c9fb23 for aarch64 (technically imx8mm-lpddr4-evk) I get following error: | /bin/false) | cat u-boot-nodtb.bin dts/dt.dtb > u-boot-dtb.bin | cp u-boot-dtb.bin u-boot.bin | aarch64-oel-linux-objcopy

[PATCH] net: ipv6: Fix IPv6 netmask parsing

2023-01-06 Thread seanedmond
From: Sean Edmond It should be possible to specify a netmask when setting a static IPv6 address. For example: setenv ip6addr 2001:cafe:cafe:cafe::100/64 The net_prefix_length and net_ip6 should be updated properly. Signed-off-by: Sean Edmond --- net/net6.c | 9 ++--- 1 file changed, 6

[regression] 2023.01 breaks u-boot-initial-env for aarch64

2023-01-06 Thread Otavio Salvador
Hello, When using v2023.01-rc4-49-g582e3c9fb23 for aarch64 (technically imx8mm-lpddr4-evk) I get following error: | /bin/false) | cat u-boot-nodtb.bin dts/dt.dtb > u-boot-dtb.bin | cp u-boot-dtb.bin u-boot.bin | aarch64-oel-linux-objcopy --dump-section

Re: [PATCH v3 6/7] video: Only dcache flush damaged lines

2023-01-06 Thread Simon Glass
Hi, On Tue, 3 Jan 2023 at 13:25, Alexander Graf wrote: > > > On 30.12.22 22:12, Heinrich Schuchardt wrote: > > On 12/30/22 20:58, Alexander Graf wrote: > >> Now that we have a damage area tells us which parts of the frame buffer > >> actually need updating, let's only dcache flush those on

Re: [PATCH v2] cmd: mmc: Expand bkops handling

2023-01-06 Thread Simon Glass
On Thu, 5 Jan 2023 at 07:19, Marek Vasut wrote: > > Add more capable "bkops" command which allows enabling and disabling both > manual and automatic bkops. The existing 'mmc bkops-enable' subcommand is > poorly named to cover all the possibilities, hence the new-ish subcommand. > Note that both

Re: [PATCH v4 3/9] vidconsole: Add damage notifications to all vidconsole drivers

2023-01-06 Thread Simon Glass
On Tue, 3 Jan 2023 at 14:50, Alexander Graf wrote: > > Now that we have a damage tracking API, let's populate damage done by > vidconsole drivers. We try to declare as little memory as damaged as > possible, with the exception of rotated screens that I couldn't get my > head wrapped around. On

Re: [PATCH v4 7/9] video: Use VIDEO_DAMAGE for VIDEO_COPY

2023-01-06 Thread Simon Glass
Hi Alexander, On Tue, 3 Jan 2023 at 14:50, Alexander Graf wrote: > > CONFIG_VIDEO_COPY implemented a range based copying mechanism: If we range-based > print a single character, it will always copy the full range of bytes > from the top left corner of the character to the lower right onto the

Re: [PATCH v3 02/25] cli: Move readline character-processing to a state machine

2023-01-06 Thread Simon Glass
Hi Heinrich, On Fri, 6 Jan 2023 at 08:50, Heinrich Schuchardt wrote: > > On 1/6/23 15:52, Simon Glass wrote: > > The current cread_line() function is very long. It handles the escape > > processing inline. The menu command does similar processing but at the > > character level, so there is some

Re: [PATCH v4 4/9] video: Add damage notification on bmp display

2023-01-06 Thread Simon Glass
On Tue, 3 Jan 2023 at 14:50, Alexander Graf wrote: > > Let's report the video damage when we draw a bitmap on the screen. This > way we can later lazily flush only relevant regions to hardware. > > Signed-off-by: Alexander Graf > Reported-by: Da Xue > --- > drivers/video/video_bmp.c | 2 ++ >

Re: [PATCH v4 8/9] video: Always compile cache flushing code

2023-01-06 Thread Simon Glass
On Tue, 3 Jan 2023 at 14:50, Alexander Graf wrote: > > The dcache flushing code path was conditional on ARM && !DCACHE config > options. However, dcaches exist on other platforms as well and may need > clearing if their driver requires it. > > Simplify the compile logic and always enable the

Re: [PATCH v4 0/9] Add video damage tracking

2023-01-06 Thread Simon Glass
Hi Alex, On Tue, 3 Jan 2023 at 14:50, Alexander Graf wrote: > > This patch set speeds up graphics output on ARM by a factor of 60x. > > On most ARM SBCs, we keep the frame buffer in DRAM and map it as cached, > but need it accessible by the display controller which reads directly > from a later

Re: [PATCH u-boot 2/2] Makefile: Build working u-boot-dtb.bin target also for mpc85xx

2023-01-06 Thread Simon Glass
Hi Pali, On Tue, 3 Jan 2023 at 10:05, Pali Rohár wrote: > > On Tuesday 03 January 2023 11:02:17 Simon Glass wrote: > > > > > > 3. Add a common binman image for u-boot.bin (used by every board) > > > > > > > > > > It should be u-boot-dtb.bin (not u-boot.bin). At least this is the > > > > >

Re: [PATCH v8 09/13] rockchip: Use multiple-images for rk3399

2023-01-06 Thread Simon Glass
Hi Quentin, On Thu, 5 Jan 2023 at 02:47, Quentin Schulz wrote: > > Hi Simon, > > On 1/4/23 21:01, Simon Glass wrote: > > Hi Quentin, > > > > On Mon, 2 Jan 2023 at 09:42, Quentin Schulz > > wrote: > >> > >> Hi Simon, > >> > >> On 12/22/22 00:07, Simon Glass wrote: > >>> Enable multiple-images

Re: [PATCH v4 9/9] video: Enable VIDEO_DAMAGE for drivers that need it

2023-01-06 Thread Simon Glass
Hi Alex, On Tue, 3 Jan 2023 at 14:50, Alexander Graf wrote: > > Some drivers call video_set_flush_dcache() to indicate that they want to > have the dcache flushed for the frame buffer. These drivers benefit from > our new video damage control, because we can reduce the amount of memory > that

Re: [PATCH] common: bouncebuf: Use dma-mapping for cache ops

2023-01-06 Thread Simon Glass
On Fri, 6 Jan 2023 at 11:02, Andrew Davis wrote: > > This matches how this would be done in Linux and these functions > do the alignment for us which makes the code look cleaner. > > Signed-off-by: Andrew Davis > --- > common/bouncebuf.c | 13 +++-- > 1 file changed, 7 insertions(+), 6

Re: [PATCH v4 1/9] dm: video: Add damage tracking API

2023-01-06 Thread Simon Glass
Hi Alex, On Tue, 3 Jan 2023 at 14:50, Alexander Graf wrote: > > We are going to introduce image damage tracking to fasten up screen > refresh on large displays. This patch adds damage tracking for up to > one rectangle of the screen which is typically enough to hold blt or > text print updates.

Re: [PATCH v4 2/9] dm: video: Add damage notification on display clear

2023-01-06 Thread Simon Glass
On Tue, 3 Jan 2023 at 14:50, Alexander Graf wrote: > > Let's report the video damage when we clear the screen. This > way we can later lazily flush only relevant regions to hardware. > > Signed-off-by: Alexander Graf > Reported-by: Da Xue > --- > drivers/video/video-uclass.c | 2 ++ > 1 file

Re: [PATCH v3 03/25] bootmenu: Add a few comments

2023-01-06 Thread Simon Glass
Hi Heinrich, On Fri, 6 Jan 2023 at 09:53, Heinrich Schuchardt wrote: > > On 1/6/23 15:52, Simon Glass wrote: > > The behaviour of these two functions is completely undocumented. Add some > > notes so the poor, suffering dev can figure out what is going on. > > > > Signed-off-by: Simon Glass > >

Re: [PATCH v2 1/2] lib: zstd: update to latest Linux zstd 1.5.2

2023-01-06 Thread Maier, Brandon L Collins
> From: Tom Rini > On Mon, Jan 02, 2023 at 04:02:06PM +, Maier, Brandon L > > > > I understand Linux replaced their custom zstd code with the Facebook zstd > code, so the changes are widespread. The new zstd does support many > optional performance features as documented in zstd's

Re: [PATCH v2 3/3] lmb: consider EFI memory map

2023-01-06 Thread Vagrant Cascadian
On 2023-01-05, Heinrich Schuchardt wrote: > Add reservations for all EFI memory areas that are not > EFI_CONVENTIONAL_MEMORY. > > Signed-off-by: Heinrich Schuchardt Tested on odroid-c2, fixes booting from extlinux.conf and boot.scr using booti, and still works using EFI boot as well. Thanks!

Re: [PATCH v2 2/3] efi_loader: carve out efi_get_memory_map_alloc()

2023-01-06 Thread Vagrant Cascadian
On 2023-01-05, Heinrich Schuchardt wrote: > Carve out code from efidebug command used to read the memory map. > > Signed-off-by: Heinrich Schuchardt Tested on odroid-c2, fixes booting from extlinux.conf and boot.scr using booti, and still works using EFI boot as well. Thanks! Tested-by:

Re: linksys wrt1900acs v2 boot problem

2023-01-06 Thread Tony Dinh
Hi all, On Fri, Jan 6, 2023 at 9:35 AM Pali Rohár wrote: > > Hello Dilyan! > > On Tuesday 28 September 2021 22:01:40 Dilyan Lazarov wrote: > > Hi, > > I have a problem with my linksys wrt1900acs. > > My main question is this a hardware problem or software problem? > > Is it possible to address?

Re: [PATCH] Revert "common/memsize.c: Fix get_effective_memsize() to check for overflow"

2023-01-06 Thread Tom Rini
On Fri, Jan 06, 2023 at 11:09:30PM +0100, Pali Rohár wrote: > On Friday 06 January 2023 16:45:41 Tom Rini wrote: > > On Fri, Jan 06, 2023 at 04:14:08PM -0500, Tom Rini wrote: > > > On Fri, Jan 06, 2023 at 09:22:56PM +0100, Pali Rohár wrote: > > > > On Friday 06 January 2023 12:25:24 Tom Rini

Pull request efi-2023-01-rc5-4

2023-01-06 Thread Heinrich Schuchardt
The following changes since commit 9ddcdcc03cc6f0f46895604c589af17fdbdfe8b7: Merge tag 'u-boot-stm32-20230106' of https://gitlab.denx.de/u-boot/custodians/u-boot-stm (2023-01-06 08:16:15 -0500) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-efi.git

Re: [PATCH] Revert "common/memsize.c: Fix get_effective_memsize() to check for overflow"

2023-01-06 Thread Pali Rohár
On Friday 06 January 2023 16:45:41 Tom Rini wrote: > On Fri, Jan 06, 2023 at 04:14:08PM -0500, Tom Rini wrote: > > On Fri, Jan 06, 2023 at 09:22:56PM +0100, Pali Rohár wrote: > > > On Friday 06 January 2023 12:25:24 Tom Rini wrote: > > > > On Fri, Jan 06, 2023 at 05:45:43PM +0100, Pali Rohár

Re: kwboot : bug when board stops acking

2023-01-06 Thread Tony Dinh
Hello, On Fri, Jan 6, 2023 at 9:52 AM Pali Rohár wrote: > > Hello Stephane! > > On Wednesday 08 January 2020 15:21:12 SC wrote: > > Hi list, > > > > I think there's a bug in kwboot. > > I have a faulty board that stops acking xmodem frames after a certain > > number of packets and kwboot > >

Re: [PATCH] Revert "common/memsize.c: Fix get_effective_memsize() to check for overflow"

2023-01-06 Thread Tom Rini
On Fri, Jan 06, 2023 at 04:14:08PM -0500, Tom Rini wrote: > On Fri, Jan 06, 2023 at 09:22:56PM +0100, Pali Rohár wrote: > > On Friday 06 January 2023 12:25:24 Tom Rini wrote: > > > On Fri, Jan 06, 2023 at 05:45:43PM +0100, Pali Rohár wrote: > > > > On Friday 06 January 2023 10:51:43 Tom Rini

Re: [PATCH] Revert "common/memsize.c: Fix get_effective_memsize() to check for overflow"

2023-01-06 Thread Tom Rini
On Fri, Jan 06, 2023 at 09:22:56PM +0100, Pali Rohár wrote: > On Friday 06 January 2023 12:25:24 Tom Rini wrote: > > On Fri, Jan 06, 2023 at 05:45:43PM +0100, Pali Rohár wrote: > > > On Friday 06 January 2023 10:51:43 Tom Rini wrote: > > > > This reverts commit

Re: [PATCH] Revert "common/memsize.c: Fix get_effective_memsize() to check for overflow"

2023-01-06 Thread Fabio Estevam
On Fri, Jan 6, 2023 at 12:51 PM Tom Rini wrote: > > This reverts commit 777706bcfe08c284aed06886db7d482af3f8. > > The changes to this generic function, which is intended to help with > 32bit platforms with large amounts of memory has unintended side effects > (which in turn lead to boot

Re: [PATCH] Revert "common/memsize.c: Fix get_effective_memsize() to check for overflow"

2023-01-06 Thread Pali Rohár
On Friday 06 January 2023 12:25:24 Tom Rini wrote: > On Fri, Jan 06, 2023 at 05:45:43PM +0100, Pali Rohár wrote: > > On Friday 06 January 2023 10:51:43 Tom Rini wrote: > > > This reverts commit 777706bcfe08c284aed06886db7d482af3f8. > > > > > > The changes to this generic function, which is

Re: [PATCH 0/4] Enable gigadevice and add new part #s

2023-01-06 Thread Vlim
Hi, Michal, On 1/5/23 20:47, Vlim wrote: >> Regarding the location of the entry, I believe you want me to add the entry >> in >> the alphabetical order? > > Not really. I want to you follow Kconfig layout which is what make > savedefconfig > && cp defconfig configs/ is for. > > Can you be

[PATCH v2] ARM: omap3: evm: Name this directory omap3evm

2023-01-06 Thread Andrew Davis
Before this was named just evm, which doesn't match the naming of the other TI board file directory and makes it look like a common directory for evms. Name this omap3evm. Signed-off-by: Andrew Davis --- Changes from v1: - Call dir omap3evm instead of omap3 arch/arm/mach-omap2/omap3/Kconfig

Re: Pull request for u-boot-nand-20230104

2023-01-06 Thread Tom Rini
On Thu, Jan 05, 2023 at 09:10:55AM +0100, Dario Binacchi wrote: > Hi Tom, > > The following changes since commit a95410696d21d38b629c61a09c100197c5fc533a: > > Merge branch '2023-01-02-platform-updates' into next (2023-01-02 > 18:07:41 -0500) > > are available in the Git repository at: > >

Re: [PATCH] ARM: omap3: evm: Name this directory omap3

2023-01-06 Thread Tom Rini
On Fri, Jan 06, 2023 at 12:13:12PM -0600, Andrew Davis wrote: > On 10/7/22 10:21 PM, Derald Woods wrote: > > On Fri, Oct 07, 2022 at 12:33:14PM -0500, Andrew Davis wrote: > > > Before this was named just evm, which doesn't match the naming > > > of the other TI board file directory and makes it

Re: [PATCH] ARM: omap3: evm: Name this directory omap3

2023-01-06 Thread Andrew Davis
On 10/7/22 10:21 PM, Derald Woods wrote: On Fri, Oct 07, 2022 at 12:33:14PM -0500, Andrew Davis wrote: Before this was named just evm, which doesn't match the naming of the other TI board file directory and makes it look like a common directory for evms. Name this omap3. Signed-off-by: Andrew

[PATCH] common: bouncebuf: Use dma-mapping for cache ops

2023-01-06 Thread Andrew Davis
This matches how this would be done in Linux and these functions do the alignment for us which makes the code look cleaner. Signed-off-by: Andrew Davis --- common/bouncebuf.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/common/bouncebuf.c

Re: kwboot : bug when board stops acking

2023-01-06 Thread Pali Rohár
Hello Stephane! On Wednesday 08 January 2020 15:21:12 SC wrote: > Hi list, > > I think there's a bug in kwboot. > I have a faulty board that stops acking xmodem frames after a certain number > of packets and kwboot > instead of exiting continues to send frames up to 100%. > With the one second

Re: Netgear RN102 U-Boot Nand Driver Modification

2023-01-06 Thread Pali Rohár
Hello Abdus! On Thursday 24 September 2020 17:26:49 Abdus Rainey wrote: > I have recently modded a Netgear RN102 NAND flash from 128 MB to 4096 MB > (Samsung k9gbg08u0a) but i have a problem with NAND initialization. > I can boot with kwboot which is unique for Armada CPU's. > > Here is my log

Re: linksys wrt1900acs v2 boot problem

2023-01-06 Thread Pali Rohár
Hello Dilyan! On Tuesday 28 September 2021 22:01:40 Dilyan Lazarov wrote: > Hi, > I have a problem with my linksys wrt1900acs. > My main question is this a hardware problem or software problem? > Is it possible to address? This looks like DDR3 training SW issue problem. Marek worked on in and

Re: [PATCH] Revert "common/memsize.c: Fix get_effective_memsize() to check for overflow"

2023-01-06 Thread Tom Rini
On Fri, Jan 06, 2023 at 05:45:43PM +0100, Pali Rohár wrote: > On Friday 06 January 2023 10:51:43 Tom Rini wrote: > > This reverts commit 777706bcfe08c284aed06886db7d482af3f8. > > > > The changes to this generic function, which is intended to help with > > 32bit platforms with large amounts of

Re: [PATCH] arm: stm32mp: Fix board_get_usable_ram_top() again

2023-01-06 Thread Patrick DELAUNAY
Hi Marek, On 1/5/23 02:22, Marek Vasut wrote: Do not access gd->ram_size and assume this is actual valid RAM size. Since commit 777706b ("common/memsize.c: Fix get_effective_memsize() to check for overflow") the RAM size may be less than gd->ram_size , call get_effective_memsize() to get

Re: [PULL] Pull request for u-boot master / v2023.01 = u-boot-stm32-20230106

2023-01-06 Thread Tom Rini
On Fri, Jan 06, 2023 at 11:48:54AM +0100, Patrick DELAUNAY wrote: > Hi Tom, > > Please pull the STM32 related fixes for u-boot/master, v2023.01: > u-boot-stm32-20230106 > > > - stm32mp: Fix board_get_usable_ram_top(): workaround to avoid issue after > the > >

Re: [PATCH] arm: rmobile: rzg2_beacon: Enable alternative Ethernet PHY

2023-01-06 Thread Tom Rini
On Wed, Jan 04, 2023 at 12:05:43PM -0600, Adam Ford wrote: > Due to the part shortage, the AR8031 PHY was replaced with a > Micrel KSZ9131. Enabling both config options keeps backward > compatibility with either platform, and both appear to be > auto-detected. > > Signed-off-by: Adam Ford >

Re: [PATCH] arm: dts: rz-g2-beacon-u-boot: Fix QSPI Regression

2023-01-06 Thread Tom Rini
On Wed, Jan 04, 2023 at 09:53:09AM -0600, Adam Ford wrote: > The QSPI is accessed via the RPC-IF, but the compatible flags > previously used a different name. This compatibel name was changed > which broke the ability to access the QSPI. Fix this by removing > the custom naming reference. > >

Re: [PATCH] pylibfdt: Fix disable version normalization

2023-01-06 Thread Tom Rini
On Wed, Jan 04, 2023 at 03:43:33PM +0100, Philippe Schenker wrote: > From: Philippe Schenker > > On Arch Linux based systems python setuptools does not contain > "setuptools.extern" hence it is failing with the following > error-message: > " > ModuleNotFoundError: No module named

Re: [PATCH] rockchip: Fix the broken Video out for rk3288 boards

2023-01-06 Thread Tom Rini
On Mon, Jan 02, 2023 at 11:53:45PM +0530, Jagan Teki wrote: > Video out on RK3288 boards has been broken since from few > releases due to the adding of reset support on vop but > missed enabling DM_RESET on associated boards. > > This patch fixes those RK3288 boards. > > Cc: Simon Glass > Cc:

Re: [PATCH] imx7d-pico: Fix the name of the u-boot.dtsi file

2023-01-06 Thread Tom Rini
On Sat, Dec 31, 2022 at 01:25:14PM -0300, Fabio Estevam wrote: > Since commit 2f96d4dd95f8 ("imx7s/d: synchronise device trees with linux") > the imx7d-pico board no longer boots. > > The reason is that prior to the above commit there was an explicit > inclusion of

Re: [PATCH u-boot] powerpc/mpc85xx: socrates: Re-enable building u-boot-socrates.bin

2023-01-06 Thread Tom Rini
On Wed, Dec 28, 2022 at 07:18:39PM +0100, Pali Rohár wrote: > U-Boot build system builds final U-Boot binary for socrates board in custom > file u-boot-socrates.bin (instead of standard u-boot.bin). Output target > file u-boot-socrates.bin is generated by binman as defined in board binman >

Re: [PATCH] Revert "Revert "cmd: pxe_utils: Check fdtcontroladdr in label_boot""

2023-01-06 Thread Tom Rini
On Sat, Dec 17, 2022 at 06:41:13PM +0100, Marek Vasut wrote: > This reverts commit ed6251187afabf811a5fd49a44ebd61c53c7b378. > > Superseded by "cmd: pxe_utils: Limit fdtcontroladdr usage to non-fitImage" > which is less heavy-handed approach and retains part of the original > behavior for

Re: [PATCH v2] cmd: pxe_utils: Limit fdtcontroladdr usage to non-fitImage

2023-01-06 Thread Tom Rini
On Wed, Dec 14, 2022 at 07:45:18AM +0100, Marek Vasut wrote: > Commit d5ba6188dfb ("cmd: pxe_utils: Check fdtcontroladdr in label_boot") > forces '$fdtcontroladdr' DT address as a third parameter of bootm command > even if the PXE transfer pulls in a fitImage which contains configuration > node

Re: [PATCH] i2c: uniphier-f: correct error recovery

2023-01-06 Thread Tom Rini
On Fri, Dec 09, 2022 at 08:38:27PM +0900, Dai Okamura wrote: > The uniphier i2c block can recognize some handshake errors. > But driver handles all error detections as no error if no timeout. > So this makes unrecoverable state. > > This replaces the return values with the right ones to tell the

Re: [PATCH] Revert "common/memsize.c: Fix get_effective_memsize() to check for overflow"

2023-01-06 Thread Pali Rohár
On Friday 06 January 2023 10:51:43 Tom Rini wrote: > This reverts commit 777706bcfe08c284aed06886db7d482af3f8. > > The changes to this generic function, which is intended to help with > 32bit platforms with large amounts of memory has unintended side effects > (which in turn lead to boot

Re: [PATCH v2] usb: gadget: fastboot: detach usb just before rebooting

2023-01-06 Thread Mattijs Korpershoek
On Thu, Jan 05, 2023 at 14:25, Dario Binacchi wrote: > Hi Mattijs, > > On Thu, Jan 5, 2023 at 12:03 PM Mattijs Korpershoek > wrote: >> >> On Thu, Jan 05, 2023 at 10:10, Dario Binacchi >> wrote: >> >> > Hi Mattijs, >> > >> > On Thu, Jan 5, 2023 at 10:06 AM Mattijs Korpershoek >> > wrote: >>

Re: [PATCH] arm: stm32mp: Fix board_get_usable_ram_top() again

2023-01-06 Thread Pali Rohar
On Friday 06 January 2023 10:13:34 Patrick DELAUNAY wrote: > Hi, > > On 1/5/23 20:25, Pali Rohar wrote: > > Ok, so it is working... > > > > On Thursday 05 January 2023 19:31:19 Patrick DELAUNAY wrote: > > > I tested on STM32MP157C-EV1 on my side... > > > > > > with 1GiB mermory size > > > > >

Re: [PATCH v3 03/25] bootmenu: Add a few comments

2023-01-06 Thread Heinrich Schuchardt
On 1/6/23 15:52, Simon Glass wrote: The behaviour of these two functions is completely undocumented. Add some notes so the poor, suffering dev can figure out what is going on. Signed-off-by: Simon Glass --- (no changes since v1) include/menu.h | 42

[PATCH] Revert "common/memsize.c: Fix get_effective_memsize() to check for overflow"

2023-01-06 Thread Tom Rini
This reverts commit 777706bcfe08c284aed06886db7d482af3f8. The changes to this generic function, which is intended to help with 32bit platforms with large amounts of memory has unintended side effects (which in turn lead to boot failures) on other platforms which were previously functional.

Re: [PATCH v3 02/25] cli: Move readline character-processing to a state machine

2023-01-06 Thread Heinrich Schuchardt
On 1/6/23 15:52, Simon Glass wrote: The current cread_line() function is very long. It handles the escape processing inline. The menu command does similar processing but at the character level, so there is some duplication. Split the character processing into a new function cli_ch_process()

Re: [PATCH 1/2] efi_loader: refine set_keyboard_layout() status

2023-01-06 Thread Heinrich Schuchardt
On 1/6/23 10:46, Vincent Stehlé wrote: As per the EFI specification, the HII database protocol function set_keyboard_layout() must return EFI_INVALID_PARAMETER when it is called with a NULL key_guid argument. Modify the function accordingly to improve conformance. Signed-off-by: Vincent Stehlé

[PATCH v3 13/25] video: Fix unchnaged typo

2023-01-06 Thread Simon Glass
Fix this typo in the header file. Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt --- (no changes since v1) include/video.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/video.h b/include/video.h index 43f2e2c02f0..3f67a93bc93 100644 ---

Re: [PATCH] arm: stm32mp: Fix board_get_usable_ram_top() again

2023-01-06 Thread Marek Vasut
On 1/6/23 10:13, Patrick DELAUNAY wrote: Hi, Hi, For me: get_effective_memsize() must return the effective size of the DDR and NOT -4KiB to avoid side effects in other part of the code (LMB for example) I think today we need to revert your patch. I agree it would be good to revert

[PATCH v3 04/25] menu: Rename KEY_... to BKEY_...

2023-01-06 Thread Simon Glass
This enum values conflict with linux/input.h so rename them. Signed-off-by: Simon Glass --- (no changes since v1) cmd/bootmenu.c | 10 +- cmd/eficonfig.c | 26 +- common/menu.c | 34 +- include/menu.h | 32

[PATCH v3 02/25] cli: Move readline character-processing to a state machine

2023-01-06 Thread Simon Glass
The current cread_line() function is very long. It handles the escape processing inline. The menu command does similar processing but at the character level, so there is some duplication. Split the character processing into a new function cli_ch_process() which processes individual characters and

[PATCH v3 08/25] menu: Make use of CLI character processing

2023-01-06 Thread Simon Glass
Avoid duplicating some of the escape-sequence processing here and use the CLI function instead. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Rebase to master cmd/bootmenu.c | 9 +++-- cmd/eficonfig.c| 12 -- common/cli_getch.c | 12 -- common/menu.c

[PATCH v3 23/25] bootstd: Add a test for the bootstd menu

2023-01-06 Thread Simon Glass
Add a test which checks that two operating systems can be displayed in a menu, allowing one to be selected. Enable a few things on snow so that the unit tests build. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Fix 'touse' typo - Fix pylint warning in mkdir_cond()

[PATCH v3 20/25] expo: Add support for scene menus

2023-01-06 Thread Simon Glass
A menu is a key part of the expo design. It consists of a number of items which the user can select from. Add the initial implementation of this. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Drop the _add suffix on expo creation function - Put strings in a separate

[PATCH v3 25/25] expo: Add documentation

2023-01-06 Thread Simon Glass
Add some documentation for the expo feature. Signed-off-by: Simon Glass --- Changes in v3: - Rebase to master Changes in v2: - Update for new API doc/develop/expo.rst | 188 ++ doc/develop/index.rst | 1 + 2 files changed, 189 insertions(+) create

[PATCH v3 21/25] expo: Add basic tests

2023-01-06 Thread Simon Glass
Add some tests for the expo, including setting up and rendering an expo. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Drop the _add suffix on expo creation function - Put strings in a separate structure referenced by ID test/boot/Makefile | 2 + test/boot/expo.c

[PATCH v3 24/25] bootstd: Support setting a theme for the menu

2023-01-06 Thread Simon Glass
Allow a theme to be set. For now this is very simple, just a default font size to use for all elements. Signed-off-by: Simon Glass --- (no changes since v1) boot/bootflow_menu.c | 43 ++ boot/bootstd-uclass.c | 2 ++ include/bootflow.h| 10 ++ include/bootstd.h

[PATCH v3 22/25] bootstd: Support creating a boot menu

2023-01-06 Thread Simon Glass
Create an expo to handle the boot menu. For now this is quite simple, with just a header, some menu items and a pointer to show the current one. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Rebase to master boot/Makefile| 1 + boot/bootflow_internal.h |

[PATCH v3 19/25] expo: Add support for scenes

2023-01-06 Thread Simon Glass
A scene is a single screen within an expo. It is possible to move between scenes but only one can be displayed at once. Add a basic implementation. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Drop the _add suffix on expo creation function - Put strings in a separate

[PATCH v3 18/25] expo: Add basic implementation

2023-01-06 Thread Simon Glass
An expo is a way of presenting and collecting information from the user. It consists of a collection of 'scenes' of which only one is presented at a time. An expo is typically used to show a boot menu and allow settings to be changed. One created, the same expo can be automatically presented in

[PATCH v3 16/25] bootstd: Allow reading a logo for the OS

2023-01-06 Thread Simon Glass
Some operating systems provide a logo in bmp format. Read this in if present so it can be displayed in the menu. Signed-off-by: Simon Glass --- (no changes since v1) boot/bootmeth-uclass.c | 69 -- boot/bootmeth_script.c | 4 +++ cmd/bootflow.c

[PATCH v3 17/25] menu: Factor out menu-keypress decoding

2023-01-06 Thread Simon Glass
Move this code into a separate function so that it can be used in the new VBE menu. Signed-off-by: Simon Glass --- (no changes since v1) common/menu.c | 48 ++-- include/menu.h | 10 ++ 2 files changed, 40 insertions(+), 18 deletions(-)

[PATCH v3 14/25] video: Add font functions to the vidconsole API

2023-01-06 Thread Simon Glass
Support for fonts currently depends on the type of vidconsole in use. Add two new methods to enumerate fonts and to set the font. Fix a few other method comments while we are here. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Rename vidconsole_get_font() to

[PATCH v3 15/25] bootstd: Read the Operating System name for distro/scripts

2023-01-06 Thread Simon Glass
Add the concept of an OS name to the bootflow. This typically includes the OS name, version and kernel version. Implement this for the distro and script bootmeths so that it works with Armbian and older version of Fedora. Signed-off-by: Simon Glass --- (no changes since v1) boot/bootflow.c

[PATCH v3 12/25] video: truetype: Rename the metrics function

2023-01-06 Thread Simon Glass
This should really have a 'truetype' prefix. Fix it. Signed-off-by: Simon Glass --- (no changes since v1) drivers/video/console_truetype.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/video/console_truetype.c b/drivers/video/console_truetype.c index

[PATCH v3 11/25] video: Enable VIDEO_ANSI by default only with EFI

2023-01-06 Thread Simon Glass
This is not generally needed unless EFI_LOADER is used. Adjust the default setting to reduce the size of the U-Boot build. Signed-off-by: Simon Glass --- (no changes since v1) drivers/video/Kconfig | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

[PATCH v3 10/25] image: Move common image code to image_board and command

2023-01-06 Thread Simon Glass
We should use the cmd/ directory for commands rather than for common code used elsewhere in U-Boot. Move the common 'source' code into image-board.c to achieve this. The image_source_script() function needs to call run_command_list() so seems to belong better in the command library. Move and

[PATCH v3 09/25] image: Add a function to find a script in an image

2023-01-06 Thread Simon Glass
Split this functionality out of the 'source' command so it can be used from another place. For now leave it where it is, but a future patch will move it out of cmd/ Signed-off-by: Simon Glass --- (no changes since v1) cmd/source.c| 173 ++--

[PATCH v3 07/25] menu: Use a switch statement

2023-01-06 Thread Simon Glass
Convert the long line of if() statements to a switch() since this makes better use of the C language. Signed-off-by: Simon Glass --- (no changes since v1) common/menu.c | 31 --- 1 file changed, 20 insertions(+), 11 deletions(-) diff --git a/common/menu.c

[PATCH v3 06/25] menu: Update bootmenu_loop() to return the code

2023-01-06 Thread Simon Glass
Use the return value to save having to pass around a pointer. This also resolves any ambiguity about what *key contains when the function is called. Signed-off-by: Simon Glass --- (no changes since v1) cmd/bootmenu.c | 2 +- cmd/eficonfig.c | 4 ++-- common/menu.c | 30

[PATCH v3 05/25] menu: Update bootmenu_autoboot_loop() to return the code

2023-01-06 Thread Simon Glass
Use the return value to save having to pass around a pointer. This also resolves any ambiguity about what *key contains when the function is called. Signed-off-by: Simon Glass --- (no changes since v1) cmd/bootmenu.c | 2 +- common/menu.c | 16 +--- include/menu.h | 7 +++

[PATCH v3 03/25] bootmenu: Add a few comments

2023-01-06 Thread Simon Glass
The behaviour of these two functions is completely undocumented. Add some notes so the poor, suffering dev can figure out what is going on. Signed-off-by: Simon Glass --- (no changes since v1) include/menu.h | 42 ++ 1 file changed, 42 insertions(+)

[PATCH v3 01/25] sandbox: Enable mmc command and legacy images

2023-01-06 Thread Simon Glass
The mmc command is useful for testing mmc disk images in sandbox, so enable it. We also need to enable legacy images so that we can run tests which use them. Disable it for a few avb tests since MMC is not implemented there yet. Signed-off-by: Simon Glass --- (no changes since v1)

[PATCH v3 00/25] bootstd: Add a boot menu

2023-01-06 Thread Simon Glass
So far standard boot lacks a boot menu, although it is possible to create a rudimentary one using the existing 'bootmenu' command. Even then, this text-based menu offer only basic functionality and does not take full advantage of the displays which are common on many devices. This series

Re: [PATCH] fastboot: remove #ifdef CONFIG when it is possible

2023-01-06 Thread Tom Rini
On Thu, Jan 05, 2023 at 12:37:58PM +0100, Patrick DELAUNAY wrote: > Hi Tom, > > On 1/3/23 21:35, Tom Rini wrote: > > On Thu, Dec 15, 2022 at 10:15:50AM +0100, Patrick Delaunay wrote: > > > Much of the fastboot code predates the introduction of Kconfig and > > > has quite a few #ifdefs in it which

Re: Please pull u-boot-dm/next

2023-01-06 Thread Tom Rini
On Thu, Jan 05, 2023 at 09:40:20PM -0600, Simon Glass wrote: > Hi Tom, > > This is for the -next branch > > > https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/14617 > > > The following changes since commit a95410696d21d38b629c61a09c100197c5fc533a: > > Merge branch

Re: [PATCH 0/4] Fix sparse warnings

2023-01-06 Thread Michal Simek
On 1/6/23 13:00, Ashok Reddy Soma wrote: Run and fix sparse warnings in below files -drivers/mmc/zynq_sdhci.c -board/xilinx/common/board.h -drivers/gpio/zynqmp_gpio_modepin.c -board/xilinx/versal/board.c Algapally Santosh Sagar (4): xilinx: common: Add missing prototype for

Re: [PATCH 1/4] xilinx: common: Add missing prototype for board_get_usable_ram_top

2023-01-06 Thread Michal Simek
On 1/6/23 13:00, Ashok Reddy Soma wrote: From: Algapally Santosh Sagar Add missing prototype to fix the sparse warning, warning: no previous prototype for 'board_get_usable_ram_top' [-Wmissing-prototypes]. Signed-off-by: Algapally Santosh Sagar Signed-off-by: Ashok Reddy Soma ---

Re: [PATCH 2/4] gpio: zynqmp: Remove unused variable ret

2023-01-06 Thread Michal Simek
On 1/6/23 13:00, Ashok Reddy Soma wrote: From: Algapally Santosh Sagar There is a unused variable ret, due to which we are getting sparse warning as below. warning: variable 'ret' set but not used [-Wunused-but-set-variable]. Remove variable ret. Signed-off-by: Algapally Santosh Sagar

Re: [PATCH 4/4] drivers: mmc: Change datatype to fix a warning

2023-01-06 Thread Michal Simek
mmc: zynq_sdhci: Fix wrong tuning_loop_counter datatype On 1/6/23 13:00, Ashok Reddy Soma wrote: From: Algapally Santosh Sagar tuning_loop_counter is of char type. Change to int to fix below warning. warning: comparison is always false due to limited range of data type. Conceptually

Re: [PATCH 3/4] xilinx: versal: Add missing prototype

2023-01-06 Thread Michal Simek
Add missing header in subject? On 1/6/23 13:00, Ashok Reddy Soma wrote: From: Algapally Santosh Sagar Add missing prototype to fix the sparse warning, warning: no previous prototype for 'do_go_exec' [-Wmissing-prototypes]. Signed-off-by: Algapally Santosh Sagar Signed-off-by: Ashok Reddy

Re: Pull request: u-boot-rockchip/for-next

2023-01-06 Thread Tom Rini
Please send a new PR. On Fri, Jan 6, 2023, 4:40 AM Kever Yang wrote: > Hi Tom, > > I have remove the rk3399.dtsi sync patch and update the for-next > branch. > > Do you need me to resend a new PR, or could you merge the latest > patches? > > The new CI result: > >

[PATCH 6/6] configs: stm32mp13: Activate command stm32key

2023-01-06 Thread Patrick Delaunay
Activate the command stm32key with CONFIG_CMD_STM32KEY. Signed-off-by: Patrick Delaunay --- configs/stm32mp13_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/stm32mp13_defconfig b/configs/stm32mp13_defconfig index f3d5e9812c6c..70b0d5dc99bf 100644 ---

[PATCH 5/6] board: st: Add support of STM32MP13x boards in stm32board cmd

2023-01-06 Thread Patrick Delaunay
Add board identifiers for STMicroelectronics STM32MP13x boards: - DISCO board: MB1635 Signed-off-by: Patrick Delaunay --- board/st/common/Kconfig | 2 +- board/st/common/cmd_stboard.c | 7 --- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/board/st/common/Kconfig

[PATCH 4/6] configs: stm32mp13: Activate CONFIG_CMD_FUSE

2023-01-06 Thread Patrick Delaunay
Activate the command fuse to access on STM32MP13x OTP with the BSEC driver. Signed-off-by: Patrick Delaunay --- configs/stm32mp13_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/stm32mp13_defconfig b/configs/stm32mp13_defconfig index af6b1839d039..f3d5e9812c6c 100644 ---

[PATCH 2/6] stm32mp: Add OP-TEE support in bsec driver

2023-01-06 Thread Patrick Delaunay
When OP-TEE is used, the SMC for BSEC management are not available and the STM32MP BSEC pseudo TA must be used (it is mandatory for STM32MP13 and it is a new feature for STM32MP15x). The BSEC driver try to open a session to this PTA BSEC at probe and use it for OTP read or write access to fuse or

[PATCH 3/6] stm32mp: Add support of STM32MP13x in bsec driver

2023-01-06 Thread Patrick Delaunay
Add support for "st,stm32mp13-bsec" for STM32MP13x in the bsec driver based on OP-TEE pseudo TA STM32MP BSEC. Signed-off-by: Patrick Delaunay --- arch/arm/mach-stm32mp/bsec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-stm32mp/bsec.c b/arch/arm/mach-stm32mp/bsec.c index

[PATCH 1/6] stm32mp: cosmetic: Update of bsec driver

2023-01-06 Thread Patrick Delaunay
Remove unnecessary return in stm32mp_bsec_write_lock and replace tab by space for plat_auto opts. Signed-off-by: Patrick Delaunay --- arch/arm/mach-stm32mp/bsec.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/arm/mach-stm32mp/bsec.c b/arch/arm/mach-stm32mp/bsec.c

  1   2   >