[bug] timer: orion-timer: static variable patch breaks armada-388-clearfog boot

2023-01-14 Thread Martin Rowe
Hi, Commit 5387b093 was a fix for early_init_done causing issues on Pogo v4 [1]. The fix breaks armada-388-clearfog because the boot hangs indefinitely. It appears that the cause is an infinite loop in __udelay due to get_ticks() always returning 0. After adding some printf statements it became

Re: [PATCH v2] vbe: Allow probing the VBE bootmeth to fail in OS fixup

2023-01-14 Thread Vagrant Cascadian
On 2023-01-12, Simon Glass wrote: > This device is created when there are no bootmeths defined in the device > tree. But it cannot be probed without a device tree node. > > For now, ignore a probe failure. > > Signed-off-by: Simon Glass > Reported-by: Karsten Merker > Suggested-by: Heinrich

Re: [PATCH 1/1] configs: enable CONFIG_LEGACY_IMAGE_FORMAT on sandbox

2023-01-14 Thread Simon Glass
On Sat, 14 Jan 2023 at 04:43, Heinrich Schuchardt wrote: > > The sandbox should be able to execute scripts in legacy U-Boot image format > for testing. > > Signed-off-by: Heinrich Schuchardt > --- > configs/sandbox_defconfig | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Simon Glass

Re: [PATCH 1/2] x86: Fix saying arch_cpu_init_dm in debug/docs

2023-01-14 Thread Simon Glass
On Sat, 14 Jan 2023 at 13:49, Tom Rini wrote: > > The function arch_cpu_init_dm was renamed to fsp_setup_pinctrl in these > cases, so rename debug / docs to match. > > Cc: Simon Glass > Fixes: 7fe32b3442f0 ("event: Convert arch_cpu_init_dm() to use events") > Signed-off-by: Tom Rini > --- >

Re: [PATCH 2/2] event: Correct dependencies on the EVENT framework

2023-01-14 Thread Simon Glass
Hi Tom, On Sat, 14 Jan 2023 at 13:49, Tom Rini wrote: > > The event framework is just that, a framework. Enabling it by itself > does nothing, so we shouldn't ask the user about it. Reword (and correct > typos) around this the option and help text. This also applies to > DM_EVENT, so reword as

RE: [PATCH 1/1] i2c:aspeed:support ast2600 i2c new register mode driver

2023-01-14 Thread Ryan Chen
Hello, I resend the v2 version here https://www.mail-archive.com/u-boot@lists.denx.de/msg460560.html Ryan Chen > -Original Message- > From: Simon Glass > Sent: Thursday, January 12, 2023 5:08 AM > To: Ryan Chen > Cc: Heiko Schocher ; BMC-SW ; > u-boot@lists.denx.de >

Re: [PATCH 3/8] sunxi: SPL SPI: allow multiple boot attempt

2023-01-14 Thread Icenowy Zheng
于 2023年1月15日 GMT+08:00 上午3:56:08, Samuel Holland 写到: >On 10/13/22 22:05, Icenowy Zheng wrote: >> As we're going to add support for SPI NAND to this code, add code that >> allows multiple boot attempts with different load offsets and functions. >> >> To keep compatibility with loading raw

[PATCH] odroid: limit boot memory to lowmem

2023-01-14 Thread Joost van Zwieten
Commit 4963f63fe61f15329d77472a762b1d8bf754d24b changed the default value of the `bootm_size` environment variable. For the odroid board this caused the initrd and fdt to be placed in highmem. This patch restricts the boot data conservatively to 256MB. Signed-off-by: Joost van Zwieten ---

Re: kwboot: UART booting with bin_hdr u-boot (Marvell Armada 385)

2023-01-14 Thread Tony Dinh
On Sat, Jan 14, 2023 at 2:53 PM Pali Rohár wrote: > > On Saturday 14 January 2023 14:48:28 Tony Dinh wrote: > > Hi Pali, > > > > On Sat, Jan 14, 2023 at 2:12 PM Tony Dinh wrote: > > > > > > Hi Pali, > > > > > > On Sat, Jan 14, 2023 at 1:44 PM Pali Rohár wrote: > > > > > > > > On Saturday 14

Re: kwboot: UART booting with bin_hdr u-boot (Marvell Armada 385)

2023-01-14 Thread Pali Rohár
On Saturday 14 January 2023 14:48:28 Tony Dinh wrote: > Hi Pali, > > On Sat, Jan 14, 2023 at 2:12 PM Tony Dinh wrote: > > > > Hi Pali, > > > > On Sat, Jan 14, 2023 at 1:44 PM Pali Rohár wrote: > > > > > > On Saturday 14 January 2023 13:35:08 Tony Dinh wrote: > > > > Hi Pali, > > > > > > > > On

Re: kwboot: UART booting with bin_hdr u-boot (Marvell Armada 385)

2023-01-14 Thread Tony Dinh
Hi Pali, On Sat, Jan 14, 2023 at 2:12 PM Tony Dinh wrote: > > Hi Pali, > > On Sat, Jan 14, 2023 at 1:44 PM Pali Rohár wrote: > > > > On Saturday 14 January 2023 13:35:08 Tony Dinh wrote: > > > Hi Pali, > > > > > > On Fri, Jan 13, 2023 at 5:32 PM Pali Rohár wrote: > > > > > > > > On Wednesday

Re: kwboot: UART booting with bin_hdr u-boot (Marvell Armada 385)

2023-01-14 Thread Tony Dinh
Hi Pali, On Sat, Jan 14, 2023 at 1:44 PM Pali Rohár wrote: > > On Saturday 14 January 2023 13:35:08 Tony Dinh wrote: > > Hi Pali, > > > > On Fri, Jan 13, 2023 at 5:32 PM Pali Rohár wrote: > > > > > > On Wednesday 11 January 2023 21:56:41 Pali Rohár wrote: > > > > On Wednesday 11 January 2023

Re: [PATCH] ddr: marvell: a38x: Add support for DDR4 from Marvell mv-ddr-marvell repository

2023-01-14 Thread Tony Dinh
Hi Pali & Tom, On Sat, Jan 14, 2023 at 12:06 PM Pali Rohár wrote: > > On Saturday 14 January 2023 15:03:41 Tom Rini wrote: > > On Sat, Jan 14, 2023 at 07:51:00PM +0100, Pali Rohár wrote: > > > On Friday 13 January 2023 21:00:21 Tom Rini wrote: > > > > On Sat, Jan 14, 2023 at 02:41:32AM +0100,

Re: kwboot: UART booting with bin_hdr u-boot (Marvell Armada 385)

2023-01-14 Thread Pali Rohár
On Saturday 14 January 2023 13:35:08 Tony Dinh wrote: > Hi Pali, > > On Fri, Jan 13, 2023 at 5:32 PM Pali Rohár wrote: > > > > On Wednesday 11 January 2023 21:56:41 Pali Rohár wrote: > > > On Wednesday 11 January 2023 12:44:45 Tony Dinh wrote: > > > > Hi Pali, > > > > > > > > On Wed, Jan 11,

Re: kwboot: UART booting with bin_hdr u-boot (Marvell Armada 385)

2023-01-14 Thread Tony Dinh
Hi Pali, On Fri, Jan 13, 2023 at 5:32 PM Pali Rohár wrote: > > On Wednesday 11 January 2023 21:56:41 Pali Rohár wrote: > > On Wednesday 11 January 2023 12:44:45 Tony Dinh wrote: > > > Hi Pali, > > > > > > On Wed, Jan 11, 2023 at 12:04 AM Pali Rohár wrote: > > > > > > > > On Tuesday 10 January

Re: [PATCH v2 u-boot 2/3] powerpc/mpc85xx: socrates: Rename u-boot-socrates.bin to u-boot.bin

2023-01-14 Thread Tom Rini
On Sat, Jan 14, 2023 at 10:12:06PM +0100, Pali Rohár wrote: > On Friday 13 January 2023 18:16:03 Tom Rini wrote: > > On Sat, Jan 14, 2023 at 12:11:22AM +0100, Pali Rohár wrote: > > > U-Boot build process for socrates board produces final U-Boot binary in > > > file u-boot-socrates.bin (by binman)

Re: [PATCH v2 u-boot 2/3] powerpc/mpc85xx: socrates: Rename u-boot-socrates.bin to u-boot.bin

2023-01-14 Thread Pali Rohár
On Friday 13 January 2023 18:16:03 Tom Rini wrote: > On Sat, Jan 14, 2023 at 12:11:22AM +0100, Pali Rohár wrote: > > U-Boot build process for socrates board produces final U-Boot binary in > > file u-boot-socrates.bin (by binman) And as a bonus it produces two > > unusable broken binaries

Re: [PATCH v2 1/1] doc: man-page for source command

2023-01-14 Thread Sean Anderson
On 1/14/23 14:15, Heinrich Schuchardt wrote: Provide a man-page for the source command. Signed-off-by: Heinrich Schuchardt --- v2: describe defaults for arguments mention signing and verifying FIT images link to uImage.FIT/signature.txt add an example with

[PATCH 2/2] event: Correct dependencies on the EVENT framework

2023-01-14 Thread Tom Rini
The event framework is just that, a framework. Enabling it by itself does nothing, so we shouldn't ask the user about it. Reword (and correct typos) around this the option and help text. This also applies to DM_EVENT, so reword as well. With this, it's time to address the larger problems. When

[PATCH 1/2] x86: Fix saying arch_cpu_init_dm in debug/docs

2023-01-14 Thread Tom Rini
The function arch_cpu_init_dm was renamed to fsp_setup_pinctrl in these cases, so rename debug / docs to match. Cc: Simon Glass Fixes: 7fe32b3442f0 ("event: Convert arch_cpu_init_dm() to use events") Signed-off-by: Tom Rini --- arch/x86/lib/spl.c| 2 +-

Re: [PATCH] sunxi: eMMC: support TOC0 on boot partitions

2023-01-14 Thread Samuel Holland
Hi Andre, On 1/4/23 19:58, Andre Przywara wrote: > To determine whether we have been booted from an eMMC boot partition, we > replay some of the checks that the BROM must have done to successfully > load the SPL. This involves a checksum check, which currently relies on > the SPL being wrapped in

Re: [PATCH] sunxi: f1c100s: re-enable SYSRESET

2023-01-14 Thread Samuel Holland
On 1/4/23 20:04, Andre Przywara wrote: > The SoC .dtsi originally submitted for the Allwinner F1C100s had the > wrong compatible string for the watchdog, which broke U-Boot's reset > functionality. To quickly fix this, we disable CONFIG_SYSRESET in > cfcf1952c11e6ffcbbf88 ("sunxi: f1c100s: Drop

Re: [PATCH] sunxi: f1c100s: Drop no-MMC hack

2023-01-14 Thread Samuel Holland
On 1/4/23 20:09, Andre Przywara wrote: > When support for the Allwinner F1C100s SoC was originally introduced, > its DT lacked any MMC nodes, which upset our sunxi-u-boot.dtsi overlay, > when it tried to add an alias to the SD card. To quickly fix this back > then, we guarded that alias with a

Re: [PATCH 5/8] sunxi: enable support for SPI NAND booting on SUNIV

2023-01-14 Thread Samuel Holland
On 10/13/22 22:05, Icenowy Zheng wrote: > As we added support for SPI NAND to the existing SPL SPI codepath, route > the boot code to it when it detects the BROM loads SPL from SPI NAND, as > for SoCs with both SPI NAND and boot media indicator support, the boot > media indicator is the same for

Re: [PATCH 4/8] sunxi: SPL SPI: add initial support for booting from SPI NAND

2023-01-14 Thread Samuel Holland
On 10/13/22 22:05, Icenowy Zheng wrote: > This commit adds support for booting from SPI NAND to SPL SPI code by > mimicing the behavior of boot ROM (use fixed page size and sequentially > try SPI NOR and NAND). One warning generated when SPL_SPI_SUNXI_NAND is disabled. Otherwise, it looks fine to

Re: [PATCH] ddr: marvell: a38x: Add support for DDR4 from Marvell mv-ddr-marvell repository

2023-01-14 Thread Pali Rohár
On Saturday 14 January 2023 15:03:41 Tom Rini wrote: > On Sat, Jan 14, 2023 at 07:51:00PM +0100, Pali Rohár wrote: > > On Friday 13 January 2023 21:00:21 Tom Rini wrote: > > > On Sat, Jan 14, 2023 at 02:41:32AM +0100, Pali Rohár wrote: > > > > On Friday 13 January 2023 16:38:55 Tony Dinh wrote: >

Re: [PATCH] ddr: marvell: a38x: Add support for DDR4 from Marvell mv-ddr-marvell repository

2023-01-14 Thread Tom Rini
On Sat, Jan 14, 2023 at 07:51:00PM +0100, Pali Rohár wrote: > On Friday 13 January 2023 21:00:21 Tom Rini wrote: > > On Sat, Jan 14, 2023 at 02:41:32AM +0100, Pali Rohár wrote: > > > On Friday 13 January 2023 16:38:55 Tony Dinh wrote: > > > > @@ -16,4 +19,9 @@ obj-$(CONFIG_SPL_BUILD) +=

Re: [PATCH 3/8] sunxi: SPL SPI: allow multiple boot attempt

2023-01-14 Thread Samuel Holland
On 10/13/22 22:05, Icenowy Zheng wrote: > As we're going to add support for SPI NAND to this code, add code that > allows multiple boot attempts with different load offsets and functions. > > To keep compatibility with loading raw binary on SPI NOR, a bool > parameter is used to allow booting

Re: [PATCH 2/3] dm: button: add support for linux_code in button-gpio.c driver

2023-01-14 Thread Dzmitry Sankouski
dev_read_u32 will fail, if linux,code is not found. We shouldn't fail here, as linux,code is optional, so maybe dev_read_u32_default with 0 default value, instead of negative error code? ср, 11 янв. 2023 г. в 18:48, Quentin Schulz : > > Hi Dzmitry, > > On 1/11/23 11:19, Dzmitry Sankouski wrote: >

Re: [PATCH 2/8] sunxi: SPL SPI: add support for read command with 2 byte address

2023-01-14 Thread Samuel Holland
On 10/13/22 22:05, Icenowy Zheng wrote: > This kind of read command is utilized in SPI NANDs for reading data > inside a selected page, which is obviously smaller than how much 2 > byte address can address. So 2 bytes are used for the address and one > dummy byte is needed after the real address.

Re: [PATCH 1/8] sunxi: SPL SPI: extract code for doing SPI transfer

2023-01-14 Thread Samuel Holland
On 10/13/22 22:05, Icenowy Zheng wrote: > To support SPI NAND flashes, more commands than Read (03h) are needed. > > Extract the code for doing SPI transfer from the reading code for code > reuse. > > Signed-off-by: Icenowy Zheng One comment below. Reviewed-by: Samuel Holland Tested-by:

[PATCH v2 1/1] doc: man-page for source command

2023-01-14 Thread Heinrich Schuchardt
Provide a man-page for the source command. Signed-off-by: Heinrich Schuchardt --- v2: describe defaults for arguments mention signing and verifying FIT images link to uImage.FIT/signature.txt add an example with incbin describe escaping hash sign

Re: [PATCH] ddr: marvell: a38x: Add support for DDR4 from Marvell mv-ddr-marvell repository

2023-01-14 Thread Pali Rohár
On Friday 13 January 2023 21:00:21 Tom Rini wrote: > On Sat, Jan 14, 2023 at 02:41:32AM +0100, Pali Rohár wrote: > > On Friday 13 January 2023 16:38:55 Tony Dinh wrote: > > > @@ -16,4 +19,9 @@ obj-$(CONFIG_SPL_BUILD) += mv_ddr_build_message.o > > > obj-$(CONFIG_SPL_BUILD) += mv_ddr_common.o > > >

Re: [PATCH 1/1] doc: man-page for source command

2023-01-14 Thread Heinrich Schuchardt
On 1/14/23 18:50, Sean Anderson wrote: On 1/14/23 12:41, Heinrich Schuchardt wrote: On 1/14/23 18:07, Sean Anderson wrote: On 1/14/23 06:51, Heinrich Schuchardt wrote: Provide a man-page for the source command. Signed-off-by: Heinrich Schuchardt ---   doc/usage/cmd/source.rst | 154

Re: [PATCH v2 01/22] apalis-imx8: fix booting caused by missing dm_event

2023-01-14 Thread Tom Rini
On Sat, Jan 14, 2023 at 07:00:08PM +0100, Heinrich Schuchardt wrote: > On 1/14/23 18:22, Tom Rini wrote: > > On Sat, Jan 14, 2023 at 11:57:20AM -0500, Tom Rini wrote: > > > On Sat, Jan 14, 2023 at 08:27:25AM -0500, Tom Rini wrote: > > > > On Sat, Jan 14, 2023 at 08:25:19AM -0300, Fabio Estevam

Re: [PATCH v2 01/22] apalis-imx8: fix booting caused by missing dm_event

2023-01-14 Thread Heinrich Schuchardt
On 1/14/23 18:22, Tom Rini wrote: On Sat, Jan 14, 2023 at 11:57:20AM -0500, Tom Rini wrote: On Sat, Jan 14, 2023 at 08:27:25AM -0500, Tom Rini wrote: On Sat, Jan 14, 2023 at 08:25:19AM -0300, Fabio Estevam wrote: Hi Francesco, On Fri, Jan 13, 2023 at 2:18 PM Francesco Dolcini wrote: From:

Re: [PATCH 1/1] doc: man-page for source command

2023-01-14 Thread Sean Anderson
On 1/14/23 12:41, Heinrich Schuchardt wrote: On 1/14/23 18:07, Sean Anderson wrote: On 1/14/23 06:51, Heinrich Schuchardt wrote: Provide a man-page for the source command. Signed-off-by: Heinrich Schuchardt ---   doc/usage/cmd/source.rst | 154 +++  

Re: [PATCH v2 01/22] apalis-imx8: fix booting caused by missing dm_event

2023-01-14 Thread Tom Rini
On Sat, Jan 14, 2023 at 12:22:24PM -0500, Tom Rini wrote: > On Sat, Jan 14, 2023 at 11:57:20AM -0500, Tom Rini wrote: > > On Sat, Jan 14, 2023 at 08:27:25AM -0500, Tom Rini wrote: > > > On Sat, Jan 14, 2023 at 08:25:19AM -0300, Fabio Estevam wrote: > > > > Hi Francesco, > > > > > > > > On Fri,

Re: [PATCH 1/1] doc: man-page for source command

2023-01-14 Thread Heinrich Schuchardt
On 1/14/23 18:07, Sean Anderson wrote: On 1/14/23 06:51, Heinrich Schuchardt wrote: Provide a man-page for the source command. Signed-off-by: Heinrich Schuchardt ---   doc/usage/cmd/source.rst | 154 +++   doc/usage/index.rst  |   1 +   2 files

Re: [PATCH v2 10/22] apalis-imx8: update spdx license identifier string

2023-01-14 Thread Tom Rini
On Fri, Jan 13, 2023 at 06:17:39PM +0100, Francesco Dolcini wrote: > From: Marcel Ziswiler > > Update SPDX license identifier string. > > While at it also update copyright period. > > Signed-off-by: Marcel Ziswiler > Signed-off-by: Francesco Dolcini > --- > v2: no changes Please don't do

Re: [PATCH v2 01/22] apalis-imx8: fix booting caused by missing dm_event

2023-01-14 Thread Tom Rini
On Sat, Jan 14, 2023 at 11:57:20AM -0500, Tom Rini wrote: > On Sat, Jan 14, 2023 at 08:27:25AM -0500, Tom Rini wrote: > > On Sat, Jan 14, 2023 at 08:25:19AM -0300, Fabio Estevam wrote: > > > Hi Francesco, > > > > > > On Fri, Jan 13, 2023 at 2:18 PM Francesco Dolcini > > > wrote: > > > > > > > >

Re: [PATCH 1/1] doc: man-page for source command

2023-01-14 Thread Sean Anderson
On 1/14/23 06:51, Heinrich Schuchardt wrote: Provide a man-page for the source command. Signed-off-by: Heinrich Schuchardt --- doc/usage/cmd/source.rst | 154 +++ doc/usage/index.rst | 1 + 2 files changed, 155 insertions(+) create mode 100644

Re: [PATCH v2 01/22] apalis-imx8: fix booting caused by missing dm_event

2023-01-14 Thread Tom Rini
On Sat, Jan 14, 2023 at 08:27:25AM -0500, Tom Rini wrote: > On Sat, Jan 14, 2023 at 08:25:19AM -0300, Fabio Estevam wrote: > > Hi Francesco, > > > > On Fri, Jan 13, 2023 at 2:18 PM Francesco Dolcini > > wrote: > > > > > > From: Marcel Ziswiler > > > > > > Without the DM_EVENT absolutely no

Re: [U-Boot][bug report] clearfog: EMMC boot broken on clearfog pro

2023-01-14 Thread Martin Rowe
Hello again > So in order to move forward, the current plan is to find out/bisect first > commit after v2021.01 which has introduced this BootROM SD/eMMC/SATA boot > regression and inform involved folks (Author and Commiter) accordingly with a > proper bug report. I did try to bisect the eMMC

Re: [PATCH v2 01/22] apalis-imx8: fix booting caused by missing dm_event

2023-01-14 Thread Tom Rini
On Sat, Jan 14, 2023 at 08:25:19AM -0300, Fabio Estevam wrote: > Hi Francesco, > > On Fri, Jan 13, 2023 at 2:18 PM Francesco Dolcini > wrote: > > > > From: Marcel Ziswiler > > > > Without the DM_EVENT absolutely no output whatsoever and the system does > > not boot at all. > > Why do we need

[PATCH 1/1] doc: man-page for source command

2023-01-14 Thread Heinrich Schuchardt
Provide a man-page for the source command. Signed-off-by: Heinrich Schuchardt --- doc/usage/cmd/source.rst | 154 +++ doc/usage/index.rst | 1 + 2 files changed, 155 insertions(+) create mode 100644 doc/usage/cmd/source.rst diff --git

[PATCH 1/1] configs: enable CONFIG_LEGACY_IMAGE_FORMAT on sandbox

2023-01-14 Thread Heinrich Schuchardt
The sandbox should be able to execute scripts in legacy U-Boot image format for testing. Signed-off-by: Heinrich Schuchardt --- configs/sandbox_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/sandbox_defconfig b/configs/sandbox_defconfig index de799b5cea..6239d495db 100644

Re: [PATCH v2 00/22] apalis-imx8: boot issue fix and support refresh

2023-01-14 Thread Fabio Estevam
Hi Francesco, On Fri, Jan 13, 2023 at 2:18 PM Francesco Dolcini wrote: > > From: Francesco Dolcini > > This series fixes a boot issue and refreshes Apalis iMX8 support as > follows: The whole series looks good. > - fix booting caused by missing DM_EVENT My only comment is that this one

Re: [PATCH v2 01/22] apalis-imx8: fix booting caused by missing dm_event

2023-01-14 Thread Fabio Estevam
Hi Francesco, On Fri, Jan 13, 2023 at 2:18 PM Francesco Dolcini wrote: > > From: Marcel Ziswiler > > Without the DM_EVENT absolutely no output whatsoever and the system does > not boot at all. Why do we need to select CONFIG_EVENT=y in the first place? Oliver on CC reported the same issue for

Re: [PATCH v3 3/3] eficonfig: add vertical scroll support

2023-01-14 Thread Heinrich Schuchardt
On 1/14/23 11:06, Heinrich Schuchardt wrote: On 1/5/23 03:58, Masahisa Kojima wrote: The current eficonfig menu does not support vertical scroll, so it can not display the menu entries greater than the console row size. This commit add the vertial scroll support. The console size is retrieved

Re: [PATCH v3 3/3] eficonfig: add vertical scroll support

2023-01-14 Thread Heinrich Schuchardt
On 1/5/23 03:58, Masahisa Kojima wrote: The current eficonfig menu does not support vertical scroll, so it can not display the menu entries greater than the console row size. This commit add the vertial scroll support. The console size is retrieved by SIMPLE_TEXT_OUTPUT_PROTOCOL.QueryMode()

tools/ifwitool.c:573:26: warning: array subscript [28, 51539607568] is outside array bounds of ‘struct bpdt[0]’ [-Warray-bounds

2023-01-14 Thread Heinrich Schuchardt
Hello Mikhail, compiling sandbox_defconfig with gives me a lot of these warnings with gcc 12.2 (as available in Ubuntu 23.04 Lunar). As you have been contributing to tools/ifwitool.c lately you might want to have a look at it. tools/ifwitool.c:1435:22: note: at offset [32, 51539607572] into