Re: [PATCH 1/1] efi_loader: stop watchdogs in ExitBootServices()

2023-02-02 Thread Rasmus Villemoes
On 03/02/2023 03.15, Simon Glass wrote: > Hi Tom, > > On Thu, 2 Feb 2023 at 10:22, Tom Rini wrote: >> >> Honestly, not really? Some good number of SoCs will start the watchdog >> in ROM and these are also the ones that don't allow you to turn it off. > > I hope not, that sounds really risky.

Re: [PATCH v2 15/16] ARM: tegra30: implement BCT patching

2023-02-02 Thread Svyatoslav Ryhel
Greetings! пт, 3 лют. 2023 р. о 04:15 Simon Glass пише: > > Hi Svyatoslav, > > On Thu, 2 Feb 2023 at 11:23, Svyatoslav Ryhel wrote: > > > > From: Ramin Khonsari > > > > This function allows updating bootloader from u-boot > > on production devices without need in host PC. > > > > Be aware! It

Re: [PATCH v2 03/16] ARM: tegra: clock: add clk_id_to_pll_id helper

2023-02-02 Thread Svyatoslav Ryhel
пт, 3 лют. 2023 р. о 00:05 Tom Warren пише: > > Svyatoslav, > > I was able to apply all of your V2 'General Tegra' patches OK on top of > current u-boot-tegra/master. But buildman (and normal make > dalmore_defconfig/make) fail to build Dalmore (T114) with the following error: > > CC

Re: [PATCH v2 10/16] ARM: tegra: create common pre-dm i2c write

2023-02-02 Thread Svyatoslav Ryhel
пт, 3 лют. 2023 р. о 04:16 Simon Glass пише: > > Hi Svyatoslav, > > On Thu, 2 Feb 2023 at 11:43, Svyatoslav Ryhel wrote: > > > > This implementation allows pwr i2c writing on early > > stages when DM was not yet setup. > > s/was/is/ ? Greetings! is > > > > > Such writing is needed to

RE: [PATCH 154/171] Correct SPL use of TARGET_PG_WCOM_SELI8

2023-02-02 Thread Aleksandar Gerasimovski
This converts 1 usage of this option to the non-SPL form, since there is no SPL_TARGET_PG_WCOM_SELI8 defined in Kconfig Signed-off-by: Simon Glass --- Reviewed-by: Aleksandar Gerasimovski Regards, Aleksandar board/keymile/pg-wcom-ls102xa/pg-wcom-ls102xa.c | 2 +- 1 file changed, 1

RE: [PATCH 153/171] Correct SPL use of TARGET_PG_WCOM_EXPU1

2023-02-02 Thread Aleksandar Gerasimovski
This converts 1 usage of this option to the non-SPL form, since there is no SPL_TARGET_PG_WCOM_EXPU1 defined in Kconfig Signed-off-by: Simon Glass --- Reviewed-by: Aleksandar Gerasimovski Regards, Aleksandar board/keymile/pg-wcom-ls102xa/pg-wcom-ls102xa.c | 2 +- 1 file changed, 1

RE: [PATCH 124/171] Correct SPL use of PG_WCOM_UBOOT_UPDATE_SUPPORTED

2023-02-02 Thread Aleksandar Gerasimovski
This converts 1 usage of this option to the non-SPL form, since there is no SPL_PG_WCOM_UBOOT_UPDATE_SUPPORTED defined in Kconfig Signed-off-by: Simon Glass --- Reviewed-by: Aleksandar Gerasimovski Regards, Aleksandar board/keymile/common/common.c | 2 +- 1 file changed, 1 insertion(+), 1

RE: [PATCH 122/171] Correct SPL uses of PG_WCOM_UBOOT_BOOTPACKAGE

2023-02-02 Thread Aleksandar Gerasimovski
This converts 2 usages of this option to the non-SPL form, since there is no SPL_PG_WCOM_UBOOT_BOOTPACKAGE defined in Kconfig Signed-off-by: Simon Glass --- Reviewed-by: Aleksandar Gerasimovski Regards, Aleksandar board/keymile/common/common.c | 4 ++-- 1 file changed, 2 insertions(+), 2

RE: [PATCH 123/171] Correct SPL uses of PG_WCOM_UBOOT_UPDATE

2023-02-02 Thread Aleksandar Gerasimovski
This converts 2 usages of this option to the non-SPL form, since there is no SPL_PG_WCOM_UBOOT_UPDATE defined in Kconfig Signed-off-by: Simon Glass --- Reviewed-by: Aleksandar Gerasimovski Regards, Aleksandar board/keymile/common/common.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH v3 20/76] samsung: Drop CONFIG_EXYNOS_PWM_BL

2023-02-02 Thread Minkyu Kang
Hi, On Thu, 2 Feb 2023 at 05:34, Simon Glass wrote: > This is not defined anywhere. Drop it. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > drivers/video/exynos/Makefile | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/video/exynos/Makefile

Re: [PATCH v3 46/76] samsung: Rename PINCTRL_EXYNOS78x0

2023-02-02 Thread Minkyu Kang
Hi, On Thu, 2 Feb 2023 at 05:48, Simon Glass wrote: > CONFIG options must not use lower-case letter. Convert this to upper case. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > arch/arm/mach-exynos/Kconfig| 6 +++--- > drivers/pinctrl/exynos/Kconfig | 2 +- >

Re: [EXTERNAL] Re: [PATCH v2 1/7] drivers: core: ofnode: Add panel timing decode.

2023-02-02 Thread Nikhil M Jain
Hi Simon, On 31/01/23 19:46, Simon Glass wrote: On Tue, 31 Jan 2023 at 03:05, Nikhil M Jain wrote: ofnode_decode_display_timing supports reading timing parameters from subnode of display-timings node, for displays supporting multiple resolution, in case if a display supports single

Re: [PATCH] arm: kirkwood: Enable uart0 dm-pre-reloc for Kirkwood boards

2023-02-02 Thread Tony Dinh
Hi all, On Thu, Feb 2, 2023 at 3:59 PM Tony Dinh wrote: > > Hi all, > > On Thu, Feb 2, 2023 at 10:04 AM Pali Rohár wrote: > > > > On Wednesday 01 February 2023 13:13:16 Tony Dinh wrote: > > > Hi all, > > > > > > On Wed, Feb 1, 2023 at 11:05 AM Pali Rohár wrote: > > > > > > > > On Wednesday 01

Re: [RFC PATCH v1 2/2] include: dm: ofnode: fix headers

2023-02-02 Thread Simon Glass
On Thu, 2 Feb 2023 at 10:59, Johan Jonker wrote: > > When fdt_addr_t and phys_addr_t are split it turns out that > the header don't match the functions, so fix the headers. > > Signed-off-by: Johan Jonker > --- > include/dm/ofnode.h | 16 > 1 file changed, 8 insertions(+), 8

Re: [PATCH v2 10/16] ARM: tegra: create common pre-dm i2c write

2023-02-02 Thread Simon Glass
Hi Svyatoslav, On Thu, 2 Feb 2023 at 11:43, Svyatoslav Ryhel wrote: > > This implementation allows pwr i2c writing on early > stages when DM was not yet setup. s/was/is/ ? > > Such writing is needed to configure main voltages of PMIC. Is this in SPL? > > Tested-by: Andreas Westman Dorcsak #

Re: [PATCH v2 01/16] tegra30: clock: add EXTPERIPH

2023-02-02 Thread Simon Glass
On Thu, 2 Feb 2023 at 11:14, Svyatoslav Ryhel wrote: > > This mappings were missing for some reason. > > Tested-by: Svyatoslav Ryhel # LG P895 T30 > Signed-off-by: Svyatoslav Ryhel > --- > arch/arm/include/asm/arch-tegra30/clock-tables.h | 6 +++--- > arch/arm/mach-tegra/tegra30/clock.c

Re: [PATCH v2 12/16] board: tegra30: switch to updated pre-dm i2c write

2023-02-02 Thread Simon Glass
On Thu, 2 Feb 2023 at 11:28, Svyatoslav Ryhel wrote: > > Configure PMIC voltages for early stages using updated > early i2c write. > > Signed-off-by: Svyatoslav Ryhel > --- > arch/arm/mach-tegra/tegra30/Kconfig | 8 > arch/arm/mach-tegra/tegra30/cpu.c | 36

Re: [PATCH v2 15/16] ARM: tegra30: implement BCT patching

2023-02-02 Thread Simon Glass
Hi Svyatoslav, On Thu, 2 Feb 2023 at 11:23, Svyatoslav Ryhel wrote: > > From: Ramin Khonsari > > This function allows updating bootloader from u-boot > on production devices without need in host PC. > > Be aware! It works only with re-crypted BCT. > > Tested-by: Andreas Westman Dorcsak # ASUS

Re: [PATCH v2 11/16] board: tegra124: switch to updated pre-dm i2c write

2023-02-02 Thread Simon Glass
On Thu, 2 Feb 2023 at 11:17, Svyatoslav Ryhel wrote: > > Configure PMIC for early stages using updated i2c write. > > Signed-off-by: Svyatoslav Ryhel > --- > board/nvidia/venice2/as3722_init.c | 65 > board/nvidia/venice2/as3722_init.h | 43 - >

Re: [PATCH 1/1] efi_loader: stop watchdogs in ExitBootServices()

2023-02-02 Thread Simon Glass
Hi Tom, On Thu, 2 Feb 2023 at 10:22, Tom Rini wrote: > > On Thu, Feb 02, 2023 at 10:12:07AM -0700, Simon Glass wrote: > > Hi, > > > > On Thu, 2 Feb 2023 at 01:17, Etienne Carriere > > wrote: > > > > > > Hello Heinrich and all, > > > > > > On Wed, 1 Feb 2023 at 10:00, Heinrich Schuchardt > > >

Re: [PATCH] arm: kirkwood: Enable uart0 dm-pre-reloc for Kirkwood boards

2023-02-02 Thread Tony Dinh
Hi all, On Thu, Feb 2, 2023 at 10:04 AM Pali Rohár wrote: > > On Wednesday 01 February 2023 13:13:16 Tony Dinh wrote: > > Hi all, > > > > On Wed, Feb 1, 2023 at 11:05 AM Pali Rohár wrote: > > > > > > On Wednesday 01 February 2023 09:17:15 Michael Walle wrote: > > > > > > > When DM_SERIAL is

[PATCH] arm: kirkwood: sheevaplug: reduce u-boot image size

2023-02-02 Thread Tony Dinh
Sheevaplug board has 512K CONFIG_BOARD_SIZE_LIMIT. Recently, DM_SERIAL has pushed the image size a few hundred bytes over that limit. So explicitly deselect some configs that are unrelated to this board (and gain back a bit over 2K). Signed-off-by: Tony Dinh --- configs/sheevaplug_defconfig |

RE: [PATCH v2 03/16] ARM: tegra: clock: add clk_id_to_pll_id helper

2023-02-02 Thread Tom Warren
Svyatoslav, I was able to apply all of your V2 'General Tegra' patches OK on top of current u-boot-tegra/master. But buildman (and normal make dalmore_defconfig/make) fail to build Dalmore (T114) with the following error: CC arch/arm/mach-tegra/tegra114/clock.o

Re: [PATCH v2 2/3] net: ftmac100: simplify priv->iobase casting

2023-02-02 Thread Tom Rini
On Thu, Jan 19, 2023 at 10:51:15PM +0300, Sergei Antonov wrote: > Replace 'phys_addr_t iobase' with 'struct ftmac100 *ftmac100' > in order to cast once on assignment and remove casting in a > number of other places. > > Signed-off-by: Sergei Antonov > Reviewed-by: Ramon Fried This introduces:

Re: [PATCH v4] common: avb_verify: prevent opening incorrect session

2023-02-02 Thread Ivan Khoronzhuk
Any comments to this patch? -- Regards, Ivan Khoronzhuk

Re: Pull request, u-boot-tegra/master

2023-02-02 Thread Tom Rini
On Thu, Feb 02, 2023 at 10:43:33AM -0700, Tom Warren wrote: > Tom, > > Please pull u-boot-tegra/master into U-Boot/master. Thanks. > It has passed 'buildman tegra' w/o error, and Thierry has tested it on his > Tegra boards. > > The following changes since commit

Re: [PULL] u-boot-riscv/master

2023-02-02 Thread Tom Rini
On Thu, Feb 02, 2023 at 06:30:07AM +, Leo Liang wrote: > Hi Tom, > > The following changes since commit 73a3f5139182a0389d505bf29b0ad4bc29424cf8: > > Merge https://source.denx.de/u-boot/custodians/u-boot-mmc (2023-01-31 > 18:28:07 -0500) > > are available in the Git repository at: > >

Re: [PULL] u-boot-sh/master

2023-02-02 Thread Tom Rini
On Thu, Feb 02, 2023 at 02:42:16AM +0100, Marek Vasut wrote: > The following changes since commit 1e1cd8eb2d0c8e5b28b2dd6622ec9cbbd5eb61b8: > > Merge tag 'fsl-qoriq-2023-2-1' of > https://source.denx.de/u-boot/custodians/u-boot-fsl-qoriq (2023-02-01 > 09:31:17 -0500) > > are available in the

[PATCH v2 12/16] board: tegra30: switch to updated pre-dm i2c write

2023-02-02 Thread Svyatoslav Ryhel
Configure PMIC voltages for early stages using updated early i2c write. Signed-off-by: Svyatoslav Ryhel --- arch/arm/mach-tegra/tegra30/Kconfig | 8 arch/arm/mach-tegra/tegra30/cpu.c | 36 - board/avionic-design/tec-ng/Makefile| 4 +-

[PATCH v2 16/16] ARM: tegra20: implement BCT patching

2023-02-02 Thread Svyatoslav Ryhel
This function allows updating bootloader from u-boot on production devices without need in host PC. Be aware! It works only with re-crypt BCT. Tested-by: Robert Eckelmann # ASUS TF101 T20 Signed-off-by: Ramin Khonsari Signed-off-by: Svyatoslav Ryhel --- arch/arm/mach-tegra/Kconfig |

[PATCH v2 15/16] ARM: tegra30: implement BCT patching

2023-02-02 Thread Svyatoslav Ryhel
From: Ramin Khonsari This function allows updating bootloader from u-boot on production devices without need in host PC. Be aware! It works only with re-crypted BCT. Tested-by: Andreas Westman Dorcsak # ASUS TF T30 Tested-by: Svyatoslav Ryhel # LG P895 T30 Signed-off-by: Ramin Khonsari

[PATCH v2 14/16] ARM: tegra: crypto: extend crypto functional

2023-02-02 Thread Svyatoslav Ryhel
Add support for encryption, decryption and signinig with non-zero key saving backward compatibility. Signed-off-by: Svyatoslav Ryhel --- arch/arm/include/asm/arch-tegra/crypto.h | 47 ++ arch/arm/mach-tegra/crypto.c | 63 +---

[PATCH v2 11/16] board: tegra124: switch to updated pre-dm i2c write

2023-02-02 Thread Svyatoslav Ryhel
Configure PMIC for early stages using updated i2c write. Signed-off-by: Svyatoslav Ryhel --- board/nvidia/venice2/as3722_init.c | 65 board/nvidia/venice2/as3722_init.h | 43 - board/toradex/apalis-tk1/as3722_init.c | 85 ++

[PATCH v2 13/16] ARM: tegra: expose crypto module for all Tegra SoCs

2023-02-02 Thread Svyatoslav Ryhel
Move crypto module from T20 only into common Tegra dir. Signed-off-by: Svyatoslav Ryhel --- arch/arm/mach-tegra/Kconfig| 5 + arch/arm/mach-tegra/Makefile | 1 + arch/arm/mach-tegra/{tegra20 => }/crypto.c | 0 arch/arm/mach-tegra/{tegra20 => }/crypto.h | 0

[PATCH v2 10/16] ARM: tegra: create common pre-dm i2c write

2023-02-02 Thread Svyatoslav Ryhel
This implementation allows pwr i2c writing on early stages when DM was not yet setup. Such writing is needed to configure main voltages of PMIC. Tested-by: Andreas Westman Dorcsak # ASUS TF T30 Tested-by: Robert Eckelmann # ASUS TF101 T20 Tested-by: Svyatoslav Ryhel # LG P895 T30

[PATCH v2 09/16] ARM: tegra: add late init support

2023-02-02 Thread Svyatoslav Ryhel
Late init function allows passing values like identifiers and perform device specific configurations of pre-boot stage. Tested-by: Andreas Westman Dorcsak # ASUS TF T30 Tested-by: Svyatoslav Ryhel # LG P895 T30 Signed-off-by: Svyatoslav Ryhel --- arch/arm/include/asm/arch-tegra/sys_proto.h |

[PATCH v2 08/16] ARM: tegra: provide default USB gadget setup

2023-02-02 Thread Svyatoslav Ryhel
From: Maxim Schwalm All Nvidia boards use the same manufacturer, vendor ID and product ID for the gadgets. Make them the defaults to remove some boilerplate from the defconfigs. Inspired by commit e02687bda96c ("sunxi: provide default USB gadget setup") which did the same for Allwinner boards.

[PATCH v2 07/16] spi: tegra20_slink: accept any word length

2023-02-02 Thread Svyatoslav Ryhel
Original t20 slink could work with commands only fully divisible by 8. This patch removes such restriction, so commands of any bitlength now can be passed and processed. Tested-by: Andreas Westman Dorcsak # ASUS TF600T T30 Tested-by: Svyatoslav Ryhel # LG P895 T30 Signed-off-by: Svyatoslav

[PATCH v2 06/16] ARM: tegra: Fix Tegra PWM parent clock

2023-02-02 Thread Svyatoslav Ryhel
Default parent clock for the PWM on Tegra is a 32kHz clock and is unable to support the requested PWM period. Fix PWM support on Tegra20, Tegra30, Tegra114, Tegra124 and Tegra210 by updating the parent clock for the PWM to be the PLL_P. This commit is equivalent to Linux kernel commit:

[PATCH v2 05/16] ARM: tegra30: add PLLD to pll setup

2023-02-02 Thread Svyatoslav Ryhel
On T30 unlike T20 dsi panels are wider used on devices and PLLD is used as DISP1 parent more often, so lets enable it as well for this cases. Tested-by: Andreas Westman Dorcsak # ASUS TF700T T30 Tested-by: Svyatoslav Ryhel # HTC One X T30 Signed-off-by: Svyatoslav Ryhel ---

[PATCH v2 04/16] ARM: tegra: clock: add clock_decode_pair helper

2023-02-02 Thread Svyatoslav Ryhel
Get periph clock id and its parent from device tree. This works by looking up the peripheral's 'clocks' node and reading out the second and fourth cells, which are the peripheral and PLL clock numbers. Signed-off-by: Svyatoslav Ryhel --- arch/arm/include/asm/arch-tegra/clock.h | 13

[PATCH v2 03/16] ARM: tegra: clock: add clk_id_to_pll_id helper

2023-02-02 Thread Svyatoslav Ryhel
This function allows to convert a device tree clock ID to PLL ID. Tested-by: Andreas Westman Dorcsak # ASUS TF T30 Tested-by: Robert Eckelmann # ASUS TF101 T20 Tested-by: Svyatoslav Ryhel # HTC One X Signed-off-by: Svyatoslav Ryhel --- arch/arm/include/asm/arch-tegra/clock.h | 8 ++

[PATCH v2 02/16] ARM: t20/t30: swap host1x and disp1 clock parents

2023-02-02 Thread Svyatoslav Ryhel
According to mainline clock tables and TRM HOST1X parent is PLLC, while DISP1 usually uses PLLP as parent clock. Tested-by: Andreas Westman Dorcsak # ASUS TF T30 Tested-by: Robert Eckelmann # ASUS TF101 T20 Tested-by: Svyatoslav Ryhel # LG P895 T30 Signed-off-by: Svyatoslav Ryhel ---

[PATCH v2 01/16] tegra30: clock: add EXTPERIPH

2023-02-02 Thread Svyatoslav Ryhel
This mappings were missing for some reason. Tested-by: Svyatoslav Ryhel # LG P895 T30 Signed-off-by: Svyatoslav Ryhel --- arch/arm/include/asm/arch-tegra30/clock-tables.h | 6 +++--- arch/arm/mach-tegra/tegra30/clock.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-)

[PATCH v2 00/16] General Tegra improvements

2023-02-02 Thread Svyatoslav Ryhel
List of changes in patch set: - add missing EXTPERIPH clocks for t30 - swap host1x and disp1 clock parents (as they should be) - add clk_id_to_pll_id and clock_decode_pair helpers to use dts deeper (in tegra clocks often go in pair child - parent) - include PLLD setup in T30 (DISP1 may use

Re: [PATCH] arm: kirkwood: Enable uart0 dm-pre-reloc for Kirkwood boards

2023-02-02 Thread Pali Rohár
On Wednesday 01 February 2023 13:13:16 Tony Dinh wrote: > Hi all, > > On Wed, Feb 1, 2023 at 11:05 AM Pali Rohár wrote: > > > > On Wednesday 01 February 2023 09:17:15 Michael Walle wrote: > > > > > > When DM_SERIAL is enabled, the device-tree property dm-pre-reloc is > > > > > > required to boot

Re: [PATCH v7 0/3] Timer support for ARM Tegra

2023-02-02 Thread Svyatoslav Ryhel
Hm, you are correct. Patchset I have sent was based on u-boot/master without timer patches. Now, since those are merged, I need to adjust them a bit. It is not a big issue since I have some more optimisations to be added anyway. I will send an updated version within an hour if nothing interferes.

[RFC PATCH v1 2/2] include: dm: ofnode: fix headers

2023-02-02 Thread Johan Jonker
When fdt_addr_t and phys_addr_t are split it turns out that the header don't match the functions, so fix the headers. Signed-off-by: Johan Jonker --- include/dm/ofnode.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/include/dm/ofnode.h

[RFC PATCH v1 1/2] include: fdtdec: decouple fdt_addr_t and phys_addr_t size

2023-02-02 Thread Johan Jonker
The DT specification supports CPUs with both 32-bit and 64-bit addressing capabilities. In U-boot the fdt_addr_t and phys_addr_t size are coupled by a typedef. The MTD NAND drivers for 32-bit CPU's can describe partitions with a 64-bit reg property. These partitions synced from Linux end up with

RE: [PATCH v7 0/3] Timer support for ARM Tegra

2023-02-02 Thread Tom Warren
I've merged your 3 timer patches w/TOT u-boot-tegra, and sent a PR to Tom Rini. However, your v1 16-patch series here does no apply cleanly on top of the new u-boot-tegra/master (fast-forwarded to u-boot/master TOT, and then with your 3 timer patches applied on top). PTAL, git am error spew

Pull request, u-boot-tegra/master

2023-02-02 Thread Tom Warren
Tom, Please pull u-boot-tegra/master into U-Boot/master. Thanks. It has passed 'buildman tegra' w/o error, and Thierry has tested it on his Tegra boards. The following changes since commit 1e1cd8eb2d0c8e5b28b2dd6622ec9cbbd5eb61b8: Merge tag 'fsl-qoriq-2023-2-1' of

Re: Docs for RISC-V

2023-02-02 Thread Simon Glass
Hi, On Thu, 2 Feb 2023 at 10:18, Simon Glass wrote: > > Hi Rick & Leo, > > I see docs for one board at [1] but I'm not sure what to do with unleashed. > > It seems to need a 'genimage' tool, going on what I see in CI. > > Could you adjust it to use binman to output an image suitable for >

Re: [PATCH 1/1] efi_loader: stop watchdogs in ExitBootServices()

2023-02-02 Thread Tom Rini
On Thu, Feb 02, 2023 at 10:12:07AM -0700, Simon Glass wrote: > Hi, > > On Thu, 2 Feb 2023 at 01:17, Etienne Carriere > wrote: > > > > Hello Heinrich and all, > > > > On Wed, 1 Feb 2023 at 10:00, Heinrich Schuchardt > > wrote: > > > > > > > > > > > > On 2/1/23 09:32, Rasmus Villemoes wrote: > >

Re: [PATCH v4 2/6] tpm: Support boot measurements

2023-02-02 Thread Eddie James
On 2/2/23 11:12, Simon Glass wrote: Hi Eddie / Ilias, On Thu, 2 Feb 2023 at 09:24, Eddie James wrote: On 1/26/23 01:51, Ilias Apalodimas wrote: Hi Eddie, Thanks for the cleanup! Unfortunately this doesn't compile with EFI selected, but in general it looks pretty good. Thanks, yes I

Docs for RISC-V

2023-02-02 Thread Simon Glass
Hi Rick & Leo, I see docs for one board at [1] but I'm not sure what to do with unleashed. It seems to need a 'genimage' tool, going on what I see in CI. Could you adjust it to use binman to output an image suitable for writing to an SD card in a single 'dd' step, as Rockchip does? Also, how

Re: [PATCH v4 2/6] tpm: Support boot measurements

2023-02-02 Thread Simon Glass
Hi Eddie / Ilias, On Thu, 2 Feb 2023 at 09:24, Eddie James wrote: > > > On 1/26/23 01:51, Ilias Apalodimas wrote: > > Hi Eddie, > > > > Thanks for the cleanup! Unfortunately this doesn't compile with EFI > > selected, but in general it looks pretty good. > > > Thanks, yes I forgot to remove

Re: V3s - Ethernet and SPI NOR problems..

2023-02-02 Thread Simon Glass
Hi, On Fri, 13 Jan 2023 at 13:32, Serdar KOYLU wrote: > > Hello everyone. > I works many custom V3s boards and tried many versions for u-boot. We find > two main problems for our use case and seems all versions is useless for me. > This comments for 2022.07 release.. Your email is garbled and

Re: [PATCH 1/1] efi_loader: stop watchdogs in ExitBootServices()

2023-02-02 Thread Simon Glass
Hi, On Thu, 2 Feb 2023 at 01:17, Etienne Carriere wrote: > > Hello Heinrich and all, > > On Wed, 1 Feb 2023 at 10:00, Heinrich Schuchardt > wrote: > > > > > > > > On 2/1/23 09:32, Rasmus Villemoes wrote: > > > On 31/01/2023 16.07, Tom Rini wrote: > > >> On Tue, Jan 31, 2023 at 02:03:10PM +0200,

Re: [PATCH 1/2] net: dhcp6: Add DHCPv6 (DHCP for IPv6)

2023-02-02 Thread Simon Glass
Hi, On Wed, 1 Feb 2023 at 17:26, wrote: > > From: Sean Edmond > > Adds DHCPv6 protocol to u-boot. > > Allows for address assignement with DHCPv6 4-message exchange > (SOLICIT->ADVERTISE->REQUEST->REPLY). Includes DHCPv6 options > required by RFC 8415. Also adds DHCPv6 options required > for

[PATCH v5 2/6] tpm: Support boot measurements

2023-02-02 Thread Eddie James
Add TPM2 functions to support boot measurement. This includes starting up the TPM, initializing/appending the event log, and measuring the U-Boot version. Much of the code was used in the EFI subsystem, so remove it there and use the common functions. Signed-off-by: Eddie James --- Changes since

[PATCH v5 6/6] doc: Add measured boot documentation

2023-02-02 Thread Eddie James
Briefly describe the feature and specify the requirements. Signed-off-by: Eddie James --- Changes since v4: - Use bullets for the requirements list doc/usage/index.rst | 1 + doc/usage/measured_boot.rst | 23 +++ 2 files changed, 24 insertions(+) create mode

[PATCH v5 5/6] test: Add sandbox TPM boot measurement

2023-02-02 Thread Eddie James
Use the sandbox TPM driver to measure some boot images in a unit test case. Signed-off-by: Eddie James Reviewed-by: Simon Glass --- Changes since v4: - Drop u8 casting in measurement test Changes since v2: - Changed reserved memory address to the top of the RAM for sandbox dts.

[PATCH v5 0/6] tpm: Support boot measurements

2023-02-02 Thread Eddie James
This series adds support for measuring the boot images more generically than the existing EFI support. Several EFI functions have been moved to the TPM layer. The series includes optional measurement from the bootm command. A new test case has been added for the bootm measurement to test the new

[PATCH v5 4/6] tpm: sandbox: Update for needed TPM2 capabilities

2023-02-02 Thread Eddie James
The driver needs to support getting the PCRs in the capabilities command. Fix various other things and support the max number of PCRs for TPM2. Signed-off-by: Eddie James Reviewed-by: Simon Glass Acked-by: Ilias Apalodimas --- drivers/tpm/tpm2_tis_sandbox.c | 100

[PATCH v5 3/6] bootm: Support boot measurement

2023-02-02 Thread Eddie James
Add a configuration option to measure the boot through the bootm function. Add the measurement state to the booti and bootz paths as well. Signed-off-by: Eddie James --- Changes since v4: - Change PCR indexes for initrd and dtb Changes since v2: - Add measure state to booti and bootz. - Skip

[PATCH v5 1/6] tpm: Fix spelling for tpmu_ha union

2023-02-02 Thread Eddie James
tmpu -> tpmu Signed-off-by: Eddie James Reviewed-by: Ilias Apalodimas --- include/tpm-v2.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/tpm-v2.h b/include/tpm-v2.h index 1c644f0048..84034c1559 100644 --- a/include/tpm-v2.h +++ b/include/tpm-v2.h @@ -167,7

Re: [PATCH v4 2/6] tpm: Support boot measurements

2023-02-02 Thread Eddie James
On 1/26/23 01:51, Ilias Apalodimas wrote: Hi Eddie, Thanks for the cleanup! Unfortunately this doesn't compile with EFI selected, but in general it looks pretty good. Thanks, yes I forgot to remove tcg2_pcr_read On Wed, Jan 25, 2023 at 11:18:06AM -0600, Eddie James wrote: Add TPM2

Re: [PATCH 1/1] README: remove 'U-Boot Porting Guide' section

2023-02-02 Thread Tom Rini
On Wed, Feb 01, 2023 at 01:20:52PM -0700, Simon Glass wrote: > Hi Heinrich, > > On Sun, 29 Jan 2023 at 15:37, Heinrich Schuchardt > wrote: > > > > > > > > On 1/28/23 23:01, Simon Glass wrote: > > > Hi Heinrich, > > > > > > On Thu, 26 Jan 2023 at 02:17, Heinrich Schuchardt > > > wrote: > > >> >

Re: [PATCH] drivers: usb: host: Fix the write to W1C fields in HPRT register

2023-02-02 Thread Marek Vasut
On 2/2/23 02:14, teik.heng.ch...@intel.com wrote: The subject tags are 'usb: dwc2:' . diff --git a/drivers/usb/host/dwc2.c b/drivers/usb/host/dwc2.c index 23060fc369..9818f9be94 100644 --- a/drivers/usb/host/dwc2.c +++ b/drivers/usb/host/dwc2.c @@ -315,9 +315,7 @@ static void

Re: [PATCH] RFC: nvedit: support doing one (extra) expansion of the value in "env set"

2023-02-02 Thread Rasmus Villemoes
On 14/02/2020 12.54, Rasmus Villemoes wrote: > > Assume BOOT_ORDER contains some permutation of "A B C", and for each > letter x, there's a BOOT_x_LEFT counter telling how many boot attempts > that slot has left. Now I want to find the first x in $BOOT_ORDER for > which $BOOT_x_LEFT is positive.

Re: [PATCH V4 01/14] env: Complete generic support for writable list

2023-02-02 Thread Marek Vasut
On 2/2/23 14:51, Jan Kiszka wrote: On 02.02.23 13:48, Marek Vasut wrote: On 2/2/23 09:07, Jan Kiszka wrote: From: Jan Kiszka This completes what 890feecaab72 started by selecting ENV_APPEND and loading the default env before any other sources. This ensures that load operations pick up all

Re: [PATCH v2] mtd: nand: Mark reserved blocks

2023-02-02 Thread Michal Simek
On 2/2/23 14:44, Michael Nazzareno Trimarchi wrote: Hi Il gio 2 feb 2023, 14:21 Michal Simek > ha scritto: Hi Dario, On 1/5/23 10:46, Ashok Reddy Soma wrote: > Reserved blocks are used for storing bad block tables. With "nand bad" > command,

Re: [RFC PATCH 05/16] clk: rockchip: Add rk3588 clk support

2023-02-02 Thread Eugen Hristev
On 1/26/23 00:27, Jagan Teki wrote: Add clock driver support for Rockchip RK3588 SoC. Signed-off-by: Elaine Zhang Signed-off-by: Jagan Teki --- drivers/clk/rockchip/Makefile |1 + drivers/clk/rockchip/clk_rk3588.c | 2019 + 2 files changed, 2020

Re: [RFC PATCH 11/16] arm64: dts: rockchip: Add base DT for rk3588 SoC

2023-02-02 Thread Eugen Hristev
On 1/26/23 00:27, Jagan Teki wrote: This initial version supports CPU, dma, interrupts, timers, UART and SDHCI (everything necessary to boot Linux on this system on chip) as well as Ethernet, I2C, PWM and SPI. The DT is split into rk3588 and rk3588s, which is a reduced version (i.e. with less

[PATCH v2] efi_loader: update attribute check for QueryVariableInfo()

2023-02-02 Thread Masahisa Kojima
Current U-Boot supports two EFI variable service, U-Boot own implementation and op-tee based StMM variable service. With ACS Security Interface Extension(SIE) v22.10_SIE_REL1.1.0, there are several failure items of QueryVariableInfo(). Current attribute check for QueryVariableInfo() was

Re: [PATCH V4 01/14] env: Complete generic support for writable list

2023-02-02 Thread Jan Kiszka
On 02.02.23 13:48, Marek Vasut wrote: > On 2/2/23 09:07, Jan Kiszka wrote: >> From: Jan Kiszka >> >> This completes what 890feecaab72 started by selecting ENV_APPEND and >> loading the default env before any other sources. This ensures that load >> operations pick up all non-writable vars from

Re: [PATCH v2] mtd: nand: Mark reserved blocks

2023-02-02 Thread Michael Nazzareno Trimarchi
Hi Il gio 2 feb 2023, 14:21 Michal Simek ha scritto: > Hi Dario, > > On 1/5/23 10:46, Ashok Reddy Soma wrote: > > Reserved blocks are used for storing bad block tables. With "nand bad" > > command, these reserved blocks are shown as bad blocks. This is leading > > to confusion when compared

RE: [PATCH 0/2] i2c: i2c-cdns.c: Update driver to read fifo-depth from device tree

2023-02-02 Thread WeiLiang Lim
Anyone can help review this patch please? > -Original Message- > From: PeiYue Ho > Sent: Wednesday, January 4, 2023 3:20 PM > To: u-boot@lists.denx.de > Cc: PeiYue Ho ; EngLee Teh > ; WeiLiang Lim > Subject: [PATCH 0/2] i2c: i2c-cdns.c: Update driver to read fifo-depth from > device

Re: [PATCH v2] mtd: nand: Mark reserved blocks

2023-02-02 Thread Michal Simek
Hi Dario, On 1/5/23 10:46, Ashok Reddy Soma wrote: Reserved blocks are used for storing bad block tables. With "nand bad" command, these reserved blocks are shown as bad blocks. This is leading to confusion when compared with Linux bad blocks. Hence, display "bbt reserved" when printing

Re: [PATCH v2 07/12] reset: uniphier: Add USB glue reset support

2023-02-02 Thread Marek Vasut
On 2/2/23 06:38, Kunihiko Hayashi wrote: Hi Marek, Hello Hayashi-san, On 2023/02/02 6:51, Marek Vasut wrote: On 2/1/23 02:13, Kunihiko Hayashi wrote: Add reset control support in USB glue logic. This needs to control the external clocks and resets for the logic before accessing the glue

Re: [PATCH v2 10/12] ARM: dts: uniphier: Fix node names and missing reg property in USB glue node

2023-02-02 Thread Marek Vasut
On 2/2/23 06:13, Kunihiko Hayashi wrote: Hi Marek, Hello Hayashi-san, On 2023/02/02 6:55, Marek Vasut wrote: On 2/1/23 02:13, Kunihiko Hayashi wrote: The node name should follow the generic name list in DT specification. This moves "reset" to "reset-controller", "hs-phy" and "ss-phy" to

Re: [PATCH v8 0/3] Timer support for ARM Tegra

2023-02-02 Thread Thierry Reding
On Wed, Feb 01, 2023 at 10:53:00AM +0200, Svyatoslav Ryhel wrote: > - ARM: tegra: remap clock_osc_freq for all Tegra family > Enum clock_osc_freq was designed to use only with T20. > This patch remaps it to use additional frequencies, added in > T30+ SoC while maintaining backwards compatibility

Re: [PATCH V4 01/14] env: Complete generic support for writable list

2023-02-02 Thread Marek Vasut
On 2/2/23 09:07, Jan Kiszka wrote: From: Jan Kiszka This completes what 890feecaab72 started by selecting ENV_APPEND and loading the default env before any other sources. This ensures that load operations pick up all non-writable vars from the default env and only permitted parts from other

Re: [PATCH v4] mtd: parsers: ofpart: add workaround for #size-cells 0

2023-02-02 Thread Francesco Dolcini
On Thu, Jan 26, 2023 at 10:12:04AM +0100, Miquel Raynal wrote: > gre...@linuxfoundation.org wrote on Thu, 26 Jan 2023 10:01:02 +0100: > > > On Wed, Jan 25, 2023 at 10:06:57PM +0100, Francesco Dolcini wrote: > > > Hello Miquel, Greg and all > > > > > > On Tue, Jan 24, 2023 at 04:38:59PM +0100,

Re: [PATCH] efi_loader: leave attribute check to StMM variable service

2023-02-02 Thread Masahisa Kojima
On Wed, 1 Feb 2023 at 18:32, Ilias Apalodimas wrote: > > Hi Kojima-san > > This looks correct when U-Boot is using StMM for the variable storage. > Since Arm claims that SCT document is outdated should we also fix the > default behavior? IOW U-Boot should return identical values when variables >

Re: [PATCH v2 15/17] android: boot: support boot image header version 3 and 4

2023-02-02 Thread Safae Ouajih
On 01/02/2023 09:44, Mattijs Korpershoek wrote: On Thu, Jan 26, 2023 at 17:55, Simon Glass wrote: Hi Safae, On Thu, 26 Jan 2023 at 09:05, Safae Ouajih wrote: This enables the support for boot image header version 3 and 4 using abootimg command. In order to use version 3 or 4: 1- Vendor

[PATCH 5/5] eficonfig: add error message of SetVariable

2023-02-02 Thread Masahisa Kojima
This commits add the error message when EFI Runtime Service SetVariable() failed. Signed-off-by: Masahisa Kojima --- cmd/eficonfig.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/cmd/eficonfig.c b/cmd/eficonfig.c index b0c8637676..c5cbf27631 100644

[PATCH 4/5] eficonfig: include EFI_STATUS string in error message

2023-02-02 Thread Masahisa Kojima
Current eficonfig_print_msg() does not show the return value of EFI Boot/Runtime Services when the service call fails. With this commit, user can know EFI_STATUS in the error message. Signed-off-by: Masahisa Kojima --- cmd/eficonfig.c | 95 +--

[PATCH 3/5] eficonfig: set EFICONFIG_ENTRY_NUM_MAX to INT_MAX - 1

2023-02-02 Thread Masahisa Kojima
eficonfig_append_menu_entryi() accepts the number of entries less than or equal to EFICONFIG_ENTRY_NUM_MAX. EFICONFIG_ENTRY_NUM_MAX is currently set as INT_MAX, so the invalid menu count check(efi_menu->count > EFICONFIG_ENTRY_NUM_MAX) in eficonfig_process_common() is always false. This commit

[PATCH 2/5] eficonfig: CTRL+S to save the boot order

2023-02-02 Thread Masahisa Kojima
The change boot order menu in eficonfig can have at most INT_MAX lines and it is troublesome to scroll down to the "Save" entry. This commit assigns CTRL+S to save the boot order. Signed-off-by: Masahisa Kojima --- cmd/eficonfig.c | 6 +- common/menu.c | 3 +++ include/menu.h | 1 + 3

[PATCH 1/5] menu: remove CTRL+C to quit

2023-02-02 Thread Masahisa Kojima
On the sandbox called without "--terminal raw" CTRL+C leaves U-Boot, "ESC/CTRL+C to quit" is misleading. Let's remove CTRL+C to quit key handling from bootmenu and eficonfig menu. Signed-off-by: Masahisa Kojima --- cmd/bootmenu.c | 2 +- cmd/eficonfig.c | 6 +++---

[PATCH 0/5] improve eficonfig usability

2023-02-02 Thread Masahisa Kojima
This series improves the eficonfig usability, enhances the error message and fixes the issue reported by coverity. Masahisa Kojima (5): menu: remove CTRL+C to quit eficonfig: CTRL+S to save the boot order eficonfig: set EFICONFIG_ENTRY_NUM_MAX to INT_MAX - 1 eficonfig: include EFI_STATUS

Re: [RFC PATCH 16/16] board: rockchip: Add Edgeble Neural Compute Module 6

2023-02-02 Thread Eugen Hristev
On 1/26/23 00:27, Jagan Teki wrote: Neural Compute Module 6(Neu2) is a 96boards SoM-CB compute module based on Rockchip RK3588 from Edgeble AI. General features: - Rockchip RK3588 - up to 32GB LPDDR4x - up to 128GB eMMC - 2x MIPI CSI2 FPC On module WiFi6/BT5 is available in the following Neu6

Re: [PATCH 1/1] efi_loader: stop watchdogs in ExitBootServices()

2023-02-02 Thread Etienne Carriere
Hello Heinrich and all, On Wed, 1 Feb 2023 at 10:00, Heinrich Schuchardt wrote: > > > > On 2/1/23 09:32, Rasmus Villemoes wrote: > > On 31/01/2023 16.07, Tom Rini wrote: > >> On Tue, Jan 31, 2023 at 02:03:10PM +0200, Ilias Apalodimas wrote: > >>> Hi all, > >>> > >>> On Mon, Jan 30, 2023 at

[PATCH V4 11/14] arm: dts: iot2050: Optionally embed OTP programming data into image

2023-02-02 Thread Jan Kiszka
From: Jan Kiszka Use external blob otpcmd.bin to replace the 0xff filled OTP programming command block to create a firmware image that provisions the OTP on first boot. This otpcmd.bin is generated from the customer keys using steps described in the meta-iot2050 integration layer for the device.

[PATCH V4 12/14] doc: iot2050: Add a note about the watchdog firmware

2023-02-02 Thread Jan Kiszka
From: Jan Kiszka This is enabled by default, thus should be described as well. Signed-off-by: Jan Kiszka --- doc/board/siemens/iot2050.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/board/siemens/iot2050.rst b/doc/board/siemens/iot2050.rst index cb49a0e36bf..efe94a448a9

[PATCH V4 05/14] arm: dts: iot2050: Use the auto generator nodes for fdt

2023-02-02 Thread Jan Kiszka
From: Su Baocheng Refactor according to the entry `fit: Entry containing a FIT` of document tools/binman/README.entries. As the generator uses the device tree name for the config description, board_fit_config_name_match requires a small adjustment as well. Signed-off-by: Su Baocheng [Jan:

[PATCH V4 14/14] iot2050: Refresh defconfigs and activate CONFIG_EFI_SCROLL_ON_CLEAR_SCREEN

2023-02-02 Thread Jan Kiszka
From: Jan Kiszka This feature is desired on the platform. Signed-off-by: Jan Kiszka --- configs/iot2050_pg1_defconfig | 6 +++--- configs/iot2050_pg2_defconfig | 7 +++ 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/configs/iot2050_pg1_defconfig

[PATCH V4 04/14] board: siemens: iot2050: Split the build for PG1 and PG2

2023-02-02 Thread Jan Kiszka
From: Su Baocheng Due to different signature keys, the PG1 and the PG2 boards can no longer use the same FSBL (tiboot3). This makes it impossible anyway to maintaine a single flash.bin for both variants, so we can also split the build. A new target is added to indicates the build is for PG1 vs.

[PATCH V4 03/14] tools: Add script for converting public key into device tree include

2023-02-02 Thread Jan Kiszka
From: Jan Kiszka Allows to create a public key device tree dtsi for inclusion into U-Boot SPL and proper during first build already. This can be achieved via CONFIG_DEVICE_TREE_INCLUDES. Signed-off-by: Jan Kiszka --- tools/key2dtsi.py | 64 +++ 1

  1   2   >