Re: [PATCH] board: stmark2: fix clock value

2023-02-06 Thread Angelo Dureghello
Hi Tom, a small issue, i cannot push on u-boot-coldfire Already on 'master' remote: remote: remote: remote: Your account has been blocked. remote: remote:

Re: [PATCH v2 036/169] Correct SPL uses of CMD_BOOTEFI_BOOTMGR

2023-02-06 Thread Heinrich Schuchardt
On 2/7/23 01:00, Tom Rini wrote: On Tue, Feb 07, 2023 at 12:54:03AM +0100, Heinrich Schuchardt wrote: On 2/6/23 01:53, Simon Glass wrote: This converts 3 usages of this option to the non-SPL form, since there is no SPL_CMD_BOOTEFI_BOOTMGR defined in Kconfig Signed-off-by: Simon Glass

Re: [PATCH 1/2] env: Complete generic support for writable list

2023-02-06 Thread Jan Kiszka
On 07.02.23 05:02, Simon Glass wrote: > Hi Jan, > > On Fri, 3 Feb 2023 at 05:23, Jan Kiszka wrote: >> >> From: Jan Kiszka >> >> This completes what 890feecaab72 started by selecting ENV_APPEND and >> loading the default env before any other sources. This ensures that load >> operations pick up

Re: [PATCH V5 07/12] tools: Add script for converting public key into device tree include

2023-02-06 Thread Jan Kiszka
On 07.02.23 05:02, Simon Glass wrote: > Hi Jan, > > On Mon, 6 Feb 2023 at 03:42, Jan Kiszka wrote: >> >> On 04.02.23 23:23, Simon Glass wrote: >>> Hi Jan, >>> >>> On Fri, 3 Feb 2023 at 23:35, Jan Kiszka wrote: On 04.02.23 01:20, Simon Glass wrote: > Hi Jan, > > On Fri, 3

RE: [PATCH] drivers: usb: host: Fix the write to W1C fields in HPRT register

2023-02-06 Thread Chong, Teik Heng
-Original Message- From: Marek Vasut Sent: Thursday, 2 February, 2023 11:16 PM To: Chong, Teik Heng ; u-boot@lists.denx.de Cc: Simon ; Chee, Tien Fong ; Hea, Kok Kiang ; Lim, Elly Siew Chin ; Kho, Sin Hui ; Lokanathan, Raaj ; Maniyam, Dinesh ; Ng, Boon Khai ; Yuslaimi, Alif Zakuan ;

Re: [PATCH v2 4/5] lib: sha256: Add support for hardware specific sha256_process

2023-02-06 Thread Simon Glass
Hi Loic, On Mon, 6 Feb 2023 at 15:12, Loic Poulain wrote: > > Hi Simon, > > Le lun. 6 févr. 2023 à 18:12, Simon Glass a écrit : >> >> Hi Loic, >> >> On Wed, 1 Jun 2022 at 12:27, Loic Poulain wrote: >> > >> > Mark sha256_process as weak to allow hardware specific implementation. >> > Add

Re: [PATCH v3 17/19] doc: android: add documentation for v3,v4 boot image header

2023-02-06 Thread Simon Glass
On Sun, 5 Feb 2023 at 16:50, Safae Ouajih wrote: > > Update the Android documentation to describe version 3 and 4 of boot > image header. > > Signed-off-by: Safae Ouajih > --- > doc/android/boot-image.rst | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) > Reviewed-by:

Re: Docs for RISC-V

2023-02-06 Thread Simon Glass
Hi Leo, On Mon, 6 Feb 2023 at 00:58, Leo Liang wrote: > > Hi Simon, > > On Thu, Feb 02, 2023 at 10:25:36AM -0700, Simon Glass wrote: > > Hi, > > > > On Thu, 2 Feb 2023 at 10:18, Simon Glass wrote: > > > > > > Hi Rick & Leo, > > > > > > I see docs for one board at [1] but I'm not sure what to do

Re: [PATCH v2 077/169] Correct SPL use of EFI_TCG2_PROTOCOL

2023-02-06 Thread Simon Glass
Hi Heinrich, On Mon, 6 Feb 2023 at 16:41, Heinrich Schuchardt wrote: > > > > On 2/5/23 23:39, Simon Glass wrote: > > This converts 1 usage of this option to the non-SPL form, since there is > > no SPL_EFI_TCG2_PROTOCOL defined in Kconfig > > Why do you touch the code? I can't see any problem

Re: [PATCH v3 06/19] android: boot: move to andr_image_data structure

2023-02-06 Thread Simon Glass
Hi Safae, On Sun, 5 Feb 2023 at 16:50, Safae Ouajih wrote: > > Move from andr_boot_img_hdr_v0 to andr_image_data > structure to prepare for boot image header > version 3 and 4. > Change log? > Signed-off-by: Safae Ouajih > --- > boot/image-android.c | 121

Re: [PATCH V5 07/12] tools: Add script for converting public key into device tree include

2023-02-06 Thread Simon Glass
Hi Jan, On Mon, 6 Feb 2023 at 03:42, Jan Kiszka wrote: > > On 04.02.23 23:23, Simon Glass wrote: > > Hi Jan, > > > > On Fri, 3 Feb 2023 at 23:35, Jan Kiszka wrote: > >> > >> On 04.02.23 01:20, Simon Glass wrote: > >>> Hi Jan, > >>> > >>> On Fri, 3 Feb 2023 at 05:29, Jan Kiszka wrote: > >

Re: [PATCH 3/8] blk: blkmap: Add basic infrastructure

2023-02-06 Thread Simon Glass
Hi Tobias, On Mon, 6 Feb 2023 at 01:30, Tobias Waldekranz wrote: > > On fre, feb 03, 2023 at 17:20, Simon Glass wrote: > > Hi Tobias, > > > > On Fri, 3 Feb 2023 at 02:38, Tobias Waldekranz > > wrote: > >> > >> On ons, feb 01, 2023 at 13:20, Simon Glass wrote: > >> > Hi Tobias, > >> > >> Hi

Re: [PATCH v1 6/6] sandbox64: add a test case for UCLASS_NVMXIP

2023-02-06 Thread Simon Glass
Hi, On Mon, 16 Jan 2023 at 10:29, wrote: > > From: Abdellatif El Khlifi > > provide a test for NVM XIP devices > > The test case allows to make sure of the following: > > - The NVM XIP QSPI devices are probed > - The DT entries are read correctly > - the data read from the flash by the NVMXIP

Re: [PATCH v2 1/2] cli: Correct several bugs in cli_getch()

2023-02-06 Thread Simon Glass
Hi Heinrich, On Mon, 6 Feb 2023 at 15:18, Heinrich Schuchardt wrote: > > On 2/6/23 18:12, Simon Glass wrote: > > Hi Heinrich, > > > > On Sun, 5 Feb 2023 at 14:29, Heinrich Schuchardt wrote: > >> > >> > >> > >> Am 5. Februar 2023 03:08:54 MEZ schrieb Simon Glass : > >>> This function does not

Re: [PATCH v2 2/2] bootstd: Replicate the dtb-filename quirks of distroboot

2023-02-06 Thread Simon Glass
On Mon, 30 Jan 2023 at 10:10, Tom Rini wrote: > > On Sat, Jan 28, 2023 at 06:27:15PM -0700, Simon Glass wrote: > > For EFI, the distro boot scripts search in three different directories > > for the .dtb file. The SOC-based filename fallback is supported only for > > 32-bit ARM. > > > > Adjust the

Re: [PATCH v3 09/19] android: boot: add vendor boot image to prepare for v3,v4 support

2023-02-06 Thread Simon Glass
On Sun, 5 Feb 2023 at 16:50, Safae Ouajih wrote: > > Introduce vendor boot image for version 3 and 4 of boot image header. > The vendor boot image will hold extra information about kernel, dtb > and ramdisk. > > This is done to prepare for boot image version 3 and 4 support. > > Signed-off-by:

Re: [PATCH 3/3] Revert "board: rockchip: Fix binman_init failure on EVB-RK3568"

2023-02-06 Thread Simon Glass
On Sun, 5 Feb 2023 at 13:21, Jonas Karlman wrote: > > This reverts commit 31500e7bcfaca08ab7c2879f502a6cf852410244. > > [why] > External TPL binary is now expected to be provided using EXTERNAL_TPL > when building RK356x targets. > > Signed-off-by: Jonas Karlman > --- >

Re: [PATCH v1 0/6] introduce NVM XIP block storage emulation

2023-02-06 Thread Simon Glass
Hi Abdellatif, On Mon, 6 Feb 2023 at 07:17, Abdellatif El Khlifi wrote: > > On Mon, Jan 16, 2023 at 05:28:26PM +, abdellatif.elkhl...@arm.com wrote: > > From: Abdellatif El Khlifi > > > > Adding block storage emulation for NVM XIP flash devices. > > > > Some paltforms such as Corstone-1000

Re: [PATCH 1/2] env: Complete generic support for writable list

2023-02-06 Thread Simon Glass
Hi Jan, On Fri, 3 Feb 2023 at 05:23, Jan Kiszka wrote: > > From: Jan Kiszka > > This completes what 890feecaab72 started by selecting ENV_APPEND and > loading the default env before any other sources. This ensures that load > operations pick up all non-writable vars from the default env and

Re: [PATCH v1 3/6] sandbox64: add support for NVMXIP QSPI

2023-02-06 Thread Simon Glass
On Mon, 16 Jan 2023 at 10:28, wrote: > > From: Abdellatif El Khlifi > > enable NVMXIP QSPI for sandbox 64-bit > > Adding two NVM XIP QSPI storage devices. > > Signed-off-by: Abdellatif El Khlifi > --- > arch/sandbox/dts/sandbox64.dts | 13 + > arch/sandbox/dts/test.dts | 14

Re: [PATCH 1/3] binman: Add support for an external-tpl entry

2023-02-06 Thread Simon Glass
Hi Jonas, On Sun, 5 Feb 2023 at 13:21, Jonas Karlman wrote: > > The external-tpl entry can be used when an external TPL binary must be > used instead of normal U-Boot TPL. > > Signed-off-by: Jonas Karlman > --- > tools/binman/entries.rst | 12 >

Re: [PATCH 2/3] rockchip: Require an external TPL binary when TPL is missing

2023-02-06 Thread Simon Glass
Hi Jonas, On Sun, 5 Feb 2023 at 13:21, Jonas Karlman wrote: > > Rockchip SoCs typically use U-Boot TPL to initialize DRAM, then jumps > back to boot-rom to load the next stage of the boot flow, U-Boot SPL. > > For RK356x there is currently no support to initialize DRAM using U-Boot > TPL and

Re: [PATCH 0/3] rockchip: Use external TPL binary to create a working firmware image

2023-02-06 Thread Simon Glass
Hi Jonas, On Sun, 5 Feb 2023 at 13:21, Jonas Karlman wrote: > > Rockchip SoCs typically use U-Boot TPL to initialize DRAM, then jumps > back to boot-rom to load the next stage of the boot flow, U-Boot SPL. > > For RK356x there is currently no support to initialize DRAM using U-Boot > TPL and

Re: [PATCH 1/1] rockchip: rk3568: Add Radxa Rock Pi 3A board support

2023-02-06 Thread FUKAUMI Naoki
sorry, few more corrections... On 2/7/23 10:07, FUKAUMI Naoki wrote: hi thank you very much for your work! On 2/7/23 02:56, Akash Gajjar wrote: Add Radxa Rock Pi 3A support. "ROCK 3 Model A" or "ROCK 3A". uppercase "ROCK", no "Pi" please. > sync rk3568-rock-3a.dts from Linux 6.2.0-rc7 it

Re: [PATCH 1/1] rockchip: rk3568: Add Radxa Rock Pi 3A board support

2023-02-06 Thread FUKAUMI Naoki
hi thank you very much for your work! On 2/7/23 02:56, Akash Gajjar wrote: Add Radxa Rock Pi 3A support. "ROCK 3 Model A" or "ROCK 3A". uppercase "ROCK", no "Pi" please. > sync rk3568-rock-3a.dts from Linux 6.2.0-rc7 it seems several parts of dts are omitted. why? Board Specification -

Re: [PATCH v2 078/169] Correct SPL use of EFI_UNICODE_COLLATION_PROTOCOL2

2023-02-06 Thread Tom Rini
On Tue, Feb 07, 2023 at 02:24:22AM +0100, Heinrich Schuchardt wrote: > > > On 2/7/23 00:38, Tom Rini wrote: > > On Tue, Feb 07, 2023 at 12:36:51AM +0100, Heinrich Schuchardt wrote: > > > On 2/5/23 23:39, Simon Glass wrote: > > > > This converts 1 usage of this option to the non-SPL form, since

Re: [PATCH v2 078/169] Correct SPL use of EFI_UNICODE_COLLATION_PROTOCOL2

2023-02-06 Thread Heinrich Schuchardt
On 2/7/23 00:38, Tom Rini wrote: On Tue, Feb 07, 2023 at 12:36:51AM +0100, Heinrich Schuchardt wrote: On 2/5/23 23:39, Simon Glass wrote: This converts 1 usage of this option to the non-SPL form, since there is no SPL_EFI_UNICODE_COLLATION_PROTOCOL2 defined in Kconfig Signed-off-by: Simon

[RESEND PATCH v2] arm: mvebu: Power up 2nd SATA port for Thecus N2350

2023-02-06 Thread Tony Dinh
Currently, only the 1st SATA port is powered up (by GPIO1 12). Add GPIO1 13 in board initialization to power up the 2nd SATA port. Note that this patch depends on the initial add-support patch: https://patchwork.ozlabs.org/project/uboot/patch/20230201231306.7010-1-mibo...@gmail.com/

Re: [PATCH v4 2/6] tpm: Support boot measurements

2023-02-06 Thread Simon Glass
Hi Eddie, On Thu, 2 Feb 2023 at 10:18, Eddie James wrote: > > > On 2/2/23 11:12, Simon Glass wrote: > > Hi Eddie / Ilias, > > > > On Thu, 2 Feb 2023 at 09:24, Eddie James wrote: > >> > >> On 1/26/23 01:51, Ilias Apalodimas wrote: > >>> Hi Eddie, > >>> > >>> Thanks for the cleanup! Unfortunately

Re: [PATCH] arm: mvebu: Power up 2nd SATA port for Thecus N2350

2023-02-06 Thread Tony Dinh
Hi Stefan, Looks like I botched this V2 patch :) I will resend it. Thanks, Tony On Sun, Feb 5, 2023 at 1:29 PM Tony Dinh wrote: > > Currently, only the 1st SATA port is powered up (by GPIO1 12). > Add GPIO1 13 in board initialization to power up the 2nd SATA port. > > Note that this patch

Re: [PATCH v2 036/169] Correct SPL uses of CMD_BOOTEFI_BOOTMGR

2023-02-06 Thread Tom Rini
On Tue, Feb 07, 2023 at 12:54:03AM +0100, Heinrich Schuchardt wrote: > > > On 2/6/23 01:53, Simon Glass wrote: > > This converts 3 usages of this option to the non-SPL form, since there is > > no SPL_CMD_BOOTEFI_BOOTMGR defined in Kconfig > > > > Signed-off-by: Simon Glass > > --- > > > > (no

Re: [PATCH v2 075/169] Correct SPL use of EFI_MM_COMM_TEE

2023-02-06 Thread Heinrich Schuchardt
On 2/6/23 01:54, Simon Glass wrote: This converts 1 usage of this option to the non-SPL form, since there is no SPL_EFI_MM_COMM_TEE defined in Kconfig Signed-off-by: Simon Glass --- (no changes since v1) cmd/eficonfig.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] schemas: Add schema for firmware logs

2023-02-06 Thread Simon Glass
Hi Rob, On Mon, 6 Feb 2023 at 16:32, Rob Herring wrote: > > +boot-architecture > > On Mon, Feb 6, 2023 at 3:25 PM Simon Glass wrote: > > > > Hi Rob, > > > > On Mon, 6 Feb 2023 at 10:15, Rob Herring wrote: > > > > > > On Sat, Feb 4, 2023 at 6:04 AM Simon Glass wrote: > > > > > > > > Hi Peter,

Re: [PATCH v2 036/169] Correct SPL uses of CMD_BOOTEFI_BOOTMGR

2023-02-06 Thread Heinrich Schuchardt
On 2/6/23 01:53, Simon Glass wrote: This converts 3 usages of this option to the non-SPL form, since there is no SPL_CMD_BOOTEFI_BOOTMGR defined in Kconfig Signed-off-by: Simon Glass --- (no changes since v1) boot/Makefile | 2 +- cmd/bootmenu.c | 4 ++-- 2 files changed, 3

Re: [PATCH v2 077/169] Correct SPL use of EFI_TCG2_PROTOCOL

2023-02-06 Thread Heinrich Schuchardt
On 2/5/23 23:39, Simon Glass wrote: This converts 1 usage of this option to the non-SPL form, since there is no SPL_EFI_TCG2_PROTOCOL defined in Kconfig Why do you touch the code? I can't see any problem being solved. Best regards Heinrich Signed-off-by: Simon Glass --- (no changes

Re: [PATCH v2 078/169] Correct SPL use of EFI_UNICODE_COLLATION_PROTOCOL2

2023-02-06 Thread Tom Rini
On Tue, Feb 07, 2023 at 12:36:51AM +0100, Heinrich Schuchardt wrote: > On 2/5/23 23:39, Simon Glass wrote: > > This converts 1 usage of this option to the non-SPL form, since there is > > no SPL_EFI_UNICODE_COLLATION_PROTOCOL2 defined in Kconfig > > > > Signed-off-by: Simon Glass > > --- > > >

Re: [PATCH v2 078/169] Correct SPL use of EFI_UNICODE_COLLATION_PROTOCOL2

2023-02-06 Thread Heinrich Schuchardt
On 2/5/23 23:39, Simon Glass wrote: This converts 1 usage of this option to the non-SPL form, since there is no SPL_EFI_UNICODE_COLLATION_PROTOCOL2 defined in Kconfig Signed-off-by: Simon Glass --- (no changes since v1) lib/efi_loader/efi_root_node.c | 2 +- 1 file changed, 1

Re: [PATCH] schemas: Add schema for firmware logs

2023-02-06 Thread Rob Herring
+boot-architecture On Mon, Feb 6, 2023 at 3:25 PM Simon Glass wrote: > > Hi Rob, > > On Mon, 6 Feb 2023 at 10:15, Rob Herring wrote: > > > > On Sat, Feb 4, 2023 at 6:04 AM Simon Glass wrote: > > > > > > Hi Peter, > > > > > > On Sat, 4 Feb 2023 at 02:36, Peter Robinson wrote: > > > > > > > >

Re: [PATCH v2 1/3] fdt: validate/fix cells count on mtdpart fixup

2023-02-06 Thread Tom Rini
On Mon, Feb 06, 2023 at 11:48:36PM +0100, Francesco Dolcini wrote: > From: Francesco Dolcini > > Fixup #size-cells value when updating the MTD partitions, this is > required to prevent issues in case the MTD parent set #size-cells to > zero. > This could happen for example in the legacy case in

[PATCH v2 3/3] colibri-imx6ull: specify MTD partitions on command line

2023-02-06 Thread Francesco Dolcini
From: Francesco Dolcini Disable fdt_fixup_mtdparts() and pass MTD partition on the command line. Dynamically editing the fdt with a static partitions configuration is not required and there is no advantages compared to using the command line. This change should prevent boot failures as the one

[PATCH v2 2/3] colibri-imx7: specify MTD partitions on command line

2023-02-06 Thread Francesco Dolcini
From: Francesco Dolcini Disable fdt_fixup_mtdparts() and pass MTD partition on the command line. Dynamically editing the fdt with a static partitions configuration is not required and there is no advantages compared to using the command line. This change should prevent boot failures as the one

[PATCH v2 1/3] fdt: validate/fix cells count on mtdpart fixup

2023-02-06 Thread Francesco Dolcini
From: Francesco Dolcini Fixup #size-cells value when updating the MTD partitions, this is required to prevent issues in case the MTD parent set #size-cells to zero. This could happen for example in the legacy case in which the partitions are created as direct child of the mtd node and that

[PATCH v2 0/3] fdt: Fix mtparts fixup

2023-02-06 Thread Francesco Dolcini
From: Francesco Dolcini Recently we had a boot regression on colibri-imx7 because of a cleanup change on Linux imx7.dtsi setting nand controller node #size-cells from 1 to 0. Because of that Linux partition parser was no longer able to properly parse the OF partitions leading to a boot failure,

[PATCH v2] arm: mvebu: Power up 2nd SATA port for Thecus N2350

2023-02-06 Thread Tony Dinh
Currently, only the 1st SATA port is powered up (by GPIO1 12). Add GPIO1 13 in board initialization to power up the 2nd SATA port. Note that this patch depends on the initial add-support patch: https://patchwork.ozlabs.org/project/uboot/patch/20230201231306.7010-1-mibo...@gmail.com/

Re: [PATCH v2 1/2] cli: Correct several bugs in cli_getch()

2023-02-06 Thread Heinrich Schuchardt
On 2/6/23 18:12, Simon Glass wrote: Hi Heinrich, On Sun, 5 Feb 2023 at 14:29, Heinrich Schuchardt wrote: Am 5. Februar 2023 03:08:54 MEZ schrieb Simon Glass : This function does not behave as expected when unknown escape sequences are sent to it: - it fails to store (and thus echo) the

Re: [PATCH v2 4/5] lib: sha256: Add support for hardware specific sha256_process

2023-02-06 Thread Loic Poulain
Hi Simon, Le lun. 6 févr. 2023 à 18:12, Simon Glass a écrit : > Hi Loic, > > On Wed, 1 Jun 2022 at 12:27, Loic Poulain wrote: > > > > Mark sha256_process as weak to allow hardware specific implementation. > > Add parameter for supporting multiple blocks processing. > > > > Signed-off-by: Loic

Re: [PATCH] board: stmark2: fix clock value

2023-02-06 Thread Angelo Dureghello
Hi Tom, On 06/02/23 23:03, Tom Rini wrote: On Mon, Feb 06, 2023 at 11:01:04PM +0100, Angelo Dureghello wrote: Fix totally blank console at boot, clock value must be decimal, as for the 30Mhz external crystal. Signed-off-by: Angelo Dureghello Fixes: 26e5944ec90c ("stmark2: Migrate

Re: [PATCH] board: stmark2: fix clock value

2023-02-06 Thread Tom Rini
On Mon, Feb 06, 2023 at 11:01:04PM +0100, Angelo Dureghello wrote: > Fix totally blank console at boot, clock value must be decimal, > as for the 30Mhz external crystal. > > Signed-off-by: Angelo Dureghello Fixes: 26e5944ec90c ("stmark2: Migrate CONFIG_SYS_EXTRA_OPTIONS to Kconfig")

Re: [PATCHv4 0/5] FWU: Handle meta-data in common code

2023-02-06 Thread Simon Glass
Hi, On Sat, 4 Feb 2023 at 20:01, wrote: > > From: Jassi Brar > > The patchset reduces ~400 lines of code, while keeping the functionality same > and making > meta-data operations much faster (by using cached structures). > > Issue: > meta-data copies (primary and secondary) are being handled

[PATCH] board: stmark2: fix clock value

2023-02-06 Thread Angelo Dureghello
Fix totally blank console at boot, clock value must be decimal, as for the 30Mhz external crystal. Signed-off-by: Angelo Dureghello --- board/sysam/stmark2/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/board/sysam/stmark2/Kconfig b/board/sysam/stmark2/Kconfig index

Re: [PATCH u-boot 2/2] tools: default_image: Accept images with padding

2023-02-06 Thread Simon Glass
Hi Tom, On Mon, 6 Feb 2023 at 12:43, Tom Rini wrote: > > On Sun, Jan 29, 2023 at 05:44:11PM +0100, Pali Rohár wrote: > > > If image file is stored on flash partition then it contains padding, which > > is not part of the image itself. Image data size is stored in the image > > header. So use

Re: [PATCH u-boot 2/2] tools: default_image: Accept images with padding

2023-02-06 Thread Pali Rohár
On Monday 06 February 2023 14:43:07 Tom Rini wrote: > On Sun, Jan 29, 2023 at 05:44:11PM +0100, Pali Rohár wrote: > > > If image file is stored on flash partition then it contains padding, which > > is not part of the image itself. Image data size is stored in the image > > header. So use image

Re: [PATCH] schemas: Add schema for firmware logs

2023-02-06 Thread Simon Glass
Hi Rob, On Mon, 6 Feb 2023 at 10:15, Rob Herring wrote: > > On Sat, Feb 4, 2023 at 6:04 AM Simon Glass wrote: > > > > Hi Peter, > > > > On Sat, 4 Feb 2023 at 02:36, Peter Robinson wrote: > > > > > > Hi Simon, > > > > > > Does it make sense to devise something that is compatible with the > > >

Re: [PATCH] arm: mvebu: Power up 2nd SATA port for Thecus N2350

2023-02-06 Thread Tony Dinh
Hi Stefan, On Mon, Feb 6, 2023 at 2:01 AM Stefan Roese wrote: > > Hi Tony, > > On 2/5/23 22:28, Tony Dinh wrote: > > Currently, only the 1st SATA port is powered up (by GPIO1 12). > > Add GPIO1 13 in board initialization to power up the 2nd SATA port. > > > > Note that this patch depends on the

Re: [PATCH u-boot 2/2] tools: default_image: Accept images with padding

2023-02-06 Thread Tom Rini
On Sun, Jan 29, 2023 at 05:44:11PM +0100, Pali Rohár wrote: > If image file is stored on flash partition then it contains padding, which > is not part of the image itself. Image data size is stored in the image > header. So use image size from the header instead of expecting that total > image

[PATCH v3 19/81] rockchip: Add a Kconfig for SPL_RESET_ROCKCHIP

2023-02-06 Thread Simon Glass
This is implicitly used in the source and seems useful, so add it. Signed-off-by: Simon Glass --- (no changes since v1) drivers/reset/Kconfig | 4 1 file changed, 4 insertions(+) diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig index e4039d74744..e2affe20e34 100644 ---

[PATCH v3 16/81] virtio: Add a Kconfig for SPL_VIRTIO

2023-02-06 Thread Simon Glass
This is implicitly used in the source and seems useful, so add it. Signed-off-by: Simon Glass --- (no changes since v1) drivers/virtio/Kconfig | 4 1 file changed, 4 insertions(+) diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig index 852f6735b60..410cdf39b67 100644 ---

[PATCH v3 15/81] pinctrl: Add a Kconfig for SPL_PINCTRL_ARMADA_38X

2023-02-06 Thread Simon Glass
This is implicitly used in the source and seems useful, so add it. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Correct the tag drivers/pinctrl/mvebu/Kconfig | 4 1 file changed, 4 insertions(+) diff --git a/drivers/pinctrl/mvebu/Kconfig

[PATCH v3 22/81] efi: Add a Kconfig for SPL_EFI_LOADER et al

2023-02-06 Thread Simon Glass
This and EFI_DEVICE_PATH_TO_TEXT are implicitly used in the source and seem useful, so add them. Signed-off-by: Simon Glass --- Changes in v3: - Move SPL_EFI_LOADER patch to this series lib/efi_loader/Kconfig | 8 1 file changed, 8 insertions(+) diff --git a/lib/efi_loader/Kconfig

[PATCH v3 72/81] kconfig: Adjust the meaning of CONFIG_IS_ENABLED()

2023-02-06 Thread Simon Glass
Adjust this to require the CONFIG option be provided, so that instead of: CONFIG_IS_ENABLED(FOO) you must write: CONFIG_IS_ENABLED(CONFIG_FOO) This is in preparation for dropping this and just using it is as the new implementation of IS_ENABLED(). For now, update IS_ENABLED() to use

[PATCH v3 09/81] boot: Add a Kconfig for SPL_OF_LIVE

2023-02-06 Thread Simon Glass
This is implicitly used in the source and seems useful, so add it. Signed-off-by: Simon Glass --- (no changes since v1) dts/Kconfig | 4 1 file changed, 4 insertions(+) diff --git a/dts/Kconfig b/dts/Kconfig index 44cc6bf1f6f..bb63eda9c40 100644 --- a/dts/Kconfig +++ b/dts/Kconfig @@

[PATCH v3 47/81] kconfig: Refactor code into separate writer functions

2023-02-06 Thread Simon Glass
Separate out the code that writes the Makefile and headers so we can reuse these functions when writing out SPL files. This makes no functional change. Signed-off-by: Simon Glass --- (no changes since v1) scripts/kconfig/confdata.c | 65 ++

[PATCH v3 81/81] Makefile: Drop SPL_ and SPL_TPL_ macros

2023-02-06 Thread Simon Glass
These are not needed anymore with split configs. Drop them. This also drops an incorrect $(SPL_TPL) in arch/powerpc/lib/Makefile Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Reworked based on earlier patches - Move patches from splb which add new Kconfig options

[PATCH v3 73/81] kconfig: Drop CONFIG_IF_ENABLED_INT()

2023-02-06 Thread Simon Glass
We can use IF_ENABLED_INT() instead, so drop the other macro. Also clean up a few things left behind and fix the comment. Signed-off-by: Simon Glass --- (no changes since v1) include/linux/kconfig.h | 32 ++-- test/lib/kconfig.c| 15

[PATCH v3 79/81] kconfig: Move closer to the Linux version

2023-02-06 Thread Simon Glass
This header file originally came from Linux and it has changed a little upstream since. Bring in some of these changes. Note that IS_ENABLED() in U-Boot supports a three-parameter version, so it not equivalent to the Linux version. Signed-off-by: Simon Glass --- (no changes since v1)

[PATCH v3 68/81] command: Don't allow commands in SPL

2023-02-06 Thread Simon Glass
At present we compile commands into U-Boot SPL even though they cannot be used. This wastes space. Adjust the condition to avoid this. Signed-off-by: Simon Glass --- Changes in v3: - Add a new patch to disallow commands in SPL include/command.h | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v3 70/81] Makefile: Use empty SPL_ and SPL_TPL_ vars

2023-02-06 Thread Simon Glass
Now that we include an auto.conf file specific to the phase being built we can make these variables empty. With this done, we can also remove them from U-Boot entirely, dropping them from all Makefiles. That is left for a future clean-up since we cannot apply this series until CONFIG migration is

[PATCH v3 78/81] fixdep: Drop support for CONFIG_IS_ENABLED and CONFIG_VAL

2023-02-06 Thread Simon Glass
Signed-off-by: Simon Glass --- (no changes since v1) scripts/basic/fixdep.c | 19 --- 1 file changed, 19 deletions(-) diff --git a/scripts/basic/fixdep.c b/scripts/basic/fixdep.c index 1cb76dc8b19..08556ef663f 100644 --- a/scripts/basic/fixdep.c +++ b/scripts/basic/fixdep.c @@

[PATCH v3 76/81] kconfig: Drop CONFIG_VAL()

2023-02-06 Thread Simon Glass
This serves no purpose now since we can write CONFIG_FOO instead of CONFIG_VAL(FOO) Drop it. Signed-off-by: Simon Glass --- (no changes since v1) arch/arm/lib/bdinfo.c | 4 +- arch/arm/mach-at91/arm926ejs/eflash.c | 4 +- arch/arm/mach-k3/am654_init.c

[PATCH v3 66/81] power: wanderboard: Correct conditions for split config

2023-02-06 Thread Simon Glass
This currently causes a build error with wanderboard. Fix it by adding a missing CONFIG and correcting the build condition so that it does not change when building SPL. Signed-off-by: Simon Glass --- (no changes since v1) configs/wandboard_defconfig | 1 + include/power/pmic.h| 3 +--

[PATCH v3 63/81] x86: Fix monitor base for split config

2023-02-06 Thread Simon Glass
This currently makes SPL refer to its own address. Use the PPL symbol to avoid this. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/cpu/intel_common/car2.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/cpu/intel_common/car2.S

[PATCH v3 64/81] dm: Add a TPL symbol for simple-bus

2023-02-06 Thread Simon Glass
This is used in some x86 code, so add a symbol for it. Signed-off-by: Simon Glass --- (no changes since v1) drivers/core/Kconfig | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/core/Kconfig b/drivers/core/Kconfig index f1ef5cd35f3..ae4f184b93f 100644 ---

[PATCH v3 60/81] freescale: Fix odd use of ESDHCI_QUIRK_BROKEN_TIMEOUT_VALUE

2023-02-06 Thread Simon Glass
This is not a CONFIG option so we should not be using IS_ENABLED() on it, particularly not when it is not defined to anything, so shows up as calling IS_ENABLED() with no arguments. Just check it normally. This fixes a build error with split config on T2080QDS. Signed-off-by: Simon Glass ---

[PATCH v3 59/81] net: Add an SPL config for atheros

2023-02-06 Thread Simon Glass
Add a new SPL_PHY_ATHEROS to avoid a build error on am335x_evm with split config. Signed-off-by: Simon Glass --- (no changes since v1) drivers/net/phy/Kconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig index

[PATCH v3 80/81] checkpatch: Remove unwanted CONFIG_IS_ENABLED rules

2023-02-06 Thread Simon Glass
These are not relevant anymore so drop them. Signed-off-by: Simon Glass Suggested-by: Tom Rini --- (no changes since v1) scripts/checkpatch.pl | 16 tools/patman/test_checkpatch.py | 6 -- 2 files changed, 22 deletions(-) diff --git a/scripts/checkpatch.pl

[PATCH v3 77/81] Makefile: Clean up an unnecessary Makefile piece

2023-02-06 Thread Simon Glass
Now that CONFIG_IS_ENABLED() is gone, we can drop this. Signed-off-by: Simon Glass --- (no changes since v1) scripts/Makefile.autoconf | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/scripts/Makefile.autoconf b/scripts/Makefile.autoconf index

[PATCH v3 57/81] freescale: Drop old pre-DM_ETH code

2023-02-06 Thread Simon Glass
This is used by ls1021atwr_sdcard_ifc_SECURE_BOOT with split config, but is not needed anymore, since Ethernet migration is complete. Drop it. Signed-off-by: Simon Glass --- (no changes since v1) arch/arm/cpu/armv7/ls102xa/fdt.c | 12 1 file changed, 12 deletions(-) diff --git

[PATCH v3 54/81] imx: watchdog: Correct watchdog error condition

2023-02-06 Thread Simon Glass
This is intended to make sure that one of the conditions is met, but causes a build error with imx6qdl_icore_mmc. Fix it by using the PPL condition instead, so that nothing changes when building for SPL with split config. In fact we should drop the old watchdog code and just use the new watchdog

[PATCH v3 75/81] kconfig: drop config_opt_enabled()

2023-02-06 Thread Simon Glass
This is include used in three places. It does not appear in Linux. Use IS_ENABLED() instead since it provides a similar feature, albeit needing brackets. Signed-off-by: Simon Glass --- (no changes since v1) drivers/fastboot/fb_command.c | 12 ++-- drivers/fastboot/fb_common.c | 4

[PATCH v3 74/81] kconfig: Drop CONFIG_IS_ENABLED()

2023-02-06 Thread Simon Glass
We can use IS_ENABLED() now, so drop the CONFIG_IS_ENABLED() macro. Also drop a comment that mentions it. Signed-off-by: Simon Glass --- Changes in v3: - Drop a comment which mentions CONFIG_IS_ENABLED() drivers/serial/ns16550.c | 1 - include/linux/kconfig.h | 23 --- 2

[PATCH v3 53/81] freescale: pm9g45: Fix problems with ls1021aqds_nand et al

2023-02-06 Thread Simon Glass
These boards need to access the 'proper' symbol for NAND_BOOT, to avoid build errors in SPL. Fix this up. Also fix pm9g45 which has the same problem. Drop the unnecessary condition in fdt_support.h to avoid needing to do something clever there too. Signed-off-by: Simon Glass --- (no changes

[PATCH v3 51/81] Add VPL options for BLOBLIST

2023-02-06 Thread Simon Glass
We can use this feature in VPL, so add some options for it. Also fix a typo in the SPL help while we are here. Signed-off-by: Simon Glass --- (no changes since v1) common/Kconfig | 31 ++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/common/Kconfig

[PATCH v3 69/81] Makefile: Include the config for the phase being built

2023-02-06 Thread Simon Glass
At present there is only a single auto.conf file used within the makefiles. Update them to use the correct one for each phase. Also update kconfig.h to include the correct autoconf.h or autoconf_spl.h file for each phase. This allows the macros to be simplified. With this, CONFIG_IS_ENABLED() is

[PATCH v3 45/81] test: Tidy up sandbox handling in test-main

2023-02-06 Thread Simon Glass
This is pretty messy at present since it relies on a SPL_SANDBOX option that does not exist. Use the normal options instead, so that it will work with split config. Signed-off-by: Simon Glass --- (no changes since v1) test/test-main.c | 10 +- 1 file changed, 5 insertions(+), 5

[PATCH v3 67/81] venice: Simplify conditions for network init

2023-02-06 Thread Simon Glass
The conditions in this code do not align when doing an SPL build with split config. Use __maybe_unused to avoid needing to be so explicit. Of course a better solution would be to refactor all of this to avoid using #ifdef. Signed-off-by: Simon Glass --- (no changes since v1)

[PATCH v3 65/81] x86: coral: Avoid build errors with missing SPL symbols

2023-02-06 Thread Simon Glass
With split config this does not build due to the missing symbols. Add them and fix the PCI condition. Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/cpu/Makefile | 2 +- configs/chromebook_coral_defconfig | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-)

[PATCH v3 49/81] Rename CONFIG_TEXT_BASE

2023-02-06 Thread Simon Glass
This means the text base for U-Boot proper. With split config it will mean something different in SPL (CONFIG_SPL_TEXT_BASE), so use the PPL prefix to avoid any problems. Signed-off-by: Simon Glass --- (no changes since v1) Makefile | 26

[PATCH v3 62/81] pci: Use the correct symbol to enable struct members

2023-02-06 Thread Simon Glass
This ends up being quite complicated since we have various pieces of code assuming that it can access the members and the conditions may not line up with SPL_PCI and serial SPL_ configs. Fix it by using a PPL condition, so that the condition does not change when split config is enabled.

[PATCH v3 61/81] serial: Support ns16550 driver in TPL

2023-02-06 Thread Simon Glass
Add options for this since they are needed by P1020RDB-PC_NAND. Signed-off-by: Simon Glass --- (no changes since v1) drivers/serial/Kconfig | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig index bb5083201b3..6f40c051604 100644 ---

[PATCH v3 56/81] rockchip: Avoid checking environment without ENV_SUPPORT

2023-02-06 Thread Simon Glass
With split config, this causes a build error in SPL where the environment may not be enabled. It affects two rk3399 boards. Add a condition. Signed-off-by: Simon Glass --- (no changes since v1) board/theobroma-systems/puma_rk3399/puma-rk3399.c | 2 +-

[PATCH v3 58/81] imx: Use SATA instead of CMD_SATA

2023-02-06 Thread Simon Glass
This causes a build failure on mx6cuboxi with split config, since CMD_SATA shows up as enabled in SPl (because there is no SPL_CMD_SATA). The condition is wrong anyway, so change it to use SATA instead. Signed-off-by: Simon Glass --- (no changes since v1) board/solidrun/mx6cuboxi/mx6cuboxi.c

[PATCH v3 32/81] boot: Add a Kconfig for SPL_AVB_VERIFY

2023-02-06 Thread Simon Glass
This is implicitly used in the source and seems useful, so add it. Signed-off-by: Simon Glass --- (no changes since v1) common/Kconfig | 4 1 file changed, 4 insertions(+) diff --git a/common/Kconfig b/common/Kconfig index 14a40d8b4ea..4f22ce4edcd 100644 --- a/common/Kconfig +++

[PATCH v3 55/81] socfpga: Use the correct condition for SYS_L2_PL310

2023-02-06 Thread Simon Glass
Update this to use the PPL condition instead, so that nothing changes when building for SPL with split config. Signed-off-by: Simon Glass --- (no changes since v1) arch/arm/mach-socfpga/misc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-socfpga/misc.c

[PATCH v3 52/81] omap: Correct an SPL build error with watchdog

2023-02-06 Thread Simon Glass
The logic here is strange since the call to hw_watchdog_init() depends on CONFIG_HW_WATCHDOG || CONFIG_WATCHDOG but the code it calls is only enabled if !CONFIG_IS_ENABLED(WDT). This seems to work, but with split config we get a build error in SPL with CONFIG_WATCHDOG, since it is interpreted as

[PATCH v3 48/81] kconfig: Support writing separate SPL files

2023-02-06 Thread Simon Glass
At present kconfig writes out several files, including: auto.conf - CONFIG settings used by make autoconf.h - header file used by C code This works well but is a bit ugly in places, for example requiring the use of a SPL_TPL_ macro in Makefiles to distinguish between options intended for

[PATCH v3 42/81] fixdep: Add some tests for parse_config_line()

2023-02-06 Thread Simon Glass
Add tests for this code to cover the basic cases. Signed-off-by: Simon Glass --- (no changes since v1) scripts/basic/fixdep.c | 73 ++ 1 file changed, 73 insertions(+) diff --git a/scripts/basic/fixdep.c b/scripts/basic/fixdep.c index

[PATCH v3 50/81] x86: Fix up some Kconfig options

2023-02-06 Thread Simon Glass
There are a few inconsistencies in various options on x86. Fix these up so that conversion to a split config is possible: - use Proper config in irq, timer and environment - drop the invalid SPL_ in a CONFIG_IS_ENABLED() usage - use the correct X86_64 option in msr.h Signed-off-by: Simon Glass

[PATCH v3 38/81] sandbox: Use the generic VPL option to enable VPL

2023-02-06 Thread Simon Glass
Avoid using CONFIG_SANDBOX_VPL since we have a generic option which works just as well. Signed-off-by: Simon Glass --- (no changes since v1) arch/sandbox/dts/sandbox.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/sandbox/dts/sandbox.dts

[PATCH v3 46/81] kconfig: Add a configuration file for nospl

2023-02-06 Thread Simon Glass
This file indicates which options are not for use in U-Boot SPL. It allows the kconfig tool to correctly generate its output. It was generated with ./tools/move_config.py --scan-source -u Note that this only produces sensible results when used with the current source code, as of this patch.

[PATCH v3 41/81] fixdep: Refactor to make testing easier

2023-02-06 Thread Simon Glass
Move the config parsing into a separate function so that it is possible to write tests for the function. Signed-off-by: Simon Glass --- (no changes since v1) scripts/basic/fixdep.c | 87 ++ 1 file changed, 54 insertions(+), 33 deletions(-) diff --git

  1   2   >