Re: [PATCH] dm: adc: add iMX93 ADC support

Hi Luca, On Tue, Feb 21, 2023 at 9:55 AM Luca Ellero wrote: > +int imx93_adc_channel_data(struct udevice *dev, int channel, static int > +int imx93_adc_start_channel(struct udevice *dev, int channel) static int > +int imx93_adc_stop(struct udevice *dev) static int > +int

[PATCH RFC u-boot-mvebu 36/59] tools: kwbimage: Fix endianity when printing kwbimage header

All fields in kwbimage header are in little endian format. Signed-off-by: Pali Rohár --- tools/kwbimage.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/kwbimage.c b/tools/kwbimage.c index 1128c934dda9..97be3bed79cb 100644 --- a/tools/kwbimage.c +++

[PATCH RFC u-boot-mvebu 38/59] tools: kwbimage: Add support for dumping NAND_BLKSZ for v0 images

In Dove functional specification, which use kwbimage v0, is also defined nand block size field. So dump NAND_BLKSZ also for v0 images. In Kirkwood functional specification, which also use kwbimage v0, this field is not defined. So when it is zero and Kirkwood is detected, do not dump it. Fixes:

[PATCH RFC u-boot-mvebu 51/59] arm: mvebu: Add support for generating PEX kwbimage

Add a new Kconfig option CONFIG_MVEBU_SPL_BOOT_DEVICE_PEX which instruct make to generate kwbimage with PEX header. This image is used for booting from PCI Express device which is in the Root Complex mode. Support is very simple, SPL after finishes DDR training returns back to the BootROM (via

[PATCH RFC u-boot-mvebu 31/59] tools: kwbimage: Fix dumping register set / DATA commands

Upper-bound for iterating for-loop over register set entries is incorrect. Fix it byt calculating correct number of entries. And fix also dumping the last entry DATA_DELAY, which is the last and not first (zero). Fixes: 1a8e6b63e24f ("tools: kwbimage: Dump kwbimage config file on '-p -1'

[PATCH RFC u-boot-mvebu 40/59] tools: kwbimage: Print image data offset when printing kwbimage header

For all images except SATA is data offset in bytes. For SATA it is in LBA format (number of sectors). This is how Marvell BootROM interprets it. Signed-off-by: Pali Rohár --- tools/kwbimage.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tools/kwbimage.c b/tools/kwbimage.c index

[PATCH RFC u-boot-mvebu 44/59] tools: kwbimage: Fix invalid secure boot header signature

Secure boot header signature is calculated from the image header with zeroed header checksum. Calculation is done in add_secure_header_v1() function. So after calling this function no header member except main_hdr->checksum can be modified. Commit 2b0980c24027 ("tools: kwbimage: Fill the real

[PATCH RFC u-boot-mvebu 55/59] arm: mvebu: Remove A39x relicts

Signed-off-by: Pali Rohár --- .../serdes/a38x/high_speed_env_spec.c | 4 +-- .../serdes/a38x/high_speed_env_spec.h | 4 +-- arch/arm/mach-mvebu/serdes/a38x/sys_env_lib.c | 14 +++-- arch/arm/mach-mvebu/serdes/a38x/sys_env_lib.h | 30 --- 4 files changed, 8

[PATCH RFC u-boot-mvebu 52/59] arm: mvebu: Fix description of MVEBU_SPL_BOOT_DEVICE_(SPI|MMC) options

MVEBU_SPL_BOOT_DEVICE_SPI is for NOR flash. Either serial or parallel. Not for general serial/SPI devices. The correct name should be BOOT_DEVICE_NOR but name SPI is already used in mkimage config format which we do not want to change for compatibility reasons. MVEBU_SPL_BOOT_DEVICE_MMC is for

[PATCH RFC u-boot-mvebu 23/59] cmd: mvebu/bubt: Rename variable image_size to hdr_size

Variable image_size contains size of the header, not size of the whole image. Rename this variable to reflect content. Signed-off-by: Pali Rohár --- cmd/mvebu/bubt.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/cmd/mvebu/bubt.c b/cmd/mvebu/bubt.c index

[PATCH RFC u-boot-mvebu 19/59] tools: kwboot: Show image type and error parsing reasons

Show image type and version during parsing of kwbimage. And show reasons in error messages when parsing failed. This can help to debug issues with invalid images. Signed-off-by: Pali Rohár --- tools/kwboot.c | 39 ++- 1 file changed, 34 insertions(+), 5

[PATCH RFC u-boot-mvebu 34/59] tools: kwbimage: Fix dumping NAND_BLKSZ

kwbimage nandblocksize field is in 64 kB unit, but NAND_BLKSZ command expects it in bytes. So do required unit conversion. Also zero value in nandblocksize field has special meaning. When this field is set to zero, the default block size is used. This default size is defined by the NAND flash

[PATCH RFC u-boot-mvebu 17/59] tools: kwboot: Add check that kwbimage contains DDR init code

Some NOR images may be execute-in-place and do not contain DDR init code in its kwbimage header. Such images cannot be booted over UART as BootROM loads them to RAM. Add check that kwbimage contains DDR init code in its header (either as binary code header or as the simple register-value set). In

[PATCH RFC u-boot-mvebu 14/59] tools: kwboot: Add image type documentation

Add information of all available image types and where they should be stored. Storage location offsets where documented from the disassembly of the A385 BootROM image dump. Signed-off-by: Pali Rohár --- tools/kwboot.c | 62 ++ 1 file changed, 62

[PATCH RFC u-boot-mvebu 58/59] arm: mvebu: Define SPL memory maps

In SPL are active memory maps set by the BootROM. Define them in cpu.h file to the correct values. Some peripherals are not mapped at all. Signed-off-by: Pali Rohár --- arch/arm/mach-mvebu/include/mach/cpu.h | 16 1 file changed, 16 insertions(+) diff --git

[PATCH RFC u-boot-mvebu 57/59] arm: mvebu: Define env_sf_get_env_addr() also for Proper U-Boot

Proper U-Boot moves SPI0 CS0 Flash mapping from 0xD400 to 0xF400 and change its size from 64 MB to 8 MB. Definitions are already in MBUS_SPI_BASE/MBUS_SPI_SIZE macros. So define these macros also for SPL build, use them in env_sf_get_env_addr() function and move this function from spl.c to

[PATCH RFC u-boot-mvebu 41/59] tools: kwbimage: Simplify add_secure_header_v1()

To make add_secure_header_v1() function more readable, call it directly with arguments: header pointer with header size and data image pointer with data image size. No functional change. Signed-off-by: Pali Rohár --- tools/kwbimage.c | 15 +-- 1 file changed, 5 insertions(+), 10

[PATCH RFC u-boot-mvebu 32/59] tools: kwbimage: Fix endianity when dumping NAND_PAGE_SIZE

Fixes: 1a8e6b63e24f ("tools: kwbimage: Dump kwbimage config file on '-p -1' option") Signed-off-by: Pali Rohár --- tools/kwbimage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/kwbimage.c b/tools/kwbimage.c index 1719b0415da1..a6f6f1578c79 100644 ---

[PATCH RFC u-boot-mvebu 53/59] arm: mvebu: db-88f6820-amc: Add defconfig for NAND booting

This new db-88f6820-amc_nand_defconfig file is copy of existing db-88f6820-amc_defconfig file and changed to instruct build system to generate final kwbimage for NAND booting. It was done by adding options: CONFIG_MVEBU_SPL_BOOT_DEVICE_NAND=y CONFIG_MVEBU_SPL_NAND_BADBLK_LOCATION=0x00

[PATCH RFC u-boot-mvebu 47/59] tools: mkimage: Print human readable error when -d is not specified

When asking mkimage to create a new image file and option -d is not specified then mkimage show human unfriendly error message: mkimage: Can't open (null): Bad address Without debugger it is hard to debug what is the issue. Function open() is being called with file name set to NULL. So add a

[PATCH RFC u-boot-mvebu 56/59] arm: mvebu: Fix comment about CPU_ATTR_BOOTROM mapping

Signed-off-by: Pali Rohár --- arch/arm/mach-mvebu/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-mvebu/cpu.c b/arch/arm/mach-mvebu/cpu.c index 1f8cdf8744e6..c5089a91c747 100644 --- a/arch/arm/mach-mvebu/cpu.c +++ b/arch/arm/mach-mvebu/cpu.c @@ -25,7 +25,7

[PATCH RFC u-boot-mvebu 43/59] tools: kwbimage: Fix generating secure boot data image signature

Secure boot data image signature is calculated from the data image without trailing 4-bit checksum. Commit 37cb9c15d70d ("tools: kwbimage: Simplify aligning and calculating checksum") unintentionally broke this calculation when it increased payloadsz variable by 4 bytes which was propagated also

[PATCH RFC u-boot-mvebu 22/59] cmd: mvebu/bubt: Add support for reading image from the SATA disk partition

This change allows to load boot image from the first SATA/SCSI device partition and burn it to board boot location (e.g. SPI-NOR). This is particularly when storage device is not handled by U-Boot as USB mass storage (which is already supported by bubt) but as SATA/SCSI device. Signed-off-by:

[PATCH RFC u-boot-mvebu 59/59] doc/kwboot.1: Update example description

Mention fact about changing baudrate back when -B is used. Signed-off-by: Pali Rohár --- doc/kwboot.1 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/kwboot.1 b/doc/kwboot.1 index a528fbbe8c38..5cda3b4d88a8 100644 --- a/doc/kwboot.1 +++ b/doc/kwboot.1 @@ -159,7 +159,8

[PATCH RFC u-boot-mvebu 45/59] tools: mkimage: Do not fill legacy_img_hdr for non-legacy XIP images

Skip filling legacy_img_hdr structure for XIP images which do not use legacy_img_hdr structure header. Adding unwanted header to other image formats, like kwbimage cause generation of broken image. Signed-off-by: Pali Rohár --- tools/mkimage.c | 4 +++- 1 file changed, 3 insertions(+), 1

[PATCH RFC u-boot-mvebu 39/59] tools: kwbimage: Print binary image offset as size

Use for it pretty print function: genimg_print_size(). This makes it more human readable, like other offset and sizes printed by this tool. Signed-off-by: Pali Rohár --- tools/kwbimage.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/kwbimage.c

[PATCH RFC u-boot-mvebu 54/59] arm: mvebu: clearfog: Add defconfig for SATA booting

This new clearfog_sata_defconfig file is copy of existing clearfog_defconfig file and changed to instruct build system to generate final kwbimage for SATA booting. This change is more readable via git option --find-copies-harder. Signed-off-by: Pali Rohár --- configs/{clearfog_defconfig =>

[PATCH RFC u-boot-mvebu 30/59] cmd: mvebu/bubt: Enable command by default

This makes updating of u-boot/firmware on Marvell boards easier. Signed-off-by: Pali Rohár --- cmd/mvebu/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/cmd/mvebu/Kconfig b/cmd/mvebu/Kconfig index 029f722096b1..e83a98294912 100644 --- a/cmd/mvebu/Kconfig +++ b/cmd/mvebu/Kconfig @@

[PATCH RFC u-boot-mvebu 49/59] tools: kwbimage: Add support for creating an image with no data

This change add support for mkimage's -s option to kwbimage format. It will create an kwbimage with empty data part of image (data part would contain only required 32-bit checksum). mkimage's -s option is indicated by skipcpy flag and it is basically in conflict with mkimage's -d (datafile)

[PATCH RFC u-boot-mvebu 12/59] arm: mvebu: spl: Fix support for loading U-Boot proper from SD card

Marvell BootROM loads MMC image from sector 0 (HW boot or data partition) and SD image from sector 1. So for SD card booting it is needed to not use constant CONFIG MMC options and instead of them it is needed to define functions spl_mmc_boot_mode() spl_mmc_get_uboot_raw_sector() which

[PATCH RFC u-boot-mvebu 13/59] tools: kwboot: Add more documentation references

Add reference to Avanta Boot Flow documentation, BobCat2, AlleyCat3 and PONCat3 BootROM Firmware documentation and links to public Marvell tools: hdrparser.c and doimage.c Signed-off-by: Pali Rohár --- tools/kwboot.c | 19 +++ 1 file changed, 19 insertions(+) diff --git

[PATCH RFC u-boot-mvebu 28/59] cmd: mvebu/bubt: Better guess default MVEBU_*_BOOT option

For 32-bit Armada boards which use SPL we can determinate boot device from existing MVEBU_SPL_BOOT_DEVICE_* option. For all other boards (e.g. 64-bit Armada) default option still needs to be set manually. Signed-off-by: Pali Rohár --- cmd/mvebu/Kconfig | 4 1 file changed, 4 insertions(+)

[PATCH RFC u-boot-mvebu 29/59] cmd: mvebu/bubt: Fix warnings: unused variable 'secure_mode' and 'fuse_read_u64' defined but not used

'secure_mode' and 'fuse_read_u64' are used only on A38x and A37xx. Fixes: f7b0bbca2b62 ("cmd: mvebu/bubt: Check for A38x/A37xx OTP secure bits and secure boot") Signed-off-by: Pali Rohár --- cmd/mvebu/bubt.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

[PATCH RFC u-boot-mvebu 20/59] cmd: mvebu/bubt: Add support for selecting eMMC HW partition

Support for burning into the correct eMMC HW boot partition was broken and removed in commit 96be2f072768 ("mvebu: bubt: Drop dead code"). Reimplement this functionality and bring it back again. Fixes: 96be2f072768 ("mvebu: bubt: Drop dead code") Signed-off-by: Pali Rohár --- cmd/mvebu/bubt.c

[PATCH RFC u-boot-mvebu 07/59] arm: mvebu: spl: Fix parsing SATA kwbimage

Despite the official specification, Marvell BootROM does not interpret srcaddr from SATA image as number of sectors the beginning of the hard drive, but as number of sectors relative to the main header. To process SATA kwbimage and load U-Boot proper from it in the same way as Marvell BootROM, it

[PATCH RFC u-boot-mvebu 00/59] arm: mvebu: Various fixes

This patch series contains various improvements and fixes for existing logical errors. Boot phase was adjusted to match behavior of Armada 385 BootROM by inspecting and disassembling of BootROM binary dump itself. Important information are included in documentation patch for kwboot. Most of the

[PATCH RFC u-boot-mvebu 24/59] cmd: mvebu/bubt: Mark all local symbols as static

There is no need to export these local functions and structures. Signed-off-by: Pali Rohár --- cmd/mvebu/bubt.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/cmd/mvebu/bubt.c b/cmd/mvebu/bubt.c index 72ed87b89ec3..820d342ae100 100644 --- a/cmd/mvebu/bubt.c +++

[PATCH RFC u-boot-mvebu 18/59] tools: kwboot: Fix patching of SPI/NOR XIP images

Marvell BootROM interprets execaddr of SPI/NOR XIP images as relative byte offset from the from the beginning of the flash device. So if data image offset and execute offset are not same then it is needed to adjust them also in DDR RAM. Fixes: f2c644e0b8bc ("tools: kwboot: Patch destination

[PATCH RFC u-boot-mvebu 26/59] cmd: mvebu/bubt: Check also A8K boot image checksum

Signed-off-by: Pali Rohár --- cmd/mvebu/bubt.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/cmd/mvebu/bubt.c b/cmd/mvebu/bubt.c index 1b08ca9298c2..74ea037dda98 100644 --- a/cmd/mvebu/bubt.c +++ b/cmd/mvebu/bubt.c @@ -725,9 +725,8 @@ static int

[PATCH RFC u-boot-mvebu 09/59] arm: mvebu: spl: Remove checks for BOOT_DEVICE_MMC2 and BOOT_DEVICE_MMC2_2

BOOT_DEVICE_MMC2 and BOOT_DEVICE_MMC2_2 are representing mmc dev 1 but all Armada SoCs have only one mmc controller. So remove references to non-existent second mmc controller. Fixes: f830703f4284 ("arm: mvebu: Check that kwbimage blockid matches boot mode") Signed-off-by: Pali Rohár ---

[PATCH RFC u-boot-mvebu 06/59] tools: kwboot: Fix parsing SATA kwbimage

Despite the official specification, Marvell BootROM does not interpret srcaddr from SATA image as number of sectors the beginning of the hard drive, but as number of sectors relative to the main header. To parse SATA kwbimage in the same way as Marvell BootROM, it is needed to interpret srcaddr

[PATCH RFC u-boot-mvebu 04/59] cmd: mvebu/bubt: Fix parsing SDIO kwbimage

Despite the official specification, Marvell BootROM does not interpret srcaddr from SDIO image as offset in number of sectors (like for SATA image), but as offset in bytes (like for all other images except SATA). To ensure that we do not store invalid SDIO image to the boot location (read by the

[PATCH RFC u-boot-mvebu 02/59] tools: kwboot: Fix parsing SDIO kwbimage

Despite the official specification, Marvell BootROM does not interpret srcaddr from SDIO image as offset in number of sectors (like for SATA image), but as offset in bytes (like for all other images except SATA). To parse SDIO kwbimage in the same way as Marvell BootROM, it is needed to interpret

[PATCH RFC u-boot-mvebu 08/59] cmd: mvebu/bubt: Fix parsing SATA kwbimage

Despite the official specification, Marvell BootROM does not interpret srcaddr from SATA image as number of sectors the beginning of the hard drive, but as number of sectors relative to the main header. Reject invalid and accept valid SATA images. Fixes: 5a0653493307 ("cmd: mvebu/bubt: Check for

[PATCH RFC u-boot-mvebu 01/59] tools: kwbimage: Fix generating, verifying and extracting SDIO kwbimage

Despite the official specification, Marvell BootROM does not interpret srcaddr from SDIO image as offset in number of sectors (like for SATA image), but as offset in bytes (like for all other images except SATA). To generate SDIO kwbimage compatible with Marvell BootROM, it is needed to have

rk3399: Loading OP-TEE by SPL?

Hello, my goal is to load OP-TEE after BL31 and before u-boot, so I enabled CONFIG_SPL_OPTEE_IMAGE. But it fails to build (tested current master): $ make -j$(nproc) CROSS_COMPILE=aarch64-linux-gnu- rock-pi-4-rk3399_defconfig all ./arch/arm/include/asm/unified.h: Assembler messages:

Re: [PATCHv4 0/5] FWU: Handle meta-data in common code

On Sat, Feb 04, 2023 at 09:00:56PM -0600, jassisinghb...@gmail.com wrote: > From: Jassi Brar > > The patchset reduces ~400 lines of code, while keeping the functionality same > and making > meta-data operations much faster (by using cached structures). > > Issue: > meta-data copies (primary

Re: [PATCH v1 1/1] input: button_kbd: make driver complementary to gpio buttons

Thanks! Do I need someone else to be able to merge this or your review is enough? Best regards, Svyatoslav R. вт, 21 лют. 2023 р. о 21:37 Simon Glass пише: > > On Mon, 20 Feb 2023 at 10:41, Svyatoslav Ryhel wrote: > > > > Remove need of dts binding for button keyboard since it reuses > >

Re: [PATCH] CI: Update test/nokia_rx51_test.sh to use prebuilt images

On Tue, 21 Feb 2023 at 09:22, Tom Rini wrote: > > From: Pali Rohár > > Now that the Dockerfile creates images which have the binaries we > require included, have CI make symlinks for them and update the existing > script to support this. > > Signed-off-by: Tom Rini > --- > Pali, since you

[PATCH 1/3] rockchip: Drop bootstage stash in TPL and SPL

Unfortunately the IRAM used to stash the bootstage records in TPL becomes accessible after SPL runs. Presumably this is because of ATF taking it over. We could move the stash to another address in SPL, before passing it to U-Boot proper. But it seems easier to wait until we have support for

[PATCH 3/3] bootstd: Enable BOOTSTD_DEFAULTS by default

This is needed to enable the boot command used to start standard boot. Enable it by default. This brings in quite a few features, mostly in common with DISTRO_DEFAULTS Signed-off-by: Simon Glass --- boot/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/boot/Kconfig b/boot/Kconfig

[PATCH 2/3] rockchip: Disable DISTRO_DEFAULTS for rockpro64

This board has moved to standard boot but the old 'distro_bootcmd' command is still active. Disable DISTRO_DEFAULTS to fix this. Signed-off-by: Simon Glass --- configs/rockpro64-rk3399_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/rockpro64-rk3399_defconfig

Re: [PATCH 6/9] binman: Mark mkimage entry missing when its subnodes is missing

On Sun, 19 Feb 2023 at 15:02, Jonas Karlman wrote: > > Using the mkimage entry with the multiple-data-files prop and having a > missing external blob result in an unexpected ValueError exception using > the --allow-missing flag. > > ValueError: Filename 'missing.bin' not found in input path

Re: [PATCH v3 2/3] kconfig: new macro IF_ENABLED()

Hi Heinrich, On Mon, 20 Feb 2023 at 10:15, Andre Przywara wrote: > > On Sun, 19 Feb 2023 12:36:28 +0100 > Heinrich Schuchardt wrote: > > Hi, > > > We want to move from using #ifdef to using if in our code. A lot of our > > code using #ifdef is structured like: > > > > #ifdef CONFIG_FOO > >

Re: [PATCH v3 58/76] Drop ubsha1 tool

Hi Peter, On Mon, 20 Feb 2023 at 03:16, Peter Robinson wrote: > > On Wed, Feb 1, 2023 at 8:46 PM Simon Glass wrote: > > > > This seems to have been used by ppc4xx which was removed a while back. > > The Kconfig does not exist so it is never built. Drop it. > > That assumption isn't entirely

Re: [PATCH 1/2] cmd: read: use part_get_info_by_dev_and_name_or_num() instead of open-coded dev_part parsing

On Fri, 17 Feb 2023 at 17:59, Rasmus Villemoes wrote: > > Use the helper part_get_info_by_dev_and_name_or_num() for parsing a > dev[:part] string and obtaining the partition info in one go, instead > of open-coding all that. > > As a bonus, this will automatically allow using the dev#partname >

Re: [PATCH 2/2] cmd: introduce 'write' command

Hi Rasmus, On Fri, 17 Feb 2023 at 17:59, Rasmus Villemoes wrote: > > It's almost no extra code to hook up a buddy to the 'read' command. In > fact, since the command is passed its own 'struct cmd_tbl', we can use > the exact same callback, and let it figure out for itself whether it > was

Re: [PATCH 9/9] Makefile: Show binman missing blob message

Hi Jonas +Tom Rini On Sun, 19 Feb 2023 at 15:02, Jonas Karlman wrote: > > When binman is invoked during a build of U-Boot and an external blob is > missing, the user is usually presented with a generic file not found in > input path message. > > Invoke binman with --allow-missing so that binman

Re: [PATCH 8/9] binman: Show filename in missing blob help message

On Sun, 19 Feb 2023 at 15:02, Jonas Karlman wrote: > > Show the filename next to the node path in missing blob help messages, > also show a generic missing blob message when there was no help message > for the help tag. > > Signed-off-by: Jonas Karlman > --- > tools/binman/control.py | 13

Re: [PATCH 7/9] binman: Fix blank line usage for invalid images warning text

On Sun, 19 Feb 2023 at 15:02, Jonas Karlman wrote: > > There is no blank line between last missing blob help message and the > header line for optional blob help messages. > > Image 'simple-bin' is missing external blobs and is non-functional: atf-bl31 > >

Re: [PATCH 5/9] binman: Implement missing check functions in mkimage entry

On Sun, 19 Feb 2023 at 15:02, Jonas Karlman wrote: > > The mkimage entry is working like a section entry but inherits from > Entry not Entry_section. Copy implementations of missing Check-functions > from Entry_section and adopt to Entry_mkimage. > > Signed-off-by: Jonas Karlman > --- >

Re: [PATCH v2 1/1] spl: allow loading via partition type GUID

Hi Heinrich, On Thu, 16 Feb 2023 at 23:56, Heinrich Schuchardt wrote: > > > > On 2/17/23 03:55, Simon Glass wrote: > > " properHi Heinrich, > > > > On Thu, 16 Feb 2023 at 14:31, Heinrich Schuchardt > > wrote: > >> > >> > >> > >> On 2/16/23 21:17, Simon Glass wrote: > >>> Hi Heinrich, > >>> >

[PATCH v2 3/4] buildman: Support disabling LTO

This cuts down build performance considerably and is not always needed, when checking for build errors, etc. Add a flag to disable it. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builder.py | 5 - tools/buildman/builderthread.py | 2 ++

[PATCH v2 4/4] buildman: Add a flag for reproducible builds

This is quite a useful thing to use when building since it avoids small size changes between commits. Add a -r flag for it. Also undefine CONFIG_LOCALVERSION_AUTO since this appends the git hash to the version string, causing every build to be slightly different. Signed-off-by: Simon Glass ---

[PATCH v2 2/4] buildman: Write out the build command used

It is sometimes useful to see the exact 'make' command used by buildman for a commit. Add an output file for this. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 13 + tools/buildman/buildman.rst | 8

[PATCH v2 1/4] buildman: Add a note about the out-env file

This file holds the environment used when doing a build. Add a note about it. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/buildman.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/buildman/buildman.rst b/tools/buildman/buildman.rst index

Re: [PATCH 1/3] remoteproc: Move rproc_cfg_arr out of the uclass header

On Sun, 19 Feb 2023 at 23:13, Samuel Holland wrote: > > This array is private to the IPU driver, so it should be declared there. > > Signed-off-by: Samuel Holland > --- > > drivers/remoteproc/ipu_rproc.c | 4 +++- > include/remoteproc.h | 1 - > 2 files changed, 3 insertions(+), 2

Re: [PATCH 1/4 v4] tpm: add a function that performs selftest + startup

On Sat, 18 Feb 2023 at 08:27, Ilias Apalodimas wrote: > > As described in [0] if a command requires use of an untested algorithm > or functional module, the TPM performs the test and then completes the > command actions. > > Since we don't check for TPM_RC_NEEDS_TEST (which is the return code of

Re: [PATCH 1/1] dm: core: revert "Don't inline dev_read...() calls with of-platdata"

Hi Heinrich, On Sat, 18 Feb 2023 at 02:17, Heinrich Schuchardt wrote: > > Compiling sandbox_defconfig with CONFIG_SPL_MMC=y results in > > drivers/mmc/mmc-uclass.c:211: > undefined reference to `dev_read_u32_default' > > Revert the fraudulent patch. > > Fixes: ef79ef21a852 ("dm: core:

Re: [PATCH 4/4 v4] test: add a test for the new tpm_auto_start() function

On Sat, 18 Feb 2023 at 08:27, Ilias Apalodimas wrote: > > A prior patch adds a new API function for TPM2.0, which performs > the full startup sequence of the TPM. Add a selftest for that. > > Signed-off-by: Ilias Apalodimas > --- > Changes since v4: > - New patch > > test/dm/tpm.c | 5 + >

Re: [PATCH 2/9] binman: Fix spelling of nodes in code comments

On Sun, 19 Feb 2023 at 15:02, Jonas Karlman wrote: > > Replace notes with nodes in code comments and docstrings. > > Signed-off-by: Jonas Karlman > --- > tools/binman/etype/fit.py | 2 +- > tools/binman/etype/section.py | 2 +- > tools/binman/state.py | 2 +- > 3 files changed, 3

Re: [PATCH v1 1/1] input: button_kbd: make driver complementary to gpio buttons

On Mon, 20 Feb 2023 at 10:41, Svyatoslav Ryhel wrote: > > Remove need of dts binding for button keyboard since it reuses > gpio-keys binding. Select gpio-keys driver if button keyboard > is selected since button keyboard can not operate on its own. > > Tested-by: Svyatoslav Ryhel # HTC One X T30

Re: [PATCH 3/3] remoteproc: Remove legacy probing method

On Sun, 19 Feb 2023 at 23:13, Samuel Holland wrote: > > This removes code that abused the device's platform data, interpreting > the driver platform data as if it was the uclass platform data. > > Signed-off-by: Samuel Holland > --- > > .../driver-model/remoteproc-framework.rst | 29

Re: [PATCH 1/1] sandbox: fix building with CONFIG_SPL_TIMER=y

Hi Heinrich, On Sat, 18 Feb 2023 at 02:34, Heinrich Schuchardt wrote: > > Building sandbox_defconfig with CONFIG_SPL_TIMER=y results in an error > > include/dm/platdata.h:63:33: error: static assertion failed: > "Cannot use U_BOOT_DRVINFO with of-platdata. > Please use devicetree

Re: [PATCH 1/1] sandbox: allow building sandbox_spl with CONFIG_DEBUG

On Sat, 18 Feb 2023 at 01:34, Heinrich Schuchardt wrote: > > Building sandbox_spl with CONFIG_DEBUG leads to errors due to missing > symbols: > > /usr/bin/ld: common/spl/spl_fit.o: in function `spl_fit_upload_fpga': > common/spl/spl_fit.c:595: undefined reference to `fpga_load' >

Re: [PATCH 4/9] binman: Override CheckOptional in fit entry

On Sun, 19 Feb 2023 at 15:02, Jonas Karlman wrote: > > Missing optional blobs was not reported for generated entries, e.g. > tee-os on rockchip targets. Implement a CheckOptional to fix this. > > After this the following can be shown: > > Image 'simple-bin' is missing external blobs but is

Re: [PATCH v3 11/95] Correct SPL use of PHY_CADENCE_SIERRA

Hi Tom, On Tue, 14 Feb 2023 at 09:31, Tom Rini wrote: > > On Sun, Feb 12, 2023 at 04:15:14PM -0700, Simon Glass wrote: > > This converts 1 usage of this option to the non-SPL form, since there is > > no SPL_PHY_CADENCE_SIERRA defined in Kconfig > > > > Signed-off-by: Simon Glass > > --- > > > >

Re: [PATCH 3/4 v4] tpm: sandbox: Change the return code when device is already open

On Sat, 18 Feb 2023 at 08:27, Ilias Apalodimas wrote: > > All the TPM drivers as well as out TCG TIS API for a TPM2.0 device > return -EBUSY if the device has already been opened. Adjust > the sandbox TPM do return the same error code. > > Signed-off-by: Ilias Apalodimas > --- > Changes since

Re: [PATCH 1/9] binman: Remove redundant SetAllowFakeBlob from blob-ext entry

On Sun, 19 Feb 2023 at 15:02, Jonas Karlman wrote: > > Entry_blob_ext contains an implementation of SetAllowFakeBlob that is > identical to the one in the base Entry class, remove it. > > Signed-off-by: Jonas Karlman > --- > tools/binman/etype/blob_ext.py | 8 > 1 file changed, 8

Re: [PATCH 3/9] binman: Use correct argument name in docstrings

On Sun, 19 Feb 2023 at 15:02, Jonas Karlman wrote: > > Use correct argument name in docstrings. > > Signed-off-by: Jonas Karlman > --- > tools/binman/entry.py | 2 +- > tools/binman/etype/blob.py| 2 +- > tools/binman/etype/section.py | 4 ++-- > 3 files changed, 4 insertions(+), 4

Re: [PATCH] binman: Avoid requiring a home directory on startup

Hi Quentin, On Mon, 20 Feb 2023 at 04:15, Quentin Schulz wrote: > > Hi Simon, > > On 2/18/23 00:49, Simon Glass wrote: > > Hi Quentin, > > > > On Fri, 17 Feb 2023 at 05:21, Quentin Schulz > > wrote: > >> > >> Hi all, > >> > >> On 2/17/23 03:55, Simon Glass wrote: > >>> Hi Tom, > >>> > >>> On

Re: [PATCH v2] binman: bintool: Add support for tool directories

Hi Neha, On Fri, 17 Feb 2023 at 04:46, Neha Malcom Francis wrote: > > Currently, bintool supports external compilable tools as single > executable files. Adding support for git repos that can be used to run > non-compilable scripting tools that cannot otherwise be present in > binman. > >

Re: rk3399 boards broken, only partially converted to standard boot? (was Re: [PATCH 71/71] rockchip: Convert rockpro64-rk3399 to use standard boot)

Hi Vagrant, On Mon, 20 Feb 2023 at 09:21, Simon Glass wrote: > > Hi Vagrant, > > On Sat, 18 Feb 2023 at 19:19, Vagrant Cascadian wrote: > > > > On 2022-12-07, Simon Glass wrote: > > > Drop the use of scripts and rely on standard boot for all operation. > > > > This patch, applied as

Re: [PATCH v2 9/9] usb: xhci: Fix root hub descriptor

Hi Mark, On Tue, 21 Feb 2023 at 02:28, Mark Kettenis wrote: > > > Date: Tue, 21 Feb 2023 01:46:22 +0100 > > From: Marek Vasut > > Hi Marek, > > > On 2/21/23 00:45, Simon Glass wrote: > > > On Sat, 21 Jan 2023 at 12:28, Mark Kettenis wrote: > > >> > > >> When a system has multiple XHCI

Re: [PATCHv4 4/5] fwu: meta-data: switch to management by common code

On Sat, Feb 04, 2023 at 09:02:02PM -0600, jassisinghb...@gmail.com wrote: > From: Jassi Brar > > The common code can now read, verify and fix meta-data copies > while exposing one consistent structure to users. > Only the .read_mdata() and .write_mdata() callbacks of fwu_mdata_ops > are

Re: [PATCH] CI: Update test/nokia_rx51_test.sh to use prebuilt images

On Tuesday 21 February 2023 11:22:29 Tom Rini wrote: > From: Pali Rohár > > Now that the Dockerfile creates images which have the binaries we > require included, have CI make symlinks for them and update the existing > script to support this. > > Signed-off-by: Tom Rini > --- > Pali, since you

[PATCH 2/2] configs: remove gwventana_gw5904_defconfig

Now that the gwventana_emmc_defconfig is the same as the gwventana_gw5904_defconfig we can remove the latter. Signed-off-by: Tim Harvey --- board/gateworks/gw_ventana/MAINTAINERS | 1 - configs/gwventana_gw5904_defconfig | 179 - 2 files changed, 180 deletions(-)

[PATCH 1/2] configs: gwventana_emmc_defconfig: add MV88E61XX DSA switch support

The MV88E61XX switch is used on the GW5904 which is an eMMC based board. Adding it here allows us to remove the gwventana_gw5904_defconfig. Signed-off-by: Tim Harvey --- configs/gwventana_emmc_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configs/gwventana_emmc_defconfig

[PATCH] CI: Update test/nokia_rx51_test.sh to use prebuilt images

From: Pali Rohár Now that the Dockerfile creates images which have the binaries we require included, have CI make symlinks for them and update the existing script to support this. Signed-off-by: Tom Rini --- Pali, since you posted this in a thread as untested, can you please reply with a S-o-b

Re: [PATCH v4 00/16] General Tegra improvements

Thanks in advance! I would love to get any ACKs/Tested-By/Reviewed-By's but most likely no one, apart from the Transformers community and me, relies so much on display drivers in u-boot. Most likely this is why it was barely set and only for T20. Best regards, Svyatoslav R. вт, 21 лют. 2023 р.

RE: [PATCH v4 00/16] General Tegra improvements

Buildman ran fine on TOT u-boot-tegra/master rebased w/TOT u-boot/master on Friday. I'll send a PR today. I'll look at merging your new DC 11-patch series later in the week. If we could get any ACKs/Tested-By/Reviewed-By's in ASAP that would be great. Tom -Original Message- From:

Re: [PATCH 3/4] mtd/fpga: add fpga directory to mtd (with Cyclone 10)

If the use of MTD is restricted to passive serial, this is OK with me. Yeah, but that is not how upstream things work. You need to also think of any other use cases. These are the things I want to achieve. * transfer data using the SPI driver and not use board files. For that, the FPGA

Re: [PATCH v5 1/1] video console: refactoring and optimization

On Mon, 20 Feb 2023 at 03:49, Dzmitry Sankouski wrote: > > - move common code to vidconsole_internal.h and console_core.c > - unite probe functions > - get rid of code duplications in switch across bpp values > - extract common pixel fill logic in two functions one per > horizontal and vertical

Re: [PATCH 3/4] mtd/fpga: add fpga directory to mtd (with Cyclone 10)

Den 2023-02-21 kl. 12:19, skrev Michael Walle: Am 2023-02-21 11:42, schrieb Ulf Samuelsson: Den 2023-02-21 kl. 10:08, skrev Michael Walle: If it is right or wrong to use that as an MTD is a matter of opinion. I am still hoping the MTD maintainer would provide input here. I might be missing

Re: [PATCH v2 9/9] usb: xhci: Fix root hub descriptor

On 2/21/23 10:28, Mark Kettenis wrote: Date: Tue, 21 Feb 2023 01:46:22 +0100 From: Marek Vasut Hi Marek, On 2/21/23 00:45, Simon Glass wrote: On Sat, 21 Jan 2023 at 12:28, Mark Kettenis wrote: When a system has multiple XHCI controllers, some of the properties described in the

[PATCH v2 RESEND 4/6] arm: dts: chameleonv3: Rename chameleonv3.dts to .dtsi

This file is included by the different chameleonv3 variants. Change the name to .dtsi. Signed-off-by: Paweł Anikiel Reviewed-by: Simon Glass --- ...arria10_chameleonv3.dts => socfpga_arria10_chameleonv3.dtsi} | 0 arch/arm/dts/socfpga_arria10_chameleonv3_270_3.dts | 2 +-

[PATCH v2 RESEND 6/6] chameleonv3: Convert CONFIG_SPL_MAX_SIZE to Kconfig

This file was missed during the conversion process. Add the symbol to defconfig. Signed-off-by: Paweł Anikiel Reviewed-by: Simon Glass --- configs/socfpga_chameleonv3_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/socfpga_chameleonv3_defconfig

[PATCH v2 RESEND 5/6] arm: dts: chameleonv3: Add 270-2 variant

Add devicetree for chameleonv3 with the 270-2I2-D11E variant of the Mercury+ AA1 module Signed-off-by: Paweł Anikiel Reviewed-by: Simon Glass --- arch/arm/dts/Makefile| 1 + .../socfpga_arria10_chameleonv3_270_2-u-boot.dtsi| 12

[PATCH v2 RESEND 1/6] socfpga: chameleonv3: Enable ext4 in SPL

Allow SPL to boot from an ext4 filesystem. Signed-off-by: Paweł Anikiel Reviewed-by: Simon Glass --- configs/socfpga_chameleonv3_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/socfpga_chameleonv3_defconfig b/configs/socfpga_chameleonv3_defconfig index

[PATCH v2 RESEND 3/6] arm: dts: chameleonv3: Override chameleonv3 bitstream names

Set the bitstream name per Chameleon variant. This allows the same boot filesystem with all bitstream variants to be used on different boards. Signed-off-by: Paweł Anikiel Reviewed-by: Simon Glass --- arch/arm/dts/socfpga_arria10_chameleonv3_270_3-u-boot.dtsi | 4

<    1   2   3   >