Re: [PATCH v2 13/30] sandbox: Drop inclusion of os.h in sscanf.c

2023-04-30 Thread Bin Meng
On Sun, Apr 30, 2023 at 9:30 AM Simon Glass wrote: > > There is no need for this file and it should not be included unless > sandbox is being used. Drop it. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > lib/sscanf.c | 1 - > 1 file changed, 1 deletion(-) > Reviewed-by: Bin

Re: [PATCH v2 12/30] sandbox: Drop incorrect inclusion of linux/types.h

2023-04-30 Thread Bin Meng
On Sun, Apr 30, 2023 at 9:30 AM Simon Glass wrote: > > This header file should only be included in U-Boot standalone files, not > those built in the Linux environment. When not building for Linux, the > header file does not exist, except in the U-Boot tree. In any case, it > should not be used. >

Re: [PATCH v2 11/30] sections: Drop use of linux/types.h

2023-04-30 Thread Bin Meng
On Sun, Apr 30, 2023 at 9:30 AM Simon Glass wrote: > > Use 'unsigned long' instead of 'ulong' so this file does not need to > include the linux/types.h header file. This allows it to be built with > MSYS2. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > include/asm-generic/sec

Re: [PATCH v2 10/30] sandbox: Include errno.h in the test header

2023-04-30 Thread Bin Meng
On Sun, Apr 30, 2023 at 9:30 AM Simon Glass wrote: > > Add this so that the header file can used without first including the > errno.h header. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > arch/sandbox/include/asm/test.h | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by

Re: [PATCH v2 09/30] sandbox: Correct SDL.h header inclusion

2023-04-30 Thread Bin Meng
On Sun, Apr 30, 2023 at 9:30 AM Simon Glass wrote: > > We rely on sdl-config to provide the include directory for this header > file, so should not add the include directory in the C file. Drop it so > that this works as expected on Windows. > > Signed-off-by: Simon Glass > --- > > (no changes si

Re: [PATCH v2 08/30] sandbox: Drop dead code from Makefile

2023-04-30 Thread Bin Meng
On Sun, Apr 30, 2023 at 9:30 AM Simon Glass wrote: > > This is not used, since the same code appears in cpu/Makefile > > Drop it. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > arch/sandbox/Makefile | 7 --- > 1 file changed, 7 deletions(-) > Reviewed-by: Bin Meng

Re: [PATCH v2 07/30] mkimage: Correct checking of configuration node

2023-04-30 Thread Bin Meng
On Sun, Apr 30, 2023 at 9:30 AM Simon Glass wrote: > > This returns a negative value on error. Update the logic to detect this > and avoid a segfault when the node is not found. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > tools/image-host.c | 4 +++- > 1 file changed, 3 in

[PATCH 1/2] cmd: fdt: Correct checking of configuration node

2023-04-30 Thread Bin Meng
fit_conf_get_node() returns a negative value on error. Signed-off-by: Bin Meng --- cmd/fdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/fdt.c b/cmd/fdt.c index aae3278526..2401ea8b44 100644 --- a/cmd/fdt.c +++ b/cmd/fdt.c @@ -733,7 +733,7 @@ static int do_fdt(struct

[PATCH 2/2] spl: Correct checking of configuration node

2023-04-30 Thread Bin Meng
Per the fit_conf_get_node() API doc, it returns configuration node offset when found (>=0). Signed-off-by: Bin Meng --- common/spl/spl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/spl/spl.c b/common/spl/spl.c index a630e79866..7c0aff93e7 100644 --- a/common/spl/s

Re: [PATCH v2 06/30] Fix Makefile warning about parallel targets

2023-04-30 Thread Bin Meng
Hi Simon, On Sun, Apr 30, 2023 at 9:30 AM Simon Glass wrote: > > These targets are not really parallel; they are handled one at a time > when invoked by other rules. Some recent versions of make (e.g. on MSYS2) > give a warning about this. Split out the rules to avoid the warning. I did not see

Re: [PATCH v2 05/30] pylibfdt: Allow building on Windows

2023-04-30 Thread Bin Meng
Hi Simon, On Sun, Apr 30, 2023 at 9:30 AM Simon Glass wrote: > > Handle the different shared-object extension with MSYS2 by creating a new > SOEXT variable. > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Use LIBEXT instead of SOEXT > > Makefile | 11 +++

Pull request: u-boot-sunxi/master for 2023.07

2023-04-30 Thread Andre Przywara
Hi Tom, please pull the second part of the sunxi pull request for this cycle. Another bunch of patches that replace old-school U-Boot hacks with proper DM based code, this time for the raw NAND flash driver, and the USB PHY VBUS detection code. Plus two smaller patches that were sitting in my inbo

[PATCH] usb: gadget: Compile USB ethernet gadget only if NET is enabled

2023-04-30 Thread Marek Vasut
In case NET networking is not enabled, it is not possible to compile the USB ethernet gadget. Protect the symbols in Makefile to avoid build failure. Such build failure may occur e.g. in case NET and USB ethernet gadget is enabled in U-Boot proper, but not in SPL. Signed-off-by: Marek Vasut --- C

Re: [PATCH v3 02/11] net: dwc_eth_qos: Add StarFive ethernet driver glue layer

2023-04-30 Thread Ramon Fried
On Fri, Apr 28, 2023 at 5:25 AM Yanhong Wang wrote: > > The StarFive ETHQOS hardware has its own clock and reset,so add a > corresponding glue driver to configure them. > > Signed-off-by: Yanhong Wang > --- > drivers/net/Kconfig| 7 + > drivers/net/Makefile | 1

Re: [PATCH] net: sh_eth: Fix RX error handling

2023-04-30 Thread Ramon Fried
On Sun, Apr 30, 2023 at 5:54 PM Marek Vasut wrote: > > From: Valentine Barshak > > In case RX error occurs, and the RD_RFE bit is set, the descriptor > is never returned back to the queue. Make sh_eth_recv_start return > zero length in this case so that the descriptor can be released > and pushed

Re: [PATCH 1/2] net: rtl8169: add minimal support for 8125B variant

2023-04-30 Thread Ramon Fried
On Tue, Apr 25, 2023 at 10:47 PM Eugen Hristev wrote: > > On 4/25/23 22:22, Ramon Fried wrote: > > On Tue, Apr 25, 2023 at 4:17 PM Eugen Hristev > > wrote: > >> > >> On 4/25/23 16:06, Eugen Hristev wrote: > >>> Add minimal support for 8125B version. > >>> Changes are based on the Linux driver. >

Re: [PATCH V3 2/3] net: phy: Drop phy_interface_is_sgmii

2023-04-30 Thread Ramon Fried
On Sat, Apr 15, 2023 at 1:06 AM Nishanth Menon wrote: > > Recent commit 75d28899e3e9 ("net: phy: Synchronize PHY interface modes > with Linux") reordered the enum definitions. This caused the range of > enums that this api was checking to go bad. > > There aren't anymore users of phy_interface_is_

Re: [PATCH V3 3/3] net: phy: Make phy_interface_is_rgmii a switch statement

2023-04-30 Thread Ramon Fried
On Sat, Apr 15, 2023 at 1:06 AM Nishanth Menon wrote: > > Recent commit 75d28899e3e9 ("net: phy: Synchronize PHY interface modes > with Linux") reordered the enum definitions. This exposed a problem > in range checking functions to identify the interface type. Though > this specific api wasn't imp

Re: [PATCH V3 1/3] net: phy: dp83867: Explicitly check against sgmii

2023-04-30 Thread Ramon Fried
On Sat, Apr 15, 2023 at 1:06 AM Nishanth Menon wrote: > > dp83867 driver only supports sgmii and not all the newer protocols. > Drop the usage of the generic phy_interface_is_sgmii function and just > matchup to the specific mode supported. > > Reported-by: Tom Rini > Suggested-by: Marek Vasut >

Re: [PATCH v5 1/3] regulator: implement basic reference counter

2023-04-30 Thread Jonas Karlman
Hi Tim, On 2023-04-28 18:36, Tim Harvey wrote: > On Fri, Apr 28, 2023 at 12:39 AM Eugen Hristev > wrote: >> >> On 4/28/23 02:39, Tim Harvey wrote: >>> On Wed, Apr 19, 2023 at 6:45 AM Eugen Hristev >>> wrote: Some devices share a regulator supply, when the first one will request reg

Re: Aw: Re: distro_boot vs. env-based bootmenu

2023-04-30 Thread Jonas Karlman
Hi Frank, On 2023-04-30 15:25, Frank Wunderlich wrote: > Hi > > I tried to find out why distroboot is enabled (i have not set it in my > defconfig) and i think this is why: > > │ Symbol: DISTRO_DEFAULTS [=y]│ > > │ Type : bool

Re: [PATCH v2 04/30] binman: Avoid using a symlink

2023-04-30 Thread Bin Meng
Hi Simon, On Sun, Apr 30, 2023 at 9:30 AM Simon Glass wrote: > > Use a small Python script instead of a symlink to avoid problems with > Windows. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > tools/binman/binman | 11 ++- > 1 file changed, 10 insertions(+), 1 deleti

Aw: [PATCH v2 0/2] Add DTS for BPI-R3

2023-04-30 Thread Frank Wunderlich
Hi, Is it possible to take this series in upcoming release? regards Frank > Gesendet: Dienstag, den 11.04.2023 um 17:19 Uhr > Von: "Frank Wunderlich" > An: u-boot@lists.denx.de > Cc: "Frank Wunderlich" , "Sam Shih" > , "William Zhang" , > "Philippe Reynes" , "Marek Vasut" > , "Fabio Estevam

Re: [PATCH v2 28/30] doc: Show how to build sandbox for MSYS2

2023-04-30 Thread Bin Meng
Hi Simon, On Sun, Apr 30, 2023 at 9:30 AM Simon Glass wrote: > > Add instructions for building u-boot.exe to run on Windows. > > Signed-off-by: Simon Glass > --- > > Changes in v2: > - Clearify the documentation to explain the environment better > > doc/build/gcc.rst | 40 ++

Re: [PATCH 17/31] sandbox: Allow weak symbols to be dropped

2023-04-30 Thread Bin Meng
Hi Simon, On Sun, Apr 30, 2023 at 2:41 AM Simon Glass wrote: > > Hi Bin, > > On Mon, 24 Apr 2023 at 20:44, Bin Meng wrote: > > > > Hi Simon, > > > > On Tue, Apr 25, 2023 at 7:09 AM Simon Glass wrote: > > > > > > The sandbox build makes use of a small number of weak symbols. Allow these > > > to

Re: [PATCH 3/3] efi: Correct .efi rules

2023-04-30 Thread Heinrich Schuchardt
Am 30. April 2023 03:21:47 MESZ schrieb Simon Glass : >These files should have both 'always' and 'targets' so that dependencies >are detected correctly. > >When only 'always' is used, the target is built every time, although I am >not quite sure why. > >Make sure each has both 'always' and 'targ

[PATCH] net: sh_eth: Fix RX error handling

2023-04-30 Thread Marek Vasut
From: Valentine Barshak In case RX error occurs, and the RD_RFE bit is set, the descriptor is never returned back to the queue. Make sh_eth_recv_start return zero length in this case so that the descriptor can be released and pushed back to the list. Also return the more appropriate -EAGAIN inste

Re: [PATCH v2 27/30] doc: Update the MSYS2 packages and versions

2023-04-30 Thread Tom Rini
On Sat, Apr 29, 2023 at 07:30:00PM -0600, Simon Glass wrote: > These are now quite out-of-date. Update to 2023 versions and bring in > those are are needed for the newer tool features. > > Signed-off-by: Simon Glass > --- > > (no changes since v1) > > doc/build/tools.rst | 20

Re: [PATCH v2 22/30] Makefile: Correct the ans1_compiler rule for MSYS2

2023-04-30 Thread Tom Rini
On Sat, Apr 29, 2023 at 07:29:55PM -0600, Simon Glass wrote: > Add the required extension to the Makefile rule. > > Signed-off-by: Simon Glass Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 21/30] Makefile: Disable unsupported compiler options with PE

2023-04-30 Thread Tom Rini
On Sat, Apr 29, 2023 at 07:29:54PM -0600, Simon Glass wrote: > The MSYS2 compiler does not support some of these options. Drop them to > avoid build errors. > > Signed-off-by: Simon Glass Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 17/30] Kbuild: Detect including an MSYS2 path

2023-04-30 Thread Tom Rini
On Sat, Apr 29, 2023 at 07:29:50PM -0600, Simon Glass wrote: > The source-tree directory is prepended to relative include paths, but this > does not work on Windows, where a path may have a drive letter like C: at > the start of it. > > This breaks SDL which includes an absolute path to the header

Re: [PATCH v2 11/30] sections: Drop use of linux/types.h

2023-04-30 Thread Tom Rini
On Sat, Apr 29, 2023 at 07:29:44PM -0600, Simon Glass wrote: > Use 'unsigned long' instead of 'ulong' so this file does not need to > include the linux/types.h header file. This allows it to be built with > MSYS2. > > Signed-off-by: Simon Glass Reviewed-by: Tom Rini -- Tom signature.asc De

Re: [PATCH v2 16/30] Makefile: Disable LTO when not building with gcc

2023-04-30 Thread Tom Rini
On Sat, Apr 29, 2023 at 07:29:49PM -0600, Simon Glass wrote: > For MSYS2 this creates a lot of errors of the form: > > `__stack_chk_fail' referenced in section `.text' of ...ltrans.o: defined >in discarded section `.text' of common/stackprot.o (symbol from plugin) > > For clang it doesn't wo

Aw: Re: distro_boot vs. env-based bootmenu

2023-04-30 Thread Frank Wunderlich
Hi I tried to find out why distroboot is enabled (i have not set it in my defconfig) and i think this is why: │ Symbol: DISTRO_DEFAULTS [=y]│ │ Type : bool│ │ Prompt: Select default

Uboot-Raspberry3b-Bare metal code

2023-04-30 Thread Little Tree
Hi, I have written (copied from here https://github.com/bztsrc/raspi3-tutorial/tree/master/0F_executionlevel) a small bare metal program to switch exception level from EL2 to EL1 in Raspberry Pi 3B. The program is linked to load at the address 0x8. The stripped version of the ELF is directly l

Re: [PATCH 17/31] sandbox: Allow weak symbols to be dropped

2023-04-30 Thread Pali Rohár
On Saturday 29 April 2023 12:41:31 Simon Glass wrote: > Hi Pali, > > On Tue, 25 Apr 2023 at 10:31, Pali Rohár wrote: > > > > On Tuesday 25 April 2023 10:44:17 Bin Meng wrote: > > > Hi Simon, > > > > > > On Tue, Apr 25, 2023 at 7:09 AM Simon Glass wrote: > > > > > > > > The sandbox build makes us