Re: F2-NAS2 and NSA325 contributions

2023-06-29 Thread Tony Dinh
Hi Henry, On Thu, Jun 29, 2023 at 7:52 PM Henry Smith wrote: > > Oh hello! > > Nice to hear from the person I wanted to contact. I based my work on > your fork of the marvell repo. > My priority is to get the new device into the tree so I don't lose it > and other people can benefit. Please

Re: [PATCH 10/12] binman: btool: Add Xilinx Bootgen btool

2023-06-29 Thread Simon Glass
Hi, On Thu, 29 Jun 2023 at 15:59, wrote: > > From: Lukas Funke > > Add the Xilinx Bootgen as bintool. Xilinx Bootgen is used to create > bootable SPL (FSBL in Xilinx terms) images for Zynq/ZynqMP devices. The > btool creates a signed version of the SPL. > > Signed-off-by: Lukas Funke > --- > >

Re: [PATCH 09/12] binman: doc: Add documentation for Xilinx Bootgen bintool

2023-06-29 Thread Simon Glass
On Thu, 29 Jun 2023 at 15:59, wrote: > > From: Lukas Funke > > Add documentation for the 'bootgen' bintool > > Signed-off-by: Lukas Funke > --- > > tools/binman/bintools.rst | 12 > 1 file changed, 12 insertions(+) > Reviewed-by: Simon Glass

Re: [PATCH 08/12] binman: etype: Add u_boot_spl_pubkey_dtb etype

2023-06-29 Thread Simon Glass
On Thu, 29 Jun 2023 at 15:59, wrote: > > From: Lukas Funke > > This adds a new etype 'u_boot_spl_pubkey_dtb'. The etype adds the public > key from a certificate to the dtb. This creates a '/signature' node which > is turn contains the fields which make up the public key. Usually this > is done

Re: [PATCH 07/12] binman: btool: Add fdt_add_pubkey as btool

2023-06-29 Thread Simon Glass
On Thu, 29 Jun 2023 at 15:59, wrote: > > From: Lukas Funke > > Add btool which calls 'fdt_add_pubkey' > > Signed-off-by: Lukas Funke > --- > > tools/binman/btool/fdt_add_pubkey.py | 67 > 1 file changed, 67 insertions(+) > create mode 100644

Re: [PATCH 06/12] binman: ftest: Add test for u_boot_spl_pubkey_dtb

2023-06-29 Thread Simon Glass
On Thu, 29 Jun 2023 at 15:59, wrote: > > From: Lukas Funke > > Add test for u_boot_spl_pubkey_dtb. The test adds a public key to the > dtb and checks if the required nodes will be added to the images dtb. > > Signed-off-by: Lukas Funke > --- > > tools/binman/ftest.py| 32

Re: F2-NAS2 and NSA325 contributions

2023-06-29 Thread Tony Dinh
Hi Henry, On Thu, Jun 29, 2023 at 6:53 PM Tony Dinh wrote: > > Hi Heny, > > On Thu, Jun 29, 2023 at 6:01 PM Henry Smith wrote: > > > > Hello, > > > > I'm a hobbyist that has been playing with Linkstation LS-WVL years > > ago. After frying UART on that, I got Terramaster F2-NAS2 later and > >

Re: F2-NAS2 and NSA325 contributions

2023-06-29 Thread Tony Dinh
Hi Heny, On Thu, Jun 29, 2023 at 6:01 PM Henry Smith wrote: > > Hello, > > I'm a hobbyist that has been playing with Linkstation LS-WVL years > ago. After frying UART on that, I got Terramaster F2-NAS2 later and > got u-boot from the main tree to work on it. > > Both landed in the closet until I

Re:Re: [PATCH] rockchip: Restore support for boot scripts in legacy image format

2023-06-29 Thread Andy Yan
Hi: 在 2023-06-29 22:07:05,"Jonas Karlman" 写道: >Hi Kever, > >On 2023-06-29 12:51, Kever Yang wrote: >> Hi Jonas, >> >> What is the legacy image format, does these boards really use than? >> >> I think most of the board using linux distro image. > >The legacy image format

Fwd: F2-NAS2 and NSA325 contributions

2023-06-29 Thread Henry Smith
Hello, I'm a hobbyist that has been playing with Linkstation LS-WVL years ago. After frying UART on that, I got Terramaster F2-NAS2 later and got u-boot from the main tree to work on it. Both landed in the closet until I dug up F2-NAS2 recently. My original source code modifications and images

Re: [PATCH] smegw01: Fix wrong symbol override

2023-06-29 Thread Tom Rini
On Tue, Jun 27, 2023 at 01:57:49PM -0300, Fabio Estevam wrote: > From: Eduard Strehlau > > board_mmc_get_env_part() is not called as the default implementation > of mmc_get_env_part() is used. > > Fix this problem by directly calling mmc_get_env_part() instead. > > Signed-off-by: Eduard

Re: [PATCH] CI: Azure: Split keymile jobs out

2023-06-29 Thread Tom Rini
On Mon, Jun 26, 2023 at 03:19:54PM -0400, Tom Rini wrote: > Currently the PowerPC build job in Azure will hit the maximum time limit > for a build and stop. Looking at the job, the easiest path to reducing > it is to move Keymile vendor boards to their own job and exclude them > from the PowerPC

Re: [PATCH] board: freescale: imx93_evk: Fix MMC environment offset boot conflict.

2023-06-29 Thread Tom Rini
On Tue, Apr 11, 2023 at 04:05:31PM -0400, Ken Sloat wrote: > Currently, the imx93_evk is configured with CONFIG_ENV_IS_IN_MMC and the > chosen environment offset in the config is 0x40. Unless the user > programs the associated fuses, this offset is the default secondary boot > image offset

Re: Pull request: u-boot-rockchip-20230629

2023-06-29 Thread Tom Rini
06-27 09:39:58 > -0400) > > are available in the Git repository at: > > https://source.denx.de/u-boot/custodians/u-boot-rockchip.git > tags/u-boot-rockchip-20230629 > > for you to fetch changes up to d77d5301d7dc333db0425ee82499fe362abd259d: > > board: rockch

Re: v2023.07-rc5 regression: Image overlaps SPL

2023-06-29 Thread Tom Rini
On Thu, Jun 29, 2023 at 04:19:22PM +0200, Francesco Dolcini wrote: > Hello Marek, > as briefly discussed off-list it looks like > commit 77aed22b48ab ("spl: spl_legacy: Add extra address checks") introduces a > regression on some board/arch, at least colibri and apalis imx6 fails to boot > now >

Re: [PATCH] doc: imx: habv4: Fix typo in 'signing'

2023-06-29 Thread Tim Harvey
On Thu, Jun 29, 2023 at 12:26 PM Fabio Estevam wrote: > > From: Fabio Estevam > > Fix two occurrences where 'signing' is misspelled. > > Signed-off-by: Fabio Estevam > --- > doc/imx/habv4/guides/mx6_mx7_secure_boot.txt | 2 +- > doc/imx/habv4/guides/mx6_mx7_spl_secure_boot.txt | 2 +- > 2

[PATCH] doc: imx: habv4: Fix typo in 'signing'

2023-06-29 Thread Fabio Estevam
From: Fabio Estevam Fix two occurrences where 'signing' is misspelled. Signed-off-by: Fabio Estevam --- doc/imx/habv4/guides/mx6_mx7_secure_boot.txt | 2 +- doc/imx/habv4/guides/mx6_mx7_spl_secure_boot.txt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 07/10] test: dm: add SCMI base protocol test

2023-06-29 Thread Simon Glass
Hi AKASHI, On Wed, 28 Jun 2023 at 01:49, AKASHI Takahiro wrote: > > Added is a new unit test for SCMI base protocol, which will exercise all > the commands provided by the protocol, except SCMI_BASE_NOTIFY_ERRORS. > $ ut dm scmi_base > It is assumed that test.dtb is used as sandbox's device

Re: [PATCH 09/10] doc: cmd: add documentation for scmi

2023-06-29 Thread Simon Glass
Hi AKASHI, On Wed, 28 Jun 2023 at 01:49, AKASHI Takahiro wrote: > > This is a help text for scmi command. > > Signed-off-by: AKASHI Takahiro > --- > doc/usage/cmd/scmi.rst | 98 ++ > 1 file changed, 98 insertions(+) > create mode 100644

Re: [PATCH v2 2/4] cmd: Add a sysinfo command

2023-06-29 Thread Simon Glass
Hi Detlev, On Wed, 28 Jun 2023 at 20:33, Detlev Casanova wrote: > > The command is able to show different information for the running > system: > * Model name > * Board ID > * Revision > > This command can be used by boot shell scripts to select configurations > depending on the specific running

Re: [PATCH 01/12] binman: elf: Check for ELF_TOOLS availability and remove extra semicolon

2023-06-29 Thread Simon Glass
On Thu, 29 Jun 2023 at 15:59, wrote: > > From: Lukas Funke > > Check if elf tools are available when running DecodeElf(). Also > remove superfuous semicolon at line ending. > > Signed-off-by: Lukas Funke > --- > > tools/binman/elf.py | 10 ++ > 1 file changed, 6 insertions(+), 4

Re: [PATCHv2 1/3] net/lwip: add lwip-external submodule

2023-06-29 Thread Simon Glass
Hi Maxim, On Thu, 29 Jun 2023 at 13:39, Maxim Uvarov wrote: > > This commit adds the lwip library as a git submodule. I think > there has to be advantages to compile lwip inside U-boot, > i.e. use the same compiler and flags as the main code. > One of them is LTO and the other is to enable

Re: [PATCH v2 1/4] sysinfo: Add IDs for board id and revision

2023-06-29 Thread Simon Glass
Hi Detlev, On Wed, 28 Jun 2023 at 20:32, Detlev Casanova wrote: > > These IDs will be used by the sysinfo command. The new IDs are: > * SYSINFO_ID_BOARD_ID: The board ID as an integer > * SYSINFO_ID_BOARD_REVISION: The board revision as a string > > Signed-off-by: Detlev Casanova > --- >

Re: [PATCH] bootstd: USB devtype detection for script boot

2023-06-29 Thread Simon Glass
Hi John, On Thu, 29 Jun 2023 at 01:03, John Clark wrote: > > > I only just thought of this, but I think it is better to check > blk->uclass_id == UCLASS_USB instead, since it avoids a string comparison. > > I am not finding anything as direct as your pseudo code above suggests. > The closest I

Re: [PATCH 05/10] firmware: scmi: fake base protocol commands on sandbox

2023-06-29 Thread Simon Glass
On Wed, 28 Jun 2023 at 01:49, AKASHI Takahiro wrote: > > This is a simple implementation of SCMI base protocol for sandbox. > The main use is in SCMI unit test. > > Signed-off-by: AKASHI Takahiro > --- > drivers/firmware/scmi/sandbox-scmi_agent.c | 359 - > 1 file changed,

Re: [PATCH 03/12] binman: Don't decompress data while signing

2023-06-29 Thread Simon Glass
Hi, On Thu, 29 Jun 2023 at 15:59, wrote: > > From: Lukas Funke > > While signing a fit compressed data (i.e. 'blob-ext') is decompressed, > but never compressed again. When compressed data was wrapped in a > section, decompression leads to an error because the outer section had > the original

Re: [PATCH 2/3] binman: Allow cipher node as special section

2023-06-29 Thread Simon Glass
On Tue, 27 Jun 2023 at 08:39, wrote: > > From: Christian Taedcke > > The new encrypted etype generates a cipher node in the device tree > that should not be evaluated by binman, but still be kept in the > output device tree. > > Signed-off-by: Christian Taedcke > --- > >

Re: [PATCH 08/10] cmd: add scmi command for SCMI firmware

2023-06-29 Thread Simon Glass
Hi AKASHI, On Wed, 28 Jun 2023 at 01:49, AKASHI Takahiro wrote: > > This command, "scmi", provides a command line interface to various SCMI > protocols. It supports at least initially SCMI base protocol with the sub > command, "base", and is intended mainly for debug purpose. > > Signed-off-by:

Re: [PATCH 01/10] firmware: scmi: implement SCMI base protocol

2023-06-29 Thread Simon Glass
Hi AKASHI, On Wed, 28 Jun 2023 at 01:49, AKASHI Takahiro wrote: > > SCMI base protocol is mandatory according to the SCMI specification. > > With this patch, SCMI base protocol can be accessed via SCMI transport > layers. All the commands, except SCMI_BASE_NOTIFY_ERRORS, are supported. > This is

Re: [PATCH 3/3] binman: Add tests for etype encrypted

2023-06-29 Thread Simon Glass
On Tue, 27 Jun 2023 at 08:39, wrote: > > From: Christian Taedcke > > Add tests to reach 100% code coverage for the added etype encrypted. > > Signed-off-by: Christian Taedcke > --- > > tools/binman/ftest.py | 69 +++ >

Re: [PATCH 1/3] binman: Add support for externally encrypted blobs

2023-06-29 Thread Simon Glass
Hi Christian, On Tue, 27 Jun 2023 at 08:39, wrote: > > From: Christian Taedcke > > This adds a new etype encrypted that is derived from collection. > > It creates a new cipher node in the related image similar to the > cipher node used by u-boot, see boot/image-cipher.c. > Optionally it creates

Re: [PATCH 06/12] binman: Convert mkimage to Entry_section

2023-06-29 Thread Simon Glass
Hi Jonas, On Wed, 28 Jun 2023 at 23:35, Jonas Karlman wrote: > > Hi Simon, > On 2023-06-28 13:41, Simon Glass wrote: > > From: Marek Vasut > > > > This is needed to handle mkimage with inner section located itself in a > > section. > > > > Signed-off-by: Marek Vasut > > Use BuildSectionData()

Re: Does CONFIG_I2C_EEPROM depend on CONFIG_MISC_INIT_R?

2023-06-29 Thread Simon Glass
Hi, On Thu, 29 Jun 2023 at 14:04, wrote: > > Hi, > We noticed that in the code implementation board/atmel/sama7g5ek/sama7g5ek.c, > "#if (IS_ENABLED(CONFIG_I2C_EEPROM))" is located in the condition "#if > (IS_ENABLED(CONFIG_MISC_INIT_R))". > > Consider that the CONFIG_I2C_EEPROM option requires

Re: [PATCH 1/2] disk: part: Add API to get partitions with specific driver

2023-06-29 Thread Simon Glass
Hi Joshua, On Wed, 28 Jun 2023 at 14:34, Joshua Watt wrote: > > On Mon, Jun 26, 2023 at 4:07 AM Simon Glass wrote: > > > > Hi Joshua, > > > > On Fri, 23 Jun 2023 at 21:01, Joshua Watt wrote: > > > > > > Adds part_driver_get_type() API which can be used to force a specific > > > driver to be

Re: [PATCH 06/10] test: dm: simplify SCMI unit test on sandbox

2023-06-29 Thread Simon Glass
On Wed, 28 Jun 2023 at 01:49, AKASHI Takahiro wrote: > > Adding SCMI base protocol makes it inconvenient to hold the agent instance > (udevice) locally since the agent device will be re-created per each test. > Just remove it and simply the test flows. > The test scenario is not changed at all. >

Re: [PATCH 04/10] sandbox: remove SCMI base node definition from test.dts

2023-06-29 Thread Simon Glass
On Wed, 28 Jun 2023 at 01:49, AKASHI Takahiro wrote: > > SCMI base protocol is mandatory and doesn't need to be listed in a device > tree. > > Signed-off-by: AKASHI Takahiro > --- > arch/sandbox/dts/test.dts | 4 > 1 file changed, 4 deletions(-) Reviewed-by: Simon Glass

Re: [PATCH 04/12] binman: blob_dtb: Add fake_size argument to ObtainContents()

2023-06-29 Thread Simon Glass
On Thu, 29 Jun 2023 at 15:59, wrote: > > From: Lukas Funke > > The method 'connect_contents_to_file()' calls ObtainsContents() with > 'fake_size' argument. Without providing the argument in the blob_dtb > we are not able to call this method without error. > > Signed-off-by: Lukas Funke > --- >

Re: [PATCH 05/12] binman: doc: Add documentation for fdt_add_pubkey bintool

2023-06-29 Thread Simon Glass
On Thu, 29 Jun 2023 at 15:59, wrote: > > From: Lukas Funke > > Add documentation for btool which calls 'fdt_add_pubkey' > > Signed-off-by: Lukas Funke > --- > > tools/binman/bintools.rst | 10 ++ > 1 file changed, 10 insertions(+) Reviewed-by: Simon Glass

Re: [PATCH 10/10] test: dm: add scmi command test

2023-06-29 Thread Simon Glass
On Wed, 28 Jun 2023 at 01:49, AKASHI Takahiro wrote: > > In this test, "scmi" with different sub-commands is tested. > Please note that scmi command is for debug purpose and is not > intended in production system. > > Signed-off-by: AKASHI Takahiro > --- > test/dm/scmi.c | 57

Re: [PATCH 02/12] binman: mkimage: Remove extra colon

2023-06-29 Thread Lukas Funke
On 29.06.2023 17:08, Quentin Schulz wrote: Hi Lukas, On 6/29/23 16:59, lukas.funke-...@weidmueller.com wrote: [You don't often get email from lukas.funke-...@weidmueller.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] From: Lukas Funke Remove extra

Re: [PATCH 02/12] binman: mkimage: Remove extra colon

2023-06-29 Thread Quentin Schulz
Hi Lukas, On 6/29/23 16:59, lukas.funke-...@weidmueller.com wrote: [You don't often get email from lukas.funke-...@weidmueller.com. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] From: Lukas Funke Remove extra colon typo Signed-off-by: Lukas Funke ---

[PATCH 07/12] binman: btool: Add fdt_add_pubkey as btool

2023-06-29 Thread lukas . funke-oss
From: Lukas Funke Add btool which calls 'fdt_add_pubkey' Signed-off-by: Lukas Funke --- tools/binman/btool/fdt_add_pubkey.py | 67 1 file changed, 67 insertions(+) create mode 100644 tools/binman/btool/fdt_add_pubkey.py diff --git

[PATCH 08/12] binman: etype: Add u_boot_spl_pubkey_dtb etype

2023-06-29 Thread lukas . funke-oss
From: Lukas Funke This adds a new etype 'u_boot_spl_pubkey_dtb'. The etype adds the public key from a certificate to the dtb. This creates a '/signature' node which is turn contains the fields which make up the public key. Usually this is done by 'mkimage -K'. However, 'binman sign' does not add

[PATCH 03/12] binman: Don't decompress data while signing

2023-06-29 Thread lukas . funke-oss
From: Lukas Funke While signing a fit compressed data (i.e. 'blob-ext') is decompressed, but never compressed again. When compressed data was wrapped in a section, decompression leads to an error because the outer section had the original compressed size but the inner entry has the uncompressed

[PATCH 02/12] binman: mkimage: Remove extra colon

2023-06-29 Thread lukas . funke-oss
From: Lukas Funke Remove extra colon typo Signed-off-by: Lukas Funke --- tools/binman/etype/mkimage.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/binman/etype/mkimage.py b/tools/binman/etype/mkimage.py index e028c44070..dd734fc779 100644 ---

[PATCH 09/12] binman: doc: Add documentation for Xilinx Bootgen bintool

2023-06-29 Thread lukas . funke-oss
From: Lukas Funke Add documentation for the 'bootgen' bintool Signed-off-by: Lukas Funke --- tools/binman/bintools.rst | 12 1 file changed, 12 insertions(+) diff --git a/tools/binman/bintools.rst b/tools/binman/bintools.rst index 88221adbe1..c8d69f7177 100644 ---

[PATCH 11/12] binman: ftest: Add test for xilinx_fsbl_auth etype

2023-06-29 Thread lukas . funke-oss
From: Lukas Funke Add test for the 'xilinx_fsbl_auth' etype Signed-off-by: Lukas Funke --- tools/binman/ftest.py | 8 tools/binman/test/280_xilinx_fsb_auth.dts | 22 ++ 2 files changed, 30 insertions(+) create mode 100644

[PATCH 05/12] binman: doc: Add documentation for fdt_add_pubkey bintool

2023-06-29 Thread lukas . funke-oss
From: Lukas Funke Add documentation for btool which calls 'fdt_add_pubkey' Signed-off-by: Lukas Funke --- tools/binman/bintools.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tools/binman/bintools.rst b/tools/binman/bintools.rst index c30e7eb9ff..88221adbe1 100644 ---

[PATCH 06/12] binman: ftest: Add test for u_boot_spl_pubkey_dtb

2023-06-29 Thread lukas . funke-oss
From: Lukas Funke Add test for u_boot_spl_pubkey_dtb. The test adds a public key to the dtb and checks if the required nodes will be added to the images dtb. Signed-off-by: Lukas Funke --- tools/binman/ftest.py| 32

[PATCH 12/12] binman: etype: Add xilinx_fsbl_auth etype

2023-06-29 Thread lukas . funke-oss
From: Lukas Funke This adds a new etype 'xilinx_fsbl_auth'. Using this etype it is possible to created an authenticated SPL (FSBL in Xilinx terms) for ZynqMP boards. The etype uses Xilinx Bootgen tools in order to transform the SPL into a bootable image and sign the image with a given primary

[PATCH 10/12] binman: btool: Add Xilinx Bootgen btool

2023-06-29 Thread lukas . funke-oss
From: Lukas Funke Add the Xilinx Bootgen as bintool. Xilinx Bootgen is used to create bootable SPL (FSBL in Xilinx terms) images for Zynq/ZynqMP devices. The btool creates a signed version of the SPL. Signed-off-by: Lukas Funke --- tools/binman/btool/bootgen.py | 82

[PATCH 04/12] binman: blob_dtb: Add fake_size argument to ObtainContents()

2023-06-29 Thread lukas . funke-oss
From: Lukas Funke The method 'connect_contents_to_file()' calls ObtainsContents() with 'fake_size' argument. Without providing the argument in the blob_dtb we are not able to call this method without error. Signed-off-by: Lukas Funke --- tools/binman/etype/blob_dtb.py | 2 +- 1 file changed,

[PATCH 00/12] Sign Xilinx ZynqMP SPL/FSBL boot images using binman

2023-06-29 Thread lukas . funke-oss
From: Lukas Funke This series adds two etypes to create a verified boot chain for Xilinx ZynqMP devices. The first etype 'xilinx_fsbl_auth' is used to create a bootable, signed image for ZynqMP boards using the Xilinx Bootgen tool. The second etype 'u_boot_spl_pubkey_dtb' is used to add a

[PATCH 01/12] binman: elf: Check for ELF_TOOLS availability and remove extra semicolon

2023-06-29 Thread lukas . funke-oss
From: Lukas Funke Check if elf tools are available when running DecodeElf(). Also remove superfuous semicolon at line ending. Signed-off-by: Lukas Funke --- tools/binman/elf.py | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tools/binman/elf.py

v2023.07-rc5 regression: Image overlaps SPL

2023-06-29 Thread Francesco Dolcini
Hello Marek, as briefly discussed off-list it looks like commit 77aed22b48ab ("spl: spl_legacy: Add extra address checks") introduces a regression on some board/arch, at least colibri and apalis imx6 fails to boot now ``` Trying to boot from MMC1 SPL: Image overlaps SPL resetting ... ``` >From

Re: [PATCH] rockchip: Restore support for boot scripts in legacy image format

2023-06-29 Thread Jonas Karlman
Hi Kever, On 2023-06-29 12:51, Kever Yang wrote: > Hi Jonas, > >     What is the legacy image format, does these boards really use than? > > I think most of the board using linux distro image. The legacy image format it the normal boot script format, in the documentation it is called Legacy

[PATCH v3] arm: dts: am335x-evm-u-boot: Remove usb0 mode configuration

2023-06-29 Thread Julien Panis
. It was finally decided to move usb0 mode configuration in kernel device trees. That's why a series was submitted for linux: https://lore.kernel.org/all/20230629-usb0-as-peripheral-v1-0-167f78a11...@baylibre.com/ As a consequence, usb0 dr_mode configuration must now be removed from 'am335x-evm-u

Does CONFIG_I2C_EEPROM depend on CONFIG_MISC_INIT_R?

2023-06-29 Thread sunying
Hi, We noticed that in the code implementation board/atmel/sama7g5ek/sama7g5ek.c, "#if (IS_ENABLED(CONFIG_I2C_EEPROM))" is located in the condition "#if (IS_ENABLED(CONFIG_MISC_INIT_R))". Consider that the CONFIG_I2C_EEPROM option requires access to EEPROM memory after normal initial operations

Suggestion: Does the CONFIG_RTC_DS1307 and CONFIG_DM_RTC options conflict?

2023-06-29 Thread sunying
hi, we recently noticed that RTC_DS1307 is dependent on DM_RTC in drivers/rtc/Kconfig, but the code implementation of drivers/rtc/ds1307.c: conflicts between the two. "#ifdef CONFIG_RTC_DS1307" is in the condition "#ifndef CONFIG_DM_RTC" . These two options are used to enable different RTC

Re: [PATCH v2 0/2] Fix 'no USB device found' error.

2023-06-29 Thread Julien Panis
On 6/26/23 09:32, Nishanth Menon wrote: On 13:59-20230623, Tom Rini wrote: On Fri, Jun 23, 2023 at 09:42:01AM +0200, Julien Panis wrote: On 6/22/23 17:49, Tom Rini wrote: On Thu, Jun 22, 2023 at 04:34:34PM +0200, Julien Panis wrote: This series fixes usb0 dr_mode for am335x-icev2 and

[PATCHv2 3/3] net/lwip: add lwip library for the network stack

2023-06-29 Thread Maxim Uvarov
This commit adds lwip library for the U-boot network stack. Supported commands: ping, tftp, dhcp and wget. Signed-off-by: Maxim Uvarov --- .gitignore| 9 + cmd/net.c | 38 +++- include/net.h | 2 +- lib/Kconfig

[PATCHv2 2/3] net/lwip: add README.lwip

2023-06-29 Thread Maxim Uvarov
Just add inital README.lwip doc. Signed-off-by: Maxim Uvarov --- doc/README.lwip | 90 + 1 file changed, 90 insertions(+) create mode 100644 doc/README.lwip diff --git a/doc/README.lwip b/doc/README.lwip new file mode 100644 index

[PATCHv2 1/3] net/lwip: add lwip-external submodule

2023-06-29 Thread Maxim Uvarov
This commit adds the lwip library as a git submodule. I think there has to be advantages to compile lwip inside U-boot, i.e. use the same compiler and flags as the main code. One of them is LTO and the other is to enable additional debug options for network protocol during development. Also we can

Pull request: u-boot-rockchip-20230629

2023-06-29 Thread Kever Yang
-20230629 for you to fetch changes up to d77d5301d7dc333db0425ee82499fe362abd259d: board: rockchip: rock5b-rk3588: fix description (2023-06-29 18:43:42 +0800) Eugen Hristev (2): phy: rockchip: inno-usb2: fix phy reg=0 case

Re: [PATCH v1] mtd: nand: raw: rockchip_nfc: copy hwecc PA data to oob_poi buffer

2023-06-29 Thread Kever Yang
On 2023/6/22 21:59, Johan Jonker wrote: Rockchip boot blocks are written per 4 x 512 byte sectors per page. Each page must have a page address (PA) pointer in OOB to the next page. Pages are written in a pattern depending on the NAND chip ID. This logic used to build a page pattern table is

[PATCH v4] imx: imx8mm: Add support for Mettler-Toledo snowflake board.

2023-06-29 Thread Sebastian Andrzej Siewior
The board is similar to "Kontron SL i.MX8M Mini" SoM. There are two variants. Snowflake_v2 has an external SDCard Interface. LEIG is the same, but without display and without external SDCard Interface. Both variants support only 1GiB of main memory. [ bigeasy: porting and a bit of cleanup ]

Re: [PATCH] rockchip: Restore support for boot scripts in legacy image format

2023-06-29 Thread Kever Yang
Hi Jonas,     What is the legacy image format, does these boards really use than? I think most of the board using linux distro image. Thanks, - Kever On 2023/6/27 03:43, Jonas Karlman wrote: Use of CONFIG_SPL_FIT_SIGNATURE=y cause CONFIG_LEGACY_IMAGE_FORMAT=n as default, this prevent boot

Re: [PATCH] board: rockchip: rock5b-rk3588: fix description

2023-06-29 Thread Kever Yang
On 2023/6/23 18:05, Eugen Hristev wrote: Update description with correct specifications Fixes: 3bf8e4080763 ("board: rockchip: add Radxa ROCK5B Rk3588 board") Signed-off-by: Eugen Hristev Reviewed-by: Kever Yang Thanks, - Kever --- arch/arm/mach-rockchip/rk3588/Kconfig | 10 +-

Re: [PATCH] pinctrl: rockchip: Fix Data Abort exception in SPL

2023-06-29 Thread Kever Yang
On 2023/6/8 18:59, Jonas Karlman wrote: Using CONFIG_ARMV8_SPL_EXCEPTION_VECTORS=y and CONFIG_OF_LIVE=y triggers a Data Abort exception from unaligned memory access when the pinctrl driver iterate node properties, e.g. for UART2 on RK3568. setting mux of GPIO0-24 to 1 setting mux of

Re: [PATCH] phy: rockchip: inno-usb2: fix phy reg=0 case

2023-06-29 Thread Kever Yang
On 2023/5/22 16:39, Eugen Hristev wrote: The support for #address-cells=2 has a loophole: if the reg is actually 0, but the #address-cells is actually 1, like in such case below: syscon { #address-cells = <1>; phy { reg = <0 0x10>; }; }; then the

Re: [PATCH v2 5/9] pci: pcie_dw_rockchip: Hide BARs of the root complex

2023-06-29 Thread Kever Yang
Hi Jonas,     Sorry for reply late for this patch.     I have check internally again for this BAR issue, the BAR alloce fail for RC would not affect other process, and it always works on vendor U-Boot tree.     And if we have to handle this, we can disable the BAR instead of this

[PATCH] drivers: led: bcm6753: do not use null label to find the top

2023-06-29 Thread Philippe Reynes
This driver considers that a node with an empty label is the top. But the led class has changed, if a label is not provided for a led, the label is filed with the node name. So we update this driver to use a wrapper to manage the top led node. Signed-off-by: Philippe Reynes ---

Re: [PATCH] cmd: efidebug: add missing efi_free_pool for dh subcommand

2023-06-29 Thread Ilias Apalodimas
On Thu, 29 Jun 2023 at 05:14, Masahisa Kojima wrote: > > This adds the missing efi_free_pool call for dh subcommand. > > Signed-off-by: Masahisa Kojima > --- > cmd/efidebug.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/cmd/efidebug.c b/cmd/efidebug.c > index 9622430c47..0be3af3e76

Re: [PATCH 2/5] rockchip: rk3399-pinebook-pro: Fix SPL max size and SPI flash payload offset

2023-06-29 Thread Quentin Schulz
Hi Jonas, On 6/29/23 00:11, Jonas Karlman wrote: Hi Quentin, On 2023-06-28 15:49, Quentin Schulz wrote: Hi Jonas, On 6/27/23 21:10, Jonas Karlman wrote: TPL max size is limited to 184 KB, SPL is loaded to 0x0 and TF-A is loaded to 0x4, this limit SPL max size to 256 KB. With BootRom

Re: [PATCH v3] dt-bindings: riscv: deprecate riscv,isa

2023-06-29 Thread Anup Patel
On Thu, Jun 29, 2023 at 8:49 AM Palmer Dabbelt wrote: > > On Wed, 28 Jun 2023 08:31:32 PDT (-0700), apa...@ventanamicro.com wrote: > > On Wed, Jun 28, 2023 at 7:46 PM Palmer Dabbelt wrote: > >> > >> On Tue, 27 Jun 2023 08:49:06 PDT (-0700), Palmer Dabbelt wrote: > >> > On Mon, 26 Jun 2023