Re: [PATCH] efi_loader: Allow also empty capsule to be process

2023-07-19 Thread AKASHI Takahiro
Hi, On Wed, Jul 19, 2023 at 08:28:41AM +0200, Michal Simek wrote: > > > On 7/18/23 17:41, Heinrich Schuchardt wrote: > > On 13.07.23 16:35, Michal Simek wrote: > > > Empty capsule are also allowed to be process. Without it updated images > > > can't change their Image Acceptance state from no

RE: [PATCH v1 0/6] Add support for PMICs used on Tegra 3 devices

2023-07-19 Thread Svyatoslav Ryhel
20 липня 2023 р. 06:12:23 GMT+03:00, Jaehoon Chung написав(-ла): >Hi > >> -Original Message- >> From: Svyatoslav Ryhel >> Sent: Saturday, July 15, 2023 1:16 AM >> To: Jaehoon Chung ; Simon Glass ; >> Svyatoslav Ryhel >> >> Cc: u-boot@lists.denx.de >> Subject: [PATCH v1 0/6] Add

RE: [PATCH v1 0/6] Add support for PMICs used on Tegra 3 devices

2023-07-19 Thread Jaehoon Chung
Hi > -Original Message- > From: Svyatoslav Ryhel > Sent: Saturday, July 15, 2023 1:16 AM > To: Jaehoon Chung ; Simon Glass ; > Svyatoslav Ryhel > > Cc: u-boot@lists.denx.de > Subject: [PATCH v1 0/6] Add support for PMICs used on Tegra 3 devices > > Patch set adds basic support for

[PATCH] arm: mvebu: x240: Use i2c-gpio instead of built in controller

2023-07-19 Thread Chris Packham
There is an Errata with the built-in I2C controller where various I2C hardware errors cause a complete lockup of the CPU (which eventually results in an watchdog reset). Put the I2C MPP pins into GPIO mode and use the i2c-gpio driver instead. This uses a bit-banged implementation of an I2C

RE: [PATCH 1/3] mmc: sdhci-cadence: Rename functions to SD4 specific

2023-07-19 Thread Jaehoon Chung
> -Original Message- > From: Piyush Malgujar > Sent: Monday, June 5, 2023 10:58 PM > To: peng@nxp.com; jh80.ch...@samsung.com; u-boot@lists.denx.de > Cc: jannadu...@marvell.com; ccha...@marvell.com; Dhananjay Kangude > ; Piyush > Malgujar > Subject: [PATCH 1/3] mmc:

Re: [RFC] efi_driver: fix a parent issue in efi-created block devices

2023-07-19 Thread AKASHI Takahiro
On Wed, Jul 19, 2023 at 07:29:57PM -0600, Simon Glass wrote: > Hi, > > On Wed, 19 Jul 2023 at 18:14, AKASHI Takahiro > wrote: > > > > On Wed, Jul 19, 2023 at 03:15:10PM +0200, Heinrich Schuchardt wrote: > > > On 19.07.23 15:04, Simon Glass wrote: > > > > Hi, > > > > > > > > On Tue, 18 Jul 2023

[PATCH] i2c: i2c-gpio: Correctly handle new {sda,scl}-gpios bindings

2023-07-19 Thread Chris Packham
gpio_request_list_by_name() returns the number of gpios requested. Notably it swallows the underlying -ENOENT when the "gpios" property does not exist. Update the i2c-gpio driver to check for ret == 0 before trying the new sda-gpios/scl-gpios properties. Signed-off-by: Chris Packham ---

Re: [RFC] efi_driver: fix a parent issue in efi-created block devices

2023-07-19 Thread Simon Glass
Hi, On Wed, 19 Jul 2023 at 18:14, AKASHI Takahiro wrote: > > On Wed, Jul 19, 2023 at 03:15:10PM +0200, Heinrich Schuchardt wrote: > > On 19.07.23 15:04, Simon Glass wrote: > > > Hi, > > > > > > On Tue, 18 Jul 2023 at 19:54, AKASHI Takahiro > > > wrote: > > > > > > > > Hi Simon, > > > > > > > >

Re: Aw: [PATCH 21/29] arm: dts: medaitek: convert gmac link mode to 2500base-x

2023-07-19 Thread 高惟杰
On Wed, 2023-07-19 at 14:08 +0200, Frank Wunderlich wrote: > Hi > > > Gesendet: Mittwoch, 19. Juli 2023 um 11:17 Uhr > > Von: "Weijie Gao" > > An: u-boot@lists.denx.de > > Cc: "GSS_MTK_Uboot_upstream" , > "Daniel Golle" , "Frank Wunderlich" < > li...@fw-web.de>, "Weijie Gao" > > Betreff:

Re: [PATCH v2 2/6] ramdisk: add ramdisk uclass and driver

2023-07-19 Thread Masahisa Kojima
Hi Simon, On Thu, 20 Jul 2023 at 04:11, Simon Glass wrote: > > Hi Masahisa, > > On Thu, 13 Jul 2023 at 23:47, Masahisa Kojima > wrote: > > > > This introcudes the ramdisk uclass and driver. > > > > Signed-off-by: Masahisa Kojima > > --- > > Newly introcuded in v2 > > > > disk/part.c

Re: [RFC] efi_driver: fix a parent issue in efi-created block devices

2023-07-19 Thread AKASHI Takahiro
Hi Simon, On Wed, Jul 19, 2023 at 07:04:06AM -0600, Simon Glass wrote: > Hi, > > On Tue, 18 Jul 2023 at 19:54, AKASHI Takahiro > wrote: > > > > Hi Simon, > > > > On Tue, Jul 18, 2023 at 07:08:45PM -0600, Simon Glass wrote: > > > Hi AKASHI, > > > > > > On Tue, 18 Jul 2023 at 18:22, AKASHI

Re: [PATCH v2 2/6] ramdisk: add ramdisk uclass and driver

2023-07-19 Thread Masahisa Kojima
Hi Heinrich, On Thu, 20 Jul 2023 at 00:10, Heinrich Schuchardt wrote: > > On 14.07.23 07:44, Masahisa Kojima wrote: > > This introcudes the ramdisk uclass and driver. > > > > Signed-off-by: Masahisa Kojima > > --- > > Newly introcuded in v2 > > > > disk/part.c | 3 + > >

Re: [RFC] efi_driver: fix a parent issue in efi-created block devices

2023-07-19 Thread AKASHI Takahiro
On Wed, Jul 19, 2023 at 03:15:10PM +0200, Heinrich Schuchardt wrote: > On 19.07.23 15:04, Simon Glass wrote: > > Hi, > > > > On Tue, 18 Jul 2023 at 19:54, AKASHI Takahiro > > wrote: > > > > > > Hi Simon, > > > > > > On Tue, Jul 18, 2023 at 07:08:45PM -0600, Simon Glass wrote: > > > > Hi

[PATCH v4 83/83] buildman: Enable test coverage

2023-07-19 Thread Simon Glass
Enable measuring test coverage for buildman so we can see the gaps. It is currently at 68%. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Fix 'bulidman' typo in three patches Changes in v2: - Drop patch to move -A logic up a little (since it breaks it)

[PATCH v4 82/83] buildman: Add an option to check maintainers and targets

2023-07-19 Thread Simon Glass
In poking around it seems that many boards don't define a CONFIG_TARGET Kconfig variable. This is not strictly necessary, but add an option to buildman so these can be viewed. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch with an option to check maintains

[PATCH v4 81/83] buildman: Use -D for --debug

2023-07-19 Thread Simon Glass
Change -D to mean --debug for consistency with other tools. This is not a commonly used option, so the impact should be minimal. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch to use -D for --debug tools/buildman/buildman.rst | 6 +++---

[PATCH v4 79/83] buildman: Move copy_files() out ot BuilderThread class

2023-07-19 Thread Simon Glass
This does not need to be in the class. Move it out to avoid a pylint warning. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 47 + 1 file changed, 24 insertions(+), 23 deletions(-) diff --git

[PATCH v4 80/83] buildman: Add a way to print the architecture for a board

2023-07-19 Thread Simon Glass
This is useful for some tools and is easily available for buildman. Add a new --print-arch option. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Add new patch to print the architecture for a board tools/buildman/cmdline.py | 2 ++ tools/buildman/control.py | 24

[PATCH v4 78/83] buildman: Tidy up some comments in builderthread

2023-07-19 Thread Simon Glass
Make sure all functions have full argument documentation. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 66 ++--- 1 file changed, 36 insertions(+), 30 deletions(-) diff --git a/tools/buildman/builderthread.py

[PATCH v4 77/83] buildman: Tidy up reporting of a toolchain error

2023-07-19 Thread Simon Glass
Provide the text of the exception when something goes wrong. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 7 +-- tools/buildman/func_test.py | 6 -- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git

[PATCH v4 75/83] buildman: Create a function to handle config and build

2023-07-19 Thread Simon Glass
Move this code into a _config_and_build() function, so reduce the size of run_commit(). Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 97 + 1 file changed, 61 insertions(+), 36 deletions(-) diff --git

[PATCH v4 76/83] buildman: Avoid passing result into _read_done_file()

2023-07-19 Thread Simon Glass
Move the creating of the result object into the function which sets it up, to simplify the code. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git

[PATCH v4 74/83] buildman: Move checkout code to a separate function

2023-07-19 Thread Simon Glass
Put this in its own function to reduce the size of the run_commit() function Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 30 +- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/tools/buildman/builderthread.py

[PATCH v4 73/83] buildman: Move code to decide output dirs

2023-07-19 Thread Simon Glass
Put this in its own function to reduce the size of the run_commit() function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 34 - 1 file changed, 25 insertions(+), 9 deletions(-) diff --git

[PATCH v4 72/83] buildman: Move code to remove old outputs

2023-07-19 Thread Simon Glass
Put this in its own function to reduce the size of the run_commit() function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/tools/buildman/builderthread.py

[PATCH v4 71/83] buildman: Move reading of the done file into a function

2023-07-19 Thread Simon Glass
Move this logic into its own function to reduce the size of the run_commt() function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 66 + 1 file changed, 42 insertions(+), 24 deletions(-) diff --git

[PATCH v4 70/83] buildman: Move bulid code into its own function

2023-07-19 Thread Simon Glass
Split this into its own function so reduce the size of run_commit(). Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 40 - 1 file changed, 30 insertions(+), 10 deletions(-) diff --git a/tools/buildman/builderthread.py

[PATCH v4 69/83] buildman: Move reconfigure code into its own function

2023-07-19 Thread Simon Glass
Split this into its own function so reduce the size of run_commit(). Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 41 - 1 file changed, 30 insertions(+), 11 deletions(-) diff --git a/tools/buildman/builderthread.py

[PATCH v4 68/83] buildman: Convert config_out to string IO

2023-07-19 Thread Simon Glass
This is probably a little more efficient and it allows passing the object to another function to write data. Convert config_out to use a string I/O device. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 9 + 1 file changed, 5 insertions(+), 4

[PATCH v4 67/83] buildman: Move more things into _build_args()

2023-07-19 Thread Simon Glass
Move more of the argument-building code into this function. Fix a missing assignment for out_rel_dir too. Rename the function since it now builds all the arguments. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 55 - 1

[PATCH v4 65/83] buildman: Start a function to set up the make arguments

2023-07-19 Thread Simon Glass
Move some of this code into a new funciion, to help reduce the size of the run_commits() function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 38 - 1 file changed, 23 insertions(+), 15 deletions(-) diff --git

[PATCH v4 64/83] buildman: Drop unnecessary assignment of config_out

2023-07-19 Thread Simon Glass
This is already set up earlier in the function, so drop the extra assignment. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py index

[PATCH v4 66/83] buildman: Move setting of toolchain arguments to _build_args()

2023-07-19 Thread Simon Glass
Move a few more pieces to this new function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py index

[PATCH v4 63/83] buildman: Correct invalid use of out_dir variable

2023-07-19 Thread Simon Glass
This variable has a different meaning in the outer scope. Use a different name to avoid confusion, or bugs. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Fix 'scrop' typo tools/buildman/builderthread.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH v4 58/83] buildman: Convert camel case in builder.py

2023-07-19 Thread Simon Glass
Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builder.py | 228 tools/buildman/builderthread.py | 26 ++-- tools/buildman/control.py | 13 +-

[PATCH v4 62/83] buildman: Export _get_output_dir() to avoid warnings

2023-07-19 Thread Simon Glass
Make this a public memory since it is used outside the class. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builder.py | 8 tools/buildman/builderthread.py | 2 +- tools/buildman/test.py | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-)

[PATCH v4 61/83] buildman: Correct most pylint warnings in builderthread

2023-07-19 Thread Simon Glass
Fix the easy warnings in this file. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builderthread.py | 95 ++--- 1 file changed, 51 insertions(+), 44 deletions(-) diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py

[PATCH v4 60/83] buildman: Convert camel case in builderthread.py

2023-07-19 Thread Simon Glass
Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builder.py | 8 +++--- tools/buildman/builderthread.py | 50 - 2 files changed, 29 insertions(+), 29 deletions(-) diff

[PATCH v4 57/83] buildman: Convert camel case in bsettings.py

2023-07-19 Thread Simon Glass
Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/bsettings.py | 14 +++--- tools/buildman/control.py | 2 +- tools/buildman/func_test.py | 12 ++-- tools/buildman/main.py | 2 +-

[PATCH v4 59/83] buildman: Split parser creation in two

2023-07-19 Thread Simon Glass
Split this into two functions to avoid a warning about too many statements. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/cmdline.py | 44 +-- 1 file changed, 33 insertions(+), 11 deletions(-) diff --git a/tools/buildman/cmdline.py

[PATCH v4 56/83] buildman: Convert to argparse

2023-07-19 Thread Simon Glass
Use argparse to parse the arguments, since OptionParser is deprecated now. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/cmdline.py | 130 + tools/buildman/control.py | 141 ++--

[PATCH v4 49/83] buildman: Move checking for make into run_builder()

2023-07-19 Thread Simon Glass
This is not needed until the builder is run. Move it there to reduce the size of the do_buildman() function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git

[PATCH v4 48/83] buildman: Adjust show_toolchain_prefix() to not return

2023-07-19 Thread Simon Glass
This function does not need to return. Simplify the code by exiting immediately. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tools/buildman/control.py b/tools/buildman/control.py

[PATCH v4 47/83] buildman: Drop some unnecessary variables

2023-07-19 Thread Simon Glass
Drop some variables at the end of the do_bulidman() function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/tools/buildman/control.py b/tools/buildman/control.py index

[PATCH v4 46/83] buildman: Moving running of the builder into a function

2023-07-19 Thread Simon Glass
Move this code into a new function. This removes the pylint warning about too many branches. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 56 --- 1 file changed, 35 insertions(+), 21 deletions(-) diff --git

[PATCH v4 45/83] buildman: Tweak commits and show_bloat

2023-07-19 Thread Simon Glass
Move setting of show_bloat to adjust_options() and adjust how the commits variable is set. Together these remove the pylint warning about too many statements. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 13 + 1 file changed, 5 insertions(+), 8

[PATCH v4 44/83] buildman: Move remaining builder properties to constructor

2023-07-19 Thread Simon Glass
Do these all in the constructor, so it is consistent. Move the stray builder comment into the correct place. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/builder.py | 25 ++--- tools/buildman/control.py | 18 +++--- 2 files changed, 25

[PATCH v4 43/83] buildman: Avoid too many returns in do_buildman()

2023-07-19 Thread Simon Glass
Fix the pylint warning by using a variable instead of lots of 'return' statements. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tools/buildman/control.py b/tools/buildman/control.py

[PATCH v4 55/83] buildman: Add a test for --boards

2023-07-19 Thread Simon Glass
Add a simple functional test for the --boards option. Fix the example in the docs while we are here. Also improve the docs for Builder.count so it is clearer what it contains. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Use snake case for tests

[PATCH v4 54/83] buildman: Correct most pylint warnings in cmdline

2023-07-19 Thread Simon Glass
Tidu up warnings in this file. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/cmdline.py | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/tools/buildman/cmdline.py b/tools/buildman/cmdline.py index 503c48d769ff..660a83bc3d0f 100644 ---

[PATCH v4 53/83] buildman: Convert camel case in cmdline.py

2023-07-19 Thread Simon Glass
Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/cmdline.py | 2 +- tools/buildman/func_test.py | 2 +- tools/buildman/main.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH v4 52/83] buildman: Create a function to get number of built commits

2023-07-19 Thread Simon Glass
Move this code into a function. This removes the last pylint error in the control module. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 34 +- 1 file changed, 25 insertions(+), 9 deletions(-) diff --git

[PATCH v4 51/83] buildman: Use get_alow_missing() directly to avoid var

2023-07-19 Thread Simon Glass
Avoid an unnecessary local variable by moving this code to a function. This fixes the pylint warning about too many local variables. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git

[PATCH v4 50/83] buildman: Move getting the adjust_cfg into run_builder()

2023-07-19 Thread Simon Glass
Move this into its own function to reduce the size of do_buildman(). Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 38 +++--- 1 file changed, 27 insertions(+), 11 deletions(-) diff --git a/tools/buildman/control.py

[PATCH v4 41/83] buildman: Move setting up the output dir into a function

2023-07-19 Thread Simon Glass
Move this code into a separate function to reduce the size of the main do_buildman() directory. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 45 --- 1 file changed, 33 insertions(+), 12 deletions(-) diff --git

[PATCH v4 42/83] buildman: Move commit numbering into determine_series()

2023-07-19 Thread Simon Glass
Commits are numbered for use in tests. Do this in determine_series() since it is already dealing with the series. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git

[PATCH v4 40/83] buildman: Move counting of commits into a function

2023-07-19 Thread Simon Glass
Move this code into a separate function to avoid a pylint warning in determine_series(). Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 63 +-- 1 file changed, 41 insertions(+), 22 deletions(-) diff --git

[PATCH v4 39/83] buildman: Build option-adjusting into a function

2023-07-19 Thread Simon Glass
Create a separate function to adjust options. Also move show_actions() up as far as we can in the function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 53 --- 1 file changed, 33 insertions(+), 20 deletions(-) diff

[PATCH v4 38/83] buildman: Pass option values to show_actions()

2023-07-19 Thread Simon Glass
Pass in the individual values rather than the whole options object, so we can see what is needed. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git

[PATCH v4 37/83] buildman: Pass option values to get_action_summary()

2023-07-19 Thread Simon Glass
Pass in the individual values rather than the whole options object, so we can see what is needed. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git

[PATCH v4 36/83] buildman: Move output-file setup into one place

2023-07-19 Thread Simon Glass
Collect the two parts of the output-file handling into single place. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/tools/buildman/control.py b/tools/buildman/control.py index

[PATCH v4 35/83] bulldman: Set up output_dir earlier

2023-07-19 Thread Simon Glass
Set up output_dir at the start of the main function, instead of updating the options.output_dir option. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tools/buildman/control.py

[PATCH v4 33/83] buildman: Move Boards-object code into a function

2023-07-19 Thread Simon Glass
Move the code which obtains a Boards object into its own function, to reduce the size of the main function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 74 +-- 1 file changed, 48 insertions(+), 26 deletions(-) diff

[PATCH v4 34/83] bulidman: Move toolchain handling to a function

2023-07-19 Thread Simon Glass
Move the code for dealing with toolchains out into its own function, to reduce the size of the main function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 53 --- 1 file changed, 38 insertions(+), 15 deletions(-) diff

[PATCH v4 29/83] buildman: Move dry-run handling higher in do_buildman()

2023-07-19 Thread Simon Glass
Move this up above where the builder is created, since it no-longer makes use of the builder. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 88 --- 1 file changed, 45 insertions(+), 43 deletions(-) diff --git

[PATCH v4 32/83] bulidman: Move more code to determine_series()

2023-07-19 Thread Simon Glass
Move some more series-related code here, to reduce the size of the main function. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Correct operation of -A tools/buildman/control.py | 82 --- 1 file changed, 42 insertions(+), 40

[PATCH v4 27/83] buildman: Add a test for the -A option

2023-07-19 Thread Simon Glass
This lacks a test at present. Add one. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/func_test.py | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tools/buildman/func_test.py b/tools/buildman/func_test.py index 85222b9f9bc2..ca579a27c61f 100644 ---

[PATCH v4 31/83] buildman: Move board-selection code into a function

2023-07-19 Thread Simon Glass
Create a new determine_boards() function to hold the code which selects which boards to build. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Correct test failure when using incorrect variable tools/buildman/control.py | 59 --- 1

[PATCH v4 30/83] buildman: Add tests for excluding things

2023-07-19 Thread Simon Glass
Add some tests for the -x flag. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch to test for excluding things tools/buildman/func_test.py | 24 1 file changed, 24 insertions(+) diff --git a/tools/buildman/func_test.py

[PATCH v4 28/83] buildman: Drop use of builder in show_actions()

2023-07-19 Thread Simon Glass
This function only needs the output directory from the builder. This is passed into the builder, so just pass the same value to show_actions(). The avoids needing a builder to call show_actions(). Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 8 1

[PATCH v4 26/83] buildman: Move fetch-arch code into a separate function

2023-07-19 Thread Simon Glass
Reduce the size of the do_buildman() function a little by moving the code that handles --fetch-arch into a separate function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 49 +-- 1 file changed, 31 insertions(+), 18

[PATCH v4 23/83] buildman: Fix most pylint warnings in control

2023-07-19 Thread Simon Glass
Tidy up the easier-to-fix pylint warnings in module 'control'. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 119 +--- tools/buildman/func_test.py | 2 +- 2 files changed, 71 insertions(+), 50 deletions(-) diff --git

[PATCH v4 25/83] buildman: Move series calculations into a separate function

2023-07-19 Thread Simon Glass
Reduce the size of the do_buildman() function a little by moving the code that figures out the series into a separate function. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 95 +++ 1 file changed, 56 insertions(+), 39

[PATCH v4 24/83] buildman: Move full-help processing to main

2023-07-19 Thread Simon Glass
This does not need any of the control features. Move it out of main to reduce the size of the do_buildman() function. For Python 3.6 the -H feature will not work, but this does not seem to be a huge problem, as it dates from 2016. Signed-off-by: Simon Glass --- (no changes since v1)

[PATCH v4 22/83] buildman: Convert camel case in control.py

2023-07-19 Thread Simon Glass
Convert this file to snake case and update all files which use it. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/control.py | 31 ++- tools/buildman/func_test.py | 7 --- tools/buildman/main.py | 3 +-- tools/buildman/test.py

[PATCH v4 20/83] buildman: Provide an argument to the -R option

2023-07-19 Thread Simon Glass
Allow writing the file to a selected location, since otherwise this is controlled by the buildman configuration, so cannot be determined by the caller. Signed-off-by: Simon Glass Fixes: https://source.denx.de/u-boot/u-boot/-/issues/17 --- (no changes since v1) tools/buildman/buildman.rst | 7

[PATCH v4 19/83] buildman: Add an option to check maintainers

2023-07-19 Thread Simon Glass
Rather than using the -R option to get this report as a side effect, add a dedicated option for it. Disable CI for now as there are some missing maintainers, unfortunately. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch with an option to check maintainers

[PATCH v4 21/83] buildman: Tidy up pylint warnings in main

2023-07-19 Thread Simon Glass
Tidy up the various pylint warnings in module 'main'. Signed-off-by: Simon Glass --- (no changes since v1) tools/buildman/main.py | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/tools/buildman/main.py b/tools/buildman/main.py index

[PATCH v4 18/83] buildman: Correct logic for missing maintainers

2023-07-19 Thread Simon Glass
An orphaned board should produce a warning, as should a missing name for the maintainer (when '-' is provided). Add these cases. Signed-off-by: Simon Glass --- Changes in v4: - Add new patch to correct logic for missing maintainers tools/buildman/boards.py| 14 +-

[PATCH v4 17/83] buildman: Sort the maintainer warnings

2023-07-19 Thread Simon Glass
Sort the warnings into alphabetical order, for easier reading. Also make sure that the buildman test files are ignored. Signed-off-by: Simon Glass --- Changes in v4: - Add new patch to sort the maintainer warnings tools/buildman/boards.py| 4 ++-- tools/buildman/func_test.py | 5 +++-- 2

[PATCH v4 16/83] buildman: Just display a single line for missing maintainers

2023-07-19 Thread Simon Glass
At present we get multiple lines of output when a board has no MAINTAINERS entry: WARNING: no status info for 'bananapi-m2-pro' WARNING: no maintainers for 'bananapi-m2-pro' Suppress the 'status' one since it is implied by the other. Signed-off-by: Simon Glass --- (no changes since v3)

[PATCH v4 15/83] buildman: Correct operation of MAINTAINERS N:

2023-07-19 Thread Simon Glass
This doesn't work as intended. Instead it scans every defconfig file in the source tree. Fix it and add a test. Signed-off-by: Simon Glass --- Changes in v4: - Use search() instead of fullmatch() to allow partial matches Changes in v3: - Add new patch to correct operation of MAINTAINERS N:

[PATCH v4 14/83] buildman: Detect boards with no CONFIG_TARGET defined

2023-07-19 Thread Simon Glass
We generally expected exactly one of these. Add a check for it. Note: This warning is not displayed by default. An option will be added to enable it. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch to detect boards with no CONFIG_TARGET defined

[PATCH v4 13/83] buildman: Detect boards with multiple CONFIG_TARGETs defined

2023-07-19 Thread Simon Glass
The TARGET_xxx options are special in that they refer to a single target. Exactly one should be enabled for each target, corresponding to a defconfig file. Detect configs which result in two TARGET_xxx options being set. For example, at present, TARGET_POLEG and TARET_POLEG_EVB are enabled for

[PATCH v4 12/83] buildman: Refactor target handling in Boards.scan()

2023-07-19 Thread Simon Glass
Move the assert to the top of the function and provide an explicit variables for the target name and base name. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch to refactor target handling in Boards.scan() tools/buildman/boards.py | 8 +--- 1 file

[PATCH v4 11/83] buildman: Warn about dangling maintainer entries

2023-07-19 Thread Simon Glass
Other than the top-level MAINTAINERS file, all maintainer entries should actually reference a target. Add a warning to detect those that do not. Signed-off-by: Simon Glass --- Changes in v4: - Reword the warning message Changes in v3: - Add new patch to warn about dangling maintainer entries

[PATCH v4 09/83] buildman: Add a partial test for ensure_board_list()

2023-07-19 Thread Simon Glass
Create a new function which has the non-UI parts of ensure_board_list(). Add some tests for everything except the N: tag. While we are here, fix the confusing usage of fname inside a loops that also uses fname. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new

[PATCH v4 10/83] buildman: Tidy up common code in parse_file()

2023-07-19 Thread Simon Glass
Use a function to add to the maintainers database, to avoid duplicating the same code twice. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch to tidy up common code in parse_file() tools/buildman/boards.py | 13 - 1 file changed, 8

[PATCH v4 08/83] buildman: Add a test for Boards.output_is_new()

2023-07-19 Thread Simon Glass
Add a test for this code, adjusting the timestamp on various files to check each use case. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch with a test for Boards.output_is_new() tools/buildman/func_test.py | 61 + 1 file

[PATCH v4 07/83] buildman: Add a test for Boards.scan_defconfigs()

2023-07-19 Thread Simon Glass
Add a test for this code. It requires some defconfig files and a test Kconfig to work with, so copy these into the temporary directory at the start. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch with a test for Boards.scan_defconfigs()

[PATCH v4 06/83] buildman: Avoid globals in leaf functions

2023-07-19 Thread Simon Glass
Rather than using the global thoughout each function, pass in these values. This allows tests to use different values when testing the same functions. Improve a few comments while we are here. No functional change is intended. Signed-off-by: Simon Glass --- (no changes since v3) Changes in

[PATCH v4 03/83] buildman: Exit with the return code consistently

2023-07-19 Thread Simon Glass
Test should return a suitable exit code when they fail. Fix this and tidy up the code a little. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch to exit with the return code consistently tools/buildman/main.py | 8 +--- 1 file changed, 5 insertions(+),

[PATCH v4 04/83] buildman: Rename the ARM boards

2023-07-19 Thread Simon Glass
Use names consistent with their target names. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch to rename the ARM boards tools/buildman/func_test.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/buildman/func_test.py

[PATCH v4 02/83] buildman: Allow --debug to enable debugging

2023-07-19 Thread Simon Glass
The -D option is used, but plumb it through --debug to enable a full traceback when something goes wrong. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch to allow --debug to enable debugging tools/buildman/main.py | 7 --- 1 file changed, 4

[PATCH v4 05/83] buildman: Drop dead code to handle :CONFIG_ construct

2023-07-19 Thread Simon Glass
This is not needed anymore, so drop it. Signed-off-by: Simon Glass Fixes: 252ed872 ("kconfig: remove meaningless prefixes in defconfig files") --- (no changes since v3) Changes in v3: - Add new patch to drop dead code to handle :CONFIG_ construct tools/buildman/boards.py | 14 +-

[PATCH v4 01/83] buildman: Fix verboose typo and add comment

2023-07-19 Thread Simon Glass
Fix the typo in the RunTests() function, adding comments while we are here. Signed-off-by: Simon Glass --- (no changes since v3) Changes in v3: - Add new patch to fix verboose typo and add comment tools/buildman/main.py | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff

[PATCH v4 00/83] buildman: Refactor code and correct some pylint warnings

2023-07-19 Thread Simon Glass
The buildman code has grown considerable since it was originally written. In places it can be quite hard to understanding and work with. This series improves things, particularly in the control and builder parts, splitting functions into smaller sizes. More work remains in

Re: [PATCH v3 5/9] pci: pcie_dw_rockchip: Hide BARs of the root complex

2023-07-19 Thread Jonas Karlman
Hi Kever, On 2023-07-19 10:20, Kever Yang wrote: > Hi Jonas, > >     Pls check if below patch available for you: > > https://patchwork.ozlabs.org/project/uboot/patch/20230719081749.976334-1-kever.y...@rock-chips.com/ That works great and is much cleaner, thanks! I had to rework the patch a

[PATCH 5/5] mmc: dw_mmc: Keep vqmmc-supply enable count in balance

2023-07-19 Thread Jonas Karlman
With the commit 4fcba5d556b4 ("regulator: implement basic reference counter"), keeping regulator enablement in balance become more important. Disable vqmmc-supply before signal voltage is changed to keep regulator enable counter in balance. Signed-off-by: Jonas Karlman --- drivers/mmc/dw_mmc.c

[PATCH 4/5] mmc: Use regulator_set_enable_if_allowed

2023-07-19 Thread Jonas Karlman
With the commit 4fcba5d556b4 ("regulator: implement basic reference counter") the return value of regulator_set_enable may be EALREADY or EBUSY for fixed/gpio regulators. Change to use the more relaxed regulator_set_enable_if_allowed to continue if regulator already was enabled or disabled.

  1   2   3   >