Re: [PATCH 4/5] mmc: Use regulator_set_enable_if_allowed

2023-07-26 Thread Svyatoslav Ryhel
чт, 20 лип. 2023 р. о 00:21 Jonas Karlman пише: > > With the commit 4fcba5d556b4 ("regulator: implement basic reference > counter") the return value of regulator_set_enable may be EALREADY or > EBUSY for fixed/gpio regulators. > > Change to use the more relaxed regulator_set_enable_if_allowed to

Re: [PATCH 2/6] arm_ffa: introduce armffa command

2023-07-26 Thread Heinrich Schuchardt
On 3/29/22 17:16, abdellatif.elkhl...@arm.com wrote: From: Abdellatif El Khlifi Provide armffa command showcasing the use of the FF-A driver The armffa command allows to query secure partitions data from the secure world and exchanging messages with the partitions. Signed-off-by: Abdellatif

Re: [PATCH 0/4] net: ti: am65-cpsw-nuss: Fix DT binding handling of pinctrl

2023-07-26 Thread Ravi Gunasekaran
On 7/26/23 6:22 PM, Nishanth Menon wrote: > On 14:44-20230726, Ravi Gunasekaran wrote: > [...] >> If it is the former, then would a duplicate mdio node help keep the changes >> to minimum? > > That is worse hack. How does it make sense to have two mdio nodes to >

Re: [PATCH 0/4] net: ti: am65-cpsw-nuss: Fix DT binding handling of pinctrl

2023-07-26 Thread Ravi Gunasekaran
Maxime, On 7/26/23 6:19 PM, Maxime Ripard wrote: > Hi Ravi, > > On Wed, Jul 26, 2023 at 02:44:00PM +0530, Ravi Gunasekaran wrote: >> On 7/20/23 7:42 PM, Maxime Ripard wrote: >>> Hi >>> >>> Sorry, I didn't receive Roger mail so I'll reply here >>> >>> On Thu, Jul 20, 2023 at 09:00:19AM -0500,

Re: [PATCH 5/9] board_f: Fix corruption of relocaddr

2023-07-26 Thread Nikhil M Jain
Hi Simon, On 27/07/23 06:23, Simon Glass wrote: Hi Devarsh, On Wed, 26 Jul 2023 at 05:09, Devarsh Thakkar wrote: Hi Simon, On 26/07/23 02:58, Simon Glass wrote: Hi Devarsh, On Tue, 25 Jul 2023 at 03:21, Devarsh Thakkar wrote: Hi Simon, On 24/07/23 20:22, Simon Glass wrote: When the

[PATCH 5/5] configs: iot2050: Enabled keyed autoboot

2023-07-26 Thread Jan Kiszka
From: Jan Kiszka Only accept SPACE to stop autobooting. This is safer to avoid accidental interruptions on unattended devices. Signed-off-by: Jan Kiszka --- configs/iot2050_defconfig | 4 1 file changed, 4 insertions(+) diff --git a/configs/iot2050_defconfig b/configs/iot2050_defconfig

[PATCH 3/5] boards: siemens: iot2050: Unify PG1 and PG2/M.2 configurations again

2023-07-26 Thread Jan Kiszka
From: Jan Kiszka This avoids having to maintain to defconfigs that are 99% equivalent. The approach is to use binman to generate two flash images, flash-pg1.bin and flash-pg2.bin. With the help of a template dtsi, we can avoid duplicating the common binman image definitions. Suggested-by:

[PATCH 0/5] iot2050: 2023.10-rc1 fixes and cleanups

2023-07-26 Thread Jan Kiszka
[resent, now that the list is working again] Most of this comes late, but primarily as the required binman templating changes were awaited, and the lots of regressions hit this board. I really hope we can not only merge the minimally required patch 1 of this series. Jan CC: Andrew Davis CC:

[PATCH 4/5] doc: board: siemens: iot2050: Update build env vars

2023-07-26 Thread Jan Kiszka
From: Jan Kiszka ATF is now called BL31, and OP-TEE since 3.21 suggests to use tee-raw.bin instead of (the still identical) tee-pager_v2.bin. Signed-off-by: Jan Kiszka --- doc/board/siemens/iot2050.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 2/5] iot2050: Use binman in signing script

2023-07-26 Thread Jan Kiszka
From: Jan Kiszka The underlying issue was fixed in the meantime. Also signing the U-Boot proper fit image now works. Just supporting custom cert templates remains a todo. Signed-off-by: Jan Kiszka --- CC: Simon Glass --- tools/iot2050-sign-fw.sh | 9 ++--- 1 file changed, 2

[PATCH 1/5] boards: siemens: iot2050: Fix boot configuration

2023-07-26 Thread Jan Kiszka
From: Jan Kiszka The common env bits now come via ti_armv7_common.env, include it. Futhermore restore the board-specific boot targets and their ordering that is now enforced k3-wide differently. Finally, enable CONFIG_LEGACY_IMAGE_FORMAT explicitly which got lost while turning FIT_SIGNATURE on

Re: [PATCH] xhci_register: Fix double free on failure

2023-07-26 Thread Richard Habeeb
Thanks, my apologies. On Wed, Jul 26, 2023 at 10:01 PM Marek Vasut wrote: > On 7/24/23 21:45, Richard Habeeb wrote: > > drivers/core/device.c will call `device_free()` after xhci_register > > already frees the private device data. This can cause a crash later > > during the boot process,

[PATCH 5/5] bootstd: Init the size before reading extlinux file

2023-07-26 Thread Simon Glass
The implementation in extlinux_pxe_getfile() does not pass a valid size to bootmeth_read_file(), so this can fail if the uninited value happens to be too small. Fix this. Signed-off-by: Simon Glass --- boot/bootmeth_pxe.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH 4/5] bootstd: Init the size before reading the devicetree

2023-07-26 Thread Simon Glass
The implementation in distro_efi_try_bootflow_files() does not pass a valid size to bootmeth_common_read_file(), so this can fail if the uninted value happens to be too small. Fix this. This was reported by someone but I cannot now find the email. Signed-off-by: Simon Glass ---

[PATCH 2/5] bootstd: Use a function to detect network in EFI bootmeth

2023-07-26 Thread Simon Glass
This checks for a network-based bootflow in two places, one of which is less than ideal. Move the correct test into a function and use it in both places. Signed-off-by: Simon Glass --- boot/bootmeth_efi.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git

[PATCH 3/5] bootstd: Avoid allocating memory for the EFI file

2023-07-26 Thread Simon Glass
The current bootflow-iteration algorithm reads the bootflow file into an allocated memory buffer so it can be examined. This works well in most cases. However, while the common case is that the first bootflow is immediately booted, it is also possible just to scan for available bootflows, perhaps

[PATCH 1/5] bootflow: Export setup_fs()

2023-07-26 Thread Simon Glass
This function is used in some bootmeth implementations. Export it. Signed-off-by: Simon Glass --- boot/bootmeth-uclass.c | 23 ++- include/bootmeth.h | 13 + 2 files changed, 19 insertions(+), 17 deletions(-) diff --git a/boot/bootmeth-uclass.c

[PATCH 0/5] bootstd: Fix some reported problems

2023-07-26 Thread Simon Glass
This little series fixes a few problems reported over the past few months. The main changes is to the EFI bootmeth, which now delays reading the .efi file until it is actually needed. Simon Glass (5): bootflow: Export setup_fs() bootstd: Use a function to detect network in EFI bootmeth

Re: [PATCH v2 05/12] firmware: scmi: install base protocol to SCMI agent

2023-07-26 Thread Simon Glass
Hi, On Wed, 26 Jul 2023 at 19:07, AKASHI Takahiro wrote: > > Hi Simon, > > Thank you for your extensive review. Cheers. > > On Wed, Jul 26, 2023 at 06:50:23PM -0600, Simon Glass wrote: > > Hi, > > > > On Wed, 26 Jul 2023 at 02:39, AKASHI Takahiro > > wrote: > > > > > > SCMI base protocol is

Re: [PATCH] xhci_register: Fix double free on failure

2023-07-26 Thread Marek Vasut
On 7/24/23 21:45, Richard Habeeb wrote: drivers/core/device.c will call `device_free()` after xhci_register already frees the private device data. This can cause a crash later during the boot process, observed on aarch64 RPi4b as a synchronous exception. All callers of xhci_register use

Re: [PATCH] riscv: Support riscv64 image type

2023-07-26 Thread Leo Liang
Hi Rick, On Thu, Jul 27, 2023 at 09:27:31AM +0800, Rick Chen wrote: > > Hi Rick, > > > > On Wed, 19 Apr 2023 at 00:56, Rick Chen wrote: > > > > > > Hi Simon, > > > > > > > Hi Rick, > > > > > > > > On Mon, 10 Apr 2023 at 01:26, Rick Chen wrote: > > > > > > > > > > Allow U-Boot to load 32 or 64

Re: [PATCH] riscv: Support riscv64 image type

2023-07-26 Thread Rick Chen
> Hi Rick, > > On Wed, 19 Apr 2023 at 00:56, Rick Chen wrote: > > > > Hi Simon, > > > > > Hi Rick, > > > > > > On Mon, 10 Apr 2023 at 01:26, Rick Chen wrote: > > > > > > > > Allow U-Boot to load 32 or 64 bits RISC-V Kernel Image > > > > distinguishly. It helps to avoid someone maybe make a

Re: [PATCH v2 05/12] firmware: scmi: install base protocol to SCMI agent

2023-07-26 Thread AKASHI Takahiro
Hi Simon, Thank you for your extensive review. On Wed, Jul 26, 2023 at 06:50:23PM -0600, Simon Glass wrote: > Hi, > > On Wed, 26 Jul 2023 at 02:39, AKASHI Takahiro > wrote: > > > > SCMI base protocol is mandatory, and once SCMI node is found in a device > > tree, the protocol handle (udevice)

Re: [PATCH 1/4] rockchip: rk3308: fix board_debug_uart_init

2023-07-26 Thread Tom Rini
On Thu, Jul 27, 2023 at 09:00:52AM +0800, Kever Yang wrote: > Hi Tom, > >     I have reply the review tag to the list last week, but this mail does > not appear at the patchwork system[1], > > did you met this kind of issue and do you know how to fix it? There've been a few hiccups with the

Re: [PATCH] fs/erofs: Remove an unnecessary assertion

2023-07-26 Thread Sam Edwards
Thanks greatly for the speedy turnaround on this patch! On 7/25/23 22:56, Yifan Zhao wrote: Fixes: 3a21e92fc255 ("fs/erofs: Introduce new features including ztailpacking, fragments and dedupe") Signed-off-by: Yifan Zhao Tested-by: Sam Edwards

Re: [PATCH 1/4] rockchip: rk3308: fix board_debug_uart_init

2023-07-26 Thread Kever Yang
Hi Tom,     I have reply the review tag to the list last week, but this mail does not appear at the patchwork system[1], did you met this kind of issue and do you know how to fix it? Thanks, - Kever [1]

Re: [PATCH v2 02/12] firmware: scmi: implement SCMI base protocol

2023-07-26 Thread Simon Glass
On Wed, 26 Jul 2023 at 02:38, AKASHI Takahiro wrote: > > SCMI base protocol is mandatory according to the SCMI specification. > > With this patch, SCMI base protocol can be accessed via SCMI transport > layers. All the commands, except SCMI_BASE_NOTIFY_ERRORS, are supported. > This is because

Re: [PATCH v2 01/12] scmi: refactor the code to hide a channel from devices

2023-07-26 Thread Simon Glass
On Wed, 26 Jul 2023 at 02:38, AKASHI Takahiro wrote: > > The commit 85dc58289238 ("firmware: scmi: prepare uclass to pass channel > reference") added an explicit parameter, channel, but it seems to make > the code complex. > > Hiding this parameter will allow for adding a generic

Re: [RFC PATCH 01/10] remoteproc: move resource table definition

2023-07-26 Thread Simon Glass
On Tue, 25 Jul 2023 at 08:08, Tanmay Shah wrote: > > Resource table is defined in multiple files. Instead move > definition to remoteproc header file and include header file > in multiple c files where resource table definition is needed. > > Signed-off-by: Tanmay Shah > --- >

Re: [PATCH 1/5] x86: fsp: Use mtrr_set_next_var() for graphics memory

2023-07-26 Thread Simon Glass
Hi Bin, On Tue, 25 Jul 2023 at 07:43, Bin Meng wrote: > > Hi Simon, > > On Mon, Jul 24, 2023 at 6:14 AM Simon Glass wrote: > > > > Hi Bin, > > > > On Sun, 23 Jul 2023 at 09:50, Bin Meng wrote: > > > > > > Hi Simon, > > > > > > On Sun, Jul 23, 2023 at 11:43 AM Simon Glass wrote: > > > > > > >

Re: Strange construct in binman description

2023-07-26 Thread Simon Glass
Hi Tim, On Mon, 24 Jul 2023 at 08:53, Simon Glass wrote: > > Hi, > > On Sun, 23 Jul 2023 at 03:00, Marcel Ziswiler > wrote: > > > > Hi Simon > > > > On Jul 23, 2023 05:48, Simon Glass wrote: > > > > Hi Marcel, > > > > I just noticed this in an imx8 description: > > > > binman_configuration:

Re: [PATCH] remoteproc: uclass: Clean up a return

2023-07-26 Thread Simon Glass
On Wed, 26 Jul 2023 at 10:50, Dan Carpenter wrote: > > We know that "pa" is non-NULL so it's nicer to just return zero instead > of return !pa. This has no effect on runtime behavior. > > Signed-off-by: Dan Carpenter > --- > drivers/remoteproc/rproc-uclass.c | 2 +- > 1 file changed, 1

Re: [PATCH 2/5] usb: dwc2: Use regulator_set_enable_if_allowed

2023-07-26 Thread Simon Glass
On Wed, 19 Jul 2023 at 15:21, Jonas Karlman wrote: > > With the commit 4fcba5d556b4 ("regulator: implement basic reference > counter") the return value of regulator_set_enable may be EALREADY or > EBUSY for fixed/gpio regulators. > > Change to use the more relaxed regulator_set_enable_if_allowed

Re: [PATCH] video: Add parentheses around VNBYTES() macro

2023-07-26 Thread Simon Glass
On Wed, 26 Jul 2023 at 00:54, Dan Carpenter wrote: > > The VNBYTES() macro needs to have parentheses to prevent some (harmless) > macro expansion bugs. The VNBYTES() macro is used like this: > > VID_TO_PIXEL(x) * VNBYTES(vid_priv->bpix) > > The * operation is done before the / operation.

Re: [PATCH 5/9] board_f: Fix corruption of relocaddr

2023-07-26 Thread Simon Glass
Hi Devarsh, On Wed, 26 Jul 2023 at 05:09, Devarsh Thakkar wrote: > > Hi Simon, > > On 26/07/23 02:58, Simon Glass wrote: > > Hi Devarsh, > > > > On Tue, 25 Jul 2023 at 03:21, Devarsh Thakkar wrote: > >> > >> Hi Simon, > >> > >> On 24/07/23 20:22, Simon Glass wrote: > >>> When the video

Re: [PATCH v2 2/4] rockchip: Add support to generate LZMA compressed U-boot binary

2023-07-26 Thread Simon Glass
On Mon, 24 Jul 2023 at 21:51, Manoj Sai wrote: > > Add support for generating a LZMA-compressed U-boot binary with the > help of binman, if CONFIG_SPL_LZMA is selected. > > Signed-off-by: Manoj Sai > --- > arch/arm/dts/rockchip-u-boot.dtsi | 4 > 1 file changed, 4 insertions(+)

Re: [PATCH v2 3/4] spl: fit: support for booting a GZIP-compressed U-boot binary

2023-07-26 Thread Simon Glass
On Mon, 24 Jul 2023 at 21:51, Manoj Sai wrote: > > If GZIP Compression support is enabled, GZIP compressed U-Boot binary > will be at a specified RAM location which is defined at > CONFIG_SYS_LOAD_ADDR and will be assign it as the source address. > > gunzip function in spl_load_fit_image ,will

Re: [PATCH 1/1] efi_loader: simplify dp_fill()

2023-07-26 Thread Simon Glass
On Wed, 26 Jul 2023 at 07:02, Heinrich Schuchardt wrote: > > On 23.07.23 05:48, Simon Glass wrote: > > Hi Heinrich, > > > > On Fri, 21 Jul 2023 at 00:34, Heinrich Schuchardt > > wrote: > >> > >> Move the recursive dp_fill(dev->parent) call to a single location. > >> Determine uclass_id only

Re: [PATCH v2 04/12] firmware: scmi: framework for installing additional protocols

2023-07-26 Thread Simon Glass
On Wed, 26 Jul 2023 at 02:39, AKASHI Takahiro wrote: > > This framework allows SCMI protocols to be installed and bound to the agent > so that the agent can manage and utilize them later. > > Signed-off-by: AKASHI Takahiro > --- > v2 > * check for availability of protocols > --- >

Re: [PATCH v2 09/12] test: dm: add SCMI base protocol test

2023-07-26 Thread Simon Glass
\On Wed, 26 Jul 2023 at 02:39, AKASHI Takahiro wrote: > > Added is a new unit test for SCMI base protocol, which will exercise all > the commands provided by the protocol, except SCMI_BASE_NOTIFY_ERRORS. > $ ut dm scmi_base > It is assumed that test.dtb is used as sandbox's device tree. > >

Re: [PATCH v2 4/4] spl: fit: support for booting a LZMA-compressed U-boot binary

2023-07-26 Thread Simon Glass
On Mon, 24 Jul 2023 at 21:51, Manoj Sai wrote: > > If LZMA Compression support is enabled, LZMA compressed U-Boot > binary will be placed at a specified RAM location which is > defined at CONFIG_SYS_LOAD_ADDR and will be assigned as the > source address. > > image_decomp() function, will

Re: [PATCH v2 1/4] rockchip: Add support to generate GZIP compressed U-boot binary

2023-07-26 Thread Simon Glass
On Mon, 24 Jul 2023 at 21:51, Manoj Sai wrote: > > Add support for generating a GZIP-compressed U-boot binary with the > help of binman, if CONFIG_SPL_GZIP is selected. > > Signed-off-by: Manoj Sai > --- > arch/arm/dts/rockchip-u-boot.dtsi | 7 +++ > 1 file changed, 7 insertions(+)

Re: [RFC PATCH 03/10] remoteproc: add remoteproc virtio transport driver

2023-07-26 Thread Simon Glass
Hi Tanmay, On Tue, 25 Jul 2023 at 08:08, Tanmay Shah wrote: > > Remoteproc virtio is virtio transport layer driver for remoteproc. > Implement virtio config ops used by actual virtio > driver using remoteproc virtio device > > Ported from the Linux kernel version 6.4-rc2 (d848a4819d85), >

Re: [PATCH v2 12/12] test: dm: add scmi command test

2023-07-26 Thread Simon Glass
On Wed, 26 Jul 2023 at 02:40, AKASHI Takahiro wrote: > > In this test, "scmi" command is tested against different sub-commands. > Please note that scmi command is for debug purpose and is not intended > in production system. > > Signed-off-by: AKASHI Takahiro > Reviewed-by: Simon Glass > --- >

Re: [PATCH 4/5] mmc: Use regulator_set_enable_if_allowed

2023-07-26 Thread Simon Glass
On Wed, 19 Jul 2023 at 15:21, Jonas Karlman wrote: > > With the commit 4fcba5d556b4 ("regulator: implement basic reference > counter") the return value of regulator_set_enable may be EALREADY or > EBUSY for fixed/gpio regulators. > > Change to use the more relaxed regulator_set_enable_if_allowed

Re: [PATCH 18/18] riscv: qemu: Enable usb keyboard as an input device

2023-07-26 Thread Simon Glass
On Tue, 25 Jul 2023 at 01:05, Rick Chen wrote: > > > From: U-Boot On Behalf Of Bin Meng > > Sent: Sunday, July 23, 2023 12:41 PM > > To: Simon Glass ; u-boot@lists.denx.de > > Cc: Bin Meng ; Heinrich Schuchardt > > Subject: [PATCH 18/18] riscv: qemu: Enable usb keyboard as an input device > > >

Re: [PATCH 2/5] iot2050: Use binman in signing script

2023-07-26 Thread Simon Glass
On Wed, 26 Jul 2023 at 09:21, Jan Kiszka wrote: > > From: Jan Kiszka > > The underlying issue was fixed in the meantime. Also signing the U-Boot > proper fit image now works. Just supporting custom cert templates > remains a todo. > > Signed-off-by: Jan Kiszka > --- > CC: Simon Glass > --- >

Re: [PATCH v2 11/12] doc: cmd: add documentation for scmi

2023-07-26 Thread Simon Glass
On Wed, 26 Jul 2023 at 02:40, AKASHI Takahiro wrote: > > This is a help text for scmi command. > > Signed-off-by: AKASHI Takahiro > --- > v2 > * add more descriptions about SCMI > --- > doc/usage/cmd/scmi.rst | 126 + > 1 file changed, 126 insertions(+) >

Re: [PATCH v2 10/12] cmd: add scmi command for SCMI firmware

2023-07-26 Thread Simon Glass
On Wed, 26 Jul 2023 at 02:40, AKASHI Takahiro wrote: > > This command, "scmi", may provide a command line interface to various SCMI > protocols. It supports at least initially SCMI base protocol and is > intended mainly for debug purpose. > > Signed-off-by: AKASHI Takahiro > --- > v2 > * remove

Re: [PATCH v2 05/12] firmware: scmi: install base protocol to SCMI agent

2023-07-26 Thread Simon Glass
Hi, On Wed, 26 Jul 2023 at 02:39, AKASHI Takahiro wrote: > > SCMI base protocol is mandatory, and once SCMI node is found in a device > tree, the protocol handle (udevice) is unconditionally installed to > the agent. Then basic information will be retrieved from SCMI server via > the protocol

Re: [PATCH 1/1] fat: correct sign for deletion mark

2023-07-26 Thread Simon Glass
On Wed, 26 Jul 2023 at 02:33, Heinrich Schuchardt wrote: > > The FAT file systems uses character '\xe5' to mark a deleted directory > entry. If a file name starts with this character, it is substituted by > '\x05' in the directory entry. > > While (signed char)'\xe5' is a negative number 0xe5 is

Re: [RFC PATCH 1/3] scripts: kconfig: Add config fragment support in board/../

2023-07-26 Thread Simon Glass
Hi Tom, On Wed, 19 Jul 2023 at 07:34, Tom Rini wrote: > > On Tue, Jul 18, 2023 at 07:07:58PM -0600, Simon Glass wrote: > > Hi, > > > > On Sun, 16 Jul 2023 at 09:12, Tom Rini wrote: > > > > > > On Sat, Jul 15, 2023 at 05:40:35PM -0600, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On Thu,

Re: [PATCH v2 03/12] firmware: scmi: move scmi_bind_protocols() backward

2023-07-26 Thread Simon Glass
On Wed, 26 Jul 2023 at 02:38, AKASHI Takahiro wrote: > > Move the location of scmi_bind_protocols() backward for changes > in later patches. > There is no change in functionality. > > Signed-off-by: AKASHI Takahiro > --- > drivers/firmware/scmi/scmi_agent-uclass.c | 118 +++--- >

Re: [RFC PATCH 04/10] drivers: add RPMsg framework

2023-07-26 Thread Simon Glass
Hi Tanmay, On Tue, 25 Jul 2023 at 08:08, Tanmay Shah wrote: > > RPMsg framework is used to communicate to remote processor > using rpmsg protocol. > > This framework is ported from the Linux kernel > directory: drivers/rpmsg/ > kernel version: 6.4-rc2 (d848a4819d85) > > Signed-off-by: Tanmay

Re: [RFC] efi_driver: fix a parent issue in efi-created block devices

2023-07-26 Thread Simon Glass
Hi, On Wed, 19 Jul 2023 at 20:56, AKASHI Takahiro wrote: > > On Wed, Jul 19, 2023 at 07:29:57PM -0600, Simon Glass wrote: > > Hi, > > > > On Wed, 19 Jul 2023 at 18:14, AKASHI Takahiro > > wrote: > > > > > > On Wed, Jul 19, 2023 at 03:15:10PM +0200, Heinrich Schuchardt wrote: > > > > On 19.07.23

Re: [RFC PATCH 06/10] cmd: add rpmsg framework commands

2023-07-26 Thread Simon Glass
Hi Tanmay, On Tue, 25 Jul 2023 at 08:08, Tanmay Shah wrote: > > This patch introduces commands to use rpmsg framework > > rpmsg init > - Initialize rpmsg framework for remote core > > rpmsg debug_data <"tx" / "rx"> > - debug tx or rx virtqueues. This command simply uses >

Re: [RFC PATCH 10/10] configs: sandbox: enable rpmsg

2023-07-26 Thread Simon Glass
On Tue, 25 Jul 2023 at 08:08, Tanmay Shah wrote: > > Enable configs required to test rpmsg on sandbox build. > CMD_MISC is enabled to probe rpmsg_sample_client driver. > > Test procedure: > - boot sandbox build > - command to run rpmsg tests: ut dm rpmsg > - command to run sample driver:

Re: [PATCH] pci: Fix device_find_first_child() return value handling

2023-07-26 Thread Simon Glass
Hi Marek, On Mon, 17 Jul 2023 at 11:03, Marek Vasut wrote: > > On 7/17/23 09:42, Michal Suchánek wrote: > > Hello, > > > > On Sun, Jul 16, 2023 at 05:53:24PM +0200, Marek Vasut wrote: > >> This function only ever returns 0, but may not assign the second > >> parameter. Same thing for

Re: [RFC PATCH 07/10] remoteproc: add attach/detach commands

2023-07-26 Thread Simon Glass
On Tue, 25 Jul 2023 at 08:08, Tanmay Shah wrote: > > Current remoteproc framework provides commands to start/stop > remote processor. However, If remote processor is already running > before U-Boot then there is no way to connect to remote processor. > > Implements attach/detach commands to

Re: [RFC PATCH 05/10] rpmsg: add sample client driver

2023-07-26 Thread Simon Glass
Hi Tanmay, On Tue, 25 Jul 2023 at 08:08, Tanmay Shah wrote: > > Add driver to demonstrate use of rpmsg framework. > > Signed-off-by: Tanmay Shah > --- > drivers/rpmsg/Kconfig | 8 > drivers/rpmsg/Makefile | 3 ++ > drivers/rpmsg/rpmsg_sample_client.c | 63

Re: [PATCH v5 23/46] pci: Allow the video BIOS to work in SPL with QEMU

2023-07-26 Thread Simon Glass
Hi Bin, On Mon, 17 Jul 2023 at 00:20, Bin Meng wrote: > > Hi Simon, > > On Sun, Jul 16, 2023 at 11:39 AM Simon Glass wrote: > > > > QEMU emulates two common machines (Q35 and i440fx) which use mapping to > > determine whether RAM is present below 1MB. In order to copy the video > > BIOS to

Re: [PATCH 15/18] riscv: qemu: Enable PRE_CONSOLE_BUFFER

2023-07-26 Thread Simon Glass
On Tue, 25 Jul 2023 at 01:21, Rick Chen wrote: > > > From: U-Boot On Behalf Of Bin Meng > > Sent: Sunday, July 23, 2023 12:41 PM > > To: Simon Glass ; u-boot@lists.denx.de > > Cc: Bin Meng > > Subject: [PATCH 15/18] riscv: qemu: Enable PRE_CONSOLE_BUFFER > > > > By default the video console

Re: [PATCH 10/18] riscv: qemu: Enable Bochs video support

2023-07-26 Thread Simon Glass
On Sat, 22 Jul 2023 at 22:41, Bin Meng wrote: > > Enable video console using the emulated Bochs VGA card. > > Signed-off-by: Bin Meng > --- > > board/emulation/qemu-riscv/Kconfig | 3 +++ > doc/board/emulation/qemu-riscv.rst | 5 + > include/configs/qemu-riscv.h | 5 + > 3 files

Re: [PATCH 17/18] riscv: qemu: Remove out-of-date "riscv, kernel-start" handling

2023-07-26 Thread Simon Glass
On Tue, 25 Jul 2023 at 01:17, Rick Chen wrote: > > > From: U-Boot On Behalf Of Bin Meng > > Sent: Sunday, July 23, 2023 12:41 PM > > To: Simon Glass ; u-boot@lists.denx.de > > Cc: Bin Meng > > Subject: [PATCH 17/18] riscv: qemu: Remove out-of-date "riscv, > > kernel-start" handling > > > >

Re: [PATCH] fdt: off by one in ofnode_lookup_fdt()

2023-07-26 Thread Simon Glass
Hi Dan, On Wed, 26 Jul 2023 at 00:59, Dan Carpenter wrote: > > The "oftree_count" is the number of entries which have been set in > the oftree_list[] array. If all the entries have been initialized then > this off by one would result in reading one element beyond the end > of the array. > >

Re: Securing u-boot: allow only authentic images

2023-07-26 Thread Simon Glass
Hi, On Tue, 25 Jul 2023 at 09:40, Martin van den Berg wrote: > > Hi there, > > I'm new to u-boot and in need for a little assistance, I hope someone can > point me in the right direction. > > I need to secure the bootloader of a device to some extend. The device is > currently using u-boot as

RE: [PATCH v1] HSD #18028953892: usb: xhci-dwc3: Fix USB3.1 controller register access in reset state

2023-07-26 Thread Chong, Teik Heng
Hi > -Original Message- > From: Marek Vasut > Sent: Wednesday, 26 July, 2023 6:30 PM > To: Chong, Teik Heng ; Lim, Jit Loon > ; u-boot@lists.denx.de > Cc: Jagan Teki ; Simon > ; Chee, Tien Fong > ; Hea, Kok Kiang ; > Maniyam, Dinesh ; Ng, Boon Khai > ; Yuslaimi, Alif Zakuan > ; Zamri,

Re: Building and Running UBoot on UBuntu Linux distribution

2023-07-26 Thread Simon Glass
Hi, On Wed, 26 Jul 2023 at 11:23, Ritika Chauhan wrote: > > Hello Team, > I am writing in since I am learning about bootloader, so I tried building > Das U-boot source code on WSL Ubuntu distribution but could not find any > guide or documentation. So, I followed the one with Debian linux >

Re: [PATCH 1/5] adc: Use regulator_set_enable_if_allowed

2023-07-26 Thread Simon Glass
On Wed, 19 Jul 2023 at 15:21, Jonas Karlman wrote: > > With the commit 4fcba5d556b4 ("regulator: implement basic reference > counter") the return value of regulator_set_enable may be EALREADY or > EBUSY for fixed/gpio regulators. > > Change to use the more relaxed regulator_set_enable_if_allowed

Re: [PATCH 1/1] virtio: provide driver name in debug message

2023-07-26 Thread Simon Glass
On Wed, 26 Jul 2023 at 11:00, Heinrich Schuchardt wrote: > > If a driver cannot be bound, provide the driver name in the debug > message. Now the debug message may look like this: > > (virtio-pci.l#0): virtio-rng driver not configured > > Signed-off-by: Heinrich Schuchardt > --- >

Re: [PATCH] addrmap: Fix off by one in addrmap_set_entry()

2023-07-26 Thread Simon Glass
Hi Dan, On Tue, 25 Jul 2023 at 09:40, Dan Carpenter wrote: > > The > comparison needs to be changed to >= to prevent an out of bounds > write on th next line. > > Signed-off-by: Dan Carpenter > --- > lib/addr_map.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH] cros_ec: Fix an error code is cros_ec_get_sku_id()

2023-07-26 Thread Simon Glass
On Wed, 26 Jul 2023 at 00:58, Dan Carpenter wrote: > > The ec_command_inptr() function returns negative error codes or > the number of bytes that it was able to read. The cros_ec_get_sku_id() > function should return negative error codes. Right now it returns > positive error codes or negative

Re: [PATCH] regulator: preserve error code properly in regulator_list_autoset()

2023-07-26 Thread Simon Glass
On Wed, 26 Jul 2023 at 01:01, Dan Carpenter wrote: > > This code has a & vs && typo so it only preserves odd value error > codes and not even value error codes. > > Signed-off-by: Dan Carpenter > --- > drivers/power/regulator/regulator-uclass.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH] efi_loader: Allow also empty capsule to be process

2023-07-26 Thread AKASHI Takahiro
Hi Michal, Sughosh, On Wed, Jul 26, 2023 at 06:36:56PM +0200, Michal Simek wrote: > > > On 7/26/23 15:07, Ilias Apalodimas wrote: > > Hi all > > > > [...] > > > > > > > > > > > > > > > Hello Sugosh, > > > > > > > > fwu_empty_capsule() detects an empty capsule as one with a GUID > > > >

[PATCH] efi_loader: capsule: enforce guid check in api and capsule_on_disk

2023-07-26 Thread AKASHI Takahiro
While UPDATE_CAPSULE api is not fully implemented, this interface and capsule-on-disk feature should behave in the same way, especially in handling an empty capsule for fwu multibank, for future enhancement. So move the guid check into efi_capsule_update_firmware(). Fixed: commit a6aafce494ab

Re: [RFC] efi_driver: fix a parent issue in efi-created block devices

2023-07-26 Thread AKASHI Takahiro
Please ignore the following RFC since I accidentally posted the wrong patch. -Takahiro Akashi On Thu, Jul 27, 2023 at 09:29:55AM +0900, AKASHI Takahiro wrote: > An EFI application may create an EFI block device (EFI_BLOCK_IO_PROTOCOL) in > EFI world, which in turn generates a corresponding

[RFC] efi_driver: fix a parent issue in efi-created block devices

2023-07-26 Thread AKASHI Takahiro
An EFI application may create an EFI block device (EFI_BLOCK_IO_PROTOCOL) in EFI world, which in turn generates a corresponding U-Boot block device based on U-Boot's Driver Model. The latter device, however, doesn't work as U-Boot proper block device due to an issue in efi_driver's implementation.

Re: [PATCH] sunxi: remove CONFIG_SATAPWR

2023-07-26 Thread Sam Edwards
On 7/26/23 17:47, Andre Przywara wrote: diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index b3115b054c8..422cc01e529 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -1158,6 +1158,8 @@ config ARCH_SUNXI imply CMD_GPT imply CMD_UBI if MTD_RAW_NAND imply

[PATCH v2] ARM: dts: stm32: Switch DWMAC RMII clock to MCO2 on DHCOM

2023-07-26 Thread Marek Vasut
The DHCOM SoM has two options for supplying ETHRX clock to the DWMAC block and PHY. Either (1) ETHCK_K generates 50 MHz clock on ETH_CLK pad for the PHY and the same 50 MHz clock are fed back to ETHRX via internal eth_clk_fb clock connection OR (2) ETH_CLK is not used at all, MCO2 generates 50 MHz

[PATCH] sunxi: remove CONFIG_SATAPWR

2023-07-26 Thread Andre Przywara
The CONFIG_SATAPWR Kconfig symbol was used to point to a GPIO that enables the power for a SATA harddisk. In the DT this is described with the target-supply property in the AHCI DT node, pointing to a (GPIO controlled) regulator. Since we need SATA only in U-Boot proper, and use a DM driver for

[PATCH] ARM: dts: stm32: Switch DWMAC RMII clock to MCO2 on DHCOM

2023-07-26 Thread Marek Vasut
The DHCOM SoM has two options for supplying ETHRX clock to the DWMAC block and PHY. Either (1) ETHCK_K generates 50 MHz clock on ETH_CLK pad for the PHY and the same 50 MHz clock are fed back to ETHRX via internal eth_clk_fb clock connection OR (2) ETH_CLK is not used at all, MCO2 generates 50 MHz

[PATCH] mtd: spi-nor: Add support for Silicon Kaiser sk25lp128

2023-07-26 Thread Jonas Karlman
Add support for Silicon Kaiser sk25lp128 SPI NOR flash found in Pine64 PinePhone Pro and PineTab2. Signed-off-by: Jonas Karlman --- drivers/mtd/spi/Kconfig | 5 + drivers/mtd/spi/spi-nor-ids.c | 4 2 files changed, 9 insertions(+) diff --git a/drivers/mtd/spi/Kconfig

Re: [PATCH] riscv: Support riscv64 image type

2023-07-26 Thread Simon Glass
Hi Rick, On Wed, 19 Apr 2023 at 00:56, Rick Chen wrote: > > Hi Simon, > > > Hi Rick, > > > > On Mon, 10 Apr 2023 at 01:26, Rick Chen wrote: > > > > > > Allow U-Boot to load 32 or 64 bits RISC-V Kernel Image > > > distinguishly. It helps to avoid someone maybe make a mistake > > > to run 32-bit

Re: [PATCH 0/4] net: ti: am65-cpsw-nuss: Fix DT binding handling of pinctrl

2023-07-26 Thread Ravi Gunasekaran
Maxime, On 7/20/23 7:42 PM, Maxime Ripard wrote: > Hi > > Sorry, I didn't receive Roger mail so I'll reply here > > On Thu, Jul 20, 2023 at 09:00:19AM -0500, Nishanth Menon wrote: >> On 16:56-20230720, Roger Quadros wrote: >>> Hi, >>> >>> On 20/07/2023 16:33, Ravi Gunasekaran wrote:

Re: [PATCH 14/14] bloblist: Update documentation and header comment

2023-07-26 Thread Julius Werner
Here are a couple of other differences I have found between the bloblist code after applying your patches and the TL specification: * bloblist seems to explicitly disallow having the same tag more than once in the list (e.g. see documentation of bloblist_add()), whereas the TL specification

Re: [PATCH 3/6] board: ti: am62x: Add basic initialization for usb voltage, 32k crystal, debounce

2023-07-26 Thread Nishanth Menon
On 00:35-20230726, Francesco Dolcini wrote: [...] > > > > > > At least the ones we have currently (I am not sure about toradex, > > > phytech etc), seem to operate the vdd_core at 0.85V .. (which is what > > > USB is dependent upon). > > > > Fo

Re: [PATCH 13/14] bloblist: Add alignment to bloblist_new()

2023-07-26 Thread Julius Werner
I'm not sure why you would add an API to allow setting this explicitly, that's not really how it is supposed to work according to the spec. New TLs are always supposed to start with an alignment requirement of 8 (2^3) and then automatically increase that value if a TE gets added that has a larger

Re: [PATCH 11/14] bloblist: Reduce blob-header size

2023-07-26 Thread Julius Werner
> - rec->tag = tag; > - rec->hdr_size = sizeof(struct bloblist_rec); > + rec->tag_and_hdr_size = tag | sizeof(*rec) << > BLOBLISTR_HDR_SIZE_SHIFT; nit: Might be a good idea to mask the tag or double-check that it fits the field size here. > - * 5. Bloblist uses 16-byte

Re: [PATCH 10/14] bloblist: Handle alignment with a void entry

2023-07-26 Thread Julius Werner
> /* Calculate the new allocated total */ > - new_alloced = data_start + ALIGN(size, 1U << align_log2); > + new_alloced = data_start - map_to_sysmem(hdr) + > + ALIGN(size, 1U << align_log2); I think this is incorrect. There's no requirement that the size of an

Re: [PATCH 01/14] bloblist: Update the tag numbering

2023-07-26 Thread Julius Werner
> diff --git a/include/bloblist.h b/include/bloblist.h > index 7ea72c6bd46..bad5fbbb889 100644 > --- a/include/bloblist.h > +++ b/include/bloblist.h nit: I would suggest also updating the documentation at the top of this file (point 7) to clarify that new standardized tags must be allocated in

Re: [PATCH v5 06/12] Dockerfile: capsule: Setup the files needed for capsule update testing

2023-07-26 Thread Tom Rini
On Thu, Jul 27, 2023 at 01:30:04AM +0530, Sughosh Ganu wrote: > On Wed, 26 Jul 2023 at 22:09, Tom Rini wrote: > > > > On Wed, Jul 26, 2023 at 08:11:44PM +0530, Sughosh Ganu wrote: > > > hi Simon, > > > > > > On Wed, 26 Jul 2023 at 19:41, Simon Glass wrote: > > > > > > > > Hi Tom, > > > > > > > >

Re: [PATCH v5 06/12] Dockerfile: capsule: Setup the files needed for capsule update testing

2023-07-26 Thread Sughosh Ganu
On Wed, 26 Jul 2023 at 22:09, Tom Rini wrote: > > On Wed, Jul 26, 2023 at 08:11:44PM +0530, Sughosh Ganu wrote: > > hi Simon, > > > > On Wed, 26 Jul 2023 at 19:41, Simon Glass wrote: > > > > > > Hi Tom, > > > > > > On Wed, 26 Jul 2023 at 07:23, Tom Rini wrote: > > > > > > > > On Wed, Jul 26,

Re: [PATCH v16 09/10] arm_ffa: efi: introduce FF-A MM communication

2023-07-26 Thread Tom Rini
On Wed, Jul 26, 2023 at 10:45:02AM +0100, Abdellatif El Khlifi wrote: > Add MM communication support using FF-A transport > > This feature allows accessing MM partitions services through > EFI MM communication protocol. MM partitions such as StandAlonneMM > or smm-gateway secure partitions which

Re: [PATCH v2 2/2] schemas: Add a schema for binman

2023-07-26 Thread Simon Glass
Hi, On Thu, 20 Jul 2023 at 13:56, Simon Glass wrote: > > With this version I have done with a generic name, in this case 'data', > as suggested by Alper Nebi Yasak. This may be controversial, but we may > as well have the dicussion now. I assume that there are no other > ongoing attempts to

Re: [PATCH V2 1/3] omap: timer: add ti,am654-timer compatibility

2023-07-26 Thread Andrew Davis
On 7/26/23 10:10 AM, Nishanth Menon wrote: From: Sjoerd Simons THe TI AM654 timer is compatible with the omap-timer implementation, so s/THe/The add it to the id list s/id list/compatible ID list. Andrew Signed-off-by: Sjoerd Simons Reviewed-by: Tom Rini Tested-by: Ravi Gunasekaran

[PATCH V2 3/3] arm: dts: k3-am62: Bump dtsi from linux v6.5-rc1

2023-07-26 Thread Nishanth Menon
Update the am62 and am625 device-trees from linux v6.3-rc5 This needed the followin tweaks to the u-boot specific dtsi as well: - Switch tick-timer to the main_timer as it's now defined in the main dtsi - Secure proxies are defined in Soc dtsis - Drop duplicate nodes - u-boot.dtsi is includes in

Re: [PATCH 6/6] doc: board: ti: Add beagleplay documentation

2023-07-26 Thread Andrew Davis
On 7/25/23 5:45 PM, Tom Rini wrote: On Tue, Jul 25, 2023 at 05:00:15PM -0500, Nishanth Menon wrote: On 17:35-20230725, Tom Rini wrote: On Tue, Jul 25, 2023 at 01:52:53PM -0500, Nishanth Menon wrote: [...] + +Build procedure: + +1. Trusted Firmware-A: + +.. code-block:: bash

[PATCH v2 09/12] test: dm: add SCMI base protocol test

2023-07-26 Thread AKASHI Takahiro
Added is a new unit test for SCMI base protocol, which will exercise all the commands provided by the protocol, except SCMI_BASE_NOTIFY_ERRORS. $ ut dm scmi_base It is assumed that test.dtb is used as sandbox's device tree. Signed-off-by: AKASHI Takahiro --- v2 * use helper functions, removing

[PATCH v2 02/12] firmware: scmi: implement SCMI base protocol

2023-07-26 Thread AKASHI Takahiro
SCMI base protocol is mandatory according to the SCMI specification. With this patch, SCMI base protocol can be accessed via SCMI transport layers. All the commands, except SCMI_BASE_NOTIFY_ERRORS, are supported. This is because U-Boot doesn't support interrupts and the current transport layers

[PATCH v2 07/12] firmware: scmi: fake base protocol commands on sandbox

2023-07-26 Thread AKASHI Takahiro
This is a simple implementation of SCMI base protocol for sandbox. The main use is in SCMI unit test. Signed-off-by: AKASHI Takahiro Reviewed-by: Simon Glass --- drivers/firmware/scmi/sandbox-scmi_agent.c | 359 - 1 file changed, 358 insertions(+), 1 deletion(-) diff --git

  1   2   3   >