Re: [PATCH 1/3] malloc: Don't use ifdefs for SYS_MALLOC_DEFAULT_TO_INIT

2023-07-31 Thread Heinrich Schuchardt
On 8/1/23 00:33, Sean Anderson wrote: With CONFIG_IS_ENABLED we can eliminate some ifdefs. Signed-off-by: Sean Anderson Reviewed-by: Heinrich Schuchardt --- common/dlmalloc.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/common/dlmalloc.c

Re: [PATCH 1/4] config: rock64: start USB to make storage usable

2023-07-31 Thread Kever Yang
Hi Peter,     Could you update the patchset with patches you still want to send? Thanks, - Kever On 2023/6/14 20:43, Peter Robinson wrote: Start the USB stack so usb storage can be used. Adding the command as usb keyboard isn't enabled as there's not currently display output.

Re: [PATCH] rockchip: rk3399: nanopc-t4: use 1600MHz sdram config

2023-07-31 Thread Kever Yang
Hi Lu jicong,     Does the 1866M worked for your board before?     I think this config should be fine for other people, it has been submit for 4 years. Thanks, - Kever On 2023/7/5 21:58, Lu jicong wrote: Current 1866MHz sdram config is too high for NanoPC-T4. On this frequency, its

Problem upon startup with halted USB device on RaspberryPi 4

2023-07-31 Thread Harry Waschkeit
Hi, I have a RaspberryPi 4 where on one USB port a Sierra Wireless LTE module (EM7455) is attached via an PCIe-to-USB adapter. The boot image I use gets built by Yocto with the help of poky (kirkstone) and meta-raspberry (beside a few other layers) which incorporates U-Boot 22.01. When I

[PATCH] ram: mediatek: mt7629: include

2023-07-31 Thread Daniel Golle
Something between U-Boot 2023.04 and 2023.07.02 resulted in no longer implicitely including in the DDR3 RAM driver for the MT7929 SoC. The result is a build failure: drivers/ram/mediatek/ddr3-mt7629.c: In function 'mtk_ddr3_get_info': drivers/ram/mediatek/ddr3-mt7629.c:734:30: error: 'SZ_128M'

Re: [PATCH] spl: spl_legacy: Fix spl_end address for non ARM target

2023-07-31 Thread Tom Rini
On Tue, Aug 01, 2023 at 10:35:19AM +0800, Shiji Yang wrote: > On Mon, 31 Jul 2023 15:12:27 -0400, Tom Rini wrote: > > On Tue, Aug 01, 2023 at 12:10:52AM +0800, Shiji Yang wrote: > > > On Mon, 31 Jul 2023 16:17:39 +0200, Marek Vasut wrote: > > > >On 7/31/23 13:57, Shiji Yang wrote: > > > >> Only

Re: [PATCH] spl: spl_legacy: Fix spl_end address for non ARM target

2023-07-31 Thread Shiji Yang
On Mon, 31 Jul 2023 15:12:27 -0400, Tom Rini wrote: > On Tue, Aug 01, 2023 at 12:10:52AM +0800, Shiji Yang wrote: > > On Mon, 31 Jul 2023 16:17:39 +0200, Marek Vasut wrote: > > >On 7/31/23 13:57, Shiji Yang wrote: > > >> Only ARM target defines _image_binary_end symbol as char*, All other > > >>

Re: Pull request: u-boot-rockchip-20230731

2023-07-31 Thread Kever Yang
at: https://source.denx.de/u-boot/custodians/u-boot-rockchip.git tags/u-boot-rockchip-20230731 for you to fetch changes up to 1f54f71b182e3515f72870a75ce2ba769b00b1f3: board: rockchip: Add Radxa E25 Carrier Board (2023-07-31 20:34:32 +0800) I've applied to u-boot/master now, thanks. But one bit

Re: [PATCH] x86: Add a little more info to cbsysinfo

2023-07-31 Thread Bin Meng
On Fri, Jul 28, 2023 at 5:54 PM Bin Meng wrote: > > On Wed, Jul 26, 2023 at 5:37 AM Simon Glass wrote: > > > > Show the number of records in the table and the total table size in > > bytes. > > > > Signed-off-by: Simon Glass > > --- > > > > arch/x86/include/asm/cb_sysinfo.h | 4 > >

Re: [PATCH v3] x86: Change tesing logic of mtrr commit

2023-07-31 Thread Bin Meng
On Mon, Jul 31, 2023 at 9:56 PM Simon Glass wrote: > > From: Bin Meng > > On Coral U-Boot SPL programs some MTRRs and FSPv2 in U-Boot proper > needs to program MTRRs too. With current testing logic of mtrr > commit in init_cache_f_r(), the mtrr commit is skipped which won't > work as the queued

Re: [PATCH v2 1/6] x86: Change tesing logic of mtrr commit

2023-07-31 Thread Bin Meng
On Mon, Jul 31, 2023 at 2:01 PM Bin Meng wrote: > > From: Bin Meng > > On Coral U-Boot SPL programs some MTRRs and FSPv2 in U-Boot proper > needs to program MTRRs too. With current testing logic of mtrr > commit in init_cache_f_r(), the mtrr commit is skipped which won't > work as the queued

[PATCH v5 11/11] spl: spi: Consolidate spi_load_image_os into spl_spi_load_image

2023-07-31 Thread Sean Anderson
spi_load_image_os performs almost the same steps as the non-falcon-boot path of spl_spi_load_image. The load address is different, and it also loads a device tree, but that's it. Refactor the boot process so that they can both use the same load function. Signed-off-by: Sean Anderson --- Changes

[PATCH v5 09/11] spl: Convert semihosting to spl_load

2023-07-31 Thread Sean Anderson
This converts the semihosting load method to use spl_load. As a result, it also adds support for LOAD_FIT_FULL and IMX images. Signed-off-by: Sean Anderson --- Changes in v5: - Rework to load header in spl_load Changes in v2: - New common/spl/spl_semihosting.c | 43

[PATCH v5 10/11] spl: Convert spi to spl_load

2023-07-31 Thread Sean Anderson
This converts the spi load method to use spl_load. As a consequence, it also adds support for LOAD_FIT_FULL. Signed-off-by: Sean Anderson --- Changes in v5: - Rework to load header in spl_load common/spl/spl_spi.c | 72 +--- 1 file changed, 8

[PATCH v5 06/11] spl: Convert net to spl_load

2023-07-31 Thread Sean Anderson
This converts the net load method to use spl_load. As a result, it also adds support for LOAD_FIT_FULL and IMX images. Signed-off-by: Sean Anderson --- Changes in v5: - Rework to load header in spl_load common/spl/spl_net.c | 25 + 1 file changed, 5 insertions(+), 20

[PATCH v5 08/11] spl: Convert nor to spl_load

2023-07-31 Thread Sean Anderson
This converts the nor load method to use spl_load. As a result it also adds support for LOAD_FIT_FULL. Signed-off-by: Sean Anderson --- Changes in v5: - Rework to load header in spl_load common/spl/spl_nor.c | 41 +++-- 1 file changed, 7 insertions(+), 34

[PATCH v5 05/11] spl: Convert mmc to spl_load

2023-07-31 Thread Sean Anderson
This converts the mmc loader to spl_load. Legacy images are handled by spl_load (via spl_parse_image_header), so mmc_load_legacy can be omitted. Signed-off-by: Sean Anderson --- Changes in v5: - Rework to load header in spl_load common/spl/spl_mmc.c | 91

[PATCH v5 03/11] spl: Convert ext to use spl_load

2023-07-31 Thread Sean Anderson
This converts the ext load method to use spl_load. As a consequence, it also adds support for FIT and IMX images. Signed-off-by: Sean Anderson --- Changes in v5: - Rework to load header in spl_load common/spl/spl_ext.c | 34 ++ 1 file changed, 18 insertions(+),

[PATCH v5 07/11] spl: Convert NVMe to spl_load

2023-07-31 Thread Sean Anderson
This converts the blk load method (used exclusively by NVMe) to use spl_load. As a consequence, it also adds support for LOAD_FIT_FULL and IMX images. Signed-off-by: Sean Anderson --- Changes in v5: - New common/spl/spl_blk_fs.c | 68 - 1 file changed,

[PATCH v5 04/11] spl: Convert fat to spl_load

2023-07-31 Thread Sean Anderson
This converts the fat loader to use spl_load. Some platforms are very tight on space, so we take care to only include the code we really need. Signed-off-by: Sean Anderson --- Changes in v5: - Rework to load header in spl_load Changes in v3: - Fix failing on success common/spl/spl_fat.c | 55

[PATCH v5 02/11] spl: Add generic spl_load function

2023-07-31 Thread Sean Anderson
Implementers of SPL_LOAD_IMAGE_METHOD have to correctly determine what type of image is being loaded and then call the appropriate image load function correctly. This is tricky, because some image load functions expect the whole image to already be loaded (CONFIG_SPL_LOAD_FIT_FULL), some will load

[PATCH v5 01/11] spl: Make SHOW_ERRORS depend on LIBCOMMON

2023-07-31 Thread Sean Anderson
The purpose of SHOW_ERRORS is to print extra information. Make it depend on LIBCOMMON to avoid having to check for two configs. Signed-off-by: Sean Anderson --- Changes in v5: - New common/spl/Kconfig | 1 + common/spl/spl.c | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff

[PATCH v5 00/11] spl: Use common function for loading/parsing images

2023-07-31 Thread Sean Anderson
This series adds support for loading all image types (Legacy, FIT (with and without LOAD_FIT_FULL), and i.MX) to the MMC, SPI, NOR, NET, FAT, and EXT load methods. It does this by introducing a helper function which handles the minutiae of invoking the proper parsing function, and reading the rest

[PATCH 0/3] malloc: Reduce size by initializing data at runtime

2023-07-31 Thread Sean Anderson
In my efforts to get SPL to fit into flash after some changes I made, I noticed that av_ is one of the largest variables in SPL. As it turns out, we can generate it at runtime, and the code is already there. This has the potential to save 1-2k across the board, for some minor boot time increase.

[PATCH 1/3] malloc: Don't use ifdefs for SYS_MALLOC_DEFAULT_TO_INIT

2023-07-31 Thread Sean Anderson
With CONFIG_IS_ENABLED we can eliminate some ifdefs. Signed-off-by: Sean Anderson --- common/dlmalloc.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/common/dlmalloc.c b/common/dlmalloc.c index 0f9b7262d5..30c78ae976 100644 --- a/common/dlmalloc.c +++

[PATCH 3/3] malloc: Enable SYS_MALLOC_RUNTIME_INIT by default in SPL

2023-07-31 Thread Sean Anderson
On boards with size restrictions, 1-2k can be a significant fraction of the binary size. Add a new SPL version of SYS_MALLOC_RUNTIME_INIT and enable it by default. Signed-off-by: Sean Anderson --- Kconfig | 11 +++ 1 file changed, 11 insertions(+) diff --git a/Kconfig b/Kconfig index

[PATCH 2/3] malloc: Don't statically initialize av_ if using malloc_init

2023-07-31 Thread Sean Anderson
When we enable malloc_init, there is no need to statically initialize av_, since we are going to do it manually. This lets us move av_ to .bss, saving around 1-2k of data (depending on the pointer size). cALLOc must be adjusted to not access top before malloc_init. While we're at it,

Re: [PATCH] arm: Use builtins for ffs/fls

2023-07-31 Thread Sean Anderson
On 7/31/23 17:27, Sean Anderson wrote: Since ARMv5, the clz instruction allows for efficient implementation of ffs/fls with builtins. Until ARMv7 (with Thumb-2), this instruction is only available in ARM mode. LTO makes it difficult to force specific functions to be in ARM mode, as it is

Re: [PATCH] arm: Use builtins for ffs/fls

2023-07-31 Thread Sean Anderson
On 7/31/23 17:36, Tom Rini wrote: On Mon, Jul 31, 2023 at 05:27:33PM -0400, Sean Anderson wrote: Since ARMv5, the clz instruction allows for efficient implementation of ffs/fls with builtins. Until ARMv7 (with Thumb-2), this instruction is only available in ARM mode. LTO makes it difficult

Re: [PATCH] arm: Use builtins for ffs/fls

2023-07-31 Thread Tom Rini
On Mon, Jul 31, 2023 at 05:27:33PM -0400, Sean Anderson wrote: > Since ARMv5, the clz instruction allows for efficient implementation of > ffs/fls with builtins. Until ARMv7 (with Thumb-2), this instruction is > only available in ARM mode. LTO makes it difficult to force specific > functions to

[PATCH] arm: Use builtins for ffs/fls

2023-07-31 Thread Sean Anderson
Since ARMv5, the clz instruction allows for efficient implementation of ffs/fls with builtins. Until ARMv7 (with Thumb-2), this instruction is only available in ARM mode. LTO makes it difficult to force specific functions to be in ARM mode, as it is effectively a form of very aggressive inlining.

Re: [PATCH v3 5/9] board_f: Fix corruption of relocaddr

2023-07-31 Thread Simon Glass
Hi Tom, On Mon, 31 Jul 2023 at 15:06, Tom Rini wrote: > > On Mon, Jul 31, 2023 at 02:49:06PM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Mon, 31 Jul 2023 at 14:45, Tom Rini wrote: > > > > > > On Mon, Jul 31, 2023 at 02:37:04PM -0600, Simon Glass wrote: > > > > Hi Tom, > > > > > > > > On

Re: [PATCH 2/2] test: unit test for semihosting

2023-07-31 Thread Sean Anderson
On 7/31/23 16:01, Heinrich Schuchardt wrote: Provide a unit test for semihosting testing reading and writing a file. Signed-off-by: Heinrich Schuchardt --- test/py/tests/test_semihosting/conftest.py| 23 + test/py/tests/test_semihosting/test_hostfs.py | 33

Re: [PATCH 1/2] configs: enable SEMIHOSTING on qemu_arm64_defconfig

2023-07-31 Thread Sean Anderson
On 7/31/23 16:01, Heinrich Schuchardt wrote: We need a platform on which we can test our semihosting code. Signed-off-by: Heinrich Schuchardt --- configs/qemu_arm64_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/qemu_arm64_defconfig b/configs/qemu_arm64_defconfig

Re: [PATCH v3 5/9] board_f: Fix corruption of relocaddr

2023-07-31 Thread Tom Rini
On Mon, Jul 31, 2023 at 02:49:06PM -0600, Simon Glass wrote: > Hi Tom, > > On Mon, 31 Jul 2023 at 14:45, Tom Rini wrote: > > > > On Mon, Jul 31, 2023 at 02:37:04PM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Mon, 31 Jul 2023 at 13:32, Tom Rini wrote: > > > > > > > > On Mon, Jul 31,

Re: [PATCH v3 5/9] board_f: Fix corruption of relocaddr

2023-07-31 Thread Simon Glass
Hi Tom, On Mon, 31 Jul 2023 at 14:45, Tom Rini wrote: > > On Mon, Jul 31, 2023 at 02:37:04PM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Mon, 31 Jul 2023 at 13:32, Tom Rini wrote: > > > > > > On Mon, Jul 31, 2023 at 09:59:56AM -0600, Simon Glass wrote: > > > > > > > When the video

Re: [PATCH v3 5/9] board_f: Fix corruption of relocaddr

2023-07-31 Thread Tom Rini
On Mon, Jul 31, 2023 at 02:37:04PM -0600, Simon Glass wrote: > Hi Tom, > > On Mon, 31 Jul 2023 at 13:32, Tom Rini wrote: > > > > On Mon, Jul 31, 2023 at 09:59:56AM -0600, Simon Glass wrote: > > > > > When the video framebuffer comes from the bloblist, we should not change > > > relocaddr to this

Re: [PATCH v3 5/9] board_f: Fix corruption of relocaddr

2023-07-31 Thread Simon Glass
Hi Tom, On Mon, 31 Jul 2023 at 13:32, Tom Rini wrote: > > On Mon, Jul 31, 2023 at 09:59:56AM -0600, Simon Glass wrote: > > > When the video framebuffer comes from the bloblist, we should not change > > relocaddr to this address, since it interfers with the normal memory > > allocation. > > > >

[PATCH 2/2] test: unit test for semihosting

2023-07-31 Thread Heinrich Schuchardt
Provide a unit test for semihosting testing reading and writing a file. Signed-off-by: Heinrich Schuchardt --- test/py/tests/test_semihosting/conftest.py| 23 + test/py/tests/test_semihosting/test_hostfs.py | 33 +++ 2 files changed, 56 insertions(+) create mode

[PATCH 1/2] configs: enable SEMIHOSTING on qemu_arm64_defconfig

2023-07-31 Thread Heinrich Schuchardt
We need a platform on which we can test our semihosting code. Signed-off-by: Heinrich Schuchardt --- configs/qemu_arm64_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/qemu_arm64_defconfig b/configs/qemu_arm64_defconfig index 94bd966784..2080f5ee9a 100644 ---

[PATCH 0/2] test: unit test for semihosting

2023-07-31 Thread Heinrich Schuchardt
* Provide a unit test for semihosting testing, reading and writing a file. * Enable semihosting on qemu_arm64_defconfig. Semihosting is already enabled for the board in u-boot-testhooks. Heinrich Schuchardt (2): configs: enable SEMIHOSTING on qemu_arm64_defconfig test: unit test for

Re: [PATCH v3 5/9] board_f: Fix corruption of relocaddr

2023-07-31 Thread Tom Rini
On Mon, Jul 31, 2023 at 09:59:56AM -0600, Simon Glass wrote: > When the video framebuffer comes from the bloblist, we should not change > relocaddr to this address, since it interfers with the normal memory > allocation. > > This fixes a boot loop in qemu-x86_64 > > Signed-off-by: Simon Glass

Re: [PATCH] board: ti: am62x: Add variable device tree in env

2023-07-31 Thread Jason Kacines
On Mon, Jul 31, 2023 at 09:36:38AM -0500, Andrew Davis wrote: > On 7/31/23 9:27 AM, Jason Kacines wrote: > > Added variable default_device_tree that grabs from defconfig. Prevents > > needing to change this variable in two locations if using a separate > > device tree. In the future, it would be a

Re: [PATCH] spl: spl_legacy: Fix spl_end address for non ARM target

2023-07-31 Thread Tom Rini
On Tue, Aug 01, 2023 at 12:10:52AM +0800, Shiji Yang wrote: > On Mon, 31 Jul 2023 16:17:39 +0200, Marek Vasut wrote: > >On 7/31/23 13:57, Shiji Yang wrote: > >> Only ARM target defines _image_binary_end symbol as char*, All other > >> targets define it as an ulong type in

Re: [PATCH] arm: moxa: add nport6600 platform

2023-07-31 Thread Tom Rini
On Mon, Jul 31, 2023 at 09:43:29PM +0300, Sergei Antonov wrote: > Support for NPort 6600 Series RS-232/422/485 secure terminal servers. > > Technical specifications: > FA526 ARMv4 CPU, 64 MB of RAM, 16 MB NOR flash, 100 Mbit/s Ethernet, > optional expansion modules, up to 32 RS-232/422/485

[PATCH] arm: moxa: add nport6600 platform

2023-07-31 Thread Sergei Antonov
Support for NPort 6600 Series RS-232/422/485 secure terminal servers. Technical specifications: FA526 ARMv4 CPU, 64 MB of RAM, 16 MB NOR flash, 100 Mbit/s Ethernet, optional expansion modules, up to 32 RS-232/422/485 ports. Signed-off-by: Sergei Antonov --- arch/arm/Kconfig |

Re: Pull request: u-boot-rockchip-20230731

2023-07-31 Thread Tom Rini
(2023-07-28 12:48:00 > -0400) > > are available in the Git repository at: > > https://source.denx.de/u-boot/custodians/u-boot-rockchip.git > tags/u-boot-rockchip-20230731 > > for you to fetch changes up to 1f54f71b182e3515f72870a75ce2ba769b00b1f3: > > board: r

Re: [PATCH 1/1] cmd: avoid overflow in mtd_is_aligned_with_min_io_size

2023-07-31 Thread Michael Nazzareno Trimarchi
Hi On Mon, Jul 31, 2023 at 10:10 AM Heinrich Schuchardt < heinrich.schucha...@canonical.com> wrote: > > > > On 7/31/23 09:00, Michael Nazzareno Trimarchi wrote: > > Hi > > > > On Sun, Jul 30, 2023 at 3:03 PM Heinrich Schuchardt > > wrote: > >> > >> Multiplication of u32 factors has an u32 result

Re: [PATCH v2 2/9] cmd: boot: implement PMIC based poweroff

2023-07-31 Thread Svyatoslav Ryhel
31 липня 2023 р. 20:08:06 GMT+03:00, Simon Glass написав(-ла): >Hi Svyatoslav, > >On Sun, 30 Jul 2023 at 01:23, Svyatoslav Ryhel wrote: >> >> >> >> 24 липня 2023 р. 05:28:24 GMT+03:00, Simon Glass >> написав(-ла): >> >Hi Svyatoslav, >> > >> >On Sun, 23 Jul 2023 at 03:00, Svyatoslav Ryhel

Re: [PATCH 00/22] x86: Move some boards to text environment

2023-07-31 Thread Simon Glass
Hi Andy, On Mon, 31 Jul 2023 at 02:09, Andy Shevchenko wrote: > > On Sun, Jul 30, 2023 at 09:01:43PM -0600, Simon Glass wrote: > > This series starts the process of moving x86 boards to a text environment. > > > > This includes conversions for about half the boards. > > > > The rest (including

Re: [PATCH v2 4/9] bootstd: Rename bootdev_setup_sibling_blk()

2023-07-31 Thread Mattijs Korpershoek
On dim., juil. 30, 2023 at 11:15, Simon Glass wrote: > This name is a little confusing since it suggests that it sets up the > sibling block device. In fact it sets up a bootdev for it. Rename the > function to make this clearer. > > Signed-off-by: Simon Glass Reviewed-by: Mattijs Korpershoek

Re: [PATCH v2 2/9] cmd: boot: implement PMIC based poweroff

2023-07-31 Thread Simon Glass
Hi Svyatoslav, On Sun, 30 Jul 2023 at 01:23, Svyatoslav Ryhel wrote: > > > > 24 липня 2023 р. 05:28:24 GMT+03:00, Simon Glass > написав(-ла): > >Hi Svyatoslav, > > > >On Sun, 23 Jul 2023 at 03:00, Svyatoslav Ryhel wrote: > >> > >> нд, 23 лип. 2023 р. о 06:48 Simon Glass пише: > >> > > >> >

Re: [PATCH 1/1] tools/fdt_add_pubkey: error handling in add_pubkey

2023-07-31 Thread Simon Glass
Hi, On Mon, 31 Jul 2023 at 02:16, Ivan Mikhaylov wrote: > > On Sun, 2023-07-30 at 10:15 +0200, Heinrich Schuchardt wrote: > > * If info is NULL, do not dereference it. > > * If mmap fails, print an error message. > > > > Fixes: 30238e99619c ("tools: add fdt_add_pubkey") > > Signed-off-by:

Re: [PATCH v17 09/10] arm_ffa: efi: introduce FF-A MM communication

2023-07-31 Thread Simon Glass
Hi Abdellatif, On Mon, 31 Jul 2023 at 05:46, Abdellatif El Khlifi wrote: > > Hi Ilias, > > On Mon, Jul 31, 2023 at 12:38:16PM +0300, Ilias Apalodimas wrote: > > > > > > ... > > > > > > Changelog: > > > > > > === > > > > > > > > > > > > v17: > > > > > > > > > > > > * show a debug

Re: [PATCH] dm: Correct DM_FLAG_ comment

2023-07-31 Thread Simon Glass
On Mon, 31 Jul 2023 at 08:01, Bin Meng wrote: > > The macros are prefixed with DM_FLAG_, not DM_FLAGS_. > > Signed-off-by: Bin Meng > --- > > include/dm/device.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass

Re: [PATCH] test: fix a couple NULL vs IS_ERR() checks

2023-07-31 Thread Simon Glass
Hi Dan, On Mon, 31 Jul 2023 at 08:08, Dan Carpenter wrote: > > The x509_cert_parse() and pkcs7_parse_message() functions return error > pointers. They don't return NULL. Update the checks accordingly. > > Signed-off-by: Dan Carpenter > --- > test/lib/asn1.c | 4 ++-- > 1 file changed, 2

Re: [PATCH v3 1/2] dm: core: ofnode: Add ofnode_read_bootscript_address()

2023-07-31 Thread Simon Glass
On Mon, 31 Jul 2023 at 05:33, Michal Simek wrote: > > ofnode_read_bootscript_address() reads bootscript address from > /options/u-boot DT node. bootscr-address or bootscr-ram-offset properties > are read and values are filled. bootscr-address has higher priority than > bootscr-ram-offset and the

Re: [PATCH 3/8] bootstd: Rename bootdev_setup_sibling_blk()

2023-07-31 Thread Simon Glass
Hi Mattijs, On Fri, 28 Jul 2023 at 02:00, Mattijs Korpershoek wrote: > > On jeu., juil. 27, 2023 at 20:37, Simon Glass wrote: > > > This name is a little confusing since it suggests that it sets up the > > sibling block device. In fact it sets up a bootdev for it. Rename the > > function to

Re: [PATCH v2 1/1] doc: describe QEMU virtio block device

2023-07-31 Thread Simon Glass
On Sun, 30 Jul 2023 at 11:38, Heinrich Schuchardt wrote: > > Enhance the description of QEMU block devices > > * Describe how to attach a virtio-blk device. > * Sort the command lines for MMC to match the other devices. > > Signed-off-by: Heinrich Schuchardt > --- > v2: >

Re: [PATCH 2/2] arch: m68k: Implement relocation

2023-07-31 Thread Simon Glass
On Sun, 30 Jul 2023 at 16:21, Marek Vasut wrote: > > Implement relocation for M68K. Perform all the updates in start.S > relocate_code in assemby, since it is a simple matter of traversing > the dynsym table and adding relocation offset - MONITOR_BASE to all > the items in that table. The

Re: [PATCH] expo: allocate correct ammount of memory

2023-07-31 Thread Simon Glass
On Mon, 31 Jul 2023 at 08:08, Dan Carpenter wrote: > > This should be allocating the memory for "item" instead of "menu". > The item struct is 48 bytes instead of 96 (assuming a 64bit system) > so this saves a little memory. > > Signed-off-by: Dan Carpenter > --- > boot/scene_menu.c | 2 +- > 1

Re: [PATCH 1/1] boot: fix bootdev_list()

2023-07-31 Thread Simon Glass
Hi Heinrich, On Sun, 30 Jul 2023 at 08:29, Heinrich Schuchardt wrote: > > uclass_get_device_by_name() is meant to return 0 or a negative error code. > simple_itoa() cannot handle negative numbers. > > This leads to output like: > > => bootdev list -p > > Seq Probed Status Uclass

Re: [PATCH v2 4/6] video: ivybridge: Use mtrr_set_next_var() for graphics memory

2023-07-31 Thread Simon Glass
On Mon, 31 Jul 2023 at 00:04, Bin Meng wrote: > > From: Bin Meng > > At present this uses mtrr_add_request() & mtrr_commit() combination > to program the MTRR for graphics memory. This usage has two major > issues as below: > > - mtrr_commit() will re-initialize all MTRR registers from index 0,

Re: [PATCH v2 5/6] video: vesa: Use mtrr_set_next_var() for graphics memory

2023-07-31 Thread Simon Glass
On Mon, 31 Jul 2023 at 00:05, Bin Meng wrote: > > From: Bin Meng > > At present this uses mtrr_add_request() & mtrr_commit() combination > to program the MTRR for graphics memory. This usage has two major > issues as below: > > - mtrr_commit() will re-initialize all MTRR registers from index 0,

Re: [PATCH v2 3/6] video: broadwell: Use mtrr_set_next_var() for graphics memory

2023-07-31 Thread Simon Glass
On Mon, 31 Jul 2023 at 00:03, Bin Meng wrote: > > From: Bin Meng > > At present this uses mtrr_add_request() & mtrr_commit() combination > to program the MTRR for graphics memory. This usage has two major > issues as below: > > - mtrr_commit() will re-initialize all MTRR registers from index 0,

Re: [PATCH] cmd: pxe: Update the command help

2023-07-31 Thread Simon Glass
On Mon, 31 Jul 2023 at 02:33, Bin Meng wrote: > > Currently the "help" displays pxe command help text like this: > > => help > ... > printenv - print environment variables > pxe - commands to get and boot from pxe files > To use IPv6 add -ipv6 parameter > qfw - QEMU

Re: [PATCH] cmd: improve string matching for hex

2023-07-31 Thread Simon Glass
On Mon, 31 Jul 2023 at 08:04, Dan Carpenter wrote: > > Match the "=0x" instead of just "=0". > > Signed-off-by: Dan Carpenter > --- > We sometimes two character partial matching for commands so people can > type "re" instead of "read". But here reading two characters doesn't > seem correct. > >

Re: [PATCH 4/9] Revert "x86: Switch QEMU over to use the bochs driver"

2023-07-31 Thread Simon Glass
Hi Bin, On Mon, 31 Jul 2023 at 08:46, Bin Meng wrote: > > Hi Simon, > > On Mon, Jul 31, 2023 at 10:37 PM Simon Glass wrote: > > > > Hi Bin, > > > > On Mon, 31 Jul 2023 at 08:32, Bin Meng wrote: > > > > > > Hi Simon, > > > > > > On Sat, Jul 29, 2023 at 1:32 AM Simon Glass wrote: > > > > > > >

Re: [PATCH v2 2/6] x86: fsp: Use mtrr_set_next_var() for graphics memory

2023-07-31 Thread Simon Glass
On Mon, 31 Jul 2023 at 00:02, Bin Meng wrote: > > From: Bin Meng > > At present this uses mtrr_add_request() & mtrr_commit() combination > to program the MTRR for graphics memory. This usage has two major > issues as below: > > - mtrr_commit() will re-initialize all MTRR registers from index 0,

Re: [PATCH v2 2/6] x86: fsp: Use mtrr_set_next_var() for graphics memory

2023-07-31 Thread Bin Meng
Hi Simon, On Mon, Jul 31, 2023 at 2:02 PM Bin Meng wrote: > > From: Bin Meng > > At present this uses mtrr_add_request() & mtrr_commit() combination > to program the MTRR for graphics memory. This usage has two major > issues as below: > > - mtrr_commit() will re-initialize all MTRR registers

Re: [PATCH v3] x86: Change tesing logic of mtrr commit

2023-07-31 Thread Bin Meng
Hi Simon, On Tue, Aug 1, 2023 at 12:13 AM Simon Glass wrote: > > Hi Bin, > > On Mon, 31 Jul 2023 at 08:58, Bin Meng wrote: > > > > Hi Simon, > > > > On Mon, Jul 31, 2023 at 9:56 PM Simon Glass wrote: > > > > > > From: Bin Meng > > > > > > On Coral U-Boot SPL programs some MTRRs and FSPv2 in

Re: [PATCH] cmd: improve string matching for hex

2023-07-31 Thread Heinrich Schuchardt
On 31.07.23 16:03, Dan Carpenter wrote: Match the "=0x" instead of just "=0". Signed-off-by: Dan Carpenter --- We sometimes two character partial matching for commands so people can type "re" instead of "read". But here reading two characters doesn't seem correct. cmd/nvedit_efi.c | 2 +-

Re: [PATCH v2 1/1] efi_loader: overflow in efi_allocate_pages

2023-07-31 Thread Heinrich Schuchardt
On 31.07.23 14:46, Ilias Apalodimas wrote: Hi Heinrich, On Sun, 30 Jul 2023 at 13:51, Heinrich Schuchardt wrote: On 32bit systems (pages << EFI_PAGE_SHIFT) may lead to an overflow which does not occur in 64bit arithmetics. You mean this cant happen in 32 bits but can in 64bit right?

Re: [PATCH v3] x86: Change tesing logic of mtrr commit

2023-07-31 Thread Simon Glass
Hi Bin, On Mon, 31 Jul 2023 at 08:58, Bin Meng wrote: > > Hi Simon, > > On Mon, Jul 31, 2023 at 9:56 PM Simon Glass wrote: > > > > From: Bin Meng > > > > On Coral U-Boot SPL programs some MTRRs and FSPv2 in U-Boot proper > > needs to program MTRRs too. With current testing logic of mtrr > >

Re: [PATCH] spl: spl_legacy: Fix spl_end address for non ARM target

2023-07-31 Thread Shiji Yang
On Mon, 31 Jul 2023 16:17:39 +0200, Marek Vasut wrote: >On 7/31/23 13:57, Shiji Yang wrote: >> Only ARM target defines _image_binary_end symbol as char*, All other >> targets define it as an ulong type in include/asm-generic/sections.h. >> >> This patch fixes the boot failure on MIPS target.

Re: [PATCH v2 5/9] board_f: Fix corruption of relocaddr

2023-07-31 Thread Simon Glass
Hi Devarsh, On Mon, 31 Jul 2023 at 05:10, Devarsh Thakkar wrote: > > Hi Simon, > > Thanks for the patch. > > On 30/07/23 22:46, Simon Glass wrote: > > When the video framebuffer comes from the bloblist, we should not change > > relocaddr to this address, since it interfers with the normal memory

[PATCH v3 5/9] board_f: Fix corruption of relocaddr

2023-07-31 Thread Simon Glass
When the video framebuffer comes from the bloblist, we should not change relocaddr to this address, since it interfers with the normal memory allocation. This fixes a boot loop in qemu-x86_64 Signed-off-by: Simon Glass Fixes: 5bc610a7d9d ("common: board_f: Pass frame buffer info from SPL to

Re: Pull request for spl-2023-10-rc2

2023-07-31 Thread Tom Rini
On Sun, Jul 30, 2023 at 09:08:44PM +0200, Heinrich Schuchardt wrote: > Dear Tom, > > The following changes since commit a36d59ba99a19c777d896d4c70e75975654e2831: > > Merge tag 'efi-2023-10-rc2' of > https://source.denx.de/u-boot/custodians/u-boot-efi (2023-07-28 12:48:00 > -0400) > > are

Re: [PATCH v8 0/7] Tegra: add ASUS/Google Nexus 7 (2012) support

2023-07-31 Thread Tom Rini
On Mon, Jul 31, 2023 at 03:19:08PM +0300, Svyatoslav Ryhel wrote: > Hello! > > It has been a month since the last patchset was sent. Should I re-send them? Not unless things don't apply. Thierry, can you put together a pull request soon? Thanks! > > Bast regards, > Svyatoslav Ryhel. > > 30

Re: [PATCH v2 0/2] arm: dts: k3-am6: Sync DT with Linux

2023-07-31 Thread Roger Quadros
On 31/07/2023 15:27, Roger Quadros wrote: > Hi, > > This series syncs AM64 DT files from Linux v6.5-rc1. > > NOTE: I have only boot tested this on AM64-GP-EVM. > I would appreciate a tested-by for AM64-sk EVM. Thanks. Also tested on AM64-SK SR2.0 HS-FS > > cheers, > -roger > > Changelog:

Re: [PATCH 3/6] net: ti: am65-cpsw-nuss: Add logic to support MDIO reset

2023-07-31 Thread Tom Rini
On Mon, Jul 31, 2023 at 02:06:26PM +0530, Siddharth Vadapalli wrote: > > > On 31/07/23 10:13, Siddharth Vadapalli wrote: > > Tom, > > > > On 22/07/23 01:06, Tom Rini wrote: > >> On Sat, Jul 08, 2023 at 04:15:20PM +0530, Siddharth Vadapalli wrote: > >> > >>> From: Suman Anna > >>> > >>> Enhance

Re: [PATCH v3] x86: Change tesing logic of mtrr commit

2023-07-31 Thread Bin Meng
Hi Simon, On Mon, Jul 31, 2023 at 9:56 PM Simon Glass wrote: > > From: Bin Meng > > On Coral U-Boot SPL programs some MTRRs and FSPv2 in U-Boot proper > needs to program MTRRs too. With current testing logic of mtrr > commit in init_cache_f_r(), the mtrr commit is skipped which won't > work as

Re: [PATCH 4/9] Revert "x86: Switch QEMU over to use the bochs driver"

2023-07-31 Thread Bin Meng
Hi Simon, On Mon, Jul 31, 2023 at 10:37 PM Simon Glass wrote: > > Hi Bin, > > On Mon, 31 Jul 2023 at 08:32, Bin Meng wrote: > > > > Hi Simon, > > > > On Sat, Jul 29, 2023 at 1:32 AM Simon Glass wrote: > > > > > > Hi Bin, > > > > > > On Fri, 28 Jul 2023 at 09:46, Bin Meng wrote: > > > > > > >

Re: [PATCH v3 1/4] cmd: bind: Add unbind command with driver filter

2023-07-31 Thread Marek Vasut
On 7/31/23 16:25, Miquel Raynal wrote: Hi Marek, ma...@denx.de wrote on Mon, 31 Jul 2023 16:08:19 +0200: On 7/31/23 15:58, Miquel Raynal wrote: Hi Marek, ma...@denx.de wrote on Mon, 31 Jul 2023 15:50:58 +0200: On 7/31/23 15:36, Miquel Raynal wrote: Hi Marek, ma...@denx.de wrote on

Re: [PATCH 4/9] Revert "x86: Switch QEMU over to use the bochs driver"

2023-07-31 Thread Simon Glass
Hi Bin, On Mon, 31 Jul 2023 at 08:32, Bin Meng wrote: > > Hi Simon, > > On Sat, Jul 29, 2023 at 1:32 AM Simon Glass wrote: > > > > Hi Bin, > > > > On Fri, 28 Jul 2023 at 09:46, Bin Meng wrote: > > > > > > Hi Simon, > > > > > > On Mon, Jul 24, 2023 at 10:52 PM Simon Glass wrote: > > > > > > >

Re: [PATCH] board: ti: am62x: Add variable device tree in env

2023-07-31 Thread Andrew Davis
On 7/31/23 9:27 AM, Jason Kacines wrote: Added variable default_device_tree that grabs from defconfig. Prevents needing to change this variable in two locations if using a separate device tree. In the future, it would be a good idea to remove this logic completely, but this will help reduce

Re: [PATCH 4/9] Revert "x86: Switch QEMU over to use the bochs driver"

2023-07-31 Thread Bin Meng
Hi Simon, On Sat, Jul 29, 2023 at 1:32 AM Simon Glass wrote: > > Hi Bin, > > On Fri, 28 Jul 2023 at 09:46, Bin Meng wrote: > > > > Hi Simon, > > > > On Mon, Jul 24, 2023 at 10:52 PM Simon Glass wrote: > > > > > > Unfortunately the bochs driver does not currently work with distros. It > > >

[PATCH] board: ti: am62x: Add variable device tree in env

2023-07-31 Thread Jason Kacines
Added variable default_device_tree that grabs from defconfig. Prevents needing to change this variable in two locations if using a separate device tree. In the future, it would be a good idea to remove this logic completely, but this will help reduce complications. Signed-off-by: Jason Kacines

Re: [PATCH v3 1/4] cmd: bind: Add unbind command with driver filter

2023-07-31 Thread Miquel Raynal
Hi Marek, ma...@denx.de wrote on Mon, 31 Jul 2023 16:08:19 +0200: > On 7/31/23 15:58, Miquel Raynal wrote: > > Hi Marek, > > > > ma...@denx.de wrote on Mon, 31 Jul 2023 15:50:58 +0200: > > > >> On 7/31/23 15:36, Miquel Raynal wrote: > >>> Hi Marek, > >>> > >>> ma...@denx.de wrote on Mon,

Re: [PATCH v2 1/2] board: ti: am64x: Recognize AM64-HSEVM

2023-07-31 Thread Andrew Davis
On 7/31/23 7:27 AM, Roger Quadros wrote: AM64-HSEVM is AM64-GPEVM with High Security Device. Gets rid of "Unidentified board claims AM64-HSEVM in eeprom header". Signed-off-by: Roger Quadros --- Acked-by: Andrew Davis board/ti/am64x/evm.c | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [PATCH] spl: spl_legacy: Fix spl_end address for non ARM target

2023-07-31 Thread Marek Vasut
On 7/31/23 13:57, Shiji Yang wrote: Only ARM target defines _image_binary_end symbol as char*, All other targets define it as an ulong type in include/asm-generic/sections.h. This patch fixes the boot failure on MIPS target. Error log: SPL: Image overlaps SPL Fixes: 1b8a1be1a1f1 ("spl:

[PATCH] test: fix a couple NULL vs IS_ERR() checks

2023-07-31 Thread Dan Carpenter
The x509_cert_parse() and pkcs7_parse_message() functions return error pointers. They don't return NULL. Update the checks accordingly. Signed-off-by: Dan Carpenter --- test/lib/asn1.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/lib/asn1.c b/test/lib/asn1.c

[PATCH] expo: allocate correct ammount of memory

2023-07-31 Thread Dan Carpenter
This should be allocating the memory for "item" instead of "menu". The item struct is 48 bytes instead of 96 (assuming a 64bit system) so this saves a little memory. Signed-off-by: Dan Carpenter --- boot/scene_menu.c | 2 +- 1 file changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [PATCH v3 1/4] cmd: bind: Add unbind command with driver filter

2023-07-31 Thread Marek Vasut
On 7/31/23 15:58, Miquel Raynal wrote: Hi Marek, ma...@denx.de wrote on Mon, 31 Jul 2023 15:50:58 +0200: On 7/31/23 15:36, Miquel Raynal wrote: Hi Marek, ma...@denx.de wrote on Mon, 31 Jul 2023 13:44:25 +0200: On 7/31/23 11:31, Miquel Raynal wrote: Hi Marek, ma...@denx.de wrote on

[PATCH] cmd: improve string matching for hex

2023-07-31 Thread Dan Carpenter
Match the "=0x" instead of just "=0". Signed-off-by: Dan Carpenter --- We sometimes two character partial matching for commands so people can type "re" instead of "read". But here reading two characters doesn't seem correct. cmd/nvedit_efi.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] dm: Correct DM_FLAG_ comment

2023-07-31 Thread Bin Meng
The macros are prefixed with DM_FLAG_, not DM_FLAGS_. Signed-off-by: Bin Meng --- include/dm/device.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/dm/device.h b/include/dm/device.h index b86bf90609..e54cb6bca4 100644 --- a/include/dm/device.h +++

Re: [PATCH v2 5/9] bootstd: Correct creating of bootdev sibling

2023-07-31 Thread Simon Glass
Hi Bin, On Sun, 30 Jul 2023 at 21:37, Bin Meng wrote: > > Hi Simon, > > On Mon, Jul 31, 2023 at 10:50 AM Simon Glass wrote: > > > > Hi Bin, > > > > On Sun, 30 Jul 2023 at 19:59, Bin Meng wrote: > > > > > > Hi Simon, > > > > > > On Mon, Jul 31, 2023 at 1:15 AM Simon Glass wrote: > > > > > > >

Re: [PATCH v3 1/4] cmd: bind: Add unbind command with driver filter

2023-07-31 Thread Miquel Raynal
Hi Marek, ma...@denx.de wrote on Mon, 31 Jul 2023 15:50:58 +0200: > On 7/31/23 15:36, Miquel Raynal wrote: > > Hi Marek, > > > > ma...@denx.de wrote on Mon, 31 Jul 2023 13:44:25 +0200: > > > >> On 7/31/23 11:31, Miquel Raynal wrote: > >>> Hi Marek, > >>> > >>> ma...@denx.de wrote on Sat,

[PATCH v3] x86: Change tesing logic of mtrr commit

2023-07-31 Thread Simon Glass
From: Bin Meng On Coral U-Boot SPL programs some MTRRs and FSPv2 in U-Boot proper needs to program MTRRs too. With current testing logic of mtrr commit in init_cache_f_r(), the mtrr commit is skipped which won't work as the queued mtrr requests include setup for DRAM regions. Change the logic

Pull request: u-boot-rockchip-20230731

2023-07-31 Thread Kever Yang
a36d59ba99a19c777d896d4c70e75975654e2831: Merge tag 'efi-2023-10-rc2' of https://source.denx.de/u-boot/custodians/u-boot-efi (2023-07-28 12:48:00 -0400) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-rockchip.git tags/u-boot-rockchip-20230731 for you to fetch

  1   2   >