Re: [RFC] make sandbox UT more generic

2023-08-30 Thread AKASHI Takahiro
Hi Simon, On Wed, Aug 30, 2023 at 08:49:05PM -0600, Simon Glass wrote: > Hi, > > On Wed, 30 Aug 2023 at 18:38, AKASHI Takahiro > wrote: > > > > Hi, > > > > I'm working on implementing SCMI-based pinctrl/gpio driver, > > and want to re-use sandbox UT to test the code. However, > > It is somehow

Re: [PATCH v2] cmd: dm: allow for selecting uclass and device

2023-08-30 Thread AKASHI Takahiro
On Wed, Aug 30, 2023 at 09:48:48PM -0600, Simon Glass wrote: > Hi AKASHI, > > On Tue, 22 Aug 2023 at 19:50, AKASHI Takahiro > wrote: > > > > The output from "dm tree" or "dm uclass" is a bit annoying > > if the number of devices available on the system is huge. > > (This is especially true on

Re: [PATCH v2 03/19] video: Hide the BMP options

2023-08-30 Thread Heinrich Schuchardt
Am 31. August 2023 05:52:57 MESZ schrieb Simon Glass : >These appear prominently in the main menu at present. However they are >selected when needed so do not need to be visible. > >Make them hidden. > >Signed-off-by: Simon Glass >--- > >(no changes since v1) > > common/Kconfig | 4 ++-- > 1

Re: [RFC PATCH 9/9] upl: Add initial documentation

2023-08-30 Thread Heinrich Schuchardt
Am 31. August 2023 01:29:23 MESZ schrieb Simon Glass : >Add some placeholder documentation to explain the basic concept. Once the >spec is published, more can be added and this series applied. > >Signed-off-by: Simon Glass >--- > > doc/usage/index.rst | 1 + > doc/usage/upl.rst | 27

[PATCH v2 19/19] boot: Join ARCH_FIXUP_FDT_MEMORY with related options

2023-08-30 Thread Simon Glass
Move this to be with the other devicetree-fixup options. Signed-off-by: Simon Glass --- (no changes since v1) boot/Kconfig | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/boot/Kconfig b/boot/Kconfig index 023446130282..257f4cc085e1 100644 ---

[PATCH v2 18/19] boot: Join FDT_FIXUP_PARTITIONS with related options

2023-08-30 Thread Simon Glass
Move this to be with the other devicetree-fixup options. Signed-off-by: Simon Glass --- (no changes since v1) boot/Kconfig | 8 lib/Kconfig | 9 - 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/boot/Kconfig b/boot/Kconfig index a7dea0a0623b..023446130282

[PATCH v2 17/19] Mark DISTRO_DEFAULTS as deprecated

2023-08-30 Thread Simon Glass
Standard boot has been in place for a while now. Quite a few problems have been found and fixed. It seems like a good time to mark the script-based approach as deprecated and encourage people to use standard boot. Update the DISTRO_DEFAULTS Kconfig to encourage people to move to standard boot,

[PATCH v2 16/19] Kconfig: Move TEXT_BASE et al under general setup

2023-08-30 Thread Simon Glass
These don't relate to booting. Move them out of there and into the same place as the other related settings. Signed-off-by: Simon Glass --- (no changes since v1) Kconfig | 65 boot/Kconfig | 65

[PATCH v2 15/19] boot: Make standard boot a menu

2023-08-30 Thread Simon Glass
Collect these options into a menu for easier viewing. Signed-off-by: Simon Glass --- (no changes since v1) boot/Kconfig | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/boot/Kconfig b/boot/Kconfig index c9b7d3f710b6..17f54b926f05 100644 --- a/boot/Kconfig +++

[PATCH v2 14/19] spl: Tidy up load address in spl_ram

2023-08-30 Thread Simon Glass
This CONFIG is used but is not given a value by some boards. Use a default value of 0 explicitly, rather than relying on the 0 value provided by CONFIG_SPL_LOAD_FIT_ADDRESS This will allow us to make SPL_LOAD_FIT_ADDRESS depend on SPL_LOAD_FIT as it should. Signed-off-by: Simon Glass --- (no

[PATCH v2 13/19] Kconfig: Move SPL_FIT under FIT

2023-08-30 Thread Simon Glass
This option already depends on FIT, so put it under the same umbrella, so that it appears in the FIT menu. Signed-off-by: Simon Glass --- (no changes since v1) boot/Kconfig | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/boot/Kconfig b/boot/Kconfig index

[PATCH v2 12/19] Kconfig: Create a menu for FIT

2023-08-30 Thread Simon Glass
This is a major feature with a lot of options. Give it its own menu to tidy up the 'make menuconfig' display. Drop the 'depends on FIT' pieces which are now unnecessary, since they are now bracketed by an 'if FIT'. Signed-off-by: Simon Glass --- (no changes since v1) boot/Kconfig | 18

[PATCH v2 11/19] boot: Rename Android-boot text

2023-08-30 Thread Simon Glass
Phrases like 'Enable support for' are pointless since this is an option which enables things. Drop that part so it is easier to follow. Signed-off-by: Simon Glass --- (no changes since v1) boot/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/boot/Kconfig

[PATCH v2 10/19] boot: Move some other fdt-fixup options to the same menu

2023-08-30 Thread Simon Glass
Move more options relating to fixing up a device tree into the new devicetree-fixup menu. Signed-off-by: Simon Glass --- (no changes since v1) boot/Kconfig | 55 +--- 1 file changed, 26 insertions(+), 29 deletions(-) diff --git a/boot/Kconfig

[PATCH v2 09/19] Move fdt_simplefb to boot/

2023-08-30 Thread Simon Glass
This relates to booting, so move it there. Create a new Kconfig menu for things related to devicetree fixup. Signed-off-by: Simon Glass --- (no changes since v1) boot/Kconfig| 16 boot/Makefile | 1 + {common => boot}/fdt_simplefb.c | 0

[PATCH v2 08/19] boot: Move fdt_support to boot/

2023-08-30 Thread Simon Glass
This relates to booting since it fixes up the devicetree for the OS. Move it into the boot/ directory. Signed-off-by: Simon Glass --- (no changes since v1) boot/Makefile | 3 +++ {common => boot}/fdt_support.c | 0 common/Makefile| 2 -- 3 files changed, 3

[PATCH v2 07/19] test: Move POST under a renamed Testing section

2023-08-30 Thread Simon Glass
Rename Unit tests to Testing, since it is a stretch to describe some of the tests as unit tests. Move POST there as well, so it doesn't show up by itself in the top-level menu. Signed-off-by: Simon Glass --- (no changes since v1) test/Kconfig | 12 ++-- 1 file changed, 6

[PATCH v2 04/19] video: Move BMP options and code to video directory

2023-08-30 Thread Simon Glass
Put the options and the common BMP code with the other related Kconfig options in the drivers/video directory. Signed-off-by: Simon Glass --- (no changes since v1) common/Kconfig | 11 --- common/Makefile | 1 - drivers/video/Kconfig | 11

[PATCH v2 06/19] FWU: Avoid showing an unselectable menu option

2023-08-30 Thread Simon Glass
Use a menuconfig to avoid showing a menu which cannot be selected in many cases. This option should really go with the other 'Update support'. Perhaps we should even consider a top-level update/ directory? Signed-off-by: Simon Glass Acked-by: Sughosh Ganu --- Changes in v2: - Fix FMU typo in

[PATCH v2 05/19] net: Move SYS_RX_ETH_BUFFER into the network menu

2023-08-30 Thread Simon Glass
Move this Kconfig option into the correct place, so it doesn't show up in the top-level menu. Unfortunately this makes the CONFIG undefined on some boards which don't enable CONFIG_NET but do include the net.h header file. In fact that header is included from a lot of common places. So use a

[PATCH v2 03/19] video: Hide the BMP options

2023-08-30 Thread Simon Glass
These appear prominently in the main menu at present. However they are selected when needed so do not need to be visible. Make them hidden. Signed-off-by: Simon Glass --- (no changes since v1) common/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v2 02/19] Kconfig: Move API into general setup

2023-08-30 Thread Simon Glass
This is perhaps not a commonly used feature so should not have its own option in the main menu. Move it under general setup. Signed-off-by: Simon Glass --- (no changes since v1) Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Kconfig b/Kconfig index

[PATCH v2 01/19] lib: rational: Move the Kconfigs into the correct place

2023-08-30 Thread Simon Glass
These should not be part of the 'system tables' menu. Move them outside on their own. Signed-off-by: Simon Glass Fixes: 7d0f3fbb93c ("lib: rational: copy the rational fraction lib...") --- (no changes since v1) lib/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v2 00/19] Kconfig: Tidy up some options

2023-08-30 Thread Simon Glass
The view from 'make menuconfig' is confusing in places. This series aims to improve the top-level menu and also the boot menu. It also groups FDT-fixup options tegether, at least the ones I could fine. Finally this series marks the distro scripts as deprecated, so people have a pointer to

Re: [RFX PATCH 0/9] Universal Payload initial series

2023-08-30 Thread Heinrich Schuchardt
Am 31. August 2023 01:28:37 MESZ schrieb Simon Glass : >Universal Payload (UPL) is an upcoming Industry Standard for firmware >components. UPL is designed to improve interoperability within the >firmware industry, allowing mixing and matching of projects with less >friction and fewer

Re: [PATCH v2] cmd: dm: allow for selecting uclass and device

2023-08-30 Thread Simon Glass
Hi AKASHI, On Tue, 22 Aug 2023 at 19:50, AKASHI Takahiro wrote: > > The output from "dm tree" or "dm uclass" is a bit annoying > if the number of devices available on the system is huge. > (This is especially true on sandbox when I debug some DM code.) > > With this patch, we can specify the

Re: [RFC PATCH 0/5] Allow for removal of DT nodes and properties

2023-08-30 Thread Simon Glass
Hi Peter, On Wed, 30 Aug 2023 at 02:19, Peter Robinson wrote: > > > > > > > I have started the process to upstream the binman bindings. > > > > > > > > > > I don't think they should be in DT at all, they don't describe > > > > > anything to do with hardware, or generally even the runtime of a >

Re: [PATCH v2 0/1] meson: Demonstration of using binman to produce the image

2023-08-30 Thread Simon Glass
Hi Ferass, On Wed, 30 Aug 2023 at 11:53, Ferass El Hafidi wrote: > > Hi Simon, > > > So I wonder how best to move this forward so that we can build things > > using binman and everything works? > > It's still not ready yet, but I'm working on porting U-Boot SPL to some > Amlogic SoCs [1]. I'm

[PATCH v2 2/2] x86: Prevent from missing the FADT chaining

2023-08-30 Thread Simon Glass
From: Andy Shevchenko Recent approach with FADT writer shows that there is a room for subtle errors. Prevent this from happening again by introducing acpi_add_fadt() helper. Signed-off-by: Andy Shevchenko Signed-off-by: Simon Glass --- (no changes since v1) arch/x86/cpu/apollolake/acpi.c |

[PATCH v2 1/2] Reland "x86: Move FACP table into separate functions""

2023-08-30 Thread Simon Glass
Each board has its own way of creating this table. Rather than calling the acpi_create_fadt() function for each one from a common acpi_write_fadt() function, just move the writer into the board-specific code. Signed-off-by: Simon Glass Signed-off-by: Andy Shevchenko --- (Now fixed - thank you

Re: [RFC PATCH 1/2] Makefile: Run defconfig files through the C preprocessor

2023-08-30 Thread Simon Glass
Hi Andrew, On Tue, 29 Aug 2023 at 16:15, Andrew Davis wrote: > > This allows us to use some of the normal preprocessor directives inside > defconfig files. Such as #define and #include. > > Signed-off-by: Andrew Davis > --- > scripts/kconfig/Makefile | 3 ++- > 1 file changed, 2 insertions(+),

Re: [PATCH v5 11/13] video: Use VIDEO_DAMAGE for VIDEO_COPY

2023-08-30 Thread Simon Glass
Hi Alper, On Wed, 30 Aug 2023 at 13:07, Alper Nebi Yasak wrote: > > On 2023-08-21 23:06 +03:00, Alexander Graf wrote: > > > > On 21.08.23 21:11, Simon Glass wrote: > >> Hi Alper, > >> > >> On Mon, 21 Aug 2023 at 07:51, Alper Nebi Yasak > >> wrote: > >>> From: Alexander Graf > >>> > >>>

Re: [RFC PATCH 2/2] configs: Add am62x_beagleplay_* defconfigs

2023-08-30 Thread Simon Glass
Hi, On Wed, 30 Aug 2023 at 09:17, Andrew Davis wrote: > > On 8/30/23 9:59 AM, Nishanth Menon wrote: > > On 09:31-20230830, Andrew Davis wrote: > >> On 8/30/23 7:31 AM, Nishanth Menon wrote: > >>> On 17:14-20230829, Andrew Davis wrote: > >>>&

Re: [RFC PATCH 5/5] doc: Add a document for non-compliant DT node/property removal

2023-08-30 Thread Simon Glass
Hi Ilias, On Wed, 30 Aug 2023 at 01:25, Ilias Apalodimas wrote: > > Hi Tom > > On Mon, 28 Aug 2023 at 21:39, Tom Rini wrote: > > > > On Tue, Aug 29, 2023 at 12:04:53AM +0530, Sughosh Ganu wrote: > > > hi Simon, > > > > > > On Mon, 28 Aug 2023 at 23:25, Simon Glass wrote: > > > > > > > > Hi

Re: [PATCH] driver: rng: Add DM_RNG interface for ARMv8.5 RNDR registers

2023-08-30 Thread Simon Glass
Hi Andre, On Wed, 30 Aug 2023 at 05:32, Andre Przywara wrote: > > The ARMv8.5 architecture extension defines architectural RNDR/RNDRRS > system registers, that provide 64 bits worth of randomness on every > read. Since it's an extension, and implementing it is optional, there is > a field in the

Re: [PATCH v2] spl: bootstage: move bootstage_stash before jumping to image

2023-08-30 Thread Simon Glass
Hi Chanho, On Tue, 29 Aug 2023 at 23:10, Chanho Park wrote: > > Hi Simon, > > > -Original Message- > > From: Simon Glass > > Sent: Wednesday, August 30, 2023 1:38 AM > > To: Chanho Park > > Cc: Nikhil M Jain ; Marek Vasut ; u- > > b...@lists.denx.de > > Subject: Re: [PATCH v2] spl:

Re: [PATCH v2 4/4] dm: core: Modify default for OFNODE_MULTI_TREE

2023-08-30 Thread Simon Glass
On Tue, 29 Aug 2023 at 14:37, wrote: > > From: Sean Edmond > > There is a preference to use the "ofnode" API for FDT fixups > moving forward. The FDT fixup will usually be for the kernel FDT. To > fixup the kernel FDT with the ofnode API, it's required to set the > OFNODE_MULTI_TREE option. >

[PATCH] am33xx: ignore return value from usb_ether_init()

2023-08-30 Thread Trevor Woerner
In 2cb43ef1c223 ("usb: ether: Fix error handling in usb_ether_init") the error handling of usb_ether_init() was changed. Not a single other call site of this function checks its return value, therefore follow suit in the am33xx code. Do not cause the boot to halt if the usb gadget ethernet

Re: [PATCH v5 04/13] dm: video: Add damage tracking API

2023-08-30 Thread Simon Glass
Hi Alper, On Wed, 30 Aug 2023 at 13:15, Alper Nebi Yasak wrote: > > > > On 2023-08-21 22:11 +03:00, Simon Glass wrote: > > On Mon, 21 Aug 2023 at 07:51, Alper Nebi Yasak > > wrote: > >> > >> From: Alexander Graf > >> > >> We are going to introduce image damage tracking to fasten up screen >

Re: [RFC] make sandbox UT more generic

2023-08-30 Thread Simon Glass
Hi, On Wed, 30 Aug 2023 at 18:38, AKASHI Takahiro wrote: > > Hi, > > I'm working on implementing SCMI-based pinctrl/gpio driver, > and want to re-use sandbox UT to test the code. However, > It is somehow sandbox-specific (with additional DT nodes). > How can/should we make it more generic for

RE: [PATCH] fpga: define dummy fpga_load function for debug build

2023-08-30 Thread Chanho Park
> On 8/16/23 08:54, Chanho Park wrote: > > This fixes below build error when CC_OPTIMIZE_FOR_DEBUG is enabled and > > CONFIG_SPL_FPGA is not enabled. > > I would rewrite this because the connection to SPL_FPGA is just one part > of it. > It is also taken when CONFIG_FPGA is not enabled. Sure.

[RFC] make sandbox UT more generic

2023-08-30 Thread AKASHI Takahiro
Hi, I'm working on implementing SCMI-based pinctrl/gpio driver, and want to re-use sandbox UT to test the code. However, It is somehow sandbox-specific (with additional DT nodes). How can/should we make it more generic for other targets/drivers rather than just by copying the test code? (I have

[RFC PATCH 9/9] upl: Add initial documentation

2023-08-30 Thread Simon Glass
Add some placeholder documentation to explain the basic concept. Once the spec is published, more can be added and this series applied. Signed-off-by: Simon Glass --- doc/usage/index.rst | 1 + doc/usage/upl.rst | 27 +++ 2 files changed, 28 insertions(+) create

[RFC PATCH 8/9] sandbox_vpl: Enable Universal Payload

2023-08-30 Thread Simon Glass
Use the sandbox_vpl build to test UPL since it supports a real devicetree in SPL. The sandbox_spl build uses OF_PLATDATA. Enable writing the UPL handoff in SPL and reading it in U-Boot proper. Provide a test to check that this handoff works. Note that the test uses the standard devicetree rather

[RFC PATCH 7/9] Plumb in universal payload to the init process

2023-08-30 Thread Simon Glass
Read the UPL early in boot so that it is available. For now none of the information is used. Signed-off-by: Simon Glass --- boot/Kconfig | 12 +++- common/board_f.c | 22 ++ common/board_r.c | 2 ++ 3 files changed, 35 insertions(+), 1 deletion(-) diff --git

[RFC PATCH 6/9] spl: Plumb in the Universal Payload handoff

2023-08-30 Thread Simon Glass
Specify the FIT and include information about each loaded image, as required by the UPL handoff. Write the UPL handoff into the bloblist before jumping to the next phase. Signed-off-by: Simon Glass --- common/spl/spl.c | 6 ++ common/spl/spl_fit.c | 22 ++

[RFC PATCH 3/9] upl: Add basic tests

2023-08-30 Thread Simon Glass
Add some unit tests to check that we can write a UPL handoff and read it back. Signed-off-by: Simon Glass --- test/boot/Makefile | 2 + test/boot/upl.c| 420 + 2 files changed, 422 insertions(+) create mode 100644 test/boot/upl.c diff --git

[RFC PATCH 4/9] upl: Add a command

2023-08-30 Thread Simon Glass
Add a 'upl' command to work with Universal Payload features. For now it only supports reading and writing a handoff structure. Signed-off-by: Simon Glass --- boot/Kconfig | 1 + cmd/Kconfig | 7 ++ cmd/Makefile | 1 +

[RFC PATCH 5/9] upl: Add support for Universal Payload in SPL

2023-08-30 Thread Simon Glass
Add the basic code to create a handoff structure in SPL, so it can be passed to the next phase. For now this is not plumbed in. Signed-off-by: Simon Glass --- boot/Kconfig | 32 + common/spl/Makefile | 2 + common/spl/spl_upl.c | 153

[RFC PATCH 2/9] upl: Add support for writing a upl handoff

2023-08-30 Thread Simon Glass
Universal Payload provides a standard way of handing off control between two firmware phases. Add support for writing the handoff information from a structure. Signed-off-by: Simon Glass --- boot/Kconfig | 8 + boot/Makefile| 1 + boot/upl_write.c | 623

[RFC PATCH 1/9] upl: Add support for reading a upl handoff

2023-08-30 Thread Simon Glass
Universal Payload provides a standard way of handing off control between two firmware phases. Add support for reading the handoff information into a structure. Signed-off-by: Simon Glass --- boot/Kconfig | 21 +- boot/Makefile | 3 + boot/upl_common.c | 51

[RFC PATCH 0/9] Universal Payload initial series

2023-08-30 Thread Simon Glass
Universal Payload (UPL) is an upcoming Industry Standard for firmware components. UPL is designed to improve interoperability within the firmware industry, allowing mixing and matching of projects with less friction and fewer project-specific implementations. UPL is cross-platform, supporting ARM,

[RFX PATCH 0/9] Universal Payload initial series

2023-08-30 Thread Simon Glass
Universal Payload (UPL) is an upcoming Industry Standard for firmware components. UPL is designed to improve interoperability within the firmware industry, allowing mixing and matching of projects with less friction and fewer project-specific implementations. UPL is cross-platform, supporting ARM,

[PATCH v5 3/4] schemas: Add some common reserved-memory usages

2023-08-30 Thread Simon Glass
The Devicetree specification skips over handling of a logical view of the memory map, pointing users to the UEFI specification. It is common to split firmware into 'Platform Init', which does the initial hardware setup and a "Payload" which selects the OS to be booted. Thus an handover interface

[PATCH v5 2/4] Bring in some other reserved-memory files

2023-08-30 Thread Simon Glass
Add schema yaml files from v6.5 which are not vendor-specific, nor Linux-specific. Signed-off-by: Simon Glass --- Changes in v5: - Trim back to just a subset of mostly generic schemas Changes in v4: - New patch .../schemas/reserved-memory/framebuffer.yaml | 52 ++

[PATCH v5 4/4] memory: Add ECC properties

2023-08-30 Thread Simon Glass
Some memories provide ECC detection and/or correction. For software which wants to check memory, it is helpful to see which regions provide this feature. Add this as a property of the /memory nodes, since it presumably follows the hardware-level memory system. Signed-off-by: Simon Glass ---

[PATCH v5 1/4] Add reserved-memory

2023-08-30 Thread Simon Glass
Bring in this file from Linux v6.5 Signed-off-by: Simon Glass --- (no changes since v4) Changes in v4: - New patch .../reserved-memory/reserved-memory.yaml | 181 ++ 1 file changed, 181 insertions(+) create mode 100644

Re: [PATCH 32/32] pci: serial: Support reading PCI-register size with base

2023-08-30 Thread Tom Rini
On Wed, Aug 30, 2023 at 11:29:34PM +0200, Pali Rohár wrote: > There were no answers. > > On Wednesday 30 August 2023 17:26:20 Tom Rini wrote: > > I'm trimming the CC list. All of those points you list were addressed > > and answered in your last long running argument. You need to decide what > >

Re: [PATCH 09/32] spl: Avoid an #ifdef when printing gd->malloc_ptr

2023-08-30 Thread Tom Rini
On Wed, Aug 30, 2023 at 12:04:40PM -0600, Simon Glass wrote: > Use an accessor in the header file to avoid this. > > Signed-off-by: Simon Glass > --- > > common/spl/spl.c | 9 + > include/asm-generic/global_data.h | 7 +++ > 2 files changed, 12 insertions(+), 4

Re: [PATCH 03/32] spl: Rename SYS_SPL_ARGS_ADDR to SPL_SYS_ARGS_ADDR

2023-08-30 Thread Tom Rini
On Wed, Aug 30, 2023 at 12:04:34PM -0600, Simon Glass wrote: > Rename this so that SPL is first, as per U-Boot convention. > > Signed-off-by: Simon Glass [snip] > diff --git a/doc/develop/falcon.rst b/doc/develop/falcon.rst > index a569d1a2951..fbf8c10e47e 100644 > --- a/doc/develop/falcon.rst

Re: [PATCH 07/32] spl: Avoid #ifdef with CONFIG_SPL_SYS_ARGS_ADDR

2023-08-30 Thread Tom Rini
On Wed, Aug 30, 2023 at 12:04:38PM -0600, Simon Glass wrote: > Use IF_ENABLED_INT() to avoid needing to use the preprocessor. Give the > Kconfig option a default since we try to avoid hex values without > defaults. > > Signed-off-by: Simon Glass > --- > > common/spl/Kconfig | 1 + >

Re: [PATCH 04/32] spl: Avoid #ifdef with CONFIG_SPL_SYS_MALLOC

2023-08-30 Thread Tom Rini
On Wed, Aug 30, 2023 at 12:04:35PM -0600, Simon Glass wrote: > Use IF_ENABLED_INT() to avoid needing to use the preprocessor. > > Signed-off-by: Simon Glass > --- > > common/spl/spl.c | 12 > include/system-constants.h | 5 - > 2 files changed, 12 insertions(+), 5

Re: [PATCH 32/32] pci: serial: Support reading PCI-register size with base

2023-08-30 Thread Pali Rohár
There were no answers. On Wednesday 30 August 2023 17:26:20 Tom Rini wrote: > I'm trimming the CC list. All of those points you list were addressed > and answered in your last long running argument. You need to decide what > is best for you moving forward and I would ask that it not involve >

Re: [PATCH 32/32] pci: serial: Support reading PCI-register size with base

2023-08-30 Thread Tom Rini
I'm trimming the CC list. All of those points you list were addressed and answered in your last long running argument. You need to decide what is best for you moving forward and I would ask that it not involve complaining that you're being asked to review code that you're a listed maintainer of.

Re: [PATCH 32/32] pci: serial: Support reading PCI-register size with base

2023-08-30 Thread Pali Rohár
Seems that you completely miss the point of the argument, then the only option for such people is to repeat them. Or have I repeat you again that you have not answered the first question, why you are asking for review from somebody who you are ignoring and not taking into account? You do not want

Re: [PATCH v3 1/2] schemas: Add a schema for memory map

2023-08-30 Thread Simon Glass
Hi Ard, On Tue, 29 Aug 2023 at 15:32, Ard Biesheuvel wrote: > > On Tue, 29 Aug 2023 at 21:18, Simon Glass wrote: > > > > Hi Ard, > > > > On Thu, 24 Aug 2023 at 03:10, Ard Biesheuvel wrote: > > > > > > On Wed, 23 Aug 2023 at 22:04, Simon Glass wrote: > > > > > > > > Hi, > > > > > > > > On Wed,

Re: [PATCH 32/32] pci: serial: Support reading PCI-register size with base

2023-08-30 Thread Tom Rini
I don't think it's worth re-hashing the same arguments over and over. There is no "my persons", there is the public community. If you no longer wish to participate, I can remove you from the maintainers entries you're listed in. But please stop with the long arguments unrelated to the patches at

Re: [PATCH 32/32] pci: serial: Support reading PCI-register size with base

2023-08-30 Thread Pali Rohár
So lets recap what you and your persons have done in last 6 months: * Ignored my changes * Ignored my reviews * Ignored my regression reports * Ignored my reminders And now you complaining that I'm not going to do another review? Then you should be the first who step down there as incompetent

Re: [PATCH v5 10/13] video: Only dcache flush damaged lines

2023-08-30 Thread Alexander Graf
On 30.08.23 21:12, Alper Nebi Yasak wrote: On 2023-08-22 02:03 +03:00, Simon Glass wrote: Hi Alex, On Mon, 21 Aug 2023 at 16:44, Alexander Graf wrote: On 22.08.23 00:10, Simon Glass wrote: Hi Alex, On Mon, 21 Aug 2023 at 13:59, Alexander Graf wrote: On 21.08.23 21:11, Simon Glass

Re: [PATCH v5 00/13] Add video damage tracking

2023-08-30 Thread Alexander Graf
On 29.08.23 11:19, Mark Kettenis wrote: Date: Tue, 29 Aug 2023 08:20:49 +0200 From: Alexander Graf On 28.08.23 23:54, Heinrich Schuchardt wrote: On 8/28/23 22:24, Alexander Graf wrote: On 28.08.23 19:54, Simon Glass wrote: Hi Alex, On Wed, 23 Aug 2023 at 02:56, Alexander Graf wrote:

Re: [PATCH 1/5] drivers: rtc: add rv3032 driver

2023-08-30 Thread Steffen Dirkwinkel
Hi, > On 30. Aug 2023, at 21:43, Alexandre Belloni > wrote: > > Hello, > > On 30/08/2023 16:03:30+0200, Steffen Dirkwinkel wrote: >> From: Steffen Dirkwinkel >> >> Based on linux driver, with these differences: >> - no support for trickle charger >> - no support for hwmon >> - no support for

Re: [PATCH v5 00/13] Add video damage tracking

2023-08-30 Thread Alexander Graf
On 30.08.23 20:27, Alper Nebi Yasak wrote: Hi all, On 2023-08-29 09:27 +03:00, Alexander Graf wrote: On 29.08.23 00:08, Simon Glass wrote: On Mon, 28 Aug 2023 at 14:24, Alexander Graf wrote: On 28.08.23 19:54, Simon Glass wrote: U-Boot does have video_sync() but it doesn't know when to

Re: [PATCH 32/32] pci: serial: Support reading PCI-register size with base

2023-08-30 Thread Pali Rohár
And you too. That was at the time when you and your people were interested in reviews from others. On Wednesday 30 August 2023 15:41:57 Tom Rini wrote: > Then you should probably remove yourself from the places you've listed > yourself as an interested maintainer, thanks. > > On Wed, Aug 30,

Re: [PATCH 1/5] drivers: rtc: add rv3032 driver

2023-08-30 Thread Alexandre Belloni
Hello, On 30/08/2023 16:03:30+0200, Steffen Dirkwinkel wrote: > From: Steffen Dirkwinkel > > Based on linux driver, with these differences: > - no support for trickle charger > - no support for hwmon > - no support for battery backed memory > - dm_i2c instead of regmap > - different tm_year and

Re: [PATCH 32/32] pci: serial: Support reading PCI-register size with base

2023-08-30 Thread Tom Rini
Then you should probably remove yourself from the places you've listed yourself as an interested maintainer, thanks. On Wed, Aug 30, 2023 at 09:10:36PM +0200, Pali Rohár wrote: > You have already decided, what is the point? You are not taking any my > objections into account, so stop writing to

Re: [PATCH v5 04/13] dm: video: Add damage tracking API

2023-08-30 Thread Alper Nebi Yasak
On 2023-08-21 22:11 +03:00, Simon Glass wrote: > On Mon, 21 Aug 2023 at 07:51, Alper Nebi Yasak > wrote: >> >> From: Alexander Graf >> >> We are going to introduce image damage tracking to fasten up screen >> refresh on large displays. This patch adds damage tracking for up to >> one

Re: [PATCH v5 10/13] video: Only dcache flush damaged lines

2023-08-30 Thread Alper Nebi Yasak
On 2023-08-22 02:03 +03:00, Simon Glass wrote: > Hi Alex, > > On Mon, 21 Aug 2023 at 16:44, Alexander Graf wrote: >> >> >> On 22.08.23 00:10, Simon Glass wrote: >>> Hi Alex, >>> >>> On Mon, 21 Aug 2023 at 13:59, Alexander Graf wrote: On 21.08.23 21:11, Simon Glass wrote: > Hi

Re: [PATCH 32/32] pci: serial: Support reading PCI-register size with base

2023-08-30 Thread Pali Rohár
You have already decided, what is the point? You are not taking any my objections into account, so stop writing to me and to others these your stupids bullshits. I'm not an idiot who is interesting for them. On Wednesday 30 August 2023 15:04:22 Tom Rini wrote: > You're a listed maintainer for a

Re: [PATCH v5 11/13] video: Use VIDEO_DAMAGE for VIDEO_COPY

2023-08-30 Thread Alper Nebi Yasak
On 2023-08-21 23:06 +03:00, Alexander Graf wrote: > > On 21.08.23 21:11, Simon Glass wrote: >> Hi Alper, >> >> On Mon, 21 Aug 2023 at 07:51, Alper Nebi Yasak >> wrote: >>> From: Alexander Graf >>> >>> CONFIG_VIDEO_COPY implemented a range-based copying mechanism: If we >>> print a single

Re: [PATCH 32/32] pci: serial: Support reading PCI-register size with base

2023-08-30 Thread Tom Rini
You're a listed maintainer for a file being changed. If you objected to the changes, your objection would matter. If you don't object, you can just ignore it, or review it, whatever you like. You need to decide what you want to do about code you're volunteering to maintain. On Wed, Aug 30, 2023

Re: [PATCH v2 2/2] armv8: Disable SYS_DCACHE_OFF & SYS_ICACHE_OFF for ARM64

2023-08-30 Thread Tom Rini
On Tue, Aug 22, 2023 at 01:21:12PM +0530, Bhupesh Sharma wrote: > Ideally SYS_ICACHE_OFF and SYS_DCACHE_OFF should never be set for > ARM64 (ARMv8) platforms, as it makes booting u-boot slower on these > platforms. > > However, if some platforms require ICACHE or DCACHE to be disabled > only

Re: [PATCH 32/32] pci: serial: Support reading PCI-register size with base

2023-08-30 Thread Pali Rohár
And what? How it is related to the statements that my reviews would also ignored? And what you want from me now? On Wednesday 30 August 2023 14:17:50 Tom Rini wrote: > Pali, > > You are specifically listed as a maintainer for drivers/pci/pci_mvebu.c > and that is changed by this patch. > > On

Re: [PATCH v5 00/13] Add video damage tracking

2023-08-30 Thread Alper Nebi Yasak
Hi all, On 2023-08-29 09:27 +03:00, Alexander Graf wrote: > On 29.08.23 00:08, Simon Glass wrote: >> On Mon, 28 Aug 2023 at 14:24, Alexander Graf wrote: >>> On 28.08.23 19:54, Simon Glass wrote: U-Boot does have video_sync() but it doesn't know when to call it. If it does not call it,

Re: [PATCH 32/32] pci: serial: Support reading PCI-register size with base

2023-08-30 Thread Tom Rini
Pali, You are specifically listed as a maintainer for drivers/pci/pci_mvebu.c and that is changed by this patch. On Wed, Aug 30, 2023 at 08:14:59PM +0200, Pali Rohár wrote: > Simon, why you are contacting me? You have wrote to me that you would > ignore my reviews here, so what you want now?

[PATCH 00/32] spl: Preparation for Universal Payload

2023-08-30 Thread Simon Glass
This series tidies up SPL a little and adds some core ofnode functions needed to support Universal Payload. It also includes a few minor fix-ups for sandbox. For SPL the changes include CONFIG naming, removing various #ifdefs and tidying up the FIT code. One notable piece of the ofnode

[PATCH 4/5] xilinx: zynqmp: add Beckhoff CX8200

2023-08-30 Thread Steffen Dirkwinkel
From: Steffen Dirkwinkel This adds support for the Beckhoff CX8200 series of industrial embedded PCs. There is some information about the device and features here: https://www.beckhoff.com/en-en/products/ipc/embedded-pcs/cx8200-arm-cortex-a53/ Currently supported/tested: - Boot from microSD -

[PATCH 5/5] xilinx: zynqmp: beckhoff cx8200: setup inner cache broadcasting

2023-08-30 Thread Steffen Dirkwinkel
From: Steffen Dirkwinkel We need it for coherent access between pl and ps. >From xilinx documentation: https://xilinx-wiki.atlassian.net/wiki/spaces/A/pages/18842098/Zynq+UltraScale+MPSoC+Cache+Coherency Inner Cache Broadcasting Linux sets up the MMU for cacheable memory to be inner shareable

[PATCH 3/5] xilinx: zynqmp: move fdt_addr so we can use devices with less memory

2023-08-30 Thread Steffen Dirkwinkel
From: Steffen Dirkwinkel With the current config we'd put the fdt outside of memory. Signed-off-by: Steffen Dirkwinkel --- include/configs/xilinx_zynqmp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/configs/xilinx_zynqmp.h b/include/configs/xilinx_zynqmp.h

[PATCH 1/5] drivers: rtc: add rv3032 driver

2023-08-30 Thread Steffen Dirkwinkel
From: Steffen Dirkwinkel Based on linux driver, with these differences: - no support for trickle charger - no support for hwmon - no support for battery backed memory - dm_i2c instead of regmap - different tm_year and tm_mon read/write access the user eeprom. The read and write functions access

[PATCH 2/5] drivers/usb/dwc3: zynqmp: only free reset gpio if we have one

2023-08-30 Thread Steffen Dirkwinkel
From: Steffen Dirkwinkel This gpio is optional so undonditionally freeing it will crash. Signed-off-by: Steffen Dirkwinkel --- drivers/usb/dwc3/dwc3-generic.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/dwc3-generic.c

[PATCH 0/5] board: xilinx: zyqmp: add Beckhoff CX8200

2023-08-30 Thread Steffen Dirkwinkel
From: Steffen Dirkwinkel This adds support for the Beckhoff CX8200 series of industrial embedded PCs. There is some information about the device and features here: https://www.beckhoff.com/en-en/products/ipc/embedded-pcs/cx8200-arm-cortex-a53/ We also add the rtc rv3032 driver from linux, as

Re: [PATCH 32/32] pci: serial: Support reading PCI-register size with base

2023-08-30 Thread Pali Rohár
Simon, why you are contacting me? You have wrote to me that you would ignore my reviews here, so what you want now? Could you please explain what you are trying to achieve? I'm not going to review this or any other your changes. On Wednesday 30 August 2023 12:05:03 Simon Glass wrote: > The PCI

[PATCH 32/32] pci: serial: Support reading PCI-register size with base

2023-08-30 Thread Simon Glass
The PCI helpers read only the base address for a PCI region. In some cases the size is needed as well, e.g. to pass along to a driver which needs to know the size of its register area. Update the functions to allow the size to be returned. For serial, record the information and provided it with

[PATCH 31/32] command: Include a required header in command.h

2023-08-30 Thread Simon Glass
This uses ARRAY_SIZE() but does not include the header file which declares it. Fix this, so that command.h can be included without common.h Signed-off-by: Simon Glass --- include/command.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/command.h b/include/command.h index

[PATCH 30/32] fdt: Allow the devicetree to come from a bloblist

2023-08-30 Thread Simon Glass
Standard passage provides for a bloblist to be passed from one firmware phase to the next. That can be used to pass the devicetree along as well. Add an option to support this. Tests for this will be added as part of the Universal Payload work. Signed-off-by: Simon Glass --- common/bloblist.c

[PATCH 29/32] bloblist: Support initing from multiple places

2023-08-30 Thread Simon Glass
Typically the bloblist is set up after the devicetree is present. This makes sense because bloblist may use malloc() to allocate the space it needs. However sometimes the devicetree itself may be present in the bloblist. In that case it is at a known location in memory so we can init the bloblist

[PATCH 28/32] sandbox: Move the bloblist down a little in memory

2023-08-30 Thread Simon Glass
Move this down by 4KB so that it is large enough to hold the devicetree. Also fix up the devicetree address in the documetation while we are here. Signed-off-by: Simon Glass --- common/Kconfig | 2 +- doc/arch/sandbox/sandbox.rst | 4 ++-- test/lib/kconfig.c | 4 ++--

[PATCH 27/32] sandbox: Only read the state if we have a state file

2023-08-30 Thread Simon Glass
We should not read this unless requested. Make it conditional on the option being provided. Add some debugging to show the state being written. Signed-off-by: Simon Glass --- arch/sandbox/cpu/start.c | 8 +--- arch/sandbox/cpu/state.c | 1 + 2 files changed, 6 insertions(+), 3

[PATCH 26/32] sandbox: Init the EC properly even if no state file is available

2023-08-30 Thread Simon Glass
This currently relies on sandbox attempting to read a state file. At present it always does, even when there is no state file, in which case it fails, but still inits the EC. That is a bug, so update this driver to set the current image always, even if no state is read. Signed-off-by: Simon

[PATCH 25/32] sandbox: Move reading the RAM buffer into a better place

2023-08-30 Thread Simon Glass
This should not happen in the argument-parsing function. Move it to the main program. Add some debugging for reading/writing. Signed-off-by: Simon Glass --- arch/sandbox/cpu/start.c | 19 +++ arch/sandbox/cpu/state.c | 1 + 2 files changed, 12 insertions(+), 8 deletions(-)

  1   2   >