[PATCH 2/2] ARM: imx: Update DRAM timings with inline ECC on DH i.MX8MP DHCOM SoM

2023-12-15 Thread Marek Vasut
Import DRAM timings generated by the DDR tool 3.31 which introduce assorted tweaks to the DRAM controller settings. Furthermore, enable DBI to improve noise resilience of the DRAM bus by reducing the number of bit changes on the bus. Reduce the DRAM rate to 3600 MTps to remove all remaining

[PATCH 1/2] ARM: imx: Force DRAM regulators into FPWM mode on DH i.MX8MP DHCOM SoM

2023-12-15 Thread Marek Vasut
In case the Buck5 and Buck6 regulators which supply DRAM Vdd1 and Vdd2/Vddq respectively operate in automatic PWM/PFM mode, the DRAM EDAC detects more correctable errors than if the regulators operate in forced PWM only mode. Force DRAM regulators to forced PWM mode only to stop tempting the DRAM.

[PATCH] ARM: dts: imx7d-pico: Fix alias node indent

2023-12-15 Thread Marek Vasut
Switch from indent with spaces to indent with tabs. No functional change. Fixes: f8548ce0e093 ("imx7d-pico: Fix the name of the u-boot.dtsi file") Signed-off-by: Marek Vasut --- Cc: "NXP i.MX U-Boot Team" Cc: Fabio Estevam Cc: Stefano Babic Cc: u-boot@lists.denx.de ---

[PATCH v3 00/22] Complete decoupling of bootm logic from commands

2023-12-15 Thread Simon Glass
This series continues refactoring the bootm code to allow it to be used with CONFIG_COMMAND disabled. The OS-handling code is refactored and a new bootm_run() function is created to run through the bootm stages. This completes the work. A booti_go() function is created also, in case it proves

[PATCH v3 10/22] bootm: Add more fields to bootm_info

2023-12-15 Thread Simon Glass
Add fields for the three bootm parameters and other things needed for booting. Also add a helper to set up the struct correctly. Signed-off-by: Simon Glass --- Changes in v3: - Rename addr_fit to addr_img in struct bootm_info Changes in v2: - Split out adding the rest of struct bootm_info

[PATCH v3 22/22] bootm: Create a new boot_run() function to handle booting

2023-12-15 Thread Simon Glass
Create a common function used by the three existing bootz/i/m_run() functions, to reduce duplicated code. Signed-off-by: Simon Glass Suggested-by: Tom Rini --- Changes in v3: - Add new boot_run() function boot/bootm.c| 40 ++-- include/bootm.h | 18

[PATCH v3 21/22] bootm: Create a function to run through the booti states

2023-12-15 Thread Simon Glass
In a few places, the booti command is used to handle a boot. We want these to be done without needing CONFIG_CMDLINE, so add a new booti_run() function to handle this. So far this is not used. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: - Rework series to allow OS

[PATCH v3 20/22] stm32: Use bootm_run() and bootz_run()

2023-12-15 Thread Simon Glass
Use the new bootm/z_run() functions to avoid having to create an argument list for the stm32prog code. Signed-off-by: Simon Glass Reviewed-by: Patrick Delaunay --- Changes in v3: - Rename addr_fit to addr_img in struct bootm_info .../cmd_stm32prog/cmd_stm32prog.c | 20

[PATCH v3 19/22] bootm: Create a function to run through the bootz states

2023-12-15 Thread Simon Glass
In a few places, the bootz command is used to handle a boot. We want these to be done without needing CONFIG_CMDLINE, so add a new bootz_run() function to handle this. Signed-off-by: Simon Glass --- (no changes since v1) boot/bootm.c| 13 + cmd/bootz.c | 9 ++---

[PATCH v3 18/22] stm32: Use local vars in stm32prog for initrd and fdt

2023-12-15 Thread Simon Glass
Rather than assigning to the bootm_argv[] array multiple times, use local variables for the two things that can change and assign them at the end. This makes it easier to drop the array eventually. Tidu up an overly short line while we are here. Signed-off-by: Simon Glass Reviewed-by: Patrick

[PATCH v3 17/22] bootm: Create a function to run through the bootm states

2023-12-15 Thread Simon Glass
In quite a few places, the bootm command is used to handle a boot. We want these to be done without needing CONFIG_CMDLINE, so add a new bootm_run() function to handle this. Signed-off-by: Simon Glass --- Changes in v3: - Enable CONFIG_MEASURED_BOOT always and rely on CONFIG_MEASURED_BOOT

[PATCH v3 15/22] bootm: Rename do_bootm_states() to bootm_run_states()

2023-12-15 Thread Simon Glass
Rename the function to bootm_run_states() to better indicate ts purpose. The 'do_' prefix is used to indicate a command processor, which this is now not. Signed-off-by: Simon Glass Reviewed-by: Tom Rini --- (no changes since v2) Changes in v2: - Split do_bootm_states() rename to a separate

[PATCH v3 16/22] bootm: Tidy up boot_selected_os()

2023-12-15 Thread Simon Glass
Use struct bootm_info with this function, to avoiding needing to create a new one. Signed-off-by: Simon Glass Reviewed-by: Tom Rini --- (no changes since v1) boot/bootm.c| 6 ++ boot/bootm_os.c | 11 +++ include/bootm.h | 3 +-- 3 files changed, 6 insertions(+), 14

[PATCH v3 14/22] bootm: Drop arguments from do_bootm_states()

2023-12-15 Thread Simon Glass
Use the bootm_info struct to hold the information required by bootm. Now that none of the functions called from do_bootm_states() needs an argv[] list, change the arguments of do_bootm_states() as well. Take care to use the same value for boot_progress even though it is a little inconsistent.

[PATCH v3 12/22] booti: Avoid use of #ifdef

2023-12-15 Thread Simon Glass
Use the compiler to get the set of states, instead of the preprocessor. Signed-off-by: Simon Glass Reviewed-by: Tom Rini --- (no changes since v2) Changes in v2: - Split out booti removal of #ifdef cmd/booti.c | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-)

[PATCH v3 13/22] bootz: Avoid use of #ifdef

2023-12-15 Thread Simon Glass
Use the compiler to get the set of states, instead of the preprocessor. Signed-off-by: Simon Glass Reviewed-by: Tom Rini --- (no changes since v2) Changes in v2: - Split out bootz removal of #ifdef cmd/bootz.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff

[PATCH v3 11/22] bootm: Move do_bootm_states() comment to header file

2023-12-15 Thread Simon Glass
This is an exported function, so move the function comment to the bootm.h header file. Signed-off-by: Simon Glass Reviewed-by: Mattijs Korpershoek Reviewed-by: Tom Rini --- (no changes since v2) Changes in v2: - Split out patch to move do_bootm_states() comment to header boot/bootm.c|

[PATCH v3 09/22] bootm: Adjust arguments of boot_os_fn

2023-12-15 Thread Simon Glass
Adjust boot_os_fn to use struct bootm_info instead of the separate argc, argv and image parameters. Update the handlers accordingly. Few of the functions make use of the arguments, so this improves code size slightly. Signed-off-by: Simon Glass Reviewed-by: Tom Rini --- (no changes since v2)

[PATCH v3 08/22] bootm: Create a struct for argument information

2023-12-15 Thread Simon Glass
Some OS functions require the arguments to the 'bootm' command. This is inconvenient for two reasons. Firstly, there may not be any actual command, if CMDLINE is not enabled and programmatic boot is being used. Secondly, most functions don't require the arguments, so it is inefficient to pass

[PATCH v3 07/22] sandbox: bootm: Enable more bootm OS methods

2023-12-15 Thread Simon Glass
It is useful for sandbox to build as much code as possible. Enable support for booting various other operating systems. Add the missing cache functions. These operating systems do not actually boot on sandbox, of course. Signed-off-by: Simon Glass --- (no changes since v2) Changes in v2: -

[PATCH v3 05/22] riscv: Add a reset_cpu() function

2023-12-15 Thread Simon Glass
The current do_reset() is called from a command context. Add a function which can be used from anywhere, as is done on ARM. Adjust do_reset() to call it. Note that reset_cpu() is normally provided by SYSRESET so make this declaration conditional on that being disabled. Signed-off-by: Simon Glass

[PATCH v3 06/22] bootm: Adjust how the board is reset

2023-12-15 Thread Simon Glass
Use reset_cpu() to reset the board, copying the logic from the 'reset' command. This makes more sense than directly calling the do_reset() function with the arguments passsed to the bootm command. Signed-off-by: Simon Glass Reviewed-by: Tom Rini Reviewed-by: Mattijs Korpershoek --- (no

[PATCH v3 04/22] nios2: Add a reset_cpu() function

2023-12-15 Thread Simon Glass
The current do_reset() is called from a command context. Add a function which can be used from anywhere, as is done on ARM. Signed-off-by: Simon Glass --- (no changes since v1) arch/nios2/cpu/cpu.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/nios2/cpu/cpu.c

[PATCH v3 02/22] m68k: Add a reset_cpu() function

2023-12-15 Thread Simon Glass
The current do_reset() is called from a command context. Add a function which can be used from anywhere, as is done on ARM. Since there are lots of reset functions, this one actually just calls do_reset(). Future refactoring could correct this. Signed-off-by: Simon Glass Acked-by: Angelo

[PATCH v3 03/22] ppc: Add a reset_cpu() function

2023-12-15 Thread Simon Glass
The current do_reset() is called from a command context. Add a function which can be used from anywhere, as is done on ARM. This is only needed if CONFIG_SYSRESET is disabled. Since there are lots of reset functions, this one actually just calls do_reset(). Future refactoring could correct this.

[PATCH v3 01/22] mips: Add a reset_cpu() function

2023-12-15 Thread Simon Glass
The current do_reset() is called from a command context. Add a function which can be used from anywhere, as is done on ARM. Signed-off-by: Simon Glass --- (no changes since v1) arch/mips/cpu/cpu.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/mips/cpu/cpu.c

[PATCH] boot: Support decompressing non-kernel OS images

2023-12-15 Thread Simon Glass
Sometimes the kernel is built as an EFI application rather than a binary. We still want to support compression for this case. For arm64 the entry point is set later in the bootm_load_os() function, since these images are typically relocated due to the 2MB-alignment requirement of arm64 images.

[PATCH 1/1] binman: used-before-assignment in ftest.py

2023-12-15 Thread Heinrich Schuchardt
Pytest 7.4.3 complains if a variable is used in a finally clause without having been initialized before the try clause. Signed-off-by: Heinrich Schuchardt --- tools/binman/ftest.py | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/tools/binman/ftest.py

Re: [PATCH v2] imx: imx8mp: Add support for Polyhex Debix Model A SBC

2023-12-15 Thread Gilles Talis
Hi Milan, Thanks for testing the patch! Glad that you could get it to work! Hi Fabio, Le mer. 13 déc. 2023 à 12:22, Fabio Estevam a écrit : > On Thu, Dec 7, 2023 at 2:15 PM Milan Zamazal wrote: > > > > Peng Fan writes: > > > > > On 5/24/2023 3:21 AM, Gilles Talis wrote: > > >> Add support for

Re: [PATCH] board: ti: k3: Remove need for CFG_SYS_SDRAM_BASE

2023-12-15 Thread Tom Rini
On Thu, Nov 30, 2023 at 08:49:11AM -0600, Andrew Davis wrote: > The base address of extended DDR does not change across the K3 family. > Setting this per SoC is not needed. Remove this definition to help > remove the last bits from K3 include/configs/*.h files. > > Signed-off-by: Andrew Davis

Re: [PATCH 4/4] board: ti: am62x/am62ax: Update virtual interrupt allocations in board config

2023-12-15 Thread Tom Rini
On Tue, Nov 28, 2023 at 01:40:24PM -0600, Vishal Mahaveer wrote: > Updates as a result of TIFS core now reserving a virtual interrupt > for enabling interrupts between DM to TIFS core. Because of this > change other virtual interrupt counts decrease by one. > > Signed-off-by: Vishal Mahaveer

Re: [PATCH 3/4] board: ti: am62x/am62ax: Update MCU GPIO interrupt allocation in board config

2023-12-15 Thread Tom Rini
On Tue, Nov 28, 2023 at 01:40:23PM -0600, Vishal Mahaveer wrote: > Share the MCU GPIO interrupts between A53 core and DM R5 core. Allocating > 2 instances each to A53 and DM R5. > > Signed-off-by: Vishal Mahaveer Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP

Re: [PATCH 2/4] board: ti: am62ax: Add C7x resource allocation entries to board config

2023-12-15 Thread Tom Rini
On Tue, Nov 28, 2023 at 01:40:22PM -0600, Vishal Mahaveer wrote: > Update am62ax rm-cfg with allocation entries for C7x core. Following > updates are added for C7x: > - Share split BCDMA tx and rx channels between DM R5 and C7x > - Share rings for split BCDMA tx and rx channels between DM R5 and

Re: [PATCH 1/4] board: ti: am62x/am62ax: Formatting updates to board config files

2023-12-15 Thread Tom Rini
On Tue, Nov 28, 2023 at 01:40:21PM -0600, Vishal Mahaveer wrote: > Minor formatting updates to the rm board configuration file for > am62x and am62ax boards. > > Signed-off-by: Vishal Mahaveer Applied to u-boot/next, thanks! -- Tom signature.asc Description: PGP signature

Re: [PATCH v2 4/4] arm: mach-k3: Merge initial memory maps

2023-12-15 Thread Tom Rini
On Tue, Nov 28, 2023 at 11:05:28AM -0600, Andrew Davis wrote: > The Device vs Normal memory map is the same for all K3 SoCs. Merge > the SoC specific maps into one. > > Signed-off-by: Andrew Davis > Reviewed-by: Nishanth Menon > Tested-by: Nishanth Menon Applied to u-boot/next, thanks! --

Re: [PATCH v2 3/4] arm: mach-k3: Remove non-cached memory map areas

2023-12-15 Thread Tom Rini
On Tue, Nov 28, 2023 at 11:05:27AM -0600, Andrew Davis wrote: > All normal memory areas should be mapped as such. > > We added these un-cached holes in our memory map to hack around the > remoteproc driver missing the proper cache maintenance operations. > > The problem is having these

Re: [PATCH v2 2/4] arm: mach-k3: Do not map ATF and OPTEE regions in MMU

2023-12-15 Thread Tom Rini
On Tue, Nov 28, 2023 at 11:05:26AM -0600, Andrew Davis wrote: > ATF and OPTEE regions may be firewalled from non-secure entities. To > prevent access to this area we leave a hole there in the MMU map. This > is the same idea as [0] but we complete that patch by adding the same > for AM65, J721e,

Re: [PATCH v2 1/4] arm: mach-k3: Let the compiler size the mem_map lists

2023-12-15 Thread Tom Rini
On Tue, Nov 28, 2023 at 11:05:25AM -0600, Andrew Davis wrote: > NR_MMU_REGIONS is a copy/paste from another platform that extends > this list later. We do not do that, so let the list be the size > of the initializer list. > > Signed-off-by: Andrew Davis > Reviewed-by: Nishanth Menon >

Re: [PATCH v2] arm: mach-k3: Move K3 common schema.yaml out of board directory

2023-12-15 Thread Tom Rini
On Wed, Nov 22, 2023 at 03:30:05PM -0600, Andrew Davis wrote: > This file is common for all K3, move it out of board/ directory and > into mach-k3. As we need to change the path in k3-binman.dtsi let's > take this opportunity to switch to absolute paths which makes adding > non-TI boards (like

[GIT PULL] clock changes for u-boot/master

2023-12-15 Thread Sean Anderson
The following changes since commit 3ac22891cfc0dc6d8eec25d2b0fbdd2eb8f3d3ed: Merge tag 'u-boot-imx-20231214' of https://gitlab.denx.de/u-boot/custodians/u-boot-imx (2023-12-15 08:22:31 -0500) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-clk.git

Re: (subset) [PATCH v3 2/2] test: dm: clk_ccf: test ccf_clk_ops

2023-12-15 Thread Sean Anderson
On Sat, 16 Dec 2023 02:28:52 +0800, Yang Xiwen wrote: > Assign ccf_clk_ops to .ops of clk_ccf driver so that it can act as an > clk provider. Also add "#clock-cells=<1>" to its device tree node. > > Add "i2c_root" to clk_test in the device tree and driver for testing. > > Get "i2c_root" clock in

Re: [PATCH] test: dm: clk_ccf: fix building error

2023-12-15 Thread Sean Anderson
On Sat, 16 Dec 2023 04:21:11 +0800, Yang Xiwen wrote: > Fix unused variable error produced by building tests > > Applied, thanks! [1/1] test: dm: clk_ccf: fix building error https://source.denx.de/u-boot/custodians/u-boot-clk/-/commit/97d65b32d76c Best regards, -- Sean Anderson

[GIT PULL] clock changes for u-boot/next

2023-12-15 Thread Sean Anderson
The following changes since commit fa3f19aa56c519d6345cc774187b7a8fdc053d71: Merge tag 'xilinx-for-v2024.04-rc1' of https://source.denx.de/u-boot/custodians/u-boot-microblaze into next (2023-12-14 13:27:11 -0500) are available in the Git repository at:

Re: [PATCH v7 5/8] clk: Add dump operation to clk_ops

2023-12-15 Thread Sean Anderson
On 11/9/23 05:55, Igor Prusov wrote: This adds dump function to struct clk_ops which should replace soc_clk_dump. It allows clock drivers to provide custom dump implementation without overriding generic CCF dump function. Reviewed-by: Patrice Chotard Tested-by: Patrice Chotard Reviewed-by:

Re: [PATCH v3] clk: nuvoton: add read only feature for clk driver

2023-12-15 Thread Sean Anderson
On Tue, 14 Nov 2023 17:00:04 +0800, Jim Liu wrote: > Add a flag to set ahb/apb/fiu/spi clock divider as read-only > The spi clock setting is related to booting flash, it is setup by early > bootloader. > It just protects the clock source and can't modify it in uboot. > > Applied, thanks! [1/1]

Re: [PATCH v7 0/8] clk: Switch from soc_clk_dump to clk_ops function

2023-12-15 Thread Sean Anderson
On Thu, 9 Nov 2023 13:55:08 +0300, Igor Prusov wrote: > Currently clock providers may override default implementation of > soc_clk_dump function to replace clk dump command output. This causes > confusing behaviour when u-boot is built with one of such drivers > enabled but still has clocks

Re: [PATCH v2] board: rockchip: Add the Turing RK1 SoM

2023-12-15 Thread Sam Edwards
Hi Joshua, I just updated my own modules to this version of the patch and all continues to be well. On 12/14/23 16:46, Joshua Riek wrote: Signed-off-by: Joshua Riek Cc: Sam Edwards Tested-by: Sam Edwards Thanks for the continued efforts, my friend! Happy Friday, Sam

Re: [PATCH v2 0/6] board: siemens: clean up subfolders

2023-12-15 Thread Tom Rini
On Thu, Nov 30, 2023 at 01:23:18PM +0100, Enrico Leto wrote: > This serie depends on the serie: > [PATCH 0/6] siemens,am335x: clean up the draco board family > > The common folder was initialially created for the common parts of > the products based on draco-am355x board family. We

Re: [PATCH] test: dm: clk_ccf: fix building error

2023-12-15 Thread Sean Anderson
On 12/15/23 15:21, Yang Xiwen via B4 Relay wrote: From: Yang Xiwen Fix unused variable error produced by building tests Fixes: d3061824 (test: dm: clk_ccf: test ccf_clk_ops) Signed-off-by: Yang Xiwen --- it's detected by u-boot gitlab CI. --- test/dm/clk_ccf.c | 3 ++- 1 file changed, 2

[PATCH] test: dm: clk_ccf: fix building error

2023-12-15 Thread Yang Xiwen via B4 Relay
From: Yang Xiwen Fix unused variable error produced by building tests Fixes: d3061824 (test: dm: clk_ccf: test ccf_clk_ops) Signed-off-by: Yang Xiwen --- it's detected by u-boot gitlab CI. --- test/dm/clk_ccf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v1 1/1] clk: clk-gpio: add actual gated clock

2023-12-15 Thread Sean Anderson
On 12/15/23 15:00, Svyatoslav Ryhel wrote: пт, 15 груд. 2023 р. о 20:45 Sean Anderson пише: On 12/15/23 13:26, Svyatoslav Ryhel wrote: пт, 15 груд. 2023 р. о 19:25 Sean Anderson пише: On 11/17/23 02:52, Svyatoslav Ryhel wrote: Existing gpio-gate-clock driver acts like a simple GPIO

Re: [PULL] Pull request for u-boot next / v2024.04 = u-boot-stm32-20231215

2023-12-15 Thread Tom Rini
On Fri, Dec 15, 2023 at 05:30:42PM +0100, Patrice CHOTARD wrote: > Hi Tom > > Please pull the STM32 related patches for u-boot/next, v2024.04: > u-boot-stm32-20231215 > > CI status: > https://source.denx.de/u-boot/custodians/u-boot-stm/-/pipelines/18947 > > The fol

Re: [PATCH v1 1/1] clk: clk-gpio: add actual gated clock

2023-12-15 Thread Svyatoslav Ryhel
пт, 15 груд. 2023 р. о 20:45 Sean Anderson пише: > > On 12/15/23 13:26, Svyatoslav Ryhel wrote: > > пт, 15 груд. 2023 р. о 19:25 Sean Anderson пише: > >> > >> On 11/17/23 02:52, Svyatoslav Ryhel wrote: > >>> Existing gpio-gate-clock driver acts like a simple GPIO switch without any > >>> effect

Re: [RFC PATCH] mxs: Don't enable 4P2 reg if mx28 is powered only from DCDC_BATT without 5V

2023-12-15 Thread Fabio Estevam
On Fri, Dec 15, 2023 at 1:20 PM Fabio Estevam wrote: > Ok, what about the patch below? > > https://patchwork.ozlabs.org/project/uboot/patch/20230703205700.9120-1-c...@londelec.com/ > > Is this still needed? I looked in the i.MX28 Reference Manual, and the one above looks a correct fix. I will

Re: [PATCH 3/3] cmd: acpi: check HW reduced flag in acpi list

2023-12-15 Thread Heinrich Schuchardt
On 12/15/23 18:46, Andy Shevchenko wrote: On Fri, Dec 15, 2023 at 05:40:16PM +0100, Heinrich Schuchardt wrote: On non x86 platforms the hardware reduce flag must be set in the FADT table. Write an error message if the flag is missing. ... + if (!IS_ENABLED(CONFIG_X86) && +

Re: [PATCH 0/8] An effort to bring DT bindings compliance within U-boot

2023-12-15 Thread Tom Rini
On Fri, Dec 15, 2023 at 02:45:11PM +, Conor Dooley wrote: > On Fri, Dec 15, 2023 at 08:37:43AM -0500, Tom Rini wrote: > > On Fri, Dec 15, 2023 at 08:50:51AM +0100, Krzysztof Kozlowski wrote: > > > On 14/12/2023 20:48, Rob Herring wrote: > > > >> > > > >> I think some of the important questions

Re: [PATCH] arm: dts: imx8mm_evk: Fix PMIC definition

2023-12-15 Thread Fabio Estevam
Hi Alexander, On Tue, Sep 26, 2023 at 3:55 AM Alexander Koch wrote: > > Newer revisions of the i.MX8MM EVK are equipped with a different PMIC than > the initial ones (PCA9540 instead of BD71847), which has already been > reflected in 4c07a21e5. This commit hash does not exist: $ git show

Re: [PATCH 2/2] ARM: dts: imx8mm-venice: prepare for dek blob encapsulation

2023-12-15 Thread Adam Ford
On Fri, Dec 15, 2023 at 12:41 PM Fabio Estevam wrote: > > Hi Tim, > > On Fri, Dec 15, 2023 at 3:34 PM Tim Harvey wrote: > > > Fabio, > > > > The commit log details are not valid for upstream. I was basing this > > off of 8d060e4a66d6884341fbb3d8ab1d837a3f173d47 which made it upstream > > with

Re: [PATCH 1/3] acpi: fix FADT table

2023-12-15 Thread Heinrich Schuchardt
On 12/15/23 18:48, Simon Glass wrote: Hi Heinrich, On Fri, 15 Dec 2023 at 09:40, Heinrich Schuchardt wrote: Fields X_FIRMWAE_CTRL and X_DSDT must be 64bit wide. Convert pointers to to uintptr_t to fill these. If field X_FIRMWARE_CTRL is filled, field FIRMWARE must be ignored. If field

Re: [PATCH v3 2/2] test: dm: clk_ccf: test ccf_clk_ops

2023-12-15 Thread Sean Anderson
On 12/15/23 13:28, Yang Xiwen via B4 Relay wrote: From: Yang Xiwen Assign ccf_clk_ops to .ops of clk_ccf driver so that it can act as an clk provider. Also add "#clock-cells=<1>" to its device tree node. Add "i2c_root" to clk_test in the device tree and driver for testing. Get "i2c_root"

Re: [PATCH v1 1/1] clk: clk-gpio: add actual gated clock

2023-12-15 Thread Sean Anderson
On 12/15/23 13:26, Svyatoslav Ryhel wrote: пт, 15 груд. 2023 р. о 19:25 Sean Anderson пише: On 11/17/23 02:52, Svyatoslav Ryhel wrote: Existing gpio-gate-clock driver acts like a simple GPIO switch without any effect on gated clock. Add actual clock actions into enable/disable ops and

Re: [PATCH v2 1/4] acpi: fix FADT table

2023-12-15 Thread Andy Shevchenko
On Fri, Dec 15, 2023 at 07:26:55PM +0100, Heinrich Schuchardt wrote: > Fields X_FIRMWAE_CTRL and X_DSDT must be 64bit wide. Convert pointers to > to uintptr_t to fill these. > > If field X_FIRMWARE_CTRL is filled, field FIRMWARE must be ignored. If > field X_DSDT is filled, field DSDT must be

Re: [PATCH 2/2] ARM: dts: imx8mm-venice: prepare for dek blob encapsulation

2023-12-15 Thread Fabio Estevam
Hi Tim, On Fri, Dec 15, 2023 at 3:34 PM Tim Harvey wrote: > Fabio, > > The commit log details are not valid for upstream. I was basing this > off of 8d060e4a66d6884341fbb3d8ab1d837a3f173d47 which made it upstream > with the same message. > > I can submit a v2 if necessary. Yes, please submit a

Re: [PATCH v6 06/17] arm: mach-k3: j784s4: Add clk and power support

2023-12-15 Thread Bryan Brattlof
On December 6, 2023 thus sayeth Apurva Nandan: > Add clk and device data which can be used by respective drivers > to configure clocks and PSC. > > Signed-off-by: Hari Nagalla > Signed-off-by: Apurva Nandan > --- > arch/arm/mach-k3/r5/j784s4/Makefile| 7 + >

Re: [PATCH 0/2] Fix NULL dereference in clk_composite_set_rate()

2023-12-15 Thread Sean Anderson
On Wed, 6 Dec 2023 02:23:32 +0300, Igor Prusov wrote: > On sandbox it's possible to trigger NULL dereference when setting rate > of a composite clock. It happens because sandbox composite divider does > not implement set_rate() operation. This series adds NULL check and a > test cases for

Re: [PATCH v2] clk: check parent_name in clk_register to avoid confusing log_error() output

2023-12-15 Thread Sean Anderson
On Sat, 11 Nov 2023 03:19:52 +0800, Yang Xiwen wrote: > For some gate clocks and fixed clocks without a parent, calling > clk_register will print an useless error message indicating that parent > is missing. Fix that by gaurding log_xxx() with an if-statement. > > Applied, thanks! [1/1] clk:

Re: (subset) [PATCH v2 2/4] clk: get correct ops for clk_enable() and clk_disable()

2023-12-15 Thread Sean Anderson
On Sun, 19 Nov 2023 06:10:06 +0800, Yang Xiwen wrote: > assign clk_dev_ops(clkp->dev) to ops to ensure correct clk operations > are called on clocks. > > This fixes the incorrect enable_count issue as described in [1]. > > [1]: >

Re: [PATCH 2/2] ARM: dts: imx8mm-venice: prepare for dek blob encapsulation

2023-12-15 Thread Tim Harvey
On Thu, Dec 14, 2023 at 8:30 AM Fabio Estevam wrote: > > Hi Tim, > > On Thu, Dec 14, 2023 at 1:25 PM Tim Harvey wrote: > > > > Prepare for DEK blob encapsulation support through "dek_blob" command. > > On ARMv8, u-boot runs in non-secure, thus cannot encapsulate a DEK blob > > for encrypted

Re: [PATCH v3 0/4] bootm: Handle compressed arm64 images with bootm

2023-12-15 Thread Tom Rini
On Sun, 19 Nov 2023 07:43:30 -0700, Simon Glass wrote: > This little series corrects a problem I noticed with arm64 images, > where the kernel is not recognised if compression is used: > >U-Boot> tftp image.fit >Using ethernet@7d58 device >TFTP from server 192.168.4.7; our IP

[PATCH v3 0/2] clk: ccf: fix enable_count mismatch

2023-12-15 Thread Yang Xiwen via B4 Relay
As described in [1], enable_count is incremented by 2 when ccf_clk_enable() is called. This series of patch fixed this issue and added a testcase for that. [1]: https://lore.kernel.org/all/sezpr06mb695927a6deeef8489a06897396...@sezpr06mb6959.apcprd06.prod.outlook.com/ Signed-off-by: Yang Xiwen

[PATCH v3 1/2] clk: get correct ops for clk_enable() and clk_disable()

2023-12-15 Thread Yang Xiwen via B4 Relay
From: Yang Xiwen assign clk_dev_ops(clkp->dev) to ops to ensure correct clk operations are called on clocks. This fixes the incorrect enable_count issue as described in [1]. [1]: https://lore.kernel.org/all/sezpr06mb695927a6deeef8489a06897396...@sezpr06mb6959.apcprd06.prod.outlook.com/

[PATCH v3 2/2] test: dm: clk_ccf: test ccf_clk_ops

2023-12-15 Thread Yang Xiwen via B4 Relay
From: Yang Xiwen Assign ccf_clk_ops to .ops of clk_ccf driver so that it can act as an clk provider. Also add "#clock-cells=<1>" to its device tree node. Add "i2c_root" to clk_test in the device tree and driver for testing. Get "i2c_root" clock in CCF unit tests and add tests for it.

[PATCH v2 4/4] aci: fix acpi_find_table() for DSDT and FACS

2023-12-15 Thread Heinrich Schuchardt
Use X_DSDT and X_FIRMWARE_CTRL if available. Signed-off-by: Heinrich Schuchardt --- v2: new patch --- lib/acpi/acpi.c | 29 - 1 file changed, 24 insertions(+), 5 deletions(-) diff --git a/lib/acpi/acpi.c b/lib/acpi/acpi.c index f21e509461..f80b2176e1 100644

Re: [PATCH v1 1/1] clk: clk-gpio: add actual gated clock

2023-12-15 Thread Svyatoslav Ryhel
пт, 15 груд. 2023 р. о 19:25 Sean Anderson пише: > > On 11/17/23 02:52, Svyatoslav Ryhel wrote: > > Existing gpio-gate-clock driver acts like a simple GPIO switch without any > > effect on gated clock. Add actual clock actions into enable/disable ops and > > implement get_rate op by passing gated

[PATCH v2 3/4] cmd: acpi: check HW reduced flag in acpi list

2023-12-15 Thread Heinrich Schuchardt
On non x86 platforms the hardware reduce flag must be set in the FADT table. Write an error message if the flag is missing. Signed-off-by: Heinrich Schuchardt --- v2: no change --- cmd/acpi.c | 4 1 file changed, 4 insertions(+) diff --git a/cmd/acpi.c b/cmd/acpi.c index

[PATCH v2 2/4] cmd: acpi: fix listing DSDT and FACS

2023-12-15 Thread Heinrich Schuchardt
If field X_FIRMWARE_CTRL is filled, field FIRMWARE must be ignored. If field X_DSDT is filled, field DSDT must be ignored. Signed-off-by: Heinrich Schuchardt --- v2: check FADT table revision --- cmd/acpi.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

[PATCH v2 1/4] acpi: fix FADT table

2023-12-15 Thread Heinrich Schuchardt
Fields X_FIRMWAE_CTRL and X_DSDT must be 64bit wide. Convert pointers to to uintptr_t to fill these. If field X_FIRMWARE_CTRL is filled, field FIRMWARE must be ignored. If field X_DSDT is filled, field DSDT must be ignored. We should not fill unused fields. Signed-off-by: Heinrich Schuchardt

[PATCH v2 0/4] cmd: acpi: correct handling of DSDT and FACS

2023-12-15 Thread Heinrich Schuchardt
Fields X_FIRMWARE and X_DSDT in the FADT table must be 64bit. Fix the definition in our include. The 64bit fields X_FIRMWARE and X_DSDT take precedence over the respective 32bit fields. Consider this in the 'acpi list' and 'acpi dump' commands. The fields only exist for FADT table revision 3 and

Re: [PATCH] rock-pi-4: Enable SPI flash

2023-12-15 Thread Dragan Simic
On 2023-12-15 15:00, Stefan Nagy wrote: The ROCK Pi 4A/B/C boards come with a 32 Mbit SPI NOR flash chip (XTX Technology Limited XT25F32). Sync the devicetrees from Linux to enable spi1 and add a device node for the NOR flash chip. In the board's defconfig files enable the Rockchip SPI driver,

Re: whitelist commands

2023-12-15 Thread Simon Glass
Hi Thomas, On Fri, 15 Dec 2023 at 02:12, Thomas McCann wrote: > > Hello Simon, > > Firstly my apologies I very new to U-Boot and just trying to make sense of it > all. My chip currently does not boot because the commands "bootelf" commend > is not whitelisted. > My question was two-fold

Re: [PATCH v2] clk: meson: add Hardware Clock measure driver

2023-12-15 Thread Sean Anderson
On 12/12/23 09:12, Neil Armstrong wrote: Amlogic SoCs embeds an hardware clock measure block, port it from Linux and implement it as a UCLK_CLK with only the dump op and fail-only xlate. Please include a short blurb describing the hardware like you did for Linux commit 2b45ebef39a2 ("soc:

Re: [PATCH v4 1/8] binman: ti-secure: Add support for firewalling entities

2023-12-15 Thread Simon Glass
Hi Jon, On Thu, 14 Dec 2023 at 14:49, Jon Cormier wrote: > > Hi Manorit, > > This commit added a possibly unintentional dependency on python 3.9+. > > I ran into this while trying to build the soon-to-be-released 09.01.00.008. > > Build failure on ubuntu 20.04 which uses python 3.8: > "binman:

Re: [PATCH 1/1] buildman: type cotaining

2023-12-15 Thread Simon Glass
On Fri, 15 Dec 2023 at 02:42, Heinrich Schuchardt wrote: > > %s/cotaining/containing/ > > Signed-off-by: Heinrich Schuchardt > --- > tools/buildman/boards.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/buildman/boards.py b/tools/buildman/boards.py > index

Re: [PATCH 1/3] acpi: fix FADT table

2023-12-15 Thread Simon Glass
Hi Heinrich, On Fri, 15 Dec 2023 at 09:40, Heinrich Schuchardt wrote: > > Fields X_FIRMWAE_CTRL and X_DSDT must be 64bit wide. Convert pointers to > to uintptr_t to fill these. > > If field X_FIRMWARE_CTRL is filled, field FIRMWARE must be ignored. If > field X_DSDT is filled, field DSDT must be

Re: [PATCH 3/3] cmd: acpi: check HW reduced flag in acpi list

2023-12-15 Thread Andy Shevchenko
On Fri, Dec 15, 2023 at 05:40:16PM +0100, Heinrich Schuchardt wrote: > On non x86 platforms the hardware reduce flag must be set in the FADT > table. Write an error message if the flag is missing. ... > + if (!IS_ENABLED(CONFIG_X86) && > + !(fadt->flags & ACPI_FADT_HW_REDUCED_ACPI))

Re: [PATCH 1/3] acpi: fix FADT table

2023-12-15 Thread Andy Shevchenko
On Fri, Dec 15, 2023 at 05:40:14PM +0100, Heinrich Schuchardt wrote: > Fields X_FIRMWAE_CTRL and X_DSDT must be 64bit wide. Convert pointers to > to uintptr_t to fill these. > > If field X_FIRMWARE_CTRL is filled, field FIRMWARE must be ignored. If > field X_DSDT is filled, field DSDT must be

Re: [PATCH v6 06/17] arm: mach-k3: j784s4: Add clk and power support

2023-12-15 Thread Sean Anderson
On 12/6/23 07:37, Apurva Nandan wrote: Add clk and device data which can be used by respective drivers to configure clocks and PSC. Signed-off-by: Hari Nagalla Signed-off-by: Apurva Nandan --- arch/arm/mach-k3/r5/j784s4/Makefile| 7 + arch/arm/mach-k3/r5/j784s4/clk-data.c | 428

Re: [PATCH v1 1/1] clk: clk-gpio: add actual gated clock

2023-12-15 Thread Sean Anderson
On 11/17/23 02:52, Svyatoslav Ryhel wrote: Existing gpio-gate-clock driver acts like a simple GPIO switch without any effect on gated clock. Add actual clock actions into enable/disable ops and implement get_rate op by passing gated clock if it is enabled. Signed-off-by: Svyatoslav Ryhel ---

Re: [PATCH v2 4/4] test: dm: clk_ccf: get "i2c_root" clock from _ccf

2023-12-15 Thread Sean Anderson
On 11/18/23 17:10, Yang Xiwen via B4 Relay wrote: From: Yang Xiwen get i2c_root clock from device tree. In this way we get an CCF clock and also test ccf_clk_ops. Signed-off-by: Yang Xiwen --- test/dm/clk_ccf.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff

Re: [PATCH v2 2/4] clk: get correct ops for clk_enable() and clk_disable()

2023-12-15 Thread Sean Anderson
On 11/18/23 17:10, Yang Xiwen via B4 Relay wrote: From: Yang Xiwen assign clk_dev_ops(clkp->dev) to ops to ensure correct clk operations are called on clocks. This fixes the incorrect enable_count issue as described in [1]. [1]:

Re: [PATCH 2/2] dm: test: clk: Add test for ccf clk_set_rate()

2023-12-15 Thread Sean Anderson
On 12/5/23 18:23, Igor Prusov wrote: Add a simple test case which sets clock rate to its current value. Signed-off-by: Igor Prusov --- test/dm/clk_ccf.c | 9 + 1 file changed, 9 insertions(+) diff --git a/test/dm/clk_ccf.c b/test/dm/clk_ccf.c index e4ebb93cda..3b23982541 100644

Re: [PATCH 1/2] clk: Check that composite clock's div has set_rate()

2023-12-15 Thread Sean Anderson
On 12/5/23 18:23, Igor Prusov wrote: It's possible for composite clocks to have a divider that does not implement set_rate() operation. For example, sandbox_clk_composite() registers composite clock with a divider that only has get_rate(). Currently clk_composite_set_rate() only checks thate

[PATCH v2] doc: Replace examples of MD5 and SHA1 with SHA256

2023-12-15 Thread Sean Anderson
Both SHA1 and (especially) MD5 are no longer as safe as they once were for cryptographic use. Replace examples that use them with examples using SHA256 instead. This will provide more-secure defaults for users who use documentation examples as a base for their own use. This is not too necessary

Re: [PATCH] doc: Replace examples of MD5 and SHA1 with SHA256

2023-12-15 Thread Sean Anderson
On 12/3/23 11:45, Peter Robinson wrote: On Sat, Dec 2, 2023 at 7:33 PM Sean Anderson wrote: Both SHA1 and (especially) MD5 are no longer as safe as they once were for cryptographic use. Replaces examples which use them with examples using SHA256 instead. This will provide more-secure defaults

[PATCH 3/3] cmd: acpi: check HW reduced flag in acpi list

2023-12-15 Thread Heinrich Schuchardt
On non x86 platforms the hardware reduce flag must be set in the FADT table. Write an error message if the flag is missing. Signed-off-by: Heinrich Schuchardt --- cmd/acpi.c | 4 1 file changed, 4 insertions(+) diff --git a/cmd/acpi.c b/cmd/acpi.c index 24910c150b..2e9a333ffa 100644 ---

[PATCH 2/3] cmd: acpi: fix listing DSDT and FACS

2023-12-15 Thread Heinrich Schuchardt
If field X_FIRMWARE_CTRL is filled, field FIRMWARE must be ignored. If field X_DSDT is filled, field DSDT must be ignored. Signed-off-by: Heinrich Schuchardt --- cmd/acpi.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/cmd/acpi.c b/cmd/acpi.c index

[PATCH 1/3] acpi: fix FADT table

2023-12-15 Thread Heinrich Schuchardt
Fields X_FIRMWAE_CTRL and X_DSDT must be 64bit wide. Convert pointers to to uintptr_t to fill these. If field X_FIRMWARE_CTRL is filled, field FIRMWARE must be ignored. If field X_DSDT is filled, field DSDT must be ignored. We should not fill unused fields. Signed-off-by: Heinrich Schuchardt

[PATCH 0/3] cmd: acpi: fix list_fadt()

2023-12-15 Thread Heinrich Schuchardt
Fields X_FIRMWARE and X_DSDT in the FADT table must be 64bit. Fix the definition in our include. The 64bit fields X_FIRMWARE and X_DSDT take precedence over the respective 32bit fields. Don't fill unused fields FIRMWAE and DSDT. Write an error if the hardware reduce flag is not set for non-x86

[PULL] Pull request for u-boot next / v2024.04 = u-boot-stm32-20231215

2023-12-15 Thread Patrice CHOTARD
Hi Tom Please pull the STM32 related patches for u-boot/next, v2024.04: u-boot-stm32-20231215 CI status: https://source.denx.de/u-boot/custodians/u-boot-stm/-/pipelines/18947 The following changes since commit fa3f19aa56c519d6345cc774187b7a8fdc053d71: Merge tag 'xilinx-for-v2024.04-rc1

Re: [PATCH v2] clk: fix clk_get_rate() always return ulong

2023-12-15 Thread Sean Anderson
On 12/15/23 09:09, Julien Masson wrote: When we call clk_get_rate(), we expect to get clock rate value as ulong. In that case we should not use log_ret() macro since it use internally an int. Otherwise we may return an invalid/truncated clock rate value. Fixes: 5c5992cb90c ("clk: Add

  1   2   >