Re: [PATCH v2 1/1] clk: clk-gpio: add actual gated clock

2023-12-16 Thread Sean Anderson
On 12/16/23 19:19, Marek Vasut wrote: On 12/16/23 17:56, Sean Anderson wrote: On 12/16/23 11:52, Marek Vasut wrote: On 12/16/23 16:37, Sean Anderson wrote: On 12/16/23 03:48, Svyatoslav Ryhel wrote: Existing gpio-gate-clock driver acts like a simple GPIO switch without any effect on gated

[PATCH v2 RESEND] pci: Enable dm_pci_map_bar() for 64-bit BARs

2023-12-16 Thread Moritz Fischer
Allow dm_pci_map_bar() usage on systems with CONFIG_SYS_PCI_64BIT. Reviewed-by: Philip Oberfichtner Reviewed-by: Simon Glass Signed-off-by: Moritz Fischer --- drivers/pci/pci-uclass.c | 11 +++ include/pci.h| 4 ++-- 2 files changed, 13 insertions(+), 2 deletions(-) diff

[PATCH v2] arm: Add OVERLAY command to BSS section on ARM64

2023-12-16 Thread Marek Vasut
Avoid allocating and loading the BSS section. $ aarch64-linux-gnu-objdump -Sh u-boot Before: 10 .bss_start 000f21d8 000f21d8 001021d8 2**0 CONTENTS, ALLOC, LOAD, DATA 11 .bss 68f8 000f2200 000f2200 001021d8

Re: [PATCH v2 1/1] clk: clk-gpio: add actual gated clock

2023-12-16 Thread Marek Vasut
On 12/16/23 17:56, Sean Anderson wrote: On 12/16/23 11:52, Marek Vasut wrote: On 12/16/23 16:37, Sean Anderson wrote: On 12/16/23 03:48, Svyatoslav Ryhel wrote: Existing gpio-gate-clock driver acts like a simple GPIO switch without any effect on gated clock. Add actual clock actions into

Re: [PATCH 13/17] video: rockchip: Add rk3328 vop support

2023-12-16 Thread Johan Jonker
Hi Jagan, In  your patch U-boot users must add a new file for each new Rockchip SoC. With the VOP2 introduction the VOP1 structures and functions are frozen/stabilized. My proposal would be to use a file simular to Linux rockchip_vop_reg.c and port it to U-boot as is done in the manufacturer

Re: [PATCH v2 3/3] efi: Avoid using dm_scan_other()

2023-12-16 Thread Heinrich Schuchardt
Am 16. Dezember 2023 23:14:20 MEZ schrieb Tom Rini : >On Sat, Dec 16, 2023 at 09:57:41PM +0100, Heinrich Schuchardt wrote: >> On 12/16/23 21:46, Simon Glass wrote: >> > Hi, >> > >> > On Tue, 21 Nov 2023 at 06:21, Tom Rini wrote: >> > > >> > > On Tue, Nov 21, 2023 at 01:18:09PM +0100,

Re: [PATCH v2 3/3] efi: Avoid using dm_scan_other()

2023-12-16 Thread Tom Rini
On Sat, Dec 16, 2023 at 09:57:41PM +0100, Heinrich Schuchardt wrote: > On 12/16/23 21:46, Simon Glass wrote: > > Hi, > > > > On Tue, 21 Nov 2023 at 06:21, Tom Rini wrote: > > > > > > On Tue, Nov 21, 2023 at 01:18:09PM +0100, Heinrich Schuchardt wrote: > > > > On 11/12/23 21:55, Simon Glass

Re: Booting fails on the sandbox

2023-12-16 Thread Heinrich Schuchardt
On 12/16/23 19:45, Simon Glass wrote: Hi Heinrich, On Sat, 16 Dec 2023 at 07:50, Heinrich Schuchardt wrote: Hello Simon, I have built sandbox_defconfig with PREBOOT='host bind 0 ../sct.img' On the image I have an ESP with file EFI/BOOT/BOOTX64.EFI. I would expect the sandbox to boot from

Re: [PATCH v2 3/3] efi: Avoid using dm_scan_other()

2023-12-16 Thread Heinrich Schuchardt
On 12/16/23 21:46, Simon Glass wrote: Hi, On Tue, 21 Nov 2023 at 06:21, Tom Rini wrote: On Tue, Nov 21, 2023 at 01:18:09PM +0100, Heinrich Schuchardt wrote: On 11/12/23 21:55, Simon Glass wrote: This function is defined by bootstd so using it precludes using that feature. Use the

Re: [PATCH v2 3/3] efi: Avoid using dm_scan_other()

2023-12-16 Thread Simon Glass
Hi, On Tue, 21 Nov 2023 at 06:21, Tom Rini wrote: > > On Tue, Nov 21, 2023 at 01:18:09PM +0100, Heinrich Schuchardt wrote: > > On 11/12/23 21:55, Simon Glass wrote: > > > This function is defined by bootstd so using it precludes using that > > > feature. Use the board_early_init_r() feature

[PATCH v2 2/2] nvme: Update scan namespace to keep trying on busy

2023-12-16 Thread Moritz Fischer
A busy controller shouldn't be game-over for all controllers, so keep trying on hitting -EBUSY. This change brings the actual behavior of the routine in line with what the descriptions says. Fixes: 982388eaa991 ("nvme: Add NVM Express driver support") Reviewed-by: Simon Glass Signed-off-by:

[PATCH v2 1/2] nvme: Fix error code and log to indicate busy

2023-12-16 Thread Moritz Fischer
Return -EBUSY if controller is found busy rather than -ENOMEM and update the error message accordingly. Fixes: 982388eaa991 ("nvme: Add NVM Express driver support") Reviewed-by: Simon Glass Signed-off-by: Moritz Fischer --- Changes from V1: - Added Simon's Reviewed-by --- drivers/nvme/nvme.c |

Re: [PATCH v6 0/5] Populate kaslr seed with RNG

2023-12-16 Thread Tom Rini
On Sat, Dec 16, 2023 at 12:09:49PM -0500, Tom Rini wrote: > On Thu, Nov 30, 2023 at 04:54:39PM -0800, Sean Edmond wrote: > > > This patch series creates a common API (fdt_fixup_kaslr_seed()) for > > populating the kaslr seed in the DTB. Existing users (kaslrseed, > > and ARMv8 sec firmware) have

Re: [PATCH v3 22/22] bootm: Create a new boot_run() function to handle booting

2023-12-16 Thread Tom Rini
On Sat, Dec 16, 2023 at 11:45:36AM -0700, Simon Glass wrote: > Hi Tom, > > On Sat, 16 Dec 2023 at 10:12, Tom Rini wrote: > > > > On Fri, Dec 15, 2023 at 08:14:26PM -0700, Simon Glass wrote: > > > Create a common function used by the three existing bootz/i/m_run() > > > functions, to reduce

[PATCH 1/3] clk: Remove rfree

2023-12-16 Thread Sean Anderson
Nothing uses this function. Remove it. Since clk_free no longer does anything, just stub it out. Signed-off-by: Sean Anderson --- arch/sandbox/include/asm/clk.h | 8 drivers/clk/clk-uclass.c | 14 -- drivers/clk/clk_sandbox.c | 12

[PATCH 2/3] treewide: Remove clk_free

2023-12-16 Thread Sean Anderson
This function is a no-op. Remove it. Signed-off-by: Sean Anderson --- arch/arm/mach-rockchip/rk3288/rk3288.c| 2 - arch/arm/mach-socfpga/clock_manager_agilex.c | 2 - arch/arm/mach-socfpga/clock_manager_arria10.c | 7 +-- arch/arm/mach-socfpga/clock_manager_n5x.c | 2 -

[PATCH 3/3] clk: Document clk_ops return codes and behavior

2023-12-16 Thread Sean Anderson
Currently, clock consumers cannot take any programmatic action based on the return code of a clock function. This is because there is no standardization, and generally no way of separating e.g. "there was a major problem setting the rate for this clock" which usually should not be recovered from,

[PATCH 0/3] clk: Remove clk_free and better document clk_ops

2023-12-16 Thread Sean Anderson
This series contains two unrelated changes. They are included together because they touch the same files and would otherwise conflict. The first change is to completely remove clk_free. This is because the op it calls (rfree) is completely unused. I believe the original intent of this op was to

Re: [PATCH v2 8/9] configs: qemu: add config fragment for ACPI

2023-12-16 Thread Heinrich Schuchardt
On 12/16/23 19:46, Simon Glass wrote: On Fri, 15 Dec 2023 at 06:33, Heinrich Schuchardt wrote: Provide a configuration fragment to enable ACPI on QEMU. Signed-off-by: Heinrich Schuchardt Acked-by: Ilias Apalodimas --- v2: no change --- MAINTAINERS | 1 +

Re: [PATCH v2 3/9] arrm: add ACPI fields to global data

2023-12-16 Thread Heinrich Schuchardt
On 12/16/23 19:46, Simon Glass wrote: Hi Heinrich, On Fri, 15 Dec 2023 at 06:32, Heinrich Schuchardt wrote: Add fields for the location of ACPI tables to the global data. Signed-off-by: Heinrich Schuchardt --- v2: new patch --- arch/arm/include/asm/global_data.h | 4 1

Re: [PATCH v3 4/4] acpi: support 64bit in acpi_find_table for DSDT and FACS

2023-12-16 Thread Heinrich Schuchardt
On 12/16/23 19:45, Simon Glass wrote: On Sat, 16 Dec 2023 at 01:12, Heinrich Schuchardt wrote: Use X_DSDT and X_FIRMWARE_CTRL if available. Signed-off-by: Heinrich Schuchardt --- lib/acpi/acpi.c | 29 - 1 file changed, 24 insertions(+), 5 deletions(-)

Re: Proposal: U-Boot memory management

2023-12-16 Thread Heinrich Schuchardt
On 12/16/23 19:01, Simon Glass wrote: Hi, This records my thoughts after a discussion with Ilias & Heinrich re memory allocation in U-Boot. 1. malloc() malloc() is used for programmatic memory allocation. It allows memory to be freed. It is not designed for very large allocations (e.g. a 10MB

Re: [PATCH v2 4/4] aci: fix acpi_find_table() for DSDT and FACS

2023-12-16 Thread Simon Glass
On Fri, 15 Dec 2023 at 11:27, Heinrich Schuchardt wrote: > > Use X_DSDT and X_FIRMWARE_CTRL if available. > > Signed-off-by: Heinrich Schuchardt > --- > v2: > new patch > --- > lib/acpi/acpi.c | 29 - > 1 file changed, 24 insertions(+), 5 deletions(-)

Re: [PATCH v2 3/4] cmd: acpi: check HW reduced flag in acpi list

2023-12-16 Thread Simon Glass
On Fri, 15 Dec 2023 at 11:27, Heinrich Schuchardt wrote: > > On non x86 platforms the hardware reduce flag must be set in the FADT > table. Write an error message if the flag is missing. > > Signed-off-by: Heinrich Schuchardt > --- > v2: > no change > --- > cmd/acpi.c | 4 > 1 file

Re: [v2 10/16] global: Rework architecture global_data.h to include

2023-12-16 Thread Simon Glass
On Thu, 14 Dec 2023 at 11:18, Tom Rini wrote: > > In most cases, the architecture global data currently makes use of > assorted linux types, but does not include to provide > them. Add instead of relying on indirect inclusion. > > Signed-off-by: Tom Rini > --- > Changes in v2: > - Update

Re: [PATCH v2 1/2] tools: kwbimage: Allow disabling build on non-mvebu platforms

2023-12-16 Thread Simon Glass
On Thu, 14 Dec 2023 at 05:11, Alexander Dahl wrote: > > Some users want to build with CONFIG_TOOLS_LIBCRYPTO disabled, which in > general is possible for at least some boards. 32-bit mvebu however > requires kwbimage for building SPL, and kwbimage has a hard dependency > to host OpenSSL. > > The

Re: [PATCH 1/1] binman: used-before-assignment in ftest.py

2023-12-16 Thread Simon Glass
On Fri, 15 Dec 2023 at 16:26, Heinrich Schuchardt wrote: > > Pytest 7.4.3 complains if a variable is used in a finally clause without > having been initialized before the try clause. > > Signed-off-by: Heinrich Schuchardt > --- > tools/binman/ftest.py | 20 +++- > 1 file

Re: [PATCH v4] arm: dts: rockpro64: Add RockPro64 smbios

2023-12-16 Thread Simon Glass
Hi Shantur, On Thu, 14 Dec 2023 at 07:14, Shantur Rathore wrote: > > Hi, > > On Wed, Dec 13, 2023 at 8:41 PM Simon Glass wrote: > > > > Hi Tom, > > > > On Wed, 13 Dec 2023 at 13:29, Tom Rini wrote: > > > > > > On Wed, Dec 13, 2023 at 12:50:06PM -0700, Simon Glass wrote: > > > > Hi Tom, > > > >

Re: [PATCH v2 9/9] arm: enable support for QEMU firmware tables

2023-12-16 Thread Simon Glass
On Fri, 15 Dec 2023 at 06:33, Heinrich Schuchardt wrote: > > Enable the QEMU firmware interface if ACPI tables are to be supported on > the QEMU platform. > > Signed-off-by: Heinrich Schuchardt > --- > v2: > new patch > --- > board/emulation/qemu-arm/Kconfig | 1 + > 1 file changed, 1

Re: [PATCH v2 8/9] configs: qemu: add config fragment for ACPI

2023-12-16 Thread Simon Glass
On Fri, 15 Dec 2023 at 06:33, Heinrich Schuchardt wrote: > > Provide a configuration fragment to enable ACPI on QEMU. > > Signed-off-by: Heinrich Schuchardt > Acked-by: Ilias Apalodimas > --- > v2: > no change > --- > MAINTAINERS | 1 + >

Re: [PATCH 1/1] boot: CONFIG_CEDIT must depend on CONFIG_EXPO

2023-12-16 Thread Simon Glass
On Sat, 16 Dec 2023 at 08:38, Heinrich Schuchardt wrote: > > Building sandbox_defconfig with > > CONFIG_CMD_CEDIT=y > CONFIG_EXPO=n > > fails with > > cmd/cedit.c:258:(.text.do_cedit_run+0x4c): > undefined reference to `expo_apply_theme > > Fix the dependencies. > > Fixes:

Re: [PATCH v3 22/22] bootm: Create a new boot_run() function to handle booting

2023-12-16 Thread Simon Glass
Hi Tom, On Sat, 16 Dec 2023 at 10:12, Tom Rini wrote: > > On Fri, Dec 15, 2023 at 08:14:26PM -0700, Simon Glass wrote: > > Create a common function used by the three existing bootz/i/m_run() > > functions, to reduce duplicated code. > > > > Signed-off-by: Simon Glass > > Suggested-by: Tom Rini

Re: [PATCH v2 3/9] arrm: add ACPI fields to global data

2023-12-16 Thread Simon Glass
Hi Heinrich, On Fri, 15 Dec 2023 at 06:32, Heinrich Schuchardt wrote: > > Add fields for the location of ACPI tables to the global data. > > Signed-off-by: Heinrich Schuchardt > --- > v2: > new patch > --- > arch/arm/include/asm/global_data.h | 4 > 1 file changed, 4 insertions(+)

Re: [PATCH] get_maintainer.pl: Add --git to look up CCed in git history

2023-12-16 Thread Simon Glass
On Sat, 16 Dec 2023 at 11:08, Marek Vasut wrote: > > Add the --git parameter, else recent contributors are left out of the CC list. > > Signed-off-by: Marek Vasut > --- > Cc: Simon Glass > Cc: Tom Rini > --- > .get_maintainer.conf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: Where is the u-boot for BeagleV-Fire?

2023-12-16 Thread Simon Glass
Hi, On Fri, 15 Dec 2023 at 06:15, Pei Jia wrote: > > > Where can I find the u-boot defconfig file for BeagleV-Fire? > > I've got an issue posted at > https://forum.beagleboard.org/t/error-illegal-operands-li-t1/36823 . You could check here, or ask the vendor?

Re: [PATCH] global: Restrict use of '#include '

2023-12-16 Thread Simon Glass
On Thu, 14 Dec 2023 at 05:16, Tom Rini wrote: > > In general terms, we -include include/linux/kconfig.h and so normal > U-Boot code does not need to also #include it. However, for code which > is shared with userspace we may need to add it so that either our full > config is available or so that

Re: [v2 13/16] efi_loader: Remove

2023-12-16 Thread Simon Glass
On Thu, 14 Dec 2023 at 11:19, Tom Rini wrote: > > We largely do not need in these files, so drop it. The only > exception here is that efi_freestanding.c needs and had > been getting that via . > > Signed-off-by: Tom Rini > --- > lib/efi_loader/dtbdump.c | 1 - >

Re: [PATCH v2 5/9] acpi: enable writing ACPI tables on QEMU

2023-12-16 Thread Simon Glass
Hi Heinrich, On Fri, 15 Dec 2023 at 06:33, Heinrich Schuchardt wrote: > > Invoke write_acpi_tables() via EVT_LAST_STAGE_INIT on QEMU except on X86. > X86 calls write_acpi_tables() in write_tables(). > > Signed-off-by: Heinrich Schuchardt > --- > v2: > new patch > --- >

Re: [PATCH 2/2 v3] smbios: Fallback to the default DT if sysinfo nodes are missing

2023-12-16 Thread Simon Glass
Hi Tom, On Thu, 14 Dec 2023 at 06:11, Tom Rini wrote: > > On Wed, Dec 13, 2023 at 08:19:11PM -0700, Simon Glass wrote: > > [snip] > > The new DT nodes / SMBIOS binding [1] allows for the correct > > information to be provided, though. > [snip] > > [1] > >

Re: [v2 11/16] lib/sha*.c: Update header list

2023-12-16 Thread Simon Glass
On Thu, 14 Dec 2023 at 11:18, Tom Rini wrote: > > Cleanup the list of headers we include here. For the tools build we only > need to exclude as that's used by the target build for the > prototype for schedule(), and we don't need to get that via > . We can also make use of our intentionally >

Re: Booting fails on the sandbox

2023-12-16 Thread Simon Glass
Hi Heinrich, On Sat, 16 Dec 2023 at 07:50, Heinrich Schuchardt wrote: > > Hello Simon, > > I have built sandbox_defconfig with PREBOOT='host bind 0 ../sct.img' > > On the image I have an ESP with file EFI/BOOT/BOOTX64.EFI. > > I would expect the sandbox to boot from the ESP. > > But when

Re: Where to find those definition for particular boards? CFG_SYS_INIT_RAM_ADDR, CFG_SYS_INIT_RAM_SIZE, GENERATED_GBL_DATA_SIZE? etc.

2023-12-16 Thread Simon Glass
Hi, On Fri, 15 Dec 2023 at 06:15, Pei Jia wrote: > > > Hi, all: > > I'm using a *BeagleV-Fire*, However, I failed to build *u-boot*, and now > traced to this step. Where to find those *macro values* specifically for > this board *BeagleV-Fire*? I assume that beaglebone.org has a U-Boot for this

Re: [PATCH] arm: Add OVERLAY command to BSS section

2023-12-16 Thread Simon Glass
On Sat, 16 Dec 2023 at 11:08, Marek Vasut wrote: > > Avoid allocating and loading the BSS section. > > $ aarch64-linux-gnu-objdump -Sh u-boot > > Before: > 10 .bss_start 000f21d8 000f21d8 001021d8 > 2**0 >CONTENTS, ALLOC, LOAD, DATA > 11

Re: [PATCH 1/1] test: build test/boot for CONFIG_UT_BOOTSTD=n

2023-12-16 Thread Simon Glass
On Sat, 16 Dec 2023 at 08:20, Heinrich Schuchardt wrote: > > Building sandbox_defconfig with > > CONFIG_UT_BOOTSTD=n > CONFIG_MEASURMENT=y > > results in an error: > > /usr/bin/ld: test/cmd_ut.o:(.data.rel.cmd_ut_sub+0x408): > undefined reference to `do_ut_measurement' > > Fixes:

Re: [v2 03/16] arm: Partial cleanup and audit usage of

2023-12-16 Thread Simon Glass
On Thu, 14 Dec 2023 at 11:17, Tom Rini wrote: > > We need to include directly when a file needs to have > something such as CFG_SYS_SDRAM_SIZE referenced as this file is not > automatically globally included and is most commonly indirectly included > via common.h. Remove most cases of arm

Re: [v2 04/16] sandbox: Audit config.h and common.h usage

2023-12-16 Thread Simon Glass
On Thu, 14 Dec 2023 at 11:17, Tom Rini wrote: > > Remove and replace common.h and config.h in sandbox when it's not needed > and add some explicit includes where needed. > > Signed-off-by: Tom Rini > --- > Changes in v2: > - Drop from arch/sandbox/cpu/state.c as it's also not > needed and

Re: [PATCH 1/1] test: CONFIG_UT_BOOTSTD must depend on CONFIG_BOOTSTD

2023-12-16 Thread Simon Glass
On Sat, 16 Dec 2023 at 08:46, Heinrich Schuchardt wrote: > > Building sandbox_defconfig with > > CONFIG_BOOTSTD=n > CONFIG_UT_BOOTSTD=y > > leads to an error > > /usr/bin/ld: test/cmd_ut.o:(.data.rel.cmd_ut_sub+0xc0): > undefined reference to `do_ut_bootstd' > > Add the missing

Re: [PATCH v3 1/4] acpi: use 64-bit addresses in FADT table

2023-12-16 Thread Simon Glass
On Sat, 16 Dec 2023 at 01:12, Heinrich Schuchardt wrote: > > Fields X_FIRMWAE_CTRL and X_DSDT must be 64bit wide. Convert pointers to > to uintptr_t to fill these. > > If field X_FIRMWARE_CTRL is filled, field FIRMWARE must be ignored. If > field X_DSDT is filled, field DSDT must be ignored. We

Re: [PATCH v3 4/4] acpi: support 64bit in acpi_find_table for DSDT and FACS

2023-12-16 Thread Simon Glass
On Sat, 16 Dec 2023 at 01:12, Heinrich Schuchardt wrote: > > Use X_DSDT and X_FIRMWARE_CTRL if available. > > Signed-off-by: Heinrich Schuchardt > --- > lib/acpi/acpi.c | 29 - > 1 file changed, 24 insertions(+), 5 deletions(-) Reviewed-by: Simon Glass This could

Re: [PATCH v3 2/4] cmd: acpi: fix listing DSDT and FACS

2023-12-16 Thread Simon Glass
On Sat, 16 Dec 2023 at 01:12, Heinrich Schuchardt wrote: > > If field X_FIRMWARE_CTRL is filled, field FIRMWARE must be ignored. If > field X_DSDT is filled, field DSDT must be ignored. > > Signed-off-by: Heinrich Schuchardt > --- > cmd/acpi.c | 8 ++-- > 1 file changed, 6 insertions(+), 2

Re: [PATCH v3 3/4] cmd: acpi: check HW reduced flag in acpi list

2023-12-16 Thread Simon Glass
On Sat, 16 Dec 2023 at 01:12, Heinrich Schuchardt wrote: > > On non x86 platforms the hardware reduce flag must be set in the FADT > table. Write an error message if the flag is missing. > > Signed-off-by: Heinrich Schuchardt > --- > cmd/acpi.c | 4 > 1 file changed, 4 insertions(+)

Re: [PATCH] get_maintainer.pl: Add --git to look up CCed in git history

2023-12-16 Thread Tom Rini
On Sat, Dec 16, 2023 at 07:07:52PM +0100, Marek Vasut wrote: > Add the --git parameter, else recent contributors are left out of the CC list. > > Signed-off-by: Marek Vasut Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP signature

Re: [PATCH] arm: Add OVERLAY command to BSS section

2023-12-16 Thread Tom Rini
On Sat, Dec 16, 2023 at 07:08:22PM +0100, Marek Vasut wrote: > Avoid allocating and loading the BSS section. > > $ aarch64-linux-gnu-objdump -Sh u-boot > > Before: > 10 .bss_start 000f21d8 000f21d8 001021d8 > 2**0 >CONTENTS, ALLOC, LOAD,

[PATCH] arm: Add OVERLAY command to BSS section

2023-12-16 Thread Marek Vasut
Avoid allocating and loading the BSS section. $ aarch64-linux-gnu-objdump -Sh u-boot Before: 10 .bss_start 000f21d8 000f21d8 001021d8 2**0 CONTENTS, ALLOC, LOAD, DATA 11 .bss 68f8 000f2200 000f2200 001021d8

[PATCH] get_maintainer.pl: Add --git to look up CCed in git history

2023-12-16 Thread Marek Vasut
Add the --git parameter, else recent contributors are left out of the CC list. Signed-off-by: Marek Vasut --- Cc: Simon Glass Cc: Tom Rini --- .get_maintainer.conf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.get_maintainer.conf b/.get_maintainer.conf index

Proposal: U-Boot memory management

2023-12-16 Thread Simon Glass
Hi, This records my thoughts after a discussion with Ilias & Heinrich re memory allocation in U-Boot. 1. malloc() malloc() is used for programmatic memory allocation. It allows memory to be freed. It is not designed for very large allocations (e.g. a 10MB kernel or 100MB ramdisk). 2. lmb lmb

Re: [PATCH v1 0/8] Convert Tegra pinctrl to DM

2023-12-16 Thread Svyatoslav Ryhel
сб, 9 груд. 2023 р. о 16:14 Tom Rini пише: > > On Mon, Dec 04, 2023 at 04:45:38PM +0200, Svyatoslav Ryhel wrote: > > пн, 4 груд. 2023 р. о 12:26 Thierry Reding пише: > > > > > > On Mon, Dec 04, 2023 at 10:20:46AM +0200, Svyatoslav Ryhel wrote: > > > > Create a DM supported wrapper arround

Re: [PATCH v3 21/22] bootm: Create a function to run through the booti states

2023-12-16 Thread Tom Rini
On Fri, Dec 15, 2023 at 08:14:25PM -0700, Simon Glass wrote: > In a few places, the booti command is used to handle a boot. We want > these to be done without needing CONFIG_CMDLINE, so add a new > booti_run() function to handle this. > > So far this is not used. > > Signed-off-by: Simon Glass

Re: [PATCH v3 19/22] bootm: Create a function to run through the bootz states

2023-12-16 Thread Tom Rini
On Fri, Dec 15, 2023 at 08:14:23PM -0700, Simon Glass wrote: > In a few places, the bootz command is used to handle a boot. We want > these to be done without needing CONFIG_CMDLINE, so add a new > bootz_run() function to handle this. > > Signed-off-by: Simon Glass Reviewed-by: Tom Rini --

Re: [PATCH v3 17/22] bootm: Create a function to run through the bootm states

2023-12-16 Thread Tom Rini
On Fri, Dec 15, 2023 at 08:14:21PM -0700, Simon Glass wrote: > In quite a few places, the bootm command is used to handle a boot. We > want these to be done without needing CONFIG_CMDLINE, so add a new > bootm_run() function to handle this. > > Signed-off-by: Simon Glass Reviewed-by: Tom Rini

Re: [PATCH v3 22/22] bootm: Create a new boot_run() function to handle booting

2023-12-16 Thread Tom Rini
On Fri, Dec 15, 2023 at 08:14:26PM -0700, Simon Glass wrote: > Create a common function used by the three existing bootz/i/m_run() > functions, to reduce duplicated code. > > Signed-off-by: Simon Glass > Suggested-by: Tom Rini > --- > > Changes in v3: > - Add new boot_run() function > >

Re: [PATCH v3 10/22] bootm: Add more fields to bootm_info

2023-12-16 Thread Tom Rini
On Fri, Dec 15, 2023 at 08:14:14PM -0700, Simon Glass wrote: > Add fields for the three bootm parameters and other things needed for > booting. Also add a helper to set up the struct correctly. > > Signed-off-by: Simon Glass Reviewed-by: Tom Rini -- Tom signature.asc Description: PGP

Re: [PATCH v6 0/5] Populate kaslr seed with RNG

2023-12-16 Thread Tom Rini
On Thu, Nov 30, 2023 at 04:54:39PM -0800, Sean Edmond wrote: > This patch series creates a common API (fdt_fixup_kaslr_seed()) for > populating the kaslr seed in the DTB. Existing users (kaslrseed, > and ARMv8 sec firmware) have been updated to use this common API. > > New functionality has

Re: [PATCH v2 1/1] clk: clk-gpio: add actual gated clock

2023-12-16 Thread Sean Anderson
On 12/16/23 11:52, Marek Vasut wrote: On 12/16/23 16:37, Sean Anderson wrote: On 12/16/23 03:48, Svyatoslav Ryhel wrote: Existing gpio-gate-clock driver acts like a simple GPIO switch without any effect on gated clock. Add actual clock actions into enable/disable ops and implement get_rate op

Re: [PATCH v2 1/1] clk: clk-gpio: add actual gated clock

2023-12-16 Thread Svyatoslav Ryhel
сб, 16 груд. 2023 р. о 18:52 Marek Vasut пише: > > On 12/16/23 16:37, Sean Anderson wrote: > > On 12/16/23 03:48, Svyatoslav Ryhel wrote: > >> Existing gpio-gate-clock driver acts like a simple GPIO switch without > >> any > >> effect on gated clock. Add actual clock actions into enable/disable >

Re: [PATCH v2 1/1] clk: clk-gpio: add actual gated clock

2023-12-16 Thread Marek Vasut
On 12/16/23 16:37, Sean Anderson wrote: On 12/16/23 03:48, Svyatoslav Ryhel wrote: Existing gpio-gate-clock driver acts like a simple GPIO switch without any effect on gated clock. Add actual clock actions into enable/disable ops and implement get_rate op by passing gated clock if it is

Re: [GIT PULL] clock changes for u-boot/next

2023-12-16 Thread Tom Rini
On Fri, Dec 15, 2023 at 03:52:26PM -0500, Sean Anderson wrote: > The following changes since commit fa3f19aa56c519d6345cc774187b7a8fdc053d71: > > Merge tag 'xilinx-for-v2024.04-rc1' of > https://source.denx.de/u-boot/custodians/u-boot-microblaze into next > (2023-12-14 13:27:11 -0500) > >

Re: [PATCH v3 08/16] fastboot: Remove dependencies on CMDLINE

2023-12-16 Thread Tom Rini
On Sat, Dec 16, 2023 at 06:16:38AM -0700, Simon Glass wrote: > It is possible to boot a kernel without CMDLINE being enabled. Update > the implementation to handle this, and drop the condition from the > FASTBOOT config. > > Reviewed-by: Mattijs Korpershoek > > Signed-off-by: Simon Glass

Re: [GIT PULL] clock changes for u-boot/master

2023-12-16 Thread Tom Rini
On Fri, Dec 15, 2023 at 04:06:23PM -0500, Sean Anderson wrote: > The following changes since commit 3ac22891cfc0dc6d8eec25d2b0fbdd2eb8f3d3ed: > > Merge tag 'u-boot-imx-20231214' of > https://gitlab.denx.de/u-boot/custodians/u-boot-imx (2023-12-15 08:22:31 > -0500) > > are available in the

[PATCH 1/1] test: CONFIG_UT_BOOTSTD must depend on CONFIG_BOOTSTD

2023-12-16 Thread Heinrich Schuchardt
Building sandbox_defconfig with CONFIG_BOOTSTD=n CONFIG_UT_BOOTSTD=y leads to an error /usr/bin/ld: test/cmd_ut.o:(.data.rel.cmd_ut_sub+0xc0): undefined reference to `do_ut_bootstd' Add the missing dependency. Signed-off-by: Heinrich Schuchardt --- test/Kconfig | 2 +- 1

[PATCH 1/1] boot: CONFIG_CEDIT must depend on CONFIG_EXPO

2023-12-16 Thread Heinrich Schuchardt
Building sandbox_defconfig with CONFIG_CMD_CEDIT=y CONFIG_EXPO=n fails with cmd/cedit.c:258:(.text.do_cedit_run+0x4c): undefined reference to `expo_apply_theme Fix the dependencies. Fixes: a0874dc4ac71 ("expo: Add a configuration editor") Signed-off-by: Heinrich Schuchardt

Re: [PATCH v2 1/1] clk: clk-gpio: add actual gated clock

2023-12-16 Thread Sean Anderson
On 12/16/23 03:48, Svyatoslav Ryhel wrote: Existing gpio-gate-clock driver acts like a simple GPIO switch without any effect on gated clock. Add actual clock actions into enable/disable ops and implement get_rate op by passing gated clock if it is enabled. Signed-off-by: Svyatoslav Ryhel ---

[PATCH 1/1] test: build test/boot for CONFIG_UT_BOOTSTD=n

2023-12-16 Thread Heinrich Schuchardt
Building sandbox_defconfig with CONFIG_UT_BOOTSTD=n CONFIG_MEASURMENT=y results in an error: /usr/bin/ld: test/cmd_ut.o:(.data.rel.cmd_ut_sub+0x408): undefined reference to `do_ut_measurement' Fixes: 5999ea20fa42 ("test: Add sandbox TPM boot measurement") Signed-off-by:

Booting fails on the sandbox

2023-12-16 Thread Heinrich Schuchardt
Hello Simon, I have built sandbox_defconfig with PREBOOT='host bind 0 ../sct.img' On the image I have an ESP with file EFI/BOOT/BOOTX64.EFI. I would expect the sandbox to boot from the ESP. But when starting the sandbox is does not boot. Instead it shows a menu with some Fedora related entry:

[PATCH v3 08/16] fastboot: Remove dependencies on CMDLINE

2023-12-16 Thread Simon Glass
It is possible to boot a kernel without CMDLINE being enabled. Update the implementation to handle this, and drop the condition from the FASTBOOT config. Reviewed-by: Mattijs Korpershoek Signed-off-by: Simon Glass --- Changes in v3: - Expand the fastboot help Changes in v2: - Avoid changing

Re: [PATCH 1/2] ARM: imx: Force DRAM regulators into FPWM mode on DH i.MX8MP DHCOM SoM

2023-12-16 Thread Fabio Estevam
On Sat, Dec 16, 2023 at 2:43 AM Marek Vasut wrote: > > In case the Buck5 and Buck6 regulators which supply DRAM Vdd1 and Vdd2/Vddq > respectively operate in automatic PWM/PFM mode, the DRAM EDAC detects more > correctable errors than if the regulators operate in forced PWM only mode. > Force DRAM

Re: [PATCH 1/2] configs: imx8m{m, n, p}_venice_defconfig: add arch_misc_init

2023-12-16 Thread Fabio Estevam
On Thu, Dec 14, 2023 at 1:25 PM Tim Harvey wrote: > > Enable call to arch_misc_init in order to probe the CAAM driver. > > Signed-off-by: Tim Harvey Applied only this one to u-boot-imx next, thanks.

Re: [PATCH] arm: dts: imx8mp-venice-gw72xx: add TPM device

2023-12-16 Thread Fabio Estevam
On Mon, Nov 27, 2023 at 4:37 PM Tim Harvey wrote: > > Add the TPM device found on the GW72xx revision F PCB. > > This hangs off of SPI2, uses gpio1_10 as a CS and gpio1_11 as RST#. > > Signed-off-by: Tim Harvey Applied to u-boot-imx next, thanks.

Re: [PATCH] arm: dts: imx8mm-venice-gw72xx: add TPM device

2023-12-16 Thread Fabio Estevam
On Mon, Nov 27, 2023 at 4:37 PM Tim Harvey wrote: > > Add the TPM device found on the GW72xx revision F PCB. > > This hangs off of SPI2, uses gpio1_10 as a CS and gpio1_11 as RST#. > > Signed-off-by: Tim Harvey Applied to u-boot-imx next, thanks.

Re: [PATCH] ARM: dts: imx7d-pico: Fix alias node indent

2023-12-16 Thread Fabio Estevam
Hi Marek, On Sat, Dec 16, 2023 at 2:36 AM Marek Vasut wrote: > > Switch from indent with spaces to indent with tabs. No functional change. > > Fixes: f8548ce0e093 ("imx7d-pico: Fix the name of the u-boot.dtsi file") > Signed-off-by: Marek Vasut Thanks for the patch, but this is already fixed

[PATCH v2 1/1] clk: clk-gpio: add actual gated clock

2023-12-16 Thread Svyatoslav Ryhel
Existing gpio-gate-clock driver acts like a simple GPIO switch without any effect on gated clock. Add actual clock actions into enable/disable ops and implement get_rate op by passing gated clock if it is enabled. Signed-off-by: Svyatoslav Ryhel --- drivers/clk/clk-gpio.c | 44

[PATCH v2 0/1] Fix clk-gpio driver

2023-12-16 Thread Svyatoslav Ryhel
Existing gpio-gate-clock driver acts like a simple GPIO switch without any effect on gated clock. Add actual clock actions into enable/disable ops and implement get_rate op by passing gated clock if it is enabled. Testing current driver implementation shows that it is not fully capable and lacks

[PATCH v3 4/4] acpi: support 64bit in acpi_find_table for DSDT and FACS

2023-12-16 Thread Heinrich Schuchardt
Use X_DSDT and X_FIRMWARE_CTRL if available. Signed-off-by: Heinrich Schuchardt --- lib/acpi/acpi.c | 29 - 1 file changed, 24 insertions(+), 5 deletions(-) diff --git a/lib/acpi/acpi.c b/lib/acpi/acpi.c index f21e509461..f80b2176e1 100644 --- a/lib/acpi/acpi.c +++

[PATCH v3 3/4] cmd: acpi: check HW reduced flag in acpi list

2023-12-16 Thread Heinrich Schuchardt
On non x86 platforms the hardware reduce flag must be set in the FADT table. Write an error message if the flag is missing. Signed-off-by: Heinrich Schuchardt --- cmd/acpi.c | 4 1 file changed, 4 insertions(+) diff --git a/cmd/acpi.c b/cmd/acpi.c index 8d9eaf36c9..f6e02ea7a5 100644 ---

[PATCH v3 2/4] cmd: acpi: fix listing DSDT and FACS

2023-12-16 Thread Heinrich Schuchardt
If field X_FIRMWARE_CTRL is filled, field FIRMWARE must be ignored. If field X_DSDT is filled, field DSDT must be ignored. Signed-off-by: Heinrich Schuchardt --- cmd/acpi.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/cmd/acpi.c b/cmd/acpi.c index

[PATCH v3 1/4] acpi: use 64-bit addresses in FADT table

2023-12-16 Thread Heinrich Schuchardt
Fields X_FIRMWAE_CTRL and X_DSDT must be 64bit wide. Convert pointers to to uintptr_t to fill these. If field X_FIRMWARE_CTRL is filled, field FIRMWARE must be ignored. If field X_DSDT is filled, field DSDT must be ignored. We should not fill unused fields. See the field definitions in chapter

[PATCH v3 0/4] cmd: acpi: correct handling of DSDT and FACS

2023-12-16 Thread Heinrich Schuchardt
Fields X_FIRMWARE and X_DSDT in the FADT table must be 64bit. Fix the definition in our include. The 64bit fields X_FIRMWARE and X_DSDT take precedence over the respective 32bit fields. Consider this in the 'acpi list' and 'acpi dump' commands. The fields only exist for FADT table revision 3 and