Re: [PATCH v3 3/8] scripts/Makefile.lib: Statically define *-u-boot.dtsi files location

2024-01-07 Thread Sumit Garg
Hi Bryan, On Sat, 6 Jan 2024 at 02:12, Bryan Brattlof wrote: > > Hi Sumit! > > On December 28, 2023 thus sayeth Sumit Garg: > > Allow u-boot to build DTB from a different directory tree such that > > *-u-boot.dtsi files can be included from a common location. Currently > > that location is

Re: [PATCH v2] rockchip: rk3328: Set efuse auto mode and timing control

2024-01-07 Thread Kever Yang
On 2024/1/8 02:18, Jonas Karlman wrote: Reading from efuse return zero when mainline TF-A is used. => dump_efuse : 00 00 00 00 0004: 00 00 00 00 0008: 00 00 00 00 000c: 00 00 00 00 0010: 00 00 00 00 0014: 00 00 00

Please pull u-boot-dm/next

2024-01-07 Thread Simon Glass
Hi Tom, This is for -next https://source.denx.de/u-boot/custodians/u-boot-dm/-/pipelines/19216 https://dev.azure.com/simon0972/u-boot/_build/results?buildId=58=results The following changes since commit c2c598e87cfe56f5991730762c00733c5aa9a994: Merge branch 'staging' of

Re: [PATCH v3 1/4] acpi: use 64-bit addresses in FADT table

2024-01-07 Thread Simon Glass
On Sat, 16 Dec 2023 at 01:12, Heinrich Schuchardt wrote: > > Fields X_FIRMWAE_CTRL and X_DSDT must be 64bit wide. Convert pointers to > to uintptr_t to fill these. > > If field X_FIRMWARE_CTRL is filled, field FIRMWARE must be ignored. If > field X_DSDT is filled, field DSDT must be ignored. We

Re: [PATCH v3 2/4] cmd: acpi: fix listing DSDT and FACS

2024-01-07 Thread Simon Glass
On Sat, 16 Dec 2023 at 01:12, Heinrich Schuchardt wrote: > > If field X_FIRMWARE_CTRL is filled, field FIRMWARE must be ignored. If > field X_DSDT is filled, field DSDT must be ignored. > > Signed-off-by: Heinrich Schuchardt > --- > cmd/acpi.c | 8 ++-- > 1 file changed, 6 insertions(+), 2

Re: [PATCH v3 3/4] cmd: acpi: check HW reduced flag in acpi list

2024-01-07 Thread Simon Glass
On Sat, 16 Dec 2023 at 01:12, Heinrich Schuchardt wrote: > > On non x86 platforms the hardware reduce flag must be set in the FADT > table. Write an error message if the flag is missing. > > Signed-off-by: Heinrich Schuchardt > --- > cmd/acpi.c | 4 > 1 file changed, 4 insertions(+)

Re: [PATCH v4 2/9] acpi: carve out qfw_acpi.c

2024-01-07 Thread Simon Glass
On Tue, Dec 19, 2023 at 04:04:01PM +0100, Heinrich Schuchardt wrote: > Move the code related to copying tables from QEMU to a separate code > module. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Tom Rini > Reviewed-by: Simon Glass > --- > v4: > no change > v3: > no change >

Re: [PATCH v3 4/4] acpi: support 64bit in acpi_find_table for DSDT and FACS

2024-01-07 Thread Simon Glass
Hi Heinrich, On Sat, 16 Dec 2023 at 12:21, Heinrich Schuchardt wrote: > > On 12/16/23 19:45, Simon Glass wrote: > > On Sat, 16 Dec 2023 at 01:12, Heinrich Schuchardt > > wrote: > >> > >> Use X_DSDT and X_FIRMWARE_CTRL if available. > >> > >> Signed-off-by: Heinrich Schuchardt > >> --- > >>

Re: [PATCH v4 1/9] acpi: Kconfig symbol CONFIG_QFW_ACPI

2024-01-07 Thread Simon Glass
We have two implementations of write_acpi_tables(). One for writing ACPI tables based on ACPI_WRITER() entries another based on copying tables from QEMU. Create a symbol CONFIG_QFW_ACPI that signifies copying ACPI tables from QEMU and use it consistently. Signed-off-by: Heinrich Schuchardt

Re: [PATCH v4 6/9] riscv: add support for QEMU firmware tables

2024-01-07 Thread Simon Glass
Enable the QEMU firmware interface if ACPI tables are to be supported on the QEMU platform. Enable the QFW MMIO interface if the QEMU firmware interface is enabled. Signed-off-by: Heinrich Schuchardt Reviewed-by: Simon Glass Reviewed-by: Ilias Apalodimas --- v4: no change v3:

Re: [PATCH v4 3/9] arm: add ACPI fields to global data

2024-01-07 Thread Simon Glass
On Tue, 19 Dec 2023 at 08:04, Heinrich Schuchardt wrote: > > Add fields for the location of ACPI tables to the global data. > > Signed-off-by: Heinrich Schuchardt > --- > v4: > no change > v3: > let tables in global data depend on CONFIG_(SPL_)ACPI > v2: > new patch > ---

Re: [PATCH v4 4/9] riscv: add ACPI fields to global data

2024-01-07 Thread Simon Glass
Add fields for the location of ACPI tables to the global data. Signed-off-by: Heinrich Schuchardt Reviewed-by: Simon Glass Reviewed-by: Bin Meng --- v4: no change v3: let tables in global data depend on CONFIG_(SPL_)ACPI v2: no change ---

Re: [PATCH v4 5/9] acpi: enable writing ACPI tables on QEMU

2024-01-07 Thread Simon Glass
On Tue, Dec 19, 2023 at 04:04:04PM +0100, Heinrich Schuchardt wrote: > Invoke write_acpi_tables() via EVT_LAST_STAGE_INIT on QEMU except on X86. > X86 calls write_acpi_tables() in write_tables(). > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Simon Glass > --- > v4: > no change >

Re: [PATCH v4 8/9] configs: qemu: add config fragment for ACPI

2024-01-07 Thread Simon Glass
Provide a configuration fragment to enable ACPI on QEMU. Signed-off-by: Heinrich Schuchardt Acked-by: Ilias Apalodimas Reviewed-by: Simon Glass --- v4: mention that QEMU v8.0.0 introduced RISC-V ACPI support v3: no change v2: no change --- MAINTAINERS

Re: [PATCH v4 7/9] riscv: allow usage of ACPI

2024-01-07 Thread Simon Glass
Select CONFIG_SUPPORT_ACPI to allow usage of ACPI tables with RISC-V. Signed-off-by: Heinrich Schuchardt Reviewed-by: Simon Glass --- v4: no change v3: no change v2: no change --- arch/Kconfig | 1 + 1 file changed, 1 insertion(+) Applied to u-boot-dm/next, thanks!

Re: [PATCH v4 9/9] arm: enable support for QEMU firmware tables

2024-01-07 Thread Simon Glass
On Tue, 19 Dec 2023 at 17:04, Heinrich Schuchardt wrote: > > Enable the QEMU firmware interface if ACPI tables are to be supported on > the QEMU platform. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: Simon Glass > --- > v4: > no change > v3: > no change > v2: >

Re: [PATCH v5 01/12] smbios: Refactor 32-bit code into an else statement

2024-01-07 Thread Simon Glass
In preparation for adding support for SMBIOS3 move this code into an else statement. There is no functional change. Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt Reviewed-by: Ilias Apalodimas --- (no changes since v1) lib/smbios.c | 38 +- 1

Re: [PATCH v5 02/12] smbios: Move the rest of the SMBIOS2 code

2024-01-07 Thread Simon Glass
Move all of this logic into the else clause, since it will not be used for SMBIOS3 Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt Reviewed-by: Ilias Apalodimas --- (no changes since v1) lib/smbios.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) Applied

Re: [PATCH v5 04/12] smbios: Use SMBIOS 3.0 to support an address above 4GB

2024-01-07 Thread Simon Glass
Hi Heinrich, On Mon, Jan 1, 2024 at 10:34 AM Heinrich Schuchardt wrote: > > On 12/31/23 16:25, Simon Glass wrote: > > When the SMBIOS table is written to an address above 4GB a 32-bit table > > address is not large enough. > > > > Use an SMBIOS3 table in that case. > > > > Note that we cannot

Re: [PATCH v5 03/12] smbios: SMBIOS 3.0 (64-bit) Entry Point structure

2024-01-07 Thread Simon Glass
From: Heinrich Schuchardt Add definition of the SMBIOS 3.0 (64-bit) Entry Point structure. Signed-off-by: Heinrich Schuchardt Reviewed-by: Simon Glass Reviewed-by: Ilias Apalodimas Signed-off-by: Simon Glass --- (no changes since v4) Changes in v4: - Bring in this patch from Heinrich's

Re: [PATCH v5 05/12] smbios: Correct gd_smbios_start()

2024-01-07 Thread Simon Glass
This should access arch-specific properties. Fix it and update the existing usage. Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt Reviewed-by: Ilias Apalodimas --- (no changes since v2) Changes in v2: - Add a new patch to correct gd_smbios_start()

Re: [PATCH v5 06/12] efi: Use the correct GUID for the SMBIOS table

2024-01-07 Thread Simon Glass
EFI does not use the 'anchor string' to determine the SMBIOS table version, instead preferring to have two separate GUIDs. Use the correct one, depending on the table version. Call unmap_system() to balance to the use of map_sysmem() Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt

Re: [PATCH v5 08/12] smbios: Drop support for SMBIOS2 tables

2024-01-07 Thread Simon Glass
On Sun, Dec 31, 2023 at 3:26 PM Simon Glass wrote: > > These tables are a pain since there is no way to handle memory above > 4GB. Use SMBIOS3 always. > > This should hopefully not create problems on x86 devices, since SMBIOS3 > was released seven years ago (2015). > > Signed-off-by: Simon Glass

Re: [PATCH v5 07/12] smbios: Require the caller to align the SMBIOS table

2024-01-07 Thread Simon Glass
All callers handle this alignment, so drop the unnecessary code. This simplifies things a little. Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt Reviewed-by: Ilias Apalodimas --- Changes in v5: - Update comment to mention x86 alignment include/smbios.h | 9 +

Re: [PATCH v5 09/12] efi: smbios: Drop support for SMBIOS2 tables

2024-01-07 Thread Simon Glass
On 12/31/23 16:25, Simon Glass wrote: > Only the v3 table is supported now, so always use this when installing > the EFI table. > > Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt > --- > > Changes in v5: > - Add new patch to drop support for SMBIOS2 tables with EFI > >

Re: [PATCH v7] fdt: Allow the devicetree to come from a bloblist

2024-01-07 Thread Simon Glass
On Thu, 4 Jan 2024 at 03:49, Simon Glass wrote: > > Standard passage provides for a bloblist to be passed from one firmware > phase to the next. That can be used to pass the devicetree along as well. > Add an option to support this. > > Tests for this will be added as part of the Universal

Re: [PATCH v5 11/12] acpi: Write pointers to tables instead of addresses

2024-01-07 Thread Simon Glass
On 12/31/23 16:25, Simon Glass wrote: > Sandbox uses an API to map between addresses and pointers. This allows > it to have (emulated) memory at zero and avoid arch-specific addressing > details. It also allows memory-mapped peripherals to work. > > As an example, on many machines sandbox maps

Re: [PATCH v5 10/12] acpi: Rename test dm_test_setup_ctx_and_base_tables()

2024-01-07 Thread Simon Glass
Am 31. Dezember 2023 16:25:53 MEZ schrieb Simon Glass : >Use the word 'acpi' in this test so that it runs along with all the >other ACPI tests. > >Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt >--- > >Changes in v5: >- Add new patch to rename test

Re: [PATCH v5 12/12] efi: Correct smbios-table installation

2024-01-07 Thread Simon Glass
On 1/1/24 01:37, Simon Glass wrote: > Hi Heinrich, > > On Sun, Dec 31, 2023 at 9:27 AM Heinrich Schuchardt > wrote: >> >> On 12/31/23 16:25, Simon Glass wrote: >>> At present this code allocates memory when writing the tables and >>> then unnecessarily adds another memory map when installing it.

[PATCH 2/2] coreboot: Switch to a monospaced font

2024-01-07 Thread Simon Glass
The default font is proportional, with different character widths. Select a monospace font for coreboot so that the 'dm tree' output lines up correctly. Update the coreboot tests to match. Signed-off-by: Simon Glass --- configs/coreboot64_defconfig | 3 +++ configs/coreboot_defconfig | 3

[PATCH 1/2] video: Allow querying the font size

2024-01-07 Thread Simon Glass
All the font size to be queried using the 'font size' command. Signed-off-by: Simon Glass --- cmd/font.c | 17 + doc/usage/cmd/font.rst | 6 -- test/cmd/font.c| 9 + 3 files changed, 22 insertions(+), 10 deletions(-) diff --git a/cmd/font.c

Re: [RFC PATCH V2] net: wget: Take in account tcp sequence number wrap around

2024-01-07 Thread Fabio Estevam
On Sun, Jan 7, 2024 at 5:01 PM Michael Trimarchi wrote: > > Coming from some discussion on mailing about wget unconsistent. It's > just and idea to play around > > Signed-off-by: Michael Trimarchi > --- > RFC V1 -> RFC V2: > - drop random train change in unsigned difference Same

[RFC PATCH V2] net: wget: Take in account tcp sequence number wrap around

2024-01-07 Thread Michael Trimarchi
Coming from some discussion on mailing about wget unconsistent. It's just and idea to play around Signed-off-by: Michael Trimarchi --- RFC V1 -> RFC V2: - drop random train change in unsigned difference --- include/net/tcp.h | 10 ++ net/wget.c| 2 +- 2 files changed,

Re: [PATCH] boot: add support for button commands

2024-01-07 Thread Svyatoslav Ryhel
пт, 5 січ. 2024 р. о 18:03 Caleb Connolly пише: > > With the relatively new button API in U-Boot, it's now much easier to > model the common usecase of mapping arbitrary actions to different > buttons during boot - for example entering fastboot mode, setting some > additional kernel cmdline

[PATCH v2] rockchip: rk3328: Set efuse auto mode and timing control

2024-01-07 Thread Jonas Karlman
Reading from efuse return zero when mainline TF-A is used. => dump_efuse : 00 00 00 00 0004: 00 00 00 00 0008: 00 00 00 00 000c: 00 00 00 00 0010: 00 00 00 00 0014: 00 00 00 00 0018: 00 00 00 00 001c:

Re: inconsistent wget behavior

2024-01-07 Thread Fabio Estevam
Hi Michael, On Sun, Jan 7, 2024 at 1:36 PM Michael Nazzareno Trimarchi wrote: > I have sent but not sure about it, just compile for now ;) It didn't work: u-boot=> wget 192.168.0.16:/test HTTP/1.0 200 OK| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | |

Re: [PATCH v2] rockchip: rk35xx: expand space for decompressed kernel

2024-01-07 Thread Jonas Karlman
Hi Hugh, On 2023-12-26 17:43, Hugh Cole-Baker wrote: > An uncompressed 6.7.0-rc1 Linux kernel Image built with the arm64 > defconfig is about 40MB. This does not fit in to the space between > kernel_comp_addr_r and fdt_addr_r, so when uncompressing an Image.gz > to this size, the FDT will be

Re: inconsistent wget behavior

2024-01-07 Thread Michael Nazzareno Trimarchi
Hi Fabio On Sun, Jan 7, 2024 at 5:19 PM Michael Nazzareno Trimarchi wrote: > > Hi > > Il dom 7 gen 2024, 17:08 Fabio Estevam ha scritto: >> >> Hi Michael, >> >> On Sat, Jan 6, 2024 at 5:49 AM Michael Nazzareno Trimarchi >> wrote: >> > >> > Hi >> > >> > Is this code correct? >> > >> > if

[RFC PATCH] net: wget: Take in account tcp sequence number wrap around

2024-01-07 Thread Michael Trimarchi
Coming from some discussion on mailing about wget unconsistent. It's just and idea to play around Signed-off-by: Michael Trimarchi --- I'm on a train ;). No board to test --- include/net/tcp.h | 10 ++ net/wget.c| 8 2 files changed, 14 insertions(+), 4 deletions(-)

Re: inconsistent wget behavior

2024-01-07 Thread Michael Nazzareno Trimarchi
Hi Il dom 7 gen 2024, 17:08 Fabio Estevam ha scritto: > Hi Michael, > > On Sat, Jan 6, 2024 at 5:49 AM Michael Nazzareno Trimarchi > wrote: > > > > Hi > > > > Is this code correct? > > > > if (tcp_seq_num >= initial_data_seq_num && > > store_block(pkt, tcp_seq_num -

Re: inconsistent wget behavior

2024-01-07 Thread Fabio Estevam
Hi Michael, On Sat, Jan 6, 2024 at 5:49 AM Michael Nazzareno Trimarchi wrote: > > Hi > > Is this code correct? > > if (tcp_seq_num >= initial_data_seq_num && > store_block(pkt, tcp_seq_num - initial_data_seq_num, > len) != 0) { >

[PATCH 4/4] doc: sophgo: milkv_duo: document Milk-V Duo board

2024-01-07 Thread Kongyang Liu
Add document for Milk-V Duo board which based on Sophgo's CV1800B SoC. Signed-off-by: Kongyang Liu --- doc/board/index.rst| 1 + doc/board/sophgo/index.rst | 8 ++ doc/board/sophgo/milkv_duo.rst | 50 ++ 3 files changed, 59 insertions(+)

[PATCH 3/4] configs: milkv_duo_defconfig: Add initial config

2024-01-07 Thread Kongyang Liu
Add basic config for Milk-V Duo board which make it capable of booting into serial console. Signed-off-by: Kongyang Liu --- configs/milkv_duo_defconfig | 24 1 file changed, 24 insertions(+) create mode 100644 configs/milkv_duo_defconfig diff --git

[PATCH 2/4] riscv: dts: sophgo: Add basic device tree for Milk-V Duo board

2024-01-07 Thread Kongyang Liu
Import device tree from Linux kernel to add basic support for CPU, PLIC, UART and Timer. The name cv1800b in the filename represent the chip used on Milk-V Duo board. Signed-off-by: Kongyang Liu --- arch/riscv/dts/Makefile | 1 + arch/riscv/dts/cv1800b-milkv-duo.dts | 38

[PATCH 1/4] riscv: sophgo: milkv_duo: initial support added

2024-01-07 Thread Kongyang Liu
Add support for Sophgo's Milk-V Duo board, only minimal device tree and serial console are enabled, and it can boot via vendor first stage bootloader. Signed-off-by: Kongyang Liu --- arch/riscv/Kconfig | 4 board/sophgo/milkv_duo/Kconfig | 28

[PATCH 0/4] riscv: sophgo: milkv_duo: add support for Milk-V Duo board

2024-01-07 Thread Kongyang Liu
The Milk-V Duo board is built upon Sophgo's CV1800B SoC, featuring two XuanTie C906 CPUs running at 1.0GHz and 700MHz, respectively. This series introduces fundamental support for the Milk-V Duo board, encompassing UART, CPU, and PLIC support. This ensures that U-Boot can operate in serial

Re: [PATCH 3/6] board: ti: am62x: Add basic initialization for usb voltage, 32k crystal, debounce

2024-01-07 Thread Jan Kiszka
On 26.07.23 13:10, Nishanth Menon wrote: > On 00:35-20230726, Francesco Dolcini wrote: > [...] At least the ones we have currently (I am not sure about toradex, phytech etc), seem to operate the vdd_core at 0.85V .. (which is what USB is dependent upon). >>> >>> For Toradex, we

[PATCH 1/1] boot: superfluous assignment in bootflow_menu_new()

2024-01-07 Thread Heinrich Schuchardt
ret is assigned a value 0 which is never used but is immediately overwritten in the next statement. Addresses-Coverity-ID: 453304 ("Unused value") Signed-off-by: Heinrich Schuchardt --- boot/bootflow_menu.c | 1 - 1 file changed, 1 deletion(-) diff --git a/boot/bootflow_menu.c

[PATCH 1/1] boot: boot_flow_iter_set() called with uninitialized methods_flag

2024-01-07 Thread Heinrich Schuchardt
Some code paths do not initialize methods_flag before using it. Initialize it to 0 in the definition line. Addresses-Coverity-ID: ("467057 Uninitialized scalar variable") Signed-off-by: Heinrich Schuchardt --- boot/bootflow.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH 1/1] boot: remove dead code in bootflow_check()

2024-01-07 Thread Heinrich Schuchardt
The 'return 0;' statement is not reachable. Remove it. 'else' is superfluous after an if statement with return. Addresses-Coverity-ID: 352451 ("Logically dead code") Signed-off-by: Heinrich Schuchardt --- Simon, please, recheck the logic of the function. The comment 'For 'all' we return all

[PATCH 1/1] sandbox: missing return value checks in eth-raw-os

2024-01-07 Thread Heinrich Schuchardt
We should check the return value of fcntl(). Addresses-Coverity-ID: 131108 ("Unchecked return value from library") Addresses-Coverity-ID: 131109 ("Unchecked return value from library") Signed-off-by: Heinrich Schuchardt --- arch/sandbox/cpu/eth-raw-os.c | 14 -- 1 file changed, 12