Re: [FIX PATCH v1] Fix: common: usb_hub: Reset only USB3.0 hub

2024-02-09 Thread Dragan Simic
Hello Shantur, On 2024-02-08 15:17, Dragan Simic wrote: On 2024-02-08 15:10, Shantur Rathore wrote: On Thu, Feb 8, 2024 at 1:44 PM Dragan Simic wrote: On 2024-02-08 14:33, Marek Vasut wrote: > On 2/8/24 12:30, Shantur Rathore wrote: >> On Wed, Feb 7, 2024 at 1:07 PM Marek Vasut wrote: >>>

[PATCH 4/4] rockchip: rk3399: regenerate defconfigs

2024-02-09 Thread Chen-Yu Tsai
From: Chen-Yu Tsai Regenerate RK3399 defconfigs after adding imply statements. Signed-off-by: Chen-Yu Tsai --- configs/chromebook_bob_defconfig | 2 -- configs/chromebook_kevin_defconfig| 2 -- configs/firefly-rk3399_defconfig | 2 --

[PATCH 3/4] rockchip: rk3328: regenerate defconfigs

2024-02-09 Thread Chen-Yu Tsai
From: Chen-Yu Tsai Regenerate RK3328 defconfigs after adding imply statements. Signed-off-by: Chen-Yu Tsai --- configs/evb-rk3328_defconfig | 2 -- configs/nanopi-r2c-plus-rk3328_defconfig | 2 -- configs/nanopi-r2c-rk3328_defconfig | 2 --

[PATCH 2/4] rockchip: rk3399: Read cpuid and generate MAC address from efuse

2024-02-09 Thread Chen-Yu Tsai
From: Chen-Yu Tsai The rockchip-efuse driver supports the efuse found on RK3399. This hardware block is part of the SoC and contains the CPUID, which can be used to generate stable serial numbers and MAC addresses. Enable the driver and reading cpuid by default for RK3399. Signed-off-by:

[PATCH 1/4] rockchip: rk3328: Read cpuid and generate MAC address from efuse

2024-02-09 Thread Chen-Yu Tsai
From: Chen-Yu Tsai The rockchip-efuse driver supports the efuse found on RK3328. This hardware block is part of the SoC and contains the CPUID, which can be used to generate stable serial numbers and MAC addresses. Enable the driver and reading cpuid by default for RK3328. Signed-off-by:

[PATCH 0/4] rockchip: Read cpuid and generate MAC address from efuse for RK3328 and RK3399

2024-02-09 Thread Chen-Yu Tsai
From: Chen-Yu Tsai Hi folks, This series enables ROCKCHIP_EFUSE and MISC_INIT_R by default for RK3328 and RK3399 so that the cpuid is read from the efuse and used to generate a serial number and MAC addresses for all boards. This stacks on top of the recent defconfig update series [1] from

Re: [PATCH 00/15] rockchip: rk3328: Update defconfigs, DTs and enable boot from SPI

2024-02-09 Thread John Clark
On 2/6/24 7:02 PM, Jonas Karlman wrote: This series contains miscellaneous updates to defconfigs, syncs latest device trees from linux, fixes an issue loading FIT from SD-card when running SPL from eMMC and enables building a bootable SPI image on RK3328 boards. I am also adding myself as a

Re: [PATCH V3 04/11] board: ti: am62x: Set fdtfile from C code instead of findfdt script

2024-02-09 Thread Tom Rini
On Tue, Jan 30, 2024 at 07:06:08AM -0600, Nishanth Menon wrote: > Stop using the findfdt script and switch to setting the fdtfile from > C code. > > While at this, replace findfdt in environment with a warning as it is > no longer needed > > Reviewed-by: Jonathan Humphreys > Reviewed-by: Roger

Re: [PATCH v2 1/3] imx93: Use a header for imx9_probe_mu declaration

2024-02-09 Thread Igor Opaniuk
On Fri, Feb 9, 2024 at 1:05 PM Mathieu Othacehe wrote: > > Put imx9_probe_mu declaration in a new mu.h header file. > > Signed-off-by: Mathieu Othacehe > --- > arch/arm/include/asm/arch-imx9/mu.h | 13 + > board/freescale/imx93_evk/spl.c | 2 +- >

[PATCH] clk: renesas: Fix broken clocks on all Gen2 boards

2024-02-09 Thread Niklas Söderlund
To prepare support for multiple register layouts pointers to register tables where added to struct cpg_mssr_info. These pointers are suppose to be filled in at probe time and no intended change in behavior was intended. However the new pointers where only filled in by some paths of the driver

Re: [PATCH 0/2] imx93_var_som: Enable AHAB support

2024-02-09 Thread Mathieu Othacehe
> This is what I am concerned about: this hang causes the board to brick > and can no > longer be recovered since it has the fuse programmed to close the device, > right? Once the board is closed you can only boot from signed images. If the signed image is not working (hanging during

Re: [GIT PULL] Please pull u-boot-dfu-20240209

2024-02-09 Thread Tom Rini
02-08 14:42:56 -0500) > > are available in the Git repository at: > > https://source.denx.de/u-boot/custodians/u-boot-dfu.git > tags/u-boot-dfu-20240209 > > for you to fetch changes up to 766f04a297e892d5106f7f7ac8b43c69bd8a6007: > > lib: sparse: Fix error checking f

Re: [PATCH] Added FDT PAD memory size while reserving memory for FDT to avoid some memory corruption issue

2024-02-09 Thread Tom Rini
On Fri, Feb 09, 2024 at 07:45:10PM +0530, Selvakumar Velandi wrote: > The FDT relocation is not disabled. I am adding the FDT PADDING bytes while > doing FDT reservation in the board_f file. > Also update the FDT length based on the new allocation, instead of blindly > increasing the size. >

Re: [PATCH v2 1/7] common: avb_verify: don't call mmc_switch_part for SD

2024-02-09 Thread Dragan Simic
On 2024-02-09 20:20, Igor Opaniuk wrote: From: Igor Opaniuk mmc_switch_part() is used for switching between hw partitions on eMMC (boot0, boot1, user, rpmb). There is no need to do that for SD card. Reviewed-by: Mattijs Korpershoek Signed-off-by: Igor Opaniuk Looking good to me.

[PATCH v2 7/7] doc: android: avb: sync usage details

2024-02-09 Thread Igor Opaniuk
From: Igor Opaniuk Sync usage info with the one cmd/avb.c. Signed-off-by: Igor Opaniuk --- Changes in v2: - Address Mattijs comment about usage info, sync with cmd/avb.c doc/android/avb2.rst | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git

[PATCH v2 6/7] cmd: avb: rework do_avb_verify_part

2024-02-09 Thread Igor Opaniuk
From: Igor Opaniuk Use existing str_avb_slot_error() function for obtaining verification fail reason details. Take into account device lock state for setting correct androidboot.verifiedbootstate kernel cmdline parameter. Reviewed-by: Mattijs Korpershoek Signed-off-by: Igor Opaniuk ---

[PATCH v2 5/7] common: avb_verify: add str_avb_io_error/str_avb_slot_error

2024-02-09 Thread Igor Opaniuk
From: Igor Opaniuk Introduce str_avb_io_error() and str_avb_slot_error() functions, that provide a pointer to AVB runtime error message. Reviewed-by: Mattijs Korpershoek Signed-off-by: Igor Opaniuk --- Changes in v2: - Mattijs Korpershoek R-b tag applied common/avb_verify.c | 49

[PATCH v2 4/7] cmd: avb: rework prints

2024-02-09 Thread Igor Opaniuk
From: Igor Opaniuk Simplify and add more context for prints where it's needed. Signed-off-by: Igor Opaniuk --- Changes in v2: - Drop AVB_OPS_CHECK macro and leave previous check cmd/avb.c | 123 +- 1 file changed, 75 insertions(+), 48

[PATCH v2 3/7] common: avb_verify: rework error/debug prints

2024-02-09 Thread Igor Opaniuk
From: Igor Opaniuk Make error prints more verbose with additional context. Also s/print/debug/g for prints, which might be relevant only for debugging purposes. Reviewed-by: Mattijs Korpershoek Signed-off-by: Igor Opaniuk --- Changes in v2: - Mattijs Korpershoek R-b tag applied

[PATCH v2 2/7] avb: move SPDX license identifiers to the first line

2024-02-09 Thread Igor Opaniuk
From: Igor Opaniuk Move SPDX license identifiers to the first line, so it conforms to license placement rule [1]: Placement: The SPDX license identifier in kernel files shall be added at the first possible line in a file which can contain a comment. For the majority of files this is the first

[PATCH v2 1/7] common: avb_verify: don't call mmc_switch_part for SD

2024-02-09 Thread Igor Opaniuk
From: Igor Opaniuk mmc_switch_part() is used for switching between hw partitions on eMMC (boot0, boot1, user, rpmb). There is no need to do that for SD card. Reviewed-by: Mattijs Korpershoek Signed-off-by: Igor Opaniuk --- Changes in v2: - Mattijs Korpershoek R-b tag applied

[PATCH v2 0/7] AVB: cosmetic adjustments/improvements

2024-02-09 Thread Igor Opaniuk
This is the first patch series for incoming major improvements for AVB implementation, that include: - Simplify and add more context for debug/error prints where it's needed. - Move SPDX license identifiers to the first line, so it conforms to license placement rule. - Use mmc_switch_part() only

Re: [PATCH v2 2/2] smbios: fill wake-up type

2024-02-09 Thread Tom Rini
On Fri, Feb 09, 2024 at 07:37:28PM +0100, Heinrich Schuchardt wrote: > On 2/9/24 19:12, Tom Rini wrote: > > On Fri, Feb 09, 2024 at 04:51:15PM +0100, Heinrich Schuchardt wrote: > > > > > We should not use the reserved value 0x00 for the wake up type but > > > use 0x02 (Unknown). > > > > > >

Re: [PATCH v2 09/20] rockchip: merge misc.c into board.c

2024-02-09 Thread Dragan Simic
Hello Mark, On 2024-02-09 19:36, Mark Kettenis wrote: Date: Fri, 09 Feb 2024 18:58:01 +0100 From: Dragan Simic Please, see my comments below. On 2024-02-09 10:50, Quentin Schulz wrote: > From: Quentin Schulz > > The functions aren't used anywhere else than in board.c, therefore, > let's not

Re: [PATCH v2 2/2] smbios: fill wake-up type

2024-02-09 Thread Heinrich Schuchardt
On 2/9/24 19:12, Tom Rini wrote: On Fri, Feb 09, 2024 at 04:51:15PM +0100, Heinrich Schuchardt wrote: We should not use the reserved value 0x00 for the wake up type but use 0x02 (Unknown). Signed-off-by: Heinrich Schuchardt [snip] @@ -108,6 +108,16 @@ struct __packed smbios_type0 {

Re: [PATCH v2 09/20] rockchip: merge misc.c into board.c

2024-02-09 Thread Mark Kettenis
> Date: Fri, 09 Feb 2024 18:58:01 +0100 > From: Dragan Simic > > Hello Quentin, > > Please, see my comments below. > > On 2024-02-09 10:50, Quentin Schulz wrote: > > From: Quentin Schulz > > > > The functions aren't used anywhere else than in board.c, therefore, > > let's not expose them

Re: [PATCH v2 1/2] imx: imxrt1050-evk: Add support for SPI flash booting

2024-02-09 Thread Fabio Estevam
On Fri, Feb 9, 2024 at 3:27 PM Jesse T wrote: > These errors also happen on master. There are no errors in master, otherwise they would not pass the CI build. > I will submit a patch to fix these soon. Just to clarify: on master we do get the following warnings (not errors):

Re: [PATCH v2 1/2] imx: imxrt1050-evk: Add support for SPI flash booting

2024-02-09 Thread Jesse T
On Thu, Feb 8, 2024 at 8:08 AM Fabio Estevam wrote: > > Hi Jesse, > > On Tue, Feb 6, 2024 at 1:40 PM Jesse Taube wrote: > > > > Add support for booting the imxrt1050-evk from spi. > > Add imximage config and the ability for SPL to boot from NOR. > > > > Signed-off-by: Jesse Taube > > This

Re: [PATCH v2 2/2] smbios: fill wake-up type

2024-02-09 Thread Tom Rini
On Fri, Feb 09, 2024 at 04:51:15PM +0100, Heinrich Schuchardt wrote: > We should not use the reserved value 0x00 for the wake up type but > use 0x02 (Unknown). > > Signed-off-by: Heinrich Schuchardt [snip] > @@ -108,6 +108,16 @@ struct __packed smbios_type0 { > char

Re: [PATCH v2 10/20] rockchip: transform rockchip_capsule_update_board_setup into a weak function symbol

2024-02-09 Thread Dragan Simic
On 2024-02-09 10:50, Quentin Schulz wrote: From: Quentin Schulz There's only one user of rockchip_capsule_update_board_setup, which is in board.c, and only one board defines it, so instead of having a header only for one function symbol, let's just use a weak symbol instead. Cc: Quentin

Re: [PATCH v2 09/20] rockchip: merge misc.c into board.c

2024-02-09 Thread Dragan Simic
Hello Quentin, Please, see my comments below. On 2024-02-09 10:50, Quentin Schulz wrote: From: Quentin Schulz The functions aren't used anywhere else than in board.c, therefore, let's not expose them anymore at all. This merges misc.c and board.c together and removes the functions from the

Re: [PATCH v2 06/20] rockchip: pine64: rockpro64: migrate to rockchip_early_misc_init_r

2024-02-09 Thread Dragan Simic
On 2024-02-09 10:50, Quentin Schulz wrote: From: Quentin Schulz Only setup_iodomain() differs from the original misc_init_r from Rockchip mach code, so let's use rockchip_early_misc_init_r instead of reimplementing the whole misc_init_r from Rockchip. Cc: Quentin Schulz Reviewed-by: Kever

Re: [PATCH v2 05/20] rockchip: pine64: pinephone-pro: migrate to rockchip_early_misc_init_r

2024-02-09 Thread Dragan Simic
On 2024-02-09 10:50, Quentin Schulz wrote: From: Quentin Schulz Compared to the original misc_init_r from Rockchip mach code, setup_iodomain() is added and rockchip_setup_macaddr() is not called. It is assumed adding rockchip_setup_macaddr() back is fine. Let's use rockchip_early_misc_init_r

Re: [PATCH v2 04/20] rockchip: pine64: pinebook-pro: migrate to rockchip_early_misc_init_r

2024-02-09 Thread Dragan Simic
On 2024-02-09 10:50, Quentin Schulz wrote: From: Quentin Schulz Compared to the original misc_init_r from Rockchip mach code, setup_iodomain() is added and rockchip_setup_macaddr() is not called. It is assumed adding rockchip_setup_macaddr() back is fine. Let's use rockchip_early_misc_init_r

Re: [PATCH v2 01/20] rockchip: avoid out-of-bounds when computing cpuid

2024-02-09 Thread Dragan Simic
On 2024-02-09 10:49, Quentin Schulz wrote: From: Quentin Schulz The expected length of the cpuid, as passed with cpuid_length, determines the size of cpuid_str string. Therefore, care should be taken to make sure nothing is accessing data out-of-bounds. Instead of using hardcoded values,

Re: [AVB/AB] Overhaul plans

2024-02-09 Thread Igor Opaniuk
Hello Mattijs, On Fri, Feb 9, 2024 at 11:30 AM Mattijs Korpershoek wrote: > > Hi Igor, > > On ven., févr. 09, 2024 at 11:14, Igor Opaniuk wrote: > > > Hi everyone, > > > > I'm currently planning a big overhaul of the current implementation of > > AVB/AB in U-Boot during the 2024 year, which I

Re: [PATCH v3 27/36] dts: msm8916: replace with upstream DTS

2024-02-09 Thread Caleb Connolly
On 02/02/2024 08:38, Sumit Garg wrote: > On Tue, 30 Jan 2024 at 19:35, Caleb Connolly > wrote: >> >> Drop the U-Boot specific dragonboard410c.dts in favour of the upstream >> msm8916-sbc.dts. No additional changes are needed to this DTS for U-Boot >> support. >> >> Taken from kernel tag v6.7

[PATCH v2 1/2] cmd: smbios: type 1 wake-up time, family

2024-02-09 Thread Heinrich Schuchardt
Correct type 1 output * render wake up time as string * print family string * remove duplicate serial number output Signed-off-by: Heinrich Schuchardt --- v2: no change --- cmd/smbios.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git

[PATCH v2 2/2] smbios: fill wake-up type

2024-02-09 Thread Heinrich Schuchardt
We should not use the reserved value 0x00 for the wake up type but use 0x02 (Unknown). Signed-off-by: Heinrich Schuchardt --- v2: use wake-up type 'Unknown' as our default add more SMBIOS wake-up type constants --- include/smbios.h | 10 ++ lib/smbios.c | 1 + 2

[PATCH v2 0/2] smbios: fill wake-up type

2024-02-09 Thread Heinrich Schuchardt
We should not use the reserved value 0x00 for the wake up type but use 0x06 (Power Switch). Correctly display wake-up type in smbios command. Display SMBIOS type 1 field family in smbios command. v2: use wake-up type 0x02 as our default Heinrich Schuchardt (2): cmd: smbios: type 1

[PATCH] button: qcom-pmic: demote "unknown button" message to debug

2024-02-09 Thread Caleb Connolly
This message isn't an error (there can be a watchdog subnode for example) but it shouldn't be printed unless this driver is being debugged. Demote it to a debug print. Signed-off-by: Caleb Connolly --- drivers/button/button-qcom-pmic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] doc/develop/codingstyle.rst: Clarify include section

2024-02-09 Thread Tom Rini
Rework the section about includes slightly. We should not be using common.h anywhere, so remove that from examples and ask people to send patches removing it when found. Doing this also means we need to reword other parts of this section. Be clearer about using alphabetical ordering.

Re: [PATCH 0/2] imx93_var_som: Enable AHAB support

2024-02-09 Thread Fabio Estevam
On Fri, Feb 9, 2024 at 11:25 AM Mathieu Othacehe wrote: > Once the board is closed you can only boot from signed images. If the > signed image is not working (hanging during relocation for instance), > then you can always boot from a new one. All the interfaces: SD-card, > UART, USB are still

Re: [PATCH] Added FDT PAD memory size while reserving memory for FDT to avoid some memory corruption issue

2024-02-09 Thread Selvakumar Velandi
The FDT relocation is not disabled. I am adding the FDT PADDING bytes while doing FDT reservation in the board_f file. Also update the FDT length based on the new allocation, instead of blindly increasing the size. Currently the size is getting increased even for the relocation disabled scenario

Re: [PATCH v2 13/20] rockchip: migrate hardware.h inclusion into appropriate files

2024-02-09 Thread Johan Jonker
On 2/9/24 10:50, Quentin Schulz wrote: > From: Quentin Schulz > > hardware.h is only defining macros which are "wrappers" around writel(). > > writel() is however not available in hardware.h, needs to be > included. This means in order to use the wrappers in hardware.h, one > also needs to

Re: [PATCH v2 13/20] rockchip: migrate hardware.h inclusion into appropriate files

2024-02-09 Thread Quentin Schulz
Hi Johan, On 2/9/24 14:07, Johan Jonker wrote: [...] From codingstyle.rst: You should follow this ordering in U-Boot. The common.h header (which is going away at some point) should always be first, followed by other headers in order, then headers with directories, then local files. Within

[GIT PULL] Please pull u-boot-dfu-20240209

2024-02-09 Thread Mattijs Korpershoek
changes since commit a4650bf65e4b7d3ef04c90ba8031374428e4a682: ti: keystone2: Move common Kconfig selections to under ARCH_KEYSTONE (2024-02-08 14:42:56 -0500) are available in the Git repository at: https://source.denx.de/u-boot/custodians/u-boot-dfu.git tags/u-boot-dfu-20240209 for you

Re: [PATCH] Added FDT PAD memory size while reserving memory for FDT to avoid some memory corruption issue

2024-02-09 Thread Tom Rini
On Fri, Feb 09, 2024 at 01:22:08PM +0530, Selvakumar Velandi wrote: > Hi, > > Issue: > Linux kernel getting crash after loading kernel in VM system using RISCV > QEMU. > > RootCause: > Memory corruption in uboot FDT memory while launching a VM system in RISCV > QEMU. > > Fix: > In the board_f.c

[PATCH] rockchip: ringneck-px30: put STM32_RST line in input mode instead of output

2024-02-09 Thread Quentin Schulz
quot;); return; } } --- base-commit: a4650bf65e4b7d3ef04c90ba8031374428e4a682 change-id: 20240209-ringneck-stm32-rst-input-ca1cdfa67ff5 Best regards, -- Quentin Schulz

Re: [PATCH 3/3] doc: board: Add minimal documentation for Sielaff i.MX6 Solo board

2024-02-09 Thread Fabio Estevam
Hi Frieder, On Thu, Feb 8, 2024 at 1:59 PM Frieder Schrempf wrote: > +Burn the flash.bin to SD card at an offset of 1 KiB: > + > +.. code-block:: bash > + > + $ dd if=flash.bin of=/dev/sd[x] bs=1K seek=1 conv=notrunc I see that you used binman to create the flash.bin file. You could simply

Re: [PATCH 1/2] board: imx93_var_som: Probe ELE MU

2024-02-09 Thread Mathieu Othacehe
Hello, > Please put this prototype into a header file. > > Currently, it appears in 3 imx93 spl.c files. Fixed in the v2 :) Thanks, Mathieu

[PATCH v2 3/3] configs: imx93_var_som: Enable AHAB support

2024-02-09 Thread Mathieu Othacehe
Enable AHAB support in the imx93_var_som configuration. Signed-off-by: Mathieu Othacehe --- configs/imx93_var_som_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/imx93_var_som_defconfig b/configs/imx93_var_som_defconfig index cc0c5a79bc1..14922f2a3e2 100644 ---

[PATCH v2 2/3] board: imx93_var_som: Probe ELE MU

2024-02-09 Thread Mathieu Othacehe
Probing the MU is needed to prevent this error in the SPL: ele dev is not initialized Authenticate container hdr failed, return -19, resp 0x0 IND = INVALID ele dev is not initialized Error: release container failed, resp 0x0! IND = INVALID SPL: failed to boot from all boot devices

[PATCH v2 1/3] imx93: Use a header for imx9_probe_mu declaration

2024-02-09 Thread Mathieu Othacehe
Put imx9_probe_mu declaration in a new mu.h header file. Signed-off-by: Mathieu Othacehe --- arch/arm/include/asm/arch-imx9/mu.h | 13 + board/freescale/imx93_evk/spl.c | 2 +- board/phytec/phycore_imx93/spl.c| 2 +- 3 files changed, 15 insertions(+), 2 deletions(-)

[PATCH v2 0/3] imx93_var_som: Enable AHAB support

2024-02-09 Thread Mathieu Othacehe
Hello, In this v2, I moved imx93_probe_mu to a dedicated header. Thanks, Mathieu Changelog: v2: Move imx93_probe_mu declaration to a header file Link to the previous revision: v1: https://lists.denx.de/pipermail/u-boot/2024-February/545528.html Mathieu Othacehe (3): imx93: Use a header for

[PATCH] configs: am64x_evm_r5_defconfig: enlarge simple malloc pool

2024-02-09 Thread Thomas Weißschuh
CONFIG_SPL_STACK_R=y +CONFIG_SPL_STACK_R_MALLOC_SIMPLE_LEN=0x40 CONFIG_SPL_SEPARATE_BSS=y CONFIG_SPL_SYS_MALLOC=y CONFIG_SPL_HAS_CUSTOM_MALLOC_START=y --- base-commit: a4650bf65e4b7d3ef04c90ba8031374428e4a682 change-id: 20240209-am64x_evm_r5_defconfig-malloc-simple-len-b1e36478e431 Best regards

Re: [PATCH 0/2] imx93_var_som: Enable AHAB support

2024-02-09 Thread Mathieu Othacehe
Hello Fabio, > Just wanted to make sure I understand: if someone programs the fuse to > close the board, > it will fail to boot U-Boot proper and this means that the board is > bricked. Is this correct? No. I fused the board and with this series applied and the three HAFDBS commits reverted, I

[PATCH] Added FDT PAD memory size while reserving memory for FDT to avoid some memory corruption issue

2024-02-09 Thread Selvakumar Velandi
Hi, Issue: Linux kernel getting crash after loading kernel in VM system using RISCV QEMU. RootCause: Memory corruption in uboot FDT memory while launching a VM system in RISCV QEMU. Fix: In the board_f.c file the FDT memory region is reserved without FDT padding bytes. uboot will add some

Re: [PATCH 0/2] imx93_var_som: Enable AHAB support

2024-02-09 Thread Fabio Estevam
Hi Mathieu, On Fri, Feb 9, 2024 at 5:05 AM Mathieu Othacehe wrote: > No. I fused the board and with this series applied and the three HAFDBS > commits reverted, I can boot just fine on that board. Yes, this part I understood. > Without reverting those commits, the SPL is working fine and

Re: [AVB/AB] Overhaul plans

2024-02-09 Thread Mattijs Korpershoek
Hi Igor, On ven., févr. 09, 2024 at 11:14, Igor Opaniuk wrote: > Hi everyone, > > I'm currently planning a big overhaul of the current implementation of > AVB/AB in U-Boot during the 2024 year, which I have barely touched since > 2019. I used to believe that it was stillborn, but looks like

[AVB/AB] Overhaul plans

2024-02-09 Thread Igor Opaniuk
Hi everyone, I'm currently planning a big overhaul of the current implementation of AVB/AB in U-Boot during the 2024 year, which I have barely touched since 2019. I used to believe that it was stillborn, but looks like it's being actively used now by some SoC vendors and Google folks [1][2].

[PATCH v5] misc: fs-loader: Use fw_storage_interface instead of storage_interface

2024-02-09 Thread MD Danish Anwar
The fs-loader driver reads env storage_interface and uses it to load firmware file into memory using the medium set by env. Update the driver to use env fw_storage_interface as this variable is only used to load firmwares. This is to keep all variables used by fs-loader driver with 'fw_' prefix.

Re: [PATCH v1 4/7] cmd: avb: rework prints

2024-02-09 Thread Igor Opaniuk
Hi Mattijs, On Thu, Feb 8, 2024 at 3:00 PM Mattijs Korpershoek wrote: > > Hi Igor, > > Thank you for the patch. > > On mar., févr. 06, 2024 at 23:31, Igor Opaniuk > wrote: > > > From: Igor Opaniuk > > > > Introduce AVB_OPS_CHECK macro for checking AvbOps before using > > it to avoid code

[PATCH v2 20/20] rockchip: ringneck_px30: update website link

2024-02-09 Thread Quentin Schulz
From: Quentin Schulz The original link returns a custom 404, so let's point to a link that works today instead. Cc: Quentin Schulz Signed-off-by: Quentin Schulz --- board/theobroma-systems/ringneck_px30/MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v1 7/7] doc: android: avb: add slot_suffix param details

2024-02-09 Thread Igor Opaniuk
Hi Mattijs, On Thu, Feb 8, 2024 at 3:12 PM Mattijs Korpershoek wrote: > > Hi Igor, > > Thank you for the patch. > > On mar., févr. 06, 2024 at 23:31, Igor Opaniuk > wrote: > > > From: Igor Opaniuk > > > > Add info about slot_suffix param for avb verify. > > > > Signed-off-by: Igor Opaniuk >

[PATCH v2 19/20] rockchip: ringneck_px30: migrate README to doc/board in rST format

2024-02-09 Thread Quentin Schulz
From: Quentin Schulz This migrates the plaintext README in board/theobroma-systems/ringneck_px30 to doc/board/theobroma-systems and while doing so, update the instructions and rewrite it in rST. Cc: Quentin Schulz Signed-off-by: Quentin Schulz ---

[PATCH v2 18/20] rockchip: rk3399-puma: migrate README to doc/board in rST format

2024-02-09 Thread Quentin Schulz
From: Quentin Schulz This migrates the plaintext README in board/theobroma-systems/puma_rk3399 to doc/board/theobroma-systems and while doing so, update the instructions and rewrite it in rST. Cc: Quentin Schulz Signed-off-by: Quentin Schulz ---

[PATCH v2 17/20] rockchip: puma-rk3399: MAINTAINERS: use glob for dtses

2024-02-09 Thread Quentin Schulz
From: Quentin Schulz There are multiple Device Trees in U-Boot git repo for Puma, so let's make the MAINTAINERS entry match them all. Cc: Quentin Schulz Signed-off-by: Quentin Schulz --- board/theobroma-systems/puma_rk3399/MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH v2 16/20] board: rockchip: add Theobroma-Systems RK3588 Jaguar SBC

2024-02-09 Thread Quentin Schulz
From: Quentin Schulz JAGUAR is a Single-Board Computer (SBC) based around the rk3588 SoC and is targeting Autonomous Mobile Robots (AMR). It features: * LPDDR4X (up to 16GB) * 1Gbps Ethernet on RJ45 connector (KSZ9031 or KSZ9131) * PCIe 3.0 4-lane on M.2 M-key connector * PCIe 2.1 1-lane on

[PATCH v2 15/20] rockchip: rk3588: bind MMC controllers in U-Boot proper pre-reloc

2024-02-09 Thread Quentin Schulz
From: Quentin Schulz Since commit 9e644284ab81 ("dm: core: Report bootph-pre-ram/sram node as pre-reloc after relocation"), bootph-pre-ram doesn't make U-Boot proper bind the device before relocation. While this is usually not much of an issue, it is when there's a lookup for devices by code

[PATCH v2 14/20] rockchip: include asm/io.h directly in asm/arch-rockchip/hardware.h

2024-02-09 Thread Quentin Schulz
From: Quentin Schulz The different macros use writel which is defined in asm/io.h, so let's include the header so users of hardware.h do not need to include asm/io.h as well. While at it, remove asm/io.h includes wherever asm/arch-rockchip/hardware.h is included already. Cc: Quentin Schulz

[PATCH v2 13/20] rockchip: migrate hardware.h inclusion into appropriate files

2024-02-09 Thread Quentin Schulz
From: Quentin Schulz hardware.h is only defining macros which are "wrappers" around writel(). writel() is however not available in hardware.h, needs to be included. This means in order to use the wrappers in hardware.h, one also needs to include the header. However, this cannot be done

[PATCH v2 12/20] rockchip: rk3588: add constants for some register address spaces

2024-02-09 Thread Quentin Schulz
From: Quentin Schulz It's one thing to have the register mapped via a well-defined struct but it's another to be able to make use of it. For that to happen, one needs to cast the physical address memory of the beginning of the register address space with the struct. Since this cannot change,

[PATCH v2 11/20] rockchip: rk3588: fix non-working SD controller if booting from other media

2024-02-09 Thread Quentin Schulz
From: Quentin Schulz Rockchip SoCs have some jtag/sdmmc autoswitching that simply doesn't work really well.[00] The Linux kernel disables it for all SoCs[01], so U-Boot needs to do the same in order to fix issues related to SD card on RK3588. This autoswitching is enabled (by default) via the

[PATCH v2 10/20] rockchip: transform rockchip_capsule_update_board_setup into a weak function symbol

2024-02-09 Thread Quentin Schulz
From: Quentin Schulz There's only one user of rockchip_capsule_update_board_setup, which is in board.c, and only one board defines it, so instead of having a header only for one function symbol, let's just use a weak symbol instead. Cc: Quentin Schulz Reviewed-by: Kever Yang Signed-off-by:

[PATCH v2 09/20] rockchip: merge misc.c into board.c

2024-02-09 Thread Quentin Schulz
From: Quentin Schulz The functions aren't used anywhere else than in board.c, therefore, let's not expose them anymore at all. This merges misc.c and board.c together and removes the functions from the misc.h header file. Cc: Quentin Schulz Reviewed-by: Kever Yang Signed-off-by: Quentin

[PATCH v2 08/20] rockchip: theobroma-systems: ringneck: migrate to rockchip_early_misc_init_r

2024-02-09 Thread Quentin Schulz
From: Quentin Schulz Only setup_boottargets differs from the original misc_init_r from Rockchip mach code, so let's use rockchip_early_misc_init_r instead of reimplementing the whole misc_init_r from Rockchip. Cc: Quentin Schulz Reviewed-by: Kever Yang Signed-off-by: Quentin Schulz ---

[PATCH v2 07/20] rockchip: theobroma-systems: puma: migrate to rockchip_early_misc_init_r

2024-02-09 Thread Quentin Schulz
From: Quentin Schulz Only setup_iodomain() and setup_boottargets differ from the original misc_init_r from Rockchip mach code, so let's use rockchip_early_misc_init_r instead of reimplementing the whole misc_init_r from Rockchip. Cc: Quentin Schulz Reviewed-by: Kever Yang Signed-off-by:

[PATCH v2 06/20] rockchip: pine64: rockpro64: migrate to rockchip_early_misc_init_r

2024-02-09 Thread Quentin Schulz
From: Quentin Schulz Only setup_iodomain() differs from the original misc_init_r from Rockchip mach code, so let's use rockchip_early_misc_init_r instead of reimplementing the whole misc_init_r from Rockchip. Cc: Quentin Schulz Reviewed-by: Kever Yang Signed-off-by: Quentin Schulz ---

[PATCH v2 05/20] rockchip: pine64: pinephone-pro: migrate to rockchip_early_misc_init_r

2024-02-09 Thread Quentin Schulz
From: Quentin Schulz Compared to the original misc_init_r from Rockchip mach code, setup_iodomain() is added and rockchip_setup_macaddr() is not called. It is assumed adding rockchip_setup_macaddr() back is fine. Let's use rockchip_early_misc_init_r instead of reimplementing the whole

[PATCH v2 04/20] rockchip: pine64: pinebook-pro: migrate to rockchip_early_misc_init_r

2024-02-09 Thread Quentin Schulz
From: Quentin Schulz Compared to the original misc_init_r from Rockchip mach code, setup_iodomain() is added and rockchip_setup_macaddr() is not called. It is assumed adding rockchip_setup_macaddr() back is fine. Let's use rockchip_early_misc_init_r instead of reimplementing the whole

[PATCH v2 03/20] rockchip: google: gru: migrate to rockchip_early_misc_init_r

2024-02-09 Thread Quentin Schulz
From: Quentin Schulz Only setup_iodomain() differs from the original misc_init_r from Rockchip mach code, so let's use rockchip_early_misc_init_r instead of reimplementing the whole misc_init_r from Rockchip. Cc: Quentin Schulz Reviewed-by: Kever Yang Signed-off-by: Quentin Schulz ---

[PATCH v2 00/20] rockchip: add support for Theobroma JAGUAR SBC-RK3588-AMR

2024-02-09 Thread Quentin Schulz
This adds all the necessary bits for adding support for Theobroma's new SBC. JAGUAR is a Single-Board Computer (SBC) based around the rk3588 SoC and is targeting Autonomous Mobile Robots (AMR). It features: * LPDDR4X (up to 16GB) * 1Gbps Ethernet on RJ45 connector (KSZ9031 or KSZ9131) * PCIe

[PATCH v2 02/20] rockchip: add weak function symbol called at the beginning of misc_init_r

2024-02-09 Thread Quentin Schulz
From: Quentin Schulz Most Rockchip boards who override misc_init_r do it only to call another function and keep the rest unchanged. Therefore to allow for less duplication, let's just add a weak function symbol that is called inside misc_init_r. Cc: Quentin Schulz Reviewed-by: Kever Yang

[PATCH v2 01/20] rockchip: avoid out-of-bounds when computing cpuid

2024-02-09 Thread Quentin Schulz
From: Quentin Schulz The expected length of the cpuid, as passed with cpuid_length, determines the size of cpuid_str string. Therefore, care should be taken to make sure nothing is accessing data out-of-bounds. Instead of using hardcoded values, derive them from cpuid_length. Cc: Quentin

[PATCH 2/4] ARM: dts: at91: sama7g54_curiosity: Add initial device tree of the board

2024-02-09 Thread Mihai Sain
Add initial device tree of the SAMA7G54 Curiosity board. Signed-off-by: Mihai Sain --- arch/arm/dts/Makefile | 3 + .../dts/at91-sama7g54_curiosity-u-boot.dtsi | 59 + arch/arm/dts/at91-sama7g54_curiosity.dts | 246 ++ 3 files changed, 308

[PATCH 3/4] board: at91: sama7g54_curiosity: Add initial board support

2024-02-09 Thread Mihai Sain
Add initial support for SAMA7G54 Curiosity board. Hardware: SoC: SAMA7G54D2G SiP 1000 MHz DRAM: DDR3 256 MiB PMIC: MCP16502 Debug: UART3 Flash: QSPI NOR 8 MiB, SLC NAND 512 MiB M.2 slot for wireless Mikrobus connectors x 2 SD-Card connectors x 1 USB 2.0 x 3 Signed-off-by: Mihai Sain ---

[PATCH 4/4] configs: at91: sama7g54_curiosity: Add initial default configs

2024-02-09 Thread Mihai Sain
Add default configuration for nand-flash to boot the linux kernel. Add default configuration for qspi-flash to boot the linux kernel. Add default configuration for sdcard to boot the linux kernel. Configs are synced with savedefconfig. Signed-off-by: Mihai Sain ---

[PATCH 1/4] ARM: dts: at91: sama7g5: add flexcom 10 node

2024-02-09 Thread Mihai Sain
Add flexcom 10 node for usage on the SAMA7G54 Curiosity board. Signed-off-by: Mihai Sain --- arch/arm/dts/sama7g5.dtsi | 26 ++ 1 file changed, 26 insertions(+) diff --git a/arch/arm/dts/sama7g5.dtsi b/arch/arm/dts/sama7g5.dtsi index 746a5ba347..01e880aabe 100644 ---

[PATCH 0/4] Add initial support for Microchip SAMA7G54 Curiosity board

2024-02-09 Thread Mihai Sain
This patch series adds initial support for Microchip SAMA7G54 Curiosity board. Mihai Sain (4): ARM: dts: at91: sama7g5: add flexcom 10 node ARM: dts: at91: sama7g54_curiosity: Add initial device tree of the board board: at91: sama7g54_curiosity: Add initial board support configs: at91:

Re: [PATCH v4] misc: fs-loader: Use fw_storage_interface instead of storage_interface

2024-02-09 Thread MD Danish Anwar
On 08/02/24 5:28 pm, Roger Quadros wrote: > > > On 08/02/2024 07:19, MD Danish Anwar wrote: >> Hi Sean, >> >> On 07/02/24 11:14 pm, Sean Anderson wrote: >>> On 1/30/24 01:26, MD Danish Anwar wrote: The fs-loader driver reads env storage_interface and uses it to load firmware file

Re: [PATCH v1 6/7] cmd: avb: rework do_avb_verify_part

2024-02-09 Thread Mattijs Korpershoek
Hi Igor, Thank you for the patch. On mar., févr. 06, 2024 at 23:31, Igor Opaniuk wrote: > From: Igor Opaniuk > > Use existing str_avb_slot_error() function for obtaining > verification fail reason details. > Take into account device lock state for setting correct >

Re: [PATCH v4] remoteproc: uclass: Add methods to load firmware to rproc and boot rproc

2024-02-09 Thread MD Danish Anwar
On 07/02/24 6:27 pm, Anwar, Md Danish wrote: > On 2/7/2024 6:05 PM, Roger Quadros wrote: >> >> >> On 07/02/2024 09:15, MD Danish Anwar wrote: >>> Hi Roger >>> >>> On 06/02/24 7:11 pm, Roger Quadros wrote: On 06/02/2024 07:31, MD Danish Anwar wrote: > > > On 05/02/24 6:07

[PATCH] configs: khadas-vim3*_android: fix AVB oom error

2024-02-09 Thread Mattijs Korpershoek
"khadas-vim3l_android" CONFIG_ARCH_MESON=y CONFIG_TEXT_BASE=0x0100 +CONFIG_SYS_MALLOC_LEN=0x0800 CONFIG_NR_DRAM_BANKS=1 CONFIG_HAS_CUSTOM_SYS_INIT_SP_ADDR=y CONFIG_CUSTOM_SYS_INIT_SP_ADDR=0x2000 --- base-commit: 076529725f16f07a5cb2d5feba25d62b5f5a5872 change-id: 20240209-vim3-avb-malloc-aa3de534d6a0 Best regards, -- Mattijs Korpershoek

Re: [PATCH] xilinx: zynqmp: Add the missing function prototype

2024-02-09 Thread Michal Simek
On 2/7/24 12:30, Michal Simek wrote: On 2/7/24 09:33, Venkatesh Yadav Abbarapu wrote: Add missing prototype to fix the below sparse warning warning: no previous prototype for 'spl_spi_get_uboot_offs' [-Wmissing-prototypes] Signed-off-by: Venkatesh Yadav Abbarapu ---