Re: [PATCH v2 06/15] rockchip: rk3328-nanopi-r2: Update defconfig

2024-02-16 Thread Tianling Shen
Hi Jonas, On Sat, Feb 17, 2024 at 8:23 AM Jonas Karlman wrote: > > Update defconfig for rk3328-nanopi-r2* boards with new defaults. > > Remove the SPL_DRIVERS_MISC=y option, no misc driver is used in SPL. > > Add CONFIG_SPL_FIT_SIGNATURE=y to let SPL verify an auto generated hash > of FIT

Re: [PATCH V6 07/20] configs: am62x_evm_a53_defconfig: Switch to bootstd

2024-02-16 Thread Alexander Sverdlin
Hello Nishanth, On Fri, 2023-08-25 at 13:02 -0500, Nishanth Menon wrote: > Switch to using bootstd. Note with this change, we will stop using > distro_bootcmd and instead depend entirely on bootflow method of > starting the system up. > > Suggested-by: Tom Rini > Suggested-by: Simon Glass >

[PATCH v2 1/2] rockchip: rk3328: Update stack addresses

2024-02-16 Thread Jonas Karlman
With the stack and text base used by U-Boot SPL and proper on RK3328 there is a high likelihood of overlapping when U-Boot proper + FDT nears 1 MiB in size. Currently the following memory layout is used: - 0x (@0 MiB): U-Boot SPL text base - 0x0004 (@256 KiB): TF-A - 0x0020 (@2

[PATCH v2 2/2] rockchip: rk3399: Update stack and bss addresses

2024-02-16 Thread Jonas Karlman
With the stack and text base used by U-Boot SPL and proper on RK3399 there is a high likelihood of overlapping when U-Boot proper + FDT nears 1 MiB in size. Currently the following memory layout is used: - 0x (@0 MiB): U-Boot SPL text base - 0x0004 (@256 KiB): TF-A - 0x0020 (@2

[PATCH v2 0/2] rockchip: Update stack and bss addresses on RK3328 and RK3399

2024-02-16 Thread Jonas Karlman
With the stack and text base used by U-Boot SPL and proper on RK3328 and RK3399 there is a high likelihood of overlapping when U-Boot proper + FDT nears 1 MiB in size. Trying to run U-Boot proper close to 1 MiB in size with debug logging something similar to following can be observed: FDT

[PATCH v2 10/15] rng: rockchip: Use same compatible as linux

2024-02-16 Thread Jonas Karlman
Replace the rockchip,cryptov1-rng compatible with compatibles used in the linux device tree for RK3288, RK3328 and RK3399 to ease sync of SoC device tree from linux. Signed-off-by: Jonas Karlman Reviewed-by: Heinrich Schuchardt --- v2: - No change - Collect r-b tag ---

[PATCH v2 13/15] rockchip: rk3328: Add support to build bootable SPI image

2024-02-16 Thread Jonas Karlman
Similar to RK35xx the BootRom in RK3328 can read all data and look for idbloader at 0x8000, same as it does for SD and eMMC. Use the rksd format and modify the mkimage offset to generate a bootable u-boot-rockchip-spi.bin that can be written to 0x0 of SPI NOR flash. Signed-off-by: Jonas Karlman

[PATCH v2 15/15] rockchip: rk3328-orangepi-r1-plus: Enable boot from SPI NOR flash

2024-02-16 Thread Jonas Karlman
Add Kconfig options to enable support for booting from SPI NOR flash on Orange Pi R1 Plus boards. The generated bootable u-boot-rockchip-spi.bin can be written to 0x0 of SPI NOR flash. The FIT image is loaded from 0x6, same as on RK35xx boards. => sf probe SF: Detected zb25vq128 with

[PATCH v2 14/15] rockchip: rk3328-rock64: Enable boot from SPI NOR flash

2024-02-16 Thread Jonas Karlman
Add Kconfig options to enable support for booting from SPI NOR flash on Pine64 Rock64. The generated bootable u-boot-rockchip-spi.bin can be written to 0x0 of SPI NOR flash. The FIT image is loaded from 0x6, same as on RK35xx boards. => sf probe SF: Detected gd25q128 with page size 256

[PATCH v2 12/15] Revert "rockchip: Allow booting from SPI"

2024-02-16 Thread Jonas Karlman
This reverts commit 3523c07867b403d5b3b68812aebac8a5afa5be4c. Booting from SPI was already allowed before this commit was first introduced. A few lines further down the exact same code already existed and still does. Signed-off-by: Jonas Karlman --- v2: - No change ---

[PATCH v2 08/15] rockchip: rk3328: Fix loading FIT from SD-card when booting from eMMC

2024-02-16 Thread Jonas Karlman
When RK3328 boards run SPL from eMMC and fail to load FIT from eMMC due to it being missing or checksum validation fails there is a fallback to read FIT from SD-card. However, without proper pinctrl configuration reading FIT from SD-card will fail: U-Boot SPL 2024.04-rc1 (Feb 05 2024 - 22:18:22

[PATCH v2 07/15] rockchip: rk3328-orangepi-r1-plus: Update defconfig

2024-02-16 Thread Jonas Karlman
Update defconfig for rk3328-orangepi-r1-plus boards with new defaults. Remove the SPL_DRIVERS_MISC=y option, no misc driver is used in SPL. Add CONFIG_SPL_FIT_SIGNATURE=y to let SPL verify an auto generated hash of FIT images. This help indicate if there is an issue loading any of the images to

[PATCH v2 11/15] rockchip: rk3328: Sync device tree from linux v6.8-rc1

2024-02-16 Thread Jonas Karlman
Sync rk3328 device tree from linux v6.8-rc1. Signed-off-by: Jonas Karlman --- v2: - No change --- arch/arm/dts/rk3328-evb.dts | 1 + arch/arm/dts/rk3328-nanopi-r2s.dts | 3 +- arch/arm/dts/rk3328-orangepi-r1-plus-lts.dts | 4 +-

[PATCH v2 09/15] gpio: rockchip: Use gpio alias id as gpio bank id

2024-02-16 Thread Jonas Karlman
The U-Boot driver try to base the gpio bank id on the gpio-ranges prop and fall back to base the bank id on the node name. However, the linux driver try to base the bank id on the gpio alias id and fall back on node order. This can cause issues when SoC DT is synced from linux and gpioX@ nodes

[PATCH v2 06/15] rockchip: rk3328-nanopi-r2: Update defconfig

2024-02-16 Thread Jonas Karlman
Update defconfig for rk3328-nanopi-r2* boards with new defaults. Remove the SPL_DRIVERS_MISC=y option, no misc driver is used in SPL. Add CONFIG_SPL_FIT_SIGNATURE=y to let SPL verify an auto generated hash of FIT images. This help indicate if there is an issue loading any of the images to DRAM

[PATCH v2 05/15] rockchip: rk3328-rock-pi-e: Update defconfig

2024-02-16 Thread Jonas Karlman
Update defconfig for rk3328-rock-pi-e with new defaults. Remove the xPL_DRIVERS_MISC=y option, no misc driver is used in xPL. Add CONFIG_SPL_FIT_SIGNATURE=y to let SPL verify an auto generated hash of FIT images. This help indicate if there is an issue loading any of the images to DRAM or SRAM.

[PATCH v2 02/15] rockchip: rk3328-evb: Update defconfig

2024-02-16 Thread Jonas Karlman
Update defconfig for rk3328-evb with new defaults. Add DM_RESET=y to support using reset signals. Remove the xPL_DRIVERS_MISC=y option, no misc driver is used in xPL. Add CONFIG_SPL_FIT_SIGNATURE=y to let SPL verify an auto generated hash of FIT images. This help indicate if there is an issue

[PATCH v2 04/15] rockchip: rk3328-roc-cc: Update defconfig

2024-02-16 Thread Jonas Karlman
Update defconfig for rk3328-roc-cc with new defaults. Remove the SPL_DRIVERS_MISC=y option, no misc driver is used in SPL. Add CONFIG_SPL_FIT_SIGNATURE=y to let SPL verify an auto generated hash of FIT images. This help indicate if there is an issue loading any of the images to DRAM or SRAM.

[PATCH v2 03/15] rockchip: rk3328-rock64: Update defconfig

2024-02-16 Thread Jonas Karlman
Update defconfig for rk3328-rock64 with new defaults. Remove the SPL_DRIVERS_MISC=y option, no misc driver is used in SPL. Add CONFIG_SPL_FIT_SIGNATURE=y to let SPL verify an auto generated hash of FIT images. This help indicate if there is an issue loading any of the images to DRAM or SRAM.

[PATCH v2 00/15] rockchip: rk3328: Update defconfigs, DTs and enable boot from SPI

2024-02-16 Thread Jonas Karlman
This series contains miscellaneous updates to defconfigs, syncs latest device trees from linux, fixes an issue loading FIT from SD-card when running SPL from eMMC and enables building a bootable SPI image on RK3328 boards. I am also adding myself as a reviewer for the three RK3328 boards I own.

[PATCH v2 01/15] rockchip: rk3328: Update default u-boot, spl-boot-order prop

2024-02-16 Thread Jonas Karlman
Change to use a common FIT load order, same-as-spl > SD-card > eMMC on RK3328 boards. Only EVB and Radxa ROCK Pi E is affected by this change. Signed-off-by: Jonas Karlman Reviewed-by: Dragan Simic --- v2: - No change - Collect r-b tag --- arch/arm/dts/rk3328-nanopi-r2c-plus-u-boot.dtsi |

[PATCH 1/1] clk: sifive: avoid declaring static variables in includes

2024-02-16 Thread Heinrich Schuchardt
The existing code is unnecessarily convoluted: Arrays __prci_init_clocks_fu[5|7]40 are initialized with data. In separate includes fu[5|7]40-prci.h the size of the arrays is provided as constants. By moving the structures prci_clk_fu[5|7]40 to the respective code modules we can directly use

[PATCH] video: simplefb: modernise DT parsing

2024-02-16 Thread Caleb Connolly
simplefb was using old style FDT parsing which doesn't behave well in combination with livetree. Update it to use ofnode instead and add a missing null check for the "format" property. Standardise the error logging while we're here. Fixes: 971d7e64245d ("video: simplefb") Signed-off-by: Caleb

Re: [PATCH v4 19/39] board: dragonboard820c: use LINUX_KERNEL_IMAGE_HEADER

2024-02-16 Thread Ilias Apalodimas
On Thu, Feb 15, 2024 at 08:52:37PM +, Caleb Connolly wrote: > db820c predated support for prepending the kernel image header > automatically, drop it's custom linker script and head.S in favour of > this generic support. > > Reviewed-by: Neil Armstrong > Signed-off-by: Caleb Connolly > --- >

[PATCH] clk: sifive: check wrpll_configure_for_rate() return value

2024-02-16 Thread Heinrich Schuchardt
wrpll_configure_for_rate() might fail. We should check the return value. Fixes: d56d79ed27c6 ("drivers: clk: add fu740 support") Signed-off-by: Heinrich Schuchardt --- drivers/clk/sifive/sifive-prci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH 1/1] clk: sifive: append missing \n to messages

2024-02-16 Thread Heinrich Schuchardt
If multiple messages are written, line-feeds improve the readability. Fixes: c40b6df87fc0 ("clk: Add SiFive FU540 PRCI clock driver") Signed-off-by: Heinrich Schuchardt --- drivers/clk/analogbits/wrpll-cln28hpc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH] arm64: zynqmp: Support semhosting boot method

2024-02-16 Thread Sean Anderson
On 2/16/24 11:03, Sean Anderson wrote: > On 2/16/24 10:06, Michal Simek wrote: >> >> >> On 2/16/24 14:48, Michal Simek wrote: >>> >>> >>> On 2/15/24 20:31, Sean Anderson wrote: On 2/15/24 14:08, Michal Simek wrote: > > > On 2/15/24 18:19, Sean Anderson wrote: >> Currently,

Re: [PATCH] arm64: zynqmp: Support semhosting boot method

2024-02-16 Thread Sean Anderson
On 2/16/24 10:06, Michal Simek wrote: > > > On 2/16/24 14:48, Michal Simek wrote: >> >> >> On 2/15/24 20:31, Sean Anderson wrote: >>> On 2/15/24 14:08, Michal Simek wrote: On 2/15/24 18:19, Sean Anderson wrote: > Currently, when we boot from JTAG we try to boot U-Boot from RAM.

Re: [PATCH v8 12/16] arm: dts: Introduce j784s4 u-boot dts files

2024-02-16 Thread Nishanth Menon
On 14:33-20240215, Neha Malcom Francis wrote: [...] > > if the templates are abstract enough, the additional code will be so > > minimal that we wont need a board-binman.dtsi - just u-boot.dtsi and > > r5.dtsi can include the relevant templates. > > > > Hope this helps. > > > So I took a stab

Re: [PATCH 2/2] doc: Rework the gcc section to reflect general build instructions

2024-02-16 Thread Tom Rini
On Fri, Feb 16, 2024 at 04:00:27PM +0100, Heinrich Schuchardt wrote: > On 16.02.24 2:18 PM, Tom Rini wrote: > > On Fri, Feb 16, 2024 at 12:20:14AM +0100, Heinrich Schuchardt wrote: > > > > > > > > > Am 15. Februar 2024 23:00:32 MEZ schrieb Tom Rini : > > > > On Thu, Feb 15, 2024 at 10:53:59PM

Re: [PATCH] arm64: zynqmp: Support semhosting boot method

2024-02-16 Thread Michal Simek
On 2/16/24 14:48, Michal Simek wrote: On 2/15/24 20:31, Sean Anderson wrote: On 2/15/24 14:08, Michal Simek wrote: On 2/15/24 18:19, Sean Anderson wrote: Currently, when we boot from JTAG we try to boot U-Boot from RAM. However, this is a bit tricky to time, since the debugger has to

Re: [PATCH 2/2] doc: Rework the gcc section to reflect general build instructions

2024-02-16 Thread Heinrich Schuchardt
On 16.02.24 2:18 PM, Tom Rini wrote: On Fri, Feb 16, 2024 at 12:20:14AM +0100, Heinrich Schuchardt wrote: Am 15. Februar 2024 23:00:32 MEZ schrieb Tom Rini : On Thu, Feb 15, 2024 at 10:53:59PM +0100, Heinrich Schuchardt wrote: Am 15. Februar 2024 22:28:24 MEZ schrieb Tom Rini : On Thu,

Re: [PATCH] efi_loader: Don't carve out memory reservations too early

2024-02-16 Thread Mark Kettenis
> Date: Fri, 16 Feb 2024 00:38:25 +0100 > From: Heinrich Schuchardt > > Am 16. Februar 2024 00:25:34 MEZ schrieb Mark Kettenis : > >Moving the efi_carve_out_dt_rsv() call in commit 1be415b21b2d > >("efi_loader: create memory reservations in ACPI case") > >broke boards that create additional

Re: [PATCH] arm64: zynqmp: Support semhosting boot method

2024-02-16 Thread Michal Simek
On 2/15/24 20:31, Sean Anderson wrote: On 2/15/24 14:08, Michal Simek wrote: On 2/15/24 18:19, Sean Anderson wrote: Currently, when we boot from JTAG we try to boot U-Boot from RAM. However, this is a bit tricky to time, since the debugger has to wait for SPL to initialize RAM before it

Re: [PATCH 2/2] doc: Rework the gcc section to reflect general build instructions

2024-02-16 Thread Tom Rini
On Fri, Feb 16, 2024 at 10:10:19AM +, Paul Barker wrote: > On 15/02/2024 21:10, Tom Rini wrote: > > The first big issue is that the "gcc" file talked a lot about the > > general build requirements as well, but was titled in a gcc-centric > > manner. Solve this by renaming the file to

Re: [PATCH 1/2] doc: Update our clang documentation to reflect current status

2024-02-16 Thread Tom Rini
On Fri, Feb 16, 2024 at 10:06:03AM +, Paul Barker wrote: > On 15/02/2024 21:10, Tom Rini wrote: > > First, since this document was written the biggest challenges at the > > time are simply not applicable anymore. Second, we need to list the > > challenges which are preventing more platforms

Re: [PATCH 2/2] doc: Rework the gcc section to reflect general build instructions

2024-02-16 Thread Tom Rini
On Fri, Feb 16, 2024 at 12:20:14AM +0100, Heinrich Schuchardt wrote: > > > Am 15. Februar 2024 23:00:32 MEZ schrieb Tom Rini : > >On Thu, Feb 15, 2024 at 10:53:59PM +0100, Heinrich Schuchardt wrote: > >> > >> > >> Am 15. Februar 2024 22:28:24 MEZ schrieb Tom Rini : > >> >On Thu, Feb 15, 2024

Re:Re: [PATCH v2 1/2] board: rockchip: Add support for rk3588s based Cool Pi 4B

2024-02-16 Thread Andy Yan
Hi Quentin: 在 2024-02-15 20:42:56,"Quentin Schulz" 写道: >Hi Andy, > >On 2/15/24 12:55, Andy Yan wrote: >> [You don't often get email from andys...@163.com. Learn why this is >> important at https://aka.ms/LearnAboutSenderIdentification ] >> >> Hi Quentin: >> At 2024-02-15 18:40:25, "Quentin

Re: [PATCH v5 08/11] doc: devicetree: Updates for devicetree-rebasing subtree

2024-02-16 Thread Paul Barker
On 14/02/2024 13:32, Sumit Garg wrote: > On Wed, 14 Feb 2024 at 03:01, Paul Barker > wrote: >> On 02/02/2024 13:05, Sumit Garg wrote: >>> +Dependencies >>> + >>> + >>> +The DT schema project must be installed in order to validate the DT schema >>> +binding documents and validate DTS

[PATCH] dma: ti: k3-udma: Fix error handling for setup_resources() in udma_probe()

2024-02-16 Thread Siddharth Vadapalli
In udma_probe() the return value of setup_resources() is stored in the u32 "ch_count" member of "struct udma_dev", due to which any negative return value which indicates an error is masked. Fix this by storing the return value of setup_resources() in the already declared integer variable "ret",

Re: [PATCH 1/1] arm: separate .data and .text sections of EFI binaries

2024-02-16 Thread Ilias Apalodimas
Hi Heinrich, [...] > } > + .rela.dyn : { *(.rela.dyn) } > + .rela.plt : { *(.rela.plt) } > + .rela.got : { *(.rela.got) } > + .rela.data : { *(.rela.data) *(.rela.data*) } Why are we switching from Rel to Rela? > _etext = .; > _text_size = . -

Re: [PATCH 2/2] doc: Rework the gcc section to reflect general build instructions

2024-02-16 Thread Paul Barker
On 15/02/2024 21:10, Tom Rini wrote: > The first big issue is that the "gcc" file talked a lot about the > general build requirements as well, but was titled in a gcc-centric > manner. Solve this by renaming the file to compile.rst and more fully > reflecting that it is general build instructions.

Re: [PATCH 1/2] doc: Update our clang documentation to reflect current status

2024-02-16 Thread Paul Barker
On 15/02/2024 21:10, Tom Rini wrote: > First, since this document was written the biggest challenges at the > time are simply not applicable anymore. Second, we need to list the > challenges which are preventing more platforms from being able to be > built with Clang today. Next, we update the

Re: [PATCH v5] rng: Add Turris Mox rTWM RNG driver

2024-02-16 Thread Stefan Roese
On 2/15/24 17:57, Max Resch wrote: A RNG driver for Armada 3720 boards running the Turris Mox rWTM firmware from CZ.NIC in the secure processor. Signed-off-by: Max Resch --- Changes in v5: - check return code turris_rwtm_rng_fill_entropy - remove empty line Changes in v4: -