Re: [PATCH] ram: rockchip: px30: Replace misleading log message

2024-04-17 Thread Łukasz Czechowski
Hi Quentin, Maybe I was a little too fast with submitting this patch. My original point of this commit was to get rid of the message "out", that is printed without any context every time the board boots, or at least replace it with something more descriptive, similarly like it is done with other

Re: [PATCH v2] rockchip: px30-board-tpl: Use CONFIG_TPL_BANNER_PRINT flag

2024-04-17 Thread Łukasz Czechowski
Hi Quentin, Thanks for your response. As for the CONFIG_TPL_SERIAL flag, I agree that it should use 'imply' to be allowed to disable it, to silence the serial in TPL. However, currently, disabling this flag makes the code unbuildable (which could be the reason 'select' is used). I'd keep this

Re: [PATCH] rockchip: px30-board-tpl: Use CONFIG_TPL_BANNER_PRINT flag

2024-04-17 Thread Łukasz Czechowski
Hi Quentin, Thanks for the hints. Matching the parent ifdef with non-PX30 TPL implementation is indeed a good idea. I'll send the updated version of the patch. Best regards, Lukasz wt., 16 kwi 2024 o 15:22 Quentin Schulz napisał(a): > > Hi Lukasz, > > Please use scripts/get_maintainer.pl to