Re: [PATCH] arm: mach-k3: am62p: Fixup TF-A/OP-TEE reserved-memory node in FDT

2024-05-23 Thread Andrew Davis
{} nodes when the loaded address does not match the address in DT. Reported-by: Andrew Davis Signed-off-by: Bryan Brattlof --- Hello everyone, This is a little fixup to avoid any confusion once we're in the kernel. Because TF-A can be configured in U-Boot to be anywhere we want, we need up update

Re: [PATCH 1/3] arm: dts: k3-am642-evm-u-boot: Add remoteproc-name for PRU cores

2024-05-22 Thread Andrew Davis
On 5/22/24 1:36 AM, MD Danish Anwar wrote: Add remoteproc-name property for PRU cores. Signed-off-by: MD Danish Anwar --- arch/arm/dts/k3-am642-evm-u-boot.dtsi | 44 +++ 1 file changed, 44 insertions(+) diff --git a/arch/arm/dts/k3-am642-evm-u-boot.dtsi

Re: [PATCH 2/7] arm: mach-k3: j721e: Enable QoS for DSS

2024-05-22 Thread Andrew Davis
On 5/22/24 6:37 AM, Jayesh Choudhary wrote: Enable Quality of Service (QoS) blocks for Display SubSystem (DSS), by servicing the DSS - DDR traffic from the Real-Time (RT) queue. This is done by setting the DSS DMA orderID to greater than 7. ATYPE 3 is selected so that the traffic takes

Re: [PATCH 1/7] arm: mach-k3: am62a_qos: Move common bit MACROS to k3_qos header file

2024-05-22 Thread Andrew Davis
On 5/22/24 6:37 AM, Jayesh Choudhary wrote: QoS bit mapping are common across all K3 SoCs so move those defines to common header file (k3_qos.h). This ensures that we do not define these for each SoC. Signed-off-by: Jayesh Choudhary --- arch/arm/mach-k3/include/mach/k3-qos.h | 74

Re: [PATCH v3 2/2] configs: add defconfigs for the am625-lp-sk

2024-05-15 Thread Andrew Davis
On 5/15/24 1:21 PM, Tom Rini wrote: On Fri, May 03, 2024 at 11:44:29AM -0500, Bryan Brattlof wrote: The am62x-lp-sk is a package and reference board spin of the am62x-sk to showcase the low-power features of the am62x SoC family. Because it so closely resembles the am62x-sk board, use the

Re: [PATCH v2 5/8] drivers: ram: Kconfig: Add CONFIG_K3_INLINE_ECC

2024-05-15 Thread Andrew Davis
On 5/10/24 3:47 AM, Santhosh Kumar K wrote: From: Neha Malcom Francis Add CONFIG_K3_INLINE_ECC so that ECC functions can be compiled into R5 SPL only when the config has been enabled. Signed-off-by: Neha Malcom Francis --- drivers/ram/Kconfig | 11 +++ 1 file changed, 11

[PATCH v2] arm: mach-k3: Move code specific to a SoC into that SoC's directory

2024-05-10 Thread Andrew Davis
Each SoC now has a directory in mach-k3, let's move the SoC specific files into their respective directories. Signed-off-by: Andrew Davis --- Changes for v2: - Rebased on latest -next arch/arm/mach-k3/Makefile | 24 ++--- arch/arm/mach-k3/am62ax/Makefile

Re: [PATCH v2 2/2] arm: dts: k3-j7200-binman: Add support for HSSE1.0 and HSFS1.0

2024-05-09 Thread Andrew Davis
release (IIRC), but for completeness this is fine to have supported, Reviewed-by: Andrew Davis Reported-by: Suman Anna Reported-by: Aniket Limaye Signed-off-by: Neha Malcom Francis --- arch/arm/dts/k3-j7200-binman.dtsi | 95 ++- 1 file changed, 94 insertions(+), 1

Re: [PATCH v2 1/2] arm: dts: k3-j721e-binman: Add support for HSFS1.1

2024-05-09 Thread Andrew Davis
HS-SE SR2.0 generation Looks good to me now, Reviewed-by: Andrew Davis arch/arm/dts/k3-j721e-binman.dtsi | 90 ++- 1 file changed, 89 insertions(+), 1 deletion(-) diff --git a/arch/arm/dts/k3-j721e-binman.dtsi b/arch/arm/dts/k3-j721e-binman.dtsi index

[PATCH] arm: mach-k3: am62ax: Fix typo in ROM data macro name

2024-04-26 Thread Andrew Davis
s/ENTENDED/EXTENDED Signed-off-by: Andrew Davis --- arch/arm/mach-k3/am62a7_init.c | 2 +- arch/arm/mach-k3/include/mach/am62a_hardware.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-k3/am62a7_init.c b/arch/arm/mach-k3/am62a7_init.c index

[PATCH] arm: mach-k3: Move code specific to a SoC into that SoC's directory

2024-04-25 Thread Andrew Davis
Each SoC now has a directory in mach-k3, let's move the SoC specific files into their respective directories. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/Makefile | 27 ++--- arch/arm/mach-k3/am62ax/Makefile| 7 ++ arch/arm/mach-k3

Re: [PATCH 1/2] arm: dts: k3-j721e-binman: Add support for HSSE2.0 and HSFS1.1

2024-04-22 Thread Andrew Davis
On 4/22/24 4:40 PM, Neha Malcom Francis wrote: J721E has SR1.1 and SR2.0 having three variants of each GP, HS-FS and HS-SE. Current build does not generate HS-SE SR2.0 and HS-FS SR1.1 so add support for them. Reported-by: Suman Anna Signed-off-by: Neha Malcom Francis ---

[PATCH] arm: mach-k3: am642: Fix reset for workaround errata ID i2331

2024-04-18 Thread Andrew Davis
driver allowing do_reset() to again function as expected. Reported-by: Jonathan Humphreys Fixes: fc5d40283483 ("firmware: ti_sci: Bind sysreset driver when enabled") Signed-off-by: Andrew Davis --- arch/arm/mach-k3/am642_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH] arm: mach-k3: security: Lower verbosity of cert message for GP

2024-04-10 Thread Andrew Davis
When we find a certificate on an image to be booted on a GP device we print out a message explaining that the certificate is being skipped. This message is rather long and is printed for every image. Shorten the message and make the long version into a debug message. Signed-off-by: Andrew Davis

Re: [PATCH 3/7] dts: j721e: binman: Include firmware capsules binman nodes

2024-04-10 Thread Andrew Davis
On 4/10/24 1:24 PM, Jon Humphreys wrote: Andrew Davis writes: On 4/8/24 5:17 PM, Jonathan Humphreys wrote: Signed-off-by: Jonathan Humphreys --- arch/arm/dts/k3-j721e-binman.dtsi | 32 +++ 1 file changed, 32 insertions(+) diff --git a/arch/arm/dts/k3-j721e

Re: [PATCH 01/13] ti:keys Add EFI signature list

2024-04-10 Thread Andrew Davis
On 4/10/24 4:38 AM, Ilias Apalodimas wrote: On Tue, 9 Apr 2024 at 23:14, Andrew Davis wrote: On 4/9/24 2:26 PM, Heinrich Schuchardt wrote: On 4/9/24 14:14, Andrew Davis wrote: On 4/8/24 10:34 PM, Heinrich Schuchardt wrote: On 4/8/24 23:33, Jonathan Humphreys wrote: EFI signature list

Re: [PATCH 3/7] dts: j721e: binman: Include firmware capsules binman nodes

2024-04-09 Thread Andrew Davis
On 4/8/24 5:17 PM, Jonathan Humphreys wrote: Signed-off-by: Jonathan Humphreys --- arch/arm/dts/k3-j721e-binman.dtsi | 32 +++ 1 file changed, 32 insertions(+) diff --git a/arch/arm/dts/k3-j721e-binman.dtsi b/arch/arm/dts/k3-j721e-binman.dtsi index

Re: [PATCH 01/13] ti:keys Add EFI signature list

2024-04-09 Thread Andrew Davis
On 4/9/24 2:26 PM, Heinrich Schuchardt wrote: On 4/9/24 14:14, Andrew Davis wrote: On 4/8/24 10:34 PM, Heinrich Schuchardt wrote: On 4/8/24 23:33, Jonathan Humphreys wrote: EFI signature list using TI dummy keys. Adding vendor public keys into the code base to lock down generated binaries

Re: [PATCH 01/13] ti:keys Add EFI signature list

2024-04-09 Thread Andrew Davis
On 4/8/24 10:34 PM, Heinrich Schuchardt wrote: On 4/8/24 23:33, Jonathan Humphreys wrote: EFI signature list using TI dummy keys. Adding vendor public keys into the code base to lock down generated binaries to the vendors unpublished private key does not match well with the intent of the GNU

Re: [RFC PATCH 13/15] arm: dts: Introduce J722S U-Boot dts files

2024-04-05 Thread Andrew Davis
On 4/5/24 2:18 AM, Jayesh Choudhary wrote: Hi, On 04/04/24 20:59, Andrew Davis wrote: On 4/4/24 4:00 AM, Jayesh Choudhary wrote: Include the uboot device tree files needed to boot the board. Co-developed-by: Vaishnav Achath Signed-off-by: Vaishnav Achath Signed-off-by: Jayesh Choudhary

Re: [PATCH 1/1] net: nfs: fix file handle length in NFSv3

2024-04-04 Thread Andrew Davis
by using a variable length file handle for dirfh. [1] https://www.rfc-editor.org/rfc/rfc1813.html#page-106 Fixes: b0baca982048 ("net: NFS: Add NFSv3 support") Signed-off-by: Sébastien Szymanski --- Fixes NFS boot for me, thanks! Tested-by: Andrew Davis net/nfs.c | 18 +---

Re: [RFC PATCH 15/15] doc: board: ti: Add J722S-EVM documentation

2024-04-04 Thread Andrew Davis
On 4/4/24 4:00 AM, Jayesh Choudhary wrote: Introduce basic documentation for the J722S-EVM. Signed-off-by: Jayesh Choudhary --- doc/board/ti/j722s_evm.rst | 262 + doc/board/ti/k3.rst| 1 + 2 files changed, 263 insertions(+) create mode

Re: [RFC PATCH 13/15] arm: dts: Introduce J722S U-Boot dts files

2024-04-04 Thread Andrew Davis
On 4/4/24 4:00 AM, Jayesh Choudhary wrote: Include the uboot device tree files needed to boot the board. Co-developed-by: Vaishnav Achath Signed-off-by: Vaishnav Achath Signed-off-by: Jayesh Choudhary --- arch/arm/dts/Makefile |2 +

Re: [PATCH 2/2] arm: dts: k3: Remove unneeded ti, sci-sysreset binding and nodes

2024-04-03 Thread Andrew Davis
On 4/3/24 1:37 AM, Neha Malcom Francis wrote: Hi Andrew, On 02/04/24 21:39, Andrew Davis wrote: This extra binding is non-standard and now unneeded as we bind the sysreset driver automatically. This matches what is done in Linux and allows us to more closely match the DTBs. Remove the binding

[PATCH 1/2] firmware: ti_sci: Bind sysreset driver when enabled

2024-04-02 Thread Andrew Davis
The sysreset TI-SCI API is available with TI-SCI always, there is no need for a DT node to describe the availability of this. If the sysreset driver is available then bind it during ti-sci probe. Remove the unneeded device tree matching. Signed-off-by: Andrew Davis --- drivers/firmware

[PATCH 2/2] arm: dts: k3: Remove unneeded ti, sci-sysreset binding and nodes

2024-04-02 Thread Andrew Davis
This extra binding is non-standard and now unneeded as we bind the sysreset driver automatically. This matches what is done in Linux and allows us to more closely match the DTBs. Remove the binding and all users. Signed-off-by: Andrew Davis --- arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 7

[PATCH 0/2] Remove ti,sci-sysreset

2024-04-02 Thread Andrew Davis
] https://lore.kernel.org/lkml/20240326223730.54639-1-...@ti.com/ Andrew Davis (2): firmware: ti_sci: Bind sysreset driver when enabled arm: dts: k3: Remove unneeded ti,sci-sysreset binding and nodes arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 7 - .../k3-am625-phyboard-lyra-rdk-u

Re: [PATCH] am625x_evm_a53: Tweak boot command to set fdt

2024-03-26 Thread Andrew Davis
On 3/26/24 9:26 AM, Martyn Welch wrote: With the current config for tha SK-AM62, fdtfile isn't set in the U-Boot environment. When using bootflow to boot from a block device, where the extlinux.conf file specifies `fdtdir`, a fallback device tree is being constructed from the `soc` (`k3`) and

Re: [PATCH 3/4] arm: dts: k3-*-binman.dtsi: Clean up and templatize boot binaries

2024-03-23 Thread Andrew Davis
On 3/22/24 8:10 AM, Neha Malcom Francis wrote: Clean up templatized boot binaries for all K3 boards. This includes modifying the k3-binman.dtsi to use SPL_BOARD_DTB, BOARD_DESCRIPTION and UBOOT_BOARD_DESCRIPTION from the files that include it to further reuse code. All k3--binman.dtsi will

Re: [PATCH] Makefile: Improve generated_defconfig file handling

2024-03-08 Thread Andrew Davis
make clean'. Also we probably want to hide it in `git status' list. This patch makes the described changes, and also adds `-P' parameter to the CPP command that produces the `generated_defconfig' to avoid generating linemarkers. All look like sensible improvements to me, Acked-by: Andrew Davis

Re: [PATCH 4/6] arm: mach-k3: am62: Fixup TF-A/OP-TEE reserved-memory node in FDT

2024-03-06 Thread Andrew Davis
On 3/6/24 7:35 AM, Bryan Brattlof wrote: On February 14, 2024 thus sayeth Andrew Davis: The address we load TF-A and OP-TEE to is configurable by Kconfig CONFIG_K3_{ATF,OPTEE}_LOAD_ADDR, but the DT nodes reserving this memory are often statically defined. As these binaries are dynamically

Re: [PATCH 4/6] arm: mach-k3: am62: Fixup TF-A/OP-TEE reserved-memory node in FDT

2024-03-06 Thread Andrew Davis
On 2/28/24 12:24 AM, Manorit Chawdhry wrote: Hi Andrew, On 10:30-20240214, Andrew Davis wrote: The address we load TF-A and OP-TEE to is configurable by Kconfig CONFIG_K3_{ATF,OPTEE}_LOAD_ADDR, but the DT nodes reserving this memory are often statically defined. As these binaries

Re: [PATCH 2/6] arm: mach-k3: Add config option for setting OP-TEE address

2024-03-06 Thread Andrew Davis
On 2/28/24 12:21 AM, Manorit Chawdhry wrote: Hi Andrew, On 10:30-20240214, Andrew Davis wrote: Much like we have for ATF, OP-TEE has a standard address that we load it too and run it from. Add a Kconfig item for this to remove some hard-coding and allow this address to be more easily changed

[PATCH v2] arm: dts: k3-am64: Move to OF_UPSTREAM

2024-03-05 Thread Andrew Davis
Enable OF_UPSTREAM for AM64-EVM and SK-AM64 boards. Remove DT files that are now available in dts/upstream. Update the appended files based on version of latest OF_UPSTREAM sync point (v6.7-rc7). Signed-off-by: Andrew Davis --- Changes for v2: - Rebased on latest -next to fix merge conflict

[PATCH] arm: dts: k3-am64: Move to OF_UPSTREAM

2024-03-04 Thread Andrew Davis
Enable OF_UPSTREAM for AM64-EVM and SK-AM64 boards. Remove DT files that are now available in dts/upstream. Update the appended files based on version of latest OF_UPSTREAM sync point (v6.7-rc7). Signed-off-by: Andrew Davis --- As suggested here[0]. Based on Mar 4 -next. [0] https

Re: [PATCH v10 14/15] configs: am69_sk: Add defconfig for AM69 SK board

2024-02-29 Thread Andrew Davis
snavis Sabiya Signed-off-by: Apurva Nandan --- Reviewed-by: Andrew Davis board/ti/j784s4/MAINTAINERS | 2 ++ configs/am69_sk_a72_defconfig | 9 + configs/am69_sk_r5_defconfig | 10 ++ 3 files changed, 21 insertions(+) create mode 100644 configs/am69_sk_a72_def

Re: [RFC PATCH 1/4] configs: j721e_sk: Move to separate defconfig for J721E SK board

2024-02-28 Thread Andrew Davis
On 2/28/24 5:20 AM, Neha Malcom Francis wrote: Add defconfig for J721E SK R5 and A72 configuration. This includes and modifies the J721E EVM defconfigs: j721e_evm_r5_defconfig -> j721e_sk_r5_defconfig j721e_evm_a72_defconfig -> j721e_sk_a72_defconfig Signed-off-by: Neha Malcom Francis ---

Re: [PATCH 6/6] arm: mach-k3: Move DRAM address of ATF for AM62/AM62a

2024-02-15 Thread Andrew Davis
On 2/15/24 2:06 AM, Francesco Dolcini wrote: Hello Andrew, thanks for this series. On Wed, Feb 14, 2024 at 10:30:09AM -0600, Andrew Davis wrote: The current address of TF-A in DRAM is just below the 512MB address line. This means if the DRAM in a system is 512MB then TF-A is right at the end

[PATCH 5/6] arm: mach-k3: am62a: Fixup TF-A/OP-TEE reserved-memory node in FDT

2024-02-14 Thread Andrew Davis
The address we load TFA and OP-TEE to is configurable by CONFIG_K3_{ATF,OPTEE}_LOAD_ADDR, but the DT nodes reserving this memory are static. Fix that by updating this node when the loaded address does not match the address in DT. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/Makefile

[PATCH 3/6] arm: mach-k3: am62: Enable OF_SYSTEM_SETUP for all boards

2024-02-14 Thread Andrew Davis
The fixups provided by ft_system_setup() are applicable for all AM62 based boards. Select this at the target selection level for all AM62 boards and remove it from any specific defconfig. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/am62x/Kconfig| 3 +++ configs/verdin

[PATCH 6/6] arm: mach-k3: Move DRAM address of ATF for AM62/AM62a

2024-02-14 Thread Andrew Davis
and is fully forward/backward compatible. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-k3/Kconfig b/arch/arm/mach-k3/Kconfig index 55bb874d9aa..33f20f61f83 100644 --- a/arch/arm/mach-k3/Kconfig +++ b/arch

[PATCH 1/6] arm: mach-k3: Add default ATF location for AM62/AM62a

2024-02-14 Thread Andrew Davis
There is a default ATF load address that is used for devices that have ATF running in SRAM. For AM62 and AM62a, ATF runs from DRAM. Instead of having to override the address in every defconfig, make add a default for these ATF in DRAM devices. Signed-off-by: Andrew Davis --- arch/arm/mach-k3

[PATCH 0/6] Move DRAM address of ATF

2024-02-14 Thread Andrew Davis
Hello all, Explanation for this series is mostly in [4/6]. First 3 patches should be safe to take independent of the last 3. Thanks, Andrew Andrew Davis (6): arm: mach-k3: Add default ATF location for AM62/AM62a arm: mach-k3: Add config option for setting OP-TEE address arm: mach-k3: am62

[PATCH 4/6] arm: mach-k3: am62: Fixup TF-A/OP-TEE reserved-memory node in FDT

2024-02-14 Thread Andrew Davis
above. Add this fixup function, and enable it for AM62. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/am625_fdt.c | 2 ++ arch/arm/mach-k3/common_fdt.c | 52 +++ arch/arm/mach-k3/common_fdt.h | 2 ++ 3 files changed, 56 insertions(+) diff --git a/arch/arm

[PATCH 2/6] arm: mach-k3: Add config option for setting OP-TEE address

2024-02-14 Thread Andrew Davis
Much like we have for ATF, OP-TEE has a standard address that we load it too and run it from. Add a Kconfig item for this to remove some hard-coding and allow this address to be more easily changed. Signed-off-by: Andrew Davis --- arch/arm/dts/k3-am625-beagleplay-u-boot.dtsi | 4 ++-- arch

Re: [PATCH 2/2] ti: keystone2: Move common Kconfig selections to under ARCH_KEYSTONE

2024-02-08 Thread Andrew Davis
On 7/25/23 12:41 PM, Tom Rini wrote: On Tue, Jul 25, 2023 at 10:54:16AM -0500, Andrew Davis wrote: These select/imply settings are common to the whole architecture not just these boards, move these settings to the architecture config. Signed-off-by: Andrew Davis Reviewed-by: Tom Rini

Re: [PATCH 02/10] arm: dts: k3-am68*: Sync with 6.8-rc1

2024-02-06 Thread Andrew Davis
On 2/6/24 6:21 AM, Manorit Chawdhry wrote: Syncs the DT from Linux v6.8-rc1. Remove udmap overrides and handle location change of chipid node. Message doesn't match the patch. This patch should just be squashed into the previous one anyway. Andrew Signed-off-by: Manorit Chawdhry ---

Re: [PATCH] arm: mach-k3: Refactor QoS settings

2024-02-06 Thread Andrew Davis
On 2/6/24 2:56 AM, Aradhya Bhatia wrote: Refactor common QoS code into a new common header file, and the soc specific setup_qos functions into a common API. Rename $(soc)_qos_count and $(soc)_qos_data variables to qos_count and qos_data. When QoS settings of more SoCs are added, only one pair

Re: [PATCH v2 05/13] arm: mach-k3: invert logic for split DM firmware config

2024-02-02 Thread Andrew Davis
_K3_AM654 && !CLK_TI_SCI && !TI_SCI_POWER_DOMAIN Always amusing to see how many SoCs get added to these lists before someone realizes there is only one or two SoCs that are not on the list :) BTW, this whole file is inside an "if ARCH_K3" block, so all symbols depend on

Re: [PATCH v2 10/13] arm: dts: introduce am62p5 uboot dts files

2024-02-02 Thread Andrew Davis
On 2/2/24 10:28 AM, Bryan Brattlof wrote: Hi Andrew! On February 2, 2024 thus sayeth Andrew Davis: On 1/31/24 9:06 PM, Bryan Brattlof wrote: Include the uboot device tree files needed to boot the board. Signed-off-by: Bryan Brattlof --- arch/arm/dts/Makefile |2

Re: [PATCH v2 10/13] arm: dts: introduce am62p5 uboot dts files

2024-02-02 Thread Andrew Davis
On 1/31/24 9:06 PM, Bryan Brattlof wrote: Include the uboot device tree files needed to boot the board. Signed-off-by: Bryan Brattlof --- arch/arm/dts/Makefile |2 + arch/arm/dts/k3-am62p-ddr-lp4-50-1600.dtsi | 2800

[PATCH 3/6] arm: mach-k3: Move tispl.bin loading into R5 directory

2024-02-01 Thread Andrew Davis
ATF, OPTEE, DM (tispl.bin) loading is only ever done by the R5 core, move the code into the R5 directory. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/common.c| 248 +- arch/arm/mach-k3/r5/common.c | 249 +++ 2 files

[PATCH 2/6] arm: mach-k3: Move disable_linefill_optimization() into R5 directory

2024-02-01 Thread Andrew Davis
The disable_linefill_optimization() function is only ever loaded by the R5 core, move the code into the R5 directory. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/common.c| 25 - arch/arm/mach-k3/r5/Makefile | 1 + arch/arm/mach-k3/r5/common.c | 35

[PATCH 6/6] arm: mach-k3: Move ARM64 specific code into new arm64 directory

2024-02-01 Thread Andrew Davis
Like we did with R5, move ARM64 code into a specific directory to make it clear what code is only meant to run on each core type. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/Makefile| 3 +-- arch/arm/mach-k3/arm64/Makefile | 6 ++ arch/arm/mach-k3/{ => ar

[PATCH 5/6] arm: mach-k3: Move firewall removal into R5 directory

2024-02-01 Thread Andrew Davis
Firewalls are only ever removed by the R5 core, move this code into the R5 directory. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/common.c| 44 arch/arm/mach-k3/r5/common.c | 44 2 files changed, 44 insertions

[PATCH 4/6] arm: mach-k3: am62a7: Disable firewalls only after loading SYSFW

2024-02-01 Thread Andrew Davis
Currently we do this multiple times, instead just do it once after loading SYSFW in R5 SPL. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/am62a7_init.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-k3/am62a7_init.c b/arch/arm/mach-k3/am62a7_init.c

[PATCH 1/6] arm: mach-k3: Move SYS_K3_SPL_ATF definition into R5 Kconfig

2024-02-01 Thread Andrew Davis
Loading ATF is only supported from the R5, move the Kconfig symbol definition to match. Signed-off-by: Andrew Davis --- arch/arm/mach-k3/Kconfig| 7 --- arch/arm/mach-k3/r5/Kconfig | 6 ++ 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/arch/arm/mach-k3/Kconfig b/arch

[PATCH 1/2] arm: dts: k3-am64: Sync with kernel v6.7-rc1

2024-02-01 Thread Andrew Davis
From: Nishanth Menon Sync with kernel v6.7-rc1 and sync up the u-boot dts files accordingly. Signed-off-by: Nishanth Menon Signed-off-by: Andrew Davis --- arch/arm/dts/k3-am64-main.dtsi| 37 ++--- arch/arm/dts/k3-am64-mcu.dtsi | 2 + arch/arm/dts/k3-am64.dtsi

[PATCH 2/2] arm: dts: k3-am64: Sync with kernel v6.8-rc1

2024-02-01 Thread Andrew Davis
Sync with kernel v6.8-rc1 and sync up the u-boot dts files accordingly. Signed-off-by: Andrew Davis --- arch/arm/dts/k3-am64-main.dtsi| 22 +- arch/arm/dts/k3-am642-evm-u-boot.dtsi | 21 + arch/arm/dts/k3-am642-evm.dts | 12

Re: [PATCH v8 15/16] configs: Add am69_sk_* defconfig fragments

2024-01-31 Thread Andrew Davis
On 1/29/24 12:26 PM, Apurva Nandan wrote: On 23/01/24 20:31, Andrew Davis wrote: On 1/23/24 8:39 AM, Apurva Nandan wrote: Hi Andrew, On 20/01/24 00:43, Andrew Davis wrote: On 1/19/24 11:50 AM, Apurva Nandan wrote: From: Dasnavis Sabiya Add config fragments for am69_sk A72 and R5

Re: [PATCH] firmware: ti_sci: fix the secure_hdr in do_xfer

2024-01-25 Thread Andrew Davis
On 1/24/24 11:43 PM, Dhruva Gole wrote: On Jan 24, 2024 at 12:08:13 -0600, Nishanth Menon wrote: On 23:07-20240124, Dhruva Gole wrote: On Jan 24, 2024 at 10:39:10 -0600, Nishanth Menon wrote: On 18:38-20240124, Dhruva Gole wrote: On Jan 24, 2024 at 16:42:12 +0530, Kamlesh Gurudasani wrote:

Re: [PATCH v8 15/16] configs: Add am69_sk_* defconfig fragments

2024-01-23 Thread Andrew Davis
On 1/23/24 8:39 AM, Apurva Nandan wrote: Hi Andrew, On 20/01/24 00:43, Andrew Davis wrote: On 1/19/24 11:50 AM, Apurva Nandan wrote: From: Dasnavis Sabiya Add config fragments for am69_sk A72 and R5 configuration. This applies on to: j784s4_evm_a72_defconfig -> am69_sk_a72.con

Re: [PATCH v8 15/16] configs: Add am69_sk_* defconfig fragments

2024-01-19 Thread Andrew Davis
On 1/19/24 11:50 AM, Apurva Nandan wrote: From: Dasnavis Sabiya Add config fragments for am69_sk A72 and R5 configuration. This applies on to: j784s4_evm_a72_defconfig -> am69_sk_a72.config j784s4_evm_r5_defconfig -> am69_sk_r5.config The usage model (with the fragment) would be: make

Re: [PATCH RFC] Kconfig: Add support for FIT image signature enforcing

2024-01-17 Thread Andrew Davis
On 1/11/24 4:34 AM, Manorit Chawdhry wrote: FIT_SIGNATURE doesn't enforce the U-boot setup to be correct for booting the FIT images, the DTB might not have all the proper nodes and it just boots up without any warning. This makes it difficult to get the correct setup working. Adds an

Re: [PATCH v3 0/8] Suspend to RAM support for K3 J7200

2024-01-12 Thread Andrew Davis
On 1/10/24 3:34 AM, Thomas Richard wrote: On 1/9/24 18:32, Andrew Davis wrote: On 1/8/24 10:56 AM, Thomas Richard wrote: This series is the U-Boot part of the work to add the suspend to RAM support for the K3 J7200 EVM board. During the boot R5 SPL makes a copy of DM-Firmware and TF

Re: [PATCH v3 0/8] Suspend to RAM support for K3 J7200

2024-01-09 Thread Andrew Davis
On 1/8/24 10:56 AM, Thomas Richard wrote: This series is the U-Boot part of the work to add the suspend to RAM support for the K3 J7200 EVM board. During the boot R5 SPL makes a copy of DM-Firmware and TF-A in memory. Resume detection is done by reading a magic value in a pmic register (set by

Re: [PATCH 08/10] board: beagle: beagleboneai64: Set fdtfile from C code instead of findfdt script

2024-01-08 Thread Andrew Davis
On 1/8/24 11:32 AM, Nishanth Menon wrote: Stop using the findfdt script and switch to setting the fdtfile from C code. While at this, replace findfdt in environment with a warning as it is no longer needed Signed-off-by: Nishanth Menon --- board/beagle/beagleboneai64/beagleboneai64.c | 14

Re: [PATCH 01/10] board: ti: common: Introduce a common fdt ops library

2024-01-08 Thread Andrew Davis
On 1/8/24 11:32 AM, Nishanth Menon wrote: Introduce a common fdt operations library for basic device tree operations that are common between various boards. The first library to introduce here is the capability to set up fdtfile as a standard variable as part of board identification rather than

Re: [PATCH 1/2] board: ti: am62x: am62x.env: Fix boot_targets

2024-01-04 Thread Andrew Davis
On 1/4/24 1:52 AM, Manorit Chawdhry wrote: Hi Andrew, Simon, On 08:58-20240102, Andrew Davis wrote: On 12/31/23 6:48 AM, Simon Glass wrote: Hi, On Wed, Nov 29, 2023 at 7:48 PM Simon Glass wrote: Hi Andrew, On Mon, 6 Nov 2023 at 11:05, Andrew Davis wrote: On 11/6/23 11:47 AM, Simon

Re: [PATCH v7 4/9] arm: dts: k3-binman: Add k3-security.h and include it in k3-binman.dtsi

2024-01-02 Thread Andrew Davis
ill don't like hardcoding the ATF firewall location here, especially since it is dynamic and we have a var for this: CONFIG_K3_ATF_LOAD_ADDR. Not a blocker, for now.., Reviewed-by: Andrew Davis + end_address = <0x0 0x7001&g

Re: [PATCH 1/2] board: ti: am62x: am62x.env: Fix boot_targets

2024-01-02 Thread Andrew Davis
On 12/31/23 6:48 AM, Simon Glass wrote: Hi, On Wed, Nov 29, 2023 at 7:48 PM Simon Glass wrote: Hi Andrew, On Mon, 6 Nov 2023 at 11:05, Andrew Davis wrote: On 11/6/23 11:47 AM, Simon Glass wrote: Hi Andrew, On Mon, 6 Nov 2023 at 10:27, Andrew Davis wrote: On 11/6/23 9:31 AM, Tom Rini

Re: [RFC PATCH 00/16] Introduce ICSSG Ethernet driver

2024-01-02 Thread Andrew Davis
On 12/27/23 12:56 AM, MD Danish Anwar wrote: On 22/12/23 6:13 pm, Roger Quadros wrote: On 22/12/2023 12:26, MD Danish Anwar wrote: Hi Roger, On 20/12/23 3:29 pm, Roger Quadros wrote: Hi, On 19/12/2023 12:11, MD Danish Anwar wrote: Introduce ICSSG PRUETH support in uboot. The ICSSG

Re: [PATCH v6 00/17] Introduce initial TI's J784S4 and AM69 support

2023-12-15 Thread Andrew Davis
On 12/15/23 2:51 AM, Marcel Ziswiler wrote: On Thu, 2023-12-14 at 14:28 -0600, Andrew Davis wrote: On 12/14/23 2:10 PM, b...@ti.com wrote: On December 14, 2023 thus sayeth Marcel Ziswiler: Hi Apurva Thanks! On Wed, 2023-12-06 at 18:07 +0530, Apurva Nandan wrote: Hello Everyone

Re: [PATCH v6 00/17] Introduce initial TI's J784S4 and AM69 support

2023-12-14 Thread Andrew Davis
On 12/14/23 2:10 PM, b...@ti.com wrote: On December 14, 2023 thus sayeth Marcel Ziswiler: Hi Apurva Thanks! On Wed, 2023-12-06 at 18:07 +0530, Apurva Nandan wrote: Hello Everyone! This series will introduce basic support (SD and UART) support for Texas Instruments J784S4 EVM. For the

Re: Proposal: FIT support for extension boards / overlays

2023-12-12 Thread Andrew Davis
On 12/12/23 8:05 AM, Simon Glass wrote: Hi, The devicetree files for a board can be quite large, perhaps around 60KB. To boot on any supported board, many of them need to be provided, typically hundreds. All boards for a particular SoC share common parts. It would be helpful to use overlays

Re: [PATCH v6 8/8] docs: k3: Add secure booting documentation

2023-12-06 Thread Andrew Davis
On 12/6/23 3:51 AM, Manorit Chawdhry wrote: This commit adds a general flow to explain the usage of firewalls and the chain of trust in K3 devices. Signed-off-by: Manorit Chawdhry --- doc/board/ti/k3.rst | 45 + 1 file changed, 45 insertions(+)

Re: [PATCH v6 4/8] binman: j721e: Add firewall configurations

2023-12-06 Thread Andrew Davis
On 12/6/23 3:51 AM, Manorit Chawdhry wrote: The following commits adds the configuration of firewalls required to protect ATF and OP-TEE memory region from non-secure reads and writes using master and slave firewalls present in our K3 SOCs. Signed-off-by: Manorit Chawdhry ---

Re: [PATCH 1/2] doc: board: beagle: am62x_beagleplay: Delete SW_PRNG flag for OPTEE

2023-12-05 Thread Andrew Davis
On 12/5/23 9:22 AM, Nishanth Menon wrote: On 08:46-20231205, Andrew Davis wrote: On 12/4/23 1:29 PM, Nishanth Menon wrote: On 15:59-20231201, Dhruva Gole wrote: Delete the flag CFG_WITH_SOFTWARE_PRNG as it's not necessary/ boot requirement for this SoC Signed-off-by: Dhruva Gole --- doc

Re: [PATCH 1/2] doc: board: beagle: am62x_beagleplay: Delete SW_PRNG flag for OPTEE

2023-12-05 Thread Andrew Davis
On 12/4/23 1:29 PM, Nishanth Menon wrote: On 15:59-20231201, Dhruva Gole wrote: Delete the flag CFG_WITH_SOFTWARE_PRNG as it's not necessary/ boot requirement for this SoC Signed-off-by: Dhruva Gole --- doc/board/beagle/am62x_beagleplay.rst | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH 3/3] doc: board: ti: k3: Mention TI_DM argument

2023-12-04 Thread Andrew Davis
be "ti-linux-firmware" if that is what you had set as BINMAN_INDIRS. s/ti-linux-firmware/BINMAN_INDIRS Otherwise whole series LGTM, Reviewed-by: Andrew Davis + utilize split firmware. + .. k3_rst_include_end_build_steps_uboot At this point you should have every binary needed

Re: [PATCH v5 17/17] board: ti: j784s4: Add MAINTAINERS file

2023-11-30 Thread Andrew Davis
On 11/30/23 5:55 AM, Apurva Nandan wrote: Add maintainership for new J784S4 files added. Signed-off-by: Apurva Nandan --- board/ti/j784s4/MAINTAINERS | 25 + 1 file changed, 25 insertions(+) create mode 100644 board/ti/j784s4/MAINTAINERS diff --git

Re: [PATCH v5 12/17] arm: dts: Introduce j784s4 u-boot dts files

2023-11-30 Thread Andrew Davis
On 11/30/23 5:55 AM, Apurva Nandan wrote: Introduce the base dts files needed for u-boot or to augment the linux dtbs for use in the u-boot-spl and u-boot binaries. Signed-off-by: Hari Nagalla [ add binman and ddr dtsi files ] Signed-off-by: Neha Malcom Francis Signed-off-by: Dasnavis Sabiya

Re: [PATCH v5 10/17] board: ti: j748s4: Add board config yaml files

2023-11-30 Thread Andrew Davis
On 11/30/23 5:55 AM, Apurva Nandan wrote: Add board-cfg, rm-cfg, pm-cfg, sec-cfg, tifs-rm-cfg yaml for buidling u-boot sysfw data. Signed-off-by: Apurva Nandan --- board/ti/j784s4/board-cfg.yaml | 37 + board/ti/j784s4/pm-cfg.yaml | 13 + board/ti/j784s4/rm-cfg.yaml | 3058

Re: [PATCH v5 09/17] board: ti: j784s4: Add board support for J784S4 EVM

2023-11-30 Thread Andrew Davis
On 11/30/23 5:55 AM, Apurva Nandan wrote: Add board files for J784S4 EVM. Signed-off-by: Hari Nagalla [ add env and board specific yaml files for binman ] Signed-off-by: Neha Malcom Francis [ cleaned up the env files ] Signed-off-by: Manorit Chawdhry Signed-off-by: Dasnavis Sabiya

[PATCH] board: ti: k3: Remove need for CFG_SYS_SDRAM_BASE

2023-11-30 Thread Andrew Davis
The base address of extended DDR does not change across the K3 family. Setting this per SoC is not needed. Remove this definition to help remove the last bits from K3 include/configs/*.h files. Signed-off-by: Andrew Davis --- board/ti/am65x/evm.c | 4 ++-- board/ti/j721e/evm.c

Re: [PATCH v2 2/4] arm: mach-k3: Do not map ATF and OPTEE regions in MMU

2023-11-29 Thread Andrew Davis
On 11/29/23 2:00 AM, Manorit Chawdhry wrote: Hi Andrew, On 28/11/23 22:35, Andrew Davis wrote: ATF and OPTEE regions may be firewalled from non-secure entities. To prevent access to this area we leave a hole there in the MMU map. This is the same idea as [0] but we complete that patch

[PATCH v2 3/4] arm: mach-k3: Remove non-cached memory map areas

2023-11-28 Thread Andrew Davis
to the nature of the K3 coherency architecture. Plus these are board specific carveouts and instead should have been added at the board level, not here in the SoC common code area. Remove these non-cached memory map areas. Signed-off-by: Andrew Davis Reviewed-by: Nishanth Menon Tested

[PATCH v2 4/4] arm: mach-k3: Merge initial memory maps

2023-11-28 Thread Andrew Davis
The Device vs Normal memory map is the same for all K3 SoCs. Merge the SoC specific maps into one. Signed-off-by: Andrew Davis Reviewed-by: Nishanth Menon Tested-by: Nishanth Menon --- arch/arm/mach-k3/arm64-mmu.c | 228 +-- 1 file changed, 2 insertions(+), 226

[PATCH v2 1/4] arm: mach-k3: Let the compiler size the mem_map lists

2023-11-28 Thread Andrew Davis
NR_MMU_REGIONS is a copy/paste from another platform that extends this list later. We do not do that, so let the list be the size of the initializer list. Signed-off-by: Andrew Davis Reviewed-by: Nishanth Menon Tested-by: Nishanth Menon --- arch/arm/mach-k3/arm64-mmu.c | 35

[PATCH v2 2/4] arm: mach-k3: Do not map ATF and OPTEE regions in MMU

2023-11-28 Thread Andrew Davis
arm64-mmu: do not map ATF and OPTEE regions in A53 MMU") Signed-off-by: Andrew Davis --- arch/arm/mach-k3/arm64-mmu.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/arch/arm/mach-k3/arm64-mmu.c b/arch/arm/mach-k3/arm64-mmu.c index d872ed714c4..5c858ae0

[PATCH v2 0/4] Unify K3 initial memory map

2023-11-28 Thread Andrew Davis
: - Included dependency patch from here[0] into this series - Add Tested-bys - Rebase on latest -next Thanks, Andrew [0] https://lore.kernel.org/all/20231122211218.607757-1-...@ti.com/ Andrew Davis (4): arm: mach-k3: Let the compiler size the mem_map lists arm: mach-k3: Do not map ATF

Re: [PATCH 2/3] arm: mach-k3: Remove non-cached memory map areas

2023-11-28 Thread Andrew Davis
On 11/27/23 9:47 AM, Nishanth Menon wrote: On 23:04-20231123, Vignesh Raghavendra wrote: On 11/23/2023 10:52 PM, Andrew Davis wrote: @@ -219,16 +177,9 @@ struct mm_region am62_mem_map[] = { }, { .virt = 0x8000UL, .phys = 0x8000UL

[PATCH 3/3] arm: mach-k3: Merge initial memory maps

2023-11-23 Thread Andrew Davis
The Device vs Normal memory map is the same for all K3 SoCs. Merge the SoC specific maps into one. Signed-off-by: Andrew Davis Reviewed-by: Nishanth Menon Tested-by: Nishanth Menon --- arch/arm/mach-k3/arm64-mmu.c | 197 +-- 1 file changed, 2 insertions(+), 195

[PATCH 2/3] arm: mach-k3: Remove non-cached memory map areas

2023-11-23 Thread Andrew Davis
to the nature of the K3 coherency architecture. Plus these are board specific carveouts and instead should have been added at the board level, not here in the SoC common code area. Remove these non-cached memory map areas. Signed-off-by: Andrew Davis Reviewed-by: Nishanth Menon Tested

[PATCH 1/3] arm: mach-k3: Let the compiler size the mem_map lists

2023-11-23 Thread Andrew Davis
NR_MMU_REGIONS is a copy/paste from another platform that extends this list later. We do not do that, so let the list be the size of the initializer list. Signed-off-by: Andrew Davis Reviewed-by: Nishanth Menon Tested-by: Nishanth Menon --- arch/arm/mach-k3/arm64-mmu.c | 35

[PATCH 0/3] Unify K3 initial memory map

2023-11-23 Thread Andrew Davis
-bys - Rebase on latest -next Thanks, Andrew [0] https://lore.kernel.org/all/20231122211218.607757-1-...@ti.com/ Andrew Davis (3): arm: mach-k3: Let the compiler size the mem_map lists arm: mach-k3: Remove non-cached memory map areas arm: mach-k3: Merge initial memory maps arch/arm/mach

[PATCH v2] arm: mach-k3: Move K3 common schema.yaml out of board directory

2023-11-22 Thread Andrew Davis
This file is common for all K3, move it out of board/ directory and into mach-k3. As we need to change the path in k3-binman.dtsi let's take this opportunity to switch to absolute paths which makes adding non-TI boards (like Toradex Verdin) not need to override these paths. Signed-off-by: Andrew

[PATCH v2] arm: mach-k3: Let the compiler size the mem_map lists

2023-11-22 Thread Andrew Davis
NR_MMU_REGIONS is a copy/paste from another platform that extends this list later. We do not do that, so let the list be the size of the initializer list. Signed-off-by: Andrew Davis --- Changes for v2: - Made same change for plats now in -next arch/arm/mach-k3/arm64-mmu.c | 35

Re: [PATCH] arm: mach-k3: Let the compiler size the mem_map lists

2023-11-22 Thread Andrew Davis
On 11/22/23 2:48 PM, Tom Rini wrote: On Mon, Nov 06, 2023 at 10:52:05AM -0600, Andrew Davis wrote: NR_MMU_REGIONS is a copy/paste from another platform that extends this list later. We do not do that, so let the list be the size of the initializer list. Signed-off-by: Andrew Davis --- arch

Re: [PATCH v4 02/16] arm: mach-k3: Add basic support for J784S4 SoC definition

2023-11-22 Thread Andrew Davis
On 10/4/23 1:06 PM, Nishanth Menon wrote: On 23:22-20231004, Apurva Nandan wrote: [...] + .virt = 0x5UL, + .phys = 0x5UL, + .size = 0x4UL, + .attrs = PTE_BLOCK_MEMTYPE(MT_DEVICE_NGNRNE) | +

  1   2   3   4   >