[PATCH v1 1/1] Makefile.lib: Always rebuild DSDT

2021-10-20 Thread Andy Shevchenko
The dsdt.asl is usually combined out of several files that are included in the main one. Whenever we change the content of any of such files, build system is not able to recognize them. Hence the easiest way is to force DSDT rebuild each time we run make. Signed-off-by: Andy Shevchenko

[PATCH v1 1/2] x86: tangier: Enable support for SD/SDIO family in the pinmux driver

2021-10-15 Thread Andy Shevchenko
We would need to quirk out Card Detect case and for that we allow configuring SD/SDIO family of pins. Signed-off-by: Andy Shevchenko --- arch/x86/cpu/tangier/pinmux.c | 39 ++- 1 file changed, 34 insertions(+), 5 deletions(-) diff --git a/arch/x86/cpu/tangier

[PATCH v1 2/2] x86: edison: Don't take SD card detect pin into consideration

2021-10-15 Thread Andy Shevchenko
-edison/issues/136 Signed-off-by: Andy Shevchenko --- arch/x86/dts/edison.dts | 12 1 file changed, 12 insertions(+) diff --git a/arch/x86/dts/edison.dts b/arch/x86/dts/edison.dts index 2c8cf6c07102..04e8a4e457c8 100644 --- a/arch/x86/dts/edison.dts +++ b/arch/x86/dts/edison.dts @@ -94,6

[PATCH v3 1/1] x86: tangier: acpi: Add GPIO card detection to SDHCI #2

2021-09-11 Thread Andy Shevchenko
On Intel Tangier the SDHCI #2 provides SD card connection. Add GPIO card detection for it. Fixes: 39665beed6f7 ("x86: tangier: Enable ACPI support for Intel Tangier") BugLink: https://github.com/edison-fw/meta-intel-edison/issues/135 Signed-off-by: Andy Shevchenko Acked-by: Bin Me

Re: [PATCH v2 1/1] x86: tangier: acpi: Add GPIO card detection to SDHCI #2

2021-09-10 Thread Andy Shevchenko
On Fri, Sep 10, 2021 at 09:04:53PM +0300, Andy Shevchenko wrote: > On Intel Tangier the SDHCI #2 provides SD card connection. > Add GPIO card detection for it. > > Fixes: 39665beed6f7 ("x86: tangier: Enable ACPI support for Intel Tangier") > BugLink: https://github.com/ed

[PATCH v2 1/1] x86: tangier: acpi: Add GPIO card detection to SDHCI #2

2021-09-10 Thread Andy Shevchenko
On Intel Tangier the SDHCI #2 provides SD card connection. Add GPIO card detection for it. Fixes: 39665beed6f7 ("x86: tangier: Enable ACPI support for Intel Tangier") BugLink: https://github.com/edison-fw/meta-intel-edison/issues/135 Signed-off-by: Andy Shevchenko Acked-by: Bin Me

Re: [PATCH v1 1/1] x86: tangier: acpi: Add GPIO card detection to SDHCI #2

2021-09-10 Thread Andy Shevchenko
On Fri, Sep 10, 2021 at 7:16 PM Bin Meng wrote: > On Sat, Sep 11, 2021 at 12:07 AM Andy Shevchenko > wrote: > > On Fri, Sep 10, 2021 at 2:38 PM Bin Meng wrote: > > > On Fri, Sep 10, 2021 at 3:59 PM Andy Shevchenko > > > wrote: > > > > On Intel Tangie

Re: [PATCH v1 1/1] x86: tangier: acpi: Add GPIO card detection to SDHCI #2

2021-09-10 Thread Andy Shevchenko
On Fri, Sep 10, 2021 at 2:38 PM Bin Meng wrote: > > On Fri, Sep 10, 2021 at 3:59 PM Andy Shevchenko > wrote: > > > > On Intel Tangier the SDHCI #2 provides SD card connection. > > Add GPIO card detection for it. > > > > Fixes: 39665beed6f7 ("x86: ta

[PATCH v1 1/1] x86: tangier: acpi: Add GPIO card detection to SDHCI #2

2021-09-10 Thread Andy Shevchenko
On Intel Tangier the SDHCI #2 provides SD card connection. Add GPIO card detection for it. Fixes: 39665beed6f7 ("x86: tangier: Enable ACPI support for Intel Tangier") BugLink: https://github.com/edison-fw/meta-intel-edison/issues/135 Signed-off-by: Andy Shevchenko --- .../asm/arch-ta

[PATCH v1 1/1] x86: edison: Mark eMMC non-removable

2021-09-10 Thread Andy Shevchenko
eMMC is non-removable on Intel Edison board. Fix the DTS accordingly. Signed-off-by: Andy Shevchenko --- arch/x86/dts/edison.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/dts/edison.dts b/arch/x86/dts/edison.dts index 64b622836377..2c8cf6c07102 100644 --- a/arch/x86/dts

USB endpoints exclusion

2021-08-17 Thread Andy Shevchenko
Hi! It seems already some of the platforms are using USB endpoints for dedicated purposes (such as debugging). Those endpoints can't be used for anything else (sounds like hw wired). What is the solution in U-Boot (DTS + generic? code) to make this supported? -- With Best Regards, Andy

[PATCH v1 1/1] x86: tangier: Fix DMA controller IRQ polarity in CSRT

2021-07-30 Thread Andy Shevchenko
described correctly. Fixes: 5e99fde34a77 ("x86: tangier: Populate CSRT for shared DMA controller") Signed-off-by: Andy Shevchenko --- arch/x86/cpu/tangier/acpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/cpu/tangier/acpi.c b/arch/x86/cpu/

[PATCH v1 1/1] test: Include /sbin to the PATH when creating file system

2021-06-10 Thread Andy Shevchenko
On some distributions the mkfs is under /sbin and /sbin is not set for mere users. Include /sbin to the PATH when creating file system, so that users won't get a scary traceback from Python. Signed-off-by: Andy Shevchenko --- test/py/tests/test_fs/conftest.py | 4 1 file changed, 4

Re: [PATCH] test: Fix filesystem tests always being skipped

2021-05-24 Thread Andy Shevchenko
ative to the revert. > > Andy: I don't think unmounting the failed-to-mount image was the cause > of the sudo call you described in that commit, so I believe this would > end up running sudo on your system. Wanted to warn in advance, but looks > like your issue needs a different s

Re: [PATCH 1/1] test: revert Don't unmount not (yet) mounted system

2021-05-17 Thread Andy Shevchenko
On Mon, May 17, 2021 at 8:57 PM Andy Shevchenko wrote: > > On Mon, May 17, 2021 at 8:08 PM Heinrich Schuchardt > wrote: > > On 17.05.21 16:06, Andy Shevchenko wrote: > > ... > > > Let's look at the code without your patch: > > > > We have multiple fu

Re: [PATCH 1/1] test: revert Don't unmount not (yet) mounted system

2021-05-17 Thread Andy Shevchenko
On Mon, May 17, 2021 at 8:08 PM Heinrich Schuchardt wrote: > On 17.05.21 16:06, Andy Shevchenko wrote: ... > Let's look at the code without your patch: > > We have multiple functions ending with: > > umount_fs(mount_dir) > except CalledProcessError as err: > p

Re: [PATCH 1/1] test: revert Don't unmount not (yet) mounted system

2021-05-17 Thread Andy Shevchenko
On Mon, May 17, 2021 at 4:29 PM Tom Rini wrote: > On Mon, May 17, 2021 at 03:21:41PM +0200, Heinrich Schuchardt wrote: > > On 17.05.21 13:44, Andy Shevchenko wrote: > > > On Mon, May 17, 2021 at 2:35 PM Heinrich Schuchardt > > > wrote: > > >> > >

Re: [PATCH 1/1] test: revert Don't unmount not (yet) mounted system

2021-05-17 Thread Andy Shevchenko
On Mon, May 17, 2021 at 4:21 PM Heinrich Schuchardt wrote: > On 17.05.21 13:44, Andy Shevchenko wrote: > > On Mon, May 17, 2021 at 2:35 PM Heinrich Schuchardt > > wrote: > >> On 17.05.21 13:16, Andy Shevchenko wrote: > >>> On Mon, May 17, 2021 at 10:48:3

Re: [PATCH 1/1] test: revert Don't unmount not (yet) mounted system

2021-05-17 Thread Andy Shevchenko
On Mon, May 17, 2021 at 2:35 PM Heinrich Schuchardt wrote: > > On 17.05.21 13:16, Andy Shevchenko wrote: > > On Mon, May 17, 2021 at 10:48:33AM +0200, Heinrich Schuchardt wrote: > >> On 17.05.21 08:33, Andy Shevchenko wrote: > >>> On Thu, May 13, 2021 at 2:41 PM

Re: [PATCH 1/1] test: revert Don't unmount not (yet) mounted system

2021-05-17 Thread Andy Shevchenko
On Mon, May 17, 2021 at 10:48:33AM +0200, Heinrich Schuchardt wrote: > On 17.05.21 08:33, Andy Shevchenko wrote: > > On Thu, May 13, 2021 at 2:41 PM Heinrich Schuchardt > > wrote: > >> > >> Since commit 1ba21bb06b08 ("test: Don't unmount not (yet) mou

Re: [PATCH v2 4/4] test: Don't unmount not (yet) mounted system

2021-05-17 Thread Andy Shevchenko
On Thu, May 13, 2021 at 2:32 PM Heinrich Schuchardt wrote: > On 2/11/21 3:40 PM, Andy Shevchenko wrote: > > When test suite tries to create a file for a new filesystem test case and > > fails, > > the clean up of the exception tries to unmount the image, that has not yet

Re: [PATCH 1/1] test: revert Don't unmount not (yet) mounted system

2021-05-17 Thread Andy Shevchenko
Probably we may understand first what is the root cause of this issue? In my case I can't allow this to happen, because it will annoy system administrators as I mentioned earlier in the commit message. So, NAK from me and let's investigate. Can you provide a command line that I may run on my environme

Re: [PATCH 03/17] x86: Allow coreboot serial driver to guess the UART

2021-05-04 Thread Andy Shevchenko
On Tue, May 04, 2021 at 09:26:19AM -0600, Simon Glass wrote: > On Fri, 30 Apr 2021 at 12:41, Andy Shevchenko > wrote: > > On Fri, Apr 30, 2021 at 9:14 PM Simon Glass wrote: > > > On Thu, 29 Apr 2021 at 17:01, Bin Meng wrote: > > > > On Fri, Apr 30, 20

Re: [PATCH 03/17] x86: Allow coreboot serial driver to guess the UART

2021-04-30 Thread Andy Shevchenko
t boots on the various > > > Chromebooks I am targetting. If it does, then serial is probablt > > > enabled. But certainly for chromebooks, it is not. My goal is to have > > > U-Boot boot on a chromebook in altfw mode with serial enabled. > > > > > > > > > > > I don't like the current approach because it ends up duplicating all > > > > UART IDs/info in C. > > > > > > Yes. Do you think it would be better to put it in the devicetree? I > > > suppose we could add some more stuff to the compatible string, > > > although U-Boot does not support the PCI compatible strings at > > > present. > > > > Putting it in the device tree also looks odd, because it only matters > > on a dedicated board. > > Right, but that is the nature of trying to run the same image on > different hardware. > > > > > > What do you suggest? > > > > Or parse the ACPI table coreboot has set up? But that might be another > > huge monster :( > > Yes, even worse... -- With Best Regards, Andy Shevchenko

Re: [PATCH v3] IOMUX: Fix buffer overflow in iomux_replace_device()

2021-04-26 Thread Andy Shevchenko
On Mon, Apr 26, 2021 at 08:08:03AM +0900, Yuichiro Goto wrote: > Use of strcat() against an uninitialized buffer would lead > to buffer overflow. This patch fixes it. Reviewed-by: Andy Shevchenko > Fixes: 694cd5618c ("IOMUX: Introduce iomux_replace_device()") > Signed

Re: [PATCH v2] IOMUX: Fix buffer overflow in iomux_replace_device()

2021-04-23 Thread Andy Shevchenko
On Fri, Apr 23, 2021 at 05:08:05PM +0900, Yuichiro Goto wrote: > Use of strcat() against an uninitialized buffer would lead > to buffer overflow. This patch fixes it. Thanks for report! Can you also add a Fixes tag? > Signed-off-by: Yuichiro Goto > Cc: Peter Robinson > Cc:

Re: [PATCH] Revert "usb: kbd: destroy device after console is stopped"

2021-04-22 Thread Andy Shevchenko
On Thu, Apr 22, 2021 at 12:11:44PM +0100, Peter Robinson wrote: > On Thu, Apr 22, 2021 at 11:52 AM Andy Shevchenko > wrote: > > > > On Thu, Apr 22, 2021 at 10:19:10AM +0100, Peter Robinson wrote: > > > > Thanks for the report. > > > > > Reverts commit

Re: [PATCH] Revert "usb: kbd: destroy device after console is stopped"

2021-04-22 Thread Andy Shevchenko
On Thu, Apr 22, 2021 at 12:11:44PM +0100, Peter Robinson wrote: > On Thu, Apr 22, 2021 at 11:52 AM Andy Shevchenko > wrote: > > On Thu, Apr 22, 2021 at 10:19:10AM +0100, Peter Robinson wrote: ... > > > This has caused us issues on a number of ARMv7 deviices. I'm not sure &

Re: [PATCH] Revert "usb: kbd: destroy device after console is stopped"

2021-04-22 Thread Andy Shevchenko
not good. When we revert, we introduce another (I consider more serious) bug. > Signed-off-by: Peter Robinson > Cc: Nicolas Saenz Julienne > Cc: Andy Shevchenko > --- > > This has caused us issues on a number of ARMv7 deviices. I'm not sure > why specifically ARMv7 becaus

Re: [PATCH v1 1/2] cmd: bind: Fix driver binding on a device

2021-04-09 Thread Andy Shevchenko
On Fri, Apr 09, 2021 at 09:13:12AM -0400, Sean Anderson wrote: > On 4/9/21 8:05 AM, Patrice CHOTARD wrote: > > On 4/9/21 1:01 PM, Andy Shevchenko wrote: > > > On Fri, Apr 9, 2021 at 1:32 PM Patrice CHOTARD > > > wrote: > > > > On 4/9/21 11:48 AM, Andy Sh

Re: [PATCH v1 1/2] cmd: bind: Fix driver binding on a device

2021-04-09 Thread Andy Shevchenko
On Fri, Apr 9, 2021 at 1:32 PM Patrice CHOTARD wrote: > On 4/9/21 11:48 AM, Andy Shevchenko wrote: > > On Fri, Apr 9, 2021 at 12:28 PM Patrice CHOTARD > > wrote: > >> On 4/9/21 11:16 AM, Andy Shevchenko wrote: > >>> On Fri, Apr 9, 2021 at 1

Re: [PATCH v1 1/2] cmd: bind: Fix driver binding on a device

2021-04-09 Thread Andy Shevchenko
On Fri, Apr 9, 2021 at 12:28 PM Patrice CHOTARD wrote: > On 4/9/21 11:16 AM, Andy Shevchenko wrote: > > On Fri, Apr 9, 2021 at 10:37 AM Patrice Chotard > > wrote: ... > >> + if (drv) { > >> +

Re: [PATCH v1 1/2] cmd: bind: Fix driver binding on a device

2021-04-09 Thread Andy Shevchenko
r struct *driver to lists_bind_fdt(). > Fix also all lists_bind_fdt() callers. With or without comments addressed Reviewed-by: Andy Shevchenko > > Fixes: 84f8e36f03fa ("cmd: bind: allow to bind driver with driver data") > No blank line in the tag block. > Signed-off-by: Pat

Re: Serial console via USB (USBTTY) ...

2021-04-01 Thread Andy Shevchenko
On Thu, Apr 1, 2021 at 7:17 PM Herbert Poetzl wrote: > > > Hello Andy! > > Thanks for the quick feedback! > > On Thu, Apr 01, 2021 at 04:10:57PM +0300, Andy Shevchenko wrote: > > On Thu, Apr 1, 2021 at 2:19 PM Herbert Poetzl wrote: > > > >> I'm tryi

Re: Serial console via USB (USBTTY) ...

2021-04-01 Thread Andy Shevchenko
ly time consuming). > - Can I help getting this working? If you do it yourself. I can help with testing on my platform. -- With Best Regards, Andy Shevchenko

Re: [PATCH v2 4/4] test: Don't unmount not (yet) mounted system

2021-03-30 Thread Andy Shevchenko
On Tuesday, March 30, 2021, Tom Rini wrote: > On Tue, Mar 30, 2021 at 10:41:15PM +0300, Andy Shevchenko wrote: > > On Thu, Feb 18, 2021 at 09:52:12PM -0700, Simon Glass wrote: > > > On Thu, 18 Feb 2021 at 03:56, Andy Shevchenko < > andy.shevche...@gmail.com> wrote: &

Re: [PATCH v2 4/4] test: Don't unmount not (yet) mounted system

2021-03-30 Thread Andy Shevchenko
On Thu, Feb 18, 2021 at 09:52:12PM -0700, Simon Glass wrote: > On Thu, 18 Feb 2021 at 03:56, Andy Shevchenko > wrote: > > On Thu, Feb 18, 2021 at 6:46 AM Simon Glass wrote: > > > On Thu, 11 Feb 2021 at 07:40, Andy Shevchenko > > > wrote: > > > > >

Re: [PATCH v2 1/4] test: Include /sbin to the PATH when creating ext4 disk image

2021-03-15 Thread Andy Shevchenko
On Thu, Feb 11, 2021 at 04:40:09PM +0200, Andy Shevchenko wrote: > On some distributions the mkfs.ext4 is under /sbin and /sbin is not set > for mere users. Include /sbin to the PATH when creating ext4 disk image, > so that users won't get a scary traceback from Python. It has be

Re: [PATCH v2 4/4] test: Don't unmount not (yet) mounted system

2021-02-18 Thread Andy Shevchenko
On Thu, Feb 18, 2021 at 6:46 AM Simon Glass wrote: > > Hi Andy, > > On Thu, 11 Feb 2021 at 07:40, Andy Shevchenko > wrote: > > > > When test suite tries to create a file for a new filesystem test case and > > fails, > > the clean up of the exception tries

Re: [PATCH v1] usb: kbd: destroy device after console is stopped

2021-02-11 Thread Andy Shevchenko
Cc'ed on the last patch (it has prerequisites, so better to apply entire series for easy going). That said, I have dropped the 'iomux' branch from my public tree. > On Thu, 2021-01-28 at 15:46 -0500, Tom Rini wrote: > > On Thu, Jan 28, 2021 at 10:35:37PM +0200, Andy Shevchenko wrote: > > &

[PATCH v1 11/11] usb: kbd: destroy device after console is stopped

2021-02-11 Thread Andy Shevchenko
yboards") Reported-by: Nicolas Saenz Julienne Signed-off-by: Andy Shevchenko --- common/usb_kbd.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/common/usb_kbd.c b/common/usb_kbd.c index b316807844b1..60c6027e048d 100644 --- a/common/usb_kbd.c +++ b/comm

[PATCH v1 06/11] console: Set file and devices at one go

2021-02-11 Thread Andy Shevchenko
Logical continuation of the change that brought console_devices_set() is to unify console_setfile() with it and replace in the callers. Signed-off-by: Andy Shevchenko --- common/console.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/common

[PATCH v1 10/11] IOMUX: Introduce iomux_replace_device()

2021-02-11 Thread Andy Shevchenko
Some console devices may appear or disappear at run time. In order to support such a hotplug mechanism introduce a new iomux_replace_device() helper to update the list of devices without altering environment. Signed-off-by: Andy Shevchenko --- common/iomux.c | 33

[PATCH v1 08/11] IOMUX: Split out iomux_match_device() helper

2021-02-11 Thread Andy Shevchenko
Deduplicate the code used in a few places by splitting out a common helper. Signed-off-by: Andy Shevchenko --- common/console.c | 7 +++ common/iomux.c | 27 ++- include/iomux.h | 1 + 3 files changed, 18 insertions(+), 17 deletions(-) diff --git a/common

[PATCH v1 07/11] IOMUX: Switch to use stdio_file_to_flags()

2021-02-11 Thread Andy Shevchenko
Deduplicate code by replacing with stdio_file_to_flags() helper. Signed-off-by: Andy Shevchenko --- common/iomux.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/common/iomux.c b/common/iomux.c index 15bf53388559..5d027561bb6f 100644 --- a/common/iomux.c +++ b

[PATCH v1 09/11] IOMUX: Split out for_each_console_dev() helper macro

2021-02-11 Thread Andy Shevchenko
It is not only less lines of code, but also better readability when new macro is being in use. Introduce for_each_console_dev() helper macro and convert current users to it. Signed-off-by: Andy Shevchenko --- common/console.c | 15 +-- common/iomux.c | 4 +--- include/iomux.h

[PATCH v1 05/11] console: Set console device counter in console_devices_set()

2021-02-11 Thread Andy Shevchenko
console_devices_set() missed the console device counter to be set correctly. Fixes: 45375adc9799 ("console: add function console_devices_set") Cc: Patrick Delaunay Signed-off-by: Andy Shevchenko --- common/console.c | 1 + 1 file changed, 1 insertion(+) diff --git a/common/console.

[PATCH v1 04/11] console: Switch to use stdio_file_to_flags()

2021-02-11 Thread Andy Shevchenko
Deduplicate code by replacing with stdio_file_to_flags() helper. Signed-off-by: Andy Shevchenko --- common/console.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/common/console.c b/common/console.c index f3cc45cab548..b1c3ed17cc03 100644 --- a/common

[PATCH v1 02/11] stdio: Split out nulldev_register() and move it under #if

2021-02-11 Thread Andy Shevchenko
It's possible that NULLDEV can be disabled while it makes leftovers, move entire device under #if. Signed-off-by: Andy Shevchenko --- common/stdio.c | 33 + 1 file changed, 21 insertions(+), 12 deletions(-) diff --git a/common/stdio.c b/common/stdio.c index

[PATCH v1 03/11] stdio: Introduce a new helper stdio_file_to_flags()

2021-02-11 Thread Andy Shevchenko
Let's deduplicate existing copies by splitting off to a new helper. Signed-off-by: Andy Shevchenko --- common/stdio.c | 13 + include/stdio_dev.h | 2 ++ 2 files changed, 15 insertions(+) diff --git a/common/stdio.c b/common/stdio.c index 2935d0d9ba8a..aa003b308a21 100644

[PATCH v1 01/11] stdio: Get rid of dead code, i.e. stdio_deregister()

2021-02-11 Thread Andy Shevchenko
Nobody is using stdio_deregister(), remove for good. Note, even its parameters are not consistent with stdio_register(). So, if anyone want to introduce this again, better with some consistency. Signed-off-by: Andy Shevchenko --- common/stdio.c | 11 --- include/stdio_dev.h | 1

Re: [PATCH v2 1/4] test: Include /sbin to the PATH when creating ext4 disk image

2021-02-11 Thread Andy Shevchenko
On Thu, Feb 11, 2021 at 04:40:09PM +0200, Andy Shevchenko wrote: > On some distributions the mkfs.ext4 is under /sbin and /sbin is not set > for mere users. Include /sbin to the PATH when creating ext4 disk image, > so that users won't get a scary traceback from Python. Note, patches 1

[PATCH v2 2/4] test: Allow simple glob pattern in the test name

2021-02-11 Thread Andy Shevchenko
When run `ut dm [test name]` allow to use simple pattern to run all tests started with given prefix. For example, to run all ACPI test cases: ut dm acpi* Signed-off-by: Andy Shevchenko --- v2: rebased against dm/test-working branch (Simon) test/test-main.c | 11 +-- 1 file

[PATCH v2 3/4] test: Use positive conditional in test_matches()

2021-02-11 Thread Andy Shevchenko
It is easier to read the positive conditional. While at it, convert hard coded length of "_test_" to strlen("_test_") which will be converted to a constant bu optimizing compiler. Signed-off-by: Andy Shevchenko --- v2: new patch test/test-main.c | 12 ++-- 1 file c

[PATCH v2 4/4] test: Don't unmount not (yet) mounted system

2021-02-11 Thread Andy Shevchenko
-by: Andy Shevchenko --- v2: new patch test/py/tests/test_fs/conftest.py | 78 ++- 1 file changed, 56 insertions(+), 22 deletions(-) diff --git a/test/py/tests/test_fs/conftest.py b/test/py/tests/test_fs/conftest.py index ec70e8c4ef3f..50af9efcf768 100644 --- a/test

[PATCH v2 1/4] test: Include /sbin to the PATH when creating ext4 disk image

2021-02-11 Thread Andy Shevchenko
On some distributions the mkfs.ext4 is under /sbin and /sbin is not set for mere users. Include /sbin to the PATH when creating ext4 disk image, so that users won't get a scary traceback from Python. Cc: Patrick Delaunay Signed-off-by: Andy Shevchenko --- v2: used '/sbin' as is (Simon) test/py

Re: [PATCH v1] test: Allow simple glob pattern in the test name

2021-02-08 Thread Andy Shevchenko
On Mon, Feb 08, 2021 at 10:07:55AM -0700, Simon Glass wrote: > On Mon, 8 Feb 2021 at 04:34, Andy Shevchenko > wrote: > > On Sun, Feb 07, 2021 at 07:37:55AM -0700, Simon Glass wrote: > > > On Fri, 5 Feb 2021 at 13:46, Andy Shevchenko > > > wrote: > > > >

Re: [PATCH v1] test: Allow simple glob pattern in the test name

2021-02-08 Thread Andy Shevchenko
On Sun, Feb 07, 2021 at 07:37:55AM -0700, Simon Glass wrote: > On Fri, 5 Feb 2021 at 13:46, Andy Shevchenko > wrote: > > On Fri, Feb 05, 2021 at 09:17:27PM +0200, Andy Shevchenko wrote: > > > On Fri, Feb 05, 2021 at 08:15:25PM +0200, Andy Shevchenko wrote: > > > &

Re: [PATCH v1] test: Allow simple glob pattern in the test name

2021-02-05 Thread Andy Shevchenko
On Fri, Feb 05, 2021 at 09:17:27PM +0200, Andy Shevchenko wrote: > On Fri, Feb 05, 2021 at 08:15:25PM +0200, Andy Shevchenko wrote: > > On Fri, Feb 05, 2021 at 07:34:49PM +0200, Andy Shevchenko wrote: > > > On Thu, Feb 04, 2021 at 08:17:24PM -0700, Simon Glass wrote: > >

Re: [PATCH v1] test: Include /sbin to the PATH when creating ext4 disk image

2021-02-05 Thread Andy Shevchenko
On Fri, Feb 05, 2021 at 07:29:40PM +0200, Andy Shevchenko wrote: > On Thu, Feb 04, 2021 at 08:17:23PM -0700, Simon Glass wrote: > > On Wed, 3 Feb 2021 at 08:32, Andy Shevchenko > > wrote: > > ... > > > > if os.path.exists(persistent): > > &

Re: [PATCH v2 2/2] console: Don't start/stop console if stdio device invalid

2021-02-05 Thread Andy Shevchenko
On Fri, Feb 05, 2021 at 01:07:02PM -0500, Tom Rini wrote: > On Fri, Feb 05, 2021 at 12:50:56PM -0500, Tom Rini wrote: > > On Fri, Feb 05, 2021 at 07:06:54PM +0200, Andy Shevchenko wrote: > > > On Wed, Feb 03, 2021 at 11:50:53AM +0200, Andy Shevchenko wrote: ... > >

Re: [PATCH v1] test: Allow simple glob pattern in the test name

2021-02-05 Thread Andy Shevchenko
On Fri, Feb 05, 2021 at 08:15:25PM +0200, Andy Shevchenko wrote: > On Fri, Feb 05, 2021 at 07:34:49PM +0200, Andy Shevchenko wrote: > > On Thu, Feb 04, 2021 at 08:17:24PM -0700, Simon Glass wrote: > > ... > > > Btw, you have an issue there, i.e. if test case failed, a

Re: [PATCH v1] test: Allow simple glob pattern in the test name

2021-02-05 Thread Andy Shevchenko
On Fri, Feb 05, 2021 at 08:15:25PM +0200, Andy Shevchenko wrote: > On Fri, Feb 05, 2021 at 07:34:49PM +0200, Andy Shevchenko wrote: > > On Thu, Feb 04, 2021 at 08:17:24PM -0700, Simon Glass wrote: > > ... > > > Btw, you have an issue there, i.e. if test case failed, a

Re: [PATCH v1] test: Allow simple glob pattern in the test name

2021-02-05 Thread Andy Shevchenko
On Fri, Feb 05, 2021 at 07:34:49PM +0200, Andy Shevchenko wrote: > On Thu, Feb 04, 2021 at 08:17:24PM -0700, Simon Glass wrote: ... > Btw, you have an issue there, i.e. if test case failed, all percentage after > it > goes red, which is wrong. One more thing, is it known bug

Re: [PATCH v1] test: Allow simple glob pattern in the test name

2021-02-05 Thread Andy Shevchenko
On Thu, Feb 04, 2021 at 08:17:24PM -0700, Simon Glass wrote: > On Wed, 3 Feb 2021 at 08:32, Andy Shevchenko > wrote: > > > > When run `ut dm [test name]` allow to use simple pattern to run all tests > > started with given prefix. For example, to run all ACPI test cases

Re: [PATCH v1] test: Include /sbin to the PATH when creating ext4 disk image

2021-02-05 Thread Andy Shevchenko
On Thu, Feb 04, 2021 at 08:17:23PM -0700, Simon Glass wrote: > On Wed, 3 Feb 2021 at 08:32, Andy Shevchenko > wrote: ... > > if os.path.exists(persistent): > > c.log.action('Disk image file ' + persistent + ' already exists') > > else: > > +

Re: [PATCH v2 2/2] console: Don't start/stop console if stdio device invalid

2021-02-05 Thread Andy Shevchenko
On Wed, Feb 03, 2021 at 11:50:53AM +0200, Andy Shevchenko wrote: > On Mon, Feb 1, 2021 at 9:29 PM Tom Rini wrote: > > > > On Fri, Jan 29, 2021 at 09:50:50AM +0100, Matthias Brugger wrote: > > > > > > > > > On 28/01/2021 16:52, Andy Shevchenko wrote:

[PATCH v1] test: Allow simple glob pattern in the test name

2021-02-03 Thread Andy Shevchenko
When run `ut dm [test name]` allow to use simple pattern to run all tests started with given prefix. For example, to run all ACPI test cases: ut dm acpi* Signed-off-by: Andy Shevchenko --- test/dm/test-main.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git

[PATCH v1] test: Include /sbin to the PATH when creating ext4 disk image

2021-02-03 Thread Andy Shevchenko
On some distributions the mkfs.ext4 is under /sbin and /sbin is not set for mere users. Include /sbin to the PATH when creating ext4 disk image, so that users won't get a scary traceback from Python. Signed-off-by: Andy Shevchenko --- test/py/tests/test_env.py | 3 +++ 1 file changed, 3

Re: [PATCH v2 2/2] console: Don't start/stop console if stdio device invalid

2021-02-03 Thread Andy Shevchenko
On Mon, Feb 1, 2021 at 9:29 PM Tom Rini wrote: > > On Fri, Jan 29, 2021 at 09:50:50AM +0100, Matthias Brugger wrote: > > > > > > On 28/01/2021 16:52, Andy Shevchenko wrote: > > > On Thu, Jan 28, 2021 at 02:12:40PM +0100, Nicolas Saenz Julienne wrote: > &

Re: [PATCH v1] doc: README.distro: Special case with Windows formatted disk

2021-01-29 Thread Andy Shevchenko
On Fri, Jan 29, 2021 at 11:39 PM Heinrich Schuchardt wrote: > On 1/29/21 10:05 PM, Andy Shevchenko wrote: > > On Fri, Jan 29, 2021 at 9:28 PM Tom Rini wrote: > >> On Mon, Dec 28, 2020 at 08:27:49PM +0200, Andy Shevchenko wrote: > >>> On Mon, Dec 28, 2020 at 06:5

Re: [PATCH v1] doc: README.distro: Special case with Windows formatted disk

2021-01-29 Thread Andy Shevchenko
On Fri, Jan 29, 2021 at 9:28 PM Tom Rini wrote: > On Mon, Dec 28, 2020 at 08:27:49PM +0200, Andy Shevchenko wrote: > > On Mon, Dec 28, 2020 at 06:50:39PM +0100, Pali Rohár wrote: ... > > The case I got into has been achieved by very standard procedures. Hence > > i

Re: [PATCH] test: correct entry point to pytest

2021-01-29 Thread Andy Shevchenko
is up as part of picking up general fixes. Thanks, Tom! > And as I've thrown this at everything-new (to see what happens there) + > sandbox, as well as my regular lab of testing with the old version and > everything is fine: > > Tested-by: Tom Rini -- With Best Regards, Andy Shevchenko

Re: [PATCH v1] usb: kbd: destroy device after console is stopped

2021-01-28 Thread Andy Shevchenko
On Thu, Jan 28, 2021 at 10:47 PM Tom Rini wrote: > On Thu, Jan 28, 2021 at 10:35:37PM +0200, Andy Shevchenko wrote: > Running this here on sandbox I get: > FAILED test/py/tests/test_ut.py::test_ut[ut_dm_bootcount] - OSError: [Errno > 5] Input/output ... Btw this is the wrong te

Re: [PATCH v1] usb: kbd: destroy device after console is stopped

2021-01-28 Thread Andy Shevchenko
On Thu, Jan 28, 2021 at 10:47 PM Tom Rini wrote: > On Thu, Jan 28, 2021 at 10:35:37PM +0200, Andy Shevchenko wrote: > > On Thu, Jan 28, 2021 at 06:19:56PM +0100, Nicolas Saenz Julienne wrote: > > > On Thu, 2021-01-28 at 18:55 +0200, Andy Shevchenko wrote: ... > > &

Re: [PATCH v1] usb: kbd: destroy device after console is stopped

2021-01-28 Thread Andy Shevchenko
On Thu, Jan 28, 2021 at 06:19:56PM +0100, Nicolas Saenz Julienne wrote: > Hi Andy, > > On Thu, 2021-01-28 at 18:55 +0200, Andy Shevchenko wrote: > > In case of IOMUX enabled it assumes that console devices in the list > > are available to get them stopped properly

Re: [PATCH] test: correct entry point to pytest

2021-01-28 Thread Andy Shevchenko
ctory_name user-supplied-arguments > -args = [os.path.dirname(__file__) + '/tests'] > -args.extend(sys.argv) > - > if __name__ == '__main__': > -sys.exit(load_entry_point('pytest', 'console_scripts', 'pytest')(args)) > +# argv; py.test test_directory_name user-supplied-arguments > +args = [os.path.dirname(__file__) + '/tests'] > +args.extend(sys.argv) > +sys.exit(pytest.main(args)) > -- > 2.29.2 > -- With Best Regards, Andy Shevchenko

Re: [PATCH v1] usb: kbd: destroy device after console is stopped

2021-01-28 Thread Andy Shevchenko
On Thu, Jan 28, 2021 at 01:24:04PM -0500, Tom Rini wrote: > On Thu, Jan 28, 2021 at 08:18:47PM +0200, Andy Shevchenko wrote: > > On Thu, Jan 28, 2021 at 12:58:30PM -0500, Tom Rini wrote: > > > On Thu, Jan 28, 2021 at 07:52:36PM +0200, Andy Shevchenko wrote: > > > >

Re: [PATCH] test: correct entry point to pytest

2021-01-28 Thread Andy Shevchenko
irectory_name user-supplied-arguments > -args = [os.path.dirname(__file__) + '/tests'] > -args.extend(sys.argv) > - > if __name__ == '__main__': > -sys.exit(load_entry_point('pytest', 'console_scripts', 'pytest')(args)) > +# argv; py.test test_directory_name user-su

Re: [PATCH v1] usb: kbd: destroy device after console is stopped

2021-01-28 Thread Andy Shevchenko
On Thu, Jan 28, 2021 at 12:58:30PM -0500, Tom Rini wrote: > On Thu, Jan 28, 2021 at 07:52:36PM +0200, Andy Shevchenko wrote: > > On Thu, Jan 28, 2021 at 07:46:49PM +0200, Andy Shevchenko wrote: > > > On Thu, Jan 28, 2021 at 06:19:56PM +0100, Nicolas Saenz Julienne wrot

Re: [PATCH v1] usb: kbd: destroy device after console is stopped

2021-01-28 Thread Andy Shevchenko
On Thu, Jan 28, 2021 at 07:52:36PM +0200, Andy Shevchenko wrote: > On Thu, Jan 28, 2021 at 07:46:49PM +0200, Andy Shevchenko wrote: > > On Thu, Jan 28, 2021 at 06:19:56PM +0100, Nicolas Saenz Julienne wrote: > > > Hi Andy, > > > > > > On Thu, 2021-01-28 a

Re: [PATCH v1] usb: kbd: destroy device after console is stopped

2021-01-28 Thread Andy Shevchenko
On Thu, Jan 28, 2021 at 07:46:49PM +0200, Andy Shevchenko wrote: > On Thu, Jan 28, 2021 at 06:19:56PM +0100, Nicolas Saenz Julienne wrote: > > Hi Andy, > > > > On Thu, 2021-01-28 at 18:55 +0200, Andy Shevchenko wrote: > > > In case of IOMUX enabled it assumes th

Re: [PATCH v1] usb: kbd: destroy device after console is stopped

2021-01-28 Thread Andy Shevchenko
On Thu, Jan 28, 2021 at 06:19:56PM +0100, Nicolas Saenz Julienne wrote: > Hi Andy, > > On Thu, 2021-01-28 at 18:55 +0200, Andy Shevchenko wrote: > > In case of IOMUX enabled it assumes that console devices in the list > > are available to get them stopped properly

Re: [PATCH v2 0/2] Console/stdio use after free

2021-01-28 Thread Andy Shevchenko
performing the stop operation. It's not ideal, but I > couldn't figure out a nicer way to fix this. I have just sent another approach, can you test it instead, please? -- With Best Regards, Andy Shevchenko

[PATCH v1] usb: kbd: destroy device after console is stopped

2021-01-28 Thread Andy Shevchenko
wap the order of device deregistration and IOMUX update to avoid the use-after-free. Fixes: 3cbcb2892809 ("usb: Fix usb_kbd_deregister when console-muxing is used") Fixes: 8a8348703081 ("dm: usb: Add a remove() method for USB keyboards") Reported-by: Nicolas Saenz Julienne Signed-

Re: [PATCH v2 2/2] console: Don't start/stop console if stdio device invalid

2021-01-28 Thread Andy Shevchenko
/ I see now. I think I have experienced this issue from time to time. I will look at it. Tom, Simon, please hold on applying these for a while. > + if (!stdio_valid(sdev)) > + return false; -- With Best Regards, Andy Shevchenko

Re: [PATCH 1/1] cmd: CMD_ACPI depends on ACPIGEN

2021-01-20 Thread Andy Shevchenko
On Wed, Jan 20, 2021 at 10:46:23PM +0200, Andy Shevchenko wrote: > On Wed, Jan 20, 2021 at 09:37:56PM +0100, Heinrich Schuchardt wrote: > > Trying to compile qemu-x86_64_defconfig with CONFIG_CMD_ACPI=y and > > CONFIG_ACPIGEN=n fails with > > > > ld.bfd: cmd/built-in.o:

Re: [PATCH 1/1] cmd: CMD_ACPI depends on ACPIGEN

2021-01-20 Thread Andy Shevchenko
List and dump ACPI tables. ACPI (Advanced Configuration and Power > Interface) is used mostly on x86 for providing information to the > -- > 2.29.2 > -- With Best Regards, Andy Shevchenko

Re: [PATCH 0/2] Console/stdio use after free

2021-01-20 Thread Andy Shevchenko
console_list accordingly. -- With Best Regards, Andy Shevchenko

Re: Invitation: Regular U-Boot video call (Tuesday 19th)

2021-01-13 Thread Andy Shevchenko
On Thu, Jan 14, 2021 at 12:00 AM Simon Glass wrote: > On Wed, 13 Jan 2021 at 06:00, Andy Shevchenko > wrote: > > On Wed, Jan 13, 2021 at 5:39 AM Simon Glass wrote: ... > > I added myself with a topic, but two issues so far: > > - i have no camera setup > &

Re: Invitation: Regular U-Boot video call (Tuesday 19th)

2021-01-13 Thread Andy Shevchenko
tant meeting, shifting later by half an hour will solve it > [1] https://bit.ly/3bFvwA1 -- With Best Regards, Andy Shevchenko

Re: [PATCH 1/1] image: usage of value ~0UL for intrd_high

2021-01-10 Thread Andy Shevchenko
at 08:33:40PM +0100, Heinrich Schuchardt wrote: > >> >> On 1/9/21 7:58 PM, Tom Rini wrote: > >> >> > On Sat, Jan 09, 2021 at 08:47:07PM +0200, Andy Shevchenko wrote: > >> >> > > On Sat, Jan 9, 2021 at 8:06 PM Heinrich Schuchardt > >> >

Re: [PATCH 1/1] image: usage of value ~0UL for intrd_high

2021-01-09 Thread Andy Shevchenko
gh. All those F:s are hard to read in the comments and documentation and typo prone. I would prefer to rephrase like "all 1:s value in 32- or 64-bit format" or alike. -- With Best Regards, Andy Shevchenko

Re: [PATCH v1] doc: README.distro: Special case with Windows formatted disk

2020-12-28 Thread Andy Shevchenko
On Mon, Dec 28, 2020 at 06:50:39PM +0100, Pali Rohár wrote: > On Sunday 27 December 2020 11:08:05 Andy Shevchenko wrote: > > On Sunday, December 27, 2020, Pali Rohár wrote: > > > On Friday 17 January 2020 12:44:51 Andy Shevchenko wrote: ... > > > > +Using

Re: [PATCH 13/13] Nokia RX-51: Enable usbtty serial console by default

2020-12-27 Thread Andy Shevchenko
On Sun, Dec 27, 2020 at 6:35 PM Pali Rohár wrote: > On Sunday 27 December 2020 18:28:25 Andy Shevchenko wrote: > > On Sun, Nov 29, 2020 at 6:53 PM Pali Rohár wrote: > > > > > > Now when usbtty serial console is fixed in U-Boot enable it for Nokia > &g

Re: [PATCH 13/13] Nokia RX-51: Enable usbtty serial console by default

2020-12-27 Thread Andy Shevchenko
d to support composite devices. So, kinda disagreement from my side as a summary on this. But disclaimer, I'm not a maintainer here, just my 2 cents. -- With Best Regards, Andy Shevchenko

Re: [PATCH 1/1] pinctrl: mediatek: correct error handling

2020-12-27 Thread Andy Shevchenko
t ret = -ENOENT; It’s not the best approach. Consider to assign it in the certain code path. > ofnode node; > > drv = lists_uclass_lookup(UCLASS_GPIO); > -- > 2.29.2 > > -- With Best Regards, Andy Shevchenko

Re: [PATCH v1] doc: README.distro: Special case with Windows formatted disk

2020-12-27 Thread Andy Shevchenko
On Sunday, December 27, 2020, Pali Rohár wrote: > On Friday 17 January 2020 12:44:51 Andy Shevchenko wrote: > > If someone wants to use shared (by installed OS) eMMC partition to > > the Windows to boot from, it's not possible due to U-Boot limitations. > > > > Desc

Re: [PATCH v2 4/7] IOMUX: Preserve console list if realloc() fails

2020-12-21 Thread Andy Shevchenko
On Mon, Dec 21, 2020 at 09:47:03AM -0700, Simon Glass wrote: > On Mon, 21 Dec 2020 at 05:00, Andy Shevchenko > wrote: > > On Fri, Dec 18, 2020 at 07:29:19PM -0700, Simon Glass wrote: > > > On Wed, 16 Dec 2020 at 16:16, Andy Shevchenko > > > wrote: > > > >

Re: [PATCH v2] doc: edison: Update information about xFSTK

2020-12-21 Thread Andy Shevchenko
On Mon, Nov 30, 2020 at 01:12:24PM -0700, Simon Glass wrote: > On Fri, 27 Nov 2020 at 08:59, Andy Shevchenko > wrote: > > > > xFSTK sources got a new home under Edison Firmware Group on GitHub [1]. > > Update Intel Edison documentation accordingly. > > >

<    1   2   3   4   5   6   7   8   9   10   >