Rename search_device() to console_search_dev() since it's in console.h.
Suggested-by: Simon Glass
Signed-off-by: Andy Shevchenko
---
v3: new patch
common/console.c | 18 +-
common/iomux.c| 4 ++--
common/stdio.c| 4 ++--
include/console.h | 2 +-
4 files changed, 14
Refactor iomux_doenv() a bit in order to increase readability.
There is no change in code generation on x86.
Signed-off-by: Andy Shevchenko
Reviewed-by: Simon Glass
---
v3: added tag
common/iomux.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/common/iomux.c
Obviously the following has unnecessary indentation level in 'else' branch.
if (foo) {
...
return;
} else {
...
}
Drop indentation level by removing redundant 'else'.
Signed-off-by: Andy Shevchenko
Reviewed-by: Simon Glass
Provide a documentation for console_search_dev().
Suggested-by: Simon Glass
Signed-off-by: Andy Shevchenko
---
v3: new patch
include/console.h | 10 ++
1 file changed, 10 insertions(+)
diff --git a/include/console.h b/include/console.h
index bb186e7be04d..7e628c0cf836 100644
When at some point environment shrinks we need to stop dropped devices.
Signed-off-by: Andy Shevchenko
Reviewed-by: Simon Glass
---
v3: added tag
common/iomux.c | 19 ---
1 file changed, 16 insertions(+), 3 deletions(-)
diff --git a/common/iomux.c b/common/iomux.c
index
In the future we would like to stop unused consoles and
also add a reference counting to avoid imbalanced calls
to ->start() and ->stop() in some cases.
Signed-off-by: Andy Shevchenko
Reviewed-by: Simon Glass
---
v3: added comments to the function declarations
common/console.c
() for good and thus preserve console list
in case of failed allocation.
Fixes: 16a28ef219c2 ("IOMUX: Add console multiplexing support.")
Signed-off-by: Andy Shevchenko
Reviewed-by: Simon Glass
---
v3: added tag
common/iomux.c | 13 ++---
1 file changed, 2 insertions(+), 11
There is no need to call ->start() for already started device. All the same,
there is no need to call ->stop() for devices still in use.
For now enforce this only for IOMUX case.
Cc: Simon Glass
Signed-off-by: Andy Shevchenko
---
v3: renamed new function and added a documen
search_device() is defined in console.c. Move its declaration
to an appropriate header file.
Signed-off-by: Andy Shevchenko
Reviewed-by: Simon Glass
---
v3: added tag and changed subject prefix
include/console.h | 2 ++
include/iomux.h | 1 -
2 files changed, 2 insertions(+), 1 deletion
On Fri, Dec 18, 2020 at 07:29:21PM -0700, Simon Glass wrote:
> On Wed, 16 Dec 2020 at 16:16, Andy Shevchenko
> wrote:
> >
> > Refactor iomux_doenv() a bit in order to increase readability.
> > There is no change in code generation on x86.
...
> Reviewed-by: Simon Gl
On Fri, Dec 18, 2020 at 07:29:19PM -0700, Simon Glass wrote:
> On Wed, 16 Dec 2020 at 16:16, Andy Shevchenko
> wrote:
> >
> > It's realloc() 101 to avoid `foo = realloc(foo, ...);` call
> > due to getting a memory leak.
>
> Hmm I don't think I knew that...
into one place.
Reviewed-by: Andy Shevchenko
> Signed-off-by: Simon Glass
> ---
>
> drivers/clk/clk-uclass.c| 2 +-
> drivers/core/device.c | 2 +-
> drivers/gpio/sandbox.c | 2 +-
> drivers/i2c/designware_i2c_pci.c| 4 ++--
> d
On Sat, Dec 19, 2020 at 10:40:09AM -0700, Simon Glass wrote:
> Now that the sequence-numbering migration is complete, rename this member
> back to seq_, adding an underscore to indicate it is internal to driver
> model.
Reviewed-by: Andy Shevchenko
> Signed-off-by:
On Sat, Dec 19, 2020 at 10:40:04AM -0700, Simon Glass wrote:
> With the new of-platdata, these need to be available to dt_platdata.c
> so must be in header files. Move them and add the dtd struct too.
Reviewed-by: Andy Shevchenko
> Signed-off-by: Simon Glass
> ---
>
> ar
On Sat, Dec 19, 2020 at 10:39:53AM -0700, Simon Glass wrote:
> Move this struct into a header file so that dtoc can include it in its
> dt-platdata.c file.
Reviewed-by: Andy Shevchenko
> Signed-off-by: Simon Glass
> ---
>
> arch/sandbox/include
On Thu, Dec 17, 2020 at 1:16 AM Andy Shevchenko
wrote:
> There is no need to call ->start() for already started device. All the same,
an already
> there is no need to call ->stop() for devices still in use.
>
> For now enforce this only for CONSOLE_MUX case.
now, enfor
On Wed, Dec 16, 2020 at 08:25:04AM -0700, Simon Glass wrote:
> Most drivers use these access methods but a few do not. Update them.
>
> In some cases the access is not permitted, so mark those with a FIXME tag
> for the maintainer to check.
Acked-by: Andy Shevchenko
> Signe
On Wed, Dec 16, 2020 at 09:40:30PM +0200, Andy Shevchenko wrote:
> On Wed, Dec 16, 2020 at 8:05 PM Andy Shevchenko
> wrote:
...
> It seems more patches will come. However, this one, since it is a fix,
> can be applied disregarding that fact. Therefore please skip the rest
>
Refactor iomux_doenv() a bit in order to increase readability.
There is no change in code generation on x86.
Signed-off-by: Andy Shevchenko
---
v2: no changes
common/iomux.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/common/iomux.c b/common/iomux.c
index
() for good and thus preserve console list
in case of failed allocation.
Fixes: 16a28ef219c2 ("IOMUX: Add console multiplexing support.")
Signed-off-by: Andy Shevchenko
---
v2: no changes
common/iomux.c | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
diff --gi
When at some point environment shrinks we need to stop dropped devices.
Signed-off-by: Andy Shevchenko
---
v2: rebased to use console_stop()
common/iomux.c | 19 ---
1 file changed, 16 insertions(+), 3 deletions(-)
diff --git a/common/iomux.c b/common/iomux.c
index 8a063563aa27
Obviously the following has unnecessary indentation level in 'else' branch.
if (foo) {
...
return;
} else {
...
}
Drop indentation level by removing redundant 'else'.
Signed-off-by: Andy Shevchenko
---
v2: no changes
search_device() is defined in console.c. Move its declaration
to an appropriate header file.
Signed-off-by: Andy Shevchenko
---
v2: new patch
include/console.h | 2 ++
include/iomux.h | 1 -
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/console.h b/include/console.h
In the future we would like to stop unused consoles and
also add a reference counting to avoid imbalanced calls
to ->start() and ->stop() in some cases.
Signed-off-by: Andy Shevchenko
---
v2: new patch
common/console.c | 30 +++---
include/console.h | 3 +++
2
There is no need to call ->start() for already started device. All the same,
there is no need to call ->stop() for devices still in use.
For now enforce this only for CONSOLE_MUX case.
Signed-off-by: Andy Shevchenko
---
v2: new patch
common/console.c | 21 +
1 file c
On Wed, Dec 16, 2020 at 8:05 PM Andy Shevchenko
wrote:
>
> It's realloc() 101 to avoid `foo = realloc(foo, ...);` call
> due to getting a memory leak.
>
> Actually it's not clear why realloc() has been used here.
> If we shrink the array, the memcpy() overwrites it anyway
&
Refactor iomux_doenv() a bit in order to increase readability.
There is no change in code generation on x86.
Signed-off-by: Andy Shevchenko
---
common/iomux.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/common/iomux.c b/common/iomux.c
index 9fae124442c1
() for good and thus preserve console list
in case of failed allocation.
Fixes: 16a28ef219c2 ("IOMUX: Add console multiplexing support.")
Signed-off-by: Andy Shevchenko
---
common/iomux.c | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/common/iomux.
Obviously the following has unnecessary indentation level in 'else' branch.
if (foo) {
...
return;
} else {
...
}
Drop indentation level by removing redundant 'else'.
Signed-off-by: Andy Shevchenko
---
common/iomux.c | 10
When at some point environment shrinks we need to stop dropped devices.
Signed-off-by: Andy Shevchenko
---
common/iomux.c | 25 ++---
1 file changed, 22 insertions(+), 3 deletions(-)
diff --git a/common/iomux.c b/common/iomux.c
index 8a063563aa27..b6936317b12e 100644
On Wed, Dec 16, 2020 at 08:24:55AM -0700, Simon Glass wrote:
> Lower case should be used for function names. Update this driver and its
> callers accordingly.
Reviewed-by: Andy Shevchenko
> Signed-off-by: Simon Glass
> ---
>
> arch/arm/mach-davinci/da850_lowlevel.c |
On Wed, Dec 16, 2020 at 08:24:54AM -0700, Simon Glass wrote:
> Typedefs should not be used in U-Boot and structs should be lower case.
> Update the code to use struct ns16550 consistently.
>
> Put a header guard on the file while we are here.
Reviewed-by: Andy Shevchenko
> Signe
On Mon, Nov 30, 2020 at 01:12:17PM -0700, Simon Glass wrote:
> On Fri, 27 Nov 2020 at 05:40, Andy Shevchenko
> wrote:
> >
> > It appears that U-Boot works by luck on Intel Edison board because the
> > amount
> > of RAM is less than 1 GB and standard way of
On Tue, Dec 8, 2020 at 7:14 PM André Przywara wrote:
> On 08/12/2020 15:45, Andy Shevchenko wrote:
> > For the sake of consistency (*) and order of initialization, i.e.
> > after we have got the ethernet address, interrupt and timer initialized,
> > try to initializ
For the sake of consistency (*) and order of initialization, i.e.
after we have got the ethernet address, interrupt and timer initialized,
try to initialize USB ethernet gadget.
*) for example, zynqmp uses same order.
Signed-off-by: Andy Shevchenko
---
arch/arm/Kconfig| 1 +
board/sunxi
t; spec, e.g. as a part of OASIS Standards. The former seems better but is
> not perfect too...
With all respect... https://xkcd.com/927/
--
With Best Regards,
Andy Shevchenko
DM is the modern default approach for the drivers in U-Boot.
It also allows to configure code via Device Tree.
Move Intel Edison to use DM_USB_GADGET and drop hard coded values.
Signed-off-by: Andy Shevchenko
---
v2: cleaned up arch/x86/cpu/tangier/Kconfig as well
arch/x86/cpu/tangier/Kconfig
Use generic Synopsys DesignWare 3 driver on Intel Edison.
For now it's just a stub which allows future refactoring.
Signed-off-by: Andy Shevchenko
---
v2: no changes
arch/x86/cpu/tangier/Kconfig| 3 +++
arch/x86/dts/edison.dts | 4
drivers/usb/dwc3/dwc3-generic.c | 1 +
3 files
On Thu, Dec 3, 2020 at 6:26 PM Andy Shevchenko
wrote:
>
> DM is the modern default approach for the drivers in U-Boot.
> It also allows to configure code via Device Tree.
>
> Move Intel Edison to use DM_USB_GADGET and drop hard coded values.
Missed one more file to be slightly cl
DM is the modern default approach for the drivers in U-Boot.
It also allows to configure code via Device Tree.
Move Intel Edison to use DM_USB_GADGET and drop hard coded values.
Signed-off-by: Andy Shevchenko
---
arch/x86/dts/edison.dts | 8
board/intel/edison/edison.c | 35
Use generic Synopsys DesignWare 3 driver on Intel Edison.
For now it's just a stub which allows future refactoring.
Signed-off-by: Andy Shevchenko
---
arch/x86/cpu/tangier/Kconfig| 3 +++
arch/x86/dts/edison.dts | 4
drivers/usb/dwc3/dwc3-generic.c | 1 +
3 files changed, 8
The platforms based on Intel Tangier may have different requirements
how to create bootloader bundle to supply to a device. Currently
the BINMAN approach is for Intel Edison only.
Signed-off-by: Andy Shevchenko
---
arch/x86/cpu/tangier/Kconfig | 1 -
board/intel/edison/Kconfig | 1 +
2 files
In case of usb_add_function() failure the error path has an issue,
i.e the global pointer variable is assigned to garbage
Fix the above mentioned issue by assigning pointer to NULL.
Signed-off-by: Andy Shevchenko
---
drivers/usb/gadget/f_fastboot.c | 2 +-
1 file changed, 1 insertion(+), 1
In case of usb_add_function() failure the error path has two issues:
- the potentially allocated structure isn't getting freed
- the global pointer variable is assigned to garbage
Fix the above mentioned issues by freeing memory and assigning NULL.
Signed-off-by: Andy Shevchenko
---
drivers
get_rkusb() mistakenly uses integers without cast.
Convert them to proper type.
Signed-off-by: Andy Shevchenko
---
drivers/usb/gadget/f_rockusb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/f_rockusb.c b/drivers/usb/gadget/f_rockusb.c
index
On Wed, Dec 02, 2020 at 01:37:35PM -0500, Tom Rini wrote:
> On Wed, Dec 02, 2020 at 08:28:55PM +0200, Andy Shevchenko wrote:
> > On Thu, Nov 19, 2020 at 10:21:39PM +0200, Andy Shevchenko wrote:
> > > Update Tom's address
> >
> > Tom, should I resend with your address
On Thu, Nov 19, 2020 at 10:21:39PM +0200, Andy Shevchenko wrote:
> Update Tom's address
Tom, should I resend with your address fixed?
--
With Best Regards,
Andy Shevchenko
Like in the rest of x86 boards append CPU to the board compatible string.
Signed-off-by: Andy Shevchenko
---
arch/x86/dts/edison.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/dts/edison.dts b/arch/x86/dts/edison.dts
index bc84bc892e71..97cc6ec386c2 100644
On Fri, Nov 27, 2020 at 05:46:54PM +0200, Andy Shevchenko wrote:
> xFSTK sources got a new home under Edison Firmware Group on GitHub [1].
> Update Intel Edison documentation accordingly.
>
> While here, fix couple of typos.
Please, discard this. V2 is better.
--
With Best R
xFSTK sources got a new home under Edison Firmware Group on GitHub [1].
Update Intel Edison documentation accordingly.
While here, fix couple of typos.
[1]: https://github.com/edison-fw
Signed-off-by: Andy Shevchenko
---
v2: more fixes to have nice looking PDF
doc/board/intel/edison.rst | 49
xFSTK sources got a new home under Edison Firmware Group on GitHub [1].
Update Intel Edison documentation accordingly.
While here, fix couple of typos.
[1]: https://github.com/edison-fw
Signed-off-by: Andy Shevchenko
---
doc/board/intel/edison.rst | 32 +---
1 file
None of the driver for Edison is using DM_PCI_COMPAT, hence drop it.
Signed-off-by: Andy Shevchenko
---
configs/edison_defconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/configs/edison_defconfig b/configs/edison_defconfig
index c69c3f883c19..ab2811eca9dc 100644
--- a/configs
("x86: Add Intel Tangier support")
Signed-off-by: Andy Shevchenko
---
arch/x86/cpu/tangier/sdram.c | 43
1 file changed, 43 insertions(+)
diff --git a/arch/x86/cpu/tangier/sdram.c b/arch/x86/cpu/tangier/sdram.c
index df3b9e4ec975..afb08476e
On Wed, Nov 25, 2020 at 7:03 PM Simon Glass wrote:
> On Wed, 25 Nov 2020 at 09:58, Andy Shevchenko
> wrote:
> > On Wed, Nov 25, 2020 at 5:45 PM Simon Glass wrote:
...
> > pci_init() makes the system hang.
> >
> > WRT video I will try later when I se
On Wed, Nov 25, 2020 at 7:11 PM Siarhei Siamashka
wrote:
> On Wed, Nov 25, 2020 at 5:36 PM Andy Shevchenko
> wrote:
...
> Does this tablet / phone have an MMC slot?
In fact it does.
> For example, on all
> Allwinner tablets it is technically possible to use MMC pins
On Wed, Nov 25, 2020 at 5:45 PM Simon Glass wrote:
> On Wed, 25 Nov 2020 at 08:35, Andy Shevchenko
> wrote:
> > On Wed, Nov 25, 2020 at 5:23 PM Simon Glass wrote:
...
> > Thanks. But the question is still open why DM PCI et al. is not
> > getting initialized.
>
&
On Wed, Nov 25, 2020 at 5:55 PM Ovidiu Panait
wrote:
> On 25.11.2020 17:36, Andy Shevchenko wrote:
> On Wed, Nov 25, 2020 at 5:23 PM Simon Glass wrote:
> On Wed, 25 Nov 2020 at 08:07, Andy Shevchenko
> wrote:
> On Wed, Nov 25, 2020 at 4:50 PM Simon Glass wrote:
> On Wed, 25
On Wed, Nov 25, 2020 at 5:23 PM Simon Glass wrote:
> On Wed, 25 Nov 2020 at 08:07, Andy Shevchenko
> wrote:
> > On Wed, Nov 25, 2020 at 4:50 PM Simon Glass wrote:
> > > On Wed, 25 Nov 2020 at 06:26, Andy Shevchenko
> > > wrote:
...
> > > I think yo
On Wed, Nov 25, 2020 at 4:50 PM Simon Glass wrote:
> On Wed, 25 Nov 2020 at 06:26, Andy Shevchenko
> wrote:
> > On Wed, Nov 25, 2020 at 1:41 AM Simon Glass wrote:
> > > On Tue, 24 Nov 2020 at 12:46, Andy Shevchenko
> > > wrote:
> > > > On Tue,
On Wed, Nov 25, 2020 at 1:41 AM Simon Glass wrote:
> On Tue, 24 Nov 2020 at 12:46, Andy Shevchenko
> wrote:
> > On Tue, Nov 24, 2020 at 6:54 PM Simon Glass wrote:
> > > On Tue, 24 Nov 2020 at 06:57, Andy Shevchenko
> > > wrote:
...
> > > Did yo
On Wed, Nov 25, 2020 at 1:41 AM Simon Glass wrote:
> On Tue, 24 Nov 2020 at 12:46, Andy Shevchenko
> wrote:
> > Nope. The PCI (framebuffer) driver is not getting probed.
> >
> > Nevertheless the above problem is gone when I cleaned up configuration.
>
> I'm amaz
On Tue, Nov 24, 2020 at 6:54 PM Simon Glass wrote:
> On Tue, 24 Nov 2020 at 06:57, Andy Shevchenko
> wrote:
> > On Mon, Nov 23, 2020 at 9:08 PM Simon Glass wrote:
> > > On Mon, 23 Nov 2020 at 07:04, Andy Shevchenko
> > > wrote:
...
> > > Make s
On Mon, Nov 23, 2020 at 9:08 PM Simon Glass wrote:
> On Mon, 23 Nov 2020 at 07:04, Andy Shevchenko
> wrote:
> > I have been debugging U-Boot on a product (Android-based) device (*)
> > which is not yet supported by U-Boot. It's x86 based.
> >
> > I have stum
On Mon, Nov 23, 2020 at 9:18 PM Andy Shevchenko
wrote:
> On Mon, Nov 23, 2020 at 9:08 PM Simon Glass wrote:
> > On Mon, 23 Nov 2020 at 07:04, Andy Shevchenko
> > wrote:
> > Make sure that start.S puts the top of memory in a sensible place. If
> > something has
On Mon, Nov 23, 2020 at 9:08 PM Simon Glass wrote:
> On Mon, 23 Nov 2020 at 07:04, Andy Shevchenko
> wrote:
Thanks! My comments below.
> > I have been debugging U-Boot on a product (Android-based) device (*)
> > which is not yet supported by U-Boot. It's x86 based.
>
On Mon, Nov 23, 2020 at 4:05 PM Andy Shevchenko
wrote:
>
> Hi!
>
> I have been debugging U-Boot on a product (Android-based) device (*)
> which is not yet supported by U-Boot. It's x86 based.
>
> I have stumbled over the couple of things:
> 1/ it required me to enable
is
stuck / hangs. And it's time consuming...
--
With Best Regards,
Andy Shevchenko
Update Tom's address
On Thu, Nov 19, 2020 at 9:26 PM Andy Shevchenko
wrote:
>
> It seems nobody tested the debug() option in spin_lock_irqsave().
> Currently, when #define DEBUG, it spoils the compiler with
>
> In file included from drivers/usb/dwc3/gadget.c:18:
> drivers
.
Fixes: 0c06db598367 ("lib, linux: move linux specific defines to
linux/compat.h")
Cc: Heiko Schocher
Cc: Tom Rini
Signed-off-by: Andy Shevchenko
---
include/linux/compat.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/compat.h b/include/linux/comp
On Tue, Nov 10, 2020 at 2:35 PM Tom Rini wrote:
> On Tue, Nov 10, 2020 at 01:18:41PM +0100, Heinrich Schuchardt wrote:
> > On 11/10/20 1:16 PM, Tom Rini wrote:
> > > On Tue, Nov 10, 2020 at 01:00:06PM +0100, Heinrich Schuchardt wrote:
> > > > On 11/10/20 1
On Tue, Nov 10, 2020 at 12:40 PM Andy Shevchenko
wrote:
>
> On Tue, Nov 10, 2020 at 12:22 AM Tom Rini wrote:
> >
> > Hey all,
> >
> > It's regular release day and I'm back on schedule, so here's -rc2.
> >
> > There's a few small'ish things outstand
scripts/dtc/libfdt/fdt.c: In function ‘fdt_offset_ptr’:
scripts/dtc/libfdt/fdt.c:137:18: warning: comparison of integer
expressions of different signedness: ‘unsigned int’ and ‘int’
[-Wsign-compare]
137 | if ((absoffset < offset)
| ^
Is it known? Is fix available?
--
With Best Regards,
Andy Shevchenko
On Tue, Sep 22, 2020 at 12:45:43PM -0600, Simon Glass wrote:
> Add some documentation provided by Andy Shevchenko to describe how to
> use struct acpi_gpio.
Thanks!
I see Bin already applied this, perhaps follow up fix is needed. See below.
...
> + * Note that GpioIo doesn't have
On Mon, Sep 21, 2020 at 2:51 PM Andy Shevchenko
wrote:
>
> On Sun, Sep 06, 2020 at 03:43:47PM -0600, Simon Glass wrote:
> > Generate ACPI information for this device so that Linux can use it
> > correctly.
>
> > + ret = acpi_device_write_interrupt_or_gpio
On Mon, Sep 21, 2020 at 02:50:56PM +0300, Andy Shevchenko wrote:
> On Sun, Sep 06, 2020 at 03:43:47PM -0600, Simon Glass wrote:
> > Generate ACPI information for this device so that Linux can use it
> > correctly.
>
> > + ret = acpi_device_write_interrupt_or_gpio(ct
High as high, assuming active
Hopefully this helps (and maybe can be added to some documentation).
P.S. Why I2cSerialBus() and not I2cSerialBusV2() ?
--
With Best Regards,
Andy Shevchenko
On Mon, Sep 21, 2020 at 10:20:18AM +0800, Bin Meng wrote:
> On Tue, Sep 8, 2020 at 10:30 PM Andy Shevchenko
> wrote:
> >
> > The revisions are usually dates in hex-decimal format representing
> > mmdd. Print them in hex to see this clearly.
> >
> > Before:
f4 (v06 U-BOOT U-BOOTBL 20200908 INTL 0)
DSDT 000e4780 000ba0 (v02 U-BOOT U-BOOTBL 1 INTL 20200326)
...
Fixes: 0b885bcfd9b0 ("acpi: Add an acpi command")
Cc: Wolfgang Wallner
Signed-off-by: Andy Shevchenko
---
v2: fixed test cases as well (Bin)
cmd/acpi.c | 2 +-
test/dm/a
On Wed, Sep 16, 2020 at 05:00:26PM +0200, Wolfgang Wallner wrote:
> -----"Andy Shevchenko" schrieb: -
> > Betreff: Re: [PATCH 1/2] x86: acpi: Fix calculation of DSDT length
> >
> > On Wed, Sep 09, 2020 at 04:08:17PM +0300, Andy Shevchenko wrote:
> > >
y uninitialized (and thus random after every reset).
> Fixes: commit b288cd960072 ("x86: acpi: Generate SPCR table")
>
> Signed-off-by: Wolfgang Wallner
In tag block should not be any blank line, but I guess maintainer can fix this
when applying (i.o.w. no need to resend
On Wed, Sep 09, 2020 at 04:08:17PM +0300, Andy Shevchenko wrote:
> On Wed, Sep 09, 2020 at 02:33:20PM +0200, Wolfgang Wallner wrote:
> > Currently, the calculation for the length of the DSDT table includes any
> > bytes that are added for alignment, but those bytes are
y uninitialized (and thus random after every reset).
Fixes: tag?
In any case, after addressing below,
Reviewed-by: Andy Shevchenko
> Signed-off-by: Wolfgang Wallner
> ---
>
> arch/x86/lib/acpi_table.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch
after a call to
> acpi_inc_align(). Split this up into the following sequence:
>
> * acpi_inc()
> * Calculate DSDT length
> * acpi_align()
Perhaps Fixes: tag?
In any case,
Reviewed-by: Andy Shevchenko
> Signed-off-by: Wolfgang Wallner
>
> ---
>
> arch/x86/lib/acpi_table.
On Wed, Sep 09, 2020 at 09:15:22AM +0200, Wolfgang Wallner wrote:
> -----"Andy Shevchenko" schrieb: -
> > Betreff: Re: [PATCH v1] cmd: acpi: Print revisions in hex format
> > On Tue, Sep 08, 2020 at 05:32:08PM +0200, Wolfgang Wallner wrote:
> > &g
On Tue, Sep 08, 2020 at 05:32:08PM +0200, Wolfgang Wallner wrote:
> -----"Andy Shevchenko" schrieb: -
> > On Tue, Sep 8, 2020 at 5:58 PM Wolfgang Wallner
> > wrote:
> > > -"Andy Shevchenko" schrieb: -
...
> > > Related to "
On Tue, Sep 8, 2020 at 5:58 PM Wolfgang Wallner
wrote:
> -----"Andy Shevchenko" schrieb: -
> > Betreff: [PATCH v1] cmd: acpi: Print revisions in hex format
> >
> > The revisions are usually dates in hex-decimal format representing
> > mmdd.
f4 (v06 U-BOOT U-BOOTBL 20200908 INTL 0)
DSDT 000e4780 000ba0 (v02 U-BOOT U-BOOTBL 1 INTL 20200326)
...
Fixes: 0b885bcfd9b0 ("acpi: Add an acpi command")
Cc: Wolfgang Wallner
Signed-off-by: Andy Shevchenko
---
cmd/acpi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
> ae7e1238e68f2a472a125673ab506d49158c1889 (x86/boot: Add ACPI RSDP
> address to setup_header) DO NOT USE!!! ASSUME SAME AS 2.13.
Where did you get this "DO NOT USE!!! ASSUME SAME AS 2.13" from?
> However in U-Boot there was a commit from Andy saying that:
>
> commit
This patch moves the the config SYS_MALLOC_LEN to Kconfig
as it is already done for zynq arch in commit 01aa5b8f0503
("Kconfig: Move config SYS_MALLOC_LEN to Kconfig for zynq").
Signed-off-by: Andy Shevchenko
---
board/intel/edison/Kconfig | 3 +++
include/configs/edison.h | 4 ---
would recommend rather to buy another base board
for it, like SparkFun or DFRobot (I recently bought the latter one, i.e. IO
Expander for Intel Edison, and it works nicely, but I didn't check xFSTK
extensively, only DFU).
--
With Best Regards,
Andy Shevchenko
On Sun, Sep 06, 2020 at 07:43:39PM -0600, Simon Glass wrote:
> On Fri, 4 Sep 2020 at 03:33, Andy Shevchenko
> wrote:
> > On Thu, Sep 03, 2020 at 07:28:53PM -0600, Simon Glass wrote:
> > > -self._pathname = tools.GetInputFi
On Sat, Sep 5, 2020 at 6:23 AM Simon Glass wrote:
> On Fri, 4 Sep 2020 at 03:46, Andy Shevchenko
> wrote:
> > On Thu, Sep 03, 2020 at 07:28:51PM -0600, Simon Glass wrote:
> I do have a question though. How does the board decide whether to wait
> for the xFSTK tool to connect
el/edison/edison-mbr.dat
> create mode 100644 tools/binman/etype/u_boot_env.py
> create mode 100644 tools/binman/test/173_missing_blob.dts
> create mode 100644 tools/binman/test/174_env.dts
> create mode 100644 tools/binman/test/175_env_no_size.dts
> create mode 100644 tools/binman/test/176_env_too_small.dts
>
> --
> 2.28.0.526.ge36021eeef-goog
>
--
With Best Regards,
Andy Shevchenko
ash, no dirty suffix).
After addressing,
Reviewed-by: Andy Shevchenko
> Signed-off-by: Simon Glass
> ---
>
> doc/board/intel/edison.rst | 120 +
> 1 file changed, 120 insertions(+)
>
> diff --git a/doc/board/intel/edison.rst b/doc/board/
ter-boot record -> OSIP header
It's a part of DnX (Download'n'Execute) protocol. Let's say it's coincidence it
looks like MBR.
With above and below changes made,
Reviewed-by: Andy Shevchenko
> Signed-off-by: Simon Glass
> ---
>
> arch/x86/cpu/tangier/Kconfig |
e containing the
> environment entries, one per line, in the format:
>
>var=value
Acked-by: Andy Shevchenko
> Signed-off-by: Simon Glass
> ---
>
> tools/binman/etype/u_boot_env.py| 42 +
> tools/binman/ftest.py | 31 +++
never report a missing file.
>
> Fix this and add a test.
Acked-by: Andy Shevchenko
One note below.
>
> Signed-off-by: Simon Glass
> ---
>
> tools/binman/etype/blob.py | 7 ---
> tools/binman/ftest.py | 7 +++
> tool
On Thu, Sep 03, 2020 at 07:28:52PM -0600, Simon Glass wrote:
> We already use binman's 'multiple-images' feature with Chrome OS and we
> want to use it for Edison. There is no real down-side.
>
> Adjust x86 to always use multiple-images.
Acked-by: Andy Shevchenko
> Signed-off-
On Thu, Sep 03, 2020 at 06:05:44PM +0300, Andy Shevchenko wrote:
> On Thu, Sep 03, 2020 at 08:21:23AM -0600, Simon Glass wrote:
> > On Thu, 3 Sep 2020 at 07:51, Andy Shevchenko
> > wrote:
> > > On Thu, Sep 3, 2020 at 4:40 PM Andy Shevchenko
> > > wrote:
>
On Thu, Sep 03, 2020 at 08:21:23AM -0600, Simon Glass wrote:
> On Thu, 3 Sep 2020 at 07:51, Andy Shevchenko
> wrote:
> > On Thu, Sep 3, 2020 at 4:40 PM Andy Shevchenko
> > wrote:
> > > On Thu, Sep 03, 2020 at 07:15:59AM -0600, Simon Glass wrote:
...
> > > H
201 - 300 of 946 matches
Mail list logo
