[U-Boot] [PATCH] dm: bcm6345_gpio: Set proper output level in bcm6345_gpio_direction_output

Current code does not set output level in bcm6345_gpio_direction_output, fix it. Signed-off-by: Axel Lin <axel@ingics.com> --- drivers/gpio/bcm6345_gpio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpio/bcm6345_gpio.c b/drivers/gpio/bcm6345_gpio.c index 009e2fc..b

[U-Boot] [PATCH RFT] gpio: vybrid: Fix up setting output value in vybrid_gpio_direction_output

Pass correct gpio argument to gpio_set_value(). The calcualation of gpio = gpio + (gpios-chip * VYBRID_GPIO_COUNT); is required for calling imx_iomux_gpio_* functions so move them close to improve readability. Signed-off-by: Axel Lin axel@ingics.com --- Hi Bhuvanchandra, I think current code

Re: [U-Boot] [PATCH RFT] gpio: vybrid: Fix up setting output value in vybrid_gpio_direction_output

2015-06-09 21:53 GMT+08:00 Bhuvanchandra DV bhuvanchandra...@toradex.com: On 06/09/2015 06:49 PM, Axel Lin wrote: 2015-06-09 20:58 GMT+08:00 Bhuvanchandra DV bhuvanchandra...@toradex.com: Hello Axel, On 06/09/2015 02:45 PM, Axel Lin wrote: Pass correct gpio argument to gpio_set_value

[U-Boot] [PATCH] gpio: vybrid: Use proper parameter name for gpio offset

It's confusing to use gpio as gpio offset parameter so rename it to offset for better readability. Signed-off-by: Axel Lin axel@ingics.com --- drivers/gpio/vybrid_gpio.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/gpio/vybrid_gpio.c

Re: [U-Boot] [PATCH] gpio: vybrid: Use proper parameter name for gpio offset

2015-06-09 22:37 GMT+08:00 Bhuvanchandra DV bhuvanchandra...@toradex.com: On 06/09/2015 07:54 PM, Axel Lin wrote: It's confusing to use gpio as gpio offset parameter so rename it to offset for better readability. Agreed, but IMHO these offsets any way at the end are the gpio numbers

Re: [U-Boot] [PATCH RFT] gpio: vybrid: Fix up setting output value in vybrid_gpio_direction_output

2015-06-09 20:58 GMT+08:00 Bhuvanchandra DV bhuvanchandra...@toradex.com: Hello Axel, On 06/09/2015 02:45 PM, Axel Lin wrote: Pass correct gpio argument to gpio_set_value(). The calcualation of gpio = gpio + (gpios-chip * VYBRID_GPIO_COUNT); is required for calling imx_iomux_gpio_

[U-Boot] [PATCH 2/2] pwm: imx: Remove unreachable code

The break after return is unreachable code, remove it. Signed-off-by: Axel Lin axel@ingics.com --- drivers/pwm/pwm-imx-util.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/pwm/pwm-imx-util.c b/drivers/pwm/pwm-imx-util.c index 79d86028..f92c370 100644 --- a/drivers/pwm/pwm

[U-Boot] [PATCH 1/2] pwm: imx: Prevent NULL pointer dereference

pwm_id_to_reg() can return NULL, so add NULL testing to prevent NULL pointer dereference. Signed-off-by: Axel Lin axel@ingics.com --- drivers/pwm/pwm-imx.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c index 40bf027..47799fc

[U-Boot] [PATCH] dm: i2c-gpio: Remove redundant dm_gpio_set_value() call

dm_gpio_set_dir_flags() will also set gpio output value when switching to gpio output. So it's not necessary to call dm_gpio_set_value() after dm_gpio_set_dir_flags() call. Signed-off-by: Axel Lin axel@ingics.com --- drivers/i2c/i2c-gpio.c | 13 +++-- 1 file changed, 7 insertions

[U-Boot] [PATCH v2] gpio: stm32_gpio: Use clrsetbits_le32() at appropriate places

Use clrsetbits_le32() to replace clrbits_le32() + setbits_le32(). Signed-off-by: Axel Lin axel@ingics.com --- v2: Conver one more place (updating gpio_regs-afr[dsc-pin 3] register) to use clrsetbits_le32(). drivers/gpio/stm32_gpio.c | 18 +- 1 file changed, 5 insertions

[U-Boot] Question about the hard-coded baud_divisor in debug_uart_init

Hi Simon, Any reason that now using hard-coded baud_divisor = 13; in debug_uart_init()? (The change is introduced by commit dd0b0122bac serial: ns16550: Add an option to specify the debug UART register shift) Regards, Axel ___ U-Boot mailing list

[U-Boot] [PATCH] serial: ns16550: Remove hard-coded baud_divisor setting

This was accidentally added by commit dd0b0122bacc serial: ns16550: Add an option to specify the debug UART register shift. Remove it. Signed-off-by: Axel Lin axel@ingics.com --- drivers/serial/ns16550.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/serial/ns16550.c b/drivers

[U-Boot] [PATCH] gpio: stm32_gpio: Use clrsetbits_le32() at appropriate places

Use clrsetbits_le32() to replace clrbits_le32() + setbits_le32(). Signed-off-by: Axel Lin axel@ingics.com --- drivers/gpio/stm32_gpio.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/gpio/stm32_gpio.c b/drivers/gpio/stm32_gpio.c index d3497e9

Re: [U-Boot] [U-Boot PATCH 3/8] spi: Zap ftssp010_spi driver

2015-04-22 2:26 GMT+08:00 Jagannadha Sutradharudu Teki jagannadh.t...@gmail.com: Zap ftssp010_spi driver since the boards used this driver is no longer been active. I'm not sure if this is correct thing to do... It's fine to drop unmaintained boards, but a driver can/may be used by different

[U-Boot] [PATCH v2] gpio: lpc32xx: Use priv_data instead of platdata

The LPC32XX GPIO driver platdata currently contains GPIO state information, which should go into priv_data. Thus rename lpc32xx_gpio_platdata to lpc32xx_gpio_priv and convert to use dev_get_priv() instead. Signed-off-by: Axel Lin axel@ingics.com --- v2: Update commit log to mention that using

Re: [U-Boot] [PATCH RFT] gpio: lpc32xx: Use priv data instead of platdata

2015-04-13 16:41 GMT+08:00 Albert ARIBAUD albert.arib...@3adev.fr: Hi Axel, Le Sat, 11 Apr 2015 10:20:08 +0800, Axel Lin axel@ingics.com a écrit : Initially I found this driver has set priv_auto_alloc_size but it actually never use dev-priv. The U_BOOT_DEVICE(lpc32xx_gpios) does

[U-Boot] [PATCH RFT] gpio: lpc32xx: Use priv data instead of platdata

data. Thus this patch renames lpc32xx_gpio_platdata to lpc32xx_gpio_priv and converts all dev_get_platdata() to dev_get_priv(). Signed-off-by: Axel Lin axel@ingics.com --- Hi Albert, I don't have this h/w for testing, so only compile test. I'd appreciate if you can review and test this patch

[U-Boot] [PATCH RESEND] tegra: Remove tegra_spl_gpio_direction_output declaration from header file

This function is deleted by commit 2fccd2d96bad tegra: Convert tegra GPIO driver to use driver model. Signed-off-by: Axel Lin axel@ingics.com --- I forgot adding Tom Warren in CC in my previous mail. So here is a resend. arch/arm/include/asm/arch-tegra/gpio.h | 9 - 1 file changed

[U-Boot] [PATCH] tegra: Remove tegra_spl_gpio_direction_output declaration from header file

This function is deleted by commit 2fccd2d96bad tegra: Convert tegra GPIO driver to use driver model. Signed-off-by: Axel Lin axel@ingics.com --- arch/arm/include/asm/arch-tegra/gpio.h | 9 - 1 file changed, 9 deletions(-) diff --git a/arch/arm/include/asm/arch-tegra/gpio.h b/arch

[U-Boot] [PATCH] serial: ns16550: Fix build error due to a typo

Fix trivial typo. Signed-off-by: Axel Lin axel@ingics.com --- drivers/serial/ns16550.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c index eb00f1c..03beab5 100644 --- a/drivers/serial/ns16550.c +++ b/drivers/serial

[U-Boot] [PATCH] spi: designware_spi: revisit FIFO size detection again

byte; b) FIFO size is incorrectly decreased by 1 which already done by meaning of TX Level register. Fixes: 501943696ea4 (spi: designware_spi: Fix detecting FIFO depth) Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Signed-off-by: Axel Lin axel@ingics.com --- This fix

[U-Boot] [PATCH 1/2] spi: cf_spi: Use to_cf_spi_slave to resolve cfslave from slave

Don't assume slave is always the first member of struct cf_spi_slave. Use container_of instead of casting first structure member. Signed-off-by: Axel Lin axel@ingics.com --- drivers/spi/cf_spi.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/spi

[U-Boot] [PATCH 2/2] spi: cf_spi: Staticize local functions

Make local functions static and remove unneeded forward declarations. Signed-off-by: Axel Lin axel@ingics.com --- drivers/spi/cf_spi.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/drivers/spi/cf_spi.c b/drivers/spi/cf_spi.c index 7453538..6ce1101

[U-Boot] spi: ftssp010_spi: Use to_ftssp010_spi() to ensure free correct address

Don't assume slave is always the first member of struct ftssp010_spi. Use to_ftssp010_spi() to ensure free correct address in spi_free_slave(). Signed-off-by: Axel Lin axel@ingics.com --- drivers/spi/ftssp010_spi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[U-Boot] [PATCH] image: Convert to use fdt_for_each_subnode macro

Signed-off-by: Axel Lin axel@ingics.com --- common/image-fit.c | 4 +--- common/image-sig.c | 16 2 files changed, 5 insertions(+), 15 deletions(-) diff --git a/common/image-fit.c b/common/image-fit.c index b47d110..778d2a1 100644 --- a/common/image-fit.c +++ b/common/image

[U-Boot] [PATCH v2] image: Convert to use fdt_for_each_subnode macro

Use fdt_for_each_subnode macro to simplify the code a bit. Signed-off-by: Axel Lin axel@ingics.com --- v2: Update commit log common/image-fit.c | 4 +--- common/image-sig.c | 16 2 files changed, 5 insertions(+), 15 deletions(-) diff --git a/common/image-fit.c b/common

[U-Boot] [PATCH] gpio: omap: Pass correct argument to _get_gpio_direction()

Pass bank rather than bank-base to _get_gpio_direction(). Signed-off-by: Axel Lin axel@ingics.com --- drivers/gpio/omap_gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/omap_gpio.c b/drivers/gpio/omap_gpio.c index f3a7ccb..19fc451 100644 --- a/drivers

[U-Boot] [PATCH RFT v2] gpio: at91: Fix getting address of private data

Use dev_get_priv() rather than dev_get_platdata() to get correct address of private data. Signed-off-by: Axel Lin axel@ingics.com --- v2: Fix an obvious typo in subject line (s/addres/address). drivers/gpio/at91_gpio.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff

[U-Boot] [PATCH RFT] gpio: at91: Fix getting addres of private data

Use dev_get_priv() rather than dev_get_platdata() to get correct address of private data. Signed-off-by: Axel Lin axel@ingics.com --- Hi Simon, I don't have this h/w, so please test if you think this patch is ok. Thanks, Axel drivers/gpio/at91_gpio.c | 10 +- 1 file changed, 5

[U-Boot] [PATCH] spi: cf_qspi: Fixup to_cf_qspi_slave macro

The third parameter of container_of is the name of the member within the struct. Current code only works if the parameter passed to to_cf_qspi_slave named slave. Fix it. Signed-off-by: Axel Lin axel@ingics.com --- drivers/spi/cf_qspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[U-Boot] [PATCH] spi: davinci: Remove duplicate code to set bus and cs for slave

It's done in spi_alloc_slave(). Signed-off-by: Axel Lin axel@ingics.com --- drivers/spi/davinci_spi.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/spi/davinci_spi.c b/drivers/spi/davinci_spi.c index 0ec5b9d..bf18362 100644 --- a/drivers/spi/davinci_spi.c +++ b/drivers/spi

[U-Boot] [PATCH] spi: ftssp010_spi: Simplify code flow in ftssp010_[wait|wait_tx|wait_rx]

No functional change, just simplify the code a bit. Signed-off-by: Axel Lin axel@ingics.com --- drivers/spi/ftssp010_spi.c | 36 1 file changed, 12 insertions(+), 24 deletions(-) diff --git a/drivers/spi/ftssp010_spi.c b/drivers/spi/ftssp010_spi.c index

[U-Boot] [PATCH] spi: cadence_qspi: Fix checking return value of fdt_first_subnode()

fdt_first_subnode() returns -FDT_ERR_NOTFOUND if no subnode found. 0 is supposed to be a valid offset returns from fdt_first_subnode(). Signed-off-by: Axel Lin axel@ingics.com --- drivers/spi/cadence_qspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi

[U-Boot] [PATCH] spi: designware_spi: Fix detecting FIFO depth

fails. This patch fixes above issues. Signed-off-by: Axel Lin axel@ingics.com --- The same fix is already applied to linux-spi tree: http://git.kernel.org/cgit/linux/kernel/git/broonie/spi.git/commit/?h=for-linusid=d297933cc7fcfbaaf2d37570baac73287bf0357d This patch replaces my previous patch

Re: [U-Boot] [PATCH] mmc: sunxi: Fix misuse of gpio_direction_input()

2014-12-22 20:59 GMT+08:00 Ian Campbell i...@hellion.org.uk: On Sun, 2014-12-21 at 11:53 -0700, Simon Glass wrote: On 19 December 2014 at 20:41, Axel Lin axel@ingics.com wrote: It does not make sense to make gpio_direction_input() return the gpio input status. The return value

[U-Boot] [PATCH] mmc: sunxi: Fix misuse of gpio_direction_input()

() is enough. Signed-off-by: Axel Lin axel@ingics.com --- Only compile tested, so please test this patch. Thanks. drivers/gpio/sunxi_gpio.c | 2 +- drivers/mmc/sunxi_mmc.c | 7 +-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpio/sunxi_gpio.c b/drivers/gpio/sunxi_gpio.c

[U-Boot] [PATCH] spi: designware_spi: Fix off-by-one for checking fifo depth

The depth could be from 2 to 256 from HW spec, so fix off-by-one for checking fifo depth. Signed-off-by: Axel Lin axel@ingics.com --- Hi, I don't have this hardware handy, so please test it. drivers/spi/designware_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [U-Boot] [PATCH] spi: designware_spi: Fix off-by-one for checking fifo depth

2014-12-19 15:35 GMT+08:00 Stefan Roese s...@denx.de: Hi Axel, On 19.12.2014 05:40, Axel Lin wrote: The depth could be from 2 to 256 from HW spec, so fix off-by-one for checking fifo depth. Signed-off-by: Axel Lin axel@ingics.com --- Hi, I don't have this hardware handy, so please

[U-Boot] [PATCH] gpio: intel_ich6: Set correct gpio output value in ich6_gpio_direction_output()

Current code does not set gpio output value in ich6_gpio_direction_output(), fix it. Signed-off-by: Axel Lin axel@ingics.com --- drivers/gpio/intel_ich6_gpio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpio/intel_ich6_gpio.c b/drivers/gpio/intel_ich6_gpio.c index b095d17

[U-Boot] [PATCH] spi: davinci: Fix register address for SPI1_BUS

Fix a trivial copy-paste bug. Signed-off-by: Axel Lin axel@ingics.com --- drivers/spi/davinci_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/davinci_spi.c b/drivers/spi/davinci_spi.c index 28fb3a2..0ec5b9d 100644 --- a/drivers/spi/davinci_spi.c +++ b

[U-Boot] [RESEND][PATCH] gpio: spear_gpio: Fix gpio_set_value() implementation

bits without affecting any other pins in a single write operation. Thus we don't need a read-modify-write to update the register. Signed-off-by: Axel Lin axel@ingics.com Acked-by: Stefan Roese s...@denx.de Reviewed-by: Vipin Kumar vipin.ku...@st.com Reviewed-by: Michael Trimarchi mich

[U-Boot] [PATCH] spi: atmel_dataflash: Simplify AT91F_SpiEnable implementation

Refactor the code a bit to make it better in readability. Remove the comments because now the intention of the code is pretty clear. Signed-off-by: Axel Lin axel@ingics.com --- drivers/spi/atmel_dataflash_spi.c | 31 --- 1 file changed, 12 insertions(+), 19

[U-Boot] [PATCH] serial: arc: Convert to use default_serial_puts

Use default_serial_puts() instead of duplicating the implementation. Signed-off-by: Axel Lin axel@ingics.com --- drivers/serial/serial_arc.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/serial/serial_arc.c b/drivers/serial/serial_arc.c index e63d25d

[U-Boot] [PATCH RESEND 2/2] serial: opencores_yanu: Avoid duplicate oc_serial_setbrg() implementation

The implementation of oc_serial_setbrg() for CONFIG_SYS_NIOS_FIXEDBAUD and !CONFIG_SYS_NIOS_FIXEDBAUD are very similar. Add a baudrate variable and set it to either CONFIG_BAUDRATE or gd-baudrate. Then we can unify the code for both cases. Signed-off-by: Axel Lin axel@ingics.com --- drivers

[U-Boot] [PATCH RESEND 1/2] serial: opencores_yanu: Fix build error

Fix build error due to missing include of serial.h and a trivial typo. Signed-off-by: Axel Lin axel@ingics.com --- Hi Tom, This patch was sent on http://lists.denx.de/pipermail/u-boot/2014-January/171093.html I don't get any feedback from NIOS2 maintainers so far. Maybe you can pick up

[U-Boot] [PATCH 1/2] serial: opencores_yanu: Fix build error

Fix build error due to missing include of serial.h and a trivial typo. Signed-off-by: Axel Lin axel@ingics.com --- drivers/serial/opencores_yanu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/serial/opencores_yanu.c b/drivers/serial/opencores_yanu.c index

[U-Boot] [PATCH 2/2] serial: opencores_yanu: Avoid duplicate oc_serial_setbrg() implementation

The implementation of oc_serial_setbrg() for CONFIG_SYS_NIOS_FIXEDBAUD and !CONFIG_SYS_NIOS_FIXEDBAUD are very similar. Add a baudrate variable and set it to either CONFIG_BAUDRATE or gd-baudrate. Then we can unify the code for both cases. Signed-off-by: Axel Lin axel@ingics.com --- drivers

[U-Boot] [PATCH] spi: oc_tiny_spi: Refactor to simplify spi_xfer implementation

Currently we have similar code for (txp rxp), (txp !rxp), (!rxp txp), and (!txp !rxp) cases. This patch refactors the code a bit to avoid duplicate similar code. Signed-off-by: Axel Lin axel@ingics.com --- Hi Thomas, This path is similar to the patch I sent for spi-oc-tiny.c linux driver

[U-Boot] [PATCH] spi: sh_spi: Use sh_spi_clear_bit() instead of open-coded

We have a sh_spi_clear_bit() function, there's no reason not to use it. Signed-off-by: Axel Lin axel@ingics.com --- drivers/spi/sh_spi.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/spi/sh_spi.c b/drivers/spi/sh_spi.c index 744afe3..7ca5e36 100644

Re: [U-Boot] How to write jffs2 image to spi nor flash?

2013/11/28 Axel Lin axel@ingics.com: Hi list, I use sf erase + sf write commands to write root image to spi nor flash. It works for writing a ext2 image. However, if I use the same commands to write a jffs2 image I got a lot of Magic bitmask 0x1985 not found at... messages and jffs2

[U-Boot] [PATCH 1/2] spi: bfin_spi: Remove unnecessary test for bus and pins[bus]

For invalid bus number, current code returns NULL in the default case of switch-case statements. In additional, pins[bus] is always not NULL because it is the address of specific row of the two-dimensional array. Thus this patch removes these unnecessary test. Signed-off-by: Axel Lin axel

[U-Boot] [PATCH 2/2] spi: bfin_spi6xx: Remove unnecessary test for bus and pins[bus]

For invalid bus number, current code returns NULL in the default case of switch-case statements. In additional, pins[bus] is always not NULL because it is the address of specific row of the two-dimensional array. Thus this patch removes these unnecessary test. Signed-off-by: Axel Lin axel

[U-Boot] How to write jffs2 image to spi nor flash?

Hi list, I use sf erase + sf write commands to write root image to spi nor flash. It works for writing a ext2 image. However, if I use the same commands to write a jffs2 image I got a lot of Magic bitmask 0x1985 not found at... messages and jffs2: inflate returned -3. jffs2:

Re: [U-Boot] [PATCH] serial: mxs_auart: Staticize local functions

2013/10/15 Marek Vasut ma...@denx.de: Dear Axel Lin, Staticize local functions in mxs_auart driver. Signed-off-by: Axel Lin axel@ingics.com Acked-by: Marek Vasut ma...@denx.de Just curious, how did you find this? Did you lint the files with some tool? I just read the code. Regards

[U-Boot] [PATCH 1/2] serial: xuartlite: Staticize local functions

Staticize local functions in xuartlite driver. Signed-off-by: Axel Lin axel@ingics.com --- drivers/serial/serial_xuartlite.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/serial/serial_xuartlite.c b/drivers/serial/serial_xuartlite.c index 9c1d025

[U-Boot] [PATCH 2/2] serial: s5p: Staticize local functions

Staticize local functions in s5p serial driver. Signed-off-by: Axel Lin axel@ingics.com --- drivers/serial/serial_s5p.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/serial/serial_s5p.c b/drivers/serial/serial_s5p.c index f98b422..13ced26 100644

[U-Boot] [PATCH v2 1/2] serial: xuartlite: Staticize local functions

Staticize local functions in xuartlite driver. Signed-off-by: Axel Lin axel@ingics.com --- v2: Also staticize userial##port##_* functions drivers/serial/serial_xuartlite.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/serial

[U-Boot] [PATCH v2 2/2] serial: s5p: Staticize local functions

Staticize local functions in s5p serial driver. Signed-off-by: Axel Lin axel@ingics.com --- v2: Also staticize s5p_serial##port##_* functions drivers/serial/serial_s5p.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/serial

[U-Boot] [PATCH] serial: mxs_auart: Staticize local functions

Staticize local functions in mxs_auart driver. Signed-off-by: Axel Lin axel@ingics.com --- drivers/serial/mxs_auart.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/serial/mxs_auart.c b/drivers/serial/mxs_auart.c index 7cfe5bc..fc0fa96 100644

[U-Boot] [PATCH v2] gpio: spear_gpio: Fix gpio_set_value() implementation

bits without affecting any other pins in a single write operation. Thus we don't need a read-modify-write to update the register. Signed-off-by: Axel Lin axel@ingics.com Acked-by: Stefan Roese s...@denx.de Reviewed-by: Vipin Kumar vipin.ku...@st.com Reviewed-by: Michael Trimarchi mich

Re: [U-Boot] [PATCH RESEND] gpio: spear_gpio: Fix gpio_set_value() implementation

2013/9/14 Albert ARIBAUD albert.u.b...@aribaud.net: Hi Axel, On Fri, 06 Sep 2013 14:22:40 +0800, Axel Lin axel@ingics.com wrote: In current gpio_set_value() implementation, it always sets the gpio control bit no matter the value argument is 0 or 1. Thus the GPIOs never set to low

[U-Boot] [PATCH] boards.cfg: Fix the comment for invoking tools/reformat.py from vim

Add the missing bang (!) to execute external command, otherwise it does not work. Signed-off-by: Axel Lin axel@ingics.com --- boards.cfg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/boards.cfg b/boards.cfg index dbd8479..9fc77fb 100644 --- a/boards.cfg +++ b/boards.cfg

Re: [U-Boot] u-boot build error in current git tree

2013/9/11 Fabio Estevam feste...@gmail.com: On Tue, Sep 10, 2013 at 12:30 AM, Axel Lin axel@ingics.com wrote: Hit below build errors (on ARM platforms): axel@phoenix:~/repos/git/u-boot$ make mx31pdk Configuring for mx31pdk board... make Are you able to reproduce the error if you run

[U-Boot] u-boot build error in current git tree

Hit below build errors (on ARM platforms): axel@phoenix:~/repos/git/u-boot$ make mx31pdk Configuring for mx31pdk board... make make[1]: Entering directory `/home/axel/repos/git/u-boot' Generating include/autoconf.mk Generating include/autoconf.mk.dep make[1]: Leaving directory

[U-Boot] actux2 build error due to commit 4412db46

Hi Jack, I hit below build error, revert commit 4412db464 standalone-examples: support custom GCC lib fixes the build error. $ ./MAKEALL actux2 Configuring for actux2 board... make[1]: *** [hello_world] Error 1 make: *** [examples/standalone] Error 2 textdata bss dec hex

[U-Boot] [PATCH RESEND] gpio: spear_gpio: Fix gpio_set_value() implementation

In current gpio_set_value() implementation, it always sets the gpio control bit no matter the value argument is 0 or 1. Thus the GPIOs never set to low. This patch fixes this bug. Signed-off-by: Axel Lin axel@ingics.com Acked-by: Stefan Roese s...@denx.de Reviewed-by: Vipin Kumar vipin.ku

[U-Boot] [PATCH] serial: arm_dcc: Convert to use default_serial_puts

Use default_serial_puts() instead of its own implementation. Signed-off-by: Axel Lin axel@ingics.com --- drivers/serial/arm_dcc.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/serial/arm_dcc.c b/drivers/serial/arm_dcc.c index 29d9295..5dfb02f 100644

Re: [U-Boot] [PATCH] gpio: spear_gpio: Fix gpio_set_value() implementation

2013/7/1 Vipin Kumar vipin.ku...@st.com: On 7/1/2013 11:02 AM, Axel Lin wrote: The questions raised here are valid and it forced me to re-read the datasheet. For your convenience, I must tell you that the device is actually pl061 from ARM, so the driver can also be named so. The datasheet

Re: [U-Boot] [PATCH] gpio: altera_pio: Fix inversed logic of gpio_is_valid() implementation

2013/7/29 Albert ARIBAUD albert.u.b...@aribaud.net: Hi Axel, On Sat, 15 Jun 2013 17:10:38 +0800, Axel Lin axel@ingics.com wrote: The implementation of gpio_is_valid() has inversed logic, fix it. Signed-off-by: Axel Lin axel@ingics.com --- Hi, I don't have this hardware to test

[U-Boot] Boot Linux kernel with initramfs fails

Hi, When I boot Linux kernel with FIT Image, the kernel does not unpacking initramfs. ( The root cause is initrd_start is NULL.) The initramfs is built-in with kernel, so I don't specify ramdisk in my kernel.its file. Is this a known issue or do I need special setting to boot a Linux kernel

Re: [U-Boot] [PATCH v2] blackfin: Fix using gd-baudrate before setting its value

2013/7/1 Sonic Zhang sonic@gmail.com: Acked-by: Sonic Zhangsonic.zh...@analog.com hi Sonic, I thought you will pick up this patch, but now I got your ACK and I have no idea who will take this patch. Just wondering if this patch should be applied for v2013.07? Regards, Axel

[U-Boot] [PATCH 1/3] spi: bfin_spi: Use DIV_ROUND_UP instead of open-coded

Use DIV_ROUND_UP to simplify the code. Signed-off-by: Axel Lin axel@ingics.com --- drivers/spi/bfin_spi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/spi/bfin_spi.c b/drivers/spi/bfin_spi.c index a9a4d92..f7192c2 100644 --- a/drivers/spi/bfin_spi.c +++ b

[U-Boot] [PATCH 2/3] spi: fsl_espi: Use DIV_ROUND_UP instead of open-coded

Use DIV_ROUND_UP to simplify the code. Signed-off-by: Axel Lin axel@ingics.com --- drivers/spi/fsl_espi.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/spi/fsl_espi.c b/drivers/spi/fsl_espi.c index 28609ee..e20ab9f 100644 --- a/drivers/spi/fsl_espi.c +++ b

[U-Boot] [PATCH 3/3] spi: mpc8xxx_spi: Use DIV_ROUND_UP instead of open-coded

Use DIV_ROUND_UP to simplify the code. Signed-off-by: Axel Lin axel@ingics.com --- drivers/spi/mpc8xxx_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/mpc8xxx_spi.c b/drivers/spi/mpc8xxx_spi.c index 6b0e3b4..c90c0ce 100644 --- a/drivers/spi/mpc8xxx_spi.c

[U-Boot] [PATCH] nds32: ag101/ag102: Fix setting lastdec and now values

, thus fix the equation to set lastdec and now variables accordingly. Signed-off-by: Axel Lin axel@ingics.com --- Hi Kuan-Yu, This change is based on your suggestion. I don't have this hardware, can you test if this patch works? Thanks, Axel arch/nds32/cpu/n1213/ag101/timer.c | 7 --- arch

[U-Boot] nds32: ag101/ag102: Inconsistent timer3 counter unit?

Hi Macpaul, For the case CONFIG_FTTMR010_EXT_CLK is not defined: In reset_timer_masked(): lastdec = readl(tmr-timer3_counter) / (CONFIG_SYS_CLK_FREQ / 2); In get_timer_masked(): ulong now = readl(tmr-timer3_counter) / (CONFIG_SYS_CLK_FREQ / 2 / 1024); The code looks strange. (Why one needs to

[U-Boot] [PATCH v3] net: Use ARRAY_SIZE at appropriate places

Use ARRAY_SIZE instead of having similar implementation in each drivers. The NUMELEMS defined in drivers/net/npe/include/IxOsalTypes.h is not used at all, so this patch removes it instead of converting it to use ARRAY_SIZE. Signed-off-by: Axel Lin axel@ingics.com Cc: Albert Aribaud albert.u.b

Re: [U-Boot] [PATCH v2] net: Use ARRAY_SIZE at appropriate places

diff --git a/drivers/net/npe/IxEthDBFeatures.c b/drivers/net/npe/IxEthDBFeatures.c index c5b680a..d43efaa 100644 --- a/drivers/net/npe/IxEthDBFeatures.c +++ b/drivers/net/npe/IxEthDBFeatures.c @@ -143,22 +143,22 @@ void ixEthDBFeatureCapabilityScan(void) IX_ENSURE(sizeof

[U-Boot] [PATCH] gpio: spear_gpio: Remove unused gpio_toggle_value() function

There is no user calling this function, thus remove it. Signed-off-by: Axel Lin axel@ingics.com --- drivers/gpio/spear_gpio.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpio/spear_gpio.c b/drivers/gpio/spear_gpio.c index d3c728e..5b5521e 100644 --- a/drivers/gpio

Re: [U-Boot] [PATCH] gpio: spear_gpio: Fix gpio_set_value() implementation

2013/6/30 Michael Trimarchi mich...@amarulasolutions.com: Hi Il giorno 30/giu/2013 06:18, Axel Lin axel@ingics.com ha scritto: 2013/6/21 Michael Trimarchi mich...@amarulasolutions.com: On 06/21/2013 06:40 AM, Vipin Kumar wrote: On 6/20/2013 7:26 PM, Axel Lin wrote: 2013/6/20 Marek

Re: [U-Boot] [PATCH] blackfin: Fix using gd-baudrate before setting its value

2013/7/1 Sonic Zhang sonic@gmail.com: Hi Axel, On Sat, Jun 29, 2013 at 8:34 AM, Axel Lin axel@ingics.com wrote: Current code uses gd-baudrate before setting its value. Besides, I got below build warning which is introduced by commit ddb5c5be blackfin: add baudrate to bdinfo

[U-Boot] [PATCH v2] blackfin: Fix using gd-baudrate before setting its value

] include/vsprintf.h:27:7: note: expected 'const char *' but argument is of type 'unsigned int' This patch ensures we get the baudrate setting before using it. Signed-off-by: Axel Lin axel@ingics.com --- v2: The change is based on Sonic 's suggestion: move gd-bd-bi_baudrate = gd-baudrate

Re: [U-Boot] [PATCH] gpio: spear_gpio: Fix gpio_set_value() implementation

The questions raised here are valid and it forced me to re-read the datasheet. For your convenience, I must tell you that the device is actually pl061 from ARM, so the driver can also be named so. The datasheet is here

Re: [U-Boot] [PATCH] blackfin: Fix using gd-baudrate before setting its value

2013/6/29 Marek Vasut ma...@denx.de: Dear Axel Lin, Current code uses gd-baudrate before setting its value. Besides, I got below build warning which is introduced by commit ddb5c5be blackfin: add baudrate to bdinfo. board.c:235:3: warning: passing argument 1 of 'simple_strtoul' makes

[U-Boot] [PATCH] net: Use ARRAY_SIZE at appropriate places

Use ARRAY_SIZE instead of having similar implementation in each drivers. Signed-off-by: Axel Lin axel@ingics.com Cc: Albert Aribaud albert.u.b...@aribaud.net Cc: Ben Warren biggerbadder...@gmail.com Cc: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com Cc: Joe Hershberger joe.hershber

Re: [U-Boot] [PATCH] net: Use ARRAY_SIZE at appropriate places

2013/6/30 Marek Vasut ma...@denx.de: Dear Axel Lin, Use ARRAY_SIZE instead of having similar implementation in each drivers. Signed-off-by: Axel Lin axel@ingics.com Cc: Albert Aribaud albert.u.b...@aribaud.net Cc: Ben Warren biggerbadder...@gmail.com Cc: Jean-Christophe PLAGNIOL

[U-Boot] [PATCH v2] net: Use ARRAY_SIZE at appropriate places

Use ARRAY_SIZE instead of having similar implementation in each drivers. Signed-off-by: Axel Lin axel@ingics.com Cc: Albert Aribaud albert.u.b...@aribaud.net Cc: Ben Warren biggerbadder...@gmail.com Cc: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com Cc: Joe Hershberger joe.hershber

Re: [U-Boot] [PATCH] net: Use ARRAY_SIZE at appropriate places

diff --git a/drivers/net/npe/include/IxOsalTypes.h b/drivers/net/npe/include/IxOsalTypes.h index 06e71de..615c655 100644 --- a/drivers/net/npe/include/IxOsalTypes.h +++ b/drivers/net/npe/include/IxOsalTypes.h @@ -93,7 +93,7 @@ typedef volatile INT32 VINT32; #ifndef NUMELEMS -#define

Re: [U-Boot] [PATCH] gpio: spear_gpio: Fix gpio_set_value() implementation

2013/6/21 Michael Trimarchi mich...@amarulasolutions.com: On 06/21/2013 06:40 AM, Vipin Kumar wrote: On 6/20/2013 7:26 PM, Axel Lin wrote: 2013/6/20 Marek Vasutma...@denx.de Dear Axel Lin, In current gpio_set_value() implementation, it always sets the gpio control bit no matter the value

[U-Boot] [PATCH] blackfin: gpio: Use proper mask for comparing function

-by: Axel Lin axel@ingics.com --- arch/blackfin/cpu/gpio.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/arch/blackfin/cpu/gpio.c b/arch/blackfin/cpu/gpio.c index f74a0b7..c4cddaf 100644 --- a/arch/blackfin/cpu/gpio.c +++ b/arch/blackfin/cpu/gpio.c @@ -247,7

[U-Boot] [PATCH] blackfin: Fix using gd-baudrate before setting its value

] include/vsprintf.h:27:7: note: expected 'const char *' but argument is of type 'unsigned int' This patch moves the code using gd-baudrate to be after init_baudrate() call, this ensures we get the baudrate setting before using it. Signed-off-by: Axel Lin axel@ingics.com --- I forgot to CC u-boot

[U-Boot] [PATCH 1/2] blackfin: gpio: Unreserve gpio in special_gpio_free()

In special_gpio_free(), call unreserve() rather than reserve() to release gpio. Signed-off-by: Axel Lin axel@ingics.com --- arch/blackfin/cpu/gpio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/blackfin/cpu/gpio.c b/arch/blackfin/cpu/gpio.c index f74a0b7

[U-Boot] [PATCH 2/2] gpio: adi_gpio2: Unreserve gpio in special_gpio_free()

In special_gpio_free(), call unreserve() rather than reserve() to release gpio. Signed-off-by: Axel Lin axel@ingics.com --- drivers/gpio/adi_gpio2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/adi_gpio2.c b/drivers/gpio/adi_gpio2.c index 7a034eb

Re: [U-Boot] [PATCH] cmd_i2c: Use ARRAY_SIZE instead of reinventing it

2013/6/25 Simon Glass s...@chromium.org: On Sat, Jun 22, 2013 at 6:56 AM, Axel Lin axel@ingics.com wrote: Signed-off-by: Axel Lin axel@ingics.com Missing commit message? Because the subject line is already very clear. And tools/checkpatch.pl does not complaint. Otherwise: Acked

[U-Boot] [PATCH] gpio: pca953x: Use ARRAY_SIZE instead of reinventing it

Signed-off-by: Axel Lin axel@ingics.com --- drivers/gpio/pca953x.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpio/pca953x.c b/drivers/gpio/pca953x.c index be13745..7371cd4 100644 --- a/drivers/gpio/pca953x.c +++ b/drivers/gpio/pca953x.c @@ -47,9 +47,6

[U-Boot] [PATCH] cmd_i2c: Use ARRAY_SIZE instead of reinventing it

Signed-off-by: Axel Lin axel@ingics.com --- common/cmd_i2c.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/common/cmd_i2c.c b/common/cmd_i2c.c index 4380794..3215644 100644 --- a/common/cmd_i2c.c +++ b/common/cmd_i2c.c @@ -120,8 +120,6 @@ static uchar i2c_no_probes

[U-Boot] [PATCH] serial: Use ARRAY_SIZE instead of reinventing it

Signed-off-by: Axel Lin axel@ingics.com --- drivers/serial/serial.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/serial/serial.c b/drivers/serial/serial.c index daa8003..a19cec5 100644 --- a/drivers/serial/serial.c +++ b/drivers/serial/serial.c @@ -37,7

[U-Boot] [PATCH 1/3] hwmon: lm63: Use ARRAY_SIZE at appropriate place

Signed-off-by: Axel Lin axel@ingics.com --- drivers/hwmon/lm63.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/hwmon/lm63.c b/drivers/hwmon/lm63.c index f3adf64..bb8e644 100644 --- a/drivers/hwmon/lm63.c +++ b/drivers/hwmon/lm63.c @@ -133,8 +133,7 @@ int

[U-Boot] [PATCH 2/3] mtd: cfi_flash: Use ARRAY_SIZE at appropriate places

Signed-off-by: Axel Lin axel@ingics.com --- drivers/mtd/cfi_flash.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/cfi_flash.c b/drivers/mtd/cfi_flash.c index 25f8752..a13b0b8 100644 --- a/drivers/mtd/cfi_flash.c +++ b/drivers/mtd/cfi_flash.c @@ -1797,7

[U-Boot] [PATCH 3/3] usb: musb: Use ARRAY_SIZE at appropriate places

Signed-off-by: Axel Lin axel@ingics.com --- drivers/usb/musb/musb_hcd.c | 3 +-- drivers/usb/musb/musb_udc.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/usb/musb/musb_hcd.c b/drivers/usb/musb/musb_hcd.c index 60e03a4..7bb91e5 100644 --- a/drivers/usb/musb

  1   2   >