Re: [PATCH V2 0/4] Anbernic RGxx3 Bootloader Fixes

2024-09-23 Thread Chris Morgan
On Sun, Sep 22, 2024 at 02:43:11PM +0100, Peter Robinson wrote: > Hi Chris, > > > Update the Anbernic RGxx3 "device" to use upstream device-trees, > > add logic to detect a different vdd_cpu regulator, and implement a > > fix to allow the panel auto-detection t

Re: [PATCH V2 4/4] board: rockchip: Enable PD_VO before driver access

2024-09-23 Thread Chris Morgan
On Mon, Sep 23, 2024 at 01:24:34PM +0200, Quentin Schulz wrote: > Hi Chris, > > On 9/19/24 4:00 PM, Chris Morgan wrote: > > From: Chris Morgan > > > > Enable the PD_VO power domain before driver access on the rk3568 SoC. > > > > Signed-off-by: Chris Morga

Re: [PATCH V2 2/4] board: rockchip: Add vdd_cpu reg fixup for RGXX3 Series

2024-09-23 Thread Chris Morgan
On Mon, Sep 23, 2024 at 01:21:01PM +0200, Quentin Schulz wrote: > Hi Chris, > > On 9/19/24 4:00 PM, Chris Morgan wrote: > > From: Chris Morgan > > > > Some of the Powkiddy devices switched to using a different vendor for > > the vdd_cpu regulator. Unfortunate

Re: [PATCH 3/3] board: rockchip: Fix panel detection for mainline A-TF

2024-09-19 Thread Chris Morgan
On Thu, Sep 19, 2024 at 09:48:58AM +0800, Kever Yang wrote: > Hi Chris, > > On 2024/9/18 21:38, Chris Morgan wrote: > > On Wed, Sep 18, 2024 at 11:06:34AM +0800, Kever Yang wrote: > > > Hi Chris, > > > > > > Please update the subject with something

[PATCH V2 4/4] board: rockchip: Enable PD_VO before driver access

2024-09-19 Thread Chris Morgan
From: Chris Morgan Enable the PD_VO power domain before driver access on the rk3568 SoC. Signed-off-by: Chris Morgan --- arch/arm/mach-rockchip/rk3568/rk3568.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/mach-rockchip/rk3568/rk3568.c b/arch/arm/mach-rockchip/rk3568

[PATCH V2 3/4] board: rockchip: Remove ARM SCMI Support from RGxx3

2024-09-19 Thread Chris Morgan
From: Chris Morgan Remove config options for ARM SCMI. It is not required to boot the board and when using the most recent mainline A-TF it actually causes the device to freeze during boot due to missing SCMI support. Signed-off-by: Chris Morgan --- configs/anbernic-rgxx3-rk3566_defconfig | 2

[PATCH V2 1/4] board: rockchip: Convert Anbernic RGxx3 to OF_UPSTREAM

2024-09-19 Thread Chris Morgan
From: Chris Morgan Refactor the board detection logic (again) to make it compatible with the upstream device-trees, and switch to OF_UPSTREAM. Now the device boots with the device-tree for the 353P, and then loads the correct device tree (of 10) in the later stages of SPL. Signed-off-by: Chris

[PATCH V2 2/4] board: rockchip: Add vdd_cpu reg fixup for RGXX3 Series

2024-09-19 Thread Chris Morgan
From: Chris Morgan Some of the Powkiddy devices switched to using a different vendor for the vdd_cpu regulator. Unfortunately the device does not have a new revision to denote this, so users have no way of knowing in advance. Add code to detect if a device is present at addresses 0x1c or 0x40

[PATCH V2 0/4] Anbernic RGxx3 Bootloader Fixes

2024-09-19 Thread Chris Morgan
From: Chris Morgan Update the Anbernic RGxx3 "device" to use upstream device-trees, add logic to detect a different vdd_cpu regulator, and implement a fix to allow the panel auto-detection to run when using mainline A-TF. Note that *Linux* still cannot use mainline A-TF because of t

Re: [PATCH 3/3] board: rockchip: Fix panel detection for mainline A-TF

2024-09-18 Thread Chris Morgan
On Wed, Sep 18, 2024 at 11:06:34AM +0800, Kever Yang wrote: > Hi Chris, > > Please update the subject with something like "Enable the VO PD before > driver access", > > and the commit message for the change reason is enough. > > and the config is more soc

[PATCH 2/3] board: rockchip: Add vdd_cpu reg fixup for RGXX3 Series

2024-09-16 Thread Chris Morgan
From: Chris Morgan Some of the Powkiddy devices switched to using a different vendor for the vdd_cpu regulator. Unfortunately the device does not have a new revision to denote this, so users have no way of knowing in advance. Add code to detect if a device is present at addresses 0x1c or 0x40

[PATCH 3/3] board: rockchip: Fix panel detection for mainline A-TF

2024-09-16 Thread Chris Morgan
From: Chris Morgan The current panel detection logic crashes when the device boots with mainline A-TF, causing a reboot loop. It turns out mainline A-TF doesn't enable the VO power domain like the BSP A-TF did. Set the VO domain on and use a memory barrier to ensure it is powered up befo

[PATCH 1/3] board: rockchip: Convert Anbernic RGxx3 to OF_UPSTREAM

2024-09-16 Thread Chris Morgan
From: Chris Morgan Refactor the board detection logic (again) to make it compatible with the upstream device-trees, and switch to OF_UPSTREAM. Now the device boots with the device-tree for the 353P, and then loads the correct device tree (of 10) in the later stages of SPL. Signed-off-by: Chris

[PATCH 0/3] Anbernic RGxx3 Bootloader Fixes

2024-09-16 Thread Chris Morgan
From: Chris Morgan Update the Anbernic RGxx3 "device" to use upstream device-trees, add logic to detect a different vdd_cpu regulator, and implement a fix to allow the panel auto-detection to run when using mainline A-TF. Note that *Linux* still cannot use mainline A-TF because of t

[PATCH V3 9/9] sunxi: Add support for Anbernic RG35XX-2024

2024-08-30 Thread Chris Morgan
From: Chris Morgan The Anbernic RG35XX series of devices are based around an Allwinner H700 SoC with 1GB of RAM, 2 SD cards, and multiple input buttons. This bootloader has been tested on the Anbernic RG35XX-2024 and RG35XX-H, but should be suitable for the entire lineup of H700 based devices

[PATCH V3 8/9] arm64: dts: allwinner: h616: Change RG35XX PMIC to r_i2c

2024-08-30 Thread Chris Morgan
From: Chris Morgan Change the Anbernic RG35XX series to use the r_i2c bus for the PMIC instead of the r_rsb bus. This is to keep the device tree consistent as there are at least 3 devices (the RG35XX-SP, RG28XX, and RG40XX-H) that have an external RTC on the r_i2c bus. Link: https

[PATCH V3 7/9] arm64: dts: allwinner: h616: Add r_i2c pinctrl nodes

2024-08-30 Thread Chris Morgan
From: Chris Morgan Add pinctrl nodes for the r_i2c node. Without the pinmux defined the r_i2c bus may fail to work, possibly if the bootloader uses rsb mode for the PMIC. Link: https://lore.kernel.org/linux-sunxi/172252952262.1669767.7675865282122079154.b4...@csie.org/ [ upstream commit

[PATCH V3 6/9] sunxi: Correct TPR6 parameter for H616 DRAM driver

2024-08-30 Thread Chris Morgan
From: Chris Morgan Correct the default TPR6 parameter based on suggestion from Mikhail Kalashnikov. [1] [1] https://lore.kernel.org/u-boot/4c003cab-c8b8-484d-924d-084e71fe6...@gmail.com/ Fixes: 4b02f0120a4b ("sunxi: H616: add LPDDR4 DRAM support") Suggested-by: Mikhail Kalashnikov

[PATCH V3 5/9] sunxi: H616: dram: Update mbus priorities

2024-08-30 Thread Chris Morgan
From: Jernej Skrabec CSI1 channel (22) is missing and IOMMU (25) has priority flag set in vendor bootloader. Fix that. While at it, replace bandwidth flag with priority since original flag has always value "true". Signed-off-by: Jernej Skrabec Tested-by: Chris Morgan --- arch/arm/

[PATCH V3 4/9] sunxi: H616: DRAM: Adjust size scan procedure

2024-08-30 Thread Chris Morgan
bank groups too. Signed-off-by: Jernej Skrabec Tested-by: Chris Morgan --- arch/arm/mach-sunxi/dram_sun50i_h616.c | 31 +++--- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/arch/arm/mach-sunxi/dram_sun50i_h616.c b/arch/arm/mach-sunxi/dram_sun50i_h616.c

[PATCH V3 3/9] sunxi: H616: DRAM: Adjust configuration procedure

2024-08-30 Thread Chris Morgan
From: Jernej Skrabec When comparing configuration procedure to vendor driver, I noticed that one command was out of order and that some delays were missing. Fix that. Signed-off-by: Jernej Skrabec Tested-by: Chris Morgan --- arch/arm/mach-sunxi/dram_sun50i_h616.c | 10 +- 1 file

[PATCH V3 2/9] sunxi: H616: DRAM: Add alternative pin mapping

2024-08-30 Thread Chris Morgan
From: Chris Morgan It seems that different dies need different PHY pin mapping. Select alternatives at compile time. Signed-off-by: Jernej Skrabec [adapted to switch from runtime to compile time config] Signed-off-by: Chris Morgan --- arch/arm/mach-sunxi/Kconfig| 17

[PATCH V3 1/9] sunxi: H616: dram: LPDDR4: adjust settings

2024-08-30 Thread Chris Morgan
From: Jernej Skrabec Adjust H616 LPDDR4 DRAM settings to be in line with vendor driver. Signed-off-by: Jernej Skrabec Tested-by: Chris Morgan --- arch/arm/mach-sunxi/dram_sun50i_h616.c| 33 +-- .../dram_timings/h616_lpddr4_2133.c | 2 +- 2 files changed, 24

[PATCH V3 0/9] Add Anbernic RG35XX-2024

2024-08-30 Thread Chris Morgan
From: Chris Morgan Add support for the Anbernic RG35XX-2024. This device is a handheld gaming console (series) based around the Anbernic H700 SoC. It comes with 1GB of RAM and multiple face buttons for input. Add support for the simplest model for now, and then iterate later to add board

[PATCH V2 9/9] sunxi: Add support for Anbernic RG35XX-2024

2024-08-19 Thread Chris Morgan
From: Chris Morgan The Anbernic RG35XX series of devices are based around an Allwinner H700 SoC with 1GB of RAM, 2 SD cards, and multiple input buttons. This bootloader has been tested on the Anbernic RG35XX-2024 and RG35XX-H, but should be suitable for the entire lineup of H700 based devices

[PATCH V2 8/9] arm64: dts: allwinner: h616: Change RG35XX Series from r_rsb to r_i2c

2024-08-19 Thread Chris Morgan
From: Chris Morgan Change the Anbernic RG35XX series to use the r_i2c bus for the PMIC instead of the r_rsb bus. This is to keep the device tree consistent as there are at least 3 devices (the RG35XX-SP, RG28XX, and RG40XX-H) that have an external RTC on the r_i2c bus. Link: https

[PATCH V2 6/9] arm64: dts: allwinner: h616: Add r_i2c pinctrl nodes

2024-08-19 Thread Chris Morgan
From: Chris Morgan Add pinctrl nodes for the r_i2c node. Without the pinmux defined the r_i2c bus may fail to work, possibly if the bootloader uses rsb mode for the PMIC. Link: https://lore.kernel.org/linux-sunxi/172252952262.1669767.7675865282122079154.b4...@csie.org/ [ upstream commit

[PATCH V2 7/9] sunxi: Correct TPR6 parameter for H616 DRAM driver

2024-08-19 Thread Chris Morgan
From: Chris Morgan Correct the default TPR6 parameter based on suggestion from Mikhail Kalashnikov. [1] [1] https://lore.kernel.org/u-boot/4c003cab-c8b8-484d-924d-084e71fe6...@gmail.com/ Fixes: 4b02f0120a4b ("sunxi: H616: add LPDDR4 DRAM support") Suggested-by: Mikhail Kalashnikov

[PATCH V2 5/9] sunxi: H616: dram: Update mbus priorities

2024-08-19 Thread Chris Morgan
From: Jernej Skrabec CSI1 channel (22) is missing and IOMMU (25) has priority flag set in vendor bootloader. Fix that. While at it, replace bandwidth flag with priority since original flag has always value "true". Signed-off-by: Jernej Skrabec Tested-by: Chris Morgan --- arch/arm/

[PATCH V2 4/9] sunxi: H616: DRAM: Adjust size scan procedure

2024-08-19 Thread Chris Morgan
bank groups too. Signed-off-by: Jernej Skrabec Tested-by: Chris Morgan --- arch/arm/mach-sunxi/dram_sun50i_h616.c | 31 +++--- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/arch/arm/mach-sunxi/dram_sun50i_h616.c b/arch/arm/mach-sunxi/dram_sun50i_h616.c

[PATCH V2 3/9] sunxi: H616: DRAM: Adjust configuration procedure

2024-08-19 Thread Chris Morgan
From: Jernej Skrabec When comparing configuration procedure to vendor driver, I noticed that one command was out of order and that some delays were missing. Fix that. Signed-off-by: Jernej Skrabec Tested-by: Chris Morgan --- arch/arm/mach-sunxi/dram_sun50i_h616.c | 10 +- 1 file

[PATCH V2 2/9] sunxi: H616: DRAM: Add alternative pin mapping

2024-08-19 Thread Chris Morgan
From: Jernej Skrabec It seems that different dies need different PHY pin mapping. Select alternatives based on "bond ID". Signed-off-by: Jernej Skrabec Tested-by: Chris Morgan --- arch/arm/mach-sunxi/dram_sun50i_h616.c | 59 +++--- 1 file changed, 44 inserti

[PATCH V2 1/9] sunxi: H616: dram: LPDDR4: adjust settings

2024-08-19 Thread Chris Morgan
From: Jernej Skrabec Adjust H616 LPDDR4 DRAM settings to be in line with vendor driver. Signed-off-by: Jernej Skrabec Tested-by: Chris Morgan --- arch/arm/mach-sunxi/dram_sun50i_h616.c| 33 +-- .../dram_timings/h616_lpddr4_2133.c | 2 +- 2 files changed, 24

[PATCH V2 0/9] Add Anbernic RG35XX-2024

2024-08-19 Thread Chris Morgan
From: Chris Morgan Add support for the Anbernic RG35XX-2024. This device is a handheld gaming console (series) based around the Anbernic H700 SoC. It comes with 1GB of RAM and multiple face buttons for input. Add support for the simplest model for now, and then iterate later to add board

Re: [PATCH 3/9] sunxi: H616: dram: LPDDR4: adjust settings

2024-08-15 Thread Chris Morgan
On Wed, Aug 14, 2024 at 04:06:23PM -0500, Chris Morgan wrote: > On Sat, Aug 03, 2024 at 03:29:17PM +0300, Mikhail Kalashnikov wrote: > > > > On 02.08.2024 01:55, Chris Morgan wrote: > > > From: Jernej Skrabec > > > > > > Adjust H616 LPDDR4 DRAM

Re: [PATCH 3/9] sunxi: H616: dram: LPDDR4: adjust settings

2024-08-14 Thread Chris Morgan
On Sat, Aug 03, 2024 at 03:29:17PM +0300, Mikhail Kalashnikov wrote: > > On 02.08.2024 01:55, Chris Morgan wrote: > > From: Jernej Skrabec > > > > Adjust H616 LPDDR4 DRAM settings to be in line with vendor driver. > > > > Signed-off-by: Jernej

Re: [PATCH 9/9] sunxi: Add support for Anbernic RG35XX-2024

2024-08-02 Thread Chris Morgan
On Fri, Aug 02, 2024 at 04:08:39PM +0530, Sumit Garg wrote: > Hi Andre, > > On Fri, 2 Aug 2024 at 15:27, Andre Przywara wrote: > > > > On Fri, 2 Aug 2024 12:24:56 +0530 > > Sumit Garg wrote: > > > > Hi Sumit, > > > > > Hi Chris, > &

[PATCH 9/9] sunxi: Add support for Anbernic RG35XX-2024

2024-08-01 Thread Chris Morgan
From: Chris Morgan The Anbernic RG35XX series of devices are based around an Allwinner H700 SoC with 1GB of RAM, 2 SD cards, and multiple input buttons. This bootloader has been tested on the Anbernic RG35XX-2024 and RG35XX-H, but should be suitable for the entire lineup of H700 based devices

[PATCH 7/9] sunxi: H616: dram: Update mbus priorities

2024-08-01 Thread Chris Morgan
From: Jernej Skrabec CSI1 channel (22) is missing and IOMMU (25) has priority flag set in vendor bootloader. Fix that. While at it, replace bandwidth flag with priority since original flag has always value "true". Signed-off-by: Jernej Skrabec Tested-by: Chris Morgan --- arch/arm/

[PATCH 8/9] sunxi: dts: arm/arm64: update sun50i-h616.dtsi from Linux-v6.11-rc1

2024-08-01 Thread Chris Morgan
From: Chris Morgan Update the sun50i-h616.dtsi file from upstream linux, and include the fix for selecting the pinctrl for the r_i2c bus from mainline: 7c9ea4ab7617 ("arm64: dts: allwinner: h616: Add r_i2c pinctrl nodes") Signed-off-by: Chris Morgan --- arch/arm/dts/sun50i

[PATCH 6/9] sunxi: H616: DRAM: Adjust size scan procedure

2024-08-01 Thread Chris Morgan
bank groups too. Signed-off-by: Jernej Skrabec Tested-by: Chris Morgan --- arch/arm/mach-sunxi/dram_sun50i_h616.c | 31 +++--- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/arch/arm/mach-sunxi/dram_sun50i_h616.c b/arch/arm/mach-sunxi/dram_sun50i_h616.c

[PATCH 5/9] sunxi: H616: DRAM: Adjust configuration procedure

2024-08-01 Thread Chris Morgan
From: Jernej Skrabec When comparing configuration procedure to vendor driver, I noticed that one command was out of order and that some delays were missing. Fix that. Signed-off-by: Jernej Skrabec Tested-by: Chris Morgan --- arch/arm/mach-sunxi/dram_sun50i_h616.c | 10 +- 1 file

[PATCH 3/9] sunxi: H616: dram: LPDDR4: adjust settings

2024-08-01 Thread Chris Morgan
From: Jernej Skrabec Adjust H616 LPDDR4 DRAM settings to be in line with vendor driver. Signed-off-by: Jernej Skrabec Tested-by: Chris Morgan --- arch/arm/mach-sunxi/dram_sun50i_h616.c| 35 +-- .../dram_timings/h616_lpddr4_2133.c | 2 +- 2 files changed, 26

[PATCH 4/9] sunxi: H616: DRAM: Add alternative pin mapping

2024-08-01 Thread Chris Morgan
From: Jernej Skrabec It seems that different dies need different PHY pin mapping. Select alternatives based on "bond ID". Signed-off-by: Jernej Skrabec Tested-by: Chris Morgan --- arch/arm/mach-sunxi/dram_sun50i_h616.c | 59 +++--- 1 file changed, 44 inserti

[PATCH 2/9] sunxi: H616: dram: LPDDR3: adjust settings

2024-08-01 Thread Chris Morgan
From: Jernej Skrabec Adjust H616 LPDDR3 DRAM settings to be in line with vendor driver. Signed-off-by: Jernej Skrabec Tested-by: Chris Morgan --- arch/arm/mach-sunxi/dram_sun50i_h616.c | 2 +- arch/arm/mach-sunxi/dram_timings/h616_lpddr3.c | 2 +- 2 files changed, 2 insertions(+), 2

[PATCH 1/9] sunxi: H616: dram: DDR3: adjust settings

2024-08-01 Thread Chris Morgan
From: Jernej Skrabec Adjust H616 DDR3 DRAM settings to be in line with vendor driver. Signed-off-by: Jernej Skrabec Tested-by: Chris Morgan --- arch/arm/mach-sunxi/dram_timings/h616_ddr3_1333.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-sunxi

[PATCH 0/9] Add Anbernic RG35XX-2024

2024-08-01 Thread Chris Morgan
From: Chris Morgan Add support for the Anbernic RG35XX-2024. This device is a handheld gaming console (series) based around the Anbernic H700 SoC. It comes with 1GB of RAM and multiple face buttons for input. Add support for the simplest model for now, and then iterate later to add board

Re: [PATCH RFC] gpio: Fix probing of gpio-hogs

2024-07-31 Thread Chris Webb
Hi Simon, Simon Glass wrote: On Wed, 31 Jul 2024 at 04:14, Chris Webb wrote: Alas I don't have any boards to test on for either of these platforms. If you have the inclination it is still worth sending a patch. The maintainer can check it. These sorts of counter-examples can be copie

Re: [PATCH RFC] gpio: Fix probing of gpio-hogs

2024-07-31 Thread Chris Webb
latforms. Best wishes, Chris.

[PATCH] pinctrl: mediatek: Bind gpio while binding pinctrl

2024-07-31 Thread Chris Webb
() to mtk_pinctrl_common_bind() and call this as the .bind method of each of the mediatek pinctrl drivers. Signed-off-by: Chris Webb --- drivers/pinctrl/mediatek/pinctrl-mt7622.c | 1 + drivers/pinctrl/mediatek/pinctrl-mt7623.c | 1 + drivers/pinctrl/mediatek/pinctrl-mt7629.c | 1

Re: [PATCH RFC] gpio: Fix probing of gpio-hogs

2024-07-29 Thread Chris Webb
k soc that uses mtk_pinctrl_common_probe() as they'll all be affected by this problem. Best wishes, Chris.

Re: [PATCH RFC] gpio: Fix probing of gpio-hogs

2024-07-29 Thread Chris Webb
_bind() wouldn't get called at all, but perhaps it's bound too late somehow? Best wishes, Chris.

Re: [PATCH RFC] gpio: Fix probing of gpio-hogs

2024-07-29 Thread Chris Webb
Chris Webb wrote: Now the release is out, I'd be really keen to pick this one up and get it fixed upstream if possible. Hi Tom, is there anything more I can do to help out here? I'd love upstream 2024.10 to ship with gpio-hog that works again. Best wishes, Chris.

Re: [PATCH 3/6] power: pmic: sunxi: replace AXP717 SPL driver

2024-07-10 Thread Chris Morgan
axp_init(void) > -{ > - return pmic_bus_init(); > -} > - > -#if !CONFIG_IS_ENABLED(ARM_PSCI_FW) && > !IS_ENABLED(CONFIG_SYSRESET_CMD_POWEROFF) > -int do_poweroff(struct cmd_tbl *cmdtp, int flag, int argc, char *const > argv[]) > -{ > - pmic_bus_setbits(AXP717_SHUTDOWN, AXP717_POWEROFF); > - > - /* infinite loop during shutdown */ > - while (1) {} > - > - /* not reached */ > - return 0; > -} > -#endif > -- > 2.35.8 > I've been using this for the past week or so on my RG35XX-H for which I've been testing some code and it has worked well for me. Tested-by: Chris Morgan

Re: [PATCH RFC] gpio: Fix probing of gpio-hogs

2024-07-03 Thread Chris Webb
Chris Webb wrote: Tom Rini wrote: Adding Marek, as the author of commit 48b3ecbedf82 ("gpio: Get rid of gpio_hog_probe_all()"). Thanks! I don't claim this is the correct way to fix this, just that it works. Specifically, the two things I found that got gpio-hog wor

Re: [PATCH RFC] gpio: Fix probing of gpio-hogs

2024-06-22 Thread Chris Webb
, presumably (b) isn't right as it would (presumably) need repeating in lots of other pinctrl drivers? Best wishes, Chris.

mkimage alignment of initrd with -T multi

2024-06-19 Thread Chris Packham
e guessing at some magic numbers that I think might be sizes of certain headers. Is there any way to convince mkimage to make sure the initrd is on an appropriately aligned boundary so I don't have to guess. Thanks, Chris

[PATCH RFC] gpio: Fix probing of gpio-hogs

2024-06-13 Thread Chris Webb
: [...] CPU: MediaTek MT7981 Model: GL.iNet GL-X3000 DRAM: 512 MiB [...] Core: 34 devices, 14 uclasses, devicetree: separate MMC: mmc@1123: 0 [...] Probe them directly in gpio_post_bind instead. Signed-off-by: Chris Webb --- drivers/gpio/gpio-uclass.c | 4 +++- 1 file

Re: Debugging gpio-hogs which don't get probed

2024-06-11 Thread Chris Webb
Chris Webb wrote: This shows gpio_post_bind being called, then the four gpio-hogs found and set to probe after bind, but the gpio_hog_probe function is never actually called. Presumably this is the problem - if they're not probed then they'll never take effect? I enabled CONF

Debugging gpio-hogs which don't get probed

2024-06-11 Thread Chris Webb
. Nothing relevant happens after gpio_post_bind is called. Is this a bug or is there some basic config/dts mistake on my part here? Is there some other debug info I can get that might shed light on what's going on, or some config prerequisite for DM_FLAG_PROBE_AFTER_BIND to work that I'm likely to be missing? Best wishes, Chris.

Re: [PATCH V3] board: rockchip: Add Indiedroid Nova

2024-05-24 Thread Chris Morgan
t; configs/nova-rk3588s_defconfig| 69 +++ > > Here's the defconfig file, but: > > > > @@ -0,0 +1,6 @@ > > > +INDIEDROID-NOVA-RK3588 > > > +M: Chris Morgan > > > +S: Maintained > > > +F:

[PATCH V4] board: rockchip: Add Indiedroid Nova

2024-05-24 Thread Chris Morgan
From: Chris Morgan The Indiedroid Nova is a Rockchip RK3588S based SBC from Indiedroid. Specifications: Rockchip RK3588S SoC 4x ARM Cortex-A76, 4x ARM Cortex-A55 4/8/16GB memory LPDDR4x Mali G610MC4 GPU Optional eMMC 2x USB 2.0, 2x USB 3.0, 1x USB 3.0 C port with DP Alt

Re: [PATCH 1/2 V2] Revert "board: rockchip: Add early ADC button detect for RGxx3"

2024-05-23 Thread Chris Morgan
On Thu, May 23, 2024 at 11:47:41AM +0800, Kever Yang wrote: > > On 2024/5/21 23:45, Chris Morgan wrote: > > From: Chris Morgan > > > > This reverts commit 41a60d0e5cef54a59596a58940fa7c9cf071034b. > > > > On some of the supported devices the adc detect cod

Re: [PATCH v2] fdt: automatically add /chosen/kaslr-seed if DM_RNG is enabled

2024-05-21 Thread Chris Morgan
> >> +/* > > >> + * Copyright 2024 Tim Harvey > > >> + */ > > >> +#include > > >> +#include > > >> +#include > > >> + > > >> +int fdt_kaslrseed(void *fdt) > > >> +{ > > >> +

Re: [PATCH 2/2] board: rockchip: rgxx3: Use sdmmc0 as first device

2024-05-21 Thread Chris Morgan
On Thu, May 02, 2024 at 10:00:46PM +0200, Jonas Karlman wrote: > Hi Chris, > > On 2024-05-02 21:34, Chris Morgan wrote: > > From: Chris Morgan > > > > Some of the rgxx3 devices do not have a way to recover from a poor > > flash of a bootloader to eMMC. Set the

[PATCH 2/2 V2] board: rockchip: rgxx3: Use sdmmc0 as first device

2024-05-21 Thread Chris Morgan
From: Chris Morgan Some of the rgxx3 devices do not have a way to recover from a poor flash of a bootloader to eMMC. Set the device to always attempt to boot from sdmmc0 first which ensures that we can override the boot from emmc if we have a card present with a valid fit signature. The

[PATCH 1/2 V2] Revert "board: rockchip: Add early ADC button detect for RGxx3"

2024-05-21 Thread Chris Morgan
From: Chris Morgan This reverts commit 41a60d0e5cef54a59596a58940fa7c9cf071034b. On some of the supported devices the adc detect code always returns that the button has been pushed, and as a result the device will not boot normally. Signed-off-by: Chris Morgan --- board/anbernic/rgxx3_rk3566

[PATCH 0/2 V2] RGXX3: Set boot order for mmc0 first

2024-05-21 Thread Chris Morgan
From: Chris Morgan Set the rgxx3 device to boot from mmc0 first. This serves as a fallback to allow us to recover from a bad U-Boot (or later) stage in a worst case scenario. The code for an ADC button appears to have broke some board revisions; this solution is much simpler and allows users to

[PATCH V3] board: rockchip: Add Indiedroid Nova

2024-05-21 Thread Chris Morgan
From: Chris Morgan The Indiedroid Nova is a Rockchip RK3588S based SBC from Indiedroid. Specifications: Rockchip RK3588S SoC 4x ARM Cortex-A76, 4x ARM Cortex-A55 4/8/16GB memory LPDDR4x Mali G610MC4 GPU Optional eMMC 2x USB 2.0, 2x USB 3.0, 1x USB 3.0 C port with DP Alt

[PATCH V4] board: rockchip: add Powkiddy X55

2024-05-21 Thread Chris Morgan
From: Chris Morgan The Powkiddy X55 is a Rockchip RK3566 based handheld gaming device. UART, ADC, eMMC, and SDMMC are tested to work in U-Boot and this successfully boots mainline Linux. Kernel commit: e99adc97e21a ("arm64: dts: rockchip: Add Powkiddy X55") Signed-off-by: Ch

[PATCH V3] board: rockchip: add Powkiddy X55

2024-05-02 Thread Chris Morgan
From: Chris Morgan The Powkiddy X55 is a Rockchip RK3566 based handheld gaming device. UART, ADC, eMMC, and SDMMC are tested to work in U-Boot and this successfully boots mainline Linux. Kernel commit: e99adc97e21a ("arm64: dts: rockchip: Add Powkiddy X55") Signed-off-by: Ch

[PATCH 2/2] board: rockchip: rgxx3: Use sdmmc0 as first device

2024-05-02 Thread Chris Morgan
From: Chris Morgan Some of the rgxx3 devices do not have a way to recover from a poor flash of a bootloader to eMMC. Set the device to always attempt to boot from sdmmc0 first which ensures that we can override the boot from emmc if we have a card present with a valid U-Boot stage. Signed-off

[PATCH 1/2] Revert "board: rockchip: Add early ADC button detect for RGxx3"

2024-05-02 Thread Chris Morgan
From: Chris Morgan This reverts commit 41a60d0e5cef54a59596a58940fa7c9cf071034b. On some of the supported devices the adc detect code always returns that the button has been pushed, and as a result the device will not boot normally. Signed-off-by: Chris Morgan --- board/anbernic/rgxx3_rk3566

[PATCH 0/2] RGXX3: Set boot order for mmc0 first

2024-05-02 Thread Chris Morgan
From: Chris Morgan Set the rgxx3 device to boot from mmc0 first. This serves as a fallback to allow us to recover from a bad U-Boot (or later) stage in a worst case scenario. The code for an ADC button appears to have broke some board revisions; this solution is much simpler and allows users to

[PATCH V2] board: rockchip: Add Indiedroid Nova

2024-05-02 Thread Chris Morgan
From: Chris Morgan The Indiedroid Nova is a Rockchip RK3588S based SBC from Indiedroid. Specifications: Rockchip RK3588S SoC 4x ARM Cortex-A76, 4x ARM Cortex-A55 4/8/16GB memory LPDDR4x Mali G610MC4 GPU Optional eMMC 2x USB 2.0, 2x USB 3.0, 1x USB 3.0 C port with DP Alt

Re: [PATCH 014/149] board: alliedtelesis: Remove and add needed includes

2024-04-30 Thread Chris Packham
On 1/05/24 14:41, Tom Rini wrote: > Remove from this board vendor directory and when needed > add missing include files directly. > > Signed-off-by: Tom Rini > --- > Cc: Chris Packham Reviewed-by: Chris Packham > --- > board/alliedtelesis/SBx81LIFKW/sbx81lif

Re: [PATCH 010/149] board: Marvell: Remove and add needed includes

2024-04-30 Thread Chris Packham
On 1/05/24 14:40, Tom Rini wrote: > Remove from this board vendor directory and when needed > add missing include files directly. > > Signed-off-by: Tom Rini > --- > Cc: Stefan Roese > Cc: Chris Packham > Cc: Tony Dinh > Cc: Jason Cooper > Cc: Siddarth Gore

Re: [PATCH] mtd: nand: pxa3xx: Incorrect bitflip return on page read

2024-04-29 Thread Chris Packham
tected at PEB 125 > ubi0: run torture test for PEB 125 > ubi0: fixable bit-flip detected at PEB 125 > ubi0 error: torture_peb: read problems on freshly erased PEB 125, > must be bad > ubi0 error: erase_worker: failed to erase PEB 125, error -5 > ubi0: mark PEB 125 as bad > >

[PATCH] rockchip: Correct UUID for root partitions

2024-04-26 Thread Chris Morgan
From: Chris Morgan For root partitions, the UUID should still be random but the partition type uuid should either be b921b045-1df0-41c3-af44-4c6f280d3fae for aarch64 or 69dad710-2ce4-4e3c-b16c-21a1d49abed3 for aarch32. Correct the attribute so it is the partition type that is hard coded and not

Many USB storage drives fail in latest U-boot

2024-04-26 Thread Chris Ziomkowski
YET, etc.)." Can the individual who is maintaining this section of the code (or anyone knowledgeable about the implementation) offer some advice on how this should be corrected? Best regards, Chris

Re: [V1 PATCH 1/2] rockchip: sdram: Support getting banks from TPL for rk3568 and rk3588

2024-04-04 Thread Chris Morgan
On Tue, Apr 02, 2024 at 06:38:59PM +0200, Quentin Schulz wrote: > Hi Chris, > > On 4/1/24 20:14, Chris Morgan wrote: > > From: Chris Morgan > > > > Allow RK3568 and RK3588 based boards to get the RAM bank configuration > > from the ROCKCHIP_TPL stage instead

[PATCH] board: rockchip: Add Indiedroid Nova

2024-04-01 Thread Chris Morgan
From: Chris Morgan The Indiedroid Nova is a Rockchip RK3588S based SBC from Indiedroid. Specifications: Rockchip RK3588S SoC 4x ARM Cortex-A76, 4x ARM Cortex-A55 4/8/16GB memory LPDDR4x Mali G610MC4 GPU Optional eMMC 2x USB 2.0, 2x USB 3.0, 1x USB 3.0 C port with DP Alt

[V2 PATCH 2/2] rockchip: Switch RK3568 and RK3588 to new RAM bank logic

2024-04-01 Thread Chris Morgan
From: Chris Morgan Switch all RK3568 and RK3588 boards to use the ATAGS based RAM bank logic. This allows us to access all RAM when >= 4GB of RAM is available while also automatically creating the memory holes when >= 16GB of RAM is available. Remove the board specific logic that prev

[V1 PATCH 1/2] rockchip: sdram: Support getting banks from TPL for rk3568 and rk3588

2024-04-01 Thread Chris Morgan
From: Chris Morgan Allow RK3568 and RK3588 based boards to get the RAM bank configuration from the ROCKCHIP_TPL stage instead of the current logic. This fixes both an issue where 256MB of RAM is blocked for devices with >= 4GB of RAM and where memory holes need to be defined for devices w

[V2 PATCH 0/2] Update RAM Bank Logic for RK3568/RK3588

2024-04-01 Thread Chris Morgan
From: Chris Morgan Use the ATAG info provided by the Rockchip binary TPL to identify RAM banks on the RK3568 and RK3588 when using the ROCKCHIP_TPL binary. This is needed because there are specific addresses that should not be written to for all RK3588 based devices with >=16GB of RAM, writ

Re: [RFC 2/2] rockchip: rk3588: Add SoC specific RAM bank logic

2024-03-30 Thread Chris Morgan
On Sat, Mar 30, 2024 at 11:53:38AM +0100, Jonas Karlman wrote: > Hi Chris, > > On 2024-03-30 06:05, Chris Morgan wrote: > > From: Chris Morgan > > > > Add SoC specific RAM bank logic for the rk3588 boards. This logic > > works by reading the ATAGS crea

Re: [RFC 1/2] rockchip: sdram: Allow board/soc specific RAM bank logic

2024-03-30 Thread Chris Morgan
On Sat, Mar 30, 2024 at 12:00:46PM +0100, Jonas Karlman wrote: > Hi Chris, > > On 2024-03-30 06:05, Chris Morgan wrote: > > From: Chris Morgan > > > > Allow individual boards or SoCs to alter the RAM bank addition logic > > by defining a __weak function th

[RFC 2/2] rockchip: rk3588: Add SoC specific RAM bank logic

2024-03-29 Thread Chris Morgan
From: Chris Morgan Add SoC specific RAM bank logic for the rk3588 boards. This logic works by reading the ATAGS created by the ROCKCHIP_TPL stage and applies fixups on those to ensure we aren't stepping on any reserved memory addresses. The existing logic requires us to define memory hol

[RFC 1/2] rockchip: sdram: Allow board/soc specific RAM bank logic

2024-03-29 Thread Chris Morgan
From: Chris Morgan Allow individual boards or SoCs to alter the RAM bank addition logic by defining a __weak function that these boards can then override if needed. In the event this function fails, fallback to the default detection logic. Signed-off-by: Chris Morgan --- arch/arm/mach

[RFC 0/2] Update RAM Bank Logic for RK3588

2024-03-29 Thread Chris Morgan
From: Chris Morgan Use the ATAG info provided by the Rockchip binary TPL to identify RAM banks on the RK3588 when using the ROCKCHIP_TPL binary. This is needed because there are specific addresses that should not be written to for all RK3588 based devices with >=16GB of RAM, writing to th

Re: [PATCH 1/2] rockchip: rk3588: Add support for ATAG parsing

2024-03-28 Thread Chris Morgan
On Thu, Mar 28, 2024 at 04:02:09PM -0400, Tom Rini wrote: > On Wed, Mar 27, 2024 at 10:03:11AM -0500, Chris Morgan wrote: > > On Wed, Mar 27, 2024 at 04:21:49PM +0200, Eugen Hristev wrote: > > > On 3/27/24 15:32, Chris Morgan wrote: > > > > On Wed, Mar 27, 2024 a

Re: [PATCH 1/2] rockchip: rk3588: Add support for ATAG parsing

2024-03-27 Thread Chris Morgan
On Wed, Mar 27, 2024 at 04:21:49PM +0200, Eugen Hristev wrote: > On 3/27/24 15:32, Chris Morgan wrote: > > On Wed, Mar 27, 2024 at 06:32:06PM +0800, Kever Yang wrote: > >> Hi Chris, > >> > >>     The ATAGS is used for passing parameter from bootloader to

Re: [PATCH 1/2] rockchip: rk3588: Add support for ATAG parsing

2024-03-27 Thread Chris Morgan
On Wed, Mar 27, 2024 at 06:32:06PM +0800, Kever Yang wrote: > Hi Chris, > >     The ATAGS is used for passing parameter from bootloader to kernel at > first, which has been replaced by DTB now for ARM platform. > >     And Rockchip using ATAGs for passing parameter like dram m

[PATCH 2/2] rockchip: rk3588: Add Support for RAM Defines from ATAGs

2024-03-26 Thread Chris Morgan
From: Chris Morgan Add support for defining the usable RAM from ATAGs provided by the Rockchip binary TPL loader. This allows us to automatically account for necessary memory holes on RK3588 devices with 16GB of RAM or more, as well as ensure we can use the full amount of RAM available. In the

[PATCH 1/2] rockchip: rk3588: Add support for ATAG parsing

2024-03-26 Thread Chris Morgan
From: Chris Morgan Add support for parsing the ATAGs created by the Rockchip binary RAM init. This ATAG parsing code was taken from the Rockchip BSP U-Boot source and tested only on parsing the RAM specific ATAGs for the RK3588. Signed-off-by: Chris Morgan --- arch/arm/include/asm/arch

[PATCH 0/2] Use ATAGs for RK3588 For RAM Info

2024-03-26 Thread Chris Morgan
From: Chris Morgan Use the ATAG info provided by the Rockchip binary TPL to identify RAM banks. This is needed because there are specific addresses that should not be written to for all RK3588 based devices with >=16GB of RAM, writing to these addresses immediately results in a crash. Ch

Re: [PATCH 4/4] board: rockchip: Add early ADC button detect for RGxx3

2024-02-05 Thread Chris Morgan
On Tue, Feb 06, 2024 at 10:53:13AM +0800, Kever Yang wrote: > > On 2024/2/6 02:58, Chris Morgan wrote: > > From: Chris Morgan > > > > Add ADC button detect for early SPL stage for RGxx3 device. This is > > important because on at least the RG353P and RG353V a c

Re: [PATCH 1/4] arm: dts: rockchip: rk3566: Remove unnecessary clks from rgxx3

2024-02-05 Thread Chris Morgan
On Tue, Feb 06, 2024 at 10:38:40AM +0800, Kever Yang wrote: > Hi Chris, > > On 2024/2/6 02:58, Chris Morgan wrote: > > From: Chris Morgan > > > > Remove unnecessary clock frequency defines from the RGxx3 u-boot dts. > > Move the necessary defines to the RGxx3 m

[PATCH 4/4] board: rockchip: Add early ADC button detect for RGxx3

2024-02-05 Thread Chris Morgan
From: Chris Morgan Add ADC button detect for early SPL stage for RGxx3 device. This is important because on at least the RG353P and RG353V a clk pin is not exposed that would allow us to take the eMMC out of the boot path. Signed-off-by: Chris Morgan --- board/anbernic/rgxx3_rk3566/rgxx3

[PATCH 2/4] board: rockchip: Add support for Powkiddy RGB10MAX3

2024-02-05 Thread Chris Morgan
From: Chris Morgan Add support to the RGxx3 device for the Powkiddy RGB10MAX3. This device is extremely similar to all the other devices and can use the same bootloader with the same detection logic. Signed-off-by: Chris Morgan --- arch/arm/dts/rk3566-anbernic-rgxx3.dts | 9

  1   2   3   4   5   6   7   8   9   10   >