Hi Mattijs,
Sorry, I did not realize there were outstanding issues for me to address. I
would be happy to send a v5, but if you doing the fixups gets this merged
quicker, that sounds better to me.
Happy to contribute,
*_*
*Colin McAllister*
On Thu, Mar 21, 2024 at 4:29 AM
From: Colin McAllister
Currently, setting CONFIG_AB_BACKUP_OFFSET in a target's defconfig will
not actually enable the #if protected code in android_ab.c. This is
because "CONFIG_" should have been prepended to the config macro, or the
macros defined in kconfig.h could have been used.
From: Colin McAllister
Found a missing semicolon in code protected by a #if that will never
evaluate to true due to a separate issue. Fixing this issue before
addressing the #if.
Fixes: 3430f24bc6 ("android_ab: Try backup booloader_message")
Signed-off-by: Colin McAllister
Cc: Joshu
e to false for all C if conditions.
Colin McAllister (2):
android_ab: Add missing semicolon
android_ab: Fix ANDROID_AB_BACKUP_OFFSET
boot/android_ab.c | 97 ++-
1 file changed, 45 insertions(+), 52 deletions(-)
--
2.34.1
to be added to the ML.
Best,
Colin
From: Mattijs Korpershoek
Sent: Tuesday, March 12, 2024 4:47 AM
To: Sam Protsenko ; McAllister, Colin
Cc: u-boot@lists.denx.de; jpewhac...@gmail.com; s...@chromium.org; Igor Opaniuk
Subject: Re: [PATCH v3 0/2] Fix Android A/B backup
Hi Colin, On ven. , mars
mails you include your reviewed-by tag. For clarity, Am I
supposed to append my patches and upload a new version? This is my
first time contributing to u-boot, so I'm still learning the workflow. I
didn't see anything glancing through the "Sending patches" page in the
U-Boot document
e included by ANDROID_AB_BACKUP_OFFSET has been refactored to no
longer be conditionally compiled by preprocessor conditionals and
instead use C conditionals. This better aligns with the Linux kernel
style guide.
Fixes: 3430f24bc6 ("android_ab: Try backup booloader_message")
Signed-off-by: Colin McAllis
Found a missing semicolon in code protected by a #if that will never
evaluate to true due to a separate issue. Fixing this issue before
addressing the #if.
Fixes: 3430f24bc6 ("android_ab: Try backup booloader_message")
Signed-off-by: Colin McAllister
Cc: Joshua Watt
Cc: Simon Gla
This is
what I would expect, because CONFIG_ANDROID_AB_BACKUP_OFFSET's default
value is 0x0, which would evaluate to false for all C if conditions.
Colin McAllister (2):
android_ab: Add missing semicolon
android_ab: Fix ANDROID_AB_BACKUP_OFFSET
bo
was used to properly restore the primary. I then corrupted both
the primary and backup data and confirmed that the primary and backup
were both reinitialized to default values. Lastly, I corrupted the
backup data and not the primary data and confirmed that the backup was
restored the primary data.
Colin
Found a missing semicolon in code protected by a #if that will never
evaluate to true due to a separate issue. Fixing this issue before
addressing the #if.
Signed-off-by: Colin McAllister
Cc: Joshua Watt
Cc: Simon Glass
---
boot/android_ab.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
e included by ANDROID_AB_BACKUP_OFFSET has been refactored to no
longer be conditionally compiled by preprocessor conditionals and
instead use C conditionals. This better aligns with the Linux kernel
style guide.
Signed-off-by: Colin McAllister
Cc: Joshua Watt
Cc: Simon Glass
---
boot/android
KUP_OFFSET is now wrapped within CONFIG_VAL().
Signed-off-by: Colin McAllister
Cc: Joshua Watt
Cc: Simon Glass
---
boot/android_ab.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/boot/android_ab.c b/boot/android_ab.c
index 9a3d15ec60..a80040749d 100644
Found a missing semicolon in code protected by a #if that will never
evaluate to true due to a separate issue. Fixing this issue before
addressing the #if.
Signed-off-by: Colin McAllister
Cc: Joshua Watt
Cc: Simon Glass
---
boot/android_ab.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
fixing the #if's. Testing the latter
patch without the former with ANDORID_AB_BACKUP_OFFSET set will cause a
compiler error.
Colin McAllister (2):
android_ab: Add missing semicolon
android_ab: Fix ANDROID_AB_BACKUP_OFFSET
boot/android_ab.c | 24
1 file changed, 12
Hi Michael,
On Mon, Jun 26, 2023 at 07:03:19AM +0200, Michael Nazzareno Trimarchi wrote:
> Hi all
>
> Il sab 20 mag 2023, 19:28 Colin Foster ha
> scritto:
>
> > On Fri, May 19, 2023 at 03:41:34PM +0300, Roger Quadros wrote:
> > > Hi Colin,
> > >
> &
On Fri, May 19, 2023 at 03:41:34PM +0300, Roger Quadros wrote:
> Hi Colin,
>
> On 19/05/2023 02:19, Colin Foster wrote:
> > Hi Roger,
> >
> >> Can you please share your spl/u-boot.cfg?
> >
> > Attached
>
> Couple of questions there
>
> 1)
Hi Roger,
I really appreciate the help!
On Thu, May 18, 2023 at 01:55:38PM +0300, Roger Quadros wrote:
> Hi Colin,
>
> On 17/05/2023 22:39, Colin Foster wrote:
> >
> > I swapped in just U-Boot (not the SPL) with your patch, and everything
> > seems to work!
> >
Hi Roger,
Thanks for the tests. I attached the files and commented in line... but
at the bottom of this email I have some findings...
On Wed, May 17, 2023 at 04:30:55PM +0300, Roger Quadros wrote:
> Hi Colin,
>
> I just tested this on AM335x EVM which uses BCH8_CODE_HW but 8-bit NAND
Hi Roger,
On Fri, May 12, 2023 at 02:53:07PM +0300, Roger Quadros wrote:
>
>
> On 10/05/2023 18:38, Colin Foster wrote:
> >
> > This is still out-of-U-Boot. I have an include/configs/our_product.h
> > file with this:
> >
> > """
> >
Hi Roger,
On Wed, May 10, 2023 at 12:42:43PM +0300, Roger Quadros wrote:
> Hi Colin,
>
> On 09/05/2023 18:31, Colin Foster wrote:
> > Hi Roger,
> >
> > I was looking to test my system against U-Boot 2023.04. I'm running an
> > OMAP 4460 SOM (I've been waiting
.
Allow partial reads to restore functionality to the code path
spl_nand_load_element() -> spl_load_legacy_img() ->
spl_nand_legacy_read(load, header, sizeof(hdr), header);
Signed-off-by: Colin Foster
Reviewed-by: Dario Binacchi
---
v2:
Add Dario reviewed tag
Use existing heap i
SPL configurations that read from NAND need a page of RAM as a buffer.
Initially this memory was statically allocated.
Move this to the heap, so it can benefit from initialized DDR.
Signed-off-by: Colin Foster
---
v2:
New patch.
Note: This patch gives an SPDX warning due to the comment
and resubmit.
Colin Foster (2):
mtd: rawnand: nand_spl_loaders: move nand page buffer to heap
mtd: rawnand: nand_spl_loaders: allow partial nand page reads during
nand_spl_load_image
drivers/mtd/nand/raw/nand_spl_loaders.c | 46 ++---
1 file changed, 34 insertions(+), 12
ing
wrong here?
Any advice would be greatly appreciated, as I find it is usually
something simple I'm doing wrong that is causing most of my issues.
Thanks,
Colin Foster.
On Tue, Nov 29, 2022 at 10:00:19AM +0100, Dario Binacchi wrote:
> Hi Colinn
>
> On Fri, Nov 18, 2022 at 1:08 PM Dario Binacchi
> wrote:
> >
> > Hi Colin,
> >
> > On Tue, Nov 15, 2022 at 5:35 PM Colin Foster
> > wrote:
> > >
> > > The n
.
Allow partial reads to restore functionality to the code path
spl_nand_load_element() -> spl_load_legacy_img() ->
spl_nand_legacy_read(load, header, sizeof(hdr), header);
Signed-off-by: Colin Foster
---
drivers/mtd/nand/raw/nand_spl_loaders.c | 36 -
1 file chang
On Monday, October 12, 2015 at 6:43:37 AM UTC-7, Maxime Ripard wrote:
>
> Hi,
>
> I'm currently writing the support in U-Boot for NAND-backed devices
> using fastboot [1], and that work derived a bit to supporting the
> sparse images.
>
> For "regular" images that are being stored, we expect a
Add a BSD-3 relicensed version of the Android sparse format image
header from:
https://android.googlesource.com/platform/system/core/+/28fa5bc347390480fe190294c6c385b6a9f0d68b/libsparse/sparse_format.h
Unchanged except for the license header.
Cc: Tom Rini tr...@ti.com
Signed-off-by: Colin Cross
On Tue, Jan 24, 2012 at 2:08 PM, Stephen Warren swar...@nvidia.com wrote:
Peter De Schrijver wrote at Tuesday, January 24, 2012 2:53 AM:
What about the peripheral resets which are also handled by CAR? Peripheral
clock nodes also offer assert and deassert methods for the reset signal
associated
On Tue, Jan 24, 2012 at 2:43 PM, Stephen Warren swar...@nvidia.com wrote:
Colin Cross wrote at Tuesday, January 24, 2012 3:33 PM:
On Tue, Jan 24, 2012 at 2:08 PM, Stephen Warren swar...@nvidia.com wrote:
Peter De Schrijver wrote at Tuesday, January 24, 2012 2:53 AM:
What about the peripheral
31 matches
Mail list logo
