Hello Quentin,
Thanks for fixing this issue! Please see my comments below.
On 2024-05-24 13:42, Quentin Schulz wrote:
From: Quentin Schulz
The ID of the PMIC is stored in the 2 16b registers but the only part
that matters right now is the 3 MSB, which make the 3 digits (in hex)
of
the
Hello all,
On 2024-05-14 01:02, Marek Vasut wrote:
On 5/13/24 10:52 PM, Tim Harvey wrote:
On Mon, Apr 29, 2024 at 1:51 PM Marek Vasut wrote:
On 4/29/24 6:48 PM, Tim Harvey wrote:
On Sat, Apr 27, 2024 at 4:20 PM Marek Vasut wrote:
On 4/27/24 2:11 AM, Tim Harvey wrote:
[...]
diff --git
Hello Jonas,
On 2024-05-04 21:42, Jonas Karlman wrote:
This series migrate RK3308, RK3328, RK356x and RK3588 boards that
exists
in Linux kernel v6.8 to use OF_UPSTREAM.
I went quickly through all the patches in this series and they
in general look good to me. I didn't check all of them in
On 2024-05-01 18:22, Jonas Karlman wrote:
Remove the obsolete ethernet0 alias now that all board device tree
files
have been fully synced with Linux kernel v6.8.
Signed-off-by: Jonas Karlman
Nice, thanks for handling the move of the ethernetX aliases around.
Reviewed-by: Dragan Simic
also gets
resolved to the SPI flash node and loading FIT from SPI flash works
without having the node explicitly referenced in spl-boot-order prop.
Signed-off-by: Jonas Karlman
Looking good to me.
Reviewed-by: Dragan Simic
---
v2: Update commit message
---
arch/arm/dts/rk3399-eaidk-610-u-boot
On 2024-04-30 17:30, Jonas Karlman wrote:
Imply OF_LIBFDT_OVERLAY Kconfig options to add device tree overlay
support on all RK3399 boards.
Signed-off-by: Jonas Karlman
Reviewed-by: Quentin Schulz
Reviewed-by: Kever Yang
Looking good to me.
Reviewed-by: Dragan Simic
---
v2: Collect r-b
On 2024-04-30 17:30, Jonas Karlman wrote:
Imply support for GbE PHY status parsing and configuration when support
for onboard ethernet is enabled.
Signed-off-by: Jonas Karlman
Reviewed-by: Quentin Schulz
Reviewed-by: Kever Yang
Looking good to me.
Reviewed-by: Dragan Simic
---
v2
quot; prop.
Signed-off-by: Jonas Karlman
Reviewed-by: Quentin Schulz
Reviewed-by: Peter Robinson
Reviewed-by: Kever Yang
Looking good to me.
Reviewed-by: Dragan Simic
---
v2: Move rng node cleanup to this patch
v2: Collect r-b tags
---
arch/arm/dts/rk3399-pinephone-pro-u-boot.dtsi | 4
ar
On 2024-04-30 17:30, Jonas Karlman wrote:
Sort imply statements under ROCKCHIP_RK3399 alphabetically.
Signed-off-by: Jonas Karlman
Reviewed-by: Kever Yang
Looking good to me.
Reviewed-by: Dragan Simic
---
v2: Collet r-b tags
---
arch/arm/mach-rockchip/Kconfig | 26
On 2024-04-27 09:25, Dragan Simic wrote:
On 2024-04-26 19:36, Tim Harvey wrote:
On Fri, Apr 26, 2024 at 10:25 AM Marek Vasut wrote:
On 4/26/24 7:12 PM, Tim Harvey wrote:
> +static const char *mmc_partnames[] = {
> + "user",
> + "boot0",
> + &quo
Hello Tim and Marek,
On 2024-04-26 19:36, Tim Harvey wrote:
On Fri, Apr 26, 2024 at 10:25 AM Marek Vasut wrote:
On 4/26/24 7:12 PM, Tim Harvey wrote:
> +static const char *mmc_partnames[] = {
> + "user",
> + "boot0",
> + "boot1",
> + "gp1",
> + "gp2",
> + "gp3",
> +
Hello Tim,
Please see my comments below.
On 2024-04-26 18:55, Tim Harvey wrote:
To aid in understanding what emmc hardware partition is being
used to boot on power-up, display the hardware partition name in the
SPL.
Signed-off-by: Tim Harvey
---
board/gateworks/venice/spl.c | 16
On 2024-04-22 10:24, Kever Yang wrote:
On 2024/4/18 15:06, Dragan Simic wrote:
Use a wildcard to simplify the list of board DT files in the
MAINTAINERS
file for the Radxa Rock 2 Square board.
Signed-off-by: Dragan Simic
Reviewed-by: Kever Yang
Thanks!
---
board/radxa/rock2
Use a wildcard to simplify the list of board DT files in the MAINTAINERS
file for the Radxa Rock 2 Square board.
Signed-off-by: Dragan Simic
---
board/radxa/rock2/MAINTAINERS | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/board/radxa/rock2/MAINTAINERS b/board/radxa/rock2
Hello Jaehoon,
On 2024-04-17 01:33, Jaehoon Chung wrote:
-Original Message-
From: Quentin Schulz
Sent: Wednesday, April 10, 2024 5:57 PM
To: Dragan Simic
Cc: Jonas Karlman ; Peng Fan ;
Jaehoon Chung
; Tom Rini ;
u-boot@lists.denx.de
Subject: Re: [PATCH 1/2] mmc: Imply HS200 cap
On 2024-04-16 16:51, Francesco Dolcini wrote:
On Tue, Apr 16, 2024 at 03:18:08PM +0200, Dragan Simic wrote:
On 2024-04-16 08:59, Francesco Dolcini wrote:
> On Tue, Apr 16, 2024 at 02:36:12AM +0200, Tom Rini wrote:
> > On Mon, Apr 15, 2024 at 02:22:02PM +0200, Heinrich Schuchardt wrote
On 2024-04-16 08:59, Francesco Dolcini wrote:
On Tue, Apr 16, 2024 at 02:36:12AM +0200, Tom Rini wrote:
On Mon, Apr 15, 2024 at 02:22:02PM +0200, Heinrich Schuchardt wrote:
> On 15.04.24 13:35, Michal Simek wrote:
> > Some of Kconfigs are using utf-8 encoding because of used chars. Convert
> >
environment is being read from env_mmc_load before env_import_redund is
called so it is printing a bit later (and possibly after error/warning
messages).
Cc: Quentin Schulz
Signed-off-by: Quentin Schulz
Looking great to me.
Reviewed-by: Dragan Simic
---
env/mmc.c | 3 +++
1 file changed, 3
Hello Caleb,
On 2024-04-15 13:18, Caleb Connolly wrote:
On 15/04/2024 12:14, Dragan Simic wrote:
Hello all,
On 2024-04-15 13:11, Robert Marko wrote:
On Mon, Apr 15, 2024 at 12:57 PM Caleb Connolly
wrote:
On 15/04/2024 11:53, Robert Marko wrote:
> Recent addition of vbus-supply support
Hello all,
On 2024-04-15 13:11, Robert Marko wrote:
On Mon, Apr 15, 2024 at 12:57 PM Caleb Connolly
wrote:
On 15/04/2024 11:53, Robert Marko wrote:
> Recent addition of vbus-supply support has broke platform which dont use
> controllable regulators for USB.
>
> Issue is that even withou
Karlman
Looking good to me. Thanks for peforming this dynamically, based
on the actual MMC interface speed/mode.
Reviewed-by: Dragan Simic
---
v2: Move cfg->b_max configuration to set_ios_post() ops
This significantly speed up FIT loading from eMMC on RK3588 boards with
a mmc-hs200 p
On 2024-04-15 10:58, Quentin Schulz wrote:
On 4/13/24 20:13, Jonas Karlman wrote:
Add .dtb-file entry to Makefile and enable Kconfig options required to
configure pinctrl in SPL. Also add missing
PHY_ROCKCHIP_NANENG_COMBOPHY.
Separate commits please.
Perhaps the Makefile changes from a
Hello Quentin,
On 2024-04-15 10:56, Quentin Schulz wrote:
Hi Jonas,
On 4/13/24 20:13, Jonas Karlman wrote:
Add the CoolPi 4 Model B and CoolPi CM5 EVB board to the
documentation.
Also fix .dtb-file entries in Makefile.
When one needs to use a list or say "also", "moreover", etc... it
On 2024-04-15 10:23, Jonas Karlman wrote:
On 2024-04-15 09:00, Dragan Simic wrote:
Please see my comments below.
On 2024-04-13 20:13, Jonas Karlman wrote:
A few RK3588 boards are missing a mmc-hs200 prop to signal that HS200
mode is supported in addition to HS400, this lead to bad performance
On 2024-04-15 10:03, Jonas Karlman wrote:
On 2024-04-15 08:37, Dragan Simic wrote:
Please see a couple of comments below.
On 2024-04-13 20:13, Jonas Karlman wrote:
The RK35xx SoCs contain a crypto engine block that can generate
random
numbers.
Enable rng node in soc u-boot.dtsi and enable
submitted to the mailing list. [1]
That would allow a significant cleanup of the U-Boot dtsi files
to be performed.
Until that's resolved, the patch is looking good to me.
Reviewed-by: Dragan Simic
[1]
https://lore.kernel.org/u-boot/20240408210619.3749231-1-jo...@kwiboo.se/
---
v2: New patch
: 3e15dee38d45 ("board: rockchip: Add support for rk3588 based
Cool Pi CM5 EVB")
Signed-off-by: Jonas Karlman
Looking good to me.
Reviewed-by: Dragan Simic
---
v2: No change
---
arch/arm/dts/Makefile | 4 ++--
doc/board/rockchip/rockchip.rst | 2 ++
2 files changed, 4 insertions(+), 2
On 2024-04-13 20:13, Jonas Karlman wrote:
Imply BOOTSTD_FULL for all RK356x boards to more closely follow RK3588.
Signed-off-by: Jonas Karlman
Looking good to me.
Reviewed-by: Dragan Simic
---
v2: No change
---
arch/arm/mach-rockchip/Kconfig | 1 +
configs/bpi-r2-pro
-by: Dragan Simic
---
v2: Collect r-b tag
---
arch/arm/mach-rockchip/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-rockchip/Kconfig
b/arch/arm/mach-rockchip/Kconfig
index 247b9a3146c2..88bab9c7b3bf 100644
--- a/arch/arm/mach-rockchip/Kconfig
+++ b/arch/arm/mach-rockchip
Hello Jonas,
Please see a couple of comments below.
On 2024-04-13 20:13, Jonas Karlman wrote:
The RK35xx SoCs contain a crypto engine block that can generate random
numbers.
Enable rng node in soc u-boot.dtsi and enable Kconfig options to take
advantage of the random generator.
On 2024-04-13 20:13, Jonas Karlman wrote:
Sort imply statements under ROCKCHIP_RK3568 and ROCKCHIP_RK3588
alphabetically.
Signed-off-by: Jonas Karlman
Looking good to me.
Reviewed-by: Dragan Simic
---
v2: No change
---
arch/arm/mach-rockchip/Kconfig | 24
1 file
On 2024-04-13 20:13, Jonas Karlman wrote:
RK3588 boards do not have any pwm-regulator compatible nodes in DT,
drop
the superfluous REGULATOR_PWM Kconfig options.
Signed-off-by: Jonas Karlman
Looking good to me.
Reviewed-by: Dragan Simic
---
v2: No change
---
configs/evb
as Karlman
Looking good to me.
Reviewed-by: Dragan Simic
---
v2: No change
---
configs/pinetab2-rk3566_defconfig | 1 -
configs/rock5b-rk3588_defconfig | 1 -
configs/turing-rk1-rk3588_defconfig | 1 -
3 files changed, 3 deletions(-)
diff --git a/configs/pinetab2-rk3566_defconfig
b/config
Hello Quentin,
On 2024-04-10 10:47, Quentin Schulz wrote:
On 4/9/24 21:30, Dragan Simic wrote:
On 2024-04-09 18:30, Jonas Karlman wrote:
On 2024-04-09 18:02, Quentin Schulz wrote:
On 4/9/24 17:58, Jonas Karlman wrote:
Agree that implying HS200 does not fully make sense, however it was
part
Hello Quentin,
On 2024-04-10 10:56, Quentin Schulz wrote:
On 4/9/24 21:28, Dragan Simic wrote:
Let's keep in mind that the troublesome DT properties describe the
capabilities of the MMC controller and the board, not the capabilities
of the MMC storage device. As we know, eMMC devices provide
Hello Jonas,
On 2024-04-09 18:30, Jonas Karlman wrote:
On 2024-04-09 18:02, Quentin Schulz wrote:
On 4/9/24 17:58, Jonas Karlman wrote:
On 2024-04-09 17:27, Quentin Schulz wrote:
On 4/8/24 23:06, Jonas Karlman wrote:
eMMC nodes in linux device tree files typically only contain a
mmc-hs400
Hello Quentin,
On 2024-04-09 18:02, Quentin Schulz wrote:
On 4/9/24 17:58, Jonas Karlman wrote:
On 2024-04-09 17:27, Quentin Schulz wrote:
On 4/8/24 23:06, Jonas Karlman wrote:
eMMC nodes in linux device tree files typically only contain a
mmc-hs400
prop to signal support for both HS400 and
Hello Quentin,
On 2024-04-09 17:45, Quentin Schulz wrote:
Hi Jonas,
On 4/8/24 20:14, Jonas Karlman wrote:
The RK3308 SoC contain a crypto engine block that can generate random
numbers.
Add rng node to soc u-boot.dtsi and enable Kconfig options to take
advantage of the random generator.
to out;
}
#endif
Also extract the buffer size to a macro.
Signed-off-by: Ahelenia Ziemiańska
Looking good to me, thanks for the v4.
Reviewed-by: Dragan Simic
---
tools/fit_common.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/fit_common.c b
tion above should use "Linux" instead od "linux", but that's
perhaps not worth sending the v2.
Otherwise, looking good to me. Great job catching this!
Reviewed-by: Dragan Simic
---
drivers/mmc/mmc-uclass.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mmc/
and imply HS200 cap when HS400 cap is signaled
using a mmc-hs400 prop.
Signed-off-by: Jonas Karlman
The description above should use "Linux" instead od "linux", but that's
perhaps not worth sending the v2.
Otherwise, looking good to me. Great job catching this!
Revie
Hello Peng,
Some minor nitpicks... s/Conver to/Convert to/ in the patch subject,
and a couple more below.
On 2024-03-28 06:05, Peng Fan (OSS) wrote:
A few nodes were added to soc and board u-boot.dtsi(lpi2c, usbotg),
those nodes
s/soc/SoC/
could be dropped after upstream linux supports
\
-T kernel -C lz4 -d Image-6.6.15.lz4 \
-b mt8173-elm-hana-6.6.15.dtb outf
when the inputs were unwritable.
Link: https://bugs.debian.org/1063097
Signed-off-by: Ahelenia Ziemiańska
Reviewed-by: Dragan Simic
---
tools/fit_image.c | 2 +-
1 file changed, 1 insertion(+), 1
Hello Ahelenia,
Just checking, have you forgotten about this patch?
On 2024-03-21 21:50, Dragan Simic wrote:
On 2024-03-21 21:37, Ahelenia Ziemiańska wrote:
This is a trivial but significant optimization:
mkimage took >200ms (and 49489 writes (of which 49456 512)),
now it takes 11
On 2024-04-01 01:41, Jonas Karlman wrote:
On 2024-04-01 01:30, Dragan Simic wrote:
On 2024-04-01 01:14, Jonas Karlman wrote:
On 2024-04-01 00:53, Dragan Simic wrote:
Please see my comments below.
On 2024-03-31 22:28, Jonas Karlman wrote:
Sync rk3399-rock-pi-4 related device tree from linux
On 2024-04-01 01:14, Jonas Karlman wrote:
On 2024-04-01 00:53, Dragan Simic wrote:
Please see my comments below.
On 2024-03-31 22:28, Jonas Karlman wrote:
Sync rk3399-rock-pi-4 related device tree from linux v6.8.
Add SPI flash related options to support booting from SPI flash.
Add AHCI=y
.
Reviewed-by: Dragan Simic
---
arch/arm/dts/rk3399-rock-4c-plus-u-boot.dtsi | 12 ++
arch/arm/dts/rk3399-rock-4c-plus.dts | 1 +
arch/arm/dts/rk3399-rock-4se-u-boot.dtsi | 12 ++
arch/arm/dts/rk3399-rock-pi-4.dtsi | 4 +++-
arch/arm/dts/rk3399-rock-pi-4c-u
for serial console.
Remove SPL_TINY_MEMSET=y to use full memset in SPL.
Signed-off-by: Jonas Karlman
Looking good to me.
Reviewed-by: Dragan Simic
---
arch/arm/dts/rk3399-pinephone-pro-u-boot.dtsi | 12 ++
arch/arm/dts/rk3399-pinephone-pro.dts | 147 ++
configs/pinephone
on the board.
Remove SPL_TINY_MEMSET=y to use full memset in SPL.
Signed-off-by: Jonas Karlman
Looking good to me.
Reviewed-by: Dragan Simic
---
arch/arm/dts/rk3399-pinebook-pro.dts | 24 +++-
configs/pinebook-pro-rk3399_defconfig | 6 --
2 files changed, 11 insertions
for all these nice cleanups!
Reviewed-by: Dragan Simic
---
arch/arm/dts/rk3399-rockpro64.dtsi | 98 --
configs/rockpro64-rk3399_defconfig | 7 ++-
2 files changed, 97 insertions(+), 8 deletions(-)
diff --git a/arch/arm/dts/rk3399-rockpro64.dtsi
b/arch/arm/dts/rk3399
On 2024-03-27 09:56, Quentin Schulz wrote:
On 3/27/24 00:35, Jonas Karlman wrote:
The commit 2cc6cde647e2 ("mmc: rockchip_sdhci: Limit number of blocks
read in a single command") introduced a limit of number of blocks to
read to fix a Data End Bit Error on RK3568 and RK3588. This had a side
On 2024-03-24 22:23, Jonas Karlman wrote:
On 2024-03-24 21:58, Dragan Simic wrote:
On 2024-03-24 18:28, Jonas Karlman wrote:
On 2024-03-24 17:52, Dragan Simic wrote:
On 2024-03-22 21:50, Jonas Karlman wrote:
diff --git a/arch/arm/mach-rockchip/rk3308/rk3308.c
b/arch/arm/mach-rockchip/rk3308
On 2024-03-24 18:28, Jonas Karlman wrote:
On 2024-03-24 17:52, Dragan Simic wrote:
Please see my comments below.
On 2024-03-22 21:50, Jonas Karlman wrote:
Add missing boot source id <-> device tree node path mapping for SPI
NOR
flash on PX30, RK3288, RK3308, RK3368 and RV1126.
Sign
-by: Kever Yang
Looking good to me! Thanks for taking the time to implement this
version, as a more robust approach.
Reviewed-by: Dragan Simic
---
v2:
- Only cache boot source id that can be resolved to a node path
- Make use of the new BROM_BOOTSOURCE_UNKNOWN enum value
- Update commit messag
Hello Jonas,
Please see my comments below.
On 2024-03-22 21:50, Jonas Karlman wrote:
Add missing boot source id <-> device tree node path mapping for SPI
NOR
flash on PX30, RK3288, RK3308, RK3368 and RV1126.
Signed-off-by: Jonas Karlman
---
v2:
- New patch
---
-by: Dragan Simic
---
v2:
- New patch
---
arch/arm/include/asm/arch-rockchip/bootrom.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm/include/asm/arch-rockchip/bootrom.h
b/arch/arm/include/asm/arch-rockchip/bootrom.h
index 4276a0f6811a..ecf3b4e7428c 100644
--- a/arch/arm/include/asm/arch
to out;
}
#endif
Also extract the buffer size to a constant.
Signed-off-by: Ahelenia Ziemiańska
Reviewed-by: Dragan Simic
Please, remove my Reviewed-by tag from this version of the patch,
because it no longer applies.
---
On Thu, Mar 21, 2024 at 08:49:52PM +0100, Dragan Simic
> 0)
;
if(size != -1) {
ret = 0;
goto out;
}
#endif
Also lift up the buffer size to a macro.
s/lift up/extract/
s/macro/constant/
Signed-off-by: Ahelenia Ziemiańska
Reviewed-by: Dragan Simic
---
tools/fit_common.c | 5 +++--
> 0)
;
if(size != -1) {
ret = 0;
goto out;
}
#endif
Signed-off-by: Ahelenia Ziemiańska
Looking good to me. With the small nitpick above and
a suggestion below,
Reviewed-by: Dragan Simic
---
tools/fit_common.c | 4 ++--
1 file chan
Ziemiańska
Looking good to me. Opening the file read-only is also good
from the standpoint of using least privilege to perform the
required operation.
With the small nitpicks above,
Reviewed-by: Dragan Simic
---
tools/fit_image.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
On 2024-03-19 16:59, Jonas Karlman wrote:
On 2024-03-19 10:44, Dragan Simic wrote:
On 2024-03-15 18:34, Jonas Karlman wrote:
diff --git a/arch/arm/mach-rockchip/spl.c
b/arch/arm/mach-rockchip/spl.c
index 1586a093fc37..27e996b504e7 100644
--- a/arch/arm/mach-rockchip/spl.c
+++ b/arch/arm/mach
Hello Quentin,
On 2024-03-19 11:19, Quentin Schulz wrote:
On 3/15/24 18:34, Jonas Karlman wrote:
Rockchip BROM write a boot source id at CFG_IRAM_BASE + 0x10, the id
indicate from what storage media TPL/SPL was loaded from.
SPL use this value to determine what device "same-as-spl" represent
Hello Jonas,
Please see a few comments below.
On 2024-03-15 18:34, Jonas Karlman wrote:
Rockchip BROM write a boot source id at CFG_IRAM_BASE + 0x10, the id
indicate from what storage media TPL/SPL was loaded from.
s/write/writes/
s/indicate/indicates/
There are also a few more similar
-by: Dragan Simic
---
Cc: Jaehoon Chung
Cc: Peng Fan
---
V2: - Add sd_select_mode_and_width and mmc_select_mode_and_width stubs
in case MMC_TINY is defined
- Add RB from Jaehoon
---
drivers/mmc/mmc-uclass.c | 13 +
drivers/mmc/mmc.c| 19 +++
2 files
On 2024-03-11 12:37, Dan Carpenter wrote:
On Fri, Mar 08, 2024 at 02:34:04PM +0100, Patrice Chotard wrote:
Move variable declaration at the beginning of the function.
The problem, presumably, is that when declarations are in the middle of
a block then it triggers a GCC warning. "declarations
Hello all,
On 2024-03-11 10:07, Kever Yang wrote:
Hi Quentin,
On 2024/3/9 01:55, Quentin Schulz wrote:
Hi Kever,
On 3/8/24 11:05, Kever Yang wrote:
Hi Quentin,
On 2024/2/21 18:37, Quentin Schulz wrote:
From: Quentin Schulz
Rockchip SoCs have some jtag/sdmmc autoswitching that simply
On 2024-03-05 18:15, Dragan Simic wrote:
On 2024-03-05 17:46, Leon M. Busch-George wrote:
From: "Leon M. Busch-George"
The error message "bc: command not found" is easily missed since the
build continues.
bc is not a part of coreutils or base-devel. POSIX sh can als
Hello Leon,
On 2024-03-04 21:44, Dragan Simic wrote:
On 2024-03-04 21:38, Leon M. Busch-George wrote:
From: "Leon M. Busch-George"
The error message "bc: command not found" is easily missed since the
build continues.
bc is not a part of coreutils or base-devel.
Hello Patrice,
Please, see my comment below.
On 2024-03-08 14:34, Patrice Chotard wrote:
Move variable declaration at the beginning of the function.
Fixes: 163c5f60ebb4 ("fdt_support: add fdt_copy_fixed_partitions
function")
Signed-off-by: Patrice Chotard
---
boot/fdt_support.c | 6
Hello all,
On 2024-03-05 10:36, Christopher Obbard wrote:
On Tue, 2024-03-05 at 10:31 +0100, Jonas Karlman wrote:
On 2024-03-05 03:10, Trevor Woerner wrote:
> Following the pattern of other Rockchip devices, enable the U-Boot
> environment to be stored in MMC. This patch specifically assumes
On 2024-03-04 16:28, Tom Rini wrote:
On Tue, Feb 06, 2024 at 12:00:04PM +0100, Dragan Simic wrote:
Prevent the error messages produced by which(1), such as the one
quoted
below, from being visible in the build outputs.
which: no dtc in (./scripts/dtc)
This makes the build outputs look
Hello Quentin,
On 2024-03-04 12:29, Quentin Schulz wrote:
From: Quentin Schulz
Those two functions had their last user removed in commit f9c68a566c4d
("rockchip: phycore_rk3288: remove phycore_init() function") part of
v2023.01 release, so let's do some cleanup here.
These functions could
. to something like "show DT path for missing device".
Otherwise, looking good to me.
Reviewed-by: Dragan Simic
Signed-off-by: Christopher Obbard
---
arch/arm/mach-rockchip/spl-boot-order.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-rockchi
Hello Christopher,
On 2024-03-02 15:50, Christopher Obbard wrote:
Fix a simple spelling mistake in a comment.
I'd suggest that the main part of the patch subject is adjusted
a bit, e.g. to something like "fix a typo".
Otherwise, looking good to me.
Reviewed-by: Dragan Simic
Hello Christopher,
On 2024-03-02 15:34, Christopher Obbard wrote:
Some variants of the ROCK Pi 4 series contain an SPI flash chip, which
can
be booted from. This patch enables support in U-Boot for building the
image for the SPI flash, support for booting U-Boot from the SPI flash
chip and
ff-by: Leon M. Busch-George
Please, see a nitpick below. Otherwise, the patch is looking
good to me.
Reviewed-by: Dragan Simic
---
Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 7a3209bd9e..41dc4baad2 100644
--- a/Makefile
+++ b/Makefil
On 2024-02-15 15:21, Dragan Simic wrote:
On 2024-02-15 14:13, Tom Rini wrote:
On Wed, Feb 14, 2024 at 04:48:52AM +0100, Dragan Simic wrote:
On 2024-02-06 12:00, Dragan Simic wrote:
> Prevent the error messages produced by which(1), such as the one quoted
> below, from being v
15...@donnerap.manchester.arm.com/T/#u
Signed-off-by: Shantur Rathore
Helped-by: Dragan Simic
Tested-by: Andre Przywara
Reviewed-by: Dragan Simic
Reviewed-by: Marek Vasut
Hello Frieder,
On 2024-02-15 17:56, Frieder Schrempf wrote:
On 15.02.24 17:50, Andre Przywara wrote:
On Thu, 15 Feb 2024 14:35:19 +0100
Frieder Schrempf wrote:
From: Frieder Schrempf
The datasheet can be found here:
https://www.esmt.com.tw/upload/pdf/ESMT/datasheets/EN25Q80B_Ver.E.pdf
On 2024-02-15 14:13, Tom Rini wrote:
On Wed, Feb 14, 2024 at 04:48:52AM +0100, Dragan Simic wrote:
On 2024-02-06 12:00, Dragan Simic wrote:
> Prevent the error messages produced by which(1), such as the one quoted
> below, from being visible in the build outputs.
>
> w
On 2024-02-14 11:01, Shantur Rathore wrote:
On Wed, Feb 14, 2024 at 9:56 AM Shantur Rathore wrote:
On Wed, Feb 14, 2024 at 3:48 AM Dragan Simic
wrote:
> On 2024-02-14 04:18, Dragan Simic wrote:
> > On 2024-02-14 03:04, Andre Przywara wrote:
> >> On Mon, 12 Feb 2024 21:19:13
On 2024-02-06 12:00, Dragan Simic wrote:
Prevent the error messages produced by which(1), such as the one quoted
below, from being visible in the build outputs.
which: no dtc in (./scripts/dtc)
This makes the build outputs look a tiny bit cleaner.
Just checking, is there something
Hello Shantur and Marek,
On 2024-02-14 04:18, Dragan Simic wrote:
On 2024-02-14 03:04, Andre Przywara wrote:
On Mon, 12 Feb 2024 21:19:13 +0100 Marek Vasut wrote:
On 2/12/24 14:41, Shantur Rathore wrote:
> On Mon, Feb 12, 2024 at 1:40 PM Shantur Rathore wrote:
>> On Sat, Feb 10,
Hello Andre,
On 2024-02-14 03:04, Andre Przywara wrote:
On Mon, 12 Feb 2024 21:19:13 +0100 Marek Vasut wrote:
On 2/12/24 14:41, Shantur Rathore wrote:
> On Mon, Feb 12, 2024 at 1:40 PM Shantur Rathore wrote:
>> On Sat, Feb 10, 2024 at 7:13 AM Dragan Simic wrote:
>>> O
On 2024-02-13 00:33, Marek Vasut wrote:
On 2/12/24 22:10, Dragan Simic wrote:
On 2024-02-12 21:19, Marek Vasut wrote:
On 2/12/24 14:41, Shantur Rathore wrote:
On Mon, Feb 12, 2024 at 1:40 PM Shantur Rathore
wrote:
On Sat, Feb 10, 2024 at 7:13 AM Dragan Simic
wrote:
On 2024-02-08 15:17
Hello Marek, Andre and Shantur,
On 2024-02-12 21:19, Marek Vasut wrote:
On 2/12/24 14:41, Shantur Rathore wrote:
On Mon, Feb 12, 2024 at 1:40 PM Shantur Rathore wrote:
On Sat, Feb 10, 2024 at 7:13 AM Dragan Simic
wrote:
On 2024-02-08 15:17, Dragan Simic wrote:
On 2024-02-08 15:10, Shantur
On 2024-02-12 15:21, Peter Robinson wrote:
On Mon, 12 Feb 2024 at 14:16, Dragan Simic wrote:
On 2024-02-12 14:56, Peter Robinson wrote:
> On Fri, 9 Feb 2024 at 18:57, Dragan Simic wrote:
>> On 2024-02-09 19:36, Mark Kettenis wrote:
>> >> Date: Fri, 09 Feb 2024 18:5
Hello Peter,
On 2024-02-12 14:56, Peter Robinson wrote:
On Fri, 9 Feb 2024 at 18:57, Dragan Simic wrote:
On 2024-02-09 19:36, Mark Kettenis wrote:
>> Date: Fri, 09 Feb 2024 18:58:01 +0100
>> From: Dragan Simic
>> Please, see my comments below.
>>
>> On 2024-02-
On 2024-02-12 14:51, Chen-Yu Tsai wrote:
From: Chen-Yu Tsai
The NanoPi R4S has an RK3399 SoC, which has efuse supported by
ROCKCHIP_EFUSE, not ROCKCHIP_OTP.
Signed-off-by: Chen-Yu Tsai
Reviewed-by: Dragan Simic
---
configs/nanopi-r4s-rk3399_defconfig | 1 -
1 file changed, 1 deletion
Hello Peter,
On 2024-02-12 14:41, Peter Robinson wrote:
On Fri, 9 Feb 2024 at 09:50, Quentin Schulz
wrote:
From: Quentin Schulz
Compared to the original misc_init_r from Rockchip mach code,
setup_iodomain() is added and rockchip_setup_macaddr() is not called.
It is assumed adding
Hello Shantur,
On 2024-02-12 14:40, Shantur Rathore wrote:
On Sat, Feb 10, 2024 at 7:13 AM Dragan Simic
wrote:
On 2024-02-08 15:17, Dragan Simic wrote:
> On 2024-02-08 15:10, Shantur Rathore wrote:
>> On Thu, Feb 8, 2024 at 1:44 PM Dragan Simic
>> wrote:
>>> On 2024-
Hello Johan,
On 2024-02-11 15:07, Johan Jonker wrote:
On 2/10/24 19:18, Dragan Simic wrote:
As discussed on the U-Boot mailing list, [1][2] only some Rockchip
SoCs
suffer from a bug in their BROMs that requires a specific format for
their
This not a bug.
SPI images, which was the reason
Hello Tom,
On 2024-02-11 00:41, Tom Rini wrote:
On Sat, Feb 10, 2024 at 07:18:10PM +0100, Dragan Simic wrote:
As discussed on the U-Boot mailing list, [1][2] only some Rockchip
SoCs
suffer from a bug in their BROMs that requires a specific format for
their
SPI images, which was the reason
On 2024-02-10 20:30, Jonas Karlman wrote:
On 2024-02-10 18:18, Dragan Simic wrote:
On 2024-02-08 22:54, Jonas Karlman wrote:
On 2024-02-08 04:53, Dragan Simic wrote:
On 2024-02-07 01:02, Jonas Karlman wrote:
Similar to RK35xx the BootRom in RK3328 can read all data and look
for
idbloader
On 2024-02-10 20:38, Jonas Karlman wrote:
On 2024-02-10 19:31, Dragan Simic wrote:
On 2024-02-07 01:02, Jonas Karlman wrote:
Add Kconfig options to enable support for booting from SPI NOR flash
on
Pine64 Rock64.
The generated bootable u-boot-rockchip-spi.bin that can be written to
0x0 of SPI
664 bytes skipped in 8.516s, speed 163516
B/s
Signed-off-by: Jonas Karlman
Looking good to me. I'm just not sure that we need to support multiple
SPI chip brands, because I can't recall that the Rock64 has been shipped
with different SPI chips, but perhaps better safe than sorry.
Reviewed-by: Dra
reference and to make understanding it easier.
[1]
https://lore.kernel.org/u-boot/c32129ba-db25-4b9d-9a4a-032d88dfb...@kwiboo.se/
[2]
https://lore.kernel.org/u-boot/CACdvmAjfCWicRd=lkkyob7fzo79afkuqky0e1hbb0zyjuoo...@mail.gmail.com/
Signed-off-by: Dragan Simic
---
doc/README.rockchip | 7
Hello Da Xue,
On 2024-02-09 02:57, Da Xue wrote:
On Wed, Feb 7, 2024 at 10:53 PM Dragan Simic
wrote:
On 2024-02-07 01:02, Jonas Karlman wrote:
> Similar to RK35xx the BootRom in RK3328 can read all data and look for
> idbloader at 0x8000, same as on SD and eMMC.
>
> Use the
Hello Jonas,
On 2024-02-08 22:54, Jonas Karlman wrote:
On 2024-02-08 04:53, Dragan Simic wrote:
On 2024-02-07 01:02, Jonas Karlman wrote:
Similar to RK35xx the BootRom in RK3328 can read all data and look
for
idbloader at 0x8000, same as on SD and eMMC.
Use the rksd format and modify
defconfig update series [1] from
Jonas.
The entire series is looking good to me!
Reviewed-by: Dragan Simic
[1]
https://lore.kernel.org/u-boot/20240207000301.3270722-1-jo...@kwiboo.se/
Chen-Yu Tsai (4):
rockchip: rk3328: Read cpuid and generate MAC address from efuse
rockchip: rk3399
1 - 100 of 185 matches
Mail list logo
