Re: [PATCH 1/1] lib: rsa: remove redundant check

2020-08-20 Thread George McCollister
On Thu, Aug 20, 2020 at 1:25 PM Heinrich Schuchardt wrote: > > No need to check tmp is non-zero twice. > > Signed-off-by: Heinrich Schuchardt > --- > lib/rsa/rsa-sign.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/lib/rsa/rsa-sign.c b/lib/rsa/rsa-sign.c > index

Re: [PATCH] lib: rsa: avoid overriding the object name when already specified

2020-05-13 Thread George McCollister
he key name hint. These two string > identifiers are not necessarily equal. > > Signed-off-by: Jan Luebbe > Signed-off-by: Bastian Krause Looks good to me. Reviewed-by: George McCollister > --- > Note: we could also check if keydir starts with "pkcs11:" and append >

Re: [U-Boot] [PATCH 2/6] x86: Remove support for Advantech SOM-6896

2018-08-10 Thread George McCollister
I don't have time to test the generic coreboot support on this board right now but sounds fine to me. Thanks, George McCollister On Fri, Aug 10, 2018 at 4:39 AM, Bin Meng wrote: > Now that we have generic coreboot payload support, remove the > dedicated support for Advantech SO

[U-Boot] [PATCH 2/2] dtoc: Decode val if it's a byte string

2017-03-30 Thread George McCollister
With Python 3.5.2 encode will throw an exception if val is a byte array. Decode it to a string first. This assumes it's utf-8, if it's not valid utf-8 it will throw an exception. Signed-off-by: George McCollister <george.mccollis...@gmail.com> --- tools/dtoc/fdt_util.py | 2 ++ 1 file chan

[U-Boot] [PATCH 1/2] patman: Convert byte arrays to strings

2017-03-30 Thread George McCollister
check data == "" would fail when data was b'' and would cause an infinite memory leaking loop. joins would also fail with an exception below but due to the infinite loop it never made it that far. Signed-off-by: George McCollister <george.mccollis...@gmail.com> --- tools/patman/cros_s

[U-Boot] [PATCH] Kconfig: Don't use RSA_FREESCALE_EXP on IMX

2017-03-16 Thread George McCollister
s. Signed-off-by: George McCollister <george.mccollis...@gmail.com> --- lib/rsa/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/rsa/Kconfig b/lib/rsa/Kconfig index 09ec358242..fde1ac108d 100644 --- a/lib/rsa/Kconfig +++ b/lib/rsa/Kconfig @@ -1,6 +1,

[U-Boot] [PATCH] mkimage: Add support for signing with pkcs11

2017-01-06 Thread George McCollister
() and rsa_engine_get_priv_key() to construct correct key_id strings. Signed-off-by: George McCollister <george.mccollis...@gmail.com> --- doc/uImage.FIT/signature.txt | 143 + include/image.h | 5 +- lib/rsa/rsa-sign.c

Re: [U-Boot] [PATCH v2 5/5] Makefile: preserve output for images that can contain HAB Blocks

2016-11-10 Thread George McCollister
.lib | 3 ++- > scripts/Makefile.spl | 4 +++- > 6 files changed, 17 insertions(+), 5 deletions(-) > Reviewed-by: George McCollister <george.mccollis...@gmail.com> Tested-by: George McCollister <george.mccollis...@gmail.com> ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 4/5] doc: imx6: add section for secure boot with SPL

2016-11-10 Thread George McCollister
On Sun, Nov 6, 2016 at 9:37 AM, Sven Ebenfeld <sven.ebenf...@gmail.com> wrote: > Cc: sba...@denx.de > > Signed-off-by: Sven Ebenfeld <sven.ebenf...@gmail.com> > --- > doc/README.imx6 | 48 > 1 file changed, 48 insert

Re: [U-Boot] [PATCH v2 3/5] tools: mkimage: add firmware-ivt image type for HAB verification

2016-11-10 Thread George McCollister
+++ > 5 files changed, 55 insertions(+), 3 deletions(-) > Reviewed-by: George McCollister <george.mccollis...@gmail.com> Tested-by: George McCollister <george.mccollis...@gmail.com> ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v2 2/5] arm: imx: add HAB authentication of image to SPL boot

2016-11-10 Thread George McCollister
.c | 25 +++ > arch/arm/imx-common/spl_sd.cfg| 10 +++ > arch/arm/include/asm/imx-common/hab.h | 2 + > include/configs/mx6_common.h | 3 + > 5 files changed, 110 insertions(+), 59 deletions(-) > Reviewed-by: George McCollister

Re: [U-Boot] [PATCH v2 1/5] arm: imx: remove bmode , hdmidet and dek commands from SPL

2016-11-10 Thread George McCollister
m/imx-common/Makefile | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) > Reviewed-by: George McCollister <george.mccollis...@gmail.com> Tested-by: George McCollister <george.mccollis...@gmail.com> ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 0/5] sf: Add support for status register protect

2016-10-28 Thread George McCollister
On Mon, Oct 10, 2016 at 1:57 PM, George McCollister <george.mccollis...@gmail.com> wrote: > Many SPI NOR flash devices support status register protection through > one or two status register protection bits. Protection of the status > register is essential in defending the de

[U-Boot] [PATCH v2] tpm: tpm_tis_lpc: Add support for AT97SC3204

2016-10-17 Thread George McCollister
The Atmel AT97SC3204 is also TIS compliant. Modify the tpm_tis_lpc driver to check for the vid/did used by the Atmel AT97SC3204 and report an appropriate description. Signed-off-by: George McCollister <george.mccollis...@gmail.com> --- Changes in v2: - Reorganized didvid check to make i

[U-Boot] [PATCH] tpm: tpm_tis_lpc: Add support for AT97SC3204

2016-10-14 Thread George McCollister
The Atmel AT97SC3204 is also TIS compliant. Modify the tpm_tis_lpc driver to check for the vid/did used by the Atmel AT97SC3204 and report an appropriate description. Signed-off-by: George McCollister <george.mccollis...@gmail.com> --- drivers/tpm/tpm_tis_lpc.

[U-Boot] [PATCH 5/5] sf: Add sr-protect sub-command

2016-10-10 Thread George McCollister
Add an sf sub-command named sr-protect which allows the status register protection method to be changed. Valid settings are software, hardware, power and otp. Signed-off-by: George McCollister <george.mccollis...@gmail.com> --- cmd/sf.c | 28 1 file chang

[U-Boot] [PATCH 4/5] sf: Add status register protect for Winbond

2016-10-10 Thread George McCollister
| --- Not all devices support OTP. Signed-off-by: George McCollister <george.mccollis...@gmail.com> --- drivers/mtd/spi/sf_internal.h | 1 + drivers/mtd/spi/spi_flash.c | 57 +++ 2 files changed, 58 insertions(+) diff

[U-Boot] [PATCH 1/5] sf: Add status register protection mechanism

2016-10-10 Thread George McCollister
until the next power-down. One Time Program - Writes to the status register are permanently blocked. Signed-off-by: George McCollister <george.mccollis...@gmail.com> --- include/spi_flash.h | 17 + 1 file changed, 17 insertions(+) diff

[U-Boot] [PATCH 2/5] sf: Add status register protect for STMICRO, SST

2016-10-10 Thread George McCollister
STMICRO parts such as M25PX64 and SST parts such as SST26VF032B support a single status register protect bit. When set this bit cause writes to the status register to be blocked when the write protect signal is low. Implement sr_protect for these devices. Signed-off-by: George McCollister

[U-Boot] [PATCH 3/5] sf: Use stm_lock/unlock for Spansion and Winbond

2016-10-10 Thread George McCollister
Spansion parts such as S25FL128S and Winbond parts such as W25Q64FV support the block protection mechanism implemented as stm_lock() and stm_unlock(). Use stm_lock() and stm_unlock() for Spansion and Winbond devices. Signed-off-by: George McCollister <george.mccollis...@gmail.com> --- d

[U-Boot] [PATCH 0/5] sf: Add support for status register protect

2016-10-10 Thread George McCollister
to the data stored in flash. This patch series adds status register protect support for STMICRO, SST, Winbond and Spansion devices and also implements an sf sub-command to set the used protection method. George McCollister (5): sf: Add status register protection mechanism sf: Add status register

Re: [U-Boot] sf: proposed status register protect

2016-10-06 Thread George McCollister
On Thu, Oct 6, 2016 at 11:55 AM, Jagan Teki <jagannadh.t...@gmail.com> wrote: > On Thu, Oct 6, 2016 at 9:21 PM, George McCollister > <george.mccollis...@gmail.com> wrote: >> On Thu, Oct 6, 2016 at 10:27 AM, Jagan Teki <jagannadh.t...@gmail.com> wrote: >>>

Re: [U-Boot] sf: proposed status register protect

2016-10-06 Thread George McCollister
On Thu, Oct 6, 2016 at 10:27 AM, Jagan Teki <jagannadh.t...@gmail.com> wrote: > On Thu, Oct 6, 2016 at 8:32 PM, George McCollister > <george.mccollis...@gmail.com> wrote: >> I'm looking into adding a sub-command to sf to protect status >> registers on Winbond

[U-Boot] sf: proposed status register protect

2016-10-06 Thread George McCollister
vendors other than Winbond that use this SRP mechanism or should only SPI_FLASH_CFI_MFR_WINBOND parts use it? For details see "7.1.7 Status Register Protect Bit (SRP1, SRP0)" on page 15 of http://www.winbond.com/resource-files/w25q64cv_revh_052214[2].pdf Cheers, George M

Re: [U-Boot] [PATCH] image-fit: Fix fit_get_node_from_config semantics

2016-09-21 Thread George McCollister
ve been checking for >>> -ENOLINK prior to bac17b78dace ("image-fit: switch ENOLINK to ENOENT") >>> anyway, which would make it right after this patch, but this would be >>> good to get verified by someone who knows this x86 code or is able to >>> test

Re: [U-Boot] [PATCH] i2c: intel_i2c: SMBus driver PCI addition (e.g. BayTrail)

2016-08-05 Thread George McCollister
On Tue, Jun 28, 2016 at 8:44 AM, Stefan Roese wrote: > This patch adds support for the SMBus block read/write functionality. > Other protocols like the SMBus quick command need to get added > if this is needed. > > This patch also removed the SMBus related defines from the Ivybridge

[U-Boot] [PATCH v2] x86: som-db5800-som-6867: fix SERIRQ on reset

2016-07-28 Thread George McCollister
on the development board all lead to the SERIRQ function being disabled (address 0xfed0c560 with value of 0x2003cc80). Signed-off-by: George McCollister <george.mccollis...@gmail.com> Reviewed-by: Bin Meng <bmeng...@gmail.com> --- Changes in v2: - Reword commit message arch/x86/dts/baytrail_so

Re: [U-Boot] [PATCH] x86: som-db5800-som-6867: fix SERIRQ on reset

2016-07-28 Thread George McCollister
On Thu, Jul 28, 2016 at 1:36 AM, Bin Meng <bmeng...@gmail.com> wrote: > On Thu, Jul 28, 2016 at 6:01 AM, George McCollister > <george.mccollis...@gmail.com> wrote: >> Pad configuration for SERIRQ is not set to enable the SERIRQ function >> on soft reset though st

[U-Boot] [PATCH] x86: som-db5800-som-6867: fix SERIRQ on reset

2016-07-27 Thread George McCollister
Pad configuration for SERIRQ is not set to enable the SERIRQ function on soft reset though strangely, it is on initial boot. Signed-off-by: George McCollister <george.mccollis...@gmail.com> --- arch/x86/dts/baytrail_som-db5800-som-6867.dts | 6 ++ 1 file changed, 6 insertions(+) diff

[U-Boot] [PATCH v2] x86: Add Advantech SOM-DB5800/SOM-6867 support

2016-06-21 Thread George McCollister
: - Winbond Super I/O (Must be disabled with jumpers on SOM-DB8500) - USB 3.0 (XHCI) - TPM Signed-off-by: George McCollister <george.mccollis...@gmail.com> Reviewed-by: Simon Glass <s...@chromium.org> --- Changes in v2: - Disable sdio, sdcard, emmc45-ddr50 in FSP DT - Remove define

Re: [U-Boot] [PATCH] x86: Add Advantech SOM-DB5800/SOM-6867 support

2016-06-21 Thread George McCollister
On Thu, Jun 16, 2016 at 10:10 PM, Bin Meng <bmeng...@gmail.com> wrote: > Hi George, > > On Wed, Jun 15, 2016 at 10:51 PM, George McCollister > <george.mccollis...@gmail.com> wrote: >> Add support for Advantech SOM-DB5800 with the SOM-6867 installed. >> This

Re: [U-Boot] [RFC] x86: baytrail: azalia DT configuration mock-up

2016-06-17 Thread George McCollister
On Fri, Jun 17, 2016 at 12:05 AM, Bin Meng <bmeng...@gmail.com> wrote: > Hi George, > > On Wed, Jun 15, 2016 at 1:12 AM, George McCollister > <george.mccollis...@gmail.com> wrote: >> On Mon, Jun 13, 2016 at 9:09 PM, Bin Meng <bmeng...@gmail.com> wrote: >>

[U-Boot] [PATCH] x86: Add Advantech SOM-DB5800/SOM-6867 support

2016-06-15 Thread George McCollister
: - Winbond Super I/O (Must be disabled with jumpers on SOM-DB8500) - USB 3.0 (XHCI) - TPM Signed-off-by: George McCollister <george.mccollis...@gmail.com> --- arch/x86/Kconfig | 4 + arch/x86/dts/Makefile | 3 +- arch/x

Re: [U-Boot] [PATCH 4/4] x86: baytrail: acpi: Hide internal UART per GNVS setting

2016-06-15 Thread George McCollister
On Wed, Jun 15, 2016 at 9:09 AM, Bin Meng <bmeng...@gmail.com> wrote: > Hi George, > > On Wed, Jun 15, 2016 at 9:57 PM, George McCollister > <george.mccollis...@gmail.com> wrote: >> On Wed, Jun 15, 2016 at 3:33 AM, Bin Meng <bmeng...@gmail.com> wrote:

Re: [U-Boot] [PATCH 4/4] x86: baytrail: acpi: Hide internal UART per GNVS setting

2016-06-15 Thread George McCollister
/asm/arch-baytrail/acpi/lpc.asl | 19 --- > 1 file changed, 8 insertions(+), 11 deletions(-) Reviewed-by: George McCollister <george.mccollis...@gmail.com> Tested-by: George McCollister <george.mccollis...@gmail.com> ___ U-Boot mai

Re: [U-Boot] [PATCH 3/4] x86: acpi: Pack global NVS into ACPI table

2016-06-15 Thread George McCollister
| 2 -- > 5 files changed, 31 insertions(+), 2 deletions(-) Reviewed-by: George McCollister <george.mccollis...@gmail.com> Tested-by: George McCollister <george.mccollis...@gmail.com> ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 1/4] x86: baytrail: Introduce ACPI global NVS

2016-06-15 Thread George McCollister
arch-baytrail/acpi/global_nvs.asl > create mode 100644 arch/x86/include/asm/arch-baytrail/global_nvs.h Reviewed-by: George McCollister <george.mccollis...@gmail.com> Tested-by: George McCollister <george.mccollis...@gmail.com> ___ U-Boot

Re: [U-Boot] MinnowMax GPIO for USB3

2016-06-14 Thread George McCollister
On Mon, Jun 13, 2016 at 8:55 PM, Bin Meng wrote: > Hi George, > > On Sun, Jun 12, 2016 at 5:26 PM, Bin Meng wrote: >> On Sun, Jun 12, 2016 at 4:43 PM, Bin Meng wrote: >>> Hi, >>> >>> My testing shows that only pin_usb_host_en1 is

Re: [U-Boot] [RFC] x86: baytrail: azalia DT configuration mock-up

2016-06-14 Thread George McCollister
On Mon, Jun 13, 2016 at 9:09 PM, Bin Meng <bmeng...@gmail.com> wrote: > Hi George, > > On Mon, Jun 13, 2016 at 9:09 PM, George McCollister > <george.mccollis...@gmail.com> wrote: >> On Fri, Jun 10, 2016 at 7:17 PM, Bin Meng <bmeng...@gmail.com> wrote: >>

Re: [U-Boot] x86: acpi: Disabling SoC functions defined in ASL on a per board basis

2016-06-14 Thread George McCollister
On Mon, Jun 13, 2016 at 8:45 PM, Bin Meng <bmeng...@gmail.com> wrote: > Hi George, > > On Tue, Jun 14, 2016 at 12:12 AM, George McCollister > <george.mccollis...@gmail.com> wrote: >> On Fri, Jun 10, 2016 at 7:25 PM, Bin Meng <bmeng...@gmail.com> wrote: &

Re: [U-Boot] x86: acpi: Disabling SoC functions defined in ASL on a per board basis

2016-06-13 Thread George McCollister
On Fri, Jun 10, 2016 at 7:25 PM, Bin Meng <bmeng...@gmail.com> wrote: > Hi George, > > +Simon, Stefan > > On Fri, Jun 10, 2016 at 1:17 AM, George McCollister > <george.mccollis...@gmail.com> wrote: >> Does anyone have any ideas on how we might go about disabl

Re: [U-Boot] [RFC] x86: baytrail: azalia DT configuration mock-up

2016-06-13 Thread George McCollister
On Fri, Jun 10, 2016 at 7:17 PM, Bin Meng <bmeng...@gmail.com> wrote: > Hi George, > > On Fri, Jun 10, 2016 at 4:57 AM, George McCollister > <george.mccollis...@gmail.com> wrote: >> I'm looking for feedback on this mock-up of fsp,azalia-config DT >> before I

Re: [U-Boot] [PATCH 7/8] x86: Probe pinctrl driver in cpu_init_r()

2016-06-10 Thread George McCollister
called just once. > > Move the call to syscon_get_by_driver_data() from ich6_gpio driver > to cpu_init_r(). > > Signed-off-by: Bin Meng <bmeng...@gmail.com> Reviewed-by: George McCollister <george.mccollis...@gmail.com> Tested-by: George McCollister <george.mccollis...@gmail.c

Re: [U-Boot] U-Boot on Minnowboard Max

2016-06-10 Thread George McCollister
On Fri, Jun 10, 2016 at 8:29 AM, vinoth eswaran <evinoth1...@gmail.com> wrote: > On Fri, Jun 10, 2016 at 2:53 PM, George McCollister > <george.mccollis...@gmail.com> wrote: >> On Thu, Jun 9, 2016 at 11:01 PM, Bin Meng <bmeng...@gmail.com> wrote: >>

Re: [U-Boot] U-Boot on Minnowboard Max

2016-06-10 Thread George McCollister
On Thu, Jun 9, 2016 at 11:01 PM, Bin Meng wrote: > Hi, > > +Simon, ML and Stefan. > > On Wed, Jun 8, 2016 at 11:58 PM, vinoth eswaran wrote: >> Hello Bin, >> >> Sorry that I don't know how not to reply without top-posting. I >> don't know which

[U-Boot] [RFC] x86: baytrail: azalia DT configuration mock-up

2016-06-09 Thread George McCollister
sp,dimm-trpt-rcd = <0xb>; fsp,dimm-twr = <0xc>; fsp,dimm-twtr = <6>; fsp,dimm-trrd = <6>; fsp,dimm-trtp = <6>; fsp,dimm-tfaw = <0x14>; }; }; Thanks, George McCollister ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] x86: acpi: Disabling SoC functions defined in ASL on a per board basis

2016-06-09 Thread George McCollister
.dts if the board uses them. I need to disable the internal UART definition for the baytrail board I'm adding since if it's included the off chip UART gets killed when Linux does it's acpi_bus_scan. Regards, George McCollister ___ U-Boot mailing list U

[U-Boot] [PATCH] x86: acpi: Fix madt lapic generation

2016-06-07 Thread George McCollister
An accumulated length was incorrectly added to current each pass through the loop. On system with more than 2 cores this caused a corrupt MADT to be generated. Signed-off-by: George McCollister <george.mccollis...@gmail.com> --- arch/x86/lib/acpi_table.c | 12 ++-- 1 file chan

Re: [U-Boot] [PATCH] dm: scsi: if_typename should be scsi

2016-06-02 Thread George McCollister
I was having this problem on the Minnowboard Max with the defconfig and this fixes it. Tested-by: George McCollister <george.mccollis...@gmail.com> Thanks, George On Wed, Jun 1, 2016 at 8:11 AM, Ed Swarthout <ed.swarth...@nxp.com> wrote: > Fixes: > > => ext2ls scsi 0:1

[U-Boot] Azalia verb table from DT with Baytrail FSP

2016-05-20 Thread George McCollister
CAR." Is it safe to move Azalia verb tables into DT for Baytrail FSP? Regards, George McCollister ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

[U-Boot] [PATCH v6] x86: Add support for Advantech SOM-6896

2015-10-21 Thread George McCollister
a concern at the moment. USB doesn't work since the xHCI driver appears to be broken. Signed-off-by: George McCollister <george.mccollis...@gmail.com> Reviewed-by: Bin Meng <bmeng...@gmail.com> Reviewed-by: Tom Rini <tr...@konsulko.com> Acked-by: Simon Glass <s...@chromium.or

[U-Boot] [PATCH v5] x86: Add support for Advantech SOM-6896

2015-10-21 Thread George McCollister
a concern at the moment. USB doesn't work since the xHCI driver appears to be broken. Signed-off-by: George McCollister <george.mccollis...@gmail.com> Reviewed-by: Bin Meng <bmeng...@gmail.com> Acked-by: Simon Glass <s...@chromium.org> --- Changes for V2: Changed pci's compatible

[U-Boot] [PATCH v4] x86: Added support for Advantech SOM-6896

2015-10-20 Thread George McCollister
a concern at the moment. USB doesn't work since the xHCI driver appears to be broken. Signed-off-by: George McCollister <george.mccollis...@gmail.com> --- Changes for V2: Changed pci's compatible string to "pci-x86" Changed I/O from base of 0x1000 to base of 0x1900 Changed spi-

Re: [U-Boot] [PATCH v3] x86: Added support for Advantech SOM-6896

2015-10-20 Thread George McCollister
On Mon, Oct 19, 2015 at 9:02 PM, Bin Meng <bmeng...@gmail.com> wrote: > Hi George, > > On Tue, Oct 20, 2015 at 1:46 AM, George McCollister > <george.mccollis...@gmail.com> wrote: >> Advantech SOM-6896 is a Broadwell U based COM Express Compact Module >

Re: [U-Boot] [PATCH 3/3] x86: Added support for Advantech SOM-6896

2015-10-19 Thread George McCollister
Simon, On Thu, Oct 15, 2015 at 8:25 AM, Simon Glass <s...@google.com> wrote: > Hi Bin, > > On Monday, 12 October 2015, Bin Meng <bmeng...@gmail.com> wrote: >> >> Hi George, >> >> On Tue, Oct 13, 2015 at 10:52 AM, George McCollister >> <ge

[U-Boot] [PATCH v3] x86: Added support for Advantech SOM-6896

2015-10-19 Thread George McCollister
a concern at the moment. USB doesn't work since the xHCI driver appears to be broken. Signed-off-by: George McCollister <george.mccollis...@gmail.com> --- Changes for V2: Changed pci's compatible string to "pci-x86" Changed I/O from base of 0x1000 to base of 0x1900 Changed spi-

Re: [U-Boot] [PATCH 3/3] x86: Added support for Advantech SOM-6896

2015-10-12 Thread George McCollister
On Fri, Oct 9, 2015 at 10:31 PM, Bin Meng <bmeng...@gmail.com> wrote: > Hi George, > > On Sat, Oct 10, 2015 at 5:54 AM, George McCollister > <george.mccollis...@gmail.com> wrote: >> Advantech SOM-6896 is a Broadwell U based COM Express Compact Module >

Re: [U-Boot] [PATCH 3/3] x86: Added support for Advantech SOM-6896

2015-10-12 Thread George McCollister
On Mon, Oct 12, 2015 at 8:34 AM, George McCollister <george.mccollis...@gmail.com> wrote: > On Fri, Oct 9, 2015 at 10:31 PM, Bin Meng <bmeng...@gmail.com> wrote: >> Hi George, >> >> On Sat, Oct 10, 2015 at 5:54 AM, George McCollister >> <george.mccollis..

[U-Boot] [PATCH v2 1/3] x86: pci: Add PCI IDs for Wildcat Point

2015-10-12 Thread George McCollister
Add Wildcat Point AHCI and LPC PCI IDs which are present on Broadwell U based (and possibly other) boards. Signed-off-by: George McCollister <george.mccollis...@gmail.com> Reviewed-by: Bin Meng <bmeng...@gmail.com> --- Changes for V2: Add simple sentence as the commit message

[U-Boot] [PATCH v2 2/3] x86: spi: Add support for Wildcat Point

2015-10-12 Thread George McCollister
Add the Wildcat Point ID so Broadwell U based boards can use SPI. Signed-off-by: George McCollister <george.mccollis...@gmail.com> Reviewed-by: Bin Meng <bmeng...@gmail.com> --- Changes for V2: Add Reviewed-by: Bin Meng drivers/spi/ich.c | 3 ++- 1 file changed, 2 insertions(+)

[U-Boot] [PATCH v2 3/3] x86: Added support for Advantech SOM-6896

2015-10-12 Thread George McCollister
a concern at the moment. USB doesn't work since the xHCI driver appears to be broken. Signed-off-by: George McCollister <george.mccollis...@gmail.com> --- Changes for V2: Changed pci's compatible string to "pci-x86" Changed I/O from base of 0x1000 to base of 0x1900 Changed spi-flash m

Re: [U-Boot] [PATCH 3/3] x86: Added support for Advantech SOM-6896

2015-10-12 Thread George McCollister
On Mon, Oct 12, 2015 at 7:48 PM, Bin Meng <bmeng...@gmail.com> wrote: > Hi George, > > On Tue, Oct 13, 2015 at 2:30 AM, George McCollister > <george.mccollis...@gmail.com> wrote: >> On Mon, Oct 12, 2015 at 8:34 AM, George McCollister >> <george.mccollis...@gm

[U-Boot] [PATCH 3/3] x86: Added support for Advantech SOM-6896

2015-10-09 Thread George McCollister
a concern at the moment. USB doesn't work since the xHCI driver appears to be broken. Signed-off-by: George McCollister <george.mccollis...@gmail.com> --- arch/x86/dts/Makefile | 3 ++- arch/x86/dts/som-6896.dts | 43 +++ include/configs/som-6896.

[U-Boot] [PATCH 2/3] x86: spi: Add support for Wildcat Point

2015-10-09 Thread George McCollister
Add the Wildcat Point ID so Broadwell U based boards can use SPI. Signed-off-by: George McCollister <george.mccollis...@gmail.com> --- drivers/spi/ich.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/ich.c b/drivers/spi/ich.c index 2e388e7..be4c0a3

[U-Boot] [PATCH 1/3] x86: pci: Add PCI IDs for Wildcat Point

2015-10-09 Thread George McCollister
Signed-off-by: George McCollister <george.mccollis...@gmail.com> --- include/pci_ids.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/pci_ids.h b/include/pci_ids.h index 49f7d7d..17a01a0 100644 --- a/include/pci_ids.h +++ b/include/pci_ids.h @@ -3022,6 +3022,8 @@ #

Re: [U-Boot] [PATCH 1/2] x86: gpio: Make x86-pinctrl subnode of ich6-gpio

2015-10-08 Thread George McCollister
On Thu, Oct 8, 2015 at 12:43 PM, Simon Glass <s...@chromium.org> wrote: > Hi George, > > On 7 October 2015 at 16:29, George McCollister > <george.mccollis...@gmail.com> wrote: >> Instead of having x86-pinctrl work separately from ich6-gpio have it >> wor

[U-Boot] [PATCH 2/2] x86: gpio: Add use-lvl-write-cache to fix baytrail

2015-10-07 Thread George McCollister
Max was unusable since USB_HOST_EN0 was set high then immediately set low when USB_HOST_EN1 was written. Signed-off-by: George McCollister <george.mccollis...@gmail.com> --- arch/x86/dts/minnowmax.dts| 6 ++ doc/device-tree-bindings/gpio/intel,ich6-gpio.tx

[U-Boot] [PATCH 1/2] x86: gpio: Make x86-pinctrl subnode of ich6-gpio

2015-10-07 Thread George McCollister
Instead of having x86-pinctrl work separately from ich6-gpio have it work underneath ich6-gpio. This removes redundant configuration and will allow the addition of shared bank settings in future commits. Signed-off-by: George McCollister <george.mccollis...@gmail.com> --- arch/x