On Mon, 7 Aug 2023 at 18:17, Eddie James wrote:
>
> From: Ilias Apalodimas
>
> commit ("")
> replaced the forced and sandbox tpm2 initialization running 'tpm2
> autostart' instead of the startup tpm sequence. The difference is that
> the new function hand
Hi Eddie,
On Mon, 7 Aug 2023 at 18:17, Eddie James wrote:
>
> From: Ilias Apalodimas
We need a commit message for that. Something along the lines of
efi_tcg2_get_active_pcr_banks() doesnt immediately call the
EFI_ENTRY() wrappers once it enters the function. Move the call a few
lines
Hi Eddie,
On Mon, 7 Aug 2023 at 18:18, Eddie James wrote:
>
> From: Ilias Apalodimas
>
> Signed-off-by: Ilias Apalodimas
> ---
> lib/tpm-v2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/tpm-v2.c b/lib/tpm-v2.c
> index d22e21985b.
Hi,
On Mon, 7 Aug 2023 at 17:43, Eddie James wrote:
>
>
> On 8/4/23 13:10, Sean Edmond wrote:
> > On 2023-03-08 1:25 p.m., Eddie James wrote:
> >> Add a configuration option to measure the boot through the bootm
> >> function. Add the measurement state to the booti and bootz paths
> >> as well.
https://gitlab.arm.com/arm-reference-solutions/arm-reference-solutions-test-report/-/tree/master/embedded-a/corstone1000/CORSTONE1000-2023.06/acs_results_fpga.zip
>
> Signed-off-by: Abdellatif El Khlifi
> Tested-by: Gowtham Suresh Kumar
> Reviewed-by: Simon Glass
> Cc: Tom Rini
On Wed, Aug 02, 2023 at 08:06:52PM +0600, Maxim Uvarov wrote:
> Signed-off-by: Maxim Uvarov
> ---
> lib/lwip/Makefile | 1 +
> lib/lwip/apps/ping/Makefile| 11 ++
> lib/lwip/apps/ping/lwip_ping.c | 37 ++
> lib/lwip/apps/ping/lwip_ping.h
Hi Maxim
On Wed, Aug 02, 2023 at 08:06:56PM +0600, Maxim Uvarov wrote:
> Signed-off-by: Maxim Uvarov
> ---
> lib/lwip/Makefile | 2 +
> +
> +#include "apps/dns/lwip-dns.h"
> +#include "apps/ping/lwip_ping.h"
> +#include "ulwip.h"
> +
> +extern int uboot_lwip_init(void);
> +extern int
On Wed, Aug 02, 2023 at 08:06:51PM +0600, Maxim Uvarov wrote:
> Signed-off-by: Maxim Uvarov
> ---
> lib/lwip/Makefile | 1 +
> lib/lwip/apps/http/Makefile| 13
> lib/lwip/apps/http/lwip-wget.c | 130 +
> 3 files changed, 144 insertions(+)
On Wed, Aug 02, 2023 at 08:06:50PM +0600, Maxim Uvarov wrote:
> Signed-off-by: Maxim Uvarov
> ---
> lib/lwip/Makefile | 1 +
> lib/lwip/apps/tftp/Makefile| 16 +
> lib/lwip/apps/tftp/lwip-tftp.c | 124 +
> 3 files changed, 141 insertions(+)
Hi Maxim,
The split looks a lot easier to review!
On Wed, Aug 02, 2023 at 08:06:49PM +0600, Maxim Uvarov wrote:
> Signed-off-by: Maxim Uvarov
> ---
> lib/lwip/Makefile | 1 +
> lib/lwip/apps/dhcp/lwip-dhcp.c | 53 ++
> 2 files changed, 54
Hi Maxim
On Wed, 2 Aug 2023 at 17:09, Maxim Uvarov wrote:
>
> Signed-off-by: Maxim Uvarov
You need to try and be a bit more formal. This is past the RFC stage,
you need commit messages that make sense.
Thanks
/Ilias
> ---
> .gitignore | 9 +
> 1 file changed, 9 insertions(+)
>
>
Hi Simon,
On Wed, 2 Aug 2023 at 16:55, Simon Glass wrote:
>
> Hi Ilias,
>
> On Wed, 2 Aug 2023 at 07:48, Ilias Apalodimas
> wrote:
> >
> > Hi Simon,
> >
> > On Wed, 2 Aug 2023 at 16:44, Simon Glass wrote:
> > >
> > > Hi Ilias,
Hi Simon,
On Wed, 2 Aug 2023 at 16:44, Simon Glass wrote:
>
> Hi Ilias,
>
> On Wed, 2 Aug 2023 at 07:43, Ilias Apalodimas
> wrote:
> >
> > On Wed, 2 Aug 2023 at 16:42, Simon Glass wrote:
> > >
> > > Hi Ilias,
> > >
> >
On Wed, 2 Aug 2023 at 16:42, Simon Glass wrote:
>
> Hi Ilias,
>
> On Wed, 2 Aug 2023 at 07:38, Ilias Apalodimas
> wrote:
> >
> > Hi Simon,
> >
> > On Wed, 2 Aug 2023 at 16:34, Simon Glass wrote:
> > >
> > > Hi Ilias,
> > >
Hi Simon,
On Wed, 2 Aug 2023 at 16:34, Simon Glass wrote:
>
> Hi Ilias,
>
> On Wed, 2 Aug 2023 at 07:27, Ilias Apalodimas
> wrote:
> >
> > Hi Simon,
> >
> >
> > On Wed, 2 Aug 2023 at 16:09, Simon Glass wrote:
> > >
> > > Hi I
Hi Simon,
On Wed, 2 Aug 2023 at 16:09, Simon Glass wrote:
>
> Hi Ilias,
>
> On Wed, 2 Aug 2023 at 07:02, Ilias Apalodimas
> wrote:
> >
> > Hi Simon,
> >
> > On Wed, 2 Aug 2023 at 15:52, Simon Glass wrote:
> > >
> > > Hi Ilias,
Hi Simon,
On Wed, 2 Aug 2023 at 15:52, Simon Glass wrote:
>
> Hi Ilias,
>
> On Wed, 2 Aug 2023 at 00:52, Ilias Apalodimas
> wrote:
> >
> > On Tue, 1 Aug 2023 at 19:19, Tom Rini wrote:
> > >
> > > On Tue, Aug 01, 2023 at 05:10:08PM +0100
On Tue, 1 Aug 2023 at 19:19, Tom Rini wrote:
>
> On Tue, Aug 01, 2023 at 05:10:08PM +0100, Abdellatif El Khlifi wrote:
> > Hi guys,
> >
> > On Tue, Aug 01, 2023 at 11:00:57AM -0400, Tom Rini wrote:
> > > > > > > > > > ...
> > > > > > > > > > Changelog:
> > > > > > > > > > ===
> > > >
Hi Abdellatif
On Mon, 31 Jul 2023 at 14:46, Abdellatif El Khlifi
wrote:
>
> Hi Ilias,
>
> On Mon, Jul 31, 2023 at 12:38:16PM +0300, Ilias Apalodimas wrote:
> > > > > > ...
> > > > > > Changelog:
> > > > > > ===
&
tial matching for commands so people can
> > type "re" instead of "read". But here reading two characters doesn't
> > seem correct.
> >
> > cmd/nvedit_efi.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> Reviewed-by: Simon Glass
Reviewed-by: Ilias Apalodimas
digest_list->digests[digest_list->count].hash_alg = hash_alg;
> memcpy(_list->digests[digest_list->count].digest, hash,
> --
> 2.40.1
>
I am fine with the change. It's worth noting that this will only
happen if we ever add an invalid algorithm to hash_algo_list[]. But
the algorithms are described in the spec, so we should never end up
in that case regardless. Can you pick this up via the EFI tree?
Reviewed-by: Ilias Apalodimas
>
> So move the guid check into efi_capsule_update_firmware().
>
> Fixed: commit a6aafce494ab ("efi_loader: use efi_update_capsule_firmware()
> for capsule on disk")
I think we can skip the fixes tag here, since noone was really using the feature
Other th
Hi Heinrich,
On Sun, 30 Jul 2023 at 13:51, Heinrich Schuchardt
wrote:
>
> On 32bit systems (pages << EFI_PAGE_SHIFT) may lead to an overflow which
> does not occur in 64bit arithmetics.
You mean this cant happen in 32 bits but can in 64bit right?
>
> An overflow of (pages << EFI_PAGE_SHIFT) on
HI Tom,
On Fri, Jul 28, 2023 at 09:54:15AM -0400, Tom Rini wrote:
> On Fri, Jul 28, 2023 at 02:00:25PM +0300, Ilias Apalodimas wrote:
> > Hi Tom
> >
> > On Thu, 27 Jul 2023 at 19:43, Tom Rini wrote:
> > >
> > > On Thu, Jul 27, 2023 at 05:07
Hi Heinrich
On Sun, 30 Jul 2023 at 12:25, Heinrich Schuchardt
wrote:
>
> If the hard coded array hash_algo_list[] contains an entry for an
> unsupported algorithm, we should not leak resources new_efi and regs.
>
> We should still extend the log with the digests for the supported
> algorithms.
free(newlist);
> + return EFI_OUT_OF_RESOURCES;
> case EFI_CARVE_OVERLAPS_NONRAM:
> /*
> * The user requested to only have RAM
> overlaps,
> --
> 2.40.1
>
Reviewed-by: Ilias Apalodimas
ct
> file_system *fs,
>
> /* +2 is for null and '/' */
> fh = calloc(1, sizeof(*fh) + plen + (flen * MAX_UTF8_PER_UTF16) + 2);
> + if (!fh)
> + return NULL;
>
> fh->open_mode = open_mode;
> fh->base = efi_file_handle_protocol;
> --
> 2.40.1
>
Reviewed-by: Ilias Apalodimas
e_file_system(struct blk_desc *desc, int part,
> + struct efi_device_path *dp,
> + struct efi_simple_file_system_protocol **fsp)
> {
> struct file_system *fs;
>
> fs = calloc(1, sizeof(*fs));
> + if (!f
ages,
> * The payload wanted to have RAM overlaps, but we overlapped
> * with an unallocated region. Error out.
> */
> + free(newlist);
> return EFI_NO_MAPPING;
> }
>
> --
> 2.40.1
>
Reviewed-by: Ilias Apalodimas
ysical_start = start;
> newlist->desc.virtual_start = start;
> --
> 2.40.1
>
Reviewed-by: Ilias Apalodimas
ist_package_lists(void)
> if (ret != EFI_SUCCESS) {
> efi_st_error("list_package_lists returned %u\n",
> (unsigned int)ret);
> - ret = EFI_ST_FAILURE;
> goto out;
> }
> ret = boottime->free_pool(handles);
> if (ret != EFI_SUCCESS) {
> efi_st_error("FreePool failed\n");
> - ret = EFI_ST_FAILURE;
> goto out;
> }
>
> --
> 2.40.1
>
Reviewed-by: Ilias Apalodimas
Hi Heinrich
On Sun, Jul 30, 2023 at 09:34:53AM +0200, Heinrich Schuchardt wrote:
> When passing a pointer to a size_t variable to a function writing an u64
> value to the address a buffer overrun occurs on 32bit systems.
>
> Fixes: 163a0d7e2cbd ("efi_loader: add PE/COFF image measurement")
>
Hi Julia,
Apologies for the late response, I was on vacation.
On Mon, 3 Jul 2023 at 16:03, Julia Daxenberger
wrote:
>
> Add TPM2_GetTestResult command support and change the command file and the
> help accordingly. Add Python tests and sandbox driver functionality.
>
> The TPM2_GetTestResult
Hi Alper,
On Sat, 8 Jul 2023 at 18:21, Alper Nebi Yasak wrote:
>
> Debian's arm64 UEFI Secure Boot shim makes the EFI variable store run
> out of space while mirroring its MOK database to variables. This can be
> observed in QEMU like so:
>
> $ tools/buildman/buildman -o build/qemu_arm64
the data and updates the MM shared
> > buffer with the response data.
> >
> > The response data is copied back to the communication buffer and
> > consumed by the EFI subsystem.
> >
> > MM communication protocol supports FF-A 64-bit direct messaging.
> >
>
(buf, dev->parent);
> + dp->dp.type = DEVICE_PATH_TYPE_HARDWARE_DEVICE;
> + dp->dp.sub_type = DEVICE_PATH_SUB_TYPE_VENDOR;
> + dp->dp.length = sizeof(*dp);
> + memcpy(>guid, _u_boot_guid,
> +sizeof(efi_guid_t));
> + dp->uclass_id = (UCLASS_BLK & 0x) |
> + (desc->uclass_id << 16);
> + dp->dev_number = desc->devnum;
> +
> + return [1];
> }
> + }
> #if defined(CONFIG_MMC)
> case UCLASS_MMC: {
> struct efi_device_path_sd_mmc_path *sddp =
> --
> 2.40.1
>
In any case the patch LGTM
Reviewed-by: Ilias Apalodimas
Hi Julius
On Wed, 26 Jul 2023 at 23:16, Julius Werner wrote:
>
> > diff --git a/include/bloblist.h b/include/bloblist.h
> > index 7ea72c6bd46..bad5fbbb889 100644
> > --- a/include/bloblist.h
> > +++ b/include/bloblist.h
>
> nit: I would suggest also updating the documentation at the top of
>
Hi Maxim,
This is too much for a single patch review. Can you pleas split it in
something that's easier to review and comment.
For example,
#1 add the lwip library only
#2-#5 add ping, wget, tcp and ping
Some random comments below as well.
On Fri, Jul 14, 2023 at 08:19:57PM +0600, Maxim
On Fri, Jul 14, 2023 at 08:20:00PM +0600, Maxim Uvarov wrote:
> provide hostname to client and allow lwip to resolve it.
>
> Signed-off-by: Maxim Uvarov
> ---
> lib/lwip/apps/http/lwip-wget.c | 59 ++
> 1 file changed, 53 insertions(+), 6 deletions(-)
>
> diff
Tom, Simon
are you ok with submodules on this one?
thanks
/Ilias
On Fri, Jul 14, 2023 at 08:19:56PM +0600, Maxim Uvarov wrote:
> This commit adds the lwip library as a git submodule. I think
> there has to be advantages to compile lwip inside U-boot,
> i.e. use the same compiler and flags as
Hi Maxim,
On Fri, Jul 14, 2023 at 08:19:58PM +0600, Maxim Uvarov wrote:
> Just add inital doc.
>
> Signed-off-by: Maxim Uvarov
> ---
> doc/develop/index.rst| 1 +
> doc/develop/net_lwip.rst | 59
> 2 files changed, 60 insertions(+)
> create mode
Hi Maxim,
On Fri, Jul 14, 2023 at 08:19:55PM +0600, Maxim Uvarov wrote:
> changelog:
> v4: - tested with tests/py/ did some minor fixes (out of tree
> build, variables set after downloads).
> - accounted review comments for documentation.
> - implemented
Hi Abdellatif,
[...]
> +}
> +
> +/**
> + * get_mm_comms() - detect the available MM transport
> + *
> + * Make sure the FF-A bus is probed successfully
> + * which means FF-A communication with secure world works and ready
> + * for use.
> + *
> + * If FF-A bus is not ready, use OPTEE comms.
>
tham respond on the mailing list
Thanks
/Ilias
> Reviewed-by: Simon Glass
> Cc: Tom Rini
> Cc: Ilias Apalodimas
> Cc: Jens Wiklander
>
> ---
>
> Changelog:
> ===
>
> v16:
>
> * lib/efi_loader/Kconfig:
>rather than automa
arm-ffa-uclass.c).
> Arm specific methods are implemented in the Arm driver (arm-ffa.c).
>
> For more details please refer to the driver documentation [2].
>
> [1]: https://developer.arm.com/documentation/den0077/latest/
> [2]: doc/arch/arm64.ffa.rst
>
> Signe
On Thu, 27 Jul 2023 at 12:24, Dan Carpenter wrote:
>
> On Thu, Jul 27, 2023 at 11:28:52AM +0300, Ilias Apalodimas wrote:
> > Hi Dan, Heinrich
> >
> > On Thu, 27 Jul 2023 at 11:25, Heinrich Schuchardt
> > wrote:
> > >
>
Hi Dan, Heinrich
On Thu, 27 Jul 2023 at 11:25, Heinrich Schuchardt wrote:
>
> On 7/27/23 09:16, Dan Carpenter wrote:
> > The efi_parse_pkcs7_header() function returns NULL on error so the check
> > for IS_ERR() should be changed to a NULL check.
> >
> > Signed-off-by: Dan Carpenter
> > ---
> >
ID_PARAMETER;
>
> + loaded_image_info = handler->protocol_interface;
> loaded_image_info->load_options = load_options;
> loaded_image_info->load_options_size = load_options_size;
>
> --
> 2.39.2
>
Reviewed-by: Ilias Apalodimas
Hi Dan,
[...]
> @@ -313,7 +313,7 @@ static int cmp_pe_section(const void *arg1, const void
> *arg2)
> *
> * Return: valid pointer to a image, return NULL if allocation fails.
> */
> -void *efi_prepare_aligned_image(void *efi, u64 *efi_size)
> +void *efi_prepare_aligned_image(void *efi,
Hi all
[...]
> > >
> >
> > Hello Sugosh,
> >
> > fwu_empty_capsule() detects an empty capsule as one with a GUID
> > fwu_guid_os_request_fw_revert or fwu_guid_os_request_fw_accept.
> >
> > I am not aware of a requirement in the UEFI specification to treat
> > capsules read from file in a
Hi Heinirch,
On Tue, 18 Jul 2023 at 18:41, Heinrich Schuchardt wrote:
>
> On 13.07.23 16:35, Michal Simek wrote:
> > Empty capsule are also allowed to be process. Without it updated images
> > can't change their Image Acceptance state from no to yes.
>
> Is there any documentation describing
Hi Dan
On Wed, 26 Jul 2023 at 09:55, Dan Carpenter wrote:
>
> It's pretty unlikely that anyone is going to be using EFI authentication
> on a 32bit system. However, if you did, the efi_prepare_aligned_image()
> function would write 8 bytes of data to the _size variable and it
> can only hold 4
/arm/dts/nuvoton-npcm845-evb.dts
> @@ -354,4 +354,4 @@
> _pins
> _pins
> >;
> -};
> \ No newline at end of file
> +};
> --
> 2.34.1
>
Reviewed-by: Ilias Apalodimas
> + TPM_SUCCESS) {
> pr_err("\tcould not write index 0\n");
> }
> tpm_nv_write_value_lock(dev, INDEX0);
> --
> 2.39.2
>
Reviewed-by: Ilias Apalodimas
| 12 ++--
> >> .../test_capsule_firmware_signed_raw.py | 12 ++--
> >> 5 files changed, 24 insertions(+), 24 deletions(-)
> >
> > Reviewed-by: Simon Glass
> >
> > Would it make sense to reduce the code duplication a little?
>
> Thank you for reviewing.
>
> Fixed 482ef90aeb4c ("test: efi_capsule: refactor efi_capsule test")
> started the de-duplication effort.
>
> Best regards
>
> Heinrich
Reviewed-by: Ilias Apalodimas
is efi_delete_image().
But that function needs a bigger rework anyway, so we can clean it up in
the future
Signed-off-by: Ilias Apalodimas
---
Changes since v1:
- only report errors internally in efi_delete_handle()
cmd/bootefi.c | 21 ++---
include/efi_loader.h
On Mon, 3 Jul 2023 at 12:55, Abdellatif El Khlifi
wrote:
>
> Hi Ilias,
>
> On Tue, Jun 20, 2023 at 05:25:51PM +0300, Ilias Apalodimas wrote:
> > [...]
> > > +int do_ffa_ping(struct cmd_tbl *cmdtp, int flag, int argc, char *const
> > > argv[])
> > >
Hi Maxim,
On Thu, Jun 29, 2023 at 06:34:30PM +0600, Maxim Uvarov wrote:
> This commit adds lwip library for the U-boot network
> stack. Supported commands: ping, tftp, dhcp and wget.
>
> Signed-off-by: Maxim Uvarov
> ---
> .gitignore| 9 +
> cmd/net.c
Hi Maxim,
On Thu, Jun 29, 2023 at 06:34:29PM +0600, Maxim Uvarov wrote:
> Just add inital README.lwip doc.
We'll need a more accurate description for this. The first paragraph of
the documentation you are adding would do
>
> Signed-off-by: Maxim Uvarov
> ---
> doc/README.lwip | 90
printf(" %pUs\n", guid[j]);
> }
> + efi_free_pool(guid);
> }
>
> efi_free_pool(handles);
> --
> 2.34.1
>
Reviewed-by: Ilias Apalodimas
[...]
> > > > > The order of operation is supposed to be:
> > > > >
> > > > > 1. Various projects used to build their ouputs (e.g. TF-A)
> > > > > 2. Makefile used to build U-Boot:
> > > > > 2a. The build produces a set of files which serve as inputs to binman
> > > > > (INPUTS-y)
> > > > > 2b.
Hi Simon,
On Mon, 26 Jun 2023 at 14:19, Simon Glass wrote:
>
> Hi Ilias,
>
> On Mon, 26 Jun 2023 at 10:53, Ilias Apalodimas
> wrote:
> >
> > Hi Simon,
> >
> > [...]
> >
> > > > > > > > +
> > > > > >
is efi_delete_image().
But that function needs a bigger rework anyway, so we can clean it up in
the future
Signed-off-by: Ilias Apalodimas
---
Heinrich this needs to be applied on top of
https://lore.kernel.org/u-boot/20230620061932.113292-1-ilias.apalodi...@linaro.org/
cmd/bootefi.c
Hi Simon,
[...]
> > > > > > +
> > > > > > +gen_capsule_signature_file signature.$$.dts > /dev/null 2>&1
> > > > > > +$CPP $dtc_cpp_flags -x assembler-with-cpp -o signature.$$.tmp
> > > > > > signature.$$.dts > /dev/null 2>&1
> > > > > > +dtc -@ -O dtb -o signature.$$.dtbo signature.$$.tmp >
ed-version property specified in U-Boot's control
> +device tree can be changed by U-Boot fdt command.
> +Secure systems should not enable this command.
> +
Other than than
Reviewed-by: Ilias Apalodimas
> To insert the lowest supported version into a dtb
>
> .. code-block:: console
> --
> 2.34.1
>
cation buffer and
> consumed by the EFI subsystem.
>
> MM communication protocol supports FF-A 64-bit direct messaging.
>
> Signed-off-by: Abdellatif El Khlifi
> Signed-off-by: Gowtham Suresh Kumar
> Cc: Tom Rini
> Cc: Simon Glass
> Cc: Ilias Apalodimas
> Cc: Jens Wiklande
[...]
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 43603522fd..0d960731cf 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -269,7 +269,9 @@ F: configs/cortina_presidio-asic-pnand_defconfig
> ARM FF-A
> M: Abdellatif El Khlifi
> S: Maintained
> +F: cmd/armffa.c
> F:
ias
>
> Signed-off-by: Abdellatif El Khlifi
> Reviewed-by: Jens Wiklander
> Reviewed-by: Simon Glass
> Cc: Tom Rini
> Cc: Simon Glass
> Cc: Ilias Apalodimas
>
> ---
>
> Changelog:
> ===
>
> v9:
>
> * update the copyright string
>
> v
Sorry for being late to the party,
+cc Jose who maintains DEN0118
On Mon, Jun 19, 2023 at 11:16:53AM -0500, Jassi Brar wrote:
> Hi Michal,
>
> On Mon, 19 Jun 2023 at 10:02, Michal Simek wrote:
> >
> > Hi Jassi,
> >
> > On 5/31/23 07:28, jaswinder.si...@linaro.org wrote:
> > > From: Jassi Brar
tests to verify controllers are reconnected when uninstalling a
protocol fails
- add tests to make sure EFI_NOT_FOUND is returned if a non existent
interface is being removed
Signed-off-by: Ilias Apalodimas
---
lib/efi_selftest/efi_selftest_controllers.c | 44 +++--
1 file
and properly free the opened protocol
information when closing a protocol.
Signed-off-by: Ilias Apalodimas
---
lib/efi_loader/efi_boottime.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c
index d44562d8f4e0
-by: Ilias Apalodimas
---
lib/efi_loader/efi_boottime.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c
index bfcd913dfad9..d75a3336e3f1 100644
--- a/lib/efi_loader/efi_boottime.c
+++ b/lib/efi_loader/efi_boottime.c
@@ -1373,6 +1373,8
efi_disconnect_controller() doesn't reconnect drivers in case of
failure. Reconnect the disconnected drivers properly
Signed-off-by: Ilias Apalodimas
---
lib/efi_loader/efi_boottime.c | 31 ++-
1 file changed, 26 insertions(+), 5 deletions(-)
diff --git a/lib
/20230615143941.416924-1-ilias.apalodi...@linaro.org/
Regards
/Ilias
Ilias Apalodimas (4):
efi_loader: reconnect drivers on failure
efi_loader: check the status of disconnected drivers
efi_loader: fix the return codes of UninstallProtocol
efi_selftests: add extra testcases on controller handling
beneficial for readability to have protocol installations and
removals in pairs -- IOW when efi_install_multiple_protocol_interfaces()
is called, efi_uninstall_multiple_protocol_interfaces() should be used to
remove it. So let's swap the efi_add_protocol() as well.
Signed-off-by: Ilias Apalodimas
convert all these to efi_install_multiple_protocol_interfaces()
and treat efi_add_protocol() in a similar manner
Reviewed-by: Heinrich Schuchardt
Signed-off-by: Ilias Apalodimas
---
Changes since v2:
- Add r-b tags
include/efi_loader.h | 4
lib/efi_loader/efi_boottime.c | 6
On Sun, 18 Jun 2023 at 17:02, Ilias Apalodimas
wrote:
>
> Hi Heinrich
>
> On Sun, Jun 18, 2023 at 12:25:47PM +0200, Heinrich Schuchardt wrote:
> > The call to efi_search_obj() is redundant as the function is called in
> > efi_search_protocol() too.
> >
> >
On Mon, 19 Jun 2023 at 10:04, Heinrich Schuchardt wrote:
>
> On 6/15/23 16:39, Ilias Apalodimas wrote:
> > When we are trying to uninstall a protocol interface from a controller
> > handle we are trying to disconnect drivers related to that protocol.
> &g
On Sun, Jun 18, 2023 at 08:39:27AM +0200, Heinrich Schuchardt wrote:
> On 6/15/23 16:39, Ilias Apalodimas wrote:
> > efi_uninstall_protocol() calls efi_disconnect_all_drivers() but never
> > checks the return value. Honor that and return an appropriate error
> > if the a
On Sun, Jun 18, 2023 at 08:03:16AM +0200, Heinrich Schuchardt wrote:
> On 6/15/23 08:57, Ilias Apalodimas wrote:
> > The tcg protocol currently adds and removes protocols with
> > efi_(add/remove)_protocol(). Although this works fine protocol
> > interfaces should be instal
Hi Heinrich
On Sun, Jun 18, 2023 at 12:25:47PM +0200, Heinrich Schuchardt wrote:
> The call to efi_search_obj() is redundant as the function is called in
> efi_search_protocol() too.
>
> Signed-off-by: Heinrich Schuchardt
> ---
> v2:
> Use handle instead of efiobj to invoke
We don't have a documentation page for our TPM subsystem. I plan
on sending one in the future, but in the meantime document the
new 'tpm autostart' command in the QEMU instructions while using
a SWTPM
Signed-off-by: Ilias Apalodimas
---
doc/board/emulation/qemu-arm.rst | 2 +-
1 file changed
git a/configs/tec_defconfig b/configs/tec_defconfig
> index 461c46c725d..8a5d959a5c0 100644
> --- a/configs/tec_defconfig
> +++ b/configs/tec_defconfig
> @@ -31,7 +31,6 @@ CONFIG_CMD_GPIO=y
> CONFIG_CMD_MMC=y
> CONFIG_CMD_USB=y
> # CONFIG_CMD_SETEXPR is not set
> -# CONFIG_CMD_NFS is not set
> CONFIG_CMD_PMIC=y
> CONFIG_CMD_REGULATOR=y
> CONFIG_CMD_EXT4_WRITE=y
> diff --git a/configs/theadorable-x86-conga-qa3-e3845-pcie-x4_defconfig
> b/configs/theadorable-x86-conga-qa3-e3845-pcie-x4_defconfig
> index 43dab09316e..69499e17f4c 100644
> --- a/configs/theadorable-x86-conga-qa3-e3845-pcie-x4_defconfig
> +++ b/configs/theadorable-x86-conga-qa3-e3845-pcie-x4_defconfig
> @@ -38,7 +38,6 @@ CONFIG_CMD_SPI=y
> CONFIG_CMD_USB=y
> CONFIG_CMD_DHCP=y
> CONFIG_BOOTP_BOOTFILESIZE=y
> -# CONFIG_CMD_NFS is not set
> CONFIG_CMD_PING=y
> CONFIG_CMD_BMP=y
> CONFIG_CMD_TIME=y
> diff --git a/configs/theadorable-x86-conga-qa3-e3845_defconfig
> b/configs/theadorable-x86-conga-qa3-e3845_defconfig
> index 5aec52733e6..e2e64b74349 100644
> --- a/configs/theadorable-x86-conga-qa3-e3845_defconfig
> +++ b/configs/theadorable-x86-conga-qa3-e3845_defconfig
> @@ -37,7 +37,6 @@ CONFIG_CMD_SPI=y
> CONFIG_CMD_USB=y
> CONFIG_CMD_DHCP=y
> CONFIG_BOOTP_BOOTFILESIZE=y
> -# CONFIG_CMD_NFS is not set
> CONFIG_CMD_PING=y
> CONFIG_CMD_BMP=y
> CONFIG_CMD_TIME=y
> diff --git a/configs/theadorable-x86-dfi-bt700_defconfig
> b/configs/theadorable-x86-dfi-bt700_defconfig
> index d5a28a2df4b..751ae3497ec 100644
> --- a/configs/theadorable-x86-dfi-bt700_defconfig
> +++ b/configs/theadorable-x86-dfi-bt700_defconfig
> @@ -35,7 +35,6 @@ CONFIG_CMD_SPI=y
> CONFIG_CMD_USB=y
> CONFIG_CMD_DHCP=y
> CONFIG_BOOTP_BOOTFILESIZE=y
> -# CONFIG_CMD_NFS is not set
> CONFIG_CMD_PING=y
> CONFIG_CMD_BMP=y
> CONFIG_CMD_TIME=y
> diff --git a/configs/trimslice_defconfig b/configs/trimslice_defconfig
> index d94a0b408b5..9ec08bda883 100644
> --- a/configs/trimslice_defconfig
> +++ b/configs/trimslice_defconfig
> @@ -35,7 +35,6 @@ CONFIG_CMD_PCI=y
> CONFIG_CMD_SPI=y
> CONFIG_CMD_USB=y
> # CONFIG_CMD_SETEXPR is not set
> -# CONFIG_CMD_NFS is not set
> CONFIG_CMD_EXT4_WRITE=y
> # CONFIG_SPL_DOS_PARTITION is not set
> # CONFIG_SPL_EFI_PARTITION is not set
> diff --git a/configs/venice2_defconfig b/configs/venice2_defconfig
> index fd538da3ac5..ebd1754fc8b 100644
> --- a/configs/venice2_defconfig
> +++ b/configs/venice2_defconfig
> @@ -36,7 +36,6 @@ CONFIG_CMD_SPI=y
> CONFIG_CMD_USB=y
> CONFIG_CMD_USB_MASS_STORAGE=y
> # CONFIG_CMD_SETEXPR is not set
> -# CONFIG_CMD_NFS is not set
> CONFIG_CMD_EXT4_WRITE=y
> # CONFIG_SPL_DOS_PARTITION is not set
> # CONFIG_SPL_EFI_PARTITION is not set
> diff --git a/configs/ventana_defconfig b/configs/ventana_defconfig
> index 5e2ff877ca8..2da8ba94d62 100644
> --- a/configs/ventana_defconfig
> +++ b/configs/ventana_defconfig
> @@ -29,7 +29,6 @@ CONFIG_CMD_GPIO=y
> CONFIG_CMD_MMC=y
> CONFIG_CMD_USB=y
> # CONFIG_CMD_SETEXPR is not set
> -# CONFIG_CMD_NFS is not set
> CONFIG_CMD_PMIC=y
> CONFIG_CMD_REGULATOR=y
> CONFIG_CMD_EXT4_WRITE=y
> diff --git a/configs/vexpress_ca9x4_defconfig
> b/configs/vexpress_ca9x4_defconfig
> index 4ee64c332b3..5cacecc7cbc 100644
> --- a/configs/vexpress_ca9x4_defconfig
> +++ b/configs/vexpress_ca9x4_defconfig
> @@ -30,7 +30,6 @@ CONFIG_CMD_MMC=y
> # CONFIG_CMD_ITEST is not set
> # CONFIG_CMD_SETEXPR is not set
> CONFIG_BOOTP_BOOTFILESIZE=y
> -# CONFIG_CMD_NFS is not set
> # CONFIG_CMD_SLEEP is not set
> CONFIG_CMD_UBI=y
> CONFIG_OF_CONTROL=y
> --
> 2.41.0
>
Reviewed-by: Ilias Apalodimas
fails
- add tests to make sure EFI_NOT_FOUND is returned if a non existent
interface is being removed
Signed-off-by: Ilias Apalodimas
---
lib/efi_selftest/efi_selftest_controllers.c | 221 ++--
1 file changed, 198 insertions(+), 23 deletions(-)
diff --git a/lib/efi_selftest
efi_disconnect_controller() doesn't reconnect drivers in case of
failure. Reconnect the disconnected drivers properly
Signed-off-by: Ilias Apalodimas
---
lib/efi_loader/efi_boottime.c | 31 ++-
1 file changed, 26 insertions(+), 5 deletions(-)
diff --git a/lib
efi_disconnect_all_drivers() with a handle instead of
the efiobj
Signed-off-by: Ilias Apalodimas
---
lib/efi_loader/efi_boottime.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/efi_loader/efi_boottime.c b/lib/efi_loader/efi_boottime.c
index df675d0ad488..b148824c7ec5 100644
is not allowed to unbind -- e.g returning EFI_DEVICE_ERROR, we
will end up returning that error instead of EFI_NOT_FOUND.
Add an extra check on the top of the function to make sure the protocol
interface exists before trying to disconnect any drivers
Signed-off-by: Ilias Apalodimas
---
lib
efi_uninstall_protocol() calls efi_disconnect_all_drivers() but never
checks the return value. Honor that and return an appropriate error
if the associated controllers failed to disconnect
Signed-off-by: Ilias Apalodimas
---
lib/efi_loader/efi_boottime.c | 6 +-
1 file changed, 5
convert all these to efi_install_multiple_protocol_interfaces()
and treat efi_add_protocol() in a similar manner
Signed-off-by: Ilias Apalodimas
---
include/efi_loader.h | 4
lib/efi_loader/efi_boottime.c | 6 +++---
2 files changed, 3 insertions(+), 7 deletions(-)
diff --git
The tcg protocol currently adds and removes protocols with
efi_(add/remove)_protocol(). Although this works fine protocol
interfaces should be installed using the EFI API functions instead
of the internal API ones
Signed-off-by: Ilias Apalodimas
---
lib/efi_loader/efi_tcg2.c | 8
1
ten check when uninstalling protocols from the
handle_controller and make sure the number of child controllers is 0
Signed-off-by: Ilias Apalodimas
---
Changes since v1:
- Move the binding protocol removal to .teardown()
- return EFI_ST_FAILURE if the last count_child_controllers() fails
li
Hi Heinrich,
On Tue, 13 Jun 2023 at 18:00, Heinrich Schuchardt wrote:
>
> On 6/13/23 15:23, Ilias Apalodimas wrote:
> > Running the controller selftest more than one times fails with
> >
> > => setenv efi_selftest 'controllers' && bootefi selftest
> > Te
d
freeing them. As a result the subsequent protocol installation will try
to use an existing handle which we just removed that from our object list.
Signed-off-by: Ilias Apalodimas
---
lib/efi_selftest/efi_selftest_manageprotocols.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/li
ten check when uninstalling protocols from the
handle_controller and make sure the number of child controllers is 0
Signed-off-by: Ilias Apalodimas
---
lib/efi_selftest/efi_selftest_controllers.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/li
a command line for that function and simplify
our CLI.
Ilias Apalodimas (3):
tpm: Add 'tpm autostart' shell command
test/py: replace 'tpm2 init, startup, selftest' sequences
test/py: Account PCR updates properly during
On Mon, Jun 12, 2023 at 10:17:28PM +0100, Simon Glass wrote:
> Hi Ilias,
>
> On Wed, 7 Jun 2023 at 10:18, Ilias Apalodimas
> wrote:
> >
> > Currently we only read the pcr updates once on test_tpm2_pcr_read().
> > It turns out that the tpm init sequence
The function does not to conform to the Sphinx style documentation.
Add the missing bits
Signed-off-by: Ilias Apalodimas
---
Heinrich, this only applies on top of my rework for the function
lib/efi_loader/efi_disk.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib
efi_disk_delete_raw/blk calls.
Signed-off-by: Ilias Apalodimas
---
- Fix CI issues. dev_tag_get_ptr() is called for UCLASS_BLK or UCLASS_PARTITION
only
lib/efi_loader/efi_disk.c | 80 ++-
1 file changed, 19 insertions(+), 61 deletions(-)
diff --git a/lib
Heinrich,
Ignore this version, I've found one problem, I'll send a v2 shortly.
Thanks
/Ilias
On Mon, 12 Jun 2023 at 13:07, Ilias Apalodimas
wrote:
>
> Instead of discovering the ID of the device and call two different
> functions for a block device or a partition, we ca
-0.01%
Signed-off-by: Ilias Apalodimas
---
lib/efi_loader/efi_disk.c | 82 +++
1 file changed, 22 insertions(+), 60 deletions(-)
diff --git a/lib/efi_loader/efi_disk.c b/lib/efi_loader/efi_disk.c
index d2256713a8e7..8ab476b02445 100644
--- a/lib/efi_loader
701 - 800 of 2249 matches
Mail list logo
