RE: RE: [PATCH] net: phy: ncsi: Correct the endian of the checksum

> On Sun, Mar 03, 2024 at 02:14:43AM +0000, Jacky Chou wrote: > > Hi Dan Carpenter, > > > > I have verified it on the little-endian platform, such as ASPEED AST2600. > > Awesome. Thanks for this. > > > I think put_unaligned_be32() and htonl() functions have

回覆: [PATCH] net: phy: ncsi: Correct the endian of the checksum

寄件者: Dan Carpenter 寄件日期: 2024年2月5日 下午 11:04 收件者: Jacky Chou 副本: joe.hershber...@ni.com ; rfried@gmail.com ; tr...@konsulko.com ; michal.si...@amd.com ; marek.vasut+rene...@mailbox.org ; u-boot@lists.denx.de ; BMC-SW 主旨: Re: [PATCH] net: phy: ncsi: Correct

[PATCH] net: phy: ncsi: reslove the unaligned access issue

>From the ethernet header is not on aligned, because the length of the ethernet header is 14 bytes. Therefore, unaligned access must be done here. Signed-off-by: Jacky Chou --- drivers/net/phy/ncsi.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/

[PATCH] net: phy: ncsi: Correct the endian of the checksum

There is no need to perform the endian twice here. Signed-off-by: Jacky Chou --- drivers/net/phy/ncsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/ncsi.c b/drivers/net/phy/ncsi.c index eb3fd65bb4..74c5386d2e 100644 --- a/drivers/net/phy/ncsi.c +++ b

[PATCH] net: phy: the NC-SI phy device do not require mdio bus

As with fixed-link phy device, the NC-SI phy devive does not require an mdio bus. So, a condition is added to check the NC-SI phy id to avoid accessing the bus pointer that is NULL. Signed-off-by: Jacky Chou --- drivers/net/phy/phy.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PATCH] net: phy: ncsi: fixed not nullify the pointers after free

The issue occurs the UAF (use-after-free) to cause double free when do the realloc function for the pointers during the reinitialization NC-SI process, and it will cause the memory management occurs error. So, nullify these pointers after free. Signed-off-by: Jacky Chou --- drivers/net/phy