[GIT PULL] Please pull u-boot-mmc master

2022-02-08 Thread Jaehoon Chung
Dear Tom, Please pull u-boot-mmc master into u-boot master branch. There is the fixing fsl_esdhc_imx issue. If there is any problem, let me know, plz Best Regards, Jaehoon Chung CI: https://source.denx.de/u-boot/custodians/u-boot-mmc/-/pipelines/10913 The following changes since commit

Re: [PATCH 03/19] mmc: call device_probe() after scanning

2022-02-08 Thread Jaehoon Chung
s/mmc/mmc-uclass.c > +++ b/drivers/mmc/mmc-uclass.c > @@ -467,6 +467,18 @@ static int mmc_blk_probe(struct udevice *dev) > return ret; > } > > + ret = device_probe(dev); > + if (ret) { > + debug("Can't probe\n"

Re: [PATCH v4 4/4] rockchip: sdhci: Add HS400 Enhanced Strobe support for RK3568

2022-02-08 Thread Jaehoon Chung
> > This is partly ported from Linux's Synopsys DWC MSHC driver which > happens to be the underlying IP. (drivers/mmc/host/sdhci-of-dwcmshc.c in > Linux tree). > > Signed-off-by: Alper Nebi Yasak Reviewed-by: Jaehoon Chung As you mentioned, if someone test this on RK3568

Re: [PATCH v4 3/4] rockchip: sdhci: Add HS400 Enhanced Strobe support for RK3399

2022-02-08 Thread Jaehoon Chung
ization fail, so let it be unset as needed in > set_control_reg(). > > This is mostly ported from Linux's Arasan SDHCI driver which happens > to be the underlying IP. (drivers/mmc/host/sdhci-of-arasan.c in Linux > tree). > > Signed-off-by: Alper Nebi Yasak Reviewed-by: Jaeh

Re: [PATCH] cmd: mmc: Consider GP partitions in mmc hwpartition user enh start -

2022-02-08 Thread Jaehoon Chung
On 1/27/22 08:16, Jaehoon Chung wrote: > On 1/18/22 06:54, Marek Vasut wrote: >> In case the eMMC contains any GP partitions or user sets up new GP >> partitions, the size of these GP partitions reduce the size of the >> USER partition. Subtract the size of tho

Re: [PATCH v1] mmc: fsl_esdhc_imx: fix watermark level in dma

2022-02-08 Thread Jaehoon Chung
pplied on u-boot-mmc/master. Thanks! Best Regards, Jaehoon Chung > > --- > > drivers/mmc/fsl_esdhc_imx.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/mmc/fsl_esdhc_imx.c b/drivers/mmc/fsl_esdhc_imx.c > index 9299635f50..efa5ed

Re: [PATCH v1] mmc: fsl_esdhc_imx: fix watermark level in dma

2022-02-07 Thread Jaehoon Chung
gt; Fixes: 41c6a22fc296 ("mmc: fsl_esdhc_imx: simplify esdhc_setup_data()") >>>> Signed-off-by: Marcel Ziswiler >>> >>> This is probably the failure I saw on imx7 when I tried testing 'ums'. >>> >>> Reviewed-by: Fabio Estevam >> >> This ind

Re: [PATCH] Revert "mmc: fsl_esdhc_imx: add wait_dat0() support"

2022-01-27 Thread Jaehoon Chung
r have same problem. I'm not sure...I remember that some controller doesn't support a busy signal. In kernel driver, also doesn't report correct status? Best Regards, Jaehoon Chung > > Signed-off-by: Marek Vasut > Cc: Haibo Chen > Cc: Igor Opaniuk > Cc: Jaehoon Chung > Cc: Peng

Re: [PATCH v2 7/9] power: domain: apple: Add reset support

2022-01-27 Thread Jaehoon Chung
On 1/27/22 20:48, Mark Kettenis wrote: >> Date: Thu, 27 Jan 2022 08:54:29 +0900 >> From: Jaehoon Chung >> >> Hi, >> >> On 1/23/22 04:38, Mark Kettenis wrote: >>> The power management controller found on Apple SoCs als provides >>> a way to r

Re: [RFC 0/6] Exynos5: Update devicetree files from linux kernel

2022-01-27 Thread Jaehoon Chung
On 1/17/22 23:34, Minkyu Kang wrote: > Hi, > > On Thu, 13 Jan 2022 at 17:39, Jaehoon Chung wrote: > >> Exynos5 is using old devicetree file for only U-boot. >> It's difficult to adjust the driver-model and sync codes with linux. >> This patchset is to copy exyno

Re: [PATCH v2] power: zynqmp: Add power domain driver for ZynqMP

2022-01-26 Thread Jaehoon Chung
; +#define NODE_ID_LOCATION 5 > + > +static unsigned int xpm_configobject[] = { > + /******/ Remove "/******/". It doesn't need to add. > + /* HEADER */ > + 2, /* Number of remaining words in the header */ > + 1, /* Number of sections in

Re: [RFC 1/2] drivers: mmc: write protect active boot area after mmc init.

2022-01-26 Thread Jaehoon Chung
n for >>> eMMC. The active boot partition is write protected, and it is still >>> able to write to the inactive boot partition. >> >> It seems that you want to enable Write-protect about boot partition >> without additional command, right? >> After initialized e

Re: [PATCH v4 08/20] power: domain: ti: Add support for J721S2 SoC

2022-01-26 Thread Jaehoon Chung
On 1/26/22 00:26, Aswath Govindraju wrote: > From: David Huang > > Add support for J721S2 SoC. > > Signed-off-by: David Huang > Signed-off-by: Aswath Govindraju Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > drivers/power/domain/ti-power-domain.c

Re: [PATCH v2 7/9] power: domain: apple: Add reset support

2022-01-26 Thread Jaehoon Chung
-by: Mark Kettenis > Reviewed-by: Simon Glass > Tested on: Macbook Air M1 > Tested-by: Simon Glass Reviewed-by: Jaehoon Chung Add minor comment. > --- > arch/arm/Kconfig | 1 + > drivers/power/domain/apple-pmgr.c | 73 ++- >

Re: [RFC 1/2] drivers: mmc: write protect active boot area after mmc init.

2022-01-26 Thread Jaehoon Chung
. It seems that you want to enable Write-protect about boot partition without additional command, right? After initialized eMMC, how to update image into boot partition? Best Regards, Jaehoon Chung > > Signed-off-by: Ying-Chun Liu (PaulLiu) > Cc: Peng Fan > Cc: Jaehoon Chu

Re: [PATCH v5 03/13] mmc: fsl: Use brackets around if()

2022-01-26 Thread Jaehoon Chung
On 1/22/22 21:07, Simon Glass wrote: > At present the IS_ENABLED() macro has extra brackets, making it possible > to write: > >if IS_ENABLED(CONFIG_XXX) > > but it is a bit confusing. Add the missing brackets. > > Signed-off-by: Simon Glass Reviewed-by: Jaeh

Re: [PATCH] cmd: mmc: Consider GP partitions in mmc hwpartition user enh start -

2022-01-26 Thread Jaehoon Chung
tion > No GP4 partition > ``` > > Signed-off-by: Marek Vasut > Cc: Fabio Estevam > Cc: Jaehoon Chung > Cc: Peng Fan > Cc: Stefano Babic Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > cmd/mmc.c | 22 -- >

Re: [PATCH v4 03/13] mmc: fsl: Use brackets around if()

2022-01-16 Thread Jaehoon Chung
On 1/17/22 5:19 AM, Simon Glass wrote: > At present the IS_ENABLED() macro has extra brackets, making it possible > to write: > >if IS_ENABLED(CONFIG_XXX) > > but it is a bit confusing. Add the missing brackets. > > Signed-off-by: Simon Glass Reviewed-by: Jaeh

[GIT PULL] Please pull u-boot-pmic master

2022-01-16 Thread Jaehoon Chung
Dear Tom, Please pull u-boot-pmic master into u-boot master branch. If there is a problem, let me know, plz Best Regards, Jaehoon Chung CI: https://source.denx.de/u-boot/custodians/u-boot-pmic/-/pipelines/10653 The following changes since commit d71dbe657c3c22f50ecb3df133e5cdd884daae7d

[RFC 4/6] mmc: exynos_dw_mmc: remove the error message and not return

2022-01-13 Thread Jaehoon Chung
Remove error message and not return when there is error value. After checked whether error is or not, if be, use default value. Signed-off-by: Jaehoon Chung --- drivers/mmc/exynos_dw_mmc.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/mmc/exynos_dw_mmc.c b

[RFC 6/6] power: s2pms11: change the subnode name to regulators

2022-01-13 Thread Jaehoon Chung
Change the subnode name from voltage-regulators to regulators. Signed-off-by: Jaehoon Chung --- drivers/power/pmic/s2mps11.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/pmic/s2mps11.c b/drivers/power/pmic/s2mps11.c index 1ba1640a8df3..4098a2bed671 100644

[RFC 2/6] board: exynos5-dt-type: add hardkernel,odroid-xu3 compatible

2022-01-13 Thread Jaehoon Chung
Add hardkernel,odroid-xu3 compatible. Linux kernel device-tree is using it. Signed-off-by: Jaehoon Chung --- board/samsung/common/exynos5-dt-types.c | 1 + 1 file changed, 1 insertion(+) diff --git a/board/samsung/common/exynos5-dt-types.c b/board/samsung/common/exynos5-dt-types.c index

[RFC 3/6] mmc: exynos_dw_mmc: add exynos5420 compatible

2022-01-13 Thread Jaehoon Chung
Add exynos5420 compatible. It's from Linux kernel. Signed-off-by: Jaehoon Chung --- drivers/mmc/exynos_dw_mmc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mmc/exynos_dw_mmc.c b/drivers/mmc/exynos_dw_mmc.c index 544798bb71d1..526c30d2fe0f 100644 --- a/drivers/mmc

[RFC 5/6] i2c: exynos_hs_i2c: add samsung,exynos5250-hsi2c compatible

2022-01-13 Thread Jaehoon Chung
Add samsung,exynos5250-hsi2c compatible. Signed-off-by: Jaehoon Chung --- drivers/i2c/exynos_hs_i2c.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/i2c/exynos_hs_i2c.c b/drivers/i2c/exynos_hs_i2c.c index 39bcacc17a7e..2ed1245bb3ab 100644 --- a/drivers/i2c/exynos_hs_i2c.c +++ b

[RFC 0/6] Exynos5: Update devicetree files from linux kernel

2022-01-13 Thread Jaehoon Chung
or not. If this is worthful job, I will work this continously. Otherwise, I will drop this RFC patches. Tested on XU3 boards. Jaehoon Chung (6): ARM: exynos5: sync devicetree files from linux kernel board: exynos5-dt-type: add hardkernel,odroid-xu3 compatible mmc: exynos_dw_mmc: add exynos5420

Re: [PATCH] mmc: dwmmc: return a proper error code when busy

2022-01-12 Thread Jaehoon Chung
On 1/12/22 8:11 PM, John Keeping wrote: > On Wed, Jan 12, 2022 at 08:38:01AM +0900, Jaehoon Chung wrote: >> On 1/12/22 7:12 AM, Jaehoon Chung wrote: >>> On 1/12/22 1:15 AM, John Keeping wrote: >>>> When failing to send a command because the hardware is busy, return &g

Re: [PATCH] mmc: dw_mmc: Fixes timeout issue for FIFO mode

2022-01-12 Thread Jaehoon Chung
to the logs, you can see that the DTO interrupt was > unintentionally cleared I had been tested after set the fifo-mode. It's occurred timeout error. But your patch doesn't work, too. It's not solution to solve this problem. Well, I have checked some code. It seems that there are some bugs ab

[GIT PULL] Please pull u-boot-mmc master

2022-01-11 Thread Jaehoon Chung
Hi Tom, Please pull u-boot-mmc master into u-boot master branch. If there is a problem, let me know, plz. Best Regards, Jaehoon Chung CI: https://source.denx.de/u-boot/custodians/u-boot-mmc/-/pipelines/10571 The following changes since commit fe04d885fb540b614a2f989e16e808b300ccb52e: Merge

Re: [PATCH] mmc: dwmmc: return a proper error code when busy

2022-01-11 Thread Jaehoon Chung
Hi John, On 1/12/22 7:12 AM, Jaehoon Chung wrote: > Hi John, > > On 1/12/22 1:15 AM, John Keeping wrote: >> When failing to send a command because the hardware is busy, return >> EBUSY to indicate the cause instead of just -1. Is this patch same? https://patchwork.ozl

[RESEND PATCH v3 01/12] mmc: fsl_esdhc_imx: make BLK as hard requirement of DM_MMC

2022-01-11 Thread Jaehoon Chung
BLK is always enabled for DM_MMC). - Use DM_MMC instead of BLK for conditional compile. Signed-off-by: Yangbo Lu Signed-off-by: Sean Anderson Signed-off-by: Jaehoon Chung --- drivers/mmc/fsl_esdhc_imx.c | 33 + 1 file changed, 1 insertion(+), 32 deletions

Re: [PATCH v2 2/2] doc: board: avoid ambiguous names for axy17lte

2022-01-11 Thread Jaehoon Chung
series > of 2017 (a5y17lte)") > Signed-off-by: Henrik Grimler > Reviewed-by: Dzmitry Sankouski Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > Changes since v1: fix a5y17lte->a7y17lte, pointed out by Dzmitry, and > add reviewed-by tag. > --- > doc/

Re: [PATCH v2 1/2] board: samsung: fix menu entries for a{3,7}y17lte

2022-01-11 Thread Jaehoon Chung
samsung: add support for Galaxy A series > of 2017 (a5y17lte)") > Signed-off-by: Henrik Grimler > Reviewed-by: Dzmitry Sankouski Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > Changes since v1: none, added Dzmitry's reviewed-by tag. > --- > arch/arm/mac

Re: [PATCH] mmc: dw_mmc: Fixes timeout issue for FIFO mode

2022-01-11 Thread Jaehoon Chung
that not clearing during reset card. (power glitch or other problem..?) Best Regards, Jaehoon Chung > > >> Could you change from your ID to your name? > > This is my first time sending a patch, sorry I didn't notice this, do I > need to resend this patch? > > > BR

Re: [PATCH] mmc: dwmmc: return a proper error code when busy

2022-01-11 Thread Jaehoon Chung
Hi John, On 1/12/22 1:15 AM, John Keeping wrote: > When failing to send a command because the hardware is busy, return > EBUSY to indicate the cause instead of just -1. > > Signed-off-by: John Keeping Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > driver

Re: [PATCH] mmc: dw_mmc: Fixes timeout issue for FIFO mode

2022-01-11 Thread Jaehoon Chung
rupt > in FIFO mode") > Signed-off-by: hmz007 Could you change from your ID to your name? Best Regards, Jaehoon Chung > --- > drivers/mmc/dw_mmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c >

Re: [RESEND PATCH v3 01/12] mmc: fsl_esdhc_imx: make BLK as hard requirement of DM_MMC

2022-01-10 Thread Jaehoon Chung
ch from patchwork directly. https://patchwork.ozlabs.org/project/uboot/patch/17862939-c7b1-310e-d98e-ce68f776e...@seco.com/ If you're ok, I will apply after modified your patch. Best Regards, Jaehoon Chung > > Signed-off-by: Yangbo Lu > Signed-off-by: Sean Anderson > --- > > Changes i

Re: [PATCH v3 00/12] fsl_esdhc_imx: port several patches from fsl_esdhc

2022-01-03 Thread Jaehoon Chung
es. For this > reason, I think that the fsl_esdhc_imx driver should be removed unless > NXP can commit to creating series like this which port patches which > apply to both drivers. Sorry for too late. I had been tried to applied this series from patchwork, but i can't see [PATCH v3 01/1

Re: [RFC v2 05/20] mmc: call device_probe() after scanning

2022-01-03 Thread Jaehoon Chung
ting partitions on a device will be added. If add me and Peng as Cc when you sent the patches related with mmc, it's more helpful to review. Best Regards, Jaehoon Chung > > Signed-off-by: AKASHI Takahiro > --- > drivers/mmc/mmc-uclass.c | 13 + > 1 file changed, 13

Re: [PATCH 0/3] Apple M1 power management controller support

2021-12-28 Thread Jaehoon Chung
Dear Mark, On 12/24/21 6:37 AM, Mark Kettenis wrote: >> From: Jaehoon Chung >> Date: Wed, 22 Dec 2021 18:56:18 +0900 > > Dear Jaehoon, > > Just noticed that I accidentally included some unrelated > driver/mailbox changes in the first patch from this series. So I se

Re: [PATCH v2 3/3] power: domain: Add Apple pmgr driver

2021-12-27 Thread Jaehoon Chung
On 12/24/21 6:34 AM, Mark Kettenis wrote: > This driver supports power domains for the power management > controller found on Apple SoCs. > > Signed-off-by: Mark Kettenis Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > arch/arm/Kconfig

Re: [PATCH v2 2/3] arm: dts: apple: Add u-boot,dm-pre-reloc properties

2021-12-27 Thread Jaehoon Chung
On 12/24/21 6:34 AM, Mark Kettenis wrote: > These are necessary to make sure the power domains needed for the > serial console are availble in the pre-relocation phase. > > Signed-off-by: Mark Kettenis Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > arch/ar

Re: [PATCH v2 1/3] arm: dts: apple: Update Apple M1 device trees

2021-12-27 Thread Jaehoon Chung
l some differences that will hopefully be resolved > soon. > > Signed-off-by: Mark Kettenis Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > arch/arm/dts/Makefile|5 +- > arch/arm/dts/t8103-j274.dts | 122 +--- > arch/arm/dts/t8103-j293.dts | 92 +--

Re: [PATCH 0/3] Apple M1 power management controller support

2021-12-22 Thread Jaehoon Chung
Hi Mark, On 12/21/21 5:30 PM, Mark Kettenis wrote: >> From: Jaehoon Chung >> Date: Tue, 21 Dec 2021 08:00:38 +0900 > Hello Jaehoon, > >> Dear Mark, >> >> On 12/7/21 4:03 AM, Mark Kettenis wrote: >>> This series adds support for the power manage

Re: [PATCH 0/3] Apple M1 power management controller support

2021-12-20 Thread Jaehoon Chung
earlier boot stages. Is there any patch before applied this patchset? Best Regards, Jaehoon Chung > > > Mark Kettenis (3): > arm: dts: apple: Update Apple M1 device trees > arm: dts: apple: Add u-boot,dm-pre-reloc properties > power: domain: Add Apple pmgr

Re: [PATCH 1/1] mmc: unconditionally define mmc_deinit()

2021-12-20 Thread Jaehoon Chung
On 12/18/21 6:53 PM, Heinrich Schuchardt wrote: > We want to replace '#ifdef' by 'if (IS_ENABLED(CONFIG_...))' in our code. > Therefore functions should be defined unconditionally even if they are not > implemented. > > Signed-off-by: Heinrich Schuchardt Reviewed-by: Jaeho

Re: [PATCH] mmc: dwmmc: return a proper error code when busy

2021-12-07 Thread Jaehoon Chung
On 12/8/21 1:09 AM, John Keeping wrote: > When failing to send a command because the hardware is busy, return > EBUSY to indicate the cause instead of just -1. > > Signed-off-by: John Keeping Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > drivers/mmc/dw

Re: [PATCH 21/23] video: Support virtio devices with the splash screen

2021-11-22 Thread Jaehoon Chung
no virtio support\n"); > + return -ENOSYS; > + } else { > + return virtio_init(); > + } Doesn't need to add "else" ? Best Regards, Jaehoon Chung > +} > + > #ifdef CONFIG_CMD_UBIFS > static int splash_mount_ubifs(struct

Re: [PATCH v2 12/14] mmc: mediatek: add support for MediaTek MT7621 SoC

2021-11-22 Thread Jaehoon Chung
On 11/19/21 10:37 AM, Weijie Gao wrote: > This patch adds SDXC support for MediaTek MT7621 SoC > > Signed-off-by: Weijie Gao Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > v2 changes: none > --- > drivers/mmc/mtk-sd.c | 13 + > 1 fil

Re: [PATCH v2 07/11] mmc: fsl_esdhc_imx: simplify 64bit check for SDMA transfers

2021-11-15 Thread Jaehoon Chung
On 11/16/21 12:12 AM, Sean Anderson wrote: > > > On 11/15/21 3:39 AM, Jaehoon Chung wrote: >> On 11/13/21 4:15 AM, Sean Anderson wrote: >>> [ fsl_esdhc commit da86e8cfcb03ed5c1d8e0718bc8bc8583e60ced8 ] >>> >>> SDMA can only do DMA with 32 bit address

Re: [PATCH v2 10/11] mmc: fsl_esdhc_imx: replace most #ifdefs by IS_ENABLED()

2021-11-15 Thread Jaehoon Chung
data->blocks * data->blocksize, > - mmc_get_dma_dir(data)); > -#ifdef CONFIG_MCF5441x > - if (data->flags & MMC_DATA_READ) > - sd_swap_dma_buff(data); > -#endif > -#endif > } > > o

Re: [PATCH v2 09/11] mmc: fsl_esdhc_imx: simplify esdhc_setup_data()

2021-11-15 Thread Jaehoon Chung
> > Signed-off-by: Michael Walle > Signed-off-by: Sean Anderson Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > > (no changes since v1) > > drivers/mmc/fsl_esdhc_imx.c | 89 ++--- > 1 file changed, 52 insertions(+),

Re: [PATCH v2 08/11] mmc: fsl_esdhc_imx: use dma-mapping API

2021-11-15 Thread Jaehoon Chung
n Anderson Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > > (no changes since v1) > > drivers/mmc/fsl_esdhc_imx.c | 50 +++-- > 1 file changed, 15 insertions(+), 35 deletions(-) > > diff --git a/drivers/mmc/fsl_esdh

Re: [PATCH v2 07/11] mmc: fsl_esdhc_imx: simplify 64bit check for SDMA transfers

2021-11-15 Thread Jaehoon Chung
_FSL_LAYERSCAPE. > > Also make the error message more concise. > > Signed-off-by: Michael Walle > Signed-off-by: Sean Anderson Reviewed-by: Jaehoon Chung Just add minor comments. > --- > > (no changes since v1) > > drivers/mmc/fsl_esdhc_imx.c | 33 ++---

Re: [PATCH v2 06/11] mmc: fsl_esdhc_imx: fix mmc->clock with actual clock

2021-11-15 Thread Jaehoon Chung
rson Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > > (no changes since v1) > > drivers/mmc/fsl_esdhc_imx.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mmc/fsl_esdhc_imx.c b/drivers/mmc/fsl_esdhc_imx.c > index b2844d0a7b.

Re: [PATCH v2 05/11] mmc: fsl_esdhc_imx: drop redundant code for non-removable feature

2021-11-15 Thread Jaehoon Chung
ff-by: Sean Anderson Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > > (no changes since v1) > > drivers/mmc/fsl_esdhc_imx.c | 28 ++-- > 1 file changed, 10 insertions(+), 18 deletions(-) > > diff --git a/drivers/mmc/fsl_esdhc

Re: [PATCH v2 04/11] mmc: fsl_esdhc_imx: clean up bus width configuration code

2021-11-15 Thread Jaehoon Chung
; use driver without providing max bus width. > > - Remove bus_width member from fsl_esdhc_priv structure. > > Signed-off-by: Yangbo Lu > [ converted if statement to switch ] > Signed-off-by: Sean Anderson Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > > C

Re: [PATCH v2 03/11] mmc: fsl_esdhc_imx: fix voltage validation

2021-11-15 Thread Jaehoon Chung
and let voltage validation is through CMD8. > > Signed-off-by: Yangbo Lu > Signed-off-by: Sean Anderson Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > > (no changes since v1) > > drivers/mmc/fsl_esdhc_imx.c | 35 +---

Re: [PATCH v2 02/11] mmc: fsl_esdhc_imx: remove redundant DM_MMC checking

2021-11-15 Thread Jaehoon Chung
On 11/13/21 4:15 AM, Sean Anderson wrote: > [ fsl_esdhc commit 2913926f3b3dec282f8773e3c02377c9600d8267 ] > > Remove redundant DM_MMC checking which is already in DM_MMC conditional > compile block. > > Signed-off-by: Yangbo Lu > Signed-off-by: Sean Anderson Reviewed-by:

Re: [PATCH v2 01/11] mmc: fsl_esdhc_imx: make BLK as hard requirement of DM_MMC

2021-11-15 Thread Jaehoon Chung
h. > 66fa035 mmc: fsl_esdhc: fix probe issue without CONFIG_BLK enabled > > - Support only DM_MMC + BLK (assuming BLK is always enabled for DM_MMC). > > - Use DM_MMC instead of BLK for conditional compile. > > Signed-off-by: Yangbo Lu > Signed-off-by: Sean Anderson

Re: [PATCH] power: pmic/fan53555: allow dm be omitted by SPL

2021-11-15 Thread Jaehoon Chung
On 11/12/21 11:10 PM, Quentin Schulz wrote: > Allow the dm driver be omitted by SPL. > > Cc: Quentin Schulz > Signed-off-by: Quentin Schulz Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > drivers/power/pmic/Kconfig | 14 ++ > drivers/pow

Re: [External] - Slow MMC IO with Raspberry CM3+ Module

2021-11-10 Thread Jaehoon Chung
d in RPi firmware and your workaround is not needed, correct? > > I think this is a fair question. > > The patches are still needed for certain tagged versions of the RPi firmware. > Later tags may resolve this problem but may also introduce their own > regressions which > force

Re: [PATCH 04/11] mmc: fsl_esdhc_imx: clean up bus width configuration code

2021-11-09 Thread Jaehoon Chung
On 11/10/21 7:47 AM, Sean Anderson wrote: > > > On 11/9/21 5:41 PM, Jaehoon Chung wrote: >> Hi Sean, >> >> On 11/9/21 11:42 PM, Sean Anderson wrote: >>> >>> >>> On 11/9/21 2:19 AM, Jaehoon Chung wrote: >>>>

Re: [PATCH 04/11] mmc: fsl_esdhc_imx: clean up bus width configuration code

2021-11-09 Thread Jaehoon Chung
On 11/10/21 1:13 AM, Adam Ford wrote: > On Fri, Nov 5, 2021 at 12:41 PM Sean Anderson wrote: >> >> [ fsl_esdhc commit 07bae1de382723b94244096953b05225572728cd ] >> >> This patch is to clean up bus width setting code. >> >> - For DM_MMC, remove getting "bus-width" from device tree. >> This has

Re: [PATCH 04/11] mmc: fsl_esdhc_imx: clean up bus width configuration code

2021-11-09 Thread Jaehoon Chung
Hi Sean, On 11/9/21 11:42 PM, Sean Anderson wrote: > > > On 11/9/21 2:19 AM, Jaehoon Chung wrote: >> On 11/6/21 2:39 AM, Sean Anderson wrote: >>> [ fsl_esdhc commit 07bae1de382723b94244096953b05225572728cd ] >>> >>> This patch is to clean up bus width

Re: [PATCH 06/11] mmc: fsl_esdhc_imx: fix mmc->clock with actual clock

2021-11-08 Thread Jaehoon Chung
.c > @@ -665,6 +665,7 @@ static void set_sysctl(struct fsl_esdhc_priv *priv, > struct mmc *mmc, uint clock) > esdhc_setbits32(>sysctl, SYSCTL_PEREN | SYSCTL_CKEN); > #endif > > + mmc->clock = sdhc_clk / pre_div / div; Are there cases about "division by zero"? Best Regards, Jaehoon Chung > priv->clock = clock; > } > >

Re: [PATCH 04/11] mmc: fsl_esdhc_imx: clean up bus width configuration code

2021-11-08 Thread Jaehoon Chung
fg->host_caps |= MMC_MODE_1BIT | MMC_MODE_4BIT; > + } else if (cfg->max_bus_width == 1) { > + mmc_cfg->host_caps |= MMC_MODE_1BIT; > + } else { > + mmc_cfg->host_caps |= MMC_MODE_1BIT | MMC_MODE_4BIT | > +

Re: [PATCH 2/2] exynos: mmu: use CONFIG_IS_ENABLED

2021-11-08 Thread Jaehoon Chung
On 11/4/21 4:13 PM, Minkyu Kang wrote: > to fix following checkpatch warnings. > Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' where > possible > > Signed-off-by: Minkyu Kang > Cc: Dzmitry Sankouski Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung >

Re: [PATCH 1/2] exynos78x0: pinctrl: set const to structs

2021-11-08 Thread Jaehoon Chung
On 11/4/21 4:13 PM, Minkyu Kang wrote: > to fix following checkpatch warings. > WARNING: struct should normally be const > > Signed-off-by: Minkyu Kang > Cc: Dzmitry Sankouski Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > drivers/pinctrl/exynos/pinc

Re: [PATCH 1/1] doc: mmc rescan speed mode

2021-11-08 Thread Jaehoon Chung
On 11/6/21 12:39 AM, Heinrich Schuchardt wrote: > Provide human readable descriptions of the speed nodes instead of the name > of constants from the code. > > Signed-off-by: Heinrich Schuchardt Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > doc/

Re: [PATCH] mmc: mtk-sd: implement waiting for DAT0 line state

2021-11-08 Thread Jaehoon Chung
?k=553fefc7-0aa4d6e8-553e6488-0cc47a31cdf8-658c3df5220dc893=1=badb6c30-0546-4072-80c5-a772143bc5ee=https%3A%2F%2Fpatchwork.ozlabs.org%2Fproject%2Fuboot%2Fpatch%2F1629192034-64056-1-git-send-email-ye.li%40nxp.com%2F > > Signed-off-by: Julien Masson Reviewed-by: Jaehoon Chung Best Regards, J

Re: [PATCH 3/3] rockchip: sdhci: Add HS400 Enhanced Strobe support for RK3568

2021-11-02 Thread Jaehoon Chung
Nebi Yasak > --- > Merely build-tested as I don't have a RK3568 board. If someone can test this patch on RK3568 board, it will be more better. Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > > drivers/mmc/rockchip_sdhci.c | 23 +++ > 1 file changed

Re: [PATCH 2/3] rockchip: sdhci: Add HS400 Enhanced Strobe support for RK3399

2021-11-02 Thread Jaehoon Chung
be the underlying IP. (drivers/mmc/host/sdhci-of-arasan.c in Linux > tree). > > Signed-off-by: Alper Nebi Yasak Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > > drivers/mmc/rockchip_sdhci.c | 28 > 1 file changed, 28 inse

Re: [PATCH 1/3] mmc: sdhci: Add HS400 Enhanced Strobe support

2021-11-02 Thread Jaehoon Chung
On 11/1/21 6:07 PM, Alper Nebi Yasak wrote: > Delegate setting the Enhanced Strobe configuration to individual drivers > if they set a function for it. Return -ENOTSUPP if they do not, like > what the MMC uclass does. > > Signed-off-by: Alper Nebi Yasak Reviewed-by: Jaehoon Chung

Re: [PATCH 0/3] rockchip: sdhci: Add HS400 Enhanced Strobe support

2021-11-01 Thread Jaehoon Chung
board, but this code is working fine. It seems that needs to implement a reinit callback function to clear the previous configurations in rockchip_sdhci.c. Best Regards, Jaehoon Chung > if (!mmc_getcd(mmc)) > force_init = true; > > if (force_init) > mmc->has_init = 0; >

Re: [PATCH 0/3] rockchip: sdhci: Add HS400 Enhanced Strobe support

2021-11-01 Thread Jaehoon Chung
| MMC High Speed (52MHz)| HS400ES (200 MHz) > 8MiB Load Speed | ~9.5 MiB/s| ~51.5 MiB/s > 256MiB Load Speed | ~177.8 MiB/s | ~114.5 MiB/s I wonder why HS400ES is lower than High Speed mode in 256MiB Load Speed. Best Regards, Jaehoon Chung > &

[GIT PULL] Please pull u-boot-mmc master

2021-10-29 Thread Jaehoon Chung
Hi Tom, Please pull u-boot-mmc master into u-boot master branch. If there is a problem, let me know, plz. Best Regards, Jaehoon Chung CI: https://source.denx.de/u-boot/custodians/u-boot-mmc/-/pipelines/9649 The following changes since commit aafc378a6caef453a40f2f9f3d6bef69e592c28d: Merge

Re: [PATCH v3 3/5] power: regulator: scmi: define LOG_CATEGORY

2021-10-28 Thread Jaehoon Chung
On 10/29/21 2:13 AM, Patrick Delaunay wrote: > Define LOG_CATEGORY to allow filtering with log command. > > Signed-off-by: Patrick Delaunay > Acked-by: Etienne Carriere Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > > (no changes since v1) > &g

Re: [PATCH] Supports SPLASH_STORAGE_MMC and SPLASH_STORAGE_RAW together

2021-10-28 Thread Jaehoon Chung
static int splash_storage_read_raw() { ... switch() { case SPLASH_STORAGE_MMC: return splash_mmc_read_raw(); ... } } It is impossible? Best Regards, Jaehoon Chung > +{ > + struct bmp_header *bmp_hdr; > + int res; > +

Re: [PATCH 4/4] mmc: sunxi: Use DM_GPIO flags to set pull-up

2021-10-22 Thread Jaehoon Chung
Hi Andre, On 10/22/21 6:00 PM, Andre Przywara wrote: > On Fri, 22 Oct 2021 06:58:48 +0900 > Jaehoon Chung wrote: > > Hi Jaehoon, > > thanks for having a look! > >> Hi, >> >> On 10/21/21 1:52 PM, Samuel Holland wrote: >>> Now that the sunxi

Re: [PATCH 4/4] mmc: sunxi: Use DM_GPIO flags to set pull-up

2021-10-21 Thread Jaehoon Chung
cd_gpio); > - > - sunxi_gpio_set_pull(cd_pin, SUNXI_GPIO_PULL_UP); > - } > + gpio_request_by_name(dev, "cd-gpios", 0, >cd_gpio, > + GPIOD_IS_IN | GPIOD_PULL_UP); Is it right to set the pull-up? Best Regards, Jaehoon Chung > > upriv->mmc = >mmc; > >

Re: please help, "Ram disk image is corrupt or invalid" (qemu virt machine, arm64)

2021-10-19 Thread Jaehoon Chung
-f1 /proc/uptime) seconds\n" > ifconfig eth0 10.0.2.15 netmask 255.255.255.0 up > route add default gw 10.0.2.2 > exec /bin/sh > > o make ramdisk image (under _install directory) > find -print0 | cpio -0oH newc | gzip -9 > ../initramfs.cpio.gz AFAIK, you

Re: [PATCH v2] mmc: arm_pl180_mmci: Enable HWFC for specific versions of MCI

2021-10-19 Thread Jaehoon Chung
wed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > drivers/mmc/arm_pl180_mmci.c | 14 ++ > drivers/mmc/arm_pl180_mmci.h | 1 + > 2 files changed, 15 insertions(+) > > diff --git a/drivers/mmc/arm_pl180_mmci.c b/drivers/mmc/arm_pl180_mmci.c > index f99b5f997

Re: please help, "Ram disk image is corrupt or invalid" (qemu virt machine, arm64)

2021-10-19 Thread Jaehoon Chung
disk Image Format > > Ramdisk image is corrupt or invalid You can check the debug message in common/image-board.c. Did you create ramdisk image the correct format? Best Regards, Jaehoon Chung > > > > I hoped now I set the device tree to have the initrd location, the kernel &

Re: How to compile u-boot with debug option?

2021-10-19 Thread Jaehoon Chung
[1] id 1 from 0x0028 in reset at arch/arm/cpu/armv8/start.S:57 ─── Variables ─── ────────

Re: How to compile u-boot with debug option?

2021-10-18 Thread Jaehoon Chung
t's not proper to current u-boot. make ARCH=arm menucofig and check config relevant to DEBUG option. Best Regards, Jaehoon Chung > > -DDEBUG to CFLAGS_NON_EFI in arch/arm/config.mk and adding CFLAGS += -DDEBUG > in arch/arm/cpu/armv8/config.mk > > But after doing "make ARCH=arm CRO

Re: [PATCH] mmc: arm_pl180_mmci: Enable HWFC for specific versions of MCI

2021-10-18 Thread Jaehoon Chung
Arif > Change-Id: Icc79e352db6305c232527c4a432f17b7a30fec8e Remove Change-ID. Best Regards, Jaehoon Chung > --- > drivers/mmc/arm_pl180_mmci.c | 14 ++ > drivers/mmc/arm_pl180_mmci.h | 1 + > 2 files changed, 15 insertions(+) > > diff --git a/driver

Re: [PATCH v2] env: mmc: Add support for redundant env in both eMMC boot partitions

2021-10-17 Thread Jaehoon Chung
st this, I can't apply this from patchwork. Best Regards, Jaehoon Chung > > Signed-off-by: Marek Vasut > Cc: Fabio Estevam > Cc: Jaehoon Chung > Cc: Peng Fan > Cc: Stefano Babic > --- > V2: Add documentation of this behavior into Kconfig help

Re: [PATCH] mmc: rockchip_sdhci: enable strobe line for HS400

2021-10-17 Thread Jaehoon Chung
gt; On 10/15/21 5:41 PM, Yifeng Zhao wrote: >> The default configuration of rk3399 EMMC PHY does not enable the >> strobe line, and EMMC controller will got data transmission error >> at HS400 mode. >> >> Signed-off-by: Yifeng Zhao Reviewed-by: Jaehoon Chung Best Regards, Jaeh

Re: [PATCH] mmc: rockchip_sdhci: enable strobe line for HS400

2021-10-17 Thread Jaehoon Chung
writel(RK_CLRSETBITS(0, 1 << 9), >emmcphy_con[2]); > + Just wonder about doesn't it affect to other mode? Best Regards, Jaehoon Chung > read_poll_timeout(readl, >emmcphy_status, dllrdy, > PHYCTRL_DLL_LOCK_WO_TMOUT(dllrdy), 1, 5000); > } >

Re: [PATCH] mxs: power: Change sequence of enabling DCDC switches

2021-10-13 Thread Jaehoon Chung
hen > follow with its children. > > Signed-off-by: Lukasz Majewski Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > arch/arm/cpu/arm926ejs/mxs/spl_power_init.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/cpu/arm926ej

[PATCH] cmd: mmc: check whether card is SD or eMMC before hwpartition

2021-09-23 Thread Jaehoon Chung
It doesn't need to follow more sequence to do the hwparititioning, because SD doesn't support hwpartitioning feature. Signed-off-by: Jaehoon Chung --- cmd/mmc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/cmd/mmc.c b/cmd/mmc.c index f1e30d0cf64b..62c7e9129666 100644 --- a/cmd/mmc.c

Re: [PATCH] drivers: pmic: Add sysreset driver to da9063 pmic device

2021-09-23 Thread Jaehoon Chung
let me know, plz. Best Regards, Jaehoon Chung > > Signed-off-by: Alexandre Ghiti > --- > configs/sifive_unmatched_defconfig | 2 ++ > drivers/power/pmic/da9063.c| 49 ++ > 2 files changed, 51 insertions(+) > > diff --git a/configs/s

Re: [PATCH 2/2] cmd/mmc: add subcommand to query max enhanced partition size

2021-09-23 Thread Jaehoon Chung
have any objection about this patch. If we can use more simpler variable name than maxhwpartsectors, I think that it's more useful. But it's not important. :) And Could you update doc/usage/mmc.rst about this command? Best Regards, Jaehoon Chung > > Signed-off-by: Markus

Re: [PATCH 1/2] mmc: add helper to query max enhanced part size

2021-09-23 Thread Jaehoon Chung
xt_csd[EXT_CSD_MAX_ENH_SIZE_MULT + 1] << 8) + > + ext_csd[EXT_CSD_MAX_ENH_SIZE_MULT]; > + sz *= ext_csd[EXT_CSD_HC_ERASE_GRP_SIZE]; > + sz *= ext_csd[EXT_CSD_HC_WP_GRP_SIZE]; > + sz *= SZ_1K; To use the num of sector, i think better that is adding Com

Re: [PATCH] mmc: fsl_esdhc: remove 1ms sleep in esdhc_send_cmd_common()

2021-09-13 Thread Jaehoon Chung
t > 9098682200e6 ("mmc: fsl_esdhc_imx: remove the 1ms delay before sending > command"). > > Signed-off-by: Michael Walle If someone can test with this patch, I think that it's more better. But i don't have any objection to apply this patch. Reviewed-by: Jaehoon Chung

Re: [PATCH] sunxi: mmc: A20: Fix MMC optimisation

2021-09-04 Thread Jaehoon Chung
tuck forever. > > Check for this situation and use a safe minimal FIFO size instead when > we hit this case. > > This fixes MMC boot on A20 devices after the MMC FIFO optimisation > (9faae5457f52). > > Signed-off-by: Andre Przywara Reviewed-by: Jaehoon Chung Best Regards,

Re: [PATCH 07/11] sunxi: pmic_bus: Fix Kconfig dependencies

2021-09-02 Thread Jaehoon Chung
amuel Holland Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > > arch/arm/mach-sunxi/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig > index 28332008501..12235fabc0

Re: [PATCH 05/11] power: pmic: Add a driver for X-Powers AXP PMICs

2021-09-02 Thread Jaehoon Chung
= dm_i2c_read, > + .write = dm_i2c_write, > +}; > + > +static int axp_pmic_bind(struct udevice *dev) > +{ > + int ret; > + > + ret = dm_scan_fdt_dev(dev); > + if (ret) > + return ret; > + > +

Re: [PATCH 04/11] power: pmic: Make the uclass optional in SPL

2021-09-02 Thread Jaehoon Chung
Also update the SPL-specific symbols to depend > on this new option. > > Signed-off-by: Samuel Holland Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > > drivers/power/pmic/Kconfig | 17 - > drivers/power/pmic/Makefile | 2 +- >

Re: [PATCH 03/11] power: pmic: Consistently depend on DM_PMIC

2021-09-02 Thread Jaehoon Chung
ad of using a "depends on DM_PMIC" clause for each driver. > > Signed-off-by: Samuel Holland Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > > drivers/power/pmic/Kconfig | 43 +++--- > 1 file changed, 8 insertions(+), 35

<    1   2   3   4   5   6   7   8   9   10   >