Re: [RFT PATCH 2/2] mmc: meson-gx: set 270 core phase during the identification

2023-11-10 Thread Jerome Brunet
he phase was set to 270 on axg). > > On Fri, 2023-09-15 at 18:01 +0200, Jerome Brunet wrote: >> It has been reported that some devices have problems with a 180 degree >> core phase. Setting 270 helped some of these devices. Other continue to >> struggle (while it works fine wit

[RFT PATCH 2/2] mmc: meson-gx: set 270 core phase during the identification

2023-09-15 Thread Jerome Brunet
, then using 180 for the rest of the operations, helps the device operate correctly. Signed-off-by: Jerome Brunet --- drivers/mmc/meson_gx_mmc.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/meson_gx_mmc.c b/drivers/mmc/meson_gx_mmc.c index c6168792cbae

[RFT PATCH 1/2] mmc: meson-gx: clean up and align on Linux settings

2023-09-15 Thread Jerome Brunet
* Remove obsolete comments * Set core phase to 180 regardless of the SoC like Linux * Enable always-on clock AML mmc driver has been working okay(ish) for a few years The purpose of this patch is to bring u-boot closer to what Linux is doing Signed-off-by: Jerome Brunet --- drivers/mmc

[RFT PATCH 0/2] mmc: meson-gx: improve MMC reliabilty

2023-09-15 Thread Jerome Brunet
on the platforms I have tested (Libretech's boards and VIM3L) It would be great if others could test this and report whether this work for them or not. If the results are good, this might be ported to Linux as well (... but the situation is less critical there) Jerome Brunet (2): mmc: meson-gx: clean up

[PATCH] ARM: meson: fixup error on efuse commands return

2022-08-04 Thread Jerome Brunet
/write_efuse() is not the requested size. Fixes: 52195ba5f579 ("ARM: amlogic: add sm efuse write support and cmd for read/write efuse") Signed-off-by: Jerome Brunet --- arch/arm/mach-meson/sm.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/arch/arm/mach-

[PATCH RESEND v2 1/2] arm64: dts: import libretech-cc-v2 from linux v5.10-rc1

2020-11-06 Thread Jerome Brunet
Sync the libretech cc v2 device tree from Linux v5.10-rc1 commit 3650b228f83a ("Linux 5.10-rc1") Signed-off-by: Jerome Brunet --- arch/arm/dts/Makefile | 1 + .../dts/meson-gxl-s905x-libretech-cc-v2.dts | 318 ++ 2 files changed, 319

[PATCH RESEND v2 2/2] arm64: meson: add support for libretech-cc v2

2020-11-06 Thread Jerome Brunet
Add support for the Amlogic based libretech cc version 2. As version 1, it is based on the s905x SoC. Signed-off-by: Jerome Brunet --- ...eson-gxl-s905x-libretech-cc-v2-u-boot.dtsi | 7 ++ board/amlogic/p212/MAINTAINERS| 1 + configs/libretech-cc_v2_defconfig

[PATCH RESEND v2 0/2] arm64: meson: add libretech cc v2 support

2020-11-06 Thread Jerome Brunet
This patchset adds support for the Amlogic based libretech cc v2. Like the v1, this revised platform used the s905x SoC. Changes since v1: - Move Makefile change to patch #1 - Amend documentation for libretech cc v2 Jerome Brunet (2): arm64: dts: import libretech-cc-v2 from linux v5.10-rc1

Re: [PATCH v2 0/2] arm64: meson: add libretech cc v2 support

2020-11-06 Thread Jerome Brunet
On Fri 06 Nov 2020 at 10:29, Neil Armstrong wrote: > Hi, > > On 06/11/2020 10:07, Jerome Brunet wrote: >> This patchset adds support for the Amlogic based libretech cc v2. >> Like the v1, this revised platform used the s905x SoC. >> >> Changes since v1: >

[PATCH v2 1/2] arm64: dts: import libretech-cc-v2 from linux v5.10-rc1

2020-11-06 Thread Jerome Brunet
Sync the libretech cc v2 device tree from Linux v5.10-rc1 commit 3650b228f83a ("Linux 5.10-rc1") Signed-off-by: Jerome Brunet --- .../dts/meson-gxl-s905x-libretech-cc-v2.dts | 318 ++ 1 file changed, 318 insertions(+) create mode 100644 arch/arm/dts/meson-gxl-s905x

[PATCH v2 2/2] arm64: meson: add support for libretech-cc v2

2020-11-06 Thread Jerome Brunet
Add support for the Amlogic based libretech cc version 2. As version 1, it is based on the s905x SoC. Signed-off-by: Jerome Brunet --- arch/arm/dts/Makefile | 1 + ...eson-gxl-s905x-libretech-cc-v2-u-boot.dtsi | 7 ++ configs/libretech-cc_v2_defconfig | 82

[PATCH v2 0/2] arm64: meson: add libretech cc v2 support

2020-11-06 Thread Jerome Brunet
This patchset adds support for the Amlogic based libretech cc v2. Like the v1, this revised platform used the s905x SoC. Changes since v1: - Move Makefile change to patch #1 - Amend documentation for libretech cc v2 Jerome Brunet (2): arm64: dts: import libretech-cc-v2 from linux v5.10-rc1

Re: [PATCH 2/2] arm64: meson: add support for libretech-cc v2

2020-11-05 Thread Jerome Brunet
On Thu 05 Nov 2020 at 15:22, Neil Armstrong wrote: > Hi, > > On 05/11/2020 15:15, Jerome Brunet wrote: >> Add support for the Amlogic based libretech cc version 2. >> As version 1, it is based on the s905x SoC. >> >> Signed-off-by: Jerome Brunet

[PATCH 2/2] arm64: meson: add support for libretech-cc v2

2020-11-05 Thread Jerome Brunet
Add support for the Amlogic based libretech cc version 2. As version 1, it is based on the s905x SoC. Signed-off-by: Jerome Brunet --- arch/arm/dts/Makefile | 1 + ...eson-gxl-s905x-libretech-cc-v2-u-boot.dtsi | 7 ++ configs/libretech-cc_v2_defconfig | 82

[PATCH 1/2] arm64: dts: import libretech-cc-v2 from linux v5.10-rc1

2020-11-05 Thread Jerome Brunet
Sync the libretech cc v2 device tree from Linux v5.10-rc1 commit 3650b228f83a ("Linux 5.10-rc1") Signed-off-by: Jerome Brunet --- .../dts/meson-gxl-s905x-libretech-cc-v2.dts | 318 ++ 1 file changed, 318 insertions(+) create mode 100644 arch/arm/dts/meson-gxl-s905x

[PATCH 0/2] arm64: meson: add libretech cc v2 support

2020-11-05 Thread Jerome Brunet
This patchset adds support for the Amlogic based libretech cc v2. Like the v1, this revised platform used the s905x SoC. Jerome Brunet (2): arm64: dts: import libretech-cc-v2 from linux v5.10-rc1 arm64: meson: add support for libretech-cc v2 arch/arm/dts/Makefile

[PATCH] edid: investigate dtd from cea861 extension if necessary

2020-11-03 Thread Jerome Brunet
If no valid detailed timing can be found in the edid base block, check the detailed timing provided in the cea861 extension block, if any. Reported-by: Da Xue Tested-by: Da Xue Signed-off-by: Jerome Brunet --- common/edid.c | 72 +++ 1 file

Re: [PATCH] ARM: dts: add missing meson-gxl-s805x-libretech-ac-u-boot.dtsi file

2020-04-15 Thread Jerome Brunet
On Wed 15 Apr 2020 at 17:58, Neil Armstrong wrote: > The libretech-ac u-boot.dtsi file is missing to enabled DT nodes changes > to enable Video output on U-Boot. > > Fixes: 671b1db8f8 ("arm64: dts: meson-gx: vpu should be probed before > relocation") > Reported-by:

[PATCH v3 4/6] arm64: dts: meson: sync dt and bindings from v5.6-rc2

2020-03-05 Thread Jerome Brunet
Sync the device tree and dt-bindings from Linux v5.6-rc2 11a48a5a18c6 ("Linux 5.6-rc2") The only exception to this is the mmc pinctrl pin bias of gxl SoC family. This is a fix which found its way to u-boot but not Linux yet. Acked-by: Neil Armstrong Signed-off-by: Jerome Brunet ---

[PATCH v3 5/6] arm64: dts: meson: import libretech-pc from linux v5.6-rc2

2020-03-05 Thread Jerome Brunet
Sync the libretech-pc device tree from Linux v5.6-rc2 11a48a5a18c6 ("Linux 5.6-rc2") Acked-by: Neil Armstrong Signed-off-by: Jerome Brunet --- arch/arm/dts/meson-gx-libretech-pc.dtsi | 375 ++ arch/arm/dts/meson-gxl-s905d-libretech-pc.dts | 16 + arch/arm/dts

[PATCH v3 2/6] mmc: meson-gx: enable input clocks

2020-03-05 Thread Jerome Brunet
controller. While the u-boot mmc controller driver is not doing fancy settings like the Linux, it at least needs to make these clocks are running. Reviewed-by: Neil Armstrong Signed-off-by: Jerome Brunet --- drivers/mmc/meson_gx_mmc.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion

[PATCH v3 6/6] arm64: dts: meson: add libretech-pc support

2020-03-05 Thread Jerome Brunet
Add support for the Amlogic based libretech-pc platform. This platform comes with 2 variant, based on the s905d or s912 SoC. Acked-by: Neil Armstrong Signed-off-by: Jerome Brunet --- arch/arm/dts/Makefile | 2 + .../meson-gxl-s905d-libretech-pc-u-boot.dtsi | 7

[PATCH v3 3/6] clk: meson: reset mmc clock on probe

2020-03-05 Thread Jerome Brunet
-off-by: Jerome Brunet --- drivers/clk/meson/axg.c | 7 +++ drivers/clk/meson/g12a.c | 7 +++ drivers/clk/meson/gxbb.c | 7 +++ 3 files changed, 21 insertions(+) diff --git a/drivers/clk/meson/axg.c b/drivers/clk/meson/axg.c index 7035b59a1379..4b0028d04bf6 100644 --- a/drivers/clk

[PATCH v3 1/6] dt-bindings: leds: import common led bindings from linux v5.5

2020-03-05 Thread Jerome Brunet
Import the common leds bindings definition from linux d5226fa6dbae ("Linux 5.5") Reviewed-by: Neil Armstrong Signed-off-by: Jerome Brunet --- include/dt-bindings/leds/common.h | 75 +++ 1 file changed, 75 insertions(+) create mode 100644 include/dt-bin

[PATCH v3 0/6] arm64: meson: add libretech-pc support

2020-03-05 Thread Jerome Brunet
if it is not the original purpose of this series. Changes since v2: - actually rebase on master Changes since v1: - Split dt sync, libretech-pc import and config addition. - Rebase on master (... not really) Jerome Brunet (6): dt-bindings: leds: import common led bindings from linux v5.5 mmc: meson-gx

Re: [PATCH v2 6/6] arm64: dts: meson: add libretech-pc support

2020-03-02 Thread Jerome Brunet
On Mon 02 Mar 2020 at 10:52, Neil Armstrong wrote: > On 02/03/2020 10:34, Neil Armstrong wrote: >> On 27/02/2020 12:27, Jerome Brunet wrote: > > The defconfig fails with : > scripts/kconfig/conf --syncconfig Kconfig > .config:164:warning: symbol value '' invalid for EN

[PATCH v2 4/6] arm64: dts: meson: sync dt and bindings from v5.6-rc2

2020-02-27 Thread Jerome Brunet
Sync the device tree and dt-bindings from Linux v5.6-rc2 11a48a5a18c6 ("Linux 5.6-rc2") The only exception to this is the mmc pinctrl pin bias of gxl SoC family. This is a fix which found its way to u-boot but not Linux yet. Signed-off-by: Jerome Brunet --- arch/arm/dts/meson-ax

[PATCH v2 3/6] clk: meson: reset mmc clock on probe

2020-02-27 Thread Jerome Brunet
-off-by: Jerome Brunet --- drivers/clk/meson/axg.c | 7 +++ drivers/clk/meson/g12a.c | 7 +++ drivers/clk/meson/gxbb.c | 7 +++ 3 files changed, 21 insertions(+) diff --git a/drivers/clk/meson/axg.c b/drivers/clk/meson/axg.c index 32cbf752aed8..0ba6c303e122 100644 --- a/drivers/clk

[PATCH v2 6/6] arm64: dts: meson: add libretech-pc support

2020-02-27 Thread Jerome Brunet
Add support for the Amlogic based libretech-pc platform. This platform comes with 2 variant, based on the s905d or s912 SoC. Signed-off-by: Jerome Brunet --- arch/arm/dts/Makefile | 2 + .../meson-gxl-s905d-libretech-pc-u-boot.dtsi | 7 ++ .../meson-gxm-s912-libretech

[PATCH v2 5/6] arm64: dts: meson: import libretech-pc from linux v5.6-rc2

2020-02-27 Thread Jerome Brunet
Sync the libretech-pc device tree from Linux v5.6-rc2 11a48a5a18c6 ("Linux 5.6-rc2") Signed-off-by: Jerome Brunet --- arch/arm/dts/meson-gx-libretech-pc.dtsi | 375 ++ arch/arm/dts/meson-gxl-s905d-libretech-pc.dts | 16 + arch/arm/dts/meson-gxl-

[PATCH v2 1/6] dt-bindings: leds: import common led bindings from linux v5.5

2020-02-27 Thread Jerome Brunet
Import the common leds bindings definition from linux d5226fa6dbae ("Linux 5.5") Reviewed-by: Neil Armstrong Signed-off-by: Jerome Brunet --- include/dt-bindings/leds/common.h | 75 +++ 1 file changed, 75 insertions(+) create mode 100644 include/dt-bin

[PATCH v2 2/6] mmc: meson-gx: enable input clocks

2020-02-27 Thread Jerome Brunet
controller. While the u-boot mmc controller driver is not doing fancy settings like the Linux, it at least needs to make these clocks are running. Reviewed-by: Neil Armstrong Signed-off-by: Jerome Brunet --- drivers/mmc/meson_gx_mmc.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion

[PATCH v2 0/6] arm64: meson: add libretech-pc support

2020-02-27 Thread Jerome Brunet
if it is not the original purpose of this series. Changes since v1: - Split dt sync, libretech-pc import and config addition. - Rebase on master Jerome Brunet (6): dt-bindings: leds: import common led bindings from linux v5.5 mmc: meson-gx: enable input clocks clk: meson: reset mmc clock on probe

Re: [PATCHv6 1/5] mmc: meson-gx: Fix clk phase tuning for MMC

2020-02-10 Thread Jerome Brunet
On Sun 09 Feb 2020 at 18:22, Anand Moon wrote: > Hi Neil, > > Thanks for you review comments. > > On Sun, 9 Feb 2020 at 18:38, Neil Armstrong wrote: >> >> Hi, >> >> Le 09/02/2020 à 12:05, Anand Moon a écrit : >> > As per mainline line kernel fix the clk tuning phase for mmc, >> > set

Re: [PATCHv5 1/5] mmc: meson-gx: Fix clk phase tuning for MMC

2020-02-03 Thread Jerome Brunet
On Mon 03 Feb 2020 at 17:38, Anand Moon wrote: > Hi Jerome, > > Thanks for your review, > > On Mon, 3 Feb 2020 at 21:11, Jerome Brunet wrote: >> >> >> On Mon 03 Feb 2020 at 16:13, Anand Moon wrote: >> >> > As per mainline line kernel fix the

Re: [PATCHv5 1/5] mmc: meson-gx: Fix clk phase tuning for MMC

2020-02-03 Thread Jerome Brunet
On Mon 03 Feb 2020 at 16:13, Anand Moon wrote: > As per mainline line kernel fix the clk tuning phase for mmc, > set Core=180, Tx=180, Rx=0 clk phase for mmc initialization. > As per S905, S905X, AGX and S922X datasheet set the default > values for clk tuning. > > Signed-off-by: Anand Moon >

Re: [PATCHv3 1/3] mmc: meson-gx: Fix clk phase tuning for MMC

2020-01-07 Thread Jerome Brunet
On Thu 26 Dec 2019 at 12:33, Anand Moon wrote: > As per mainline line kernel fix the clk tunnig phase for > mmc, set Core=180, Tx=0, Rx=0 clk phase for mmc initialization. > > Signed-off-by: Anand Moon > --- > Changes from previous > v2: Fix the clk phase macro to support PHASE_180 > drop

Re: [U-Boot] [PATCHv2 1/3] mmc: meson-gx: Fix clk phase tuning for MMC

2019-12-26 Thread Jerome Brunet
On Tue 24 Dec 2019 at 14:25, Anand Moon wrote: > As per mainline line kernel fix the clk tunnig phase for > mmc, set Core=180, Tx=0, Rx=0 clk phase for mmc initialization. > > Signed-off-by: Anand Moon > --- > Changes from previous > use the mainline kernel tuning for clk tuning. > Fixed the

Re: [U-Boot] [PATCH 1/4] mmc: meson-gx: Fix tx phase in the tuning process

2019-12-20 Thread Jerome Brunet
On Fri 20 Dec 2019 at 19:47, Anand Moon wrote: > Hi Neil, + Jerome, > > On Sat, 21 Dec 2019 at 00:28, Anand Moon wrote: >> >> Hi Neil, >> >> > Could you try the following patches instead of this one ? >> > >> > https://patchwork.ozlabs.org/patch/1213648/ >> >

[PATCH 5/5] arm64: dts: meson: add libretech-pc support

2019-12-19 Thread Jerome Brunet
Add support for the Amlogic based libretech-pc platform. This platform comes with 2 variant, based on the s905d or s912 SoC. Signed-off-by: Jerome Brunet --- arch/arm/dts/Makefile | 2 + arch/arm/dts/meson-gx-libretech-pc.dtsi | 376 ++ .../meson

[PATCH 3/5] clk: meson: reset mmc clock on probe

2019-12-19 Thread Jerome Brunet
On some SoCs, depending on the boot device, the MMC clock block may be left in a weird state by the ROM code, in which no decent clock may be provided. Reset the related register to make sure a sane MMC clock is ready for the controller. Signed-off-by: Jerome Brunet --- drivers/clk/meson/axg.c

[PATCH 4/5] arm64: dts: meson: gxl: add i2c C pins

2019-12-19 Thread Jerome Brunet
Add dv18 i2c C pins on the gxl SoC Signed-off-by: Jerome Brunet --- arch/arm/dts/meson-gxl.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/dts/meson-gxl.dtsi b/arch/arm/dts/meson-gxl.dtsi index d5c3d78aafeb..4ef11e5381d8 100644 --- a/arch/arm/dts/meson-gxl.dtsi +++ b

[PATCH 0/5] arm64: meson: add libretech-pc support

2019-12-19 Thread Jerome Brunet
, the ROM code will leave the mmc clocks in such a weird state that any access to the mmc controller would lock the device. Making sure the MMC clocks are properly reset and enabled is enough to solve the problem. [0]: https://lkml.kernel.org/r/7h5zig82ha@baylibre.com Jerome Brunet (5): dt

[PATCH 1/5] dt-bindings: leds: import common led bindings from linux v5.4

2019-12-19 Thread Jerome Brunet
Import the common leds bindings definition from linux v5.4 Signed-off-by: Jerome Brunet --- include/dt-bindings/leds/common.h | 75 +++ 1 file changed, 75 insertions(+) create mode 100644 include/dt-bindings/leds/common.h diff --git a/include/dt-bindings/leds

[PATCH 2/5] mmc: meson-gx: enable input clocks

2019-12-19 Thread Jerome Brunet
controller. While the u-boot mmc controller driver is not doing fancy settings like the Linux, it at least needs to make these clocks are running. Signed-off-by: Jerome Brunet --- drivers/mmc/meson_gx_mmc.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/mmc

[U-Boot] [PATCH u-boot] pinctrl: meson: add pinconf support

2019-01-04 Thread Jerome Brunet
Adding pinconf support is necessary to enable boot from SPI without breaking the eMMC. When booting from SPI, the ROM code leave pull downs on the eMMC pad. We need to set pinconf provided in DT to solve this Signed-off-by: Jerome Brunet --- drivers/pinctrl/meson/Kconfig | 1

Re: [U-Boot] [PATCH u-boot] arm: dts: s400: Fix status for eMMC and SDIO ports

2018-12-19 Thread Jerome Brunet
ed-off-by: Neil Armstrong Tested-by: Jerome Brunet > --- > arch/arm/dts/meson-axg-s400-u-boot.dtsi | 14 ++ > 1 file changed, 14 insertions(+) > create mode 100644 arch/arm/dts/meson-axg-s400-u-boot.dtsi > > diff --git a/arch/arm/dts/meson-axg-s400-u-boot.dtsi b

Re: [U-Boot] [PATCH] pinctrl: meson: Fix GPIO direction registers access

2018-12-04 Thread Jerome Brunet
gt;reg_gpio + reg, BIT(bit), 0); > + clrbits_le32(priv->reg_gpio + reg, BIT(bit)); > > ret = meson_gpio_calc_reg_and_bit(dev, offset, REG_OUT, , ); > if (ret) Reviewed-by: Jerome Brunet ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH u-boot v3 0/3] Add Amlogic Meson SPI Flash Controller driver

2018-11-15 Thread Jerome Brunet
+ > drivers/spi/meson_spifc.c | 330 ++ > include/regmap.h | 38 + > test/dm/regmap.c | 26 +++ > 5 files changed, 403 insertions(+) > create mode 100644 drivers/spi/meson_spifc.c > Tested-by: Jerome Brunet ... on the

Re: [U-Boot] [PATCH 0/3] GPIO support for Meson GXBB and Odroid-C2

2017-06-26 Thread Jerome Brunet
On Sun, 2017-06-25 at 17:55 +0200, Beniamino Galvani wrote: > Hi, > > this series adds a GPIO driver for Meson GXBB and enables it on > Odroid-C2. > > Beniamino Galvani (3): >   arm: dts: meson: import dts files from Linux 4.12-rc6 >   pinctrl: meson: add GPIO support >   odroid-c2: enable GPIO