RE: [PATCH v2 1/4] mmc: pic32: Refresh PIC32 MMC driver

2020-09-02 Thread John Robertson
> Am Montag, den 31.08.2020, 18:04 + schrieb John Robertson: > > The existing driver is not compatible with the Driver Model. > > > > This patch makes the necessary changes while also removing obsolescent > > calls/properties as follows: > > > > -

RE: [PATCH v2 4/4] mmc: pic32: Refresh PIC32 MMC driver

2020-09-02 Thread John Robertson
> Am Montag, den 31.08.2020, 18:04 + schrieb John Robertson: > > CONFIG_BLK needs to be enabled by default to allow U-Boot to compile > > after a 'make pic32mzdask_defconfig'. > > > > Signed-off-by: John Robertson > > --- > > > > conf

[PATCH v2 2/2] mips: dts: Fix PIC32MZDA GPIO register definitions

2020-09-01 Thread John Robertson
On the PIC32, there is no Bank I so instances 8 and 9 need to be incremented as a minimum change. An alternative (less opaque) implementation would be to use a bank-name property instead but this would require modifying the driver code too. Signed-off-by: John Robertson --- arch/mips/dt

[PATCH v2 1/2] mips: dts: Fix PIC32MZDA GPIO register definitions

2020-09-01 Thread John Robertson
nally, the data sheet (Microchip ref. 60001361H) shows that the register set to control a GPIO bank spans 0xE0 bytes, but the device tree specified size is only 0x48 bytes. Signed-off-by: John Robertson --- Changes in v2 - Split patch - Document change more fully arch/mips/dts/pic32mzda

[PATCH] mips: dts: Fix device tree warnings for PIC32MZDA

2020-09-01 Thread John Robertson
Signed-off-by: John Robertson --- arch/mips/dts/pic32mzda.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/mips/dts/pic32mzda.dtsi b/arch/mips/dts/pic32mzda.dtsi index 4c8b7a9a0b..8aff9eb812 100644 --- a/arch/mips/dts/pic32mzda.dtsi +++ b/arch/mips/dts/pic32mzda.dtsi

[PATCH v3 2/4] mmc: pic32: Refresh PIC32 MMC driver

2020-08-31 Thread John Robertson
The GPIO pins used by the SDHCI controller need to be configured to allow the interface to work. Signed-off-by: John Robertson --- drivers/pinctrl/pinctrl_pic32.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/pinctrl/pinctrl_pic32.c b/drivers/pinctrl

[PATCH v3 4/4] mmc: pic32: Refresh PIC32 MMC driver

2020-08-31 Thread John Robertson
CONFIG_BLK needs to be enabled by default to allow U-Boot to compile after a 'make pic32mzdask_defconfig'. Signed-off-by: John Robertson --- Changes in v3 - address review comment from Daniel Schwierzeck - This file should have been generated by 'make savedefconfig' rather

[PATCH v3 3/4] mmc: pic32: Refresh PIC32 MMC driver

2020-08-31 Thread John Robertson
The PIC32MZ DA Starter Kit does not need the card detect workaround because the SDCD signal line is connected properly. Disable the workaround in this case. Signed-off-by: John Robertson --- arch/mips/dts/pic32mzda_sk.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/mips/dts

[PATCH v3 1/4] mmc: pic32: Refresh PIC32 MMC driver

2020-08-31 Thread John Robertson
y of the source clock 'base_clk'; - The card detect erratum workaround is applied during probe rather than overriding get_cd. The card detect workaround (Microchip ref. DS8736E, erratum #15) is not always needed and can be disabled using a vendor specific DT property. Signed-of

[PATCH v2 4/4] mmc: pic32: Refresh PIC32 MMC driver

2020-08-31 Thread John Robertson
CONFIG_BLK needs to be enabled by default to allow U-Boot to compile after a 'make pic32mzdask_defconfig'. Signed-off-by: John Robertson --- configs/pic32mzdask_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configs/pic32mzdask_defconfig

[PATCH v2 3/4] mmc: pic32: Refresh PIC32 MMC driver

2020-08-31 Thread John Robertson
The PIC32MZ DA Starter Kit does not need the card detect workaround because the SDCD signal line is connected properly. Disable the workaround in this case. Signed-off-by: John Robertson --- arch/mips/dts/pic32mzda_sk.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/mips/dts

[PATCH v2 1/4] mmc: pic32: Refresh PIC32 MMC driver

2020-08-31 Thread John Robertson
ng a vendor specific DT property. Signed-off-by: John Robertson --- Changes in v2: - Split patch; - Fix compilation failure after 'make pic32mzdask_defconfig'. drivers/mmc/pic32_sdhci.c | 77 --- 1 file changed, 48 insertions(+), 29 deletion

[PATCH v2 2/4] mmc: pic32: Refresh PIC32 MMC driver

2020-08-31 Thread John Robertson
The GPIO pins used by the SDHCI controller need to be configured to allow the interface to work. Signed-off-by: John Robertson --- drivers/pinctrl/pinctrl_pic32.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/pinctrl/pinctrl_pic32.c b/drivers/pinctrl

[PATCH] mips: dts: Fix PIC32MZDA GPIO register definitions and dtc warnings

2020-08-22 Thread John Robertson
Currently GPIO operations (e.g. gpio status -a) don't work at all. Signed-off-by: John Robertson --- arch/mips/dts/pic32mzda.dtsi | 58 +--- 1 file changed, 34 insertions(+), 24 deletions(-) diff --git a/arch/mips/dts/pic32mzda.dtsi b/arch/mip

[PATCH] mmc: pic32: PIC32MZDA SDHCI controller non-functional

2020-08-22 Thread John Robertson
ed as described in erratum #16, but this does not apply to U-Boot because it uses the card inserted CARDINS flag. Therefore, 'cd-inverted' is not required. Signed-off-by: John Robertson --- arch/mips/dts/pic32mzda_sk.dts | 1 + drivers/mmc/pic32_sdhci.c | 77 ++