[U-Boot] [PATCH v2] fdt: Fix mkimage list to try every header type

2019-04-10 Thread Jordan Hand
-imagetools.sh Signed-off-by: Jordan Hand Tested-by: Alex Kiernan Tested-by: Vagrant Cascadian --- Changes in v2: - Fix patch formatting to move commit message above the cut tools/mkimage.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/tools/mkimage.c

Re: [U-Boot] [PATCH v1] fdt: Fix mkimage list to try every header type

2019-04-10 Thread Jordan Hand
On Wed, Apr 10, 2019 at 1:52 AM Alex Kiernan wrote: > > On Tue, Apr 9, 2019 at 6:36 PM Jordan Hand wrote: > > > > Signed-off-by: Jordan Hand > > --- > > Image type is not supplied to `mkimage -l`. For this reason, we cannot > > use imagetool_verify_print_head

Re: [U-Boot] [PATCH] Revert "fdt: Fix FIT header verification in mkimage and conduct same checks as bootm"

2019-04-09 Thread Jordan Hand
(Forgot to reply all. Sorry for the clutter Vagrant) See the patch I just submitted "fdt: Fix mkimage list to try every header type" for what I believe to be the correct fix for this problem. Thanks, Jordan > > On Mon, Apr 8, 2019 at 9:54 PM Vagrant Cascadian wrote: > > > > This reverts commit

[U-Boot] [PATCH v1] fdt: Fix mkimage list to try every header type

2019-04-09 Thread Jordan Hand
Signed-off-by: Jordan Hand --- Image type is not supplied to `mkimage -l`. For this reason, we cannot use imagetool_verify_print_header_by_type. Instead, this patch uses imagetool_verify_print_header to look through all header types to find one where image validation succeeds. This patch fixes

Re: [U-Boot] [PATCH] Revert "fdt: Fix FIT header verification in mkimage and conduct same checks as bootm"

2019-04-09 Thread Jordan Hand
On Mon, Apr 8, 2019 at 9:54 PM Vagrant Cascadian wrote: > > This reverts commit d32aa3cae44e618048ff7f378577d44f9b6d6dcc. > > This breaks the "list_image" test in tests/image/test-imagetools.sh, > where mkimage and dumpimage are expected to have the same output: > > Listing image contents... >

[U-Boot] [PATCH v2, RESEND] fdt: Fix FIT header verification in mkimage and conduct same checks as bootm

2019-03-05 Thread Jordan Hand
Signed-off-by: Jordan Hand --- FIT header verification in mkimage was treating a return code as a boolean, which meant that failures in validating the fit were seen as successes. Additionally, mkimage was checking all formats to find a header which passes validation, rather than using the image

[U-Boot] [PATCH v2] fdt: Fix FIT header verification in mkimage and conduct same checks as bootm

2019-02-21 Thread Jordan Hand
Signed-off-by: Jordan Hand --- FIT header verification in mkimage was treating a return code as a boolean, which meant that failures in validating the fit were seen as successes. Additionally, mkimage was checking all formats to find a header which passes validation, rather than using the image

[U-Boot] [PATCH] fdt: Fix FIT header verification in mkimage and conduct same checks as bootm V2

2019-02-19 Thread Jordan Hand
Signed-off-by: Jordan Hand --- FIT header verification in mkimage was treating a return code as a boolean, which meant that failures in validating the fit were seen as successes. Additionally, mkimage was checking all formats to find a header which passes validation, rather than using the image